Re: [libvirt] [PATCH 4/4] lxc: store tty pid

On Thu, May 29, 2008 at 03:44:24PM -0700, Dave Leskovec wrote: > er, this time with the patch > > Dave Leskovec wrote: > > This patch will use a file in the lxc configuration directory to store the > > tty > > forwarding process pid. The pid is stored after the process is fork()'d. > > It'

Re: [libvirt] [PATCH 3/4] lxc: validate container process during load config

On Thu, May 29, 2008 at 03:20:15PM -0700, Dave Leskovec wrote: > This patch adds a check that validates that the container process pid still > exists. This should catch cases where the container exits while libvirtd is > down. sounds fine, > +/** > + * lxcCheckContainerProcess: > + * @def: Pt

Re: [libvirt] [PATCH 2/4] lxc: ignore ECHILD errors during vm cleanup

On Thu, May 29, 2008 at 03:20:10PM -0700, Dave Leskovec wrote: > This patch ignores ECHILD from waitpid(). This can happen if libvirtd was > restarted and the container processes are no longer the children of libvirtd. Looks fine to me too, +1, Daniel -- Red Hat Virtualization group http://r

Re: [libvirt] [PATCH 1/4] lxc: validate tty pid before kill()

On Thu, May 29, 2008 at 03:20:05PM -0700, Dave Leskovec wrote: > This patch adds a check of the tty forwarding process pid before kill()'ing it > when destroying a domain. If the pid value stored in the the vm structure is > invalid, sending a SIGKILL may be very bad if the value in question is >

Re: [libvirt] [PATCH 4/4] lxc: store tty pid

er, this time with the patch Dave Leskovec wrote: > This patch will use a file in the lxc configuration directory to store the tty > forwarding process pid. The pid is stored after the process is fork()'d. > It's > loaded during startup when the config for a running container is loaded. Th

[libvirt] [PATCH 4/4] lxc: store tty pid

This patch will use a file in the lxc configuration directory to store the tty forwarding process pid. The pid is stored after the process is fork()'d. It's loaded during startup when the config for a running container is loaded. The file is deleted when the domain is undefined. This should avo

[libvirt] [PATCH 3/4] lxc: validate container process during load config

This patch adds a check that validates that the container process pid still exists. This should catch cases where the container exits while libvirtd is down. -- Best Regards, Dave Leskovec IBM Linux Technology Center Open Virtualization --- src/lxc_conf.c | 46 ++

[libvirt] [PATCH 1/4] lxc: validate tty pid before kill()

This patch adds a check of the tty forwarding process pid before kill()'ing it when destroying a domain. If the pid value stored in the the vm structure is invalid, sending a SIGKILL may be very bad if the value in question is something like -1 (which just happens to be it's initial value). -- B

[libvirt] [PATCH 0/4] lxc: cope with libvirtd restart

This set of patches fixes a few items that occur as a result of a restart of libvirtd when containers are running. While this may not be a common situation, the consequences of some of these (particularly losing the tty forwarding process pid and later trying to kill it) can be quite severe. --

[libvirt] [PATCH 2/4] lxc: ignore ECHILD errors during vm cleanup

This patch ignores ECHILD from waitpid(). This can happen if libvirtd was restarted and the container processes are no longer the children of libvirtd. -- Best Regards, Dave Leskovec IBM Linux Technology Center Open Virtualization --- src/lxc_driver.c |4 ++-- 1 file changed, 2 insertions(

Re: [libvirt] [PATCH] fix trailing blanks

On Thu, May 29, 2008 at 01:35:55PM +0900, Atsushi SAKAI wrote: > Hi, Rich > > Fix trailing blanks. This patch broke the test suite - the virsh command was generating data with trailing blanks. So I've added the following patch too, which stops it generating blanks Dan. Index: src/virsh.c =

Re: [libvirt] [PATCH] fix trailing blanks

Hi, Daniel Thank you. I already commited. By the way, Test-AutoBuild is great tool , since it generates RSS for failed module only. Thanks Atsushi SAKAI Daniel Veillard <[EMAIL PROTECTED]> wrote: > On Thu, May 29, 2008 at 01:35:55PM +0900, Atsushi SAKAI wrote: > > Hi, Rich > > > > Fix traili

Re: [libvirt] [PATCH] fix trailing blanks

On Thu, May 29, 2008 at 01:35:55PM +0900, Atsushi SAKAI wrote: > Hi, Rich > > Fix trailing blanks. > > http://builder.virt-manager.org/module-libvirt--devel.html +1 , please push the fix, thanks ! Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard