Re: [libvirt] Re: [Libvir] Reopening the old discussion about virDomainBlockPeek

2008-06-06 Thread Jim Meyering
"Richard W.M. Jones" <[EMAIL PROTECTED]> wrote: > Attached is an updated patch. The changes are: > - updated to latest CVS > - run make check / syntax-check > - remove virsh subcommand (as per Dan's suggestion - see below) > - some more things that Dan pointed out - see below ... > Index: src/

Re: [libvirt] PATCH: Fix check for inactive network

2008-06-06 Thread Richard W.M. Jones
On Fri, Jun 06, 2008 at 02:31:10PM +0100, Daniel P. Berrange wrote: > When building up the QEMU command line args we forgot to check for a NULL > when creating the TAP device arg. This can happen if the network being > connected to the VM is not running. This is something I broke in the > refactori

[libvirt] PATCH: Fix check for inactive network

2008-06-06 Thread Daniel P. Berrange
When building up the QEMU command line args we forgot to check for a NULL when creating the TAP device arg. This can happen if the network being connected to the VM is not running. This is something I broke in the refactoring of the ARGV construction in the QEMU driver. Dan. Index: src/qemu_conf.

Re: [libvirt] Question about compilation on MinGW(StorageAPI)

2008-06-06 Thread Daniel P. Berrange
On Fri, Jun 06, 2008 at 10:03:41PM +0900, Atsushi SAKAI wrote: > Hi, Dan > > Thank you, I remenber the Mail from Rich. > http://www.redhat.com/archives/libvir-list/2008-January/msg00017.html > virsh seems working again. > > Current problem on MinGW are 2points(These are avoidable on manually). >

Re: [libvirt] Question about compilation on MinGW(StorageAPI)

2008-06-06 Thread Atsushi SAKAI
Hi, Dan Thank you, I remenber the Mail from Rich. http://www.redhat.com/archives/libvir-list/2008-January/msg00017.html virsh seems working again. Current problem on MinGW are 2points(These are avoidable on manually). 1) siginfo_t should comment out.(it effects driver.h/internal.h/libvirt.c on

Re: [libvirt] [PATCH] virDomainMemoryPeek - peek into guest memory

2008-06-06 Thread Richard W.M. Jones
On Fri, Jun 06, 2008 at 11:25:41AM +0100, Daniel P. Berrange wrote: > On Thu, Jun 05, 2008 at 10:30:55PM +0100, Richard W.M. Jones wrote: > > > > +/* Memory peeking flags. */ > > +typedef enum { > > + VIR_MEMORY_VIRTUAL = 1, /* addresses are virtual addresses > > */ > > +} virDomai

Re: [libvirt] Question about compilation on MinGW(StorageAPI)

2008-06-06 Thread Daniel P. Berrange
On Fri, Jun 06, 2008 at 07:34:32PM +0900, Atsushi SAKAI wrote: > Hi, Rich and Dan > > I have a question about libvirt on MinGW. > As you know, MinGW supports remote management only. > In this situation, Storage API(dir) should be off. > Can I configure it? or other way exists? The storage APIs wi

[libvirt] Question about compilation on MinGW(StorageAPI)

2008-06-06 Thread Atsushi SAKAI
Hi, Rich and Dan I have a question about libvirt on MinGW. As you know, MinGW supports remote management only. In this situation, Storage API(dir) should be off. Can I configure it? or other way exists? One more question on MinGW with Ruby, Does someone already test the Ruby bindings on MinGW? I

Re: [libvirt] PATCH: Switch all remaining code to memory alloc APIs

2008-06-06 Thread Daniel P. Berrange
On Mon, Jun 02, 2008 at 04:35:47PM +0200, Jim Meyering wrote: > "Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: > > This patch switches all remaining code over to use the memory allocation > > APIs, with exception of virsh which is going to be slightly more complex > > > > It was mostly a straight

Re: [libvirt] [PATCH] virDomainMemoryPeek - peek into guest memory

2008-06-06 Thread Daniel P. Berrange
On Thu, Jun 05, 2008 at 10:30:55PM +0100, Richard W.M. Jones wrote: > > +/* Memory peeking flags. */ > +typedef enum { > + VIR_MEMORY_VIRTUAL = 1, /* addresses are virtual addresses */ > +} virDomainMemoryFlags; Since there is only one flag, and it is compulsory I'm rather inclined

Re: [libvirt] [PATCH] lxc: new tty for container

2008-06-06 Thread Daniel P. Berrange
On Thu, Jun 05, 2008 at 11:59:34PM -0700, Dave Leskovec wrote: > The lxc driver xml parser treats the console element as input when it should > be > output only. This obviously causes problems when anything other than > /dev/ptmx > is specified or when a container is shutdown and then restarted

Re: [libvirt] qemudDomainSetMemory() / qemudDomainSetVcpus() error codes

2008-06-06 Thread Daniel P. Berrange
On Thu, Jun 05, 2008 at 03:38:46PM -0700, Kaitlin Rupert wrote: > Hello, > > I noticed qemudDomainSetMemory() / qemudDomainSetVcpus() use the > VIR_ERR_INTERNAL_ERROR error code when the caller attempts to set the > mem/vcpus of an active domain. > > In this case, returning something like VIR_E