Re: [libvirt] [PATCH] lxc: new tty for container

2008-06-09 Thread Dave Leskovec
Daniel Veillard wrote: > On Fri, Jun 06, 2008 at 10:29:04AM +0100, Daniel P. Berrange wrote: >> On Thu, Jun 05, 2008 at 11:59:34PM -0700, Dave Leskovec wrote: >>> The lxc driver xml parser treats the console element as input when it >>> should be >>> output only. This obviously causes problems wh

[libvirt] [PATCH] Fix enabling storage driver

2008-06-09 Thread Cole Robinson
As of a couple weeks ago, the storage driver is only registered if the WITH_LIBVIRTD macro is defined. The configure option --with-libvirtd actually wasn't defining this macro. The attached patch fixes this. Thanks, Cole diff --git a/configure.in b/configure.in index 47633b0..64c6013 100644 --- a/

Re: [libvirt] what is the net model syntax

2008-06-09 Thread Cole Robinson
Farkas Levente wrote: > hi, > how can i define the emulated network card model in libvirt's xml config > files? i can't find it in the docs. > thanks. > You can see an example of the model syntax in the test xml files used by libvirt: http://git.et.redhat.com/?p=libvirt.git;a=blob;f=tests/qemux

Re: [libvirt] Question about compilation on MinGW(StorageAPI)

2008-06-09 Thread Daniel P. Berrange
On Mon, Jun 09, 2008 at 12:05:09PM +0900, Atsushi SAKAI wrote: > Hi, Dan > > If remove uncompiled code on MinGW, the patch seems like this. > > 0)siginfo_t does not have. > 1)MinGW does not have waitpid, fork etc. > 2)add testutilsqemu.c to check WITH_QEMU > > I need to investigate more? > (Ple

Re: [libvirt] Question about compilation on MinGW(StorageAPI)

2008-06-09 Thread Richard W.M. Jones
On Mon, Jun 09, 2008 at 12:05:09PM +0900, Atsushi SAKAI wrote: > I need to investigate more? > (Please wait a week, if need to investigate this.) > > src/driver.h |4 > src/internal.h|4 > src/libvirt.c |3 ++- > tests/testutils.c |9

Re: [libvirt] Question about compilation on MinGW(StorageAPI)

2008-06-09 Thread Richard W.M. Jones
On Fri, Jun 06, 2008 at 10:03:41PM +0900, Atsushi SAKAI wrote: > Thank you, I remenber the Mail from Rich. > http://www.redhat.com/archives/libvir-list/2008-January/msg00017.html > virsh seems working again. > > Current problem on MinGW are 2points(These are avoidable on manually). > > 1) siginfo

Re: [libvirt] [PATCH] virDomainMemoryPeek - peek into guest memory

2008-06-09 Thread Richard W.M. Jones
On Mon, Jun 09, 2008 at 01:47:09PM +0100, Richard W.M. Jones wrote: > +struct remote_domain_memory_peek_ret { > +opaque buffer; > +}; Aargh, and this should be REMOTE_DOMAIN_MEMORY_PEEK_BUFFER_MAX instead. Not going well today! Rich. -- Richard Jones, Emerging Technologies, Red Hat http:/

Re: [libvirt] [PATCH] virDomainMemoryPeek - peek into guest memory

2008-06-09 Thread Richard W.M. Jones
On Mon, Jun 09, 2008 at 01:47:09PM +0100, Richard W.M. Jones wrote: [...] > @@ -49,6 +49,7 @@ > #endif > > #include "internal.h" > +#include "memory.h" > #include "qemud.h" > #include "memory.h" > Oops - ignore that fragment. I think an intervening 'cvs update' pulled in an extra part fro

Re: [libvirt] [PATCH] virDomainMemoryPeek - peek into guest memory

2008-06-09 Thread Richard W.M. Jones
Here's a patch which should address all concerns raised, although I left the VIR_MEMORY_VIRTUAL flag because I still think it's important to have it. Please note to whomever is maintaining libvirt in Fedora that there is a change to the specfile. Rich. -- Richard Jones, Emerging Technologies,

Re: [libvirt] Re: [Libvir] Reopening the old discussion about virDomainBlockPeek

2008-06-09 Thread Jim Meyering
"Richard W.M. Jones" <[EMAIL PROTECTED]> wrote: > OK how about this one ... Nice! Where you changed/added things, I prefer your wording. ACK -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] Re: [Libvir] Reopening the old discussion about virDomainBlockPeek

2008-06-09 Thread Richard W.M. Jones
OK how about this one ... Rich. -- Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://et.redhat.com/~rjones/virt-top ? scripts/Makef

[libvirt] Routing

2008-06-09 Thread Dave Walker
Hi, I'm trying to set up routed networking using libvirt0.4.2, but not having much joy, I cannot ping from either the host OS, or elsewhere on the network (or inverse from the guest OS). I would really appreciate some assistance as I haven't been able to find many routing examples. I'm using the

Re: [libvirt] Re: [Libvir] Reopening the old discussion about virDomainBlockPeek

2008-06-09 Thread Jim Meyering
"Richard W.M. Jones" <[EMAIL PROTECTED]> wrote: > Suggested patch attached. Looks fine. Now that you've added the format string argument, we can give diagnostics that are more useful not just to users, but also to those who end up debugging things. > It seems a little bit perverse to have to put

Re: [libvirt] PATCH: Fix check for inactive network

2008-06-09 Thread Daniel Veillard
On Fri, Jun 06, 2008 at 02:31:10PM +0100, Daniel P. Berrange wrote: > When building up the QEMU command line args we forgot to check for a NULL > when creating the TAP device arg. This can happen if the network being > connected to the VM is not running. This is something I broke in the > refactori

Re: [libvirt] Question about compilation on MinGW(StorageAPI)

2008-06-09 Thread Daniel Veillard
On Mon, Jun 09, 2008 at 12:05:09PM +0900, Atsushi SAKAI wrote: > Hi, Dan > > If remove uncompiled code on MinGW, the patch seems like this. > > 0)siginfo_t does not have. > 1)MinGW does not have waitpid, fork etc. > 2)add testutilsqemu.c to check WITH_QEMU > > I need to investigate more? > (Ple

Re: [libvirt] Re: [Libvir] Reopening the old discussion about virDomainBlockPeek

2008-06-09 Thread Jim Meyering
"Richard W.M. Jones" <[EMAIL PROTECTED]> wrote: ... > It seems a little bit perverse to have to put gettext around > "%s: %s" but that's what make syntax-check wants. That is a relatively naive rule that was good enough for the existing uses. It shouldn't be hard to make it grant exceptions like t

Re: [libvirt] [PATCH] lxc: new tty for container

2008-06-09 Thread Daniel Veillard
On Fri, Jun 06, 2008 at 10:29:04AM +0100, Daniel P. Berrange wrote: > On Thu, Jun 05, 2008 at 11:59:34PM -0700, Dave Leskovec wrote: > > The lxc driver xml parser treats the console element as input when it > > should be > > output only. This obviously causes problems when anything other than >

Re: [libvirt] Re: [Libvir] Reopening the old discussion about virDomainBlockPeek

2008-06-09 Thread Richard W.M. Jones
On Fri, Jun 06, 2008 at 05:01:20PM +0200, Jim Meyering wrote: > "Richard W.M. Jones" <[EMAIL PROTECTED]> wrote: > > Attached is an updated patch. The changes are: > > - updated to latest CVS > > - run make check / syntax-check > > - remove virsh subcommand (as per Dan's suggestion - see below)