Re: [libvirt] [PATCH] Pass syntax check for block devices to XenD.

2008-06-16 Thread Atsushi SAKAI
Hi, Hiroyuki This patch is already commited by Rich http://git.et.redhat.com/?p=libvirt.git;a=commitdiff;h=b612d79d5be4a6f4743da4b85d973fc2f92be4bd Thanks Atsushi SAKAI Hiroyuki Kaguchi <[EMAIL PROTECTED]> wrote: > On 2008/06/04 14:17, Hiroyuki Kaguchi wrote: > > Hi, > > > > libvirt doesn't p

Re: [libvirt] [PATCH] Pass syntax check for block devices to XenD.

2008-06-16 Thread Hiroyuki Kaguchi
On 2008/06/04 14:17, Hiroyuki Kaguchi wrote: > Hi, > > libvirt doesn't pass disk information that the device type isn't specified to > XenD and doesn't show the error message either. > However, the error message should be displayed, and XenD should show it. > On this account, I change libvirt that

[libvirt] cannot compile libvirt on Suse 10

2008-06-16 Thread Dmitri Fedorov
Hi guys, I cannot compile libvirt on Suse 10 SP1, xen_unified.c gives error in the xen/xen.h include, lines 579-582, where DEFINE_XEN_GUEST_HANDLE(uint8_t) etc.are. The error says "expected '=', ',', ';', 'asm' or '__attribite'. Any idea what that is or any hint what I am missing please? Thanks

Re: [libvirt] [PATCH 0/5]: Rework iSCSI lun handling

2008-06-16 Thread Stefan de Konink
Daniel P. Berrange schreef: On Mon, Jun 16, 2008 at 04:10:42PM +0200, Stefan de Konink wrote: Chris Lalancette schreef: Stefan de Konink wrote: Chris Lalancette schreef: 4) Further lessen our dependence on direct calls to iscsiadm, in case they change the output in the future. How are you l

Re: [libvirt] [PATCH 0/5]: Rework iSCSI lun handling

2008-06-16 Thread Daniel P. Berrange
On Mon, Jun 16, 2008 at 04:10:42PM +0200, Stefan de Konink wrote: > Chris Lalancette schreef: > >Stefan de Konink wrote: > >>Chris Lalancette schreef: > >>>4) Further lessen our dependence on direct calls to iscsiadm, in case > >>>they > >>>change the output in the future. > >>How are you looking

Re: [libvirt] [PATCH 0/5]: Rework iSCSI lun handling

2008-06-16 Thread Stefan de Konink
Chris Lalancette schreef: Stefan de Konink wrote: Chris Lalancette schreef: 4) Further lessen our dependence on direct calls to iscsiadm, in case they change the output in the future. How are you looking against this previous proposed setup where we will give an updated Makefile to the open-i

Re: [libvirt] [PATCH 0/5]: Rework iSCSI lun handling

2008-06-16 Thread Chris Lalancette
Stefan de Konink wrote: > Chris Lalancette schreef: >> 4) Further lessen our dependence on direct calls to iscsiadm, in case they >> change the output in the future. > > How are you looking against this previous proposed setup where we will > give an updated Makefile to the open-iscsi folks (to

Re: [libvirt] [PATCH 0/5]: Rework iSCSI lun handling

2008-06-16 Thread Stefan de Konink
Chris Lalancette schreef: 4) Further lessen our dependence on direct calls to iscsiadm, in case they change the output in the future. How are you looking against this previous proposed setup where we will give an updated Makefile to the open-iscsi folks (to build libopen-iscsi.so) and implem

[libvirt] [PATCH 5/5]: Rewrite findLuns function

2008-06-16 Thread Chris Lalancette
This rather large patch rewrites the virStorageBackendISCSIFindLUNs() function to only rely on sysfs for finding LUNs, given a session number. Along the way, it also fixes the bug where we wouldn't find LUNs for older kernels (with the block:sda format), and also (possibly) fixes a race condition

[libvirt] [PATCH 4/5]: Move the sendtarget command into the login command

2008-06-16 Thread Chris Lalancette
A small bugfix; we only need to call the iscsiadm sendtarget command when we are first logging in; we don't need to do it for logout. Move the sendtarget command into the Login() function. Changes since last time: 1) Make const char *cmdsendtarget into const char *const cmdsendtarget based on fe

[libvirt] [PATCH 3/5]: Fix up the call to iscsiadm --mode session

2008-06-16 Thread Chris Lalancette
Older versions of iscsiadm didn't support the "-P 0" flag to the "iscsiadm --mode session" command. However, just running "iscsiadm --mode session" seems to work on all version of iscsiadm commands back to FC-6, so just use that. Changes since last time: None Signed-off-by: Chris Lalancette <[EM

[libvirt] [PATCH 2/5]: Cleanup carriage returns in util.c

2008-06-16 Thread Chris Lalancette
In src/util.c, virLog is just a wrapper around fprintf(stderr). Make sure to put line breaks at the end of lines that use virLog() (noticed during testing). Changes since last time: None Signed-off-by: Chris Lalancette <[EMAIL PROTECTED]> diff -urp libvirt.runprogregex/src/util.c libvirt.virLog

[libvirt] [PATCH 1/5]: Return exitstatus from virStorageBackendRunProgRegex

2008-06-16 Thread Chris Lalancette
This patch changes things around so that virStorageBackendRunProgRegex() does *not* virStorageReportError() if the fork()/exec() process it spawned returned a != 0 exit code. Rather, it returns the exitcode in this case, and it is up to the higher level to determine whether this is a fatal error o

[libvirt] [PATCH 0/5]: Rework iSCSI lun handling

2008-06-16 Thread Chris Lalancette
These patches are now better tested, so I'm sending them for review again. To recap, these patches: 1) Do minor cleanup of the existing code 2) Fix a bug where we aren't properly finding the LUNs on pre 2.6.24 kernels 3) Fix a bug seen in oVirt where we race between libvirtd scanning the sysfs

[libvirt] libvirt+avahi domain publication daemon / webhandler

2008-06-16 Thread Stefan de Konink
Hi, As notified before I am working on a daemon that publishes domains and looking in the close future state changes. I have implemented this daemon so my webserver handler is able to figure out where to connect to in the network upon a request. In my opinion this functionality should be in

Re: [libvirt] FYI: Major driver re-factoring imminent...

2008-06-16 Thread Stefan de Konink
On Mon, 16 Jun 2008, Daniel P. Berrange wrote: > This is a quick FYI to say that I've started working on the plan to provide > a single unified XML parser and generator for all hypervisor drivers, in > addition to the virtual network drivers. Very good! This will reduce the complexity of adding f

[libvirt] FYI: Major driver re-factoring imminent...

2008-06-16 Thread Daniel P. Berrange
This is a quick FYI to say that I've started working on the plan to provide a single unified XML parser and generator for all hypervisor drivers, in addition to the virtual network drivers. This is going to cause major churn in the XML routines for xm_internal.c, xml.c, xend_internal.c, test.c, q