Re: [libvirt] [PATCH 1 of 2] Add internal cgroup manipulation functions

2008-10-01 Thread Dan Smith
DB> Both, Xen and QEMU drivers support a virt type of 'hvm'. Ah, gotcha. I didn't realize that just looking at the enum. I've changed it locally. -- Dan Smith IBM Linux Technology Center Open Hypervisor Team email: [EMAIL PROTECTED] pgpewM4wFGN22.pgp Description: PGP signature -- Libvir-lis

Re: [libvirt] [PATCH 1 of 2] Add internal cgroup manipulation functions

2008-10-01 Thread Daniel P. Berrange
On Wed, Oct 01, 2008 at 02:11:24PM -0700, Dan Smith wrote: > DB> Rather than rely on this virt type string - virt type is not > DB> adding enough uniqueness - can still have a (virttype, name) clash > DB> between 2 libvirt drivers. Name is unique per host, per driver, so > DB> we'd want to have >

Re: [libvirt] ./configure issues

2008-10-01 Thread David Brain
Thanks Daniel, It was missing libgcrypt - found the link error in config.log as you described. David. On Oct 1, 2008, at 5:03 PM, Daniel P. Berrange wrote: On Wed, Oct 01, 2008 at 04:58:07PM -0400, David Brain wrote: Hi, Trying to compile libvirt on Centos 5.2, get the following when run

Re: [libvirt] [PATCH 1 of 2] Add internal cgroup manipulation functions

2008-10-01 Thread Dan Smith
DB> Rather than rely on this virt type string - virt type is not DB> adding enough uniqueness - can still have a (virttype, name) clash DB> between 2 libvirt drivers. Name is unique per host, per driver, so DB> we'd want to have DB> $CONTROLLER_MOUNT/libvirt/$DRIVER_NAME/$DOMAIN_NAME Hmm, I'm no

Re: [libvirt] ./configure issues

2008-10-01 Thread Daniel P. Berrange
On Wed, Oct 01, 2008 at 04:58:07PM -0400, David Brain wrote: > Hi, > > Trying to compile libvirt on Centos 5.2, get the following when > running configure: > > > checking for struct _xmlURI.query_raw... no > checking gnutls/gnutls.h usability... yes > checking gnutls/gnutls.h presence... y

Re: [libvirt] [PATCH 1 of 2] Add internal cgroup manipulation functions

2008-10-01 Thread Daniel P. Berrange
On Wed, Oct 01, 2008 at 01:19:03PM -0700, Dan Smith wrote: > This patch adds src/cgroup.{c,h} with support for creating and manipulating > cgroups. > > All groups created with the internal API are forced under $mount/libvirt/ > to keep everything together. The first time a group is created, the l

Re: [libvirt] [PATCH 2 of 2] Use cgroup functions to set resource limits on LXC domains

2008-10-01 Thread Dan Smith
DB> Should use lxcError() here - as things are setup by virExec(), DB> calls to lxcError() call to virRaiseError() which ultimately calls DB> fprintf(). By using lxcError() can we more easily change logging DB> later if needed. Indeed. DB> I think we need to virCgroupRemove() in the error path to

[libvirt] ./configure issues

2008-10-01 Thread David Brain
Hi, Trying to compile libvirt on Centos 5.2, get the following when running configure: checking for struct _xmlURI.query_raw... no checking gnutls/gnutls.h usability... yes checking gnutls/gnutls.h presence... yes checking for gnutls/gnutls.h... yes checking for gnutls_handshake in -lgnu

Re: [libvirt] [PATCH 2 of 2] Use cgroup functions to set resource limits on LXC domains

2008-10-01 Thread Daniel P. Berrange
On Wed, Oct 01, 2008 at 01:19:04PM -0700, Dan Smith wrote: > This patch adds code to the controller to set up a cgroup named after the > domain name, set the memory limit, and restrict devices. It also > adds bits to lxc_driver to properly clean up the cgroup on domain death. > > If virCgroupHave

[libvirt] [PATCH 2 of 2] Use cgroup functions to set resource limits on LXC domains

2008-10-01 Thread Dan Smith
This patch adds code to the controller to set up a cgroup named after the domain name, set the memory limit, and restrict devices. It also adds bits to lxc_driver to properly clean up the cgroup on domain death. If virCgroupHaveSupport() says that no support is available, then we just allow the d

[libvirt] [PATCH 1 of 2] Add internal cgroup manipulation functions

2008-10-01 Thread Dan Smith
This patch adds src/cgroup.{c,h} with support for creating and manipulating cgroups. All groups created with the internal API are forced under $mount/libvirt/ to keep everything together. The first time a group is created, the libvirt directory is also created, and the settings from the root are

[libvirt] [PATCH 0 of 2] Add cgroup manipulation and LXC driver support

2008-10-01 Thread Dan Smith
This is my updated set for cgroup manipulation. I think I have addressed all of the concerns and comments so far. There are no major caveats I'm aware of with this round. -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] Re: Overriding vnetN with the element in xml configuration not working

2008-10-01 Thread Daniel P. Berrange
On Wed, Oct 01, 2008 at 08:45:53PM +0200, Ahmed Medhat wrote: > Well, > > I don't recall reading this constrain anywhere in the documentation ! Documentation is never perfect and always a moving target. If anyone has improvements they want to make to the docs, all the website HTML is in the CVS

Re: [libvirt] Re: Overriding vnetN with the element in xml configuration not working

2008-10-01 Thread Ahmed Medhat
Well, I don't recall reading this constrain anywhere in the documentation ! /* || Thanks, Ahmed Medhat || ultimatetux [at] gmail [dot] com || +2-012-4184768 || Impossible is not a fact, It's an opinion! */ On Mon, Sep 29, 2008 at 11:30 AM, Daniel P. Berrange <[EMAIL PROTECTED]> wrote: > On Sa

Re: [libvirt] [PATCH] fix network interface parsing

2008-10-01 Thread Daniel Veillard
On Tue, Sep 30, 2008 at 07:12:15PM -0600, Jim Fehlig wrote: > Hi All, > > While testing libvirt 0.4.5 and 0.4.6 I noticed only one network > interface in domain xml for a xen guest regardless of number actually > assigned. Turns out the last interface parsed is always placed on head > of nets lis

Re: [libvirt] [PATCH] Fix > 1 char device for qemu VM

2008-10-01 Thread Daniel Veillard
On Mon, Sep 29, 2008 at 12:48:30PM -0400, Cole Robinson wrote: > Cole Robinson wrote: > > Trying to start a qemu guest with more than 1 character > > device (serial or parallel, doesn't count for console) > > always times out. There was an error in the code that > > would strip the pty path qemu sp

Re: [libvirt] [PATCH] openvz: swap with

2008-10-01 Thread Anton Protopopov
2008/10/1 Anton Protopopov <[EMAIL PROTECTED]> > If openvz kernel requries specification of a NIC name for inside the >> container, then this is an implemntation detail that the libvirt >> OpenVZ driver will have to deal with. It can auto-assign them to be >> eth0, eth1, etc. This is not exposed i

Re: [libvirt] [PATCH] openvz: swap with

2008-10-01 Thread Anton Protopopov
> > If openvz kernel requries specification of a NIC name for inside the > container, then this is an implemntation detail that the libvirt > OpenVZ driver will have to deal with. It can auto-assign them to be > eth0, eth1, etc. This is not exposed in the libvirt XML though, since > it is not relev

Re: [libvirt] libvirt-qpid

2008-10-01 Thread Daniel P. Berrange
On Wed, Oct 01, 2008 at 11:10:41AM +0100, Daniel P. Berrange wrote: > On Wed, Sep 24, 2008 at 10:55:36AM -0700, Ian Main wrote: > > - Make it less chatty, but log stuff > > Configurable use of syslog() would be a good idea. For sake of consistency > I'd recommend looking at the libvirtd daemon, an

Re: [libvirt] [PATCH] Fix > 1 char device for qemu VM

2008-10-01 Thread Daniel P. Berrange
On Mon, Sep 29, 2008 at 12:45:15PM -0400, Cole Robinson wrote: > Trying to start a qemu guest with more than 1 character > device (serial or parallel, doesn't count for console) > always times out. There was an error in the code that > would strip the pty path qemu spits out, which > confused the p

Re: [libvirt] libvirt-qpid

2008-10-01 Thread Daniel P. Berrange
On Wed, Sep 24, 2008 at 10:55:36AM -0700, Ian Main wrote: > > So I've been working on a qpid interface to libvirt. Here's the description > I've come up with: > > libvirt-qpid provides an interface with libvirt using QMF (qpid modeling > framework) which utilizes the AMQP protocol. The Advanced

Re: [libvirt] [PATCH] openvz: swap with

2008-10-01 Thread Daniel P. Berrange
On Wed, Oct 01, 2008 at 10:33:49AM +0400, Anton Protopopov wrote: > 2008/9/30 Daniel P. Berrange <[EMAIL PROTECTED]> > > > On Tue, Sep 30, 2008 at 05:57:20PM +0400, Anton Protopopov wrote: > > > > > > Now openvz driver chooses not interface name in host, but interface name > > in > > > container.