The attached patch fixes a possible segfault if trying
to start a domain which tries to use an inactive
virtual network. We should explicitly catch that error
and report it, but that's a separate patch.
Thanks,
Cole
commit eca87f821890c7d54f2ba57288acad1b234ec13e
Author: Cole Robinson <[EMAIL PROT
On Thu, Oct 02, 2008 at 09:06:25PM +0100, Daniel P. Berrange wrote:
> I think this needs to use the virDiskNameToIndex() method to
> extract the index instead.
Corrected pach attached. I don't know how devices are called when using
xenner so I left that out.
-- Guido
>From c1499445011166aa53bc729e
Daniel P. Berrange wrote:
> On Thu, Oct 02, 2008 at 03:41:21PM -0400, Cole Robinson wrote:
>> Currently, most src/* files have their own ReportError
>> function. Some support printf style arguments, others
>> only allow reporting a single string message. The code
>> for all of them does virtually t
On Thu, Oct 02, 2008 at 09:56:51PM +0200, Guido G?nther wrote:
> Hi,
> qemudDomainBlockStats needs to map between qemu and libvirt device
> naming as well. Possible patch attached.
> Cheers,
> -- Guido
> >From 57b8c8e66abfcc57c2f05d8b8364de6ecc05dcf9 Mon Sep 17 00:00:00 2001
> From: Guido Guenth
Hi,
qemudDomainBlockStats needs to map between qemu and libvirt device
naming as well. Possible patch attached.
Cheers,
-- Guido
>From 57b8c8e66abfcc57c2f05d8b8364de6ecc05dcf9 Mon Sep 17 00:00:00 2001
From: Guido Guenther <[EMAIL PROTECTED]>
Date: Thu, 2 Oct 2008 21:12:20 +0200
Subject: [PATCH] s
On Thu, Oct 02, 2008 at 03:41:21PM -0400, Cole Robinson wrote:
> Currently, most src/* files have their own ReportError
> function. Some support printf style arguments, others
> only allow reporting a single string message. The code
> for all of them does virtually the same thing, possibly
> passin
Currently, most src/* files have their own ReportError
function. Some support printf style arguments, others
only allow reporting a single string message. The code
for all of them does virtually the same thing, possibly
passing a different constant off to another function.
The attached patch adds
This patch simply slims down the output from the
xmllint tests to not overrun a single line, only
printing the relevant information about the xml file
(parent directory and name, not fully qualified
path). Purely cosmetic, but more useful IMO.
Thanks,
Cole
commit e167f39c756299042c550a451e7e33c0e8
The patch cleans up some uses of qemudDebug, moving
them over to use the DEBUG macros.
There are still lots of uses of qemudDebug in qemud/*,
but I don't know if they can/should be moved over to
use DEBUG.
Thanks,
Cole
commit 99c6268b660f00eb906d936248df83348befa5ab
Author: Cole Robinson <[EMAIL
Currently the DEBUG and DEBUG0 macros are duplicated in
every file that uses them. This patch moves the macros
to internal.h, removes the needless duplication, and
now every file gets them for free. Seems to work as
expected in my testing.
Thanks,
Cole
commit 1a19564d054f3903201a7c65ff0f46c6b169f9
Daniel Veillard wrote:
> On Mon, Sep 29, 2008 at 12:48:30PM -0400, Cole Robinson wrote:
>> Cole Robinson wrote:
>>> Trying to start a qemu guest with more than 1 character
>>> device (serial or parallel, doesn't count for console)
>>> always times out. There was an error in the code that
>>> would
"Daniel P. Berrange" <[EMAIL PROTECTED]> wrote:
...
> Now previously since we just use 'execv' the QEMU process would just
> inherit all libvirtd's environment variables. When we now use execve()
> no variables are inherited - we have to explicitly set all the ones
> we need. I'm not sure what we s
QEMU has two modes of providing a graphical display, VNC and SDL. Now most
of our tools just use VNC, but occasionally people want to use SDL for
some crazy reason. We already support this in Xen driver, but the QEMU
impl has been rather lacking. At the moment if you ask for a SDL display
it'll on
On Thu, Oct 02, 2008 at 08:16:02AM -0700, Ian Main wrote:
> On Thu, 2 Oct 2008 16:50:08 +0200
> Daniel Veillard <[EMAIL PROTECTED]> wrote:
>
> > On Thu, Oct 02, 2008 at 03:40:06PM +0100, Daniel P. Berrange wrote:
> > > On Thu, Oct 02, 2008 at 03:06:01PM +0200, Daniel Veillard wrote:
> > > > You
On Thu, 2 Oct 2008 16:50:08 +0200
Daniel Veillard <[EMAIL PROTECTED]> wrote:
> On Thu, Oct 02, 2008 at 03:40:06PM +0100, Daniel P. Berrange wrote:
> > On Thu, Oct 02, 2008 at 03:06:01PM +0200, Daniel Veillard wrote:
> > > You also need 'yum install qpidd' I suspect this indicates a missing
> > >
On Wed, 1 Oct 2008 11:10:41 +0100
"Daniel P. Berrange" <[EMAIL PROTECTED]> wrote:
> On Wed, Sep 24, 2008 at 10:55:36AM -0700, Ian Main wrote:
> >
> > So I've been working on a qpid interface to libvirt. Here's the description
> > I've come up with:
> >
> > libvirt-qpid provides an interface wit
On Wed, Oct 01, 2008 at 02:55:57PM -0700, Ian Main wrote:
> On Wed, 1 Oct 2008 11:36:24 +0100
> "Daniel P. Berrange" <[EMAIL PROTECTED]> wrote:
>
> > On Wed, Oct 01, 2008 at 11:10:41AM +0100, Daniel P. Berrange wrote:
> > > On Wed, Sep 24, 2008 at 10:55:36AM -0700, Ian Main wrote:
> > > > - Make i
On Thu, Oct 02, 2008 at 03:40:06PM +0100, Daniel P. Berrange wrote:
> On Thu, Oct 02, 2008 at 03:06:01PM +0200, Daniel Veillard wrote:
> > You also need 'yum install qpidd' I suspect this indicates a missing
> > dependancy maybe in the libvirt-qpid package but I'm not 100% sure
>
> Yeah, i belie
On Wed, 1 Oct 2008 11:36:24 +0100
"Daniel P. Berrange" <[EMAIL PROTECTED]> wrote:
> On Wed, Oct 01, 2008 at 11:10:41AM +0100, Daniel P. Berrange wrote:
> > On Wed, Sep 24, 2008 at 10:55:36AM -0700, Ian Main wrote:
> > > - Make it less chatty, but log stuff
> >
> > Configurable use of syslog() wou
On Thu, Oct 02, 2008 at 03:06:01PM +0200, Daniel Veillard wrote:
> On Wed, Sep 24, 2008 at 10:55:36AM -0700, Ian Main wrote:
> >
> > Howdy folks!
> >
> > If you wish to try it out, I've made rpms for fedora 9 x86_64 and i386.
> > They are in the ovirt repo, which you can add to yum using:
> >
>
On Wed, Sep 24, 2008 at 10:55:36AM -0700, Ian Main wrote:
>
> Howdy folks!
Okay i started playing with this a bit, so a few hints and feedback
> The source code repo:
>
> http://git.et.redhat.com/?p=libvirt-qpid.git;a=summary
>
> So I'd like to hear any feedback you guys might have. This fi
On Wed, Oct 01, 2008 at 11:10:33PM +0100, Daniel P. Berrange wrote:
> On Wed, Oct 01, 2008 at 02:11:24PM -0700, Dan Smith wrote:
> > DB> Rather than rely on this virt type string - virt type is not
> > DB> adding enough uniqueness - can still have a (virttype, name) clash
> > DB> between 2 libvirt
Hi.
I rewrite functions taken from vzctl in the new patch, so this:
>
>> Here is the patch, that implements the following behaviour
>>
>> * interface name inside container is automatically generated and equals
>> ethN,
>>where N is the number of that interface within current domain
>> * mac
23 matches
Mail list logo