Re: [libvirt] Doubt over Kvm migration support in libvirt 0.5.0

2008-12-01 Thread Anton Protopopov
2008/12/2 Shanmuga Rajan <[EMAIL PROTECTED]> > I am using libvirt(python) to develop a small application which will > manage my nodes which running in KVM. > But when i tried migration i got this error. > > >>> vs.migrate(conn, libvirt.VIR_MIGRATE_LIVE,'testtt','192.168.1.82',0) > libvir: error :

[libvirt] Doubt over Kvm migration support in libvirt 0.5.0

2008-12-01 Thread Shanmuga Rajan
I am using libvirt(python) to develop a small application which will manage my nodes which running in KVM. But when i tried migration i got this error. >>> vs.migrate(conn, libvirt.VIR_MIGRATE_LIVE,'testtt','192.168.1.82',0) libvir: error : this function is not supported by the hypervisor: virDoma

[libvirt] broken pipe?

2008-12-01 Thread Itamar Heim
Hi, I have a problem with a small python script (using fedora 10 with its shipped rpm's - libvirt-0.4.6-3.fc10.x86_64, libvirt-python-0.4.6-3.fc10.x86_64) I'm running a simple stupid libvirt python script. I happen to want to use SDL, and it fails on "Could not initialize SDL - exiting". Whi

[libvirt] [PATCH] Fix a few docs errors

2008-12-01 Thread Cole Robinson
The attached patch fixes a few cut and paste docs errors I've stumbled upon, and a spelling error in a virsh command output. Thanks, Cole diff --git a/docs/formatstorage.html.in b/docs/formatstorage.html.in index 7cd4731..366339a 100644 --- a/docs/formatstorage.html.in +++ b/docs/formatstorage.htm

[libvirt] [PATCH] Increase initial qemu monitor read timeout

2008-12-01 Thread Cole Robinson
See https://bugzilla.redhat.com/show_bug.cgi?id=453491 We've been getting bug reports like the above against virt-manager for a while now: installing new VMs consistently throws an error 'Timed out while reading monitor startup output'. The user can then just retry the install and it will go off w

[libvirt] [PATCH] Sanitize qemu monitor output

2008-12-01 Thread Cole Robinson
The attached patch cleans up output we read from the qemu monitor. This is a simplified form of a patch I posted awhile ago. From the patch: /* The monitor doesn't dump clean output after we have written to * it. Every character we write dumps a bunch of useless stuff, * so the result looks like

Re: [libvirt] libvirt 0.5.0 and KVM migration

2008-12-01 Thread Guido Günther
On Mon, Dec 01, 2008 at 03:31:55PM +0100, Mickaël Canévet wrote: > In other (debian) words, will an "apt-get update kvm -t > experimental" (which provides kvm-79) be enough on my lenny (I would > like to limit unstable or experimental packages) ? experimental also has kvm-source, you can build new

Re: [libvirt] PATCH: 4/28: Thread safety for test driver

2008-12-01 Thread Jim Meyering
Daniel Veillard <[EMAIL PROTECTED]> wrote: ... > I hope it's worth the effort, it's a lot of complexity added. > One of the things which worries me is that detecting errors will be > hard, you end up with a locked server that can be far from trivial > to debug. > I'm really wondering how we could a

Re: [libvirt] PATCH: 21/28: Fill in locking stubs

2008-12-01 Thread Daniel P. Berrange
On Mon, Dec 01, 2008 at 12:09:21AM +, Daniel P. Berrange wrote: > This patch fills in the previous stub methods for locking/unlocking > internal objects. > > With the following methods return a locked object > > virDomainFindByID > virDomainFindByName > virDomainFindByUUID > virDoma

Re: [libvirt] PATCH: 4/28: Thread safety for test driver

2008-12-01 Thread Daniel P. Berrange
On Mon, Dec 01, 2008 at 06:26:03PM +0100, Daniel Veillard wrote: > On Sun, Nov 30, 2008 at 11:27:14PM +, Daniel P. Berrange wrote: > > This patch makes the test driver thread safe, adding a global driver lock, > > and the neccessary locking calls on domain/network/storagepool objects. > > > >

Re: [libvirt] PATCH: 4/28: Thread safety for test driver

2008-12-01 Thread Daniel Veillard
On Sun, Nov 30, 2008 at 11:27:14PM +, Daniel P. Berrange wrote: > This patch makes the test driver thread safe, adding a global driver lock, > and the neccessary locking calls on domain/network/storagepool objects. > > You'll notice there are many calls to > > virDomainObjUnlock > > but ver

Re: [libvirt] PATCH: 3/28: Reduce return points in test driver

2008-12-01 Thread Daniel Veillard
On Sun, Nov 30, 2008 at 11:23:18PM +, Daniel P. Berrange wrote: > This patch reduces the number of return points in methods in the test > driver. This is done by switching most 'return -1' calls into a > 'goto cleanup' centralizing all cleanup in methods. > > test.c | 812 > ++

Re: [libvirt] PATCH: 2/28: Kill off macros in test driver

2008-12-01 Thread Daniel Veillard
On Sun, Nov 30, 2008 at 11:20:28PM +, Daniel P. Berrange wrote: > > The test driver has alot of convenience macros for for fetching the private > internal object impls from the public API parameters. Unfortunately these > rather obscure/hide code flow & variable accesses in the test driver, ma

Re: [libvirt] PATCH: 1/28: Stubs for object locking APIs

2008-12-01 Thread Daniel Veillard
On Sun, Nov 30, 2008 at 11:17:09PM +, Daniel P. Berrange wrote: > To facilitate later patches this introduces lock & unlock API calls for > each internal object which are just no-ops. Once all the drivers are > updated to call this at appropriate places, the stubs will be filled > out with actu

Re: [libvirt] PATCH: 0/28: Thread safety for libvirtd daemon and drivers

2008-12-01 Thread Daniel P. Berrange
On Mon, Dec 01, 2008 at 11:07:47AM -0500, Ben Guthro wrote: > What git changeset does this queue apply against? It was against CVS head as off Sunday evening. > I'm having a heck of a time getting it to apply cleanly with git-am. > > alternately: > I know you work on occasion with mercurial. Is

Re: [libvirt] PATCH: 0/28: Thread safety for libvirtd daemon and drivers

2008-12-01 Thread Ben Guthro
What git changeset does this queue apply against? I'm having a heck of a time getting it to apply cleanly with git-am. alternately: I know you work on occasion with mercurial. Is this an mq tree somewhere? Daniel P. Berrange wrote on 11/30/2008 06:14 PM: > The following huge series of patches a

Re: [libvirt] PATCH: 25/28: Thread safety for libvirtd event loop

2008-12-01 Thread Ben Guthro
please disregard this email...user error. Ben Guthro wrote on 12/01/2008 10:06 AM: > Is patch 24/25 missing? > > I tried > git branch thread-safe b726fa0fa5a91eee0af2f996c784d13593cd7616 > git checkout thread-safe > git am --interactive /home/bguthro/.thunderbird/tiloddj9.default/Mail/Local\ > F

Re: [libvirt] PATCH: 25/28: Thread safety for libvirtd event loop

2008-12-01 Thread Ben Guthro
Is patch 24/25 missing? I tried git branch thread-safe b726fa0fa5a91eee0af2f996c784d13593cd7616 git checkout thread-safe git am --interactive /home/bguthro/.thunderbird/tiloddj9.default/Mail/Local\ Folders/thread-safe and got through most of these, but it seemed to fail on patch 25: ... Applyin

Re: [libvirt] libvirt 0.5.0 and KVM migration

2008-12-01 Thread Mickaël Canévet
Thanks for your quick answer. I forgot to restart libvirt on one node. Now I have an other error message: libvir: QEMU error : operation failed: failed to start listening VM Is there any kernel limitation also ? will it work with my distro 2.6.26 kernel with kvm-79 userspace component or do I h

Re: [libvirt] libvirt 0.5.0 and KVM migration

2008-12-01 Thread Chris Lalancette
Mickaël Canévet wrote: > Hi, > > I just installed libvirt 0.5.0 on Debian Lenny with KVM 0.72 to try KVM > migration support. > > When I try to migrate a VM from one node to the other one, I have this > error message: > > libvir: error : this function is not supported by the hypervisor: > virDom

[libvirt] [PATCH] qemud/qemud.c (qemudCleanup): Plug a leak.

2008-12-01 Thread Jim Meyering
Hi Dan, With your patches, "make check" hits one new leak: 40 bytes in 1 blocks are definitely lost in loss record 9 of 65 at 0x4A05174: calloc (vg_replace_malloc.c:397) by 0x447F29: virAllocN (memory.c:128) by 0x40CD82: qemudRunLoop (qemud.c:1839) by 0x40E713: mai

[libvirt] libvirt 0.5.0 and KVM migration

2008-12-01 Thread Mickaël Canévet
Hi, I just installed libvirt 0.5.0 on Debian Lenny with KVM 0.72 to try KVM migration support. When I try to migrate a VM from one node to the other one, I have this error message: libvir: error : this function is not supported by the hypervisor: virDomainMigrate Is it really supposed to work ?

[libvirt] avoid "make check" hang on daemon-conf

2008-12-01 Thread Jim Meyering
Hi Dan, With your 28-part patch, I was getting a daemon-conf failure in "make check". This fixes it: Unless you tell me otherwise, I will apply most of this right away, (and let you remove the space-before-max_clients in your patch) since no other part of this change conflicts with your series.

Re: [libvirt] [PATCH 2/2]: Call udevsettle in the appropriate places

2008-12-01 Thread Chris Lalancette
Daniel P. Berrange wrote: > This seems rather overkill when you could just do > > #if defined(UDEVADM) || defined(UDEVSETTLE) > void virStorageBackendWaitForDevices(virConnectPtr conn) > { > #ifdef UDEVADM > const char *const settleprog[] = { UDEVADM, "settle", NULL }; > #else > const char

Re: [libvirt] KVM/qemu: problems with autostart of vms with non-bridged nets

2008-12-01 Thread Gerd v. Egidy
Hi Daniel, > > This patch alone not, but this patch + the one in my first mail > > (see > > https://www.redhat.com/archives/libvir-list/2008-November/msg00457.html) > > together make it work for me. The first patch fixes the autostart order, > > the second one adds the necessary conn structure. >

Re: [libvirt] PATCH: 11/28: Reduce return points for UML driver

2008-12-01 Thread Jim Meyering
Jim Meyering <[EMAIL PROTECTED]> wrote: > Ron Yorston <[EMAIL PROTECTED]> wrote: >> "Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: >>> static int umlDomainShutdown(virDomainPtr dom) { > ... >>>+char *info; > ... >>> VIR_FREE(info); > ... >> info should be initialised to NULL, otherwise the

Re: [libvirt] KVM/qemu: problems with autostart of vms with non-bridged nets

2008-12-01 Thread Daniel P. Berrange
On Mon, Dec 01, 2008 at 11:42:28AM +0100, Gerd v. Egidy wrote: > > > I came up with the attached patch to fix this for me, but > > > a) I'm not sure if it is a clean use of the api to call virConnectOpen() > > > from within a state-initializer function > > > b) This is just for qemu/kvm, I haven't

Re: [libvirt] PATCH: 0/28: Thread safety for libvirtd daemon and drivers

2008-12-01 Thread Daniel P. Berrange
On Mon, Dec 01, 2008 at 11:08:36AM +0100, Jim Meyering wrote: > "Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: > > The following huge series of patches adds thread safety for the libvirtd > > Hi Dan, > > FYI, I've applied everything and have begun looking. > I noticed while applying ("git am" co

Re: [libvirt] PATCH: 11/28: Reduce return points for UML driver

2008-12-01 Thread Daniel P. Berrange
On Mon, Dec 01, 2008 at 09:16:10AM +, Ron Yorston wrote: > "Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: > > static int umlDomainShutdown(virDomainPtr dom) { > >-struct uml_driver *driver = (struct uml_driver *)dom->conn->privateData; > >-virDomainObjPtr vm = virDomainFindByID(&driver

Re: [libvirt] KVM/qemu: problems with autostart of vms with non-bridged nets

2008-12-01 Thread Gerd v. Egidy
> > I came up with the attached patch to fix this for me, but > > a) I'm not sure if it is a clean use of the api to call virConnectOpen() > > from within a state-initializer function > > b) This is just for qemu/kvm, I haven't looked at any other drivers > > > > It would be nice if an experienced

Re: [libvirt] KVM/qemu: problems with autostart of vms with non-bridged nets

2008-12-01 Thread Daniel P. Berrange
On Mon, Dec 01, 2008 at 02:07:37AM +0100, Gerd von Egidy wrote: > Hi, > > > 2. missing virConnectPtr during autostart of the vm: > > > > in src/qemu_driver.c:145, qemudAutostartConfigs() you can find this call: > > int ret = qemudStartVMDaemon(NULL, driver, vm, NULL); > > > > This means virConnect

[libvirt] [PATCH] avoid format string warnings

2008-12-01 Thread Jim Meyering
Hi Dan, I've just applied all of your changes, built, and saw some new warnings: uml_driver.c:1742: warning: format not a string literal and no format arguments uml_driver.c:1748: warning: format not a string literal and no format arguments uml_driver.c:1785: warning: format not a string

Re: [libvirt] PATCH: 0/28: Thread safety for libvirtd daemon and drivers

2008-12-01 Thread Jim Meyering
"Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: > The following huge series of patches adds thread safety for the libvirtd Hi Dan, FYI, I've applied everything and have begun looking. I noticed while applying ("git am" complained) that #25 and 26 had trailing white space. -- Libvir-list mailing

Re: [libvirt] PATCH: 11/28: Reduce return points for UML driver

2008-12-01 Thread Jim Meyering
Ron Yorston <[EMAIL PROTECTED]> wrote: > "Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: >> static int umlDomainShutdown(virDomainPtr dom) { ... >>+char *info; ... >> VIR_FREE(info); ... > info should be initialised to NULL, otherwise the VIR_FREE will fail. > With the umlMonitorCommand if'

Re: [libvirt] PATCH: 11/28: Reduce return points for UML driver

2008-12-01 Thread Ron Yorston
"Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: > static int umlDomainShutdown(virDomainPtr dom) { >-struct uml_driver *driver = (struct uml_driver *)dom->conn->privateData; >-virDomainObjPtr vm = virDomainFindByID(&driver->domains, dom->id); >-char* info; >+struct uml_driver *drive