Re: [libvirt] docs/examples/*.res

2009-01-23 Thread Daniel Veillard
On Sat, Jan 24, 2009 at 03:46:38AM +, John Levon wrote: > On Sat, Jan 24, 2009 at 04:04:28AM +0100, Daniel Veillard wrote: > > >- libxml2 uses the same doc/example stuff > >- the Makefile.am is generated, it's actually indicated at the top > > Ah, thanks! A file which generates a file

Re: [libvirt] docs/examples/*.res

2009-01-23 Thread John Levon
On Sat, Jan 24, 2009 at 04:04:28AM +0100, Daniel Veillard wrote: >- libxml2 uses the same doc/example stuff >- the Makefile.am is generated, it's actually indicated at the top Ah, thanks! A file which generates a file which generates a file which generates a file, which is used to genera

Re: [libvirt] docs/examples/*.res

2009-01-23 Thread Daniel Veillard
On Sat, Jan 24, 2009 at 01:49:07AM +, John Levon wrote: > > What are these files supposed to be? Dan V's 2105:ed8c8b0ec3c5 changeset > backed out my change: Huh ? If I removed something that's definitely not on-purpose. But I never use GIT, just CVS, so no idea what the changeset might be a

[libvirt] docs/examples/*.res

2009-01-23 Thread John Levon
What are these files supposed to be? Dan V's 2105:ed8c8b0ec3c5 changeset backed out my change: install-data-local: $(mkinstalldirs) $(DESTDIR)$(HTML_DIR) -...@install@ -m 0644 $(srcdir)/*.html $(srcdir)/*.c $(srcdir)/*.xml \ - $(srcdir)/*.xsl $(DESTDIR)$(HTML_DIR) +

[libvirt] [PATCH] trivial libvirt example code

2009-01-23 Thread Dave Allan
The examples directory doesn't have a trivial example of how to connect to a hypervisor, make a few calls, and disconnect, so I put one together. I would appreciate any suggestions on anything that I've done wrong as well as suggestions for other fundamental API calls that should be illustrate

Re: [libvirt] [PATCH] xend driver: handle new-format sched-credit options

2009-01-23 Thread John Levon
On Fri, Jan 23, 2009 at 10:32:51AM +, Daniel P. Berrange wrote: > Am I right in thinking you're adding this because the > generic "virsh schedinfo --set cap=123" command is hardcoding > the LLONG data type. If so, this is the wrong approach - virsh > is actually the one at fault. OK, I'll lo

Re: [libvirt] [PATCH] Fix virsh sched-credit for xend

2009-01-23 Thread John Levon
On Fri, Jan 23, 2009 at 10:34:14AM +, Daniel P. Berrange wrote: > > Fix virsh sched-credit for xend > > > > Need to pass domain in the xend op for shut-down domains. > > (This also requires xend fixes, but this patch doesn't make things > > worse.) > > Does XenD actaully persist the schedinf

Re: [libvirt] [PATCH]: don't fail on missing locale

2009-01-23 Thread Daniel P. Berrange
On Fri, Jan 23, 2009 at 04:55:22PM +0100, Guido G?nther wrote: > Hi, > attached patch lets virsh work with missing locales. This is: > http://bugs.debian.org/512721 ACK, but can you add a comment below perror explaining why we are not exiting at this point. Daniel -- |: Red Hat, Engineering, L

[libvirt] [PATCH]: don't fail on missing locale

2009-01-23 Thread Guido Günther
Hi, attached patch lets virsh work with missing locales. This is: http://bugs.debian.org/512721 Cheers, -- Guido >From cb456e15dba480640508df4c4250234f30172083 Mon Sep 17 00:00:00 2001 From: =?utf-8?q?Guido=20G=C3=BCnther?= Date: Fri, 23 Jan 2009 16:25:33 +0100 Subject: [PATCH] don't fail on mis

Re: [libvirt] [PATCH] qemud: don't dereference NULL on failed virGetUserDirectory

2009-01-23 Thread Daniel P. Berrange
On Fri, Jan 23, 2009 at 02:23:14PM +0100, Jim Meyering wrote: > Jim Meyering wrote: > > I spotted this while merging my unix_sock_dir changes: > ... > > char *userdir = virGetUserDirectory(NULL, uid); > > +if (userdir == NULL) { > > +/* give no diagnostic here; virGetU

Re: [libvirt] [PATCH] qemud: don't dereference NULL on failed virGetUserDirectory

2009-01-23 Thread Jim Meyering
Jim Meyering wrote: > I spotted this while merging my unix_sock_dir changes: ... > char *userdir = virGetUserDirectory(NULL, uid); > +if (userdir == NULL) { > +/* give no diagnostic here; virGetUserDirectory reports OOM */ It can also fail due to getpwuid_r failure.

[libvirt] [PATCH] qemud: don't dereference NULL on failed virGetUserDirectory

2009-01-23 Thread Jim Meyering
I spotted this while merging my unix_sock_dir changes: >From 04373207bc838c31bd07596df3c676476e73c983 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Fri, 23 Jan 2009 13:59:28 +0100 Subject: [PATCH] qemud: don't dereference NULL on failed virGetUserDirectory * qemud/qemud.c (qemudInitPaths): C

[libvirt] FYI, .*ignore and gnulib updates

2009-01-23 Thread Jim Meyering
I'll push these shortly: The updates to .m4 files from gnulib are required to avoid new warnings (about a subtle problem) from the very latest version of autoconf, built from yesterday's upstream sources. >From fe911bb6a39f88dd25dce5edea1f9e03d156cd86 Mon Sep 17 00:00:00 2001 From: Jim Meyering

Re: [libvirt] PATCH: Support storage copy on write volumes

2009-01-23 Thread Jim Meyering
Miloslav Trmač wrote: > Jim Meyering píše v Čt 22. 01. 2009 v 19:15 +0100: >> > +static int >> > +cowGetBackingStore(virConnectPtr conn, >> > + char **res, >> > + const unsigned char *buf, >> > + size_t buf_size) >> > +{ >> > +size_t len;

Re: [libvirt] PATCH: Support storage copy on write volumes

2009-01-23 Thread Miloslav Trmač
Jim Meyering píše v Čt 22. 01. 2009 v 19:15 +0100: > > +static int > > +cowGetBackingStore(virConnectPtr conn, > > + char **res, > > + const unsigned char *buf, > > + size_t buf_size) > > +{ > > +size_t len; > > + > > +*res = NULL; > > +

Re: [libvirt] [PATCH] Fix virsh sched-credit for xend

2009-01-23 Thread Daniel P. Berrange
On Thu, Jan 22, 2009 at 05:49:00PM -0800, john.le...@sun.com wrote: > # HG changeset patch > # User john.le...@sun.com > # Date 1232675291 28800 > # Node ID 415bfd87e0ecd7751ed6df372e82da0e3991d617 > # Parent 68e14fe50dfa88a4694bc4c7a68d2f73f41c6171 > Fix virsh sched-credit for xend > > Need to p

Re: [libvirt] [PATCH] xend driver: handle new-format sched-credit options

2009-01-23 Thread Daniel P. Berrange
On Thu, Jan 22, 2009 at 05:49:22PM -0800, john.le...@sun.com wrote: > # HG changeset patch > # User john.le...@sun.com > # Date 1232675291 28800 > # Node ID ad7f82da983cc0ba07f7f4e94a2f23a4edc3be57 > # Parent 3ef027308b88b47b2f3ca721bf88f2e606d8e3bc > xend driver: handle new-format sched-credit op

Re: [libvirt] [PATCH] Fix recursive lock in xenstore driver

2009-01-23 Thread Daniel P. Berrange
On Thu, Jan 22, 2009 at 05:48:25PM -0800, john.le...@sun.com wrote: > # HG changeset patch > # User john.le...@sun.com > # Date 1232675291 28800 > # Node ID 903a29e99c80a35ce7f4754a3bcc3ab34bf32d8a > # Parent b83af161640c69b1de279547b270b8acb101152e > Fix recursive lock in xenstore driver > > The