2675 * Returns the new domain object if the migration was successful,
2676 * or NULL in case of error. Note that the new domain object
2677 * exists in the scope of the destination connection (dconn).
This is obviously impossible for xenmigr:///. As a result, virsh migrate
always returns
Jim Meyering wrote:
Finally, I moved a couple variable declarations
down (C99-style) to their points of first use.
I take it that the C++/C99 is the recommended style for all libvirt
code? I generally haven't coded this way in the past (in fact I usually
compile with -Wdeclaration-after-stat
# HG changeset patch
# User john.le...@sun.com
# Date 1233286638 28800
# Node ID 0934f4c2e1d446b1902d9ffcf14febf964af1e6a
# Parent 6ee939f57a02bf9d332f094e07180e0149e85924
Fix virsh migrateuri handling
Signed-off-by: John Levon
diff --git a/src/virsh.c b/src/virsh.c
--- a/src/virsh.c
+++ b/src/
On Thu, Jan 29, 2009 at 06:06:10PM -0800, john.le...@sun.com wrote:
> +if (getpwuid_r(uid, &pwbuf, strbuf, strbuflen, &pw) != 0 || pw == NULL)
I didn't qrefresh, but the version I tested does indeed compile (missing
brace here) :)
regards
john
--
Libvir-list mailing list
Libvir-list@redhat.
# HG changeset patch
# User john.le...@sun.com
# Date 1233282885 28800
# Node ID 6ee939f57a02bf9d332f094e07180e0149e85924
# Parent c60439e564f90b579c07f6349f8f0810a5da1032
Fix yet another printf("%s", NULL) case
Signed-off-by: John Levon
diff --git a/src/libvirt.c b/src/libvirt.c
--- a/src/libv
# HG changeset patch
# User john.le...@sun.com
# Date 1233280613 28800
# Node ID 59c231ad7e158acead0c236c3a52f60718b84605
# Parent b203988038c14f1160cbd250a48eda40d4613eca
Fix getpwuid_r() usage
Signed-off-by: John Levon
diff --git a/src/util.c b/src/util.c
--- a/src/util.c
+++ b/src/util.c
@@
> > ** But the second time, the command hang:
> > [r...@xen03 srv]# virsh restore /srv/save
And libvirt daemon runs with 100% CPU load ..
This is not good ..
--
Libvir-list mailing list
Libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
> ** But the second time, the command hang:
> [r...@xen03 srv]# virsh restore /srv/save
Update: qemu will not stop writing errors "Read failed" to
the logfile /var/log/libvirt/qemu/winxp100.log. So, it is an qemu
problem...
LC_ALL=C LD_LIBRARY_PATH=/usr/local/staf/lib:
PATH=/sbin:/usr/sbin:/bin:/
Hi,
i try to restore a domain without a valid disk (I deleted the diskfile
before restoring it ...). Normally, this must always produce an error.
** The first time, an error occurred - OK:
[r...@xen03 srv]# virsh restore /srv/save
libvir: QEMU error : operation failed: failed to start VM
error
Hi,
i try to restore a domain
[r...@xen03 srv]# virsh restore /srv/save
libvir: QEMU error : operation failed: failed to start VM
error: Failed to restore domain from /srv/save
[r...@xen03 srv]# virsh restore /srv/save
^C
[r...@xen03 srv]# virsh list
^C
[r...@xen03 srv]#
Viele Gruesse
Dan
Hi,
is there a way to get a consistent disk image of a domain running qemu-kvm
before saving it ?
I used " xm sysrq s" with xen-hypervisor - but what's the way with kvm ?
Or could I install drivers into the guest helping to solve this problem ?
regards
Danny
-
john cooper wrote:
> Daniel P. Berrange wrote:
>> If you loook at src/qemu_conf.c, you'll find a nice method called
>> qemudExtractVersionInfo, which runs 'qemu -help' and checks for
>> certain interesting command line arguments :-)
> That problem does seem to be crying for some type
> of structur
Mark McLoughlin wrote:
Hi David,
On Fri, 2009-01-16 at 22:23 +, David Lutterkort wrote:
> >
I don't think we want to define a bridge here, but more that an
interface is shared - i.e. this is a property of eth2.
Note this line.
The main concern is that this is the way I'd expe
I've begun eliminating the remaining problematic uses of strerror.
For example, those in virsh.c aren't a problem.
This is required for thread safety.
After this patch, there are about 60 uses left.
Note while reviewing:
- are there places where I've added uses of "conn" that I should not have?
On Thu, Jan 29, 2009 at 03:16:11PM +0100, Jim Meyering wrote:
> "Daniel P. Berrange" wrote:
> > This is a repost of the patch from:
> >
> > http://www.redhat.com/archives/libvir-list/2009-January/msg00583.html
> >
> > updated to take account of the changes commited since I first posted it.
>
> Th
On Thu, Jan 29, 2009 at 02:14:48PM +0100, Jim Meyering wrote:
> Jim Meyering wrote:
>
> > "Daniel P. Berrange" wrote:
> >> If you're taking feature requests, one thing I'd like for the syntax-check
> >
> > ;-) Always.
> >
> >> target is for it to print out the name of each check it is running.
On Thu, Jan 29, 2009 at 11:35:19AM +, Daniel P. Berrange wrote:
> > Fix xend XML generation when CPU pinning is used
> >
> > Signed-off-by: John Levon
>
> Am I right in thinking that the problem addressed here, is that if
> the SEXPR has CPU pinning data, we'd be parsing it into a NULL
> 'c
On Thu, Jan 29, 2009 at 11:33:10AM +, Daniel P. Berrange wrote:
> > +if (def->localtime && xenXMConfigSetInt(conf, "localtime", 1) < 0)
> > +goto no_memory;
>
> Existing code unconditionally sets localtime=0 and localtime=1,
> but this only sets localtime=1, relying on XM defaults
diff -urp libvirt-0.5.1/proxy/libvirt_proxy.c libvirt-dev/proxy/libvirt_proxy.c
--- libvirt-0.5.1/proxy/libvirt_proxy.c 2008-11-20 08:58:43.0 +0100
+++ libvirt-dev/proxy/libvirt_proxy.c 2009-01-25 12:51:33.0 +0100
@@ -385,7 +385,8 @@ retry:
fprintf(stderr, "read %d bytes
"Daniel P. Berrange" wrote:
> This is a repost of the patch from:
>
> http://www.redhat.com/archives/libvir-list/2009-January/msg00583.html
>
> updated to take account of the changes commited since I first posted it.
Thanks.
The fix looks right.
Glad you added those tests.
It's nice to have all
This bug was originally reported here
https://bugzilla.redhat.com/show_bug.cgi?id=479203
If you define an guest VM specifying a architecture which does not
actually exist in the QEMU driver's declared capabilities, then it
would dereference NULL when later attempting to start the VM.
The exa
Jim Meyering wrote:
> "Daniel P. Berrange" wrote:
>> If you're taking feature requests, one thing I'd like for the syntax-check
>
> ;-) Always.
>
>> target is for it to print out the name of each check it is running. We've
>> got quite alot of checks and so it just sits there for a long time us
"Daniel P. Berrange" wrote:
> If you're taking feature requests, one thing I'd like for the syntax-check
;-) Always.
> target is for it to print out the name of each check it is running. We've
> got quite alot of checks and so it just sits there for a long time using
> 100% cpu and with no feed
This is a repost of the patch from:
http://www.redhat.com/archives/libvir-list/2009-January/msg00583.html
updated to take account of the changes commited since I first posted it.
Daniel
diff -r 7aa9f1c885e7 src/qemu_conf.c
--- a/src/qemu_conf.c Tue Jan 27 15:42:39 2009 +
+++ b/src/qemu_co
"Daniel P. Berrange" wrote:
> On Wed, Jan 28, 2009 at 07:46:34PM +0100, Jim Meyering wrote:
>> "Daniel P. Berrange" wrote:
>> > On Tue, Jan 20, 2009 at 11:08:56PM +, Daniel P. Berrange wrote:
>> >> This patch adds support for using the monitor interface to set the VNC
>> >> password
>> >>
>>
On Fri, Jan 23, 2009 at 04:29:24PM +, Daniel P. Berrange wrote:
> On Fri, Jan 23, 2009 at 04:55:22PM +0100, Guido G?nther wrote:
> > Hi,
> > attached patch lets virsh work with missing locales. This is:
> > http://bugs.debian.org/512721
>
> ACK, but can you add a comment below perror explaini
On Wed, Jan 28, 2009 at 08:28:26PM -0800, john.le...@sun.com wrote:
> # HG changeset patch
> # User john.le...@sun.com
> # Date 1233203295 28800
> # Node ID 9aac8028d5f266023c85338afe71ecabe26079f7
> # Parent add5d46423d8cc24ac922373ba5cd1b3ea2e6f9f
> Fix xend XML generation when CPU pinning is us
On Wed, Jan 28, 2009 at 07:33:09PM -0800, john.le...@sun.com wrote:
> # HG changeset patch
> # User john.le...@sun.com
> # Date 1233199841 28800
> # Node ID 3f2af372963ddbae509bd0d1b2e7bdf3ebb4f217
> # Parent 76d670ab6ea5476be96441ea88af94644c985201
> Fix another printf("%s", NULL) case
>
> Signe
On Wed, Jan 28, 2009 at 07:09:19PM -0800, john.le...@sun.com wrote:
> # HG changeset patch
> # User john.le...@sun.com
> # Date 1233198416 28800
> # Node ID 76d670ab6ea5476be96441ea88af94644c985201
> # Parent f0247b9f4da199c01412d5bd0f9d7d888cbb84de
> Solaris PV is localtime. Allow this setting th
On Wed, Jan 28, 2009 at 01:23:39PM -0800, john.le...@sun.com wrote:
> # HG changeset patch
> # User john.le...@sun.com
> # Date 1233177786 28800
> # Node ID 2b9283e83c20ca2a18f2cafcb963ce254e11dbb4
> # Parent 9a9bd34ec485ebaf4c3861bdfffd2953fd91a1fc
> Fix floppy definition for HVM guests
>
> Code
On Wed, Jan 28, 2009 at 09:12:26AM -0800, john.le...@sun.com wrote:
> # HG changeset patch
> # User john.le...@sun.com
> # Date 1233162577 28800
> # Node ID 6ab030d99574ee01193e92846eb7c9b41bfcd149
> # Parent 5a0860d81ed44d5f189788fc340f975517595160
> Fixes for VNC port handling
>
> When parsing
On Thu, Jan 29, 2009 at 03:12:35PM +0900, Atsushi SAKAI wrote:
> 2 questions.
>
>
> 1)Would you explain the use case for libvirt-qpid?
> Which case AMDQ messaging is good for.
> If I am missing some document, Please point me.
> By the way I am reading through following document.
>
> http
32 matches
Mail list logo
