Re: [libvirt] [PATCH 1/1] Add SCSI pool support.

2009-03-30 Thread Dave Allan
Daniel P. Berrange wrote: On Sat, Mar 28, 2009 at 10:40:48AM -0400, Dave Allan wrote: Daniel P. Berrange wrote: This unfortauntely does not work on RHEL5, because there are no targetX.X.X links here. Only the LUNs appear in this directory. The location which appears to be present on both old

Re: [libvirt] [Fwd: first cut public API for physical host interface configuration]

2009-03-30 Thread David Lutterkort
On Mon, 2009-03-30 at 12:40 +0100, Daniel P. Berrange wrote: > Well you'll need to be able to query live interfaces anyway, because > you'll need to be able to report IPv4 addresses assigned by DHCP and > report IPv6 addresses that auto-configure themselves. What's the use case behind that ? I wo

Re: [libvirt] [PATCH 0/2]: Cleanup driver initializers

2009-03-30 Thread Laine Stump
On 03/30/2009 08:09 AM, Chris Lalancette wrote: All, This is a small series to cleanup the internal driver initializers. The drivers were using an annoying combination of C-99 style initialization and old-style (C89?) initialization. On top of that, the indentation on some of these was wac

Re: [libvirt] PATCH: Fix misc memory alloc/free/usage bugs

2009-03-30 Thread Ryota Ozaki
Hi Daniel, On Mon, Mar 30, 2009 at 10:39 PM, Daniel P. Berrange wrote: > A few more small bugs > >  * src/node_device.c: Don't strdup() a NULL device parent >  * src/qemu_conf.c: Don't try to run access() on a NULL binary path >  * src/security_selinux.c Make sure result from readlink() is NULL >

[libvirt] PATCH: Xen PCI device passthrough

2009-03-30 Thread Daniel P. Berrange
This patch implements PCI device passthrough for Xen. In pci.c there is a fair bit of refactoring to better support both pcistub.ko and pciback.ko. The latter has two extra sysfs files, add_slot and remove_slot for associating the driver with a specific PCI device domain:bus:slot:func address, whe

Re: [libvirt] [PATCH] prevent an executed external process to be a zombie

2009-03-30 Thread Ryota Ozaki
Hi Daniel, On Mon, Mar 30, 2009 at 6:18 PM, Daniel P. Berrange wrote: > On Mon, Mar 30, 2009 at 12:49:55AM +0900, Ryota Ozaki wrote: >> Hi, >> >> This patch prevents an executed external process to be a zombie >> by doing waitpid() even if virPipeReadUntilEOF() fails. > > ACK patch looks good > >

[libvirt] PATCH: Add --tree flag to virsh nodedev-list

2009-03-30 Thread Daniel P. Berrange
The virsh noddev-list command is used to display node devices. It just prints out their names in a flat list. When detaching devices for purposes of PCI passthrough though, it is important to understand what devices are children of the PCI device about to be detached. It is tedious to find this ou

[libvirt] PATCH: Fix misc memory alloc/free/usage bugs

2009-03-30 Thread Daniel P. Berrange
A few more small bugs * src/node_device.c: Don't strdup() a NULL device parent * src/qemu_conf.c: Don't try to run access() on a NULL binary path * src/security_selinux.c Make sure result from readlink() is NULL terminated * src/storage_conf.c: DOn't free 'mode' while it is still used di

Re: [libvirt] Patch to allow setting of svirt XML.

2009-03-30 Thread Daniel J Walsh
On 03/28/2009 07:51 AM, Daniel P. Berrange wrote: On Thu, Mar 26, 2009 at 11:51:21AM -0400, Daniel J Walsh wrote: This patch fixes the seclabel handling in domain_conf.c to allow virt-manager to set the seclabel model, type and label. Also adds missing error messages when the xml is incorrect.

Re: [libvirt] [PATCH 1/2] OpenNebula driver, libvirt-0.6.1

2009-03-30 Thread Pritesh Kothari
Hi > +ONE_DRIVER_SOURCES =    \ > +    one_conf.c one_conf.h   \ > +    one_driver.c one_driver.h   > > > + Is it possible to include this driver in a separate directory (maybe called src/opennebula) cause src/ directory is already very crowded. Regards, P

[libvirt] [PATCH 2/2]: Remove getURI internal driver call

2009-03-30 Thread Chris Lalancette
This patch removes the internal getURI() driver callback. It was *never* overridden by any of the drivers, so it seems kind of pointless (I even checked the "in-progress" VirtualBox, OpenNebula, and Power Hypervisor drivers). In addition, the code to actually use it in src/libvirt.c:virConnectGet

[libvirt] [PATCH 1/2]: Convert internal drivers to old style struct initializers

2009-03-30 Thread Chris Lalancette
This patch converts the internal drivers to use the old-style struct initializers, which kind of gives us a self-documenting TODO list for each of the drivers. It also fixes up some bad comments in the internal driver list. It does not touch the storage or network driver initializers. Signed-off-

[libvirt] [PATCH 0/2]: Cleanup driver initializers

2009-03-30 Thread Chris Lalancette
All, This is a small series to cleanup the internal driver initializers. The drivers were using an annoying combination of C-99 style initialization and old-style (C89?) initialization. On top of that, the indentation on some of these was wacky, making it even harder to read. After some dis

[libvirt] PATCH: Misc error handling / OOM fixes

2009-03-30 Thread Daniel P. Berrange
I ran the OOM checking test suite again and uncovered a handful of pretty minor bugs - no crashers in real code - just forgetting to report OOM correctly * src/datatypes.c: Convert to use the virReportErrorHelper macro instead of a static function, so we get correct function/line number in

Re: [libvirt] [Fwd: first cut public API for physical host interface configuration]

2009-03-30 Thread Daniel P. Berrange
On Fri, Mar 27, 2009 at 12:58:44PM -0400, Laine Stump wrote: > To summarize (correct anything I've gotten wrong): > > 1) Supporting transient interfaces would be nice, but would require too > much re-implementation of ifup-type scripts in our code (and for every > platorm), so it is out of scope

Re: [libvirt] [PATCH 1/1] Add SCSI pool support.

2009-03-30 Thread Daniel P. Berrange
On Sat, Mar 28, 2009 at 10:40:48AM -0400, Dave Allan wrote: > Daniel P. Berrange wrote: > > >This unfortauntely does not work on RHEL5, because there are no targetX.X.X > >links here. Only the LUNs appear in this directory. > > > >The location which appears to be present on both old and new kernel

Re: [libvirt] [PATCH 1/1] Add SCSI pool support.

2009-03-30 Thread Daniel P. Berrange
On Fri, Mar 27, 2009 at 11:51:57AM -0400, Dave Allan wrote: > Daniel P. Berrange wrote: > > > >Spot the obvious mistake... > > > > > >virStorageBackendWaitForDevices(conn); > > > >if ((session = virStorageBackendISCSISession(conn, pool, 0)) == NULL) > >goto cleanup; > >if (virSt

Re: [libvirt] KVM update

2009-03-30 Thread Daniel P. Berrange
On Mon, Mar 30, 2009 at 11:44:06AM +0300, Zvi Dubitzky wrote: > I am trying to update the kvm driver and userspace using existing kernel > 1) using the tar ball from kvm at sourceforge I can do it , but only kvm > -84 is there > 2) if i try the latest version from the git tree I am able to do t

Re: [libvirt] [RFC] Power Hypervisor Libvirt support

2009-03-30 Thread Daniel P. Berrange
On Fri, Mar 27, 2009 at 05:33:43PM -0300, Eduardo Otubo wrote: > > > @@ -714,6 +716,21 @@ AM_CONDITIONAL([HAVE_NUMACTL], [test "$with_numactl" > > > != "no"]) > > > AC_SUBST([NUMACTL_CFLAGS]) > > > AC_SUBST([NUMACTL_LIBS]) > > > > > > +if test "$with_phyp" = "yes"; then > > > + AC_CHECK_LIB([

Re: [libvirt] "invalid connection pointer in virConnectClose" from Python bindings

2009-03-30 Thread Daniel P. Berrange
On Sun, Mar 29, 2009 at 11:36:36PM -0500, Charles Duffy wrote: > Howdy. > > I'm calling libvirt from a program which occasionally has cause to > fork() without an immediate exec(). For the sake of simplicity, I > presently call close() on all my virConnect objects [which I then > delete] before

Re: [libvirt] [PATCH] additional options in the spec file for storage drivers and numactl

2009-03-30 Thread Daniel P. Berrange
On Mon, Mar 30, 2009 at 12:50:09AM +0900, Ryota Ozaki wrote: > Hi, > > This patch adds switches in the spec file for storage drivers and numactl > to be easy to turn on/off options of configure. ACK daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http:

Re: [libvirt] [PATCH] prevent an executed external process to be a zombie

2009-03-30 Thread Daniel P. Berrange
On Mon, Mar 30, 2009 at 12:49:55AM +0900, Ryota Ozaki wrote: > Hi, > > This patch prevents an executed external process to be a zombie > by doing waitpid() even if virPipeReadUntilEOF() fails. ACK patch looks good NB, can you fix your mail client so that it attaches patches with MIME type of 'te

Re: [libvirt] KVM update

2009-03-30 Thread Dor Laor
Zvi Dubitzky wrote: I am trying to update the kvm driver and userspace using existing kernel 1) using the tar ball from kvm at sourceforge I can do it , but only kvm -84 is there 2) if i try the latest version from the git tree I am able to do the first 2 steps (make --kerneldir= , make sync

[libvirt] KVM update

2009-03-30 Thread Zvi Dubitzky
I am trying to update the kvm driver and userspace using existing kernel 1) using the tar ball from kvm at sourceforge I can do it , but only kvm -84 is there 2) if i try the latest version from the git tree I am able to do the first 2 steps (make --kerneldir= , make sync ) . but the final m