Re: [libvirt] [PATCH 1/2] (Updated & fixed) OpenNebula driver, libvirt-0.6.2

2009-04-22 Thread Abel Míguez Rodríguez
> > domain) { break; > case VIR_FROM_VBOX: >  dom = "VBOX "; > +    case VIR_FROM_ONE: > +    dom = "ONE "; > >    break; > >  } > >  return(dom); > > there is break missing here. will cause subtle errors if not failures. You are right, a mistake

[libvirt] [PATCH 1/2] (Updated & fixed) OpenNebula driver, libvirt-0.6.2

2009-04-22 Thread Abel Míguez Rodríguez
Hi all, Here is the One driver & patches for the current git's master commit "9e9527 - Remove stale QEMU pidfiles". [PATCH 1/2] Patch to be applied to libvirt-0.6.2 sources and building files. [PATCH 2/2] Driver source code. Thanks for all the comments about the patches. We waited for the libvi

Re: [libvirt] [PATCH 1/2] (Updated & fixed) OpenNebula driver, libvirt-0.6.2

2009-04-22 Thread Pritesh Kothari
Hi Abel >- Included driver's files in a different directory "src/opennebula" Great, wouldn't crowd the src/ directory anymore, thanks. > domain) { break; > case VIR_FROM_VBOX: > dom = "VBOX "; > +case VIR_FROM_ONE: > +dom = "ONE "; > break;