Re: [libvirt] SetMaxMemory vs. SetMemory

2009-05-21 Thread Matthias Bolte
2009/5/21 Chris Lalancette : > Well, this is because of a peculiarity with Xen PV domains.  In Xen PV guests, > you specify a "maxmem" and a "memory" parameter in the configuration file.   > The > "maxmem" parameter is presented to the guest as the end of the e820 map, hence > the end of real memor

Re: [libvirt] Works: libvirt client on OS X 10.5.6

2009-05-21 Thread Schley Andrew Kutz
I didn't see your earlier response on those. As for WEXITSTATUS I have no idea why it broke, but as it always compared it to Zero anyway, I just short circuited the evaluation. The MACOSX_DEPLOYMENT_TARGET is a different kind of issue. The libraries that libvirt links to, gnutls and its dep

Re: [libvirt] Works: libvirt client on OS X 10.5.6

2009-05-21 Thread Schley Andrew Kutz
I will create a specific sub-dir and let you know. -- -a "Ideally, a code library must be immediately usable by naive developers, easily customized by more sophisticated developers, and readily extensible by experts." -- L. Stein On May 20, 2009, at 3:20 AM, Daniel Veillard wrote: On

Re: [libvirt] [PATH 0/5] CORRECTED - Interface Config Public APIs and remote stubs, with MAC addresses in string format

2009-05-21 Thread Laine Stump
On 05/20/2009 10:35 AM, Daniel Veillard wrote: Now can you double check src/libvirt_private.syms in case more are missing ? Ah, I hadn't seen that file - I was basing my work on a few other sets of patches, and they didn't modify that file, so it fell under my radar. Should virUnrefInterfac

Re: [libvirt] SetMaxMemory vs. SetMemory

2009-05-21 Thread Chris Lalancette
Matthias Bolte wrote: > Hello, > > I just took a look at the driver functions for SetMaxMemory and > SetMemory, as they are not implemented yet for the ESX driver and > Daniel Veillard was a bit surprised that they are missing, as he > expects them to be simple to implement. The problem is that I'

[libvirt] SetMaxMemory vs. SetMemory

2009-05-21 Thread Matthias Bolte
Hello, I just took a look at the driver functions for SetMaxMemory and SetMemory, as they are not implemented yet for the ESX driver and Daniel Veillard was a bit surprised that they are missing, as he expects them to be simple to implement. The problem is that I'm not sure how the memory model of

[libvirt] PATCH: Ensure filename/funcname/linenr gets passed to error func

2009-05-21 Thread Daniel P. Berrange
The current virRaiseError() function does not accept any information about these source location of the error. The various virReportSystemError and virReportOOMError wrappers all collect this info, but then discard it. This patch turns virRaiseError into virRaiseErrorFull() and adds params for li

Re: [libvirt] storage: inconsistent in 'format' scheme between document and implementation

2009-05-21 Thread Ryota Ozaki
On Thu, May 21, 2009 at 11:35 PM, Daniel P. Berrange wrote: > On Thu, May 21, 2009 at 11:29:33PM +0900, Ryota Ozaki wrote: >> Anyway, we need to keep RNG schemas valid though, I've found errors >> in storagevol.rng through trying xmllint... (e.g., the 'volume' element >> does not allow 'type' attr

Re: [libvirt] storage: inconsistent in 'format' scheme between document and implementation

2009-05-21 Thread Daniel P. Berrange
On Thu, May 21, 2009 at 11:29:33PM +0900, Ryota Ozaki wrote: > Anyway, we need to keep RNG schemas valid though, I've found errors > in storagevol.rng through trying xmllint... (e.g., the 'volume' element > does not allow 'type' attribute.) We have a test case which validates a number of example X

Re: [libvirt] storage: inconsistent in 'format' scheme between document and implementation

2009-05-21 Thread Ryota Ozaki
On Thu, May 21, 2009 at 7:05 PM, Daniel P. Berrange wrote: > On Thu, May 21, 2009 at 10:46:11AM +0200, Daniel Veillard wrote: >> On Thu, May 21, 2009 at 05:25:35PM +0900, Ryota Ozaki wrote: >> > Yes, I also checked that. >> > >> > BTW, is the schema file used by libvirtd or drivers? This is just i

Re: [libvirt] PATCH: Impl python bindings for virInterface

2009-05-21 Thread Daniel P. Berrange
On Thu, May 21, 2009 at 10:09:08AM -0400, Laine Stump wrote: > On 05/21/2009 03:49 AM, Daniel Veillard wrote: > >On Wed, May 20, 2009 at 05:45:36PM +0100, Daniel P. Berrange wrote: > > > >>We forgot that adding the virInterface APIs would break the build of the > >>python bindings. Here is the pa

Re: [libvirt] PATCH: Impl python bindings for virInterface

2009-05-21 Thread Laine Stump
On 05/21/2009 03:49 AM, Daniel Veillard wrote: On Wed, May 20, 2009 at 05:45:36PM +0100, Daniel P. Berrange wrote: We forgot that adding the virInterface APIs would break the build of the python bindings. Here is the patch to wire up the code generator for the new APIs. This is actually surpr

Re: [libvirt] storage: inconsistent in 'format' scheme between document and implementation

2009-05-21 Thread Ryota Ozaki
On Thu, May 21, 2009 at 5:46 PM, Daniel Veillard wrote: > On Thu, May 21, 2009 at 05:25:35PM +0900, Ryota Ozaki wrote: >> Yes, I also checked that. >> >> BTW, is the schema file used by libvirtd or drivers? This is just interest. > >  We don't use them in the libvirt code themselves (though it wou

Re: [libvirt] PATCH: Work in progress suport for video device config

2009-05-21 Thread Daniel P. Berrange
On Tue, May 19, 2009 at 02:51:07PM +0200, Pritesh Kothari wrote: > On Tuesday 19 May 2009 11:35:40 Daniel P. Berrange wrote: > > diff -r 66fa9bfc797c src/domain_conf.h > > --- a/src/domain_conf.h Mon May 18 11:28:46 2009 +0100 > > +++ b/src/domain_conf.h Mon May 18 11:29:00 2009 +0100 > > @

Re: [libvirt] [PATCH]: Secure migration support for KVM

2009-05-21 Thread Daniel P. Berrange
On Tue, May 12, 2009 at 01:55:47PM +0200, Chris Lalancette wrote: > All, > Attached is the secure migration patch for libvirt. What this patch > implements is a new remote RPC call for secure migration. On the source of > the > migration, we do a migration from the qemu process to the libvi

Re: [libvirt] storage: inconsistent in 'format' scheme between document and implementation

2009-05-21 Thread Daniel P. Berrange
On Thu, May 21, 2009 at 10:46:11AM +0200, Daniel Veillard wrote: > On Thu, May 21, 2009 at 05:25:35PM +0900, Ryota Ozaki wrote: > > Yes, I also checked that. > > > > BTW, is the schema file used by libvirtd or drivers? This is just interest. > > We don't use them in the libvirt code themselves

Re: [libvirt] storage: inconsistent in 'format' scheme between document and implementation

2009-05-21 Thread Daniel P. Berrange
On Thu, May 21, 2009 at 03:57:28PM +0900, Ryota Ozaki wrote: > Hi, > > I've found a problem that a 'format' element in storage-{pool,vol} XML > doesn't behave as described in the document. > > The document says that a format of {pool,vol} is specified as the value of > a format element, like: >

Re: [libvirt] VMware ESX driver announcement

2009-05-21 Thread Daniel P. Berrange
On Thu, May 21, 2009 at 02:54:46AM +0200, Matthias Bolte wrote: > 2009/5/19 Daniel Veillard : > >> diff --git a/src/esx_driver.c b/src/esx_driver.c > >> new file mode 100644 > >> index 000..28500b8 > >> --- /dev/null > >> +++ b/src/esx_driver.c > >> @@ -0,0 +1,1385 @@ > > [...] > >> +#define ES

Re: [libvirt] storage: inconsistent in 'format' scheme between document and implementation

2009-05-21 Thread Daniel Veillard
On Thu, May 21, 2009 at 05:25:35PM +0900, Ryota Ozaki wrote: > Yes, I also checked that. > > BTW, is the schema file used by libvirtd or drivers? This is just interest. We don't use them in the libvirt code themselves (though it would be relatively trivial to ask libxml2 to validate instances w

Re: [libvirt] storage: inconsistent in 'format' scheme between document and implementation

2009-05-21 Thread Ryota Ozaki
On Thu, May 21, 2009 at 5:01 PM, Daniel Veillard wrote: > On Thu, May 21, 2009 at 03:57:28PM +0900, Ryota Ozaki wrote: >> Hi, >> >> I've found a problem that a 'format' element in storage-{pool,vol} XML >> doesn't behave as described in the document. >> >> The document says that a format of {pool,

Re: [libvirt] storage: inconsistent in 'format' scheme between document and implementation

2009-05-21 Thread Daniel Veillard
On Thu, May 21, 2009 at 03:57:28PM +0900, Ryota Ozaki wrote: > Hi, > > I've found a problem that a 'format' element in storage-{pool,vol} XML > doesn't behave as described in the document. > > The document says that a format of {pool,vol} is specified as the value of > a format element, like: >

Re: [libvirt] PATCH: Impl python bindings for virInterface

2009-05-21 Thread Daniel Veillard
On Wed, May 20, 2009 at 05:45:36PM +0100, Daniel P. Berrange wrote: > We forgot that adding the virInterface APIs would break the build of the > python bindings. Here is the patch to wire up the code generator for > the new APIs. This is actually surprisingly easy, since we ditched the > raw unsign