Thanks for the review.
> -Original Message-
> From: Dave Allan [mailto:dal...@redhat.com]
> Sent: Saturday, September 26, 2009 2:43 AM
> To: Iyer, Shyam
> Cc: libvir-list@redhat.com; Bellad, Sudhir; Domsch, Matt; KM, Paniraja
> Subject: Re: [libvirt] [RFC] Multi-IQN proposal
>
> shyam_i..
There appears to be a race condition wherein a 'cont' command sent
immediately on qemu startup can prevent a inbound migration specified
via -incoming from occurring. libvirt's process for starting up qemu
domains with an incoming migration includes with a 'cont' command at the
end of qemudInit
I tracked down a memleak in libvirtd's message processing. The leak
was introduced in commit 47cab734995fa9521b1df05d37e9978eedd8d3a2
"Split out code for handling incoming method call messages". This
commit changed the way qemud_client_message objects were reused.
Before this commit:
- qemudWorke
Howdy, all.
I maintain a test infrastructure which makes heavy use of virDomainSave
and virDomainRestore, and have been seeing occasional cases where my
saved images are for some reason not restored correctly -- and, indeed,
the incoming migration streams are not even read in their entirety.
On Fri, 25 Sep 2009, Jamie Strandboge wrote:
> [PATCH 3]
> patch_3_docs.patch (Updated based on prior feedback):
> Updates docs/drvqemu.html.in for AppArmor and adds profile examples to
> examples/apparmor. Updated based on prior feedback.
--
Jamie Strandboge | http://www.canonical.c
On Fri, 25 Sep 2009, Jamie Strandboge wrote:
> [PATCH 1]
> patch_1_reenable-nonfile-labels.patch (Updated based on prior feedback):
> When James Morris originally submitted his sVirt patches (as seen in
> libvirt 0.6.1), he did not require on disk labelling for
> virSecurityDomainRestoreImageLabel
Resubmitting again based on feedback from this list. Notably, the driver
has been reworked to use:
xml = virDomainDefFormat(conn, vm->def, ...
Then the helper program uses:
ctl->def = virDomainDefParseString(... xmlStr ...);
This simplifies adding new files. Part of this process involved ad
shyam_i...@dell.com wrote:
Would this proposal be acceptable ?
In principle, I think what you're proposing is reasonable, and is
certainly contemplated by the iSCSI specs.
Example XML schema for an iSCSI storage pool created --
dell
cf354733-b01b-8870-2040-94888640e24d
0
0
0
-
> -Original Message-
> From: Domsch, Matt
> Sent: Saturday, September 26, 2009 1:01 AM
> To: Iyer, Shyam; 'libvir-list@redhat.com'
> Cc: Bellad, Sudhir; KM, Paniraja
> Subject: RE: [RFC] Multi-IQN proposal
>
> Do you also need to specify the expected mapping of initiator IQN to
> use for
Do you also need to specify the expected mapping of initiator IQN to use
for each target IQN, or is that not necessary?
--
Matt Domsch
Technology Strategist, Dell Office of the CTO
linux.dell.com & www.dell.com/linux
-Original Message-
From: Iyer, Shyam
Sent: Friday, September 25, 2009
Would this proposal be acceptable ?
Example XML schema for an iSCSI storage pool created --
dell
cf354733-b01b-8870-2040-94888640e24d
0
0
0
-
-
/dev/disk/by-path
-
0700
0
0
On Fri, Sep 25, 2009 at 02:27:33PM +0100, Mark McLoughlin wrote:
> Use virStorageFileProbeHeader() to find any backing stores for images
> and re-label them
>
> Without this, qemu cannot access qcow2 backing files, see:
>
> https://bugzilla.redhat.com/497131
>
> * src/security/security_selinux
On Fri, Sep 25, 2009 at 02:27:31PM +0100, Mark McLoughlin wrote:
> Rename virStorageBackendUpdateVolTargetInfo to virStorageFileGetInfo()
> and move to util/storage_file.[ch]
>
> * src/storage/storage_backend.[ch]: move code from here ...
>
> * src/util/storage_file.[ch]: ... to here
>
> * src/l
On Fri, Sep 25, 2009 at 02:27:32PM +0100, Mark McLoughlin wrote:
>
> +int virStorageFileProbeHeader(virConnectPtr conn,
> + const char *path,
> + int *format,
> + char **backingStore,
> +
On Fri, Sep 25, 2009 at 02:27:30PM +0100, Mark McLoughlin wrote:
> Rename to virStorageFilePerms and move to util/storage_file.[ch]
>
> * src/conf/storage_conf.h: move perms struct from here ...
>
> * src/util/storage_file.h: ... to here
>
> * src/conf/storage_conf.c: update
> ---
> src/conf/st
On Fri, Sep 25, 2009 at 02:27:29PM +0100, Mark McLoughlin wrote:
> Renam virStorageVolFormatFileSystem to virStorageFileFormat and
> move to src/util/storage_file.[ch]
>
> * src/Makefile.am: add src/util/storage_file.[ch]
>
> * src/conf/storage_conf.[ch]: move enum from here ...
>
> * src/util/s
On Fri, Sep 25, 2009 at 02:27:28PM +0100, Mark McLoughlin wrote:
> This is so we can use it in the storage file probing code which is
> also moving to src/util
>
> The real code change is renaming virStorageReportError() to
> virStorageEncryptionReportError()
>
> * src/util/storage_encryption.[c
On Fri, Sep 25, 2009 at 02:27:27PM +0100, Mark McLoughlin wrote:
> Seems standard to include internal.h in order to pull in libvirt.h
>
> * src/util/util.h: include internal.h
> ---
> src/util/util.h |1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
There don't appear to be any compil
On Fri, Sep 25, 2009 at 02:42:47PM +0100, Daniel P. Berrange wrote:
> On Fri, Sep 25, 2009 at 03:33:41PM +0200, Daniel Veillard wrote:
> > On Fri, Sep 25, 2009 at 01:28:51PM +0100, Daniel P. Berrange wrote:
> > I'm still waiting to see what this gives in the HTML docs :-)
>
> Hmm, I didn't check t
On Fri, Sep 25, 2009 at 02:27:23PM +0100, Daniel P. Berrange wrote:
> On Tue, Sep 22, 2009 at 02:43:20PM +0200, Daniel Veillard wrote:
> > [ Sending again due to mail output problems ]
> >
> > On Thu, Sep 17, 2009 at 06:25:01PM +0100, Daniel P. Berrange wrote:
> > > Introduces several new public A
On Fri, Sep 25, 2009 at 02:09:54PM +0100, Daniel P. Berrange wrote:
> On Fri, Sep 25, 2009 at 02:32:39PM +0200, Daniel Veillard wrote:
> > Hum, this would then raise the signal that stream can be used
> > both ways, do we really want to suggest this at the API level,
> > I can see how we're gonna
On Fri, Sep 25, 2009 at 03:33:41PM +0200, Daniel Veillard wrote:
> On Fri, Sep 25, 2009 at 01:28:51PM +0100, Daniel P. Berrange wrote:
> > The python method help docs are copied across from the C
> > funtion comments, but in the process all line breaks and
> > indentation was being lost. This made
On Fri, Sep 25, 2009 at 01:28:51PM +0100, Daniel P. Berrange wrote:
> The python method help docs are copied across from the C
> funtion comments, but in the process all line breaks and
> indentation was being lost. This made the resulting text
> and code examples completely unreadable. Both the AP
On Fri, Sep 25, 2009 at 03:03:27PM +0200, Wolfgang Mauerer wrote:
> Daniel P. Berrange wrote:
> > On Fri, Sep 18, 2009 at 05:26:10PM +0200, Wolfgang Mauerer wrote:
> >> This augments virDomainDevice with a element
> >> that is used to represent disk controllers (e.g., scsi
> >> controllers). The X
Finally, we get to the point of all this.
Rename virStorageBackendProbeTarget() to virStorageFileProbeHeader()
and move to src/util/storage_file.[ch]
* src/storage/storage_backend_fs.c: move code from here ...
* src/util/storage_file.[ch]: ... to here
* src/libvirt_private.syms: export virStora
Rename to virStorageFilePerms and move to util/storage_file.[ch]
* src/conf/storage_conf.h: move perms struct from here ...
* src/util/storage_file.h: ... to here
* src/conf/storage_conf.c: update
---
src/conf/storage_conf.c |2 +-
src/conf/storage_conf.h | 18 +++---
src/util
Rename virStorageBackendUpdateVolTargetInfo to virStorageFileGetInfo()
and move to util/storage_file.[ch]
* src/storage/storage_backend.[ch]: move code from here ...
* src/util/storage_file.[ch]: ... to here
* src/libvirt_private.syms: export new functions
* src/storage/storage_backend_fs.c, sr
Use virStorageFileProbeHeader() to find any backing stores for images
and re-label them
Without this, qemu cannot access qcow2 backing files, see:
https://bugzilla.redhat.com/497131
* src/security/security_selinux.c: re-label backing store files in
SELinuxSetSecurityImageLabel()
---
src/sec
This is so we can use it in the storage file probing code which is
also moving to src/util
The real code change is renaming virStorageReportError() to
virStorageEncryptionReportError()
* src/util/storage_encryption.[ch]: add
* src/conf/storage_encryption_conf.[ch]: remove
* src/conf/domain_con
Renam virStorageVolFormatFileSystem to virStorageFileFormat and
move to src/util/storage_file.[ch]
* src/Makefile.am: add src/util/storage_file.[ch]
* src/conf/storage_conf.[ch]: move enum from here ...
* src/util/storage_file.[ch]: .. to here
* src/libvirt_private.syms: update To/FromString ex
Hey,
https://bugzilla.redhat.com/497131 shows that sVirt cannot
currently handle qcow2 files with a backing store. Because we do
not re-label the backing store, qemu cannot read it.
The fix is fairly straightforward - when we go to re-label
a file, check its header and if it has a
Seems standard to include internal.h in order to pull in libvirt.h
* src/util/util.h: include internal.h
---
src/util/util.h |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/src/util/util.h b/src/util/util.h
index dbfdc45..77f50ed 100644
--- a/src/util/util.h
+++ b/src/uti
On Tue, Sep 22, 2009 at 02:43:20PM +0200, Daniel Veillard wrote:
> [ Sending again due to mail output problems ]
>
> On Thu, Sep 17, 2009 at 06:25:01PM +0100, Daniel P. Berrange wrote:
> > Introduces several new public API options for migration
> >
> > - VIR_MIGRATE_PEER2PEER: With this flag the
On Thu, Sep 24, 2009 at 11:39:08PM +0200, Matthias Bolte wrote:
> 2009/9/24 Daniel P. Berrange :
> >
> > Outside the scope of your patches, I think it would be
> > worth adding a 'name' attribute to all devices in the
> > libvirt XML as a standardized unique identifier. We
> > already have to keep
On Fri, Sep 25, 2009 at 02:32:39PM +0200, Daniel Veillard wrote:
> On Fri, Sep 25, 2009 at 12:25:50PM +0100, Daniel P. Berrange wrote:
>
> > if we needed more than just plain flags.
> >
> >
> > On the subject of flags though, I've never been entirely sure
> > about whether it would be worth mand
Matthias Bolte wrote:
> 2009/9/24 Daniel P. Berrange :
>> Outside the scope of your patches, I think it would be
>> worth adding a 'name' attribute to all devices in the
>> libvirt XML as a standardized unique identifier. We
>> already have to keep track of a 'name' internally for
>> NIC hotplug wi
Daniel P. Berrange wrote:
> On Fri, Sep 18, 2009 at 05:26:09PM +0200, Wolfgang Mauerer wrote:
>> This allows us to connect a disk with a specific controller,
>> which is required for disk hotadd/remove. A new XML child
>> element is added to the container:
>>
>>
>> ...
>> > unit=""/>
>>
>>
Daniel P. Berrange wrote:
> On Fri, Sep 18, 2009 at 05:26:10PM +0200, Wolfgang Mauerer wrote:
>> This augments virDomainDevice with a element
>> that is used to represent disk controllers (e.g., scsi
>> controllers). The XML format is given by
>>
>>
>>
>>
>>
>> where type denotes the disk in
Daniel P. Berrange wrote:
> On Fri, Sep 18, 2009 at 05:26:16PM +0200, Wolfgang Mauerer wrote:
>> Since both disks and disk controllers can be dynamically
>> added to the system, it makes sense to be also able to remove
>> them.
>
> This is the main patch which requires additional support in QEMu
>
Daniel P. Berrange wrote:
> On Fri, Sep 18, 2009 at 05:26:12PM +0200, Wolfgang Mauerer wrote:
>> This enables to hot-add disk controllers without attached
>> disks into the system. Previously, it was only possible to
>> (implicitly) add disk controllers in the static machine
>> configuration.
>>
>>
On Fri, Sep 25, 2009 at 01:28:51PM +0100, Daniel P. Berrange wrote:
> The python method help docs are copied across from the C
> funtion comments, but in the process all line breaks and
> indentation was being lost. This made the resulting text
> and code examples completely unreadable. Both the AP
On Fri, Sep 25, 2009 at 10:41:08AM +0100, Daniel P. Berrange wrote:
> On Thu, Sep 24, 2009 at 10:13:15PM +0200, Matthias Bolte wrote:
> > 2009/9/24 Daniel P. Berrange :
> > > * src/libvirt.c: Remove hand-crafted UUID parsers in favour of
> > > calling virParseUUID
> >
> > s/virParseUUID/virUUIDPa
On Fri, Sep 25, 2009 at 12:25:50PM +0100, Daniel P. Berrange wrote:
> On Fri, Sep 25, 2009 at 12:09:34PM +0200, Daniel Veillard wrote:
> > On Mon, Aug 24, 2009 at 09:51:04PM +0100, Daniel P. Berrange wrote:
> > > @@ -1448,6 +1466,81 @@ void virEventRegisterImpl(virEventAddHandleFunc
> > > addHandl
The python method help docs are copied across from the C
funtion comments, but in the process all line breaks and
indentation was being lost. This made the resulting text
and code examples completely unreadable. Both the API
doc extractor and the python generator were destroying
whitespace & this f
On Fri, Sep 25, 2009 at 12:09:34PM +0200, Daniel Veillard wrote:
> On Mon, Aug 24, 2009 at 09:51:04PM +0100, Daniel P. Berrange wrote:
> > @@ -1448,6 +1466,81 @@ void virEventRegisterImpl(virEventAddHandleFunc
> > addHandle,
> >virEventAddTimeoutFunc addTimeout,
> >
On Fri, Sep 25, 2009 at 09:58:51AM +0200, Daniel Veillard wrote:
> On Mon, Aug 24, 2009 at 09:51:03PM +0100, Daniel P. Berrange wrote:
>
> Okay, this is very similar in principle with HTTP pipelining
> with IMHO the same benefits and the same potential drawbacks.
> A couple of things to check mi
On Mon, Aug 24, 2009 at 09:51:07PM +0100, Daniel P. Berrange wrote:
> * qemud/stream.c: Handle incoming stream data packets, queuing until
> stream becomes writable. Handle stream completion handshake
> * po/POTFILES.in: Add qemud/stream.c
[...]
> +/*
> + * Callback that gets invoked when a strea
On Mon, Aug 24, 2009 at 09:51:06PM +0100, Daniel P. Berrange wrote:
> Defines the extensions to the remote protocol for generic
> data streams. Adds a bunch of helper code to the libvirtd
> daemon for working with data streams.
>
> * qemud/Makefile.am: Add stream.c/stream.h to build
> * qemud/stre
On Mon, Aug 24, 2009 at 09:51:04PM +0100, Daniel P. Berrange wrote:
> * include/libvirt/libvirt.h, include/libvirt/libvirt.h.in: Public
> API contract for virStreamPtr object
> * src/libvirt_public.syms: Export data stream APIs
> * src/libvirt_private.syms: Export internal helper APIs
> * src/lib
Hi Chris Lalancette,
Thanks for responding to my e-mail.
I tried the virsh migrate --live command and checked for the libvirtd service.
It is still running.
[r...@rhel53xen1 ~]# xm list
Name ID Mem(MiB) VCPUs State Time(s)
Copy_RHELVM3
On Thu, Sep 24, 2009 at 02:08:00PM -0400, Dave Allan wrote:
> I've been looking at implementing a libudev backed node device, and I
> noticed that the devicekit node device backend doesn't build. Since I
> believe DeviceKit is deprecated for this sort of use, and AFAIK the
> DeviceKit support w
On Thu, Sep 24, 2009 at 10:13:15PM +0200, Matthias Bolte wrote:
> 2009/9/24 Daniel P. Berrange :
> > * src/libvirt.c: Remove hand-crafted UUID parsers in favour of
> > calling virParseUUID
>
> s/virParseUUID/virUUIDParse/
>
> > ---
> > src/libvirt.c | 56
> > +
On Thu, Sep 24, 2009 at 01:02:24PM +0200, Chris Lalancette wrote:
> Charles Duffy wrote:
> > HACKING suggests compiling with --enable-compile-warnings=error before
> > submitting any patches; however, current master fails for me on this
> > account (CentOS 5.3; gcc 4.1.2).
> >
> > Please see att
> ACK to this patch btw, it does solve the problem in SuSE distros where
> device-mapper-devel is missing pkgconfig file. But the problem is
> really a bug in the devel package, so will this workaround be committed
> to libvirt configure script?
Afaics, the opensuse patch has been sent and is now
Subba Rao, Sandeep M (STSD) wrote:
> Hi,
>
> I'm trying to live move a domU using virsh migrate command:
>
> [r...@rhel53xen1 ~]# xm list
> Name ID Mem(MiB) VCPUs State Time(s)
> Copy_RHELVM3 1 511 1 -b898.3
>
On Mon, Aug 24, 2009 at 09:51:03PM +0100, Daniel P. Berrange wrote:
> The following series of patches introduce support for generic data
> streams in the libvirt API, the remote protocol, client & daemon.
>
> The public API takes the form of a new object virStreamPtr and
> methods to read/write/cl
Mark Hamzy wrote:
> The stack trace is as follows:
>
> Program received signal SIGABRT, Aborted.
> 0x0035ad830265 in raise () from /lib64/libc.so.6
> (gdb) bt
> #0 0x0035ad830265 in raise () from /lib64/libc.so.6
> #1 0x0035ad831d10 in abort () from /lib64/libc.so.6
> #2 0x0035ad86
57 matches
Mail list logo
