[PATCH] Re: [libvirt] Silently ignored virDomainRestore failures

2009-10-01 Thread Charles Duffy
Charles Duffy wrote: For existing QEMU, it might be sufficient to just put an arbitrary 'sleep(5)' before issuing 'cont', which would at least give it a reasonable chance of avoiding the race condition. Well -- I wasn't going to submit the patch I'm now using internally (using and w

[libvirt] [PATCH 2/1] Non-support for VIR_MIGRATE_TUNNELLED

2009-10-01 Thread Paolo Bonzini
This is just an example. Unlike the previous patch, this one of course is not ready for committing. * include/libvirt/libvirt.h.in: Add VIR_MIGRATE_TUNNELLED. * src/libvirt.c: Implement non-support for VIR_MIGRATE_TUNNELLED. * src/virsh.c: Add --tunnelled arg to virsh migrate. --- include/libvir

[libvirt] [PATCH 1/1] Support a new peer-to-peer migration mode

2009-10-01 Thread Paolo Bonzini
This patch introduces a peer-to-peer migration protocol where the client only invokes the virDomainMigratePerform method, expecting the source host driver to do whatever is required to complete the entire migration process. This method is used by virsh whenever the hypervisor supports it and the d

[libvirt] [PATCH 4/6] add virsh --suspend

2009-10-01 Thread Paolo Bonzini
This adds a new flag, VIR_MIGRATE_PAUSED, that mandates pausing the migrated VM before starting it. * include/libvirt/libvirt.h.in (virDomainMigrateFlags): Add VIR_MIGRATE_PAUSED. * src/libvirt.c (virDomainMigrateVersion2): "Optimize" combination of VIR_MIGRATE_LIVE and VIR_MIGRATE_PAUSED. * src/q

[libvirt] [PATCH 6/6] restore correctly the state of the VM upon migration

2009-10-01 Thread Paolo Bonzini
In order to correctly pass the paused/unpaused state on the remote side, we use the newly introduced return code of qemudDomainMigratePerform. The return code does not need to be public (it is internal to the QEMU driver). A return code of 0 specifies the old behavior. * src/qemu/qemu_driver.c (

[libvirt] [PATCH 0/6] correctly migrate paused VMs (and a bunch of bugfixes)

2009-10-01 Thread Paolo Bonzini
Currently, the QEMU driver tries to migrate paused VMs, but the effect is that the migrated virtual machine will always run on the destination. Furthermore, the state is erroneously stored as paused, so that the driver is left confused and it is not possible to re-pause the VM without doing a (use

[libvirt] [PATCH 5/6] allow non-zero success values from a domain's MigratePerform

2009-10-01 Thread Paolo Bonzini
A return code of say 1 from Perform is currently considered an error, but it could also be passed simply to Finish. This makes the v2 protocol much more powerful. * src/remote/remote_protocol.x (remote_domain_migrate_perform_ret): New. * src/qemu/qemu_driver.c (qemudDomainMigrateFinish2): Succeed

[libvirt] [PATCH 3/6] fix migration of paused vms upon failure

2009-10-01 Thread Paolo Bonzini
This makes a small change on the failed-migration path. Up to now, all VMs that failed non-live migration after the "stop" command were restarted. This must not be done when the VM was paused in the first place. * src/qemu/qemu_driver.c (qemudDomainMigratePerform): Do not restart a paused VM tha

[libvirt] [PATCH 2/6] unbreak `make rpcgen'

2009-10-01 Thread Paolo Bonzini
Fix "make rpcgen", broken by the directory reorganization. * src/Makefile.am (rpcgen): Fix path to rpcgen_fix.pl. --- src/Makefile.am |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am index de7765c..f3d4559 100644 --- a/src/Makefile.am +

[libvirt] [PATCH 1/6] unbreak migration

2009-10-01 Thread Paolo Bonzini
Fix migration, broken in two different ways by the QEMU monitor abstraction. Note that the QEMU console emits a "\r\n" as the line-ending. * src/qemu/qemu_monitor_text.c (qemuMonitorGetMigrationStatus): Fix "info migrate" command and its output's parsing. --- src/qemu/qemu_monitor_text.c |4

Re: [libvirt] [PATCH 13/27] Add API for running 'info migration' monitor command

2009-10-01 Thread Paolo Bonzini
-if (qemudMonitorCommand(vm, "info migrate",&info)< 0) { +if (qemudMonitorCommand(vm, "info migration",&reply)< 0) { Uhm. Will send a patch soon. :-) Paolo -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] getting notified of events

2009-10-01 Thread Dan Kenigsberg
I am trying to understand how to use the virEvent* API. I've built latest libvirt (with "Fix emission of domain events messages" commit) and run the domain-events example. events-c gives me mostly silence. nothing is printed when a domain changes state. events-python is more bizarre: it prints a

[libvirt] Re: [virt-tools-list] Some VMs not starting at host boot

2009-10-01 Thread Daniel Huhardeaux
Cole Robinson a écrit : On 10/01/2009 11:07 AM, Daniel Huhardeaux wrote: Hi, 3 VMs on a host, all in autostart: the both where are not started automagically on host startup. They start without problem from virsh. The one having has no problem. Any i

Re: [libvirt] Update libvirt API and refs XML files

2009-10-01 Thread Paolo Bonzini
On 09/30/2009 08:41 PM, Matthias Bolte wrote: Commit 47c8709564ac3f2ec5b4a3830ac213e69b4a44d5 "Fix up a few typos in the tree" triggered changes in docs/libvirt-api.xml and docs/libvirt-refs.xml. The attached patch contains this changes. FYI: this patch is subsumed by mine which also fixes a fe

[libvirt] Re: [virt-tools-list] Some VMs not starting at host boot

2009-10-01 Thread Cole Robinson
On 10/01/2009 11:07 AM, Daniel Huhardeaux wrote: > Hi, > > 3 VMs on a host, all in autostart: the both where > > > > > > > are not started automagically on host startup. They start without > problem from virsh. The one having > > > > > > > has no proble

Re: [libvirt] [PATCH] Fix build in separate build directory

2009-10-01 Thread Daniel Veillard
On Thu, Oct 01, 2009 at 03:31:11PM +0200, Jiri Denemark wrote: > > Signed-off-by: Jiri Denemark > --- > cfg.mk |2 +- > examples/domain-events/events-c/Makefile.am |2 +- > examples/hellolibvirt/Makefile.am |2 +- > tools/Makefile.am

Re: [libvirt] [PATCH] Fix documentation and comment typos

2009-10-01 Thread Daniel Veillard
On Thu, Oct 01, 2009 at 04:29:43PM +0200, Paolo Bonzini wrote: > Fix a few mispellings :-) of "successfully" and regenerate > docs/libvirt-*.xml. The regeneration also includes the changes > in 47c8709. > > * src/libvirt.c: Fix typos. > * src/secret/secret_driver.c: Fix typos. > * docs/libvirt-ap

[libvirt] [PATCH] Fix documentation and comment typos

2009-10-01 Thread Paolo Bonzini
Fix a few mispellings :-) of "successfully" and regenerate docs/libvirt-*.xml. The regeneration also includes the changes in 47c8709. * src/libvirt.c: Fix typos. * src/secret/secret_driver.c: Fix typos. * docs/libvirt-api.xml: Regenerate. * docs/libvirt-refs.xml: Regenerate. --- docs/libvirt-api

Re: [libvirt] [PATCH] Support a new peer-to-peer migration mode & public API

2009-10-01 Thread Paolo Bonzini
On 09/17/2009 07:25 PM, Daniel P. Berrange wrote: +if (flags& VIR_MIGRATE_PEER2PEER) { +if (VIR_DRV_SUPPORTS_FEATURE (domain->conn->driver, domain->conn, + VIR_DRV_FEATURE_MIGRATION_P2P)) { +char *duri = NULL; Is there a reason why y

Re: [libvirt] [PATCH] Allows for a tag for domains

2009-10-01 Thread Daniel Veillard
On Wed, Sep 30, 2009 at 04:09:38PM +0100, Daniel P. Berrange wrote: > On Wed, Sep 30, 2009 at 04:37:46PM +0200, Daniel Veillard wrote: > > Hum, I'm not sure I follow, you would like to create a metadata > > container at the top level and put in it ? The problem > > is that I don't see what else

[libvirt] [PATCH] Fix build in separate build directory

2009-10-01 Thread Jiri Denemark
Signed-off-by: Jiri Denemark --- cfg.mk |2 +- examples/domain-events/events-c/Makefile.am |2 +- examples/hellolibvirt/Makefile.am |2 +- tools/Makefile.am |2 +- 4 files changed, 4 insertions(+), 4 deletio

Re: [libvirt] Update libvirt API and refs XML files

2009-10-01 Thread Daniel Veillard
On Thu, Oct 01, 2009 at 12:32:51PM +0200, Chris Lalancette wrote: > Matthias Bolte wrote: > > Commit 47c8709564ac3f2ec5b4a3830ac213e69b4a44d5 "Fix up a few typos in > > the tree" triggered changes in docs/libvirt-api.xml and > > docs/libvirt-refs.xml. The attached patch contains this changes. > >

Re: [libvirt] [PATCH] Avoid a libvirtd crash on broken input 523418

2009-10-01 Thread Daniel Veillard
On Wed, Sep 30, 2009 at 05:48:49PM +0100, Mark McLoughlin wrote: > On Wed, 2009-09-30 at 18:33 +0200, Daniel Veillard wrote: > > diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c > > index 868e865..9cf0af1 100644 > > --- a/src/conf/domain_conf.c > > +++ b/src/conf/domain_conf.c > > @@ -1

Re: [libvirt] [PATCH] Various monitor improvements for migration.

2009-10-01 Thread Chris Lalancette
Daniel P. Berrange wrote: >> +void qemuMonitorMigrateCancel(const virDomainObjPtr vm) >> +{ >> +char *info = NULL; >> +qemuMonitorCommand(vm, "migrate cancel", &info); >> +VIR_FREE(info); >> +} > > An error status return value for this last one Aside from > that it looks good I ad

Re: [libvirt] [PATCH] Fix USB device re-labelling

2009-10-01 Thread Chris Lalancette
Mark McLoughlin wrote: > A simple misplaced break out of a switch results in: > > libvir: error : Failed to open file > '/sys/bus/pci/devices/:00:54c./vendor': No such file or directory > libvir: error : Failed to open file > '/sys/bus/pci/devices/:00:54c./device': No such file or di

Re: [libvirt] Update libvirt API and refs XML files

2009-10-01 Thread Chris Lalancette
Matthias Bolte wrote: > Commit 47c8709564ac3f2ec5b4a3830ac213e69b4a44d5 "Fix up a few typos in > the tree" triggered changes in docs/libvirt-api.xml and > docs/libvirt-refs.xml. The attached patch contains this changes. > > The files docs/libvirt-api.xml and docs/libvirt-refs.xml are generated > b

[libvirt]: Not able to login to container when cgroup is enabled

2009-10-01 Thread Rishikesh
Hi All, On F12 i was playing with libvirt support for container. I am seeing two issue over here: 1> Not able to create a container when start cgconfig services. 2> When i stop cgconfig, then able to create a container, but seeing few error messages to libvirtd daemon. 3> After creation

[libvirt] [OT] Relocation lookup

2009-10-01 Thread Rakotomandimby Mihamina
Hi all, Given the Social and Political reality in my country (Madagascar), I am obliged to look for a relocation. This is my public profile: http://www.linkedin.com/in/mihaminarakotomandimby Would you be aware of a position I could fit in? Thank you. -- Architecte Informatique chez Blueli

Re: [libvirt] [PATCH] incorrect error message in virDomainNetDefParseXML

2009-10-01 Thread Mark McLoughlin
On Wed, 2009-09-30 at 18:57 +0200, Daniel Veillard wrote: > On Wed, Sep 30, 2009 at 05:51:07PM +0100, Mark McLoughlin wrote: > > On Wed, 2009-09-30 at 16:41 +0200, Florian Vichot wrote: > > > When declaring a tag, needs a > > > "bridge" attribute, but the parser complains about a missing "dev" >