[libvirt] [PATCH] Change default for storage uid/gid from getuid()/getgid() to -1/-1

This allows the config to have a setting that means "leave it alone", eg when building a pool where the directory already exists the user may want the current uid/gid of the directory left intact. This actually gets us back to older behavior - before recent changes to the pool building code, we wer

[libvirt] [PATCH 3/5] build: consistently use C99 varargs macros in util

Continuation of previous patch. * src/util/hostusb.c (usbReportError): Use C99 rather than GNU vararg macro syntax. * src/util/json.c (virJSONError): Likewise. * src/util/macvtap.c (ReportError): Likewise. * src/util/pci.c (pciReportError): Likewise. * src/util/stats_linux.c (virStatsError): Likew

[libvirt] [PATCH 2/5] build: consistently use C99 varargs macros in esx

Continuation of previous patch. * src/esx/esx_device_monitor.c (ESX_ERROR): Use C99 rather than GNU vararg macro syntax. * src/esx/esx_driver.c (ESX_ERROR): Likewise. * src/esx/esx_interface_driver.c (ESX_ERROR): Likewise. * src/esx/esx_network_driver.c (ESX_ERROR): Likewise. * src/esx/esx_secret_

[libvirt] [PATCH 5/5] build: consistently use C99 varargs macros throughout

Conclusion of previous patches. * src/cpu/cpu.h (virCPUReportError): Use C99 rather than GNU vararg macro syntax. * src/datatypes.c (virLibConnError): Likewise. * src/interface/netcf_driver.c (interfaceReportError): Likewise. * src/libvirt.c (virLibStreamError): Likewise. * src/lxc/lxc_conf.h (lxc

[libvirt] [PATCH 1/5] build: consistently use C99 varargs macros in conf

Prior to this patch, there was an inconsistent mix between GNU: and C99: For consistency, and potential portability to other compilers, stick with the C99 vararg macro syntax. * src/conf/cpu_conf.c (virCPUReportError): Use C99 rather than GNU vararg macro syntax. * src/conf/domain_conf.c (virDom

[libvirt] [PATCH 0/5] build: use C99 varargs

Here's the full cleanup, based on my earlier RFC. I've tested that everything still builds and passes 'make syntax-check'. This is broken out in chunks, although whoever ends up pushing may want to squash it all into one. src/conf/cpu_conf.c|4 ++-- src/conf/domain_conf.c

[libvirt] [PATCH 4/5] build: consistently use C99 varargs macros in xen

Continuation of previous patch. * src/xen/proxy_internal.c (virProxyError): Use C99 rather than GNU vararg macro syntax. * src/xen/sexpr.c (virSexprError): Likewise. * src/xen/xen_driver.c (xenUnifiedError): Likewise. * src/xen/xen_hypervisor.c (virXenError): Likewise. * src/xen/xen_inotify.c (vir

Re: [libvirt] libvirt/dnsmasq integration.

Daniel P. Berrange wrote: >>> The total set of DNSMASQ args that we currently use are >>> >>> --strict-order >>> --bind-interfaces >>> --domain DOMAIN-NAME(optional) >>> --pid-file=/var/run/libvirt/network/$NETWORK.pid >>> --conf-file= >>> --listen-address=IPADDR-OF-BRIDGE

Re: [libvirt] [PATCH 4/6] Allow a timezone to be specified instead of sync to host timezone

On Mon, Mar 01, 2010 at 06:45:28PM +, Daniel P. Berrange wrote: > On Mon, Mar 01, 2010 at 03:14:48PM +0100, Daniel Veillard wrote: > > On Thu, Feb 18, 2010 at 05:54:30PM +, Daniel P. Berrange wrote: > > > This extends the XML to allow for > > > > > > > > > > > > This is useful if the a

[libvirt] [PATCH] Fix USB/PCI device address aliases in QEMU hotplug driver

The USB/PCI device hotplug code for the QEMU driver was forgetting to allocate a unique device alias. * src/qemu/qemu_driver.c: Fill in device alias for USB/PCI devices --- src/qemu/qemu_driver.c | 11 --- 1 files changed, 8 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_driv

Re: [libvirt] [PATCH] x86Decode: avoid NULL-dereference upon questionable input

Eric Blake wrote: > According to Jim Meyering on 3/1/2010 1:21 PM: >> Clang warned about the potential NULL-dereference >> via the STREQ/strcmp below. models[i] could be NULL. >> Even "models" could be NULL, and the "allowed = ..." test >> makes that appear to be deliberately allowed. > > This sa

Re: [libvirt] Problems with attach-device/detach-device using libvirt 0.7.6

On Mon, Mar 01, 2010 at 07:47:20PM +0100, Rolf Eike Beer wrote: > I wrote: > > [Problems attaching and detaching PCI devices] > > Ok, today I was working on that again and USB attaching was found to be > completely broken, too. Please drop my libvirt-0.7.6-null-pci-id.patch patch > from the pre

[libvirt] running libvirt on Xen Cloud Platform 0.7.1

Hi, I am trying to run libvirt daemon in Dom0 of Xen Cloud Platform 0.7.1. For that purpose I downloaded the libvirt source files 0.7.6 and trying to build the libvirt rpm with XEN driver using the XCP DDK. I am running into to many problems getting it done - so I was wondering wheth

Re: [libvirt] Problems with attach-device/detach-device using libvirt 0.7.6

I wrote: [Problems attaching and detaching PCI devices] Ok, today I was working on that again and USB attaching was found to be completely broken, too. Please drop my libvirt-0.7.6-null-pci-id.patch patch from the previous mail and use libvirt-0.7.6-null-device-id.patch instead: USB has the ve

Re: [libvirt] [virt-tools-list] and for LXC?

Hello there, libvirt already has a full feature driver for lxc. virt-install/virt-manager still need some love wrt lxc... I've started playing around with that, but that's still only a proof of concept. CR. --- Cleber Rodrigues < cr...@redhat.com > Solutions Architect - Red Hat, Inc. M

Re: [libvirt] inability to open local read-only connection

Thanks for your suggestions Daniel! I will rerun my executable thru strace with LIBVIRT_DEBUG=1 to see what happens and will send the results if need be. John -Original Message- From: Daniel P. Berrange [mailto:berra...@redhat.com] Sent: Monday, March 01, 2010 7:58 AM To: Tavares, John

Re: [libvirt] [PATCH] phypUUIDTable_Push: do not corrupt output stream

According to Jim Meyering on 3/1/2010 1:35 PM: > This started with clang's report of the two dead stores. > With the increment and decrement by "sent" being performed outside > of the intended loop, the two assignments had no net effect. > > do { > /* write the same data over

Re: [libvirt] [PATCH] openvzDomainDefineCmd: remove useless increment

According to Jim Meyering on 3/1/2010 1:41 PM: > Another dead store. > Refreshingly shallow. > > Subject: [PATCH] openvzDomainDefineCmd: remove useless increment > > * src/openvz/openvz_driver.c (openvzDomainDefineCmd): Remove > useless increment of "max_veid". ACK. -- Eric Blake ebl...@redh

Re: [libvirt] [PATCH] x86Decode: avoid NULL-dereference upon questionable input

According to Jim Meyering on 3/1/2010 1:21 PM: > Clang warned about the potential NULL-dereference > via the STREQ/strcmp below. models[i] could be NULL. > Even "models" could be NULL, and the "allowed = ..." test > makes that appear to be deliberately allowed. This same function was also listed

Re: [libvirt] [PATCH] libvirtd: avoid false-positive NULL-deref warning from clang

Eric Blake wrote: > * daemon/libvirtd.c (qemudWorker): Rewrite loop to silence a > warning. > --- > > Here's the rewrite in patch form. > > daemon/libvirtd.c |9 - > 1 files changed, 4 insertions(+), 5 deletions(-) > > diff --git a/daemon/libvirtd.c b/daemon/libvirtd.c > index 9bdbecb.

[libvirt] [PATCH] openvzDomainDefineCmd: remove useless increment

Another dead store. Refreshingly shallow. The function below starts like this: static int openvzDomainDefineCmd(virConnectPtr conn, const char *args[], int maxarg, virDomainDefPtr vmdef) { int narg; int veid;

[libvirt] [PATCH] phypUUIDTable_Push: do not corrupt output stream

This started with clang's report of the two dead stores. With the increment and decrement by "sent" being performed outside of the intended loop, the two assignments had no net effect. BTW, I presume these hard-coded names, from the same function, are somehow temporary and/or debugging-related:

[libvirt] [PATCH] x86Decode: avoid NULL-dereference upon questionable input

Clang warned about the potential NULL-dereference via the STREQ/strcmp below. models[i] could be NULL. Even "models" could be NULL, and the "allowed = ..." test makes that appear to be deliberately allowed. The change below is the least invasive and cleanest I could come up with, assuming there i

Re: [libvirt] [PATCH 2/6] Add new clock mode allowing variable adjustments

Daniel P. Berrange wrote: >> Here's the change to the syntax-check rule, >> followed by the change to the code to make those files comply. >> If everyone agrees, I'll reverse the order before pushing, >> so that make syntax-check passes after each commit. > > ACK, this makes sense - since we clearl

Re: [libvirt] [PATCH 2/6] Add new clock mode allowing variable adjustments

On Mon, Mar 01, 2010 at 08:12:23PM +0100, Jim Meyering wrote: > Daniel P. Berrange wrote: > ... > >> > diff --git a/docs/schemas/domain.rng b/docs/schemas/domain.rng > >> > index 1ff0944..d295bfe 100644 > >> > --- a/docs/schemas/domain.rng > >> > +++ b/docs/schemas/domain.rng > >> > @@ -297,12 +297

Re: [libvirt] [PATCH 2/6] Add new clock mode allowing variable adjustments

Daniel P. Berrange wrote: ... >> > diff --git a/docs/schemas/domain.rng b/docs/schemas/domain.rng >> > index 1ff0944..d295bfe 100644 >> > --- a/docs/schemas/domain.rng >> > +++ b/docs/schemas/domain.rng >> > @@ -297,12 +297,24 @@ >> > >> > >> > >> > - >> > - >> >

[libvirt] [PATCH] libvirtd: avoid false-positive NULL-deref warning from clang

* daemon/libvirtd.c (qemudWorker): Rewrite loop to silence a warning. --- Here's the rewrite in patch form. daemon/libvirtd.c |9 - 1 files changed, 4 insertions(+), 5 deletions(-) diff --git a/daemon/libvirtd.c b/daemon/libvirtd.c index 9bdbecb..9e16883 100644 --- a/daemon/libvirtd

Re: [libvirt] [PATCH 4/6] Allow a timezone to be specified instead of sync to host timezone

According to Daniel P. Berrange on 3/1/2010 11:45 AM: >>> + >>> + [a-zA-Z0-9_\.\+\-/]+ >> >> Hum ... I wonder if we should not add ':' as it's used for POSIX TZ > > How is it used ? I looked at /usr/share/zoneinfo and all the files > there should be matched by this regex ok without nee

Re: [libvirt] [PATCH 4/6] Allow a timezone to be specified instead of sync to host timezone

On Mon, Mar 01, 2010 at 03:14:48PM +0100, Daniel Veillard wrote: > On Thu, Feb 18, 2010 at 05:54:30PM +, Daniel P. Berrange wrote: > > This extends the XML to allow for > > > > > > > > This is useful if the admin has not configured any timezone on the > > host OS, but still wants to synchr

Re: [libvirt] [PATCH 2/6] Add new clock mode allowing variable adjustments

On Mon, Mar 01, 2010 at 03:02:06PM +0100, Daniel Veillard wrote: > On Thu, Feb 18, 2010 at 05:54:28PM +, Daniel P. Berrange wrote: > > This introduces a third option for clock offset synchronization, > > that allows an arbitrary / variable adjustment to be set. In > > essence the XML contains t

Re: [libvirt] [PATCH] add an assert, to avoid a false-positive NULL-deref warning from clang

Eric Blake wrote: > According to Jim Meyering on 3/1/2010 10:13 AM: >> Here's a case in which using an assertion appears to be the only >> way to tell clang that "client" really is non-NULL at that point. >> I'm sure clang's analyzers will eventually improve, and hence avoid >> this sort of false p

Re: [libvirt] [PATCH] add an assert, to avoid a false-positive NULL-deref warning from clang

On Mon, Mar 01, 2010 at 06:36:47PM +0100, Paolo Bonzini wrote: > > >On the other hand, perhaps a more invasive rewrite would also work while > >also avoiding assert(), by hoisting the worker->quitRequest into the while > >loop, something like: > > > > while ((client = qemudPendingJob(server))

Re: [libvirt] [RFC PATCH] build: consistently use C99 varargs macros

According to Daniel Veillard on 3/1/2010 10:13 AM: > On Mon, Mar 01, 2010 at 08:04:35AM -0700, Eric Blake wrote: >> Prior to this patch, there was an inconsistent mix between GNU and >> C99. For consistency, and potential portability to other compilers, >> stick with the C99 vararg macro syntax. >

Re: [libvirt] [PATCH] add an assert, to avoid a false-positive NULL-deref warning from clang

On Mon, Mar 01, 2010 at 10:27:43AM -0700, Eric Blake wrote: > According to Jim Meyering on 3/1/2010 10:13 AM: > > Here's a case in which using an assertion appears to be the only > > way to tell clang that "client" really is non-NULL at that point. > > I'm sure clang's analyzers will eventually imp

Re: [libvirt] [RFC PATCH] build: consistently use C99 varargs macros

On 03/01/2010 06:24 PM, Daniel P. Berrange wrote: mingw == gcc built as a cross-compiler, so there's no issue there. Unfortunately, _native_ mingw (i.e. building under MSYS) uses a hideously old version of GCC (3.4.x), so it's not always a non-issue. But it is fine in this case: http://gcc.

Re: [libvirt] [PATCH] add an assert, to avoid a false-positive NULL-deref warning from clang

On the other hand, perhaps a more invasive rewrite would also work while also avoiding assert(), by hoisting the worker->quitRequest into the while loop, something like: while ((client = qemudPendingJob(server)) == NULL) { if (worker->quitRequest || virCondWait(&se

Re: [libvirt] [PATCH] add an assert, to avoid a false-positive NULL-deref warning from clang

According to Jim Meyering on 3/1/2010 10:13 AM: > Here's a case in which using an assertion appears to be the only > way to tell clang that "client" really is non-NULL at that point. > I'm sure clang's analyzers will eventually improve, and hence avoid > this sort of false positive, so have marked

Re: [libvirt] [RFC PATCH] build: consistently use C99 varargs macros

On Mon, Mar 01, 2010 at 06:13:45PM +0100, Daniel Veillard wrote: > On Mon, Mar 01, 2010 at 08:04:35AM -0700, Eric Blake wrote: > > Prior to this patch, there was an inconsistent mix between GNU and > > C99. For consistency, and potential portability to other compilers, > > stick with the C99 varar

Re: [libvirt] [RFC PATCH] build: consistently use C99 varargs macros

On Mon, Mar 01, 2010 at 08:04:35AM -0700, Eric Blake wrote: > Prior to this patch, there was an inconsistent mix between GNU and > C99. For consistency, and potential portability to other compilers, > stick with the C99 vararg macro syntax. > > * src/conf/cpu_conf.c (virCPUReportError): Use C99 r

[libvirt] [PATCH] add an assert, to avoid a false-positive NULL-deref warning from clang

Here's a case in which using an assertion appears to be the only way to tell clang that "client" really is non-NULL at that point. I'm sure clang's analyzers will eventually improve, and hence avoid this sort of false positive, so have marked this with a FIXME comment, to help ensure we eventually

Re: [libvirt] [RFC] Proposal for introduction of network traffic filtering capabilities for filtering of network traffic from and to VMs

On Mon, Feb 22, 2010 at 01:45:20PM +0100, Gerhard Stenzel wrote: > > Hi, here is a preview of a chapter which is eventually intended for the > libvirt application development guide. It is not final yet, but I feel > now would be a good moment to gather some first feedback and to > "finalise" the X

[libvirt] [PATCHv2] Make domain save work on root-squash NFS

Move *all* file operations related to creation and writing of libvirt header to the domain save file into a hook function that is called by virFileOperation. First try to call virFileOperation as root. If that fails with EACCESS, and (in the case of Linux) statfs says that we're trying to save the

Re: [libvirt] [PATCH] qemudNetworkIfaceConnect: remove dead store

Eric Blake wrote: > According to Jim Meyering on 3/1/2010 8:06 AM: >> clang reported this "dead store". >> @@ -1520,11 +1520,10 @@ qemudNetworkIfaceConnect(virConnectPtr conn, >> errobj = virSaveLastError(); >> virNetworkFree(network); >> virSetError(errobj); >>

Re: [libvirt] [PATCH] udevEnumerateDevices: remove dead code

On 03/01/2010 10:15 AM, Jim Meyering wrote: Clang reported the dead store. From 0557e23ca2f5eb78ed9f260040895011785f670f Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Mon, 1 Mar 2010 16:14:35 +0100 Subject: [PATCH] udevEnumerateDevices: remove dead code * src/node_device/node_device_udev

Re: [libvirt] [PATCH] qemudNetworkIfaceConnect: remove dead store

According to Jim Meyering on 3/1/2010 8:06 AM: > clang reported this "dead store". > @@ -1520,11 +1520,10 @@ qemudNetworkIfaceConnect(virConnectPtr conn, > errobj = virSaveLastError(); > virNetworkFree(network); > virSetError(errobj); > virFreeError(errobj); > >

Re: [libvirt] [PATCH 0/3] Refactor XML parsing code

On Thu, Feb 25, 2010 at 01:12:47PM +0100, Daniel Veillard wrote: > On Wed, Feb 24, 2010 at 11:07:31PM +0100, Jiri Denemark wrote: > > Almost identical XML parsing code for either strings or files was copied > > 15 times. Since it was needed on two other places for parsing CPU XML > > strings with c

Re: [libvirt] [PATCH] cmdPoolDiscoverSources: initialize earlier to avoid FP from clang

According to Jim Meyering on 3/1/2010 7:45 AM: > This change hoists the initialization of srcSpec to the top, > to keep clang from reporting a false-positive used-uninitialized problem. > > Subject: [PATCH] cmdPoolDiscoverSources: initialize earlier to avoid FP from > clang > > * tools/virsh.c (

[libvirt] [PATCH] udevEnumerateDevices: remove dead code

Clang reported the dead store. >From 0557e23ca2f5eb78ed9f260040895011785f670f Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Mon, 1 Mar 2010 16:14:35 +0100 Subject: [PATCH] udevEnumerateDevices: remove dead code * src/node_device/node_device_udev.c (udevEnumerateDevices): Remove unnecessary

Re: [libvirt] [PATCH 6/6] Expand docs about clock modes

According to Daniel P. Berrange on 2/18/2010 10:54 AM: > * formatdomain.html.in: Document new clock options > --- > + > + The guest clock will have an arbitrary offset applied > + relative to UTC. The delta relative to UTC is specified > + in seconds, using the adjust

[libvirt] [PATCH] qemudNetworkIfaceConnect: remove dead store

clang reported this "dead store". As you can see, just a few lines before there's an identical assignment, so this may have been an editing error (didn't dig). As clang reports, that final assignment is a dead store, since there is no following use of "errobj". >From 92edbcf2ffa0dad25251723cd0749

[libvirt] [RFC PATCH] build: consistently use C99 varargs macros

Prior to this patch, there was an inconsistent mix between GNU and C99. For consistency, and potential portability to other compilers, stick with the C99 vararg macro syntax. * src/conf/cpu_conf.c (virCPUReportError): Use C99 rather than GNU vararg macro syntax. * src/conf/domain_conf.c (virDomai

Re: [libvirt] [PATCH 6/6] Implement hotremove for SCSI disks

On Mon, Mar 01, 2010 at 03:40:14PM +0100, Gerd Hoffmann wrote: > On 03/01/10 15:29, Wolfgang Mauerer wrote: > >Gerd: Are you intending to add the drive_del feature, or is > >the approach outlined above sufficient for drive hotplug/remove? > > I'm busy with other tasks right now. > > >Respectively

Re: [libvirt] libvirt/dnsmasq integration.

On Mon, Mar 01, 2010 at 01:54:44PM +, Simon Kelley wrote: > Daniel P. Berrange wrote: > > > I imagine you've already seen this, but as an example of the ARGV that > > libvirt generates for its dnsmasq instances: > > > > /usr/sbin/dnsmasq \ > >--strict-order \ > >--bind-inter

[libvirt] [PATCH] cmdPoolDiscoverSources: initialize earlier to avoid FP from clang

This change hoists the initialization of srcSpec to the top, to keep clang from reporting a false-positive used-uninitialized problem. >From f487655124c887310be3bc82d7beae3cd47e7d21 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Mon, 1 Mar 2010 15:41:15 +0100 Subject: [PATCH] cmdPoolDiscoverS

Re: [libvirt] [PATCH 6/6] Implement hotremove for SCSI disks

On 03/01/10 15:29, Wolfgang Mauerer wrote: Gerd: Are you intending to add the drive_del feature, or is the approach outlined above sufficient for drive hotplug/remove? I'm busy with other tasks right now. Respectively can there be any problems if we remove a device associated with a disk and

Re: [libvirt] [PATCH] qemu: avoid null dereference on failed migration

On Fri, Feb 26, 2010 at 10:17:53AM -0700, Eric Blake wrote: > From: Eric Blake > > * src/qemu/qemu_monitor_text.c > (qemuMonitorTextGetMigrationStatus): Check for failed strchr, to > silence a coverity warning. > > Signed-off-by: Eric Blake > --- > src/qemu/qemu_monitor_text.c |5 + >

Re: [libvirt] [PATCH] Do not search xenstore for disk device IDs

On Mon, Mar 01, 2010 at 02:45:41PM +0100, Daniel Veillard wrote: > On Tue, Feb 23, 2010 at 03:35:04PM -0700, Jim Fehlig wrote: > > Daniel P. Berrange wrote: > > > On Mon, Feb 22, 2010 at 02:50:07PM -0700, Jim Fehlig wrote: > > > > > >> Disk devices can be referenced by name in Xen, e.g. when mod

Re: [libvirt] [PATCH 6/6] Implement hotremove for SCSI disks

Daniel P. Berrange wrote: > On Fri, Feb 26, 2010 at 02:09:19PM +0100, Wolfgang Mauerer wrote: >> Recent qemu versions allow us to add disks dynamically into the system >> via the drive_add/device_add mechanism. Removing them is now just a >> matter of using device_del, and this patch adds the requi

Re: [libvirt] [PATCH 6/6] Expand docs about clock modes

On Thu, Feb 18, 2010 at 05:54:32PM +, Daniel P. Berrange wrote: > * formatdomain.html.in: Document new clock options > --- > docs/formatdomain.html.in | 38 +++--- > 1 files changed, 35 insertions(+), 3 deletions(-) > > diff --git a/docs/formatdomain.html.in

Re: [libvirt] [PATCH 4/6] Allow a timezone to be specified instead of sync to host timezone

On Thu, Feb 18, 2010 at 05:54:30PM +, Daniel P. Berrange wrote: > This extends the XML to allow for > > > > This is useful if the admin has not configured any timezone on the > host OS, but still wants to synchronize a guest to a specific one. > > * src/conf/domain_conf.h, src/conf/domain

Re: [libvirt] [PATCH 5/6] Allow configurable timezones with QEMU

On Thu, Feb 18, 2010 at 05:54:31PM +, Daniel P. Berrange wrote: > Allow an arbitrary timezone with QEMU by setting the $TZ environment > variable when launching QEMU > > * src/qemu/qemu_conf.c: Set TZ environment variable if a timezone > is requested > * tests/qemuxml2argvtest.c: Add test ca

Re: [libvirt] [PATCH 3/6] Support variable clock offset mode in QEMU

On Thu, Feb 18, 2010 at 05:54:29PM +, Daniel P. Berrange wrote: > This allows QEMU guests to be started with an arbitrary clock > offset > > The test case can't actually be enabled, since QEMU argv expects > an absolute timestring, and this will obviously change every > time the test runs :-(

Re: [libvirt] [PATCH 2/6] Add new clock mode allowing variable adjustments

On Thu, Feb 18, 2010 at 05:54:28PM +, Daniel P. Berrange wrote: > This introduces a third option for clock offset synchronization, > that allows an arbitrary / variable adjustment to be set. In > essence the XML contains the time delta in seconds, relative to > UTC. > > > > The difference

Re: [libvirt] libvirt/dnsmasq integration.

Daniel P. Berrange wrote: > On Wed, Feb 24, 2010 at 04:37:04PM +, Simon Kelley wrote: >> Richard W.M. Jones wrote: >>> On Wed, Feb 24, 2010 at 02:34:53PM +, Simon Kelley wrote: >>> [...] Does that make sense? It's a long and involved explanation to come to cold. I fear I may hav

Re: [libvirt] libvirt/dnsmasq integration.

Daniel P. Berrange wrote: > I imagine you've already seen this, but as an example of the ARGV that > libvirt generates for its dnsmasq instances: > > /usr/sbin/dnsmasq \ >--strict-order \ >--bind-interfaces \ >--pid-file=/var/run/libvirt/network/default.pid \ >--

Re: [libvirt] [PATCH 1/6] Change the internal domain conf representation of localtime/utc

On Thu, Feb 18, 2010 at 05:54:27PM +, Daniel P. Berrange wrote: > The XML will soon be extended to allow more than just a simple > localtime/utc boolean flag. This change replaces the plain > 'int localtime' with a separate struct to prepare for future > extension > > * src/conf/domain_conf.c,

Re: [libvirt] [PATCH 4/9] Add QEMU driver support for job info on migration ops

On Mon, Mar 01, 2010 at 01:02:32PM +, Daniel P. Berrange wrote: > On Fri, Feb 26, 2010 at 06:51:05PM +0100, Daniel Veillard wrote: > > On Thu, Feb 18, 2010 at 03:56:10PM +, Daniel P. Berrange wrote: > > > Introduce support for virDomainGetJobInfo in the QEMU driver. This > > > allows for m

Re: [libvirt] [PATCH 0/6] Add more guest clock mods

On Thu, Feb 18, 2010 at 05:54:26PM +, Daniel P. Berrange wrote: > An update of > > http://www.redhat.com/archives/libvir-list/2010-February/msg00104.html > > The two current options are: > > > > > This introduces a way to set a specific timezone > > > > And a way to set a complet

Re: [libvirt] [PATCH] Do not search xenstore for disk device IDs

On Tue, Feb 23, 2010 at 03:35:04PM -0700, Jim Fehlig wrote: > Daniel P. Berrange wrote: > > On Mon, Feb 22, 2010 at 02:50:07PM -0700, Jim Fehlig wrote: > > > >> Disk devices can be referenced by name in Xen, e.g. when modifying > >> their configuration or remvoving them. As such, don't search >

Re: [libvirt] [PATCH] [macvtap] interface type direct web docs addition

On Tue, Feb 23, 2010 at 12:31:07PM -0500, Stefan Berger wrote: > This adds a description about the 'direct' type of interface recently > added for macvtap device type support on the host. > > > Index: libvirt-macvtap/docs/formatdomain.html.in > ===

Re: [libvirt] libvirt/dnsmasq integration.

On Wed, Feb 24, 2010 at 04:37:04PM +, Simon Kelley wrote: > Richard W.M. Jones wrote: > > On Wed, Feb 24, 2010 at 02:34:53PM +, Simon Kelley wrote: > > [...] > >> Does that make sense? It's a long and involved explanation to come to > >> cold. I fear I may have over-simplified what libvir

Re: [libvirt] [PATCH 6/6] Implement hotremove for SCSI disks

On Fri, Feb 26, 2010 at 02:09:19PM +0100, Wolfgang Mauerer wrote: > Recent qemu versions allow us to add disks dynamically into the system > via the drive_add/device_add mechanism. Removing them is now just a > matter of using device_del, and this patch adds the required bits > and pieces to libvir

Re: [libvirt] [PATCH 5/6] Use device_del to remove SCSI controllers

On Fri, Feb 26, 2010 at 02:09:18PM +0100, Wolfgang Mauerer wrote: > ...when the underlying qemu supports the drive/device model and the > controller has been added this way. > > Signed-off-by: Wolfgang Mauerer > Signed-off-by: Jan Kiszka > --- > src/qemu/qemu_driver.c | 31 +

Re: [libvirt] [PATCH 3/6] Fix data structure handling when controllers are attached.

On Fri, Feb 26, 2010 at 02:09:16PM +0100, Wolfgang Mauerer wrote: > We must not delete the data part when the operation succeeds > because it is required later on. The correct pattern to handle > the parsed representation of the device information on success > is dev->data.controller = NULL; virDom

Re: [libvirt] [PATCH 2/6] Always link with libgcrypt

On Fri, Feb 26, 2010 at 02:09:15PM +0100, Wolfgang Mauerer wrote: > ... not just when using the remote driver: libvirt.c always depends on it. > This unbreaks builds with --without-remote > > Signed-off-by: Wolfgang Mauerer > Signed-off-by: Jan Kiszka > --- > src/Makefile.am |7 --- > 1

Re: [libvirt] [PATCH 4/6] Fix PCI address handling when controllers are deleted.

On Fri, Feb 26, 2010 at 02:09:17PM +0100, Wolfgang Mauerer wrote: > When a controller is not present in the system anymore, the PCI address > must be deleted from libvirt's hashtable because it can be re-used for > other purposes. > > Signed-off-by: Wolfgang Mauerer > Signed-off-by: Jan Kiszka >

Re: [libvirt] [PATCH 1/9] Introduce public API for domain async job handling

On Fri, Feb 26, 2010 at 06:40:10PM +0100, Daniel Veillard wrote: > On Thu, Feb 18, 2010 at 03:56:07PM +, Daniel P. Berrange wrote: > > Introduce a new public API that provides a way to get progress > > info on currently running jobs on a virDomainpPtr. APIs that > > are initially within scope o

Re: [libvirt] [PATCH] qemu: avoid null dereference on failed migration

On Fri, Feb 26, 2010 at 10:17:53AM -0700, Eric Blake wrote: > From: Eric Blake > > * src/qemu/qemu_monitor_text.c > (qemuMonitorTextGetMigrationStatus): Check for failed strchr, to > silence a coverity warning. > > Signed-off-by: Eric Blake > --- > src/qemu/qemu_monitor_text.c |5 + >

Re: [libvirt] inability to open local read-only connection

On Thu, Feb 25, 2010 at 02:34:02PM -0600, Tavares, John wrote: > I have been experimenting with using libvirt (0.3.3) on a variety of > systems (RHEL, CentOS and Oracle VM). I have run into an issue when > I try to open a local read-only connection to the hypervisor that is > failing only on Oracl

Re: [libvirt] [PATCH] Free the macvtap mode string

On Fri, Feb 26, 2010 at 01:03:56PM -0500, Stefan Berger wrote: > I forgot to free the macvtap mode string. This fixes it. > > Signed-off-by: Stefan Berger > > Index: libvirt-macvtap/src/conf/domain_conf.c > === > --- libvirt-macvta

Re: [libvirt] and for LXC?

On Mon, Mar 01, 2010 at 04:14:34PM +0300, Mihamina Rakotomandimby wrote: > Manao ahoana, Hello, Bonjour, > > Is there some plan/schedule to make libvirt LXC friendly? > Or is it already? http://libvirt.org/ livirt supports: "The LXC Linux container system " http://libvirt.org/drvlxc.htm

Re: [libvirt] Problems with attach-device/detach-device using libvirt 0.7.6

On Fri, Feb 26, 2010 at 04:24:11PM +0100, Rolf Eike Beer wrote: > Hi, > > first a short summary of what the situation is: > > I'm running qemu 0.12.2, libvirt 0.7.6 on a E5520 based machine with kernel > 2.6.33. I also tried 2.6.32.7 as I was using that before and still had the > old > kernel

Re: [libvirt] libvirt/dnsmasq integration.

On Wed, Feb 24, 2010 at 02:34:53PM +, Simon Kelley wrote: > As the principal maintainer of dnsmasq, I'm seeing increasing reports of > problems on systems which run both dnsmasq and libvirt. I'm fairly sure > I understand what's going on in these cases, and I have a few proposals > for chang

[libvirt] and for LXC?

Manao ahoana, Hello, Bonjour, Is there some plan/schedule to make libvirt LXC friendly? Or is it already? Misaotra, Thanks, Merci. -- Architecte Informatique chez Blueline/Gulfsat: Administration Systeme, Recherche & Developpement +261 34 29 155 34 / +261 33 11 207 36

Re: [libvirt] [PATCH] Free the macvtap mode string

On Fri, Feb 26, 2010 at 01:03:56PM -0500, Stefan Berger wrote: > I forgot to free the macvtap mode string. This fixes it. > > Signed-off-by: Stefan Berger > > Index: libvirt-macvtap/src/conf/domain_conf.c > === > --- libvirt-macvta

Re: [libvirt] reload libvirtd.conf has a little problem.

hmmm, I see. Thanks. Regards osier Daniel P. Berrange wrote: On Mon, Mar 01, 2010 at 05:30:21PM +0800, Osier Yang wrote: hi When libvirtd is running, I changed "unix_sock_ro_perms=0777" into ""unix_sock_ro_perms=0755", and then reload the configuration with: kill -SIGHUP `pidof

Re: [libvirt] [PATCH 4/9] Add QEMU driver support for job info on migration ops

On Fri, Feb 26, 2010 at 06:51:05PM +0100, Daniel Veillard wrote: > On Thu, Feb 18, 2010 at 03:56:10PM +, Daniel P. Berrange wrote: > > Introduce support for virDomainGetJobInfo in the QEMU driver. This > > allows for monitoring of any API that uses the 'info migrate' monitor > > command. ie vi

Re: [libvirt] Hypervisor raw options

On Fri, Feb 26, 2010 at 07:47:20PM +0100, Daniel Dehennin wrote: > Hello, > > I wonder if it's possible to add hypervisor pass-through options, I add > some usage of kvm -startdate and need to use a script which call kvm > with the desired option. > > Something like: > > /usr/bin/kvm > > -o

Re: [libvirt] reload libvirtd.conf has a little problem.

On Mon, Mar 01, 2010 at 05:30:21PM +0800, Osier Yang wrote: > hi > When libvirtd is running, I changed "unix_sock_ro_perms=0777" into > ""unix_sock_ro_perms=0755", and then reload the configuration with: > kill -SIGHUP `pidof libvirtd` or "service libvirtd reload" > > the permissi

Re: [libvirt] [PATCH] build: avoid warning about unused variables

On Thu, Feb 25, 2010 at 02:28:10PM +0100, Jim Meyering wrote: > > > >From 8ddff3e6cdccc2b4289509c6941b43f2ddf8e643 Mon Sep 17 00:00:00 2001 > From: Jim Meyering > Date: Thu, 25 Feb 2010 14:19:33 +0100 > Subject: [PATCH] build: avoid warning about unused variables > > * tools/virsh.c (cmdCPUBase

[libvirt] reload libvirtd.conf has a little problem.

hi When libvirtd is running, I changed "unix_sock_ro_perms=0777" into ""unix_sock_ro_perms=0755", and then reload the configuration with: kill -SIGHUP `pidof libvirtd` or "service libvirtd reload" the permission of /var/lib/libvirt/libvirt-sock-ro still is 0777, but not 0755.