Re: [libvirt] 'dommemstat' is not working for LXC hypervisor.

2010-04-29 Thread Kumar L Srikanth-B22348
Thanks for your time Ozaki. But, I am new to libvirt. Can you please let me know how can we enable memory.use_hierarchy for every creation of libvirt/lxc//? Regards, Srikanth. -Original Message- From: Ryota Ozaki [mailto:ozaki.ry...@gmail.com] Sent: Thursday, April 29, 2010 9:51 PM To:

Re: [libvirt] [PATCH] Fix virt-pki-validate's determination of CN

2010-04-29 Thread Eric Blake
On 04/29/2010 04:16 PM, Dustin Kirkland wrote: >> I've tested this against the certool output of both RH and Ubuntu >> generated certs. >> >> Signed-off-by: Dustin Kirkland >> Signed-off-by: Eric Blake >> --- >> -ORG=`$CERTOOL -i --infile $CA/cacert.pem | sed -n '/Issuer/ s+Issuer: >> CN=++p'` >

[libvirt] [patch 2/3] Syncronize the teardown of rules with the thread

2010-04-29 Thread Stefan Berger
Introduce a function to notify the IP address learning thread to terminate and thus release the lock on the interface. Notify the thread before grabbing the lock on the interface and tearing down the rules. This prevents a 'virsh destroy' to tear down the rules that the IP address learning thread h

[libvirt] [patch 0/3] Fixes related to the IP address learning thread

2010-04-29 Thread Stefan Berger
Proper resubmission -- sorry for the noise. The following set of patches are primarily related to the thread learning the IP address of a VM and deal with: - ebtables cleanup before applying basic filtering rules while the IP address is detected - shutting down all traffic in case the filtering

[libvirt] [patch 1/3] Clean all tables before applying basic rules

2010-04-29 Thread Stefan Berger
The functions invoked by the IP address learning thread that apply some basic filtering rules did not clean up any previous filtering rules that may still be there (due to a libvirt restart for example). With the patch below all the rules are cleaned up first. Also, I am introducing a function to

[libvirt] [patch 3/3] Prevent updates while IP address learn thread is running

2010-04-29 Thread Stefan Berger
Prevent updating and tearing down of filter while the IP address learning thread is running and has its own filtering rules applied. Signed-off-by: Stefan Berger Index: libvirt-acl/src/nwfilter/nwfilter_gentech_driver.c === --- libv

[libvirt] [v2 2/3] Syncronize the teardown of rules with the thread

2010-04-29 Thread Stefan Berger
Introduce a function to notify the IP address learning thread to terminate and thus release the lock on the interface. Notify the thread before grabbing the lock on the interface and tearing down the rules. This prevents a 'virsh destroy' to tear down the rules that the IP address learning thread h

[libvirt] [v2 1/3] Clean all tables before applying basic rules

2010-04-29 Thread Stefan Berger
The functions invoked by the IP address learning thread that apply some basic filtering rules did not clean up any previous filtering rules that may still be there (due to a libvirt restart for example). With the patch below all the rules are cleaned up first. Also, I am introducing a function to

[libvirt] [v2 3/3] Prevent updates while IP address learn thread is running

2010-04-29 Thread Stefan Berger
Prevent updating and tearing down of filter while the IP address learning thread is running and has its own filtering rules applied. Signed-off-by: Stefan Berger Index: libvirt-acl/src/nwfilter/nwfilter_gentech_driver.c === --- libv

[libvirt] [v2 0/3] Fixes related to the IP address learning thread

2010-04-29 Thread Stefan Berger
The following set of patches are primarily related to the thread learning the IP address of a VM and deal with: - ebtables cleanup before applying basic filtering rules that are active while the IP address is detected - shutting down all traffic in case the filtering rules could not be applied

Re: [libvirt] [PATCH] Fix virt-pki-validate's determination of CN

2010-04-29 Thread Dustin Kirkland
On Thu, 2010-04-29 at 15:56 -0600, Eric Blake wrote: > From: Dustin Kirkland > > Ubuntu's gntls package generates an Issuer line that looks like this: > Issuer: C=US,ST=NY,L=Rochester,O=example.com,CN=example.com > CA,email=hostmas...@example.com > > While Red Hat's looks like this > Is

[libvirt] [PATCH] Fix virt-pki-validate's determination of CN

2010-04-29 Thread Eric Blake
From: Dustin Kirkland Ubuntu's gntls package generates an Issuer line that looks like this: Issuer: C=US,ST=NY,L=Rochester,O=example.com,CN=example.com CA,email=hostmas...@example.com While Red Hat's looks like this Issuer: CN=Red Hat Emerging Technologies Note the leading whitespace,

Re: [libvirt] [PATCH] Fix virt-pki-validate's determination of CN

2010-04-29 Thread Eric Blake
On 04/29/2010 03:20 PM, Dustin Kirkland wrote: > Fix virt-pki-validate's determination of CN > > This patch is a follow-up to: > cb06a9bfe529e64b15773cb86781ae14c09f8216 > "portability fixes to tools/virt-pki-validate.in" > addressing Eric Blake's concerns about the regular expression. >

[libvirt] [PATCH] Fix virt-pki-validate's determination of CN

2010-04-29 Thread Dustin Kirkland
Fix virt-pki-validate's determination of CN This patch is a follow-up to: cb06a9bfe529e64b15773cb86781ae14c09f8216 "portability fixes to tools/virt-pki-validate.in" addressing Eric Blake's concerns about the regular expression. Ubuntu's gntls package generates an Issuer line that looks li

Re: [libvirt] [PATCH] qemudDomainSaveFlag: remove dead store

2010-04-29 Thread Jim Meyering
Eric Blake wrote: > On 04/29/2010 09:56 AM, Jim Meyering wrote: >> Clang spotted a new (albeit harmless) dead store: >> >>>From 0e37c524fb9c62d9b16443d6ff081c977963f4c5 Mon Sep 17 00:00:00 2001 >> From: Jim Meyering >> Date: Thu, 29 Apr 2010 17:56:01 +0200 >> Subject: [PATCH] qemudDomainSaveFlag:

Re: [libvirt] [PATCHv2 2/2] build: fix VPATH build of docs

2010-04-29 Thread Eric Blake
On 04/29/2010 09:59 AM, Daniel P. Berrange wrote: >> - libvirt-api.xml libvirt-refs.xml apibuild.py \ >> - site.xsl newapi.xsl news.xsl page.xsl ChangeLog.xsl \ >> + apibuild.py \ >> + site.xsl newapi.xsl news.xsl page.xsl ChangeLog.xsl \ >>$(dot_html) $(dot_html_in) $(gif) $(api

Re: [libvirt] [PATCH] qemudDomainSaveFlag: remove dead store

2010-04-29 Thread Eric Blake
On 04/29/2010 09:56 AM, Jim Meyering wrote: > Clang spotted a new (albeit harmless) dead store: > >>From 0e37c524fb9c62d9b16443d6ff081c977963f4c5 Mon Sep 17 00:00:00 2001 > From: Jim Meyering > Date: Thu, 29 Apr 2010 17:56:01 +0200 > Subject: [PATCH] qemudDomainSaveFlag: remove dead store > > *

Re: [libvirt] [PATCH 2/5] build: replace redundant header check with function check

2010-04-29 Thread Eric Blake
On 04/29/2010 01:14 AM, Paolo Bonzini wrote: > On 04/29/2010 05:41 AM, Eric Blake wrote: >> Gnulib guarantees that pthread.h exists, but for now, it is a dummy >> header with no support for most pthread_* functions. Modify our >> use of pthread to use function checks, rather than header checks, >>

Re: [libvirt] 'dommemstat' is not working for LXC hypervisor.

2010-04-29 Thread Kumar L Srikanth-B22348
Now it's showing Used Memory as 0. I don't know whether it's correct or not. I wrote a small script in the domain to check the used memory, which will run continuously in the infinite loop. dominfo 'domainname' is showing Used Memory as 0. Is this right way to check the Used Memory of that domain?

Re: [libvirt] [PATCH 0/5] build: rely more on gnulib

2010-04-29 Thread Eric Blake
On 04/29/2010 08:03 AM, Daniel Veillard wrote: > On Wed, Apr 28, 2010 at 09:41:44PM -0600, Eric Blake wrote: >> I can't yet upgrade to the latest gnulib due to some LGPLv2+ issues >> being worked out upstream. But in the meantime, here's some cleanups >> that will make it easier to upgrade when gn

Re: [libvirt] [PATCH] Fix build on Ubuntu.

2010-04-29 Thread Chris Lalancette
On 04/28/2010 04:59 PM, Eric Blake wrote: > On 04/28/2010 02:27 PM, Chris Lalancette wrote: >> When building on Ubuntu with make -j3 (or more), it would always >> fail when trying to build virt-aa-helper. I'm not an expert in >> automake by any means, but I think the entry for virt-aa-helper >> is

[libvirt] nwfilter: Also pick IP address from a DHCP ACK message

2010-04-29 Thread Stefan Berger
The local DHCP server on virtbr0 sends DHCP ACK messages when a VM is started and requests an IP address while the initial DHCP lease on the VM's MAC address hasn't expired. So, also pick the IP address of the VM if that type of message is seen. Thanks to Gerhard Stenzel for providing a test case f

Re: [libvirt] [PATCH] Report better error if qemuSnapshotIsAllowed failed.

2010-04-29 Thread Daniel Veillard
On Wed, Apr 28, 2010 at 04:27:21PM -0400, Chris Lalancette wrote: > Signed-off-by: Chris Lalancette > --- > src/qemu/qemu_driver.c |4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c > index f7084ca..5ab211a 100644 > --

Re: [libvirt] [PATCHv2 2/2] build: fix VPATH build of docs

2010-04-29 Thread Daniel Veillard
On Wed, Apr 28, 2010 at 07:37:02PM -0600, Eric Blake wrote: > The rule of thumb for generated files: > If they are distributed, they should be generated in $(srcdir); > otherwise, they should be built by the end user in $(builddir). > Since our .xml docs are built with python, and we want them > av

Re: [libvirt] [PATCH v2 0/8]: Add arbitrary qemu command-line and monitor commands

2010-04-29 Thread Chris Lalancette
On 04/29/2010 10:05 AM, Daniel Veillard wrote: > On Wed, Apr 28, 2010 at 04:20:45PM -0400, Chris Lalancette wrote: >> As we discussed previously, here is the patch series to add the ability >> to specify arbitrary qemu command-line parameters and environment variables, >> and also give arbitrary mo

[libvirt] [PATCH v2] nwfilter: Also pick IP address from a DHCP ACK message

2010-04-29 Thread Stefan Berger
The local DHCP server on virtbr0 sends DHCP ACK messages when a VM is started and requests an IP address while the initial DHCP lease on the VM's MAC address hasn't expired. So, also pick the IP address of the VM if that type of message is seen. Thanks to Gerhard Stenzel for providing a test case f

Re: [libvirt] [PATCH 0/5] build: rely more on gnulib

2010-04-29 Thread Daniel Veillard
On Wed, Apr 28, 2010 at 09:41:44PM -0600, Eric Blake wrote: > I can't yet upgrade to the latest gnulib due to some LGPLv2+ issues > being worked out upstream. But in the meantime, here's some cleanups > that will make it easier to upgrade when gnulib is ready. I always > like patch series with a

Re: [libvirt] 'dommemstat' is not working for LXC hypervisor.

2010-04-29 Thread Ryota Ozaki
On Thu, Apr 29, 2010 at 10:23 PM, Ryota Ozaki wrote: > On Thu, Apr 29, 2010 at 9:54 PM, Kumar L Srikanth-B22348 > wrote: >> Thanks Ozaki. >> Please let me know the result, once you checked with 0.8.0. > > I may understand what happen. > > Could you check 'tree -d /cgroup' where running your domai

Re: [libvirt] [PATCH] Report better error if qemuSnapshotIsAllowed failed.

2010-04-29 Thread Chris Lalancette
On 04/28/2010 04:58 PM, Eric Blake wrote: > On 04/28/2010 02:27 PM, Chris Lalancette wrote: >> Signed-off-by: Chris Lalancette >> --- >> src/qemu/qemu_driver.c |4 ++-- >> 1 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c >> in

Re: [libvirt] [PATCH] Fix handling of disk backing stores with cgroups

2010-04-29 Thread Daniel P. Berrange
On Wed, Apr 28, 2010 at 11:03:42AM -0600, Eric Blake wrote: > On 04/28/2010 09:27 AM, Daniel P. Berrange wrote: > > +memset(&meta, 0, sizeof(meta)); > > + > > +ret = virStorageFileGetMetadata(path, &meta); > > + > > +if (path != vm->def->disks[i]->src

Re: [libvirt] 'dommemstat' is not working for LXC hypervisor.

2010-04-29 Thread Ryota Ozaki
On Thu, Apr 29, 2010 at 9:54 PM, Kumar L Srikanth-B22348 wrote: > Thanks Ozaki. > Please let me know the result, once you checked with 0.8.0. I may understand what happen. Could you check 'tree -d /cgroup' where running your domain and could you find that a directory named your domain has anothe

Re: [libvirt] [PATCH] Fix a memory leak in the node_device_udev code

2010-04-29 Thread Chris Lalancette
On 04/28/2010 05:06 PM, Eric Blake wrote: > On 04/28/2010 02:27 PM, Chris Lalancette wrote: >> We were over-writing a pointer without freeing it in >> case of a disk device, leading to a memory leak. >> >> Signed-off-by: Chris Lalancette >> --- >> src/node_device/node_device_udev.c |7 ---

[libvirt] [PATCH] qemudDomainSaveFlag: remove dead store

2010-04-29 Thread Jim Meyering
Clang spotted a new (albeit harmless) dead store: >From 0e37c524fb9c62d9b16443d6ff081c977963f4c5 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Thu, 29 Apr 2010 17:56:01 +0200 Subject: [PATCH] qemudDomainSaveFlag: remove dead store * src/qemu/qemu_driver.c (qemudDomainSaveFlag): Remove dead s

Re: [libvirt] [PATCH 2/5] build: replace redundant header check with function check

2010-04-29 Thread Jim Meyering
Eric Blake wrote: > Gnulib guarantees that pthread.h exists, but for now, it is a dummy > header with no support for most pthread_* functions. Modify our > use of pthread to use function checks, rather than header checks, > to determine how much pthread support is present. > > * configure.ac: Opti

Re: [libvirt] [PATCH 5/5] build: drop more redundant configure checks

2010-04-29 Thread Jim Meyering
Eric Blake wrote: > * configure.ac (AC_CHECK_FUNCS_ONCE, AC_SYS_LARGEFILE): Rely on > gnulib for strtok_r and large file support. > (AC_OBJEXT): Drop call now done by AC_PROG_CC. > (m4_foreach_w): Drop macro guaranteed by gnulib. > (AC_C_CONST): Drop call declared obsolete by autoconf. > > Signed-o

Re: [libvirt] [PATCH 2/5] build: replace redundant header check with function check

2010-04-29 Thread Paolo Bonzini
On 04/29/2010 05:41 AM, Eric Blake wrote: Gnulib guarantees that pthread.h exists, but for now, it is a dummy header with no support for most pthread_* functions. Modify our use of pthread to use function checks, rather than header checks, to determine how much pthread support is present. Shou

Re: [libvirt] 'dommemstat' is not working for LXC hypervisor.

2010-04-29 Thread Ryota Ozaki
On Wed, Apr 28, 2010 at 8:19 PM, Kumar L Srikanth-B22348 wrote: > Daniel, > My requirement is to get how much memory is free in the guest domain. > Can you please let me know, how can I do that? Do you enable cgroup memory subsystem? If so, something wrong in lxc driver of 0.8.0. BTW, 'Used memo

Re: [libvirt] [PATCHv2 3/2] docs/Makefile.am: remove unnecessary subshells

2010-04-29 Thread Jim Meyering
Eric Blake wrote: > * docs/Makefile.am (ChangeLog.html.in, %.html.tmp, %.html) > (html/index.html, $(devhelphtml)): Avoid spurious subshells. Thanks. I've made similar changes in the vicinity. ACK. -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-

Re: [libvirt] [PATCHv2 2/2] build: fix VPATH build of docs

2010-04-29 Thread Jim Meyering
Eric Blake wrote: > The rule of thumb for generated files: > If they are distributed, they should be generated in $(srcdir); > otherwise, they should be built by the end user in $(builddir). > Since our .xml docs are built with python, and we want them > available even to end users that don't build

[libvirt] [PATCH] virFileHasSuffix case sensitivity

2010-04-29 Thread Paul Dorman
Hi Eric, sure. Here you go. Please let me know if there's anything else I need to do. diff --git a/src/util/util.c b/src/util/util.c index a7bb67c..3209185 100644 --- a/src/util/util.c +++ b/src/util/util.c @@ -1153,7 +1153,7 @@ int virFileHasSuffix(const char *str, if (len < suffixlen)

Re: [libvirt] [PATCH 4/5] build: use gnulib's sys/wait.h

2010-04-29 Thread Jim Meyering
Eric Blake wrote: > * configure.ac: Drop sys/wait.h check. > * src/libvirt.c (includes): Use header unconditionally. > * src/remote/remote_driver.c (includes): Likewise. > * src/storage/storage_backend.c (includes): Likewise. > * src/util/ebtables.c (includes): Likewise. > * src/util/hooks.c (inclu

Re: [libvirt] [PATCH 3/5] build: use gnulib's uname

2010-04-29 Thread Jim Meyering
Eric Blake wrote: > * bootstrap.conf (gnulib_modules): Add uname. > * configure.ac: Drop uname and sys/utsname.h checks. > * src/nodeinfo.c (nodeGetInfo): Use uname unconditionally. > --- > bootstrap.conf |1 + > configure.ac |4 ++-- > src/nodeinfo.c | 12 ++-- Straightforward

Re: [libvirt] 'dommemstat' is not working for LXC hypervisor.

2010-04-29 Thread Kumar L Srikanth-B22348
Thanks Ozaki. Please let me know the result, once you checked with 0.8.0. Regards, Srikanth. -Original Message- From: Ryota Ozaki [mailto:ozaki.ry...@gmail.com] Sent: Thursday, April 29, 2010 6:14 PM To: Kumar L Srikanth-B22348 Cc: Daniel P. Berrange; libvirt list; Ryota OZAKI Subject: R

Re: [libvirt] 'dommemstat' is not working for LXC hypervisor.

2010-04-29 Thread Ryota Ozaki
On Thu, Apr 29, 2010 at 9:32 PM, Kumar L Srikanth-B22348 wrote: > Now it's showing Used Memory as 0. I don't know whether it's correct or not. > I wrote a small script in the domain to check the used memory, which will run > continuously in the infinite loop. > dominfo 'domainname' is showing Use

Re: [libvirt] [PATCHv2 2/2] build: fix VPATH build of docs

2010-04-29 Thread Daniel P. Berrange
On Wed, Apr 28, 2010 at 07:37:02PM -0600, Eric Blake wrote: > diff --git a/docs/Makefile.am b/docs/Makefile.am > index a18821b..91ae13e 100644 > --- a/docs/Makefile.am > +++ b/docs/Makefile.am > @@ -53,10 +53,10 @@ gif = \ >architecture.gif \ >node.gif > > -dot_html_in = $(wildcard *.html.

Re: [libvirt] [PATCH] nwfilter: python bindings for nwfilter

2010-04-29 Thread Daniel Veillard
On Wed, Apr 28, 2010 at 02:51:16PM -0400, Stefan Berger wrote: > I have primarily followed the pattern of the 'secret' driver to provide > support for the missing python bindings for the network filter API. > > Signed-off-by: Stefan Berger > > --- > python/generator.py | 35 ++

Re: [libvirt] [PATCH] nwfilter: python bindings for nwfilter

2010-04-29 Thread Stefan Berger
Daniel Veillard wrote on 04/29/2010 05:27:18 AM: > Please respond to veillard > > On Wed, Apr 28, 2010 at 02:51:16PM -0400, Stefan Berger wrote: > > I have primarily followed the pattern of the 'secret' driver to provide > > support for the missing python bindings for the network filter API. >

Re: [libvirt] [PATCH 1/5] build: rely on gnulib's pthread module

2010-04-29 Thread Jim Meyering
Eric Blake wrote: > No need to repeat the work already provided by gnulib. > > * bootstrap.conf (gnulib_modules): Add pthread. > * configure.ac: Drop all pthread.h checks. > * src/Makefile.am (libvirt_lxc_LDADD): Ensure proper link. ACK. -- libvir-list mailing list libvir-list@redhat.com https://

[libvirt] FW: Creating multiple network interfaces in libvirt Domain.

2010-04-29 Thread Kumar L Srikanth-B22348
Hi All, Can anybody please help me in the issue? Regards, Srikanth. From: Kumar L Srikanth-B22348 Sent: Wednesday, April 28, 2010 4:47 PM To: 'Daniel P. Berrange' Subject: FW: Creating multiple network interfaces in libvirt Domain. Also, can you please let me know, how can I create m

Re: [libvirt] 'dommemstat' is not working for LXC hypervisor.

2010-04-29 Thread Ryota Ozaki
On Wed, Apr 28, 2010 at 8:15 PM, Daniel P. Berrange wrote: > On Wed, Apr 28, 2010 at 04:43:41PM +0530, Kumar L Srikanth-B22348 wrote: >> Thanks for the reply Daniel. >> Virsh dominfo dommand showing following results: >> >> Id:             32473 >> Name:           vm1 >> UUID:           f13bc513-1

Re: [libvirt] 'dommemstat' is not working for LXC hypervisor.

2010-04-29 Thread Kumar L Srikanth-B22348
Thanks ozaki. But can you please elaborate the process of getting memory.stat of a particular domain? I mounted cgroup filesystem prior to start libvirtd service using the below command: mount -t cgroup cgroup /cgroup Then started libvirtd service. Then started the domain. Here, can you let me

Re: [libvirt] 'dommemstat' is not working for LXC hypervisor.

2010-04-29 Thread Ryota Ozaki
On Thu, Apr 29, 2010 at 9:14 PM, Kumar L Srikanth-B22348 wrote: > Thanks ozaki. > But can you please elaborate the process of getting memory.stat of a > particular domain? > I mounted cgroup filesystem prior to start libvirtd service using the below > command: > mount -t cgroup cgroup /cgroup >

Re: [libvirt] [PATCH v2 0/8]: Add arbitrary qemu command-line and monitor commands

2010-04-29 Thread Daniel Veillard
On Wed, Apr 28, 2010 at 04:20:45PM -0400, Chris Lalancette wrote: > As we discussed previously, here is the patch series to add the ability > to specify arbitrary qemu command-line parameters and environment variables, > and also give arbitrary monitor commands to a guest. Because these > extra ar

Re: [libvirt] Creating multiple network interfaces in libvirt Domain.

2010-04-29 Thread Ryota Ozaki
On Wed, Apr 28, 2010 at 5:56 PM, Kumar L Srikanth-B22348 wrote: > Hi, > > I want to create a Domain with two interfaces. I am using LXC hypervisor in > the libvirt. > > My domain XML is shown below: > > > >   srikanth_vm2 > >     50 > >   > >   exe > >   /bin/sh > >  

Re: [libvirt] virFileHasSuffix case sensitivity

2010-04-29 Thread Daniel Veillard
On Wed, Apr 28, 2010 at 09:43:53PM -0600, Eric Blake wrote: > On 04/28/2010 09:24 PM, Paul Dorman wrote: > > Hi all, > > > > virFileHasSuffix fails on esx IDE fileName VMX entries that aren't lower > > case, e.g. '.ISO'. Unless there's a good reason, can the comparison be done > > with STRCASEEQ i

[libvirt] [PATCH] Add support for another explicit IO error event

2010-04-29 Thread Daniel P. Berrange
This introduces a new event type VIR_DOMAIN_EVENT_ID_IO_ERROR_REASON This event is the same as the previous VIR_DOMAIN_ID_IO_ERROR event, but also includes a string describing the cause of the event. Thus there is a new callback definition for this event type typedef void (*virConnectDomainE

Re: [libvirt] [PATCH] Fix a qemuDomainPCIAddressSetFree memory leak

2010-04-29 Thread Chris Lalancette
On 04/28/2010 05:08 PM, Eric Blake wrote: > On 04/28/2010 02:27 PM, Chris Lalancette wrote: >> qemuDomainPCIAddressSetFree was freeing up the hash >> table for the pci addresses, but not freeing up the addr >> structure. Looking over the callers of this function, it >> seems like they expect it to

[libvirt] [PATCH 4/5] build: use gnulib's sys/wait.h

2010-04-29 Thread Eric Blake
* configure.ac: Drop sys/wait.h check. * src/libvirt.c (includes): Use header unconditionally. * src/remote/remote_driver.c (includes): Likewise. * src/storage/storage_backend.c (includes): Likewise. * src/util/ebtables.c (includes): Likewise. * src/util/hooks.c (includes): Likewise. * src/util/ipt

[libvirt] [PATCH 1/5] build: rely on gnulib's pthread module

2010-04-29 Thread Eric Blake
No need to repeat the work already provided by gnulib. * bootstrap.conf (gnulib_modules): Add pthread. * configure.ac: Drop all pthread.h checks. * src/Makefile.am (libvirt_lxc_LDADD): Ensure proper link. --- bootstrap.conf |1 + configure.ac|8 src/Makefile.am |3 ++- 3

[libvirt] [PATCH 0/5] build: rely more on gnulib

2010-04-29 Thread Eric Blake
I can't yet upgrade to the latest gnulib due to some LGPLv2+ issues being worked out upstream. But in the meantime, here's some cleanups that will make it easier to upgrade when gnulib is ready. I always like patch series with a net reduction in lines. I suppose I should try to get a mingw or cy

Re: [libvirt] virFileHasSuffix case sensitivity

2010-04-29 Thread Eric Blake
On 04/28/2010 09:24 PM, Paul Dorman wrote: > Hi all, > > virFileHasSuffix fails on esx IDE fileName VMX entries that aren't lower > case, e.g. '.ISO'. Unless there's a good reason, can the comparison be done > with STRCASEEQ instead of STREQ? Seems reasonable to me. It would help if you could wr