[libvirt] [PATCHv4 1/2] virsh: add new --details option to pool-list

2010-06-21 Thread Justin Clift
This patch adds a new --details option to the virsh pool-list command, making its output more useful to people who use virsh for significant lengths of time. Addresses BZ # 605543 https://bugzilla.redhat.com/show_bug.cgi?id=605543 --- (This is the v3 patch version, but with some wonky spacing

[libvirt] [PATCH] phyp: Adding Storage Management driver (comments fixed)

2010-06-21 Thread Eduardo Otubo
All the comments from the previous email from Eric Blake are now fixed. Also fixed some styling by using indent on the whole file. Hope we can get this patch pushed to 0.8.2. Any additional comments are always welcome. []'s --- src/phyp/phyp_driver.c | 395 +++

Re: [libvirt] [PATCH] phyp: Adding storage management driver

2010-06-21 Thread Eduardo Otubo
On 06/21/2010 05:05 PM, Eric Blake wrote: On 06/21/2010 12:32 PM, Eduardo Otubo wrote: Ouch. If the result of the `` command substitution begins with 0, you have a problem with octal numbers. Remember, $((010 + 1)) is not the same as $((10 + 1)). Perhaps you can modify the sed commands used i

Re: [libvirt] [PATCH] phyp: Adding storage management driver

2010-06-21 Thread Eric Blake
On 06/21/2010 12:32 PM, Eduardo Otubo wrote: >> Ouch. If the result of the `` command substitution begins with 0, you >> have a problem with octal numbers. Remember, $((010 + 1)) is not the >> same as $((10 + 1)). Perhaps you can modify the sed commands used in >> your script to strip leading 0?

Re: [libvirt] [PATCH] phyp: Adding storage management driver

2010-06-21 Thread Eduardo Otubo
index 80ff0c3..2606fe4 100644 --- a/src/phyp/phyp_driver.h +++ b/src/phyp/phyp_driver.h @@ -75,6 +75,58 @@ struct _phyp_driver { char *managed_system; }; + +/* + * Storage functions + * */ +virStorageVolPtr +phypStorageVolCreateXML(virStoragePoolPtr pool, const char *xmldesc, +

Re: [libvirt] [PATCH v3] nwfilter: fix loadable module support

2010-06-21 Thread Stefan Berger
On 06/21/2010 11:33 AM, Daniel P. Berrange wrote: On Wed, Jun 16, 2010 at 11:33:48AM -0400, Stefan Berger wrote: Following Daniel Berrange's multiple helpful suggestions for improving this patch and introducing another driver interface, I now wrote the below patch where the nwfilter driver r

Re: [libvirt] [PATCH v3] nwfilter: fix loadable module support

2010-06-21 Thread Daniel P. Berrange
On Wed, Jun 16, 2010 at 11:33:48AM -0400, Stefan Berger wrote: > Following Daniel Berrange's multiple helpful suggestions for improving > this patch and introducing another driver interface, I now wrote the > below patch where the nwfilter driver registers the functions to > instantiate and tear

Re: [libvirt] [PATCHv3 1/2] virsh: add new --details option to pool-list

2010-06-21 Thread Justin Clift
On 06/21/2010 11:45 PM, Justin Clift wrote: > Submitting this patch for review by itself, rather than with the pool-list one as well ... Ugh, typo. I meant to say I'm submitting this one now for review, rather than with the matching *vol-list* one. :) Regards and best wishes, Justin Cl

[libvirt] [PATCHv3 1/2] virsh: add new --details option to pool-list

2010-06-21 Thread Justin Clift
This patch adds a new --details option to the virsh pool-list command, making its output more useful to people who use virsh for significant lengths of time. Addresses BZ # 605543 https://bugzilla.redhat.com/show_bug.cgi?id=605543 --- Submitting this patch for review by itself, rather than wi

Re: [libvirt] [PATCH 2/2] network: allow tftp port if tftp is defined

2010-06-21 Thread Daniel P. Berrange
On Sat, Jun 19, 2010 at 08:08:26PM +0200, ape...@gmail.com wrote: > From: Alan Pevec > > add iptables rules to allow TFTP from the virtual network if > element is defined in the network definition. > > Fedora bz#580215 > > * src/network/bridge_driver.c: open UDP port 69 for TFTP traffic if >

Re: [libvirt] [PATCH 1/2] bridge_driver.c: fix file description

2010-06-21 Thread Daniel P. Berrange
On Sat, Jun 19, 2010 at 08:08:25PM +0200, ape...@gmail.com wrote: > From: Alan Pevec > > --- > src/network/bridge_driver.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c > index d24bfd0..0cd0978 100644 > -

[libvirt] UNOFFICIAL Re: New release 0.4.6

2010-06-21 Thread Daniel P. Berrange
ATTENTION: this is *NOT* an official libvirt java release. Only Bryan Kearney, who is the nominated libvirt java maintainer, will publish official releases & send announcements. The most recent release is *still* 0.4.5 previously announced here: https://www.redhat.com/archives/libvir-list/201

Re: [libvirt] [PATCH 2/3] Add optional model attribute to the controller element

2010-06-21 Thread Daniel Veillard
On Thu, Jun 17, 2010 at 11:15:43PM +0200, Matthias Bolte wrote: > This is a step towards controller support for the ESX driver. > --- > docs/schemas/domain.rng |9 + > src/conf/domain_conf.c | 34 ++ > src/conf/domain_conf.h | 11 +++ > src

Re: [libvirt] [PATCH 1/3] Add wide SCSI bus disk address generation support

2010-06-21 Thread Daniel Veillard
On Thu, Jun 17, 2010 at 11:15:42PM +0200, Matthias Bolte wrote: > The domain XML parsing code autogenerates disk address and > controller elements when they are not explicitly specified. > The code assumes a narrow SCSI bus (7 units per bus). ESX > uses a wide SCSI bus (16 units per bus). > > This

[libvirt] how to setup libvirt development environment...

2010-06-21 Thread Avdhoot Joshi
Hi, Installed RHEL 5.5 on AMD Opteron. [r...@wlng-ppcore-nd3 ~]# uname -a Linux wlng-ppcore-nd3 2.6.18-194.el5 #1 SMP Tue Mar 16 21:52:39 EDT 2010 x86_64 x86_64 x86_64 GNU/Linux [r...@wlng-ppcore-nd3 ~]# virsh version Compiled against library: libvir 0.6.3 Using library: libvir 0.6.3 Using API:

Re: [libvirt] [PATCH 2/4] Remove unnecessary check for non-NULL uuid

2010-06-21 Thread Jiri Denemark
> We might also get rid of this unnecessary unreferencing and > referencing while touching those 3 memcpys and replace > > memcpy(&(ret->uuid[0]), uuid, VIR_UUID_BUFLEN); > > with > > memcpy(ret->uuid, uuid, VIR_UUID_BUFLEN); That was my thought too. But since git grep gives about 140 of th

Re: [libvirt] [PATCH 0/4] Change per-connection hashes to be indexed by UUIDs

2010-06-21 Thread Jiri Denemark
> While working at the area, I also made few other cleanups... > > Jiri Denemark (4): > Index hashes by UUID instead of name > Remove unnecessary check for non-NULL uuid > Do not free static buffer with UUID > Misc cleanups OK, I pushed the series. Jirka -- libvir-list mailing list libv

Re: [libvirt] [PATCH] Allow one-or-more entries

2010-06-21 Thread Jiri Denemark
> > According to docs/formatdomain.html.in, "The boot element can be > > repeated multiple times to setup a priority list of boot devices to try > > in turn." The Relax-NG schema required / allowed exactly one entry. > > ACK Pushed. Jirka -- libvir-list mailing list libvir-list@redhat.com https

Re: [libvirt] [PATCH] virsh: remove a doubled up include for errno.h

2010-06-21 Thread Jiri Denemark
> > Noticed a doubled up include for errno.h. Pretty sure it's not > > needed. > > ACK, OK, pushed. Jirka -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] phyp: Adding storage management driver

2010-06-21 Thread Jim Meyering
Justin Clift wrote: > On 06/19/2010 09:33 AM, Eric Blake wrote: > >>> +if (!(profile = phypGetLparProfile(conn, domain->id))) { >>> +VIR_ERROR("%s", "Unable to get VIOS profile name."); >>> +goto err; >>> +} >> >> Another case of a missing string translation. How come 'mak

Re: [libvirt] [PATCH] virsh: remove a doubled up include for errno.h

2010-06-21 Thread Daniel Veillard
On Mon, Jun 21, 2010 at 12:27:16AM +1000, Justin Clift wrote: > --- > > Noticed a doubled up include for errno.h. Pretty sure it's not > needed. > > tools/virsh.c |1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/tools/virsh.c b/tools/virsh.c > index 3057115..0bf744