Re: [libvirt] [PATCH] build: skip xenapi driver when building for RHEL

> https://bugzilla.redhat.com/show_bug.cgi?id=643118 > > * libvirt.spec.in: Provide xenapi conditionals. > --- > > Hmm - there's probably other things we could do to sync libvirt.spec.in > back with RHEL builds; for example, the fact that RHEL 6.0 beta builds > ESX by default needs to be updated

[libvirt] [PATCH v2] Make sure that filedescriptors are only closed once

V2: also the path where close() failed needs to be corrected; -> time for a VIR_CLOSE() ? Setting fd=-1 in these places makes sure that the fd is not closed twice later on in 'clean:'. This is of course a recipe for disaster in a multi-threaded system where the filedescriptor can belong to

[libvirt] [PATCH] Make sure that filedescriptors are only closed once

Setting fd=-1 in these places makes sure that the fd is not closed twice later on in 'clean:'. This is of course a recipe for disaster in a multi-threaded system where the filedescriptor can belong to something else right away. At least we have a pattern... (looks like I can close the augeas

Re: [libvirt] [PATCH] esx: Handle name escaping properly

2010/10/14 Daniel Veillard : > On Wed, Oct 13, 2010 at 10:47:57PM +0200, Matthias Bolte wrote: >> 2010/10/13 Daniel Veillard : >> > On Wed, Oct 13, 2010 at 11:06:44AM +0200, Matthias Bolte wrote: >> >> VMware uses a mix of percent-, pipe- and base64-encoding in >> >> different combinations in diffe

Re: [libvirt] [PATCHv2 00/14] vcpu - distinguish maximum from current

On 10/13/2010 11:53 AM, Eric Blake wrote: Version 1 had ACKs on most of the patches, but raised several points (not the least of which was a lack of testing). I've now done more testing on xen than on qemu, so there may still be some qemu quirks. Version 2 of the patch series; this addresses mo

[libvirt] [PATCHv2 15/14] vcpu: improve support for setting xen vcpu counts

Tested with RHEL 5.6 (xendConfigVersion 2, where xend_internal controls live domains and xm_internal controls inactive domains). Hopefully this works with xendConfigVersion 3 (where xend_internal controls everything). v2: new patch * src/xen/xen_driver.c (xenUnifiedDomainSetVcpusFlags): Support m

[libvirt] [PATCHv2 16/14] vcpu: remove dead xen code

v2: new patch. To be squashed with 14/14. * src/xen/xen_driver.h (xenUnifiedDriver): Remove now-unused domainSetVcpus. * src/xen/proxy_internal.c (xenProxyDriver): Likewise. * src/xen/xen_hypervisor.c (xenHypervisorDriver): Likewise. * src/xen/xen_inotify.c (xenInotifyDriver): Likewise. * src/xen/

Re: [libvirt] Mac OS X: dyld: lazy symbol binding failed

Eric, First, here is the output from diff -c: https://gist.github.com/7d8c32849e4d72be5368 I ran `automake --version` and I have "1.11.1" And the "1.9.6" automake is from the libvirt build servers, not any of my machines. I was comparing the "./configure" output from the snapshot with when I run

Re: [libvirt] Mac OS X: dyld: lazy symbol binding failed

On 10/14/2010 01:06 PM, Mitchell Hashimoto wrote: Daniel, Thanks for your response, I appreciate it. The `grep` on the two Makefiles is equivalent. I've uploaded a diff of the two Makefiles here: https://gist.github.com/da0e93a335be6a3a637b Let me know if you want me to upload the actual Makefil

Re: [libvirt] usage of PKG_CHECK_ in libvirt

On Thu, Oct 14, 2010 at 21:33, Matthias Bolte wrote: > No idea about PKG_CHECK_EXISTS, but if you look at configure.ac you'll > find multiple instances of PKG_CHECK_MODULES, so this one is perfectly > fine. Thanks, I'll use PKG_CHECK_MODULES then Alejandro -- libvir-list mailing list libvir-lis

Re: [libvirt] usage of PKG_CHECK_ in libvirt

2010/10/14 Alejandro Mery : > hi, > > I want to try to add some basic support for (linux-)vserver to libvirt > and after reading some old mail threads I noticed you vanished > PKG_CHECK_EXISTS back in 2008. is it still not welcomed in libvirt? > PKG_CHECK_MODULES also? > > Thanks, > Alejandro Mery

[libvirt] usage of PKG_CHECK_ in libvirt

hi, I want to try to add some basic support for (linux-)vserver to libvirt and after reading some old mail threads I noticed you vanished PKG_CHECK_EXISTS back in 2008. is it still not welcomed in libvirt? PKG_CHECK_MODULES also? Thanks, Alejandro Mery -- libvir-list mailing list libvir-list@red

Re: [libvirt] Mac OS X: dyld: lazy symbol binding failed

Daniel, Thanks for your response, I appreciate it. The `grep` on the two Makefiles is equivalent. I've uploaded a diff of the two Makefiles here: https://gist.github.com/da0e93a335be6a3a637b Let me know if you want me to upload the actual Makefiles as well, since I can do that. Also the src/libvi

[libvirt] [PATCH] build: skip xenapi driver when building for RHEL

https://bugzilla.redhat.com/show_bug.cgi?id=643118 * libvirt.spec.in: Provide xenapi conditionals. --- Hmm - there's probably other things we could do to sync libvirt.spec.in back with RHEL builds; for example, the fact that RHEL 6.0 beta builds ESX by default needs to be updated here. libvirt.

[libvirt] [PATCH] nwfilter: changes to rules in VM->host table

In the table built for traffic coming from the VM going to the host make the following changes: - don't ACCEPT the packets but do a 'RETURN' and let the host-specific firewall rules in subsequent rules evaluate whether the traffic is allowed to enter - use the '-m state' in the rules as ever

Re: [libvirt] [PATCH] nwfilter: prevent multiple filters with different name but same UUID

On 10/14/2010 11:27 AM, Daniel P. Berrange wrote: On Thu, Oct 14, 2010 at 11:20:15AM -0400, Stefan Berger wrote: Patch to prevent multiple nwfilters with different name but same UUID. Signed-off-by: Stefan Berger --- src/conf/nwfilter_conf.c | 14 ++ 1 file changed, 14 inse

Re: [libvirt] [PATCH] nwfilter: prevent multiple filters with different name but same UUID

On Thu, Oct 14, 2010 at 11:20:15AM -0400, Stefan Berger wrote: > Patch to prevent multiple nwfilters with different name but same UUID. > > Signed-off-by: Stefan Berger > > --- > src/conf/nwfilter_conf.c | 14 ++ > 1 file changed, 14 insertions(+) > > Index: libvirt-acl/src/conf

[libvirt] [PATCH] nwfilter: prevent multiple filters with different name but same UUID

Patch to prevent multiple nwfilters with different name but same UUID. Signed-off-by: Stefan Berger --- src/conf/nwfilter_conf.c | 14 ++ 1 file changed, 14 insertions(+) Index: libvirt-acl/src/conf/nwfilter_conf.c ===

Re: [libvirt] How to rename a domain?

On 10/12/2010 12:58 PM, Ganesh Pagade wrote: > Hi, > > I am using libvirt Java bindings. How can I rename a domain? Is there an API > to do this? > There is no API for it. The only way to do it is basically: virsh dumpxml myvm > foo.xml virsh undefine myvm virsh define foo.xml - Cole -- libv

Re: [libvirt] [PATCH 2/4] Audit VM start/stop/suspend/resume

On Thu, Oct 14, 2010 at 03:16:42PM +0100, Daniel P. Berrange wrote: > On Thu, Oct 14, 2010 at 04:09:41PM +0200, Daniel Veillard wrote: > > On Tue, Oct 12, 2010 at 06:32:16PM +0100, Daniel P. Berrange wrote: > > > From: Miloslav Trmač > > > > > > Most operations are audited at the libvirtd level;

Re: [libvirt] [PATCH 4/4] Fix symbol exports & remove duplicated libvirt_util.la linkage

On Thu, Oct 14, 2010 at 04:22:29PM +0200, Daniel Veillard wrote: > On Tue, Oct 12, 2010 at 06:32:18PM +0100, Daniel P. Berrange wrote: > > From: Miloslav Trmač > > > > The libvirt_util.la library was mistakenly linked into libvirtd > > directly. Since libvirt_util.la is already linked to libvirt.

Re: [libvirt] [PATCH 4/4] Fix symbol exports & remove duplicated libvirt_util.la linkage

On Tue, Oct 12, 2010 at 06:32:18PM +0100, Daniel P. Berrange wrote: > From: Miloslav Trmač > > The libvirt_util.la library was mistakenly linked into libvirtd > directly. Since libvirt_util.la is already linked to libvirt.so, > this resulted in libvirtd getting two copies of the code and > more c

Re: [libvirt] [PATCH 2/4] Audit VM start/stop/suspend/resume

On Thu, Oct 14, 2010 at 04:09:41PM +0200, Daniel Veillard wrote: > On Tue, Oct 12, 2010 at 06:32:16PM +0100, Daniel P. Berrange wrote: > > From: Miloslav Trmač > > > > Most operations are audited at the libvirtd level; auditing in > > src/libvirt.c would result in two audit entries per operation

Re: [libvirt] [PATCH 2/4] Audit VM start/stop/suspend/resume

On Tue, Oct 12, 2010 at 06:32:16PM +0100, Daniel P. Berrange wrote: > From: Miloslav Trmač > > Most operations are audited at the libvirtd level; auditing in > src/libvirt.c would result in two audit entries per operation (one in > the client, one in libvirtd). > > The only exception is a domain

Re: [libvirt] [PATCH v2] Added new attribute accessmode to filesystem element

On 10/14/2010 07:10 AM, Daniel Veillard wrote: otherwise, ACK. I was just a bit worried that if no model was given we always assume passthrough, but since that's what the QEMu backend implementation did so far and this doesn't affect other drivers, that's fine. Applied and pushed with that

Re: [libvirt] Mac OS X: dyld: lazy symbol binding failed

On Tue, Oct 12, 2010 at 02:56:31PM -0700, Mitchell Hashimoto wrote: > I've been working with Justin, and we've been making some progress. > However, I have another question for this list. As a follow-up to > this, I realized that when I download the snapshots and just > "./configure; make; make ins

Re: [libvirt] Improving our ChangeLog format?

On 10/15/2010 12:22 AM, Daniel Veillard wrote: Seems like we'd really need to "see it" before deciding. :) http://libvirt.org/news.test.html to get an idea, I didn't tried to clean everything up though Cool. That's going in the right direction. Can we add in a unique sort (sort -u), so it

Re: [libvirt] Improving our ChangeLog format?

On Thu, Oct 14, 2010 at 11:50:50PM +1100, Justin Clift wrote: > On 10/14/2010 11:40 PM, Daniel Veillard wrote: > > > This would run into incredibly long logs per release ! > >I was doing that in the very first releases see (bottom of news.html) > >I could change that to something more linear. Ma

Re: [libvirt] [PATCH v2] Added new attribute accessmode to filesystem element

On 10/14/2010 06:40 PM, Daniel Veillard wrote: On Thu, Oct 14, 2010 at 04:41:51PM +0530, Harsh Prateek Bora wrote: This patch introduces new attribute to filesystem element to support customizable access mode for mount type. Valid accessmode are: passthrough, mapped and squash. [...] @@ -1847,

Re: [libvirt] [PATCH] Fix statstest when driver modules are enabled

On Thu, Oct 14, 2010 at 01:23:53PM +0100, Daniel P. Berrange wrote: > The statstest is xen specific. Instead of filling the code with > a huge number of #ifdef WITH_XEN, just make its entire compilation > conditional in the Makefile.am. Also ensure it links to the Xen > driver so that it builds whe

Re: [libvirt] [PATCH v2] Added new attribute accessmode to filesystem element

On Thu, Oct 14, 2010 at 04:41:51PM +0530, Harsh Prateek Bora wrote: > This patch introduces new attribute to filesystem element > to support customizable access mode for mount type. > Valid accessmode are: passthrough, mapped and squash. [...] > @@ -1847,6 +1853,7 @@ virDomainFSDefParseXML(xmlNodeP

Re: [libvirt] Improving our ChangeLog format?

On 10/14/2010 11:40 PM, Daniel Veillard wrote: This would run into incredibly long logs per release ! I was doing that in the very first releases see (bottom of news.html) I could change that to something more linear. Maybe adding a at the end of each line would be sufficient though, and may

Re: [libvirt] Improving our ChangeLog format?

On Thu, Oct 14, 2010 at 01:06:56PM +0200, Matthias Bolte wrote: > 2010/10/14 Daniel P. Berrange : > > On Thu, Oct 14, 2010 at 08:55:24PM +1100, Justin Clift wrote: > >>   The PostgreSQL ChangeLog: > >>   http://www.postgresql.org/docs/9.0/static/release-9-0.html > > > > I don't believe that this co

[libvirt] [PATCH] Fix statstest when driver modules are enabled

The statstest is xen specific. Instead of filling the code with a huge number of #ifdef WITH_XEN, just make its entire compilation conditional in the Makefile.am. Also ensure it links to the Xen driver so that it builds when driver modules are enabled * tests/Makefile.am: Make statstest xen condit

Re: [libvirt] [PATCH] build: provide URL in 'configure --help'

On 10/13/2010 07:56 PM, Dave Allan wrote: On Wed, Oct 13, 2010 at 07:39:45PM -0600, Eric Blake wrote: * configure.ac (AC_INIT): Provide email and URL. --- Before: Report bugs to the package provider. After: Report bugs to. libvirt home page:. ACK Thanks; pushed. -- Er

Re: [libvirt] [PATCHv2] build: fix mingw build

On 10/14/2010 03:34 AM, Daniel Veillard wrote: On Wed, Oct 13, 2010 at 04:25:45PM -0600, Eric Blake wrote: * .gnulib: Update to latest, for termios fix. * configure.ac (AC_CHECK_HEADERS): Drop redundent check. Reported by Daniel P. Berrange. --- This fixes the problem in a more maintainable man

Re: [libvirt] [PATCH] Added new attribute accessmode to filesystem element

On 10/14/2010 04:38 PM, Daniel P. Berrange wrote: On Thu, Oct 14, 2010 at 04:24:45PM +0530, Harsh Prateek Bora wrote: This patch introduces new attribute to filesystem element to support customizable access mode for mount type. Valid accessmode are: passthrough, mapped and squash. Usage:

[libvirt] [PATCH v2] Added new attribute accessmode to filesystem element

This patch introduces new attribute to filesystem element to support customizable access mode for mount type. Valid accessmode are: passthrough, mapped and squash. Usage: Here is the detailed explanation on these access modes: Access mode: mapped -

Re: [libvirt] [PATCH] Added new attribute accessmode to filesystem element

On Thu, Oct 14, 2010 at 04:24:45PM +0530, Harsh Prateek Bora wrote: > This patch introduces new attribute to filesystem element > to support customizable access mode for mount type. > Valid accessmode are: passthrough, mapped and squash. > > Usage: > > > > > > Here is

Re: [libvirt] Improving our ChangeLog format?

2010/10/14 Daniel P. Berrange : > On Thu, Oct 14, 2010 at 08:55:24PM +1100, Justin Clift wrote: >> Hi all, >> >> Noticed an entry in a recent LWN.net article about PostgreSQL's >> conversion to git. >> >> One of the things mentioned sounds relevant to us : >> >>   Robert Haas has documented how to

[libvirt] [PATCH] Added new attribute accessmode to filesystem element

This patch introduces new attribute to filesystem element to support customizable access mode for mount type. Valid accessmode are: passthrough, mapped and squash. Usage: Here is the detailed explanation on these access modes: Access mode: mapped -

Re: [libvirt] Improving our ChangeLog format?

On 10/14/2010 09:09 PM, Daniel P. Berrange wrote: The changelog mention might be useful for us, as the PostgreSQL changelog looks a bunch more useful than ours. The PostgreSQL ChangeLog: http://www.postgresql.org/docs/9.0/static/release-9-0.html I don't believe that this corresponds to

Re: [libvirt] Improving our ChangeLog format?

On Thu, Oct 14, 2010 at 08:55:24PM +1100, Justin Clift wrote: > Hi all, > > Noticed an entry in a recent LWN.net article about PostgreSQL's > conversion to git. > > One of the things mentioned sounds relevant to us : > > Robert Haas has documented how to get commit summaries and sizes from >

[libvirt] Improving our ChangeLog format?

Hi all, Noticed an entry in a recent LWN.net article about PostgreSQL's conversion to git. One of the things mentioned sounds relevant to us : Robert Haas has documented how to get commit summaries and sizes from Git. He wrote a perl script (which Tom Lane improved) that allows you to pro

Re: [libvirt] [PATCH] qemu: Prohibit migration of guests with host devices

On Thu, Oct 14, 2010 at 11:45:37AM +0200, Daniel Veillard wrote: > On Thu, Oct 14, 2010 at 09:59:18AM +0100, Daniel P. Berrange wrote: > > On Thu, Oct 14, 2010 at 09:38:27AM +0200, Jiri Denemark wrote: > > > Explicitly raising a nice error in the case user tries to migrate a > > > guest with assign

Re: [libvirt] [PATCH] qemu: Prohibit migration of guests with host devices

> > Explicitly raising a nice error in the case user tries to migrate a > > guest with assigned host devices is much better than waiting for a > > mysterious error with no clue for the reason. > > ACK, good idea. Thanks, pushed. Jirka -- libvir-list mailing list libvir-list@redhat.com https://w

Re: [libvirt] [PATCH] qemu: Prohibit migration of guests with host devices

On Thu, Oct 14, 2010 at 09:59:18AM +0100, Daniel P. Berrange wrote: > On Thu, Oct 14, 2010 at 09:38:27AM +0200, Jiri Denemark wrote: > > Explicitly raising a nice error in the case user tries to migrate a > > guest with assigned host devices is much better than waiting for a > > mysterious error wi

Re: [libvirt] [PATCH] esx: Explictly declare VMX file content as UTF-8

On Thu, Oct 14, 2010 at 08:59:18AM +0200, Matthias Bolte wrote: > --- > src/esx/esx_vmx.c |3 +++ > tests/xml2vmxdata/xml2vmx-annotation.vmx |1 + > tests/xml2vmxdata/xml2vmx-cdrom-ide-device.vmx |1 + > tests/xml2vmxdata/xml2vmx-cdrom-ide

Re: [libvirt] [PATCHv2] build: fix mingw build

On Wed, Oct 13, 2010 at 04:25:45PM -0600, Eric Blake wrote: > * .gnulib: Update to latest, for termios fix. > * configure.ac (AC_CHECK_HEADERS): Drop redundent check. > Reported by Daniel P. Berrange. > --- > > This fixes the problem in a more maintainable manner. > > Tested via ./autobuild.sh on

Re: [libvirt] Xen string2sexpr and sexpr2string lose quotes?

On Thu, Aug 19, 2010 at 02:53:39PM +0100, Daniel P. Berrange wrote: > On Tue, Aug 17, 2010 at 08:26:09PM -0700, Thomas Graves wrote: > > Hello all, > > > > I am running xen on rhel5 and using libvirt0.7.2 (I also tried 0.7.7) and it > > looks like the routines string2sexpr and sexpr2string seem to

Re: [libvirt] [PATCH] qemu: Prohibit migration of guests with host devices

On Thu, Oct 14, 2010 at 09:38:27AM +0200, Jiri Denemark wrote: > Explicitly raising a nice error in the case user tries to migrate a > guest with assigned host devices is much better than waiting for a > mysterious error with no clue for the reason. > --- > src/qemu/qemu_driver.c | 19 ++

Re: [libvirt] [PATCHv2] build: fix mingw build

On 10/14/2010 07:47 PM, Daniel P. Berrange wrote: Yes, this is one of those bits of GIT black-magic. .gnulib isn't a file, its a checkout of an entire 3rd party GIT repository, at the specified changeset has. Not sure why git am isn't happy about appliny it though. Yeah. Applying it worked af

Re: [libvirt] [PATCH] Improve error reporting in test suites

On Wed, Oct 13, 2010 at 11:27:21AM -0600, Eric Blake wrote: > On 10/13/2010 08:45 AM, Eric Blake wrote: > >On 10/13/2010 05:11 AM, Daniel P. Berrange wrote: > >>Before running each test case clear the thread local error > >>indicator. After running each test case, dispatch any error > >>that was re

Re: [libvirt] [PATCHv2] build: fix mingw build

On Thu, Oct 14, 2010 at 03:31:27PM +1100, Justin Clift wrote: > On 10/14/2010 09:25 AM, Eric Blake wrote: > > >diff --git a/.gnulib b/.gnulib > >index 2bb63bf..b6d1430 16 > >--- a/.gnulib > >+++ b/.gnulib > >@@ -1 +1 @@ > >-Subproject commit 2bb63bfb25474ea147ee9f1523c0337997359a4c > >+Subproj

Re: [libvirt] [PATCH v3] Added new attribute mount_security to filesystem element

On Thu, Oct 14, 2010 at 11:00:24AM +0530, Harsh Bora wrote: > On 10/13/2010 09:22 PM, Matthias Bolte wrote: > >2010/10/11 Harsh Prateek Bora: > >>This patch introduces new attribute to filesystem element > >>to support customizable security for mount type. > >>Valid mount_security are: passthrough

Re: [libvirt] [PATCH] cpu: Use vendor in baseline CPU only if all hosts use it

> > When only some host CPUs given to cpuBaseline contain element, > > baseline CPU should not contain it. Otherwise the result would not be > > compatible with the host CPUs without vendor. CPU vendors are still > > taken into account when computing baseline CPU, it's just removed from > > the re

Re: [libvirt] [PATCH] cpu: Fix vendor for recent CPU models

> > Recent CPU models were specified using invalid vendor element > > NAME, which was silently ignored due to a bug in the > > code which was parsing it. > > ACK. Thanks, pushed. Jirka -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/2] tests: Make debuging 'make check' failures easier

> > Jiri Denemark (2): > >tests: Do not override LIBVIRT_DEBUG variable > >tests: Honor LIBVIRT_{DEBUG,LOG_*} variables > > ACK series. Thanks, pushed. Jirka -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] esx: Handle name escaping properly

On Wed, Oct 13, 2010 at 10:47:57PM +0200, Matthias Bolte wrote: > 2010/10/13 Daniel Veillard : > > On Wed, Oct 13, 2010 at 11:06:44AM +0200, Matthias Bolte wrote: > >> VMware uses a mix of percent-, pipe- and base64-encoding in > >> different combinations in different places. > >> > >> Add a testca

[libvirt] [PATCH] qemu: Prohibit migration of guests with host devices

Explicitly raising a nice error in the case user tries to migrate a guest with assigned host devices is much better than waiting for a mysterious error with no clue for the reason. --- src/qemu/qemu_driver.c | 19 +++ 1 files changed, 19 insertions(+), 0 deletions(-) diff --git

[libvirt] [PATCH] esx: Explictly declare VMX file content as UTF-8

--- src/esx/esx_vmx.c |3 +++ tests/xml2vmxdata/xml2vmx-annotation.vmx |1 + tests/xml2vmxdata/xml2vmx-cdrom-ide-device.vmx |1 + tests/xml2vmxdata/xml2vmx-cdrom-ide-file.vmx |1 + tests/xml2vmxdata/xml2vmx-cdrom-scsi-device.vmx