Re: [libvirt] [PATCH v2 1/2] timer impl

2010-12-14 Thread Wen Congyang
At 2010-12-15 14:32, Hu Tao Write: > On Wed, Dec 15, 2010 at 10:34:25AM +0800, Wen Congyang wrote: >> * src/util/timer.c src/util/timer.h src/util/timer_linux.c >> src/util/timer_win32.c: >> timer implementation >> * src/Makefile.am: build timer >> * src/libvirt_private.syms: Export public funct

Re: [libvirt] [PATCH v2 1/2] timer impl

2010-12-14 Thread Hu Tao
On Wed, Dec 15, 2010 at 10:34:25AM +0800, Wen Congyang wrote: > * src/util/timer.c src/util/timer.h src/util/timer_linux.c > src/util/timer_win32.c: > timer implementation > * src/Makefile.am: build timer > * src/libvirt_private.syms: Export public functions > * src/libvirt.c: Initialize timer >

[libvirt] [PATCH v2 2/2] auto cold migration fallback at timeout

2010-12-14 Thread Wen Congyang
implement auto cold migration fallback at timeout Signed-off-by: Wen Congyang --- tools/virsh.c | 53 + 1 files changed, 53 insertions(+), 0 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index 4e37f2d..794b97a 100644 --- a/tools/v

[libvirt] [PATCH v2 1/2] timer impl

2010-12-14 Thread Wen Congyang
* src/util/timer.c src/util/timer.h src/util/timer_linux.c src/util/timer_win32.c: timer implementation * src/Makefile.am: build timer * src/libvirt_private.syms: Export public functions * src/libvirt.c: Initialize timer * configure.ac: check the functions in librt used by timer Signed-off-by:

[libvirt] [Patch v2 0/2] Add new feature into live migration

2010-12-14 Thread Wen Congyang
If the memory of guest OS is changed constantly, the live migration can not be ended ever for ever. We can use the command 'virsh migrate-setmaxdowntime' to control the live migration. But the value of maxdowntime is diffcult to calculate because it depends on the transfer speed of network and con

[libvirt] [PATCH] build: improve testsuite results with older automake

2010-12-14 Thread Eric Blake
* tests/Makefile.am (TESTS_ENVIRONMENT, commandtest_CFLAGS) (commandhelper_CFLAGS): Avoid $(builddir) and $(abs_builddir) in automake 1.9.6; fixes spurious failures of commandtest. --- tests/Makefile.am |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/Makefile.

[libvirt] [PATCH] build: allow older libselinux again

2010-12-14 Thread Eric Blake
* configure.ac (with_selinux): Check for . * src/security/security_selinux.c (getContext): New function. (SELinuxRestoreSecurityFileLabel): Use it to restore compilation when using older libselinux. --- Although this fixes a build-breaker on RHEL, I'd rather get it reviewed before pushing. Compil

Re: [libvirt] [PATCH] build: allow autoconf 2.59 again

2010-12-14 Thread Eric Blake
On 12/14/2010 01:57 PM, Eric Blake wrote: > * configure.ac (libpcap): Avoid AS_CASE. > --- > > This fixes the autoconf build problem. But now I'm running into > a build problem with automake 1.9.6 not generating $(localedir), > which leads to configmake.h missing out on LOCALEDIR. I have tested

Re: [libvirt] [PATCH 8/n] selinux: avoid memory overhead of matchpathcon

2010-12-14 Thread Eric Blake
On 11/30/2010 08:54 PM, Eric Blake wrote: > * src/security/security_selinux.c > (SELinuxRestoreSecurityFileLabel): Use selabel_lookup instead of > matchpathcon. > Suggested by Daniel Walsh. > --- > > #include > #include > +#include > #include > #include > #include Phooey. This breaks

[libvirt] [PATCH] build: allow autoconf 2.59 again

2010-12-14 Thread Eric Blake
* configure.ac (libpcap): Avoid AS_CASE. --- This fixes the autoconf build problem. But now I'm running into a build problem with automake 1.9.6 not generating $(localedir), which leads to configmake.h missing out on LOCALEDIR. configure.ac | 10 +- 1 files changed, 5 insertions(+), 5

Re: [libvirt] [PATCH 1/2] build: properly handle ./configure --with-libpcap

2010-12-14 Thread Eric Blake
On 12/13/2010 06:44 AM, Diego Elio Pettenò wrote: > Without this fix, ./configure --with-libpcap will cause --with-libpcap=yes > to be implicitly passed down, which cause yes/bin/pcap-config to be > searched for rather than /usr/bin/pcap-config. > > + AS_CASE(["x$with_libpcap"], > +[xno], [LI

Re: [libvirt] libvirt-guests output

2010-12-14 Thread Eric Blake
On 12/14/2010 10:58 AM, Laurent Léonard wrote: >>> New patch 0010-Debianize-libvirt-guests.patch >>> >>> + if ! $configured; then >>> +-echo $"Ignoring guests on $uri URI" >>> ++echo "Ignoring guests on $uri URI" >> >> It might make sense to introduce a function:

Re: [libvirt] [PATCHv3] PHYP: Adding network interface management

2010-12-14 Thread Eric Blake
On 12/13/2010 01:09 PM, Eduardo Otubo wrote: > This is the implementation of the previous patch now using virInterface* > API. Ended up this patch got much more simpler, smaller and easier to > review. Here is some details: > You may want to use --enable-compile-warnings=error at autogen.sh time,

[libvirt] [Patch v4] Add VMware Workstation and Player driver

2010-12-14 Thread Jean-Baptiste Rouault
* Changes since v3: Fix x86_64 guests support checking Use UNIX PID for the VM ID Use virDomainObjIsDuplicate() where applicable Remove the (normally) last duplicated errors Various minor fixes -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 3/3] Add a new function doStartCPUs

2010-12-14 Thread Eric Blake
On 12/14/2010 12:40 AM, Hu Tao wrote: > --- > src/qemu/qemu_driver.c | 63 ++- > 1 files changed, 24 insertions(+), 39 deletions(-) > > diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c > index 484bdeb..c096890 100644 > --- a/src/qemu/qemu_

Re: [libvirt] [PATCH 2/3] Add a new function doStopCPUs

2010-12-14 Thread Eric Blake
On 12/14/2010 12:40 AM, Hu Tao wrote: > --- > src/qemu/qemu_driver.c | 64 +-- > 1 files changed, 23 insertions(+), 41 deletions(-) > > diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c > index 8b3546d..484bdeb 100644 > --- a/src/qemu/qemu_

Re: [libvirt] [PATCH 1/3] Add a macro timeval_to_ms to compute micro seconds from timeval

2010-12-14 Thread Eric Blake
On 12/14/2010 12:40 AM, Hu Tao wrote: > --- > src/qemu/qemu_driver.c | 24 ++-- > 1 files changed, 10 insertions(+), 14 deletions(-) > > diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c > index b9c5003..8b3546d 100644 > --- a/src/qemu/qemu_driver.c > +++ b/src/qe

Re: [libvirt] [libvirt PATCH] 802.1Qbh: Add support for IFLA_VF_MAC

2010-12-14 Thread roprabhu
Thanks Stefan. On 12/13/10 8:14 AM, "Stefan Berger" wrote: > On 12/10/2010 04:32 PM, Roopa Prabhu wrote: >> From: Roopa Prabhu >> >> Current code does not pass VM mac address to a 802.1Qbh direct attach >> interface using IFLA_VF_MAC. This patch adds support in macvtap code to >> send IFLA_VF

Re: [libvirt] [PATCH] daemon: plug a memory leak

2010-12-14 Thread Daniel P. Berrange
On Mon, Dec 13, 2010 at 03:49:15PM -0700, Eric Blake wrote: > * daemon/libvirtd.c (qemudStartWorker, qemudStartEventLoop): Avoid > leaking pthread_attr resources. > --- > daemon/libvirtd.c | 36 ++-- > 1 files changed, 26 insertions(+), 10 deletions(-) NB this co

Re: [libvirt] Got time to try out the libvirt 0.8.6 win32 package?

2010-12-14 Thread Justin Clift
On 14/12/2010, at 10:07 PM, Daniel P. Berrange wrote: > This really wants a trivial GTK app around it. Just popup a > dialog box, that populates a list of auto-detected URLs from > avahi (or Win32 equivalent), or a text field to enter one > manually. Then just launch virsh with whatever they choose

Re: [libvirt] Got time to try out the libvirt 0.8.6 win32 package?

2010-12-14 Thread Daniel P. Berrange
On Mon, Dec 13, 2010 at 06:32:43PM +0100, Matthias Bolte wrote: > 2010/12/13 Justin Clift : > > On 14/12/2010, at 3:38 AM, Daniel P. Berrange wrote: > >> This raises the question of how the tools depending on libvirt > >> will be distributed. eg virt-viewer.  If they're separate, then > >> we need

Re: [libvirt] [PATCH] util: Fix error message in __virExec

2010-12-14 Thread Jiri Denemark
> > Remove superfluous ": %s" suffix from the error message. > > --- > > src/util/util.c |2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/src/util/util.c b/src/util/util.c > > index 1b5bc68..e24facb 100644 > > --- a/src/util/util.c > > +++ b/src/util/util.c >

Re: [libvirt] [PATCH] daemon: Change CWD to / before daemonizing

2010-12-14 Thread Jiri Denemark
> > We were doing so for child processes but not for libvirtd itself. > > --- > > daemon/libvirtd.c |7 +++ > > 1 files changed, 7 insertions(+), 0 deletions(-) > > > > diff --git a/daemon/libvirtd.c b/daemon/libvirtd.c > > index 791b3dc..58fc492 100644 > > --- a/daemon/libvirtd.c > > +++

Re: [libvirt] [PATCH] util: Fix logical error in virReportSystemErrorFull

2010-12-14 Thread Jiri Denemark
> > --- > > src/util/virterror.c |2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/src/util/virterror.c b/src/util/virterror.c > > index 6e49fa2..b912737 100644 > > --- a/src/util/virterror.c > > +++ b/src/util/virterror.c > > @@ -1301,7 +1301,7 @@ void virRepo

Re: [libvirt] [PATCH] cpu: Unify CPUID data structures

2010-12-14 Thread Jiri Denemark
> > src/cpu/cpu_x86.c | 576 > > +-- > > src/cpu/cpu_x86_data.h |4 +- > > 2 files changed, 259 insertions(+), 321 deletions(-) > > > > Nice cleanup. > > ACK. Thanks, I pushed the patch without any modifications. > > + > > +static void >