Re: [libvirt] [PATCH 2/3] qemu: improve device flag parsing

2011-01-17 Thread Wen Congyang
At 01/14/2011 03:10 AM, Eric Blake Write: > * src/qemu/qemu_capabilities.h (qemuCapsParseDeviceStr): New > prototype. > * src/qemu/qemu_capabilities.c (qemuCapsParsePCIDeviceStrs) > Rename and split... > (qemuCapsExtractDeviceStr, qemuCapsParseDeviceStr): ...to make it > easier to add and test devi

[libvirt] [PATCH] docs: document element

2011-01-17 Thread Eric Blake
* docs/formatdomain.html.in: Talk about and throughout. --- Adding a new and use of for use by smartcard will be a lot easier if I can compare the changes to existing and locations. To my surprise, there wasn't any documentation for existing uses. Suggestions for polishing this are welcome

Re: [libvirt] [RFC PATCHv2 5/5] WIP: smartcard: turn on qemu support

2011-01-17 Thread Eric Blake
On 01/17/2011 11:42 AM, Alon Levy wrote: >>> dev: ccid-card-emulated, id "" >>> dev-prop: backend = "nss-emulated" >>> dev-prop: cert1 = >>> dev-prop: cert2 = >>> dev-prop: cert3 = >>> dev-prop: db = >

Re: [libvirt] [RFC PATCHv2 5/5] WIP: smartcard: turn on qemu support

2011-01-17 Thread Alon Levy
On Mon, Jan 17, 2011 at 11:30:38AM -0700, Eric Blake wrote: > On 01/15/2011 06:30 AM, Alon Levy wrote: > >> In other words a hierarchy > >> > >> USB bus 0 > >>| > >>+- ccid0 > >>| | > >>| +- smartcard0 (ccid slot 0) > >>| +- smartcard1 (ccid slot 3) > >>|

Re: [libvirt] [RFC PATCHv2 5/5] WIP: smartcard: turn on qemu support

2011-01-17 Thread Eric Blake
On 01/15/2011 06:30 AM, Alon Levy wrote: >> In other words a hierarchy >> >> USB bus 0 >>| >>+- ccid0 >>| | >>| +- smartcard0 (ccid slot 0) >>| +- smartcard1 (ccid slot 3) >>| >>+- ccid1 >> | >> +- smartcard2 (ccid slot 0) I'm oka

[libvirt] [PATCH] build: use more gnulib modules for simpler code

2011-01-17 Thread Eric Blake
* .gnulib: Update to latest, for sigpipe and sigaction modules. * bootstrap.conf (gnulib_modules): Add siaction, sigpipe, strerror_r. * tools/virsh.c (vshSetupSignals) [!SIGPIPE]: Delete, now that gnulib guarantees it. (SA_SIGINFO): Define for mingw fallback. * src/util/virterror.c (virStrerror): S

Re: [libvirt] [PATCH 6/7] qemu: use lighter-weight fd:n on incoming tunneled migration

2011-01-17 Thread Paolo Bonzini
On 01/14/2011 09:48 PM, Eric Blake wrote: Outgoing migration still has to use a Unix socket and or exec netcat, since there is no way to pass a migration fd into qemu via monitor commands, but incoming migration need not suffer from the complexity. * src/qemu/qemu_driver.c (qemudDomainMigratePre

Re: [libvirt] [PATCH 5/7] qemu: use -incoming fd:n to avoid qemu holding fd indefinitely

2011-01-17 Thread Eric Blake
On 01/15/2011 03:27 PM, Matthias Bolte wrote: > 2011/1/14 Eric Blake : >> https://bugzilla.redhat.com/show_bug.cgi?id=620363 >> >> When using -incoming stdio or -incoming exec:, qemu keeps the >> stdin fd open long after the migration is complete. Not to >> mention that exec:cat is horribly ineffi

Re: [libvirt] [PATCH v2 0/4] Explicit boot device ordering

2011-01-17 Thread Jiri Denemark
> Jiri Denemark (4): > conf: Move boot parsing into a separate function > Introduce per-device boot element > qemu: Support per-device boot ordering > tests: Add tests for per-device boot elements Thanks Eric and Dan for reviews. I squashed 5/4 into 2/4 and pushed the series. Jirka -- li

Re: [libvirt] [PATCH v2 1/4] conf: Move boot parsing into a separate function

2011-01-17 Thread Daniel P. Berrange
On Fri, Jan 14, 2011 at 06:04:43PM +0100, Jiri Denemark wrote: > --- > src/conf/domain_conf.c | 99 > > 1 files changed, 58 insertions(+), 41 deletions(-) ACK Daniel -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mai

Re: [libvirt] [PATCH v2 5/4] Check that boot order sequence is correct

2011-01-17 Thread Daniel P. Berrange
On Mon, Jan 17, 2011 at 01:46:09PM +0100, Jiri Denemark wrote: > Since I haven't pushed the series yet, I can easily squash the following patch > into patch 2/4. > > Jirka > > >From 5302f9ca43e26bd23230ba84e169a0e9109d04e8 Mon Sep 17 00:00:00 2001 > Message-Id: > <5302f9ca43e26bd23230ba84e169a0e

Re: [libvirt] [PATCH v2 3/4] qemu: Support per-device boot ordering

2011-01-17 Thread Daniel P. Berrange
On Fri, Jan 14, 2011 at 06:04:45PM +0100, Jiri Denemark wrote: > Support for this is included in qemu and seabios from upstream git. > > --- > Notes: > Version 2: > - support for floppy devices > - rebased on top of Eric's capabilities changes > > src/qemu/qemu_capabilities.c |9

Re: [libvirt] [PATCH v2 4/4] tests: Add tests for per-device boot elements

2011-01-17 Thread Daniel P. Berrange
On Fri, Jan 14, 2011 at 06:04:46PM +0100, Jiri Denemark wrote: > > --- > Notes: > Version 2: > - support for floppy devices > > .../qemuxml2argvdata/qemuxml2argv-boot-order.args |1 + > tests/qemuxml2argvdata/qemuxml2argv-boot-order.xml | 52 > > tests/qemuxm

Re: [libvirt] [PATCH] qemu: Error prompt if invalid dump image format specified

2011-01-17 Thread Osier Yang
于 2011年01月17日 22:41, Eric Blake 写道: > On 01/16/2011 09:39 PM, Osier Yang wrote: >> "getCompressionType" trys to throw error when invalid dump image >> format is specified, or the compression program for the specified >> image format is not available, but at the same time, it returns >> enum qemud_s

Re: [libvirt] [PATCH v2 2/4] Introduce per-device boot element

2011-01-17 Thread Daniel P. Berrange
On Fri, Jan 14, 2011 at 06:04:44PM +0100, Jiri Denemark wrote: > Currently, boot order can be specified per device class but there is no > way to specify exact disk/NIC device to boot from. > > This patch adds element which can be used inside > and . This is incompatible with the older os/boot >

Re: [libvirt] [PATCH v2 5/4] Check that boot order sequence is correct

2011-01-17 Thread Eric Blake
On 01/17/2011 05:46 AM, Jiri Denemark wrote: > Since I haven't pushed the series yet, I can easily squash the following patch > into patch 2/4. > > Jirka > > From 5302f9ca43e26bd23230ba84e169a0e9109d04e8 Mon Sep 17 00:00:00 2001 > Message-Id: > <5302f9ca43e26bd23230ba84e169a0e9109d04e8.129526817

Re: [libvirt] [PATCH 4/7] build: let xgettext see strings in libvirt-guests

2011-01-17 Thread Eric Blake
On 01/15/2011 12:49 PM, Matthias Bolte wrote: > 2011/1/14 Eric Blake : >> * tools/libvirt-guests.init.in: Rename... >> * tools/libvirt-guests.init.sh: ...so that xgettext's language >> detection via suffix will work. >> * po/POTFILES.in: Update all references. >> * tools/Makefile.am (EXTRA_DIST, li

Re: [libvirt] [PATCH] qemu: Error prompt if invalid dump image format specified

2011-01-17 Thread Eric Blake
On 01/16/2011 09:39 PM, Osier Yang wrote: > "getCompressionType" trys to throw error when invalid dump image > format is specified, or the compression program for the specified > image format is not available, but at the same time, it returns > enum qemud_save_formats, as a result, upper function w

Re: [libvirt] [RFC PATCHv2 3/5] smartcard: add XML support for device

2011-01-17 Thread Daniel P. Berrange
On Mon, Jan 17, 2011 at 03:23:55PM +0200, Alon Levy wrote: > On Mon, Jan 17, 2011 at 11:17:07AM +, Daniel P. Berrange wrote: > > On Sat, Jan 15, 2011 at 02:37:33PM +0200, Alon Levy wrote: > > > On Fri, Jan 14, 2011 at 10:22:19AM -0700, Eric Blake wrote: > > > > On 01/14/2011 05:24 AM, Daniel P.

Re: [libvirt] [RFC PATCHv2 3/5] smartcard: add XML support for device

2011-01-17 Thread Alon Levy
On Mon, Jan 17, 2011 at 11:17:07AM +, Daniel P. Berrange wrote: > On Sat, Jan 15, 2011 at 02:37:33PM +0200, Alon Levy wrote: > > On Fri, Jan 14, 2011 at 10:22:19AM -0700, Eric Blake wrote: > > > On 01/14/2011 05:24 AM, Daniel P. Berrange wrote: > > > > On Thu, Jan 13, 2011 at 05:34:35PM -0700,

[libvirt] [PATCH v2 5/4] Check that boot order sequence is correct

2011-01-17 Thread Jiri Denemark
Since I haven't pushed the series yet, I can easily squash the following patch into patch 2/4. Jirka >From 5302f9ca43e26bd23230ba84e169a0e9109d04e8 Mon Sep 17 00:00:00 2001 Message-Id: <5302f9ca43e26bd23230ba84e169a0e9109d04e8.1295268171.git.jdene...@redhat.com> From: Jiri Denemark Date: Mon, 1

Re: [libvirt] [PATCH] qemu: Error prompt if invalid dump image format specified

2011-01-17 Thread Daniel P. Berrange
On Mon, Jan 17, 2011 at 12:39:21PM +0800, Osier Yang wrote: > "getCompressionType" trys to throw error when invalid dump image > format is specified, or the compression program for the specified > image format is not available, but at the same time, it returns > enum qemud_save_formats, as a result

Re: [libvirt] [PATCH] Simplify "NWFilterPool" to "NWFilter"

2011-01-17 Thread Daniel P. Berrange
On Sun, Jan 16, 2011 at 12:00:41AM +0100, Matthias Bolte wrote: > The public object is called NWFilter but the corresponding private > object is called NWFilterPool. I don't see compelling reasons for this > Pool suffix. One might argue that an NWFilter is a "pool" of rules, etc. > > Remove the Po

Re: [libvirt] [PATCH] Remove two unused PATH_MAX-sized char arrays from the stack

2011-01-17 Thread Daniel P. Berrange
On Sun, Jan 16, 2011 at 12:05:32AM +0100, Matthias Bolte wrote: > --- > src/storage/storage_driver.c | 16 ++-- > src/uml/uml_driver.c |8 ++-- > 2 files changed, 4 insertions(+), 20 deletions(-) > > diff --git a/src/storage/storage_driver.c b/src/storage/storage_dri

Re: [libvirt] [PATCH] Add documentation for VIR_DOMAIN_MEMORY_PARAM_UNLIMITED

2011-01-17 Thread Daniel P. Berrange
On Sat, Jan 15, 2011 at 11:48:18PM +0100, Matthias Bolte wrote: > Otherwise apibuild.py complains about it. > --- > include/libvirt/libvirt.h.in |7 +++ > 1 files changed, 7 insertions(+), 0 deletions(-) > > diff --git a/include/libvirt/libvirt.h.in b/include/libvirt/libvirt.h.in > index

Re: [libvirt] [PATCH] Use VIR_ERR_OPERATION_INVALID when appropriated

2011-01-17 Thread Daniel P. Berrange
On Sun, Jan 16, 2011 at 12:04:46AM +0100, Matthias Bolte wrote: > VIR_ERR_OPERATION_INVALID means that the operation is not valid > for the current state of the involved object. > --- > src/esx/esx_driver.c|1 - > src/lxc/lxc_driver.c|2 +- > src/network/bridge_driver.c |

Re: [libvirt] [PATCH] Fix misuse of VIR_ERR_INVALID_* error code

2011-01-17 Thread Daniel P. Berrange
On Sun, Jan 16, 2011 at 12:03:46AM +0100, Matthias Bolte wrote: > VIR_ERR_INVALID_* is meant for invalid pointers only. > --- > src/conf/nwfilter_conf.c |6 +++--- > src/conf/storage_conf.c |2 +- > src/network/bridge_driver.c | 20 +++

Re: [libvirt] [PATCH] datatypes: Get virSecretFreeName in sync with the other free functions

2011-01-17 Thread Daniel P. Berrange
On Sat, Jan 15, 2011 at 11:47:41PM +0100, Matthias Bolte wrote: > --- > src/datatypes.c | 15 ++- > 1 files changed, 6 insertions(+), 9 deletions(-) > > diff --git a/src/datatypes.c b/src/datatypes.c > index c549c74..b43a571 100644 > --- a/src/datatypes.c > +++ b/src/datatypes.c > @

Re: [libvirt] [PATCH] datatypes: Fix outdated function names in the documentation

2011-01-17 Thread Daniel P. Berrange
On Sat, Jan 15, 2011 at 11:48:57PM +0100, Matthias Bolte wrote: > --- > src/datatypes.c |8 > 1 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/src/datatypes.c b/src/datatypes.c > index b43a571..5197863 100644 > --- a/src/datatypes.c > +++ b/src/datatypes.c > @@ -821,

Re: [libvirt] [PATCH] docs: Move the "Network Filtering" page one level up in the hierarchy

2011-01-17 Thread Daniel P. Berrange
On Sat, Jan 15, 2011 at 02:48:03PM +0100, Matthias Bolte wrote: > "Network Filtering" is not directly related to "Networks". > > Suggested by Daniel P. Berrange. > --- > docs/sitemap.html.in | 10 -- > 1 files changed, 4 insertions(+), 6 deletions(-) > > diff --git a/docs/sitemap.html.

Re: [libvirt] [RFC PATCHv2 3/5] smartcard: add XML support for device

2011-01-17 Thread Daniel P. Berrange
On Sat, Jan 15, 2011 at 02:37:33PM +0200, Alon Levy wrote: > On Fri, Jan 14, 2011 at 10:22:19AM -0700, Eric Blake wrote: > > On 01/14/2011 05:24 AM, Daniel P. Berrange wrote: > > > On Thu, Jan 13, 2011 at 05:34:35PM -0700, Eric Blake wrote: > > >> Assuming a hypervisor that supports multiple smartc

Re: [libvirt] website: API reference for virterror contains libvirt API also

2011-01-17 Thread Matthias Bolte
2010/3/23 Matthias Bolte : > The API reference website [1] for virterror contains the API reference > for virterror as expected. But the complete libvirt API reference, > that is already found at [2], is appended too. > > I looked into the XSLT process that generates those two HTML files > from the

Re: [libvirt] [PATCH v2 4/4] tests: Add tests for per-device boot elements

2011-01-17 Thread Jiri Denemark
On Fri, Jan 14, 2011 at 11:51:56 -0700, Eric Blake wrote: > On 01/14/2011 10:04 AM, Jiri Denemark wrote: > > + > > + > > + > > + > > + > > + > > + > > + > > Just to make sure I'm clear - if any has a sub-element, > then all remaining disks (in this c