Re: [libvirt] [PATCH] avoid shutting down the vm twice

2011-02-02 Thread Eric Blake
On 02/02/2011 06:18 AM, Jiri Denemark wrote: >>> + * vm is active before shutdown. >>> + */ >>> +if (virDomainObjIsActive(vm)) >>> +qemudShutdownVMDaemon(driver, vm, 0); >> >> I'm still playing with this patch, but at first glance, it is making >> sense to me. > > The patch mak

[libvirt] [PATCH] qemu: avoid double shutdown

2011-02-02 Thread Eric Blake
* src/qemu/qemu_driver.c (qemudShutdownVMDaemon): Check that vm is still active. Reported by Wen Congyang as follows: Steps to reproduce this bug: 1. use gdb to debug libvirtd, and set breakpoint in the function qemuConnectMonitor() 2. start a vm, and the libvirtd will be stopped in qemuConnec

Re: [libvirt] [PATCH] Add check for binary existing in machine type probe

2011-02-02 Thread Eric Blake
On 02/02/2011 05:36 AM, Daniel P. Berrange wrote: > When probing machine types if the QEMU binary does not exist > we get a hard to diagnose error, due to the execve() in the > child failing > > error: internal error Child process exited with status 1. > > Add an explicit check so that we get >

Re: [libvirt] [PATCH] Imprint all logs with version + package build information

2011-02-02 Thread Daniel P. Berrange
On Wed, Feb 02, 2011 at 09:43:28AM -0700, Eric Blake wrote: > On 02/02/2011 05:18 AM, Daniel P. Berrange wrote: > > The logging functions are enhanced so that immediately prior to > > the first log message being printed to any output channel, the > > libvirt package version will be printed. > > gi

Re: [libvirt] [PATCH] Add a little more debugging for async events

2011-02-02 Thread Eric Blake
On 02/02/2011 05:18 AM, Daniel P. Berrange wrote: > To make it easier to investigate problems with async event > delivery, add two more debugging lines > > * daemon/remote.c: Debug when an event is queued for dispatch > * src/remote/remote_driver.c: Debug when an event is received > for processi

Re: [libvirt] [PATCH] Imprint all logs with version + package build information

2011-02-02 Thread Eric Blake
On 02/02/2011 05:18 AM, Daniel P. Berrange wrote: > The logging functions are enhanced so that immediately prior to > the first log message being printed to any output channel, the > libvirt package version will be printed. git send-email --subject-prefix=PATCHv2 is a neat trick, as is summarizing

Re: [libvirt] [PATCH] docs: more on qemu locking patterns

2011-02-02 Thread Eric Blake
On 02/02/2011 03:52 AM, Daniel P. Berrange wrote: > On Tue, Feb 01, 2011 at 05:37:10PM -0700, Eric Blake wrote: >> * src/qemu/THREADS.txt: Improve documentation. >> --- >> >>qemuDomainObjExitMonitor() >> -- Acquires the virDomainObjPtr lock >> - Releases the qemuMonitorObjPtr lock >> +

Re: [libvirt] [PATCH] qemu: Add shortcut for HMP pass through

2011-02-02 Thread Eric Blake
On 02/02/2011 08:49 AM, Jiri Denemark wrote: > Currently users who want to use virDomainQemuMonitorCommand() API or > it's virsh equivalent has to use the same protocol as libvirt uses for > communication to qemu. Since the protocol is QMP with current qemu and > HMP much more usable for humans, on

Re: [libvirt] [PATCH 3/3] Add myself to AUTHORS

2011-02-02 Thread Eric Blake
On 02/02/2011 08:30 AM, Niels de Vos wrote: > On Wed, Feb 2, 2011 at 12:04 PM, Daniel P. Berrange > wrote: >> On Tue, Feb 01, 2011 at 04:22:03PM +, Niels de Vos wrote: >>> Without this, ./autobuild.sh fails. >>> >> ACK assuming you want this particular email addr recorded >> >> Daniel > > Th

Re: [libvirt] [PATCH 1/3] qemuBuildDeviceAddressStr() checks for QEMUD_CMD_FLAG_PCI_MULTIBUS

2011-02-02 Thread Eric Blake
On 02/01/2011 09:22 AM, Niels de Vos wrote: > -virBufferVSprintf(buf, ",bus=pci.0,addr=0x%x", info->addr.pci.slot); > +if (qemuCmdFlags & QEMUD_CMD_FLAG_PCI_MULTIBUS) > +virBufferVSprintf(buf, ",bus=pci.0,addr=0x%x", > info->addr.pci.slot); > +else > +

[libvirt] [PATCH] qemu: Add shortcut for HMP pass through

2011-02-02 Thread Jiri Denemark
Currently users who want to use virDomainQemuMonitorCommand() API or it's virsh equivalent has to use the same protocol as libvirt uses for communication to qemu. Since the protocol is QMP with current qemu and HMP much more usable for humans, one ends up typing something like the following: v

[libvirt] Strange nodedev-dumpxml ??

2011-02-02 Thread arnaud.champion
?Hi, I have maybe a strange thing on a nodedev-dumpxml virsh result : virsh # nodedev-dumpxml block_sr0 block_sr0 scsi_0_0_1_0 /dev/sr0 scsi cdrom DVD RW DRU-190S SONY 0 0 I think (note I'm not sure), the capabilty type removable should be in

Re: [libvirt] [PATCH 3/3] Add myself to AUTHORS

2011-02-02 Thread Niels de Vos
On Wed, Feb 2, 2011 at 12:04 PM, Daniel P. Berrange wrote: > On Tue, Feb 01, 2011 at 04:22:03PM +, Niels de Vos wrote: >> Without this, ./autobuild.sh fails. >> >> Signed-off-by: Niels de Vos >> --- >>  AUTHORS |    1 + >>  1 files changed, 1 insertions(+), 0 deletions(-) >> >> diff --git a/A

[libvirt] Node devices capability xml

2011-02-02 Thread arnaud.champion
?Hi, I'm looking for informations about node devices capibility xml (not driver capabilities), and there's nothing on libvirt.org, can anyone can point me to find the infos ? regards, Arnaud-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] avoid shutting down the vm twice

2011-02-02 Thread Daniel P. Berrange
On Wed, Feb 02, 2011 at 02:18:47PM +0100, Jiri Denemark wrote: > > > diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c > > > index 6140f0f..c527bb7 100644 > > > --- a/src/qemu/qemu_driver.c > > > +++ b/src/qemu/qemu_driver.c > > > @@ -2972,7 +2972,11 @@ cleanup: > > > * pretend we

Re: [libvirt] [PATCH] avoid shutting down the vm twice

2011-02-02 Thread Jiri Denemark
> > diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c > > index 6140f0f..c527bb7 100644 > > --- a/src/qemu/qemu_driver.c > > +++ b/src/qemu/qemu_driver.c > > @@ -2972,7 +2972,11 @@ cleanup: > > * pretend we never started it */ > > virCommandFree(cmd); > > VIR_FORCE_CLOSE(

[libvirt] [PATCH] Add check for binary existing in machine type probe

2011-02-02 Thread Daniel P. Berrange
When probing machine types if the QEMU binary does not exist we get a hard to diagnose error, due to the execve() in the child failing error: internal error Child process exited with status 1. Add an explicit check so that we get error: Cannot find QEMU binary /usr/libexec/qem3u-kvm: No such fil

Re: [libvirt] nodedev-list and qemu

2011-02-02 Thread arnaud.champion
Oki, good news ;) Thanks Arnaud -- From: "Daniel P. Berrange" Sent: Wednesday, February 02, 2011 1:11 PM To: Cc: Subject: Re: [libvirt] nodedev-list and qemu On Wed, Feb 02, 2011 at 11:45:11AM +0100, arnaud.champ...@devatom.fr wrote: ?Hi, I

[libvirt] [PATCH] Imprint all logs with version + package build information

2011-02-02 Thread Daniel P. Berrange
The logging functions are enhanced so that immediately prior to the first log message being printed to any output channel, the libvirt package version will be printed. eg $ LIBVIRT_DEBUG=1 virsh 18:13:28.013: 17536: info : libvirt version: 0.8.7 18:13:28.013: 17536: debug : virInitialize:361 :

[libvirt] [PATCH] Add a little more debugging for async events

2011-02-02 Thread Daniel P. Berrange
To make it easier to investigate problems with async event delivery, add two more debugging lines * daemon/remote.c: Debug when an event is queued for dispatch * src/remote/remote_driver.c: Debug when an event is received for processing --- daemon/remote.c|2 ++ src/remote/remot

Re: [libvirt] nodedev-list and qemu

2011-02-02 Thread Daniel P. Berrange
On Wed, Feb 02, 2011 at 11:45:11AM +0100, arnaud.champ...@devatom.fr wrote: > ?Hi, > > I've just installed libvirt 0.8.7 on my fedora x86_64 14 > test host. It seems that the function virNodeNumOfDevices > is no more supported by the qemu driver. Is that true ? > or I'm wrong anywhere ? Sounds li

Re: [libvirt] [PATCHv4 4/5] smartcard: enable SELinux support

2011-02-02 Thread Daniel P. Berrange
On Tue, Feb 01, 2011 at 09:48:55AM -0700, Eric Blake wrote: > * src/security/security_selinux.c > (SELinuxRestoreSecuritySmartcardCallback) > (SELinuxSetSecuritySmartcardCallback): New helper functions. > (SELinuxRestoreSecurityAllLabel, SELinuxSetSecurityAllLabel): Use > them. > > --- > Notes: >

Re: [libvirt] [PATCHv4 3/5] smartcard: check for qemu capability

2011-02-02 Thread Daniel P. Berrange
On Tue, Feb 01, 2011 at 09:48:54AM -0700, Eric Blake wrote: > Qemu smartcard support exists on branches (such as > http://cgit.freedesktop.org/~alon/qemu/commit/?h=usb_ccid.v15&id=024a37b) > but is not yet upstream. Once an upstream version exists, then we > can add new -help and -device ? output

Re: [libvirt] [PATCHv4 5/5] smartcard: turn on qemu support

2011-02-02 Thread Daniel P. Berrange
On Tue, Feb 01, 2011 at 09:48:56AM -0700, Eric Blake wrote: > * src/qemu/qemu_command.c (qemuBuildCommandLine): Emit smartcard > options. > (qemuAssignDeviceAliases): Assign an alias for smartcards. > (qemuBuildControllerDevStr): Manage the usb-ccid controller. > * tests/qemuxml2argvtest.c (mymain)

Re: [libvirt] [PATCHv4 1/5] smartcard: add XML support for device

2011-02-02 Thread Daniel P. Berrange
On Tue, Feb 01, 2011 at 09:48:52AM -0700, Eric Blake wrote: > Assuming a hypervisor that supports multiple smartcard devices in the > guest, this would be a valid XML description: > > > > > /path/to/cert1 > /path/to/cert2 > /path/to/cert3 > > > > > > > > * d

Re: [libvirt] [PATCHv4 2/5] smartcard: add domain conf support

2011-02-02 Thread Daniel P. Berrange
On Tue, Feb 01, 2011 at 09:48:53AM -0700, Eric Blake wrote: > * src/conf/domain_conf.h (virDomainSmartcardType): New enum. > (virDomainSmartcardDef, virDomainDeviceCcidAddress): New structs. > (virDomainDef): Include smartcards. > (virDomainSmartcardDefIterator): New typedef. > (virDomainSmartcardD

Re: [libvirt] [PATCH 2/3] Set QEMUD_CMD_FLAG_PCI_MULTIBUS for x86_64 and i686 architectures

2011-02-02 Thread Daniel P. Berrange
On Tue, Feb 01, 2011 at 04:22:02PM +, Niels de Vos wrote: > Only x86_64 and i686 seem to have support for multiple PCI-busses. When > a guest of these architectures is started, set the > QEMUD_CMD_FLAG_PCI_MULTIBUS flag. > > Signed-off-by: Niels de Vos > --- > src/qemu/qemu_command.c |6

Re: [libvirt] [PATCH 3/3] Add myself to AUTHORS

2011-02-02 Thread Daniel P. Berrange
On Tue, Feb 01, 2011 at 04:22:03PM +, Niels de Vos wrote: > Without this, ./autobuild.sh fails. > > Signed-off-by: Niels de Vos > --- > AUTHORS |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/AUTHORS b/AUTHORS > index 131b30a..c69f0b5 100644 > --- a/AUTHORS > +

Re: [libvirt] [PATCH 1/3] qemuBuildDeviceAddressStr() checks for QEMUD_CMD_FLAG_PCI_MULTIBUS

2011-02-02 Thread Daniel P. Berrange
On Tue, Feb 01, 2011 at 04:22:01PM +, Niels de Vos wrote: > Depending if the qemu binary supports multiple pci-busses, the device > options will contain "bus=pci" or "bus=pci.0". > > Signed-off-by: Niels de Vos Is that your primary email addr you want recorded in the GIT history & AUTHORS fi

Re: [libvirt] [PATCH] docs: more on qemu locking patterns

2011-02-02 Thread Daniel P. Berrange
On Tue, Feb 01, 2011 at 05:37:10PM -0700, Eric Blake wrote: > * src/qemu/THREADS.txt: Improve documentation. > --- > > I'm trying to make sure we don't have any qemu locking gotchas, > given that I've had a bug report of a qemu monitor callback > being able to result in a domaing being unreference

[libvirt] nodedev-list and qemu

2011-02-02 Thread arnaud.champion
?Hi, I've just installed libvirt 0.8.7 on my fedora x86_64 14 test host. It seems that the function virNodeNumOfDevices is no more supported by the qemu driver. Is that true ? or I'm wrong anywhere ? Regards, Arnaud-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailm

Re: [libvirt] Connecting with a remote libvirt

2011-02-02 Thread Marcela Castro León
Thank you very much. It's working noow. Regard. Marcela 2011/2/1 Justin Clift > On 02/02/2011, at 12:59 AM, < > arnaud.champ...@devatom.fr> wrote: > > Hi, > > > > donc forget to start libvirtd with the "-l" (listen) argument. Generally, > it's in your /etc/init.d/libvirtd script. > > Hey Marcel