Re: [libvirt] [PATCH 2/2] qemu: use -incoming fd:n to avoid qemu holding fd indefinitely

2011-03-01 Thread Paolo Bonzini
On 03/02/2011 06:16 AM, Eric Blake wrote: On 01/03/2011 06:39 AM, Paolo Bonzini wrote: On 12/23/2010 05:51 PM, Eric Blake wrote: In the outgoing direction, we still have to use a unix socket (outgoing migration is started via a monitor command, and I don't know how to pass a new fd into qemu fo

Re: [libvirt] [PATCH 2/2] qemu: use -incoming fd:n to avoid qemu holding fd indefinitely

2011-03-01 Thread Eric Blake
On 01/03/2011 06:39 AM, Paolo Bonzini wrote: > On 12/23/2010 05:51 PM, Eric Blake wrote: >> In the outgoing direction, we still have to use a unix socket (outgoing >> migration is started via a monitor command, and I don't know how to pass >> a new fd into qemu for using with an fd:n outgoing migra

[libvirt] [PATCH] qemu: avoid double close on domain restore

2011-03-01 Thread Eric Blake
qemudDomainSaveImageStartVM was evil - it closed the incoming fd argument on some, but not all, code paths, without informing the caller about that action. No wonder that this resulted in double-closes: https://bugzilla.redhat.com/show_bug.cgi?id=672725 * src/qemu/qemu_driver.c (qemudDomainSaveIm

[libvirt] there is a mistake in "libvirt development guide, chapter 4.1: list domains"

2011-03-01 Thread SanitYey o
int i; int numDomains; char **inactiveDomains; numDomains = virConnectNumOfDefinedDomains(conn); inactiveDomains = malloc(sizeof(char *) * numDomains); numDomains = virConnectListDomains(conn, inactiveDomains, numDomains); printf("Inactive domain names:\n"); for (i = 0 ; i < numDomains ; i++) {

[libvirt] [PATCH] add additional event debug points

2011-03-01 Thread Eric Blake
From: Daniel P. Berrange Followup to commit bd24 --- I'm working on debugging a delayed event flush, and Daniel pointed me to this patch of his that I'm finding useful. Any objections to committing this upstream? src/remote/remote_driver.c |4 +++- 1 files changed, 3 insertions(+), 1

[libvirt] Network Filter not working on RHEL-6

2011-03-01 Thread Shi Jin
Hi there, I have been testing the Network Filter [1] feature of libvirt with KVM on RHEL-5.6 and RHEL-6. On RHEL-5.6, it works well except the $IP variable is not supported thus cannot use the clean-filter. The major problem I found on RHEL-6 is that the iptables rules introduced by nwfilter

[libvirt] [PATCH v4] Ignore backing file errors in FS storage pool

2011-03-01 Thread Philipp Hahn
Currently a single storage volume with a broken backing file will disable the whole storage pool. This can happen when the backing file is on some unavailable network storage or if the backing volume is deleted, while the storage volumes using it remain. Since the storage pool can not be re-activat

[libvirt] [PATCH 1/2] virsh: Change integer option parsing functions to return tri-state information.

2011-03-01 Thread Michal Privoznik
This is needed to detect situations when optional argument was specified with non-integer value: '--int-opt foo'. --- tools/virsh.c | 46 +++--- 1 files changed, 27 insertions(+), 19 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index 62fca17..

[libvirt] [PATCH 2/2] virsh: Change optional int arguments to check for non-integer values

2011-03-01 Thread Michal Privoznik
--- tools/virsh.c | 18 ++ 1 files changed, 14 insertions(+), 4 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index e5093a2..c9b4c57 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -2285,7 +2285,7 @@ cmdFreecell(vshControl *ctl, const vshCmd *cmd) { int func_re

[libvirt] [PATCH v3] domain.rng vs. formatdomain.html#elementsUSB

2011-03-01 Thread Philipp Hahn
The Relax-NG schema for domains regarding doesn't match what's implemented in src/conf/domain_conf.c#virDomainHostdevDefFormat(): The implementation only requires @type, but the schema currently either required none or all three attributes (@mode, @type, and @managed) to be defined together, becau

Re: [libvirt] [PATCH 1/3] Introduce flag representing if MAC address of interface was generated or not.

2011-03-01 Thread Michal Prívozník
On 02/25/2011 05:42 PM, Eric Blake wrote: On 02/24/2011 07:56 AM, Michal Privoznik wrote: --- src/conf/domain_conf.c |2 ++ src/conf/domain_conf.h |1 + 2 files changed, 3 insertions(+), 0 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index b97c1f0..454f6