Re: [libvirt] Network device abstraction aka virtual switch - V3

2011-07-02 Thread Laine Stump
On 06/16/2011 09:56 PM, Christian Benvenuti (benve) wrote: Laine Stump wrote: Interface Pools --- In many cases, a single host network may have multiple physical network devices associated with it (especially in the case of an SRIOV-capable ethernet card, which will have several "vi

[libvirt] offline migration / vm cloning with libvirt/virsh

2011-07-02 Thread Sethuraman Subbiah
Hi , I am trying to perform offline migration (i.e) Create an incremental image using the qcow format, transfer the vm memory state to a state fie.Use the image and statefile together as a template. Now create a new vm using the template. I can successfully do it using the following commands :

[libvirt] [PATCH] remote/ssh: support for no_verify.

2011-07-02 Thread Oskari Saarenmaa
Set StrictHostKeyChecking=no to auto-accept new ssh host keys if the no_verify extra parameter was specified. This won't disable host key checking for already known hosts. --- src/remote/remote_driver.c |1 + src/rpc/virnetclient.c |3 ++- src/rpc/virnetclient.h |1 + src/rpc/

Re: [libvirt] [PATCH] initialize pointer to NULL

2011-07-02 Thread Laine Stump
On 07/02/2011 08:55 AM, Wen Congyang wrote: > From 577ac7e8594cbcccb59653786e80c3916a3238cb Mon Sep 17 00:00:00 2001 From: Wen Congyang Date: Sat, 2 Jul 2011 06:41:18 +0800 Subject: [PATCH] initialize pointer to NULL def and cmd is not initialized to NULL, but we try to freed it if we meet some

Re: [libvirt] [PATCH 7/8] vmware: avoid null deref on failed lookup

2011-07-02 Thread Wen Congyang
At 2011-7-2 7:36, Eric Blake write: Detected by Coverity. * src/vmware/vmware_driver.c (vmwareDomainReboot): Check error before dereferencing memory. --- src/vmware/vmware_driver.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/vmware/vmware_driver.c b/src/vmwar

Re: [libvirt] [PATCH 3/8] rpc: silence coverity warning

2011-07-02 Thread Wen Congyang
At 2011-7-2 7:36, Eric Blake write: Coverity noted that 4 out of 5 calls to virNetClientStreamRaiseError checked the return value. This case expects a particular value, so warn if our expectations went wrong due to some bug elsewhere. * src/rpc/virnetclient.c (virNetClientCallDispatchStream): W

Re: [libvirt] [PATCH 5/8] rpc: fix logic bug

2011-07-02 Thread Wen Congyang
At 2011-7-2 7:36, Eric Blake write: Spotted by Coverity. If we don't update tmp each time through the loop, then if the filter being removed was not the head of the list, we accidentally lose all filters prior to the one we wanted to remove. * src/rpc/virnetserverclient.c (virNetServerClientRem

Re: [libvirt] [PATCH 4/8] cgroup: silence coverity warning

2011-07-02 Thread Wen Congyang
At 2011-7-2 7:36, Eric Blake write: Coverity noted that most clients reacted to failure to hash; but in a best-effort kill loop, we can ignore failure. * src/util/cgroup.c (virCgroupKillInternal): Ignore hash failure. --- src/util/cgroup.c |2 +- 1 files changed, 1 insertions(+), 1 deleti

Re: [libvirt] [PATCH 6/8] qemu: avoid null deref on low memory

2011-07-02 Thread Wen Congyang
At 2011-7-2 7:36, Eric Blake write: Detected by Coverity. qemuDomainEventQueue requires a non-NULL pointer; most callers silently drop the event if we encountered and OOM situation trying to create the event. * src/qemu/qemu_migration.c (qemuMigrationFinish): Check for OOM. --- src/qemu/qemu_

Re: [libvirt] [PATCH 2/8] qemu: silence coverity warnings

2011-07-02 Thread Wen Congyang
At 2011-7-2 7:36, Eric Blake write: Coverity warns if the majority of callers check a function for errors, but a few don't; but in qemu_audit and qemu_domain, the choice to not check for failures was safe. In qemu_command, the failure to generate a uuid can only occur on a bad pointer. * src/qe

[libvirt] [PATCH] initialize pointer to NULL

2011-07-02 Thread Wen Congyang
>From 577ac7e8594cbcccb59653786e80c3916a3238cb Mon Sep 17 00:00:00 2001 From: Wen Congyang Date: Sat, 2 Jul 2011 06:41:18 +0800 Subject: [PATCH] initialize pointer to NULL def and cmd is not initialized to NULL, but we try to freed it if we meet some error. It's very dangerous. --- src/qemu/qemu

Re: [libvirt] [PATCH] fix the failure of nodedev-reattach caused by the variables from nodedev-attach

2011-07-02 Thread Wen Congyang
At 2011-7-2 13:27, Guannan Ren write: On 07/01/2011 11:30 PM, ghostwcy wrote: At 2011-7-1 18:24, Guannan Ren write: the "virsh nodedev-reattch" command could return successfully, but the pci device is still bound to pci-stub driver. The reason is noddev-reattach trys to use the variables set by