Re: [libvirt] [PATCH V2] Do not drop kernel cmdline for xen pv domains

2011-07-07 Thread Matthias Bolte
2011/7/8 Jim Fehlig : > Kernel cmdline args can be passed to xen pv domains even when a > bootloader is specified.  The current config-to-sxpr mapping > ignores cmdline when bootloader is present. > > Since the xend sub-driver is used with many xen toolstack versions, > this patch takes conservativ

Re: [libvirt] [PATCH 1/1] microblaze: Add architecture support

2011-07-07 Thread John Williams
On Fri, Jul 8, 2011 at 9:50 AM, Eric Blake wrote: > On 07/06/2011 08:45 PM, John Williams wrote: > > Add libvirt support for MicroBlaze architecture as a QEMU target. Based > on mips/mipsel pattern. > > > > ACK and pushed. I added you to AUTHORS; let me know if I need to adjust > anything for p

[libvirt] [PROPOSED PATCH] Change the creation of the TAP interface for generic ethernet interfaces

2011-07-07 Thread Tyler Coumbes
Currently with libvirt and qemu/kvm to use the generic ethernet interface you have to use the workarounds listed in http://fedoraproject.org/wiki/How_to_debug_Virtualization_problems#Errors_using_.3Cinterface_type.3D.27ethernet.27.2F.3E . This is required since the current method relies on qemu to

Re: [libvirt] [PATCH 1/1] microblaze: Add architecture support

2011-07-07 Thread Eric Blake
On 07/06/2011 08:45 PM, John Williams wrote: > Add libvirt support for MicroBlaze architecture as a QEMU target. Based on > mips/mipsel pattern. > > Signed-off-by: John Williams > --- > docs/drvqemu.html.in |2 ++ > docs/schemas/capability.rng |

Re: [libvirt] [PATCH V2] Do not drop kernel cmdline for xen pv domains

2011-07-07 Thread Jim Fehlig
Jim Fehlig wrote: > Kernel cmdline args can be passed to xen pv domains even when a > bootloader is specified. The current config-to-sxpr mapping > ignores cmdline when bootloader is present. > > Since the xend sub-driver is used with many xen toolstack versions, > this patch takes conservative ap

[libvirt] [PATCH 19/19] qemu: Remove special case for virDomainAbortJob

2011-07-07 Thread Jiri Denemark
This doesn't abort migration job in any phase, yet. --- src/qemu/qemu_domain.c|9 +--- src/qemu/qemu_domain.h| 14 src/qemu/qemu_driver.c| 36 ++--- src/qemu/qemu_migration.c | 48 - src/

Re: [libvirt] [PATCH] Skip some xen tests if xend is not running

2011-07-07 Thread Jim Fehlig
Eric Blake wrote: > On 07/07/2011 04:00 PM, Jim Fehlig wrote: > >> Currently, the xen statstest and reconnect tests are only compiled >> if xend is running. Compile them unconditionally if xen headers >> are present, but skip the tests at runtime if xend is not running. >> >> This is in respons

[libvirt] [PATCH 18/19] qemu: Remove special case for virDomainSuspend

2011-07-07 Thread Jiri Denemark
--- src/qemu/qemu_domain.h|1 - src/qemu/qemu_driver.c| 46 ++-- src/qemu/qemu_migration.c |6 + 3 files changed, 24 insertions(+), 29 deletions(-) diff --git a/src/qemu/qemu_domain.h b/src/qemu/qemu_domain.h index 71cefd9..3da7931 100

[libvirt] [PATCH 15/19] qemu: Remove special case for virDomainBlockStats

2011-07-07 Thread Jiri Denemark
Like other query commands, this can now be called directly during migration. --- src/qemu/qemu_domain.h|4 --- src/qemu/qemu_driver.c| 54 +++-- src/qemu/qemu_migration.c | 18 --- 3 files changed, 18 insertions(+), 58 deletions(-

[libvirt] [PATCH 14/19] qemu: Remove special case for virDomainGetBlockInfo

2011-07-07 Thread Jiri Denemark
Like other query commands, this can now be called directly during migration. --- src/qemu/qemu_domain.h|4 src/qemu/qemu_driver.c| 42 -- src/qemu/qemu_migration.c | 14 -- 3 files changed, 12 insertions(+), 48 deletions(-)

[libvirt] [PATCH 16/19] qemu: Remove special case for virDomainMigrateSetMaxSpeed

2011-07-07 Thread Jiri Denemark
Call qemu monitor command directly within a special job that is only allowed during outgoing migration. --- src/qemu/qemu_domain.c|1 + src/qemu/qemu_domain.h|3 +-- src/qemu/qemu_driver.c| 23 +++ src/qemu/qemu_migration.c | 21 + sr

[libvirt] [PATCH 12/19] qemu: Recover from interrupted migration

2011-07-07 Thread Jiri Denemark
--- src/qemu/qemu_process.c | 110 ++- 1 files changed, 109 insertions(+), 1 deletions(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 49625b5..ddb29c1 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -38,6

[libvirt] [PATCH 11/19] qemu: Migration job on source daemon

2011-07-07 Thread Jiri Denemark
Make MIGRATION_OUT use the new helper methods. This also introduces new protection to migration v3 process: the migration job is held from Begin to Confirm to avoid changes to a domain during migration (esp. between Begin and Perform phases). This change, however brings a small issue when Prepare

[libvirt] [PATCH 08/19] qemu: Consolidate qemuMigrationPrepare{Direct, Tunnel}

2011-07-07 Thread Jiri Denemark
Most of the code in these two functions is supposed to be identical but currently it isn't (which is natural since the code is duplicated). Let's move common parts of these functions into qemuMigrationPrepareAny. --- src/qemu/qemu_migration.c | 255 +++- 1

[libvirt] [PATCH 09/19] qemu: Implement migration job phases

2011-07-07 Thread Jiri Denemark
This patch introduces several helper methods to deal with jobs and phases during migration in a simpler manner. --- src/qemu/MIGRATION.txt| 55 +++ src/qemu/qemu_domain.c|5 ++ src/qemu/qemu_migration.c | 91 + src

[libvirt] [PATCH 06/19] qemu: Recover from interrupted jobs

2011-07-07 Thread Jiri Denemark
Detect and react on situations when libvirtd was restarted or killed when a job was active. --- src/qemu/qemu_domain.c | 14 src/qemu/qemu_domain.h |2 + src/qemu/qemu_process.c | 80 +++ 3 files changed, 96 insertions(+), 0 deletions(

[libvirt] [PATCH 17/19] qemu: Remove special case for virDomainMigrateSetMaxDowntime

2011-07-07 Thread Jiri Denemark
Call qemu monitor command directly within a special job that is only allowed during outgoing migration. --- src/qemu/qemu_domain.c|1 - src/qemu/qemu_domain.h|6 -- src/qemu/qemu_driver.c| 23 +++ src/qemu/qemu_migration.c | 13 - 4 files

[libvirt] [PATCH 07/19] qemu: Add support for job phase

2011-07-07 Thread Jiri Denemark
Asynchronous jobs may take long time to finish and may consist of several phases which we need to now about to help with recovery/rollback after libvirtd restarts. --- src/qemu/qemu_domain.c | 75 +++- src/qemu/qemu_domain.h |9 ++ 2 files chan

[libvirt] [PATCH 05/19] qemu: Save job type in domain status XML

2011-07-07 Thread Jiri Denemark
If libvirtd is restarted when a job is running, the new libvirtd process needs to know about that to be able to recover and rollback the operation. --- src/qemu/qemu_domain.c| 124 +++- src/qemu/qemu_domain.h| 35 src/qemu/qemu_driver.c

[libvirt] [PATCH 13/19] qemu: Fix monitor unlocking in some error paths

2011-07-07 Thread Jiri Denemark
When monitor is entered with qemuDomainObjEnterMonitorWithDriver, the correct method for leaving and unlocking the monitor is qemuDomainObjExitMonitorWithDriver. --- src/qemu/qemu_hotplug.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/qemu/qemu_hotplug.c

[libvirt] [PATCH 01/19] qemu: Separate job related data into a new object

2011-07-07 Thread Jiri Denemark
--- src/qemu/qemu_domain.c| 104 + src/qemu/qemu_domain.h| 25 +++--- src/qemu/qemu_driver.c| 82 +++--- src/qemu/qemu_migration.c | 123 ++--- src/qemu/qemu_process.c |5

[libvirt] [PATCH 03/19] qemu: Consolidate {Enter, Exit}Monitor{, WithDriver}

2011-07-07 Thread Jiri Denemark
EnterMonitor and ExitMonitor methods are very similar to their *WithDriver variants; consolidate them into EnterMonitorInternal and ExitMonitorInternal to avoid (mainly future) code duplication. --- src/qemu/qemu_domain.c | 74 ++- 1 files changed, 35

[libvirt] [PATCH 10/19] qemu: Migration job on destination daemon

2011-07-07 Thread Jiri Denemark
Make MIGRATION_IN use the new helper methods. --- src/qemu/qemu_domain.c|2 +- src/qemu/qemu_domain.h|1 - src/qemu/qemu_migration.c | 80 +++- 3 files changed, 36 insertions(+), 47 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qe

[libvirt] [PATCH 02/19] qemu: Consolidate BeginJob{, WithDriver} into a single method

2011-07-07 Thread Jiri Denemark
This avoids code duplication and also avoids relying on good luck that ignore_value(virDomainObjUnref(obj)) doesn't set errno. --- src/qemu/qemu_domain.c | 93 ++-- 1 files changed, 43 insertions(+), 50 deletions(-) diff --git a/src/qemu/qemu_domain.c

[libvirt] [PATCH 00/19] Rollback migration when libvirtd restarts

2011-07-07 Thread Jiri Denemark
This series is also available at https://gitorious.org/~jirka/libvirt/jirka-staging/commits/migration-recovery The series does several things: - persists current job and its phase in status xml - allows safe monitor commands to be run during migration/save/dump jobs - implements recovery when libv

Re: [libvirt] [PATCH 05/10] conf: put virtPortProfile struct / functions in a common location

2011-07-07 Thread Eric Blake
On 07/05/2011 01:45 AM, Laine Stump wrote: > virtPortProfiles are currently only used in the domain XML, but will > soon also be used in the network XML. To prepare for that change, this > patch moves the structure definition into util/network.h and the parse > and format functions into util/networ

[libvirt] [PATCH V2] Do not drop kernel cmdline for xen pv domains

2011-07-07 Thread Jim Fehlig
Kernel cmdline args can be passed to xen pv domains even when a bootloader is specified. The current config-to-sxpr mapping ignores cmdline when bootloader is present. Since the xend sub-driver is used with many xen toolstack versions, this patch takes conservative approach of adding an else bloc

Re: [libvirt] [PATCH] Skip some xen tests if xend is not running

2011-07-07 Thread Eric Blake
On 07/07/2011 04:00 PM, Jim Fehlig wrote: > Currently, the xen statstest and reconnect tests are only compiled > if xend is running. Compile them unconditionally if xen headers > are present, but skip the tests at runtime if xend is not running. > > This is in response to Eric's suggestion here >

[libvirt] [PATCH] Skip some xen tests if xend is not running

2011-07-07 Thread Jim Fehlig
Currently, the xen statstest and reconnect tests are only compiled if xend is running. Compile them unconditionally if xen headers are present, but skip the tests at runtime if xend is not running. This is in response to Eric's suggestion here https://www.redhat.com/archives/libvir-list/2011-Jul

[libvirt] [PATCH] Fix build when using polkit0

2011-07-07 Thread Jim Fehlig
Here's a hacked attempt at fixing the build on older distros using polkit0. It works and user is authorized or denied depending on settings in PolicyKit.conf. I'm not too happy with it but haven't yet digested all the changes in rpc and daemon code. In the meantime, hopefully someone can suggest

Re: [libvirt] [PATCH 00/20] flags cleanup

2011-07-07 Thread Eric Blake
On 07/07/2011 12:30 PM, Eric Blake wrote: >> Yes, the ESX >> driver has no means to support a truly read-only connection as you >> always need to provide credentials, so one can consider this a bugfix >> or a regression depending on the point-of-view. > > I'm 50-50 on whether this really is a bug-

Re: [libvirt] [PATCH 03/20] drivers: prefer unsigned int for flags

2011-07-07 Thread Matthias Bolte
2011/7/7 Eric Blake : > On 07/06/2011 09:07 PM, Daniel Veillard wrote: >> On Wed, Jul 06, 2011 at 05:23:46PM -0600, Eric Blake wrote: >>> Now that the public APIs always use unsigned flags, the internal >>> driver callbacks might as well do likewise. >>> > >>>  struct remote_nwfilter_get_xml_desc_a

Re: [libvirt] [PATCH 03/20] drivers: prefer unsigned int for flags

2011-07-07 Thread Eric Blake
On 07/06/2011 09:07 PM, Daniel Veillard wrote: > On Wed, Jul 06, 2011 at 05:23:46PM -0600, Eric Blake wrote: >> Now that the public APIs always use unsigned flags, the internal >> driver callbacks might as well do likewise. >> >> struct remote_nwfilter_get_xml_desc_args { >> remote_nonnu

Re: [libvirt] [PATCH] virsh: make destroy sound less scary

2011-07-07 Thread Eric Blake
On 07/07/2011 03:23 AM, Daniel P. Berrange wrote: > On Wed, Jul 06, 2011 at 03:44:13PM -0600, Eric Blake wrote: >> Destroy has a rather negative English connotation. Try to reduce >> the impact, so newbies aren't as scared to use it. >> >> * tools/virsh.c: Tweak all destroy documentation. >> * too

Re: [libvirt] RFC: API additions for enhanced snapshot support

2011-07-07 Thread Eric Blake
On 07/07/2011 03:13 AM, Stefan Hajnoczi wrote: > On Wed, Jul 6, 2011 at 3:03 PM, Eric Blake wrote: >> In other words, it looks like we are stuck with updating XML to track >> new file names any time we take a snapshot. > > Yes, but QEMU's snapshot_blkdev command takes a filename argument so > at

Re: [libvirt] [PATCH] build: use gnulib pthread_sigmask

2011-07-07 Thread Eric Blake
On 07/07/2011 03:22 AM, Daniel P. Berrange wrote: > On Wed, Jul 06, 2011 at 11:24:12AM -0600, Eric Blake wrote: >> Gnulib finally learned how to do pthread_sigmask on mingw. >> >> We still have to worry about optional signals, like SIGWINCH, >> but overall, this makes for less conditional code. >>

Re: [libvirt] [PATCHv3] build: fix virBufferVasprintf on mingw

2011-07-07 Thread Matthias Bolte
2011/7/6 Eric Blake : > Gnulib documents that mingw vsnprintf is broken (it returns -1 > on out-of-space, instead of the count of what would have been > printed); but while we were using the snprintf wrapper, we had > not yet been using the vsnprintf wrapper. > > Meanwhile, mingw (but not mingw64)

Re: [libvirt] [PATCH 00/20] flags cleanup

2011-07-07 Thread Eric Blake
On 07/07/2011 12:09 AM, Matthias Bolte wrote: > 2011/7/7 Eric Blake : >> On 07/06/2011 05:23 PM, Eric Blake wrote: >>> Inspired in part by Laine's recent cleanup of qemuDomainGetXMLDesc, >>> in part by my desire to add a new flag to virDomainCoreDump and test >>> that older clients reject that flag

Re: [libvirt] [PATCH v4] graphics: add support for action_if_connected in qemu

2011-07-07 Thread Eric Blake
On 07/07/2011 02:59 AM, Michal Privoznik wrote: > On 06.07.2011 00:34, Eric Blake wrote: >> >> This patch changes the .xml, but not the corresponding .args file, which >> to me says it is probably incomplete. We covered the case of changing >> the attribute affecting qemu_hotplug: >> >> > No. This

Re: [libvirt] [PATCH] qemu: Don't chown files on NFS share if dynamic_ownership is off

2011-07-07 Thread Laine Stump
On 07/07/2011 12:00 PM, Michal Privoznik wrote: On 07.07.2011 17:52, Eric Blake wrote: On 07/07/2011 09:33 AM, Michal Privoznik wrote: When dynamic ownership is disabled we don't want to chown any files, not just local. Is there more details on a scenario where this was causing an issue? Eithe

Re: [libvirt] [PATCH] vbox: Fix logic in storage driver open function

2011-07-07 Thread Eric Blake
On 07/07/2011 01:24 AM, Matthias Bolte wrote: > If the main driver is the vbox driver, then the open function > has to return an error if the private data is invalid. > --- > src/vbox/vbox_tmpl.c |7 ++- > 1 files changed, 2 insertions(+), 5 deletions(-) ACK. -- Eric Blake ebl...@redh

Re: [libvirt] [PATCH] Fix compilation of statstest.c during make check

2011-07-07 Thread Eric Blake
On 07/07/2011 10:28 AM, Eric Blake wrote: >> +++ b/tests/statstest.c >> @@ -17,7 +17,7 @@ static void testQuietError(void *userData ATTRIBUTE_UNUSED, >> >> static int testDevice(const char *path, int expect) >> { >> -int actual = xenLinuxDomainDeviceID(NULL, 1, path); >> +int actual = x

Re: [libvirt] [PATCH] Fix compilation of statstest.c during make check

2011-07-07 Thread Jim Fehlig
Eric Blake wrote: > On 07/07/2011 10:16 AM, Jim Fehlig wrote: > >> --- >> tests/statstest.c |2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/tests/statstest.c b/tests/statstest.c >> index d18bb0c..c989992 100644 >> --- a/tests/statstest.c >> +++ b/tests/statstes

Re: [libvirt] [PATCH] Fix compilation of statstest.c during make check

2011-07-07 Thread Eric Blake
On 07/07/2011 10:16 AM, Jim Fehlig wrote: > --- > tests/statstest.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/tests/statstest.c b/tests/statstest.c > index d18bb0c..c989992 100644 > --- a/tests/statstest.c > +++ b/tests/statstest.c > @@ -17,7 +17,7 @@ static v

Re: [libvirt] [PATCH] Do not drop kernel cmdline for xen pv domains

2011-07-07 Thread Jim Fehlig
Daniel P. Berrange wrote: > On Wed, Jul 06, 2011 at 07:36:26PM -0600, Jim Fehlig wrote: > >> Kernel cmdline args can be passed to xen pv domains even when a >> bootloader is specified. The current config-to-sxpr mapping >> ignores cmdline when bootloader is present. >> >> Since the xend sub-dri

[libvirt] [PATCH] Fix compilation of statstest.c during make check

2011-07-07 Thread Jim Fehlig
--- tests/statstest.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tests/statstest.c b/tests/statstest.c index d18bb0c..c989992 100644 --- a/tests/statstest.c +++ b/tests/statstest.c @@ -17,7 +17,7 @@ static void testQuietError(void *userData ATTRIBUTE_UNUSED, stati

Re: [libvirt] [PATCH] qemu: Don't chown files on NFS share if dynamic_ownership is off

2011-07-07 Thread Michal Privoznik
On 07.07.2011 17:52, Eric Blake wrote: > On 07/07/2011 09:33 AM, Michal Privoznik wrote: >> When dynamic ownership is disabled we don't want to chown any files, >> not just local. > > Is there more details on a scenario where this was causing an issue? > Either a BZ number or a set of steps to rep

Re: [libvirt] [PATCH] Do not drop kernel cmdline for xen pv domains

2011-07-07 Thread Jim Fehlig
Paolo Bonzini wrote: > On 07/07/2011 11:31 AM, Daniel P. Berrange wrote: >> On Wed, Jul 06, 2011 at 07:36:26PM -0600, Jim Fehlig wrote: >>> Kernel cmdline args can be passed to xen pv domains even when a >>> bootloader is specified. The current config-to-sxpr mapping >>> ignores cmdline when bootl

Re: [libvirt] [PATCH] qemu: Don't chown files on NFS share if dynamic_ownership is off

2011-07-07 Thread Eric Blake
On 07/07/2011 09:33 AM, Michal Privoznik wrote: > When dynamic ownership is disabled we don't want to chown any files, > not just local. Is there more details on a scenario where this was causing an issue? Either a BZ number or a set of steps to reproduce the problem. > --- > src/qemu/qemu_drive

Re: [libvirt] [PATCH 14/14] Enable systemd socket activation with virtlockd

2011-07-07 Thread Paolo Bonzini
On 07/07/2011 04:17 PM, Daniel P. Berrange wrote: if [ $1 -eq 1 ] ; then # Initial installation +/bin/systemctl enable virtlockd.service>/dev/null 2>&1 || : /bin/systemctl enable libvirtd.service>/dev/null 2>&1 || : /bin/systemctl enable cgconfig.service>/dev/null 2>&1 ||

[libvirt] [PATCH] qemu: Don't chown files on NFS share if dynamic_ownership is off

2011-07-07 Thread Michal Privoznik
When dynamic ownership is disabled we don't want to chown any files, not just local. --- src/qemu/qemu_driver.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 52b7dfd..968865f 100644 --- a/src/qemu/qemu_driver.c ++

Re: [libvirt] [PATCH] Do not drop kernel cmdline for xen pv domains

2011-07-07 Thread Paolo Bonzini
On 07/07/2011 11:31 AM, Daniel P. Berrange wrote: On Wed, Jul 06, 2011 at 07:36:26PM -0600, Jim Fehlig wrote: Kernel cmdline args can be passed to xen pv domains even when a bootloader is specified. The current config-to-sxpr mapping ignores cmdline when bootloader is present. Since the xend s

Re: [libvirt] [PATCH] Skip bugs which are CLOSED in todo list

2011-07-07 Thread Eric Blake
On 07/07/2011 09:04 AM, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > * docs/todo.pl: Skip closed bugs > --- > docs/todo.pl |4 > 1 files changed, 4 insertions(+), 0 deletions(-) ACK. -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library htt

[libvirt] [PATCH] Skip bugs which are CLOSED in todo list

2011-07-07 Thread Daniel P. Berrange
From: "Daniel P. Berrange" * docs/todo.pl: Skip closed bugs --- docs/todo.pl |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/docs/todo.pl b/docs/todo.pl index e6da418..1183ff5 100755 --- a/docs/todo.pl +++ b/docs/todo.pl @@ -47,6 +47,8 @@ my $trackers = BZ::Client::Bu

Re: [libvirt] Fwd: Re: ports/devel/libvirt Makefile distinfo ports/devel/libvirt/files patch-docs__apibuild.py patch-libvirtd.h

2011-07-07 Thread Matthias Bolte
2011/7/7 Jason Helfman : > Hey Guys, > > Any ideas on this one? I have no way to test this, at the moment. > > Thanks, > Jason > > -- > Jason Helfman > System Administrator > experts-exchange.com > http://www.experts-exchange.com/M_4830110.html > E4AD 7CF1 1396 27F6 79DD  4342 5E92 AD66 8C8C FBA5 >

Re: [libvirt] [PATCH] Remove duplicate empty lines and correct indentation and style

2011-07-07 Thread Matthias Bolte
2011/7/7 Daniel P. Berrange : > On Thu, Jul 07, 2011 at 03:55:01AM -0400, Laine Stump wrote: >> On 07/07/2011 03:24 AM, Matthias Bolte wrote: >> >No functional change included. >> >--- >> >  python/libvirt-override.c                 |    1 - >> >  src/conf/domain_conf.c                    |    1 -

[libvirt] [PATCH 14/14] Enable systemd socket activation with virtlockd

2011-07-07 Thread Daniel P. Berrange
From: "Daniel P. Berrange" This enhancement virtlockd so that it can receive a pre-opened UNIX domain socket from systemd at launch time, and adds the systemd service/socket unit files * daemon/libvirtd.service.in: Require virtlockd to be running * libvirt.spec.in: Add virtlockd systemd files *

[libvirt] [PATCH 11/14] Add the virtlockd daemon for managing virtual guest locks

2011-07-07 Thread Daniel P. Berrange
From: "Daniel P. Berrange" This adds a new daemon 'virtlockd' which will manage the locks for all running virtual machines. Communication is via a new RPC lock program. The intent is that virtlockd runs forever and if it ever crashes, the entire host should be restarted (ideally via a hardware f

[libvirt] [PATCH 09/14] Add a simple internal API for managing lockspaces

2011-07-07 Thread Daniel P. Berrange
From: "Daniel P. Berrange" This adds a simple module for managing lockspaces. A lockspace has a path to a directory, which will usually be kep on shared storage like NFS/GFS, etc Inside the lockspace leases are created as plain files. Locks on leases are taken using the virFileLock APIs (fcntl b

[libvirt] [PATCH 06/14] Add support for systemd init service

2011-07-07 Thread Daniel P. Berrange
From: "Daniel P. Berrange" This patch adds support for a systemd init service for libvirtd and libvirt-guests. The libvirtd.service is *not* written to use socket activation, since we want libvirtd to start on boot so it can do guest auto-start. The libvirt-guests.service is pretty lame, just ex

[libvirt] [PATCH 12/14] Add a 'lockd' lock driver implementation

2011-07-07 Thread Daniel P. Berrange
From: "Daniel P. Berrange" This adds a 'lockd' lock driver which is just a client which talks to the lockd daemon to perform all locking. This will be the default lock driver for any hypervisor which needs one. * src/Makefile.am: Add lockd.so plugin * src/locking/lock_driver_lockd.c: Lockd drive

[libvirt] [PATCH 13/14] Change the default QEMU lock manager to 'lockd'

2011-07-07 Thread Daniel P. Berrange
From: "Daniel P. Berrange" The current default QEMU lock manager is the 'nop' lock manager, which obviously does not perform any locking. The new virtlockd daemon is able to work out of the box with zero configuration in single-host only mode. Enable this as the default lock manager for all QEMU

[libvirt] [PATCH 07/14] Change function signature for creating new lock manager instances

2011-07-07 Thread Daniel P. Berrange
From: "Daniel P. Berrange" To allow a virLockManagerPtr to be created directly from a driver table struct, replace the virLockManagerPluginPtr parameter with a virLockDriverPtr parameter. * src/locking/domain_lock.c, src/locking/lock_manager.c, src/locking/lock_manager.h: Replace plugin param

[libvirt] [PATCH 05/14] Rewrite pidfile handling to be crash safe

2011-07-07 Thread Daniel P. Berrange
From: "Daniel P. Berrange" If libvirtd crashes then the pidfile may not be cleaned up, making a later restart fail, even though the original process no longer exists. Instead of simply using file creation as the test for successful pidfile acquisition, actually take out a lock on the pidfile. T

[libvirt] [PATCH 10/14] Add a 'fcntl' lock driver which uses the simple lock database

2011-07-07 Thread Daniel P. Berrange
From: "Daniel P. Berrange" The 'fcntl' lock driver is a implementation of the lock manager driver API, which will be linked directly into the virtlockd process. It will use the simple lock database added in the previous commit to acquire/release locks for leases or disks associated with virtual m

[libvirt] [PATCH 02/14] Add virFileLock and virFileUnlock APIs

2011-07-07 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Add some simple wrappers around the fcntl() discretionary file locking capability. * src/util/util.c, src/util/util.h, src/libvirt_private.syms: Add virFileLock and virFileUnlock APIs --- src/libvirt_private.syms |2 ++ src/util/util.c | 33 ++

[libvirt] [PATCH 04/14] Ensure signal handler propagates fatal signals to default handler

2011-07-07 Thread Daniel P. Berrange
From: "Daniel P. Berrange" When replacing the default SEGV/ABORT/BUS signal handlers you can't rely on the process being terminated after your custom handler runs. It is neccessary to manually restore the default handler and then re-raise the signal * src/rpc/virnetserver.c: Restore default hand

[libvirt] [PATCH 01/14] Remove unused virNetServerProgramErrorHander typedef

2011-07-07 Thread Daniel P. Berrange
From: "Daniel P. Berrange" * src/rpc/virnetserverprogram.h: Remove unused typedef for virNetServerProgramErrorHander function callback * daemon/remote.h: Remove decl for non-existant variables --- daemon/remote.h |2 -- src/rpc/virnetserverprogram.h |3 --- 2 files change

[libvirt] [PATCH 00/14] Add a virtlockd lock manager daemon

2011-07-07 Thread Daniel P. Berrange
The lock manager infrastructure we recently added to QEMU only has two possible drivers at this time, 'nop' and 'sanlock'. The former does absolutely nothing, while the latter requires a 3rd party package installed and is a little heavy on disk I/O and storage requirements. This series adds a new

[libvirt] [PATCH 08/14] Define a wire protocol for talking to the virtlockd daemon

2011-07-07 Thread Daniel P. Berrange
From: "Daniel P. Berrange" The virtlockd daemon will be responsible for managing locks on virtual machines. Communication will be via the standard RPC infrastructure. This provides the XDR protocol definition * src/locking/lock_protocol.x: Wire protocol for virtlockd --- .gitignore

[libvirt] [PATCH 03/14] Add API for duplicating a socket/client file descriptor

2011-07-07 Thread Daniel P. Berrange
From: "Daniel P. Berrange" * src/rpc/virnetsocket.c, src/rpc/virnetsocket.h: Add virNetSocketDupFD() * src/rpc/virnetclient.c, src/rpc/virnetclient.h: Add virNetClientDupFD() and virNetClientGetFD() --- src/rpc/virnetclient.c | 20 src/rpc/virnetclient.h |3 +++ sr

[libvirt] 腾讯 could you give me any suggestions when running libvirtd in the container

2011-07-07 Thread 朱以军
Hi all: we manage the contaienr vms using libvirt, and we want to mornitor the vms by running the libvirtd in the container. but there is something wrong with it, a lock in the kernel is crashed. if you run the "sudo" or "ping" .etc, the system call can NOT be returned, the status of the comman

[libvirt] [PATCH 1/1] microblaze: Add architecture support

2011-07-07 Thread John Williams
Add libvirt support for MicroBlaze architecture as a QEMU target. Based on mips/mipsel pattern. Signed-off-by: John Williams --- docs/drvqemu.html.in |2 ++ docs/schemas/capability.rng |2 ++ examples/apparmor/libvirt-qemu |4 +

Re: [libvirt] [PATCH] python: Fix bogus label placement

2011-07-07 Thread Matthias Bolte
2011/7/7 Laine Stump : > On 07/07/2011 03:23 AM, Matthias Bolte wrote: >> >> --- >>  python/libvirt-override.c |    8 +++- >>  1 files changed, 3 insertions(+), 5 deletions(-) > > ACK. (couldn't resist, could you? :-P) No, and I also did a complete label name and indentation cleanup one the wh

Re: [libvirt] [RFC PATCH] doc: add sample XML for disk

2011-07-07 Thread Daniel P. Berrange
On Thu, Jul 07, 2011 at 01:06:01PM +0800, Wen Congyang wrote: > When I edit the xml config file, I need to know the format. > The easiest way to know the format is a sample XML. > But we do not have such sample now. > > TODO: > 1. dir and network disk's sample > 2. nic's sample > > If we need suc

Re: [libvirt] [PATCH] Do not drop kernel cmdline for xen pv domains

2011-07-07 Thread Daniel P. Berrange
On Wed, Jul 06, 2011 at 07:36:26PM -0600, Jim Fehlig wrote: > Kernel cmdline args can be passed to xen pv domains even when a > bootloader is specified. The current config-to-sxpr mapping > ignores cmdline when bootloader is present. > > Since the xend sub-driver is used with many xen toolstack v

Re: [libvirt] [PATCH 20/20] xenapi: reject unknown flags

2011-07-07 Thread Daniel P. Berrange
On Wed, Jul 06, 2011 at 05:24:03PM -0600, Eric Blake wrote: > * src/xenapi/xenapi_driver.c (xenapiOpen, xenapiDomainReboot) > (xenapiDomainGetXMLDesc): Reject unknown flags. > --- > src/xenapi/xenapi_driver.c | 13 ++--- > 1 files changed, 10 insertions(+), 3 deletions(-) > > diff --git

Re: [libvirt] [PATCH 19/20] xen: reject unknown flags

2011-07-07 Thread Daniel P. Berrange
On Wed, Jul 06, 2011 at 05:24:02PM -0600, Eric Blake wrote: > * src/xen/xen_driver.c (xenUnifiedDomainXMLFromNative) > (xenUnifiedDomainXMLToNative, xenUnifiedDomainBlockPeek): Reject > unknown flags. > * src/xen/xen_hypervisor.c (xenHypervisorOpen) > (xenHypervisorGetDomainState): Likewise. > * sr

Re: [libvirt] [PATCH 17/20] vbox: reject unknown flags

2011-07-07 Thread Daniel P. Berrange
On Wed, Jul 06, 2011 at 05:24:00PM -0600, Eric Blake wrote: > * src/vbox/vbox_driver.c (vboxOpenDummy): Reject unknown flags. > * src/vbox/vbox_tmpl.c (vboxOpen, vboxDomainReboot) > (vboxNetworkOpen, vboxNetworkGetXMLDesc, vboxStorageOpen) > (vboxStorageVolCreateXML, vboxStorageVolDelete) > (vboxSt

Re: [libvirt] [PATCH 15/20] test: reject unknown flags

2011-07-07 Thread Daniel P. Berrange
On Wed, Jul 06, 2011 at 05:23:58PM -0600, Eric Blake wrote: > * src/test/test_driver.c (testOpen, testDomainCoreDump) > (testOpenNetwork, testNetworkGetXMLDesc, testOpenInterface) > (testInterfaceChangeBegin, testInterfaceChangeCommit) > (testInterfaceChangeRollback, testInterfaceGetXMLDesc) > (tes

Re: [libvirt] [PATCH 18/20] vmware: reject unknown flags

2011-07-07 Thread Daniel P. Berrange
On Wed, Jul 06, 2011 at 05:24:01PM -0600, Eric Blake wrote: > * src/vmware/vmware_driver.c (vmwareOpen, vmwareDomainReboot) > (vmwareDomainCreateXML, vmwareDomainCreateWithFlags): Reject > unknown flags. > --- > src/vmware/vmware_driver.c | 17 - > 1 files changed, 12 insertions(

Re: [libvirt] [PATCH 16/20] uml: reject unknown flags

2011-07-07 Thread Daniel P. Berrange
On Wed, Jul 06, 2011 at 05:23:59PM -0600, Eric Blake wrote: > * src/uml/uml_driver.c (umlOpen, umlDomainGetXMLDesc) > (umlDomainBlockPeek): Reject unknown flags. > --- > src/uml/uml_driver.c | 14 +++--- > 1 files changed, 11 insertions(+), 3 deletions(-) > > diff --git a/src/uml/uml_dr

Re: [libvirt] [PATCH 14/20] qemu: reject unknown flags

2011-07-07 Thread Daniel P. Berrange
On Wed, Jul 06, 2011 at 05:23:57PM -0600, Eric Blake wrote: > * src/qemu/qemu_driver.c (qemudOpen, qemuDomainScreenshot) > (qemuDomainXMLFromNative, qemuDomainXMLToNative) > (qemudDomainBlockPeek, qemuCPUCompare, qemuCPUBaseline): Reject > unknown flags. > * src/qemu/qemu_migration.c (qemuMigration

Re: [libvirt] [PATCH 13/20] phyp: reject unknown flags

2011-07-07 Thread Daniel P. Berrange
On Wed, Jul 06, 2011 at 05:23:56PM -0600, Eric Blake wrote: > * src/phyp/phyp_driver.c (phypOpen, phypDomainReboot) > (phypVIOSDriverOpen): Reject unknown flags. > --- > src/phyp/phyp_driver.c | 12 +--- > 1 files changed, 9 insertions(+), 3 deletions(-) > > diff --git a/src/phyp/phyp_d

Re: [libvirt] [PATCH 11/20] lxc: reject unknown flags

2011-07-07 Thread Daniel P. Berrange
On Wed, Jul 06, 2011 at 05:23:54PM -0600, Eric Blake wrote: > * src/lxc/lxc_driver.c (lxcOpen, lxcDomainSetMemoryParameters) > (lxcDomainGetMemoryParameters): Reject unknown flags. > --- > src/lxc/lxc_driver.c | 12 +--- > 1 files changed, 9 insertions(+), 3 deletions(-) > > diff --git

Re: [libvirt] [PATCH 12/20] openvz: reject unknown flags

2011-07-07 Thread Daniel P. Berrange
On Wed, Jul 06, 2011 at 05:23:55PM -0600, Eric Blake wrote: > * src/openvz/openvz_driver.c (openvzDomainReboot, openvzOpen): > Reject unknown flags. > --- > src/openvz/openvz_driver.c |9 +++-- > 1 files changed, 7 insertions(+), 2 deletions(-) > > diff --git a/src/openvz/openvz_driver.c

Re: [libvirt] [PATCH 10/20] libxl: reject unknown flags

2011-07-07 Thread Daniel P. Berrange
On Wed, Jul 06, 2011 at 05:23:53PM -0600, Eric Blake wrote: > * src/libxl/libxl_driver.c (libxlOpen, libxlDomainReboot) > (libxlDomainXMLFromNative, libxlDomainXMLToNative) > (libxlDomainCreateWithFlags): Reject unknown flags. > --- > src/libxl/libxl_driver.c | 18 +- > 1 files c

Re: [libvirt] [PATCH 05/20] util: drop unused safezero argument

2011-07-07 Thread Daniel P. Berrange
On Thu, Jul 07, 2011 at 11:10:31AM +0800, Daniel Veillard wrote: > On Wed, Jul 06, 2011 at 05:23:48PM -0600, Eric Blake wrote: > > No caller was using the flags argument, and this function is internal > > only, so we might as well skip it. > > > > * src/util/util.h (safezero): Update signature. >

Re: [libvirt] [PATCH] virsh: make destroy sound less scary

2011-07-07 Thread Daniel P. Berrange
On Wed, Jul 06, 2011 at 03:44:13PM -0600, Eric Blake wrote: > Destroy has a rather negative English connotation. Try to reduce > the impact, so newbies aren't as scared to use it. > > * tools/virsh.c: Tweak all destroy documentation. > * tools/virsh.pod: Likewise. > --- > tools/virsh.c | 20

Re: [libvirt] [PATCH 01/20] maint: print flags in hex during debug

2011-07-07 Thread Daniel P. Berrange
On Wed, Jul 06, 2011 at 05:23:44PM -0600, Eric Blake wrote: > Debugging decimal flags is a pain. > > * src/libvirt.c: Always print flags in hex. > --- > src/libvirt.c | 216 > ++--- > 1 files changed, 114 insertions(+), 102 deletions(-) ACK

Re: [libvirt] [PATCH] build: use gnulib pthread_sigmask

2011-07-07 Thread Daniel P. Berrange
On Wed, Jul 06, 2011 at 11:24:12AM -0600, Eric Blake wrote: > Gnulib finally learned how to do pthread_sigmask on mingw. > > We still have to worry about optional signals, like SIGWINCH, > but overall, this makes for less conditional code. > > * .gnulib: Update to latest, for pthread_sigmask. > *

Re: [libvirt] [PATCH] docs: minor whitespace cleanups

2011-07-07 Thread Daniel P. Berrange
On Wed, Jul 06, 2011 at 01:51:13PM -0600, Eric Blake wrote: > No change in wording. One spacing change in a , noticed because > of odd XML formatting online; the rest is in free-flowing text to > make it easier to see nesting levels in the document. > > * docs/formatdomain.html.in: Adjust spacing

Re: [libvirt] Virsh Command Reference is out of date

2011-07-07 Thread Daniel P. Berrange
On Thu, Jul 07, 2011 at 03:39:24PM +0800, Gui Jianfeng wrote: > Hi, > > Virsh Command Reference on libvirt.org seems out of date, it's at libvirt > 0.8.7 > http://libvirt.org/sources/virshcmdref/html-single/ > Any one can help to update it to latest stable libvirt? The virsh command reference is

Re: [libvirt] [PATCH] Remove duplicate empty lines and correct indentation and style

2011-07-07 Thread Daniel P. Berrange
On Thu, Jul 07, 2011 at 03:55:01AM -0400, Laine Stump wrote: > On 07/07/2011 03:24 AM, Matthias Bolte wrote: > >No functional change included. > >--- > > python/libvirt-override.c |1 - > > src/conf/domain_conf.c|1 - > > src/conf/interface_conf.c

Re: [libvirt] RFC: API additions for enhanced snapshot support

2011-07-07 Thread Stefan Hajnoczi
On Wed, Jul 6, 2011 at 3:03 PM, Eric Blake wrote: > In other words, it looks like we are stuck with updating XML to track > new file names any time we take a snapshot. Yes, but QEMU's snapshot_blkdev command takes a filename argument so at least you get to specify that new filename. Stefan -- l

Re: [libvirt] php-virt-control

2011-07-07 Thread Michal Novotny
On 07/03/2011 05:28 PM, Andreas Cymbal wrote: > > Hello i have some problem with php-virt-control > > */Message:/**/ /*/Cannot connect to hypervisor. Please change > connection information. /(Local)// > > Virt-manager run without Problems > > Virsh run only with sudo virsh > > My System is Ubuntu 1

Re: [libvirt] [PATCH v4] graphics: add support for action_if_connected in qemu

2011-07-07 Thread Michal Privoznik
On 06.07.2011 00:34, Eric Blake wrote: > On 07/04/2011 02:48 AM, Michal Privoznik wrote: >> This option accepts 3 values: >> -keep, to keep current client connected (Spice+VNC) >> -disconnect, to disconnect client (Spice) >> -fail, to fail setting password if there is a client connected (Spice) >>

Re: [libvirt] [PATCH] Remove duplicate empty lines and correct indentation and style

2011-07-07 Thread Laine Stump
On 07/07/2011 03:24 AM, Matthias Bolte wrote: No functional change included. --- python/libvirt-override.c |1 - src/conf/domain_conf.c|1 - src/conf/interface_conf.c |1 - src/conf/network_conf.c |1 - sr

[libvirt] Virsh Command Reference is out of date

2011-07-07 Thread Gui Jianfeng
Hi, Virsh Command Reference on libvirt.org seems out of date, it's at libvirt 0.8.7 http://libvirt.org/sources/virshcmdref/html-single/ Any one can help to update it to latest stable libvirt? Thanks, Gui -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/l

Re: [libvirt] [PATCH] python: Fix bogus label placement

2011-07-07 Thread Laine Stump
On 07/07/2011 03:23 AM, Matthias Bolte wrote: --- python/libvirt-override.c |8 +++- 1 files changed, 3 insertions(+), 5 deletions(-) ACK. (couldn't resist, could you? :-P) -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

  1   2   >