>From e61aba3ed00b0d84233f75cc892ac13f06f9021e Mon Sep 17 00:00:00 2001
From: KAMEZAWA Hiroyuki
Date: Tue, 12 Jul 2011 14:22:45 +0900
Subject: [PATCH] Fix inject-nmi virsh man page
fix the placement.
---
tools/virsh.pod |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --g
Any ideas on this issue with virt-viewer?
Thanks!
-jgh
Original Message
Subject: bug virt-viewer was Re: [virt-tools-list] virt-viewer 0.2.0, as
listed on virt-manager download page
From:"Jason Helfman"
Date:Mon, July 11, 2011 12:2
On Mon, Jul 11, 2011 at 09:37:22PM -0400, Dave Allan wrote:
> On Mon, Jul 11, 2011 at 05:29:24PM -0600, Eric Blake wrote:
> > log2() is heavy when ffs() can do the same thing. But ffs()
> > requires gnulib support for mingw.
> >
> > * .gnulib: Update to latest, for ffs.
> > * bootstrap.conf (gnul
On Mon, Jul 11, 2011 at 05:29:24PM -0600, Eric Blake wrote:
> log2() is heavy when ffs() can do the same thing. But ffs()
> requires gnulib support for mingw.
>
> * .gnulib: Update to latest, for ffs.
> * bootstrap.conf (gnulib_modules): Import ffs.
> * src/conf/domain_conf.c (virDomainDefParseXM
On 07/11/2011 02:01 PM, Daniel P. Berrange wrote:
> On Fri, Jul 08, 2011 at 01:25:45PM -0600, Eric Blake wrote:
>> Since we are going to add some libvirt-qemu.so entry points in
>> 0.9.4, we might as well start checking for RPC stability, just
>> as for libvirt.so.
>>
>> * src/Makefile.am (PROTOCOL
* src/util/virtaudit.[ch]: Rename...
* src/util/viraudit.[ch]: ...to match virAudit* API.
* src/Makefile.am (UTIL_SOURCES): Reflect rename.
* daemon/libvirtd.c: Likewise.
* po/POTFILES.in: Likewise.
* src/libvirt_private.syms: Likewise.
* src/qemu/qemu_audit.c: Likewise.
---
First suggested here:
* src/qemu/qemu_driver.c (doCoreDump): Guarantee fd is closed.
---
Spotted by hand, while working on virDomainSaveFlags.
src/qemu/qemu_driver.c | 10 ++
1 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 1356c54..f9d2de4
On 07/11/2011 03:32 PM, Eric Blake wrote:
+#include
>>>
>>> What was this needed for?
>>
>> For log2 to convert 1 << x back to x in case only one bit is set in
>> expectedVirtTypes.
>
> log2(), including -lm, is rather heavyweight. It should be possible to
> use ffs() from to do the same t
log2() is heavy when ffs() can do the same thing. But ffs()
requires gnulib support for mingw.
* .gnulib: Update to latest, for ffs.
* bootstrap.conf (gnulib_modules): Import ffs.
* src/conf/domain_conf.c (virDomainDefParseXML): Use ffs instead
of log2.
Reported by Dave Allan.
---
Pushing under
Daniel P. Berrange wrote:
> I'd like the virNetServer stuff to not have any mention of policy
> kit in it. So rather than saying 'bool usePolkit', have a
> 'bool connectDBus', and just remove those HAVE_POLKIT0 conditionals
> so that the DBus API is always available in virNetServer. The changes
> y
I'm seeing:
/usr/bin/ld: libvirt_lxc-domain_conf.o: undefined reference
to symbol 'log2@@GLIBC_2.2.5'
when building the git HEAD just now.
It appears to be the result of:
aa14709a src/conf/domain_conf.c (Matthias Bolte 2011-07-11
19:29:09 +0200 5868)
virDomainVirtTypeToString(log2(expected
On 07/11/2011 11:58 AM, Matthias Bolte wrote:
> 2011/7/11 Eric Blake :
>> On 07/11/2011 10:16 AM, Matthias Bolte wrote:
> My only regret here is that we can't really suggest the value expected
> because QEmu accepts more than one, but for other drivers we should be
> able to provide wha
Eric Blake wrote:
> On 07/11/2011 02:40 PM, Jim Fehlig wrote:
>
>> ---
>> daemon/libvirtd.h | 30 --
>> 1 files changed, 0 insertions(+), 30 deletions(-)
>>
>
> ACK.
>
>
Thanks, pushed.
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.
On 07/11/2011 02:40 PM, Jim Fehlig wrote:
> ---
> daemon/libvirtd.h | 30 --
> 1 files changed, 0 insertions(+), 30 deletions(-)
ACK.
--
Eric Blake ebl...@redhat.com+1-801-349-2682
Libvirt virtualization library http://libvirt.org
signature.asc
Description
---
daemon/libvirtd.h | 30 --
1 files changed, 0 insertions(+), 30 deletions(-)
diff --git a/daemon/libvirtd.h b/daemon/libvirtd.h
index 8e1843c..6c9b9c3 100644
--- a/daemon/libvirtd.h
+++ b/daemon/libvirtd.h
@@ -27,10 +27,6 @@
# include
-# if HAVE_POLKIT0
-#
On Fri, Jul 08, 2011 at 01:34:05AM +0200, Jiri Denemark wrote:
> This series is also available at
> https://gitorious.org/~jirka/libvirt/jirka-staging/commits/migration-recovery
>
> The series does several things:
> - persists current job and its phase in status xml
> - allows safe monitor command
On Fri, Jul 08, 2011 at 01:34:13AM +0200, Jiri Denemark wrote:
> Most of the code in these two functions is supposed to be identical but
> currently it isn't (which is natural since the code is duplicated).
> Let's move common parts of these functions into qemuMigrationPrepareAny.
Were there any a
Jim Fehlig wrote:
> Here's a hacked attempt at fixing the build on older distros using
> polkit0. It works and user is authorized or denied depending on
> settings in PolicyKit.conf.
>
[...]
> diff --git a/daemon/libvirtd.h b/daemon/libvirtd.h
> index 8e1843c..18a10ef 100644
> --- a/daemon/lib
On Fri, Jul 08, 2011 at 01:34:06AM +0200, Jiri Denemark wrote:
> ---
> src/qemu/qemu_domain.c| 104 +
> src/qemu/qemu_domain.h| 25 +++---
> src/qemu/qemu_driver.c| 82 +++---
> src/qemu/qemu_migration.c | 123
> +++
On Fri, Jul 08, 2011 at 01:34:11AM +0200, Jiri Denemark wrote:
> Detect and react on situations when libvirtd was restarted or killed
> when a job was active.
> ---
> src/qemu/qemu_domain.c | 14
> src/qemu/qemu_domain.h |2 +
> src/qemu/qemu_process.c | 80
> ++
On Fri, Jul 08, 2011 at 01:34:12AM +0200, Jiri Denemark wrote:
> Asynchronous jobs may take long time to finish and may consist of
> several phases which we need to now about to help with recovery/rollback
> after libvirtd restarts.
> ---
> src/qemu/qemu_domain.c | 75
>
On Fri, Jul 08, 2011 at 01:34:10AM +0200, Jiri Denemark wrote:
> If libvirtd is restarted when a job is running, the new libvirtd process
> needs to know about that to be able to recover and rollback the
> operation.
> ---
> src/qemu/qemu_domain.c| 124 +++-
On Fri, Jul 08, 2011 at 01:34:09AM +0200, Jiri Denemark wrote:
> Query commands are safe to be called during long running jobs (such as
> migration). This patch makes them all work without the need to
> special-case every single one of them.
>
> The patch introduces new job.asyncCond condition and
On Fri, Jul 08, 2011 at 01:34:08AM +0200, Jiri Denemark wrote:
> EnterMonitor and ExitMonitor methods are very similar to their
> *WithDriver variants; consolidate them into EnterMonitorInternal and
> ExitMonitorInternal to avoid (mainly future) code duplication.
> ---
> src/qemu/qemu_domain.c |
On Mon, Jul 04, 2011 at 12:33:31PM +0100, Daniel P. Berrange wrote:
> This series adds auditing to the LXC and UML drivers. As a side
> effect it also fixes missing auditing of filesystem passthrough
> in the QEMU driver and a bug in UML vm cleanup
Anyone got comments on this (very easy to review
On Fri, Jul 08, 2011 at 01:25:45PM -0600, Eric Blake wrote:
> Since we are going to add some libvirt-qemu.so entry points in
> 0.9.4, we might as well start checking for RPC stability, just
> as for libvirt.so.
>
> * src/Makefile.am (PROTOCOL_STRUCTS): New variable.
> (remote_protocol-structs): Re
On Mon, Jul 11, 2011 at 10:50:31PM +0300, Oskari Saarenmaa wrote:
> Set StrictHostKeyChecking=no to auto-accept new ssh host keys if the
> no_verify extra parameter was specified. This won't disable host key
> checking for already known hosts. Includes a test and documentation.
> ---
> Thanks fo
On Fri, Jul 08, 2011 at 02:52:36PM -0600, Eric Blake wrote:
> On 07/04/2011 04:28 AM, Daniel P. Berrange wrote:
> > Introduce a new API in libvirt-qemu.so
> >
> > virDomainPtr virDomainQemuAttach(virConnectPtr domain,
> > unsigned long long pid,
>
> We already a
Set StrictHostKeyChecking=no to auto-accept new ssh host keys if the
no_verify extra parameter was specified. This won't disable host key
checking for already known hosts. Includes a test and documentation.
---
Thanks for the review, here's an updated patch.
docs/remote.html.in|9 +
I am happy to announce a new release[1] of the libvirt Perl bindings,
Sys::Virt 0.9.2 is available for download:
http://search.cpan.org/CPAN/authors/id/D/DA/DANBERR/Sys-Virt-0.9.2.tar.gz
Changes in this release
- Changed version numbering to track the corresponding
minimum required libvirt
* Dave Allan [2011-07-08 17:22:53]:
> On Mon, Jul 04, 2011 at 10:05:21PM +0530, Vaidyanathan Srinivasan wrote:
> > * Dave Allan [2011-07-01 16:56:29]:
> >
> >
> > > > libvirt has virConnectGetCapabilities() that would export an XML file
> > > > describing the capabilities of the host platform
* Dave Allan [2011-07-08 17:23:31]:
> On Mon, Jul 04, 2011 at 10:00:20PM +0530, Vaidyanathan Srinivasan wrote:
> > * Dave Allan [2011-07-01 17:19:06]:
> >
> > > On Fri, Jul 01, 2011 at 04:56:29PM -0400, Dave Allan wrote:
> > > > On Tue, Jun 28, 2011 at 08:55:31PM +0530, Vaidyanathan Srinivasan
2011/7/11 Eric Blake :
> On 07/11/2011 10:16 AM, Matthias Bolte wrote:
>>> > My only regret here is that we can't really suggest the value expected
>>> > because QEmu accepts more than one, but for other drivers we should be
>>> > able to provide what type is expected.
>> Yes, we can do that even f
On Mon, Jul 11, 2011 at 07:02:35PM +0200, Michal Privoznik wrote:
> virCopyLastError simply overwrites destination, which may lead to leak
> if there already was error. Therefore we need first to free destination.
> ---
> src/qemu/qemu_migration.c |1 +
> src/qemu/qemu_monitor.c |1 +
>
Caller must free returned value of virXPathString
---
src/conf/domain_conf.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 2315c98..05c9d3e 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -5732,6 +
virCopyLastError simply overwrites destination, which may lead to leak
if there already was error. Therefore we need first to free destination.
---
src/qemu/qemu_migration.c |1 +
src/qemu/qemu_monitor.c |1 +
2 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/src/qemu/qemu_m
On 07/11/2011 10:16 AM, Matthias Bolte wrote:
>> > My only regret here is that we can't really suggest the value expected
>> > because QEmu accepts more than one, but for other drivers we should be
>> > able to provide what type is expected.
> Yes, we can do that even for QEMU. See attached diff be
2011/7/11 Daniel Veillard :
> On Sat, Jul 09, 2011 at 03:38:32PM +0200, Matthias Bolte wrote:
>> 2011/7/8 Eric Blake :
>> > On 07/08/2011 02:13 AM, Matthias Bolte wrote:
>> >> The drivers were accepting domain configs without checking if those
>> >> were actually meant for them. For example the LXC
On 07/08/2011 04:18 PM, Eric Blake wrote:
On 07/05/2011 01:45 AM, Laine Stump wrote:
The qemu driver accesses fields in the virDomainNetDef directly, but
with the advent of the virDomainActualNetDef, some pieces of
information may be found in a different place (the ActualNetDef) if
the network c
On 07/10/2011 11:14 PM, a...@redhat.com wrote:
> From: Alex Jia
>
> Detected in valgrind run:
>
> ==9184== 1 bytes in 1 blocks are definitely lost in loss record 1 of 19
> ==9184==at 0x4A04A28: calloc (vg_replace_malloc.c:467)
> ==9184==by 0x3073715F78: xdr_array (xdr_array.c:97)
> ==918
On 07/09/2011 09:52 AM, Matthias Bolte wrote:
> Anyway, you decided to add an snapshot_mode attribute to the disk
> element and exposed the VMX values there. I'm not sure that this is a
> good idea as scsi0:0.mode affects two aspects.
>
> scsi0:0.mode can basically have three different modes
>
>
On Mon, Jul 11, 2011 at 06:11:47PM +0800, Guannan Ren wrote:
> On 07/11/2011 04:49 PM, Jiri Denemark wrote:
> >On Sun, Jul 10, 2011 at 22:29:03 +0800, Guannan Ren wrote:
> >>The three patches add support to delete volumes while it is building intead
> >>of raising
> >>an warning infomation,then ab
On 07/09/2011 09:42 AM, Matthias Bolte wrote:
> True, the current expression doesn't work for counter = 40. You're
> expression fixed this, but no reason for special casing 0 here, as
> modulo on negative values is perfectly fine and yields the right
> result here
>
> expr 39 - \( \( 0 - 1 \) %
Jim Fehlig wrote:
> Eric Blake wrote:
>
[...]
>> Oh, and our testsuite has a cosmetic bug. After applying your patch, I
>> see this during 'make check':
>>
>> TEST: xencapstest
>> .. 10 OK
>> PASS: xencapstest
>> SKIP: reconnect
>> TEST: statstest
>>
Eric Blake wrote:
> On 07/07/2011 05:37 PM, Jim Fehlig wrote:
>
>> Jim Fehlig wrote:
>>
>>> Kernel cmdline args can be passed to xen pv domains even when a
>>> bootloader is specified. The current config-to-sxpr mapping
>>> ignores cmdline when bootloader is present.
>>>
>>> Since the xend
On 07/11/2011 06:50 AM, Daniel P. Berrange wrote:
>>
>> -if (virAsprintf(&ret, "%s/%s.save", driver->saveDir, vm->def->name) <
>> 0) {
>> +if (virAsprintf(&ret, "%s/%s.save", driver->saveDir, uuidstr) < 0) {
>> virReportOOMError();
>> return(NULL);
>> }
>
> NACK,
At 2011年07月11日 17:25, Daniel P. Berrange write:
On Mon, Jul 11, 2011 at 09:25:40AM +0800, Wen Congyang wrote:
At 07/01/2011 06:05 PM, Wen Congyang Write:
If virDomainSaveConfig() failed, we will return NULL to source,
and the vm is still available to restart during confirm() step in
v3 protocol
At 2011年07月11日 16:36, Daniel Veillard write:
On Mon, Jul 11, 2011 at 04:26:16PM +0800, Wen Congyang wrote:
---
docs/news.html.in |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/docs/news.html.in b/docs/news.html.in
index 6c94afc..625e3b9 100644
--- a/docs/news.html.i
At 2011年07月11日 17:25, Daniel P. Berrange write:
On Mon, Jul 11, 2011 at 04:26:34PM +0800, Wen Congyang wrote:
---
src/rpc/virnetsocket.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/rpc/virnetsocket.c b/src/rpc/virnetsocket.c
index 4b0c2ee..3392047 100644
--
On Mon, Jul 11, 2011 at 09:06:05PM +0800, Osier Yang wrote:
> A domain managed state file named with domain name can cause
> problem if the domain is undefined, and a later new domain is
> created with the same name. The new domain will not be able to
> start.
> ---
> src/libxl/libxl_driver.c |
A domain managed state file named with domain name can cause
problem if the domain is undefined, and a later new domain is
created with the same name. The new domain will not be able to
start.
---
src/libxl/libxl_driver.c |4 +++-
src/qemu/qemu_driver.c |4 +++-
2 files changed, 6 insert
A domain managed state file named with domain name can cause
problem if the domain is undefined, and a later new domain is
created with the same name. The new domain will not be able to
start.
---
src/libxl/libxl_driver.c |4 +++-
src/qemu/qemu_driver.c |4 +++-
2 files changed, 6 insert
On 01.07.2011 09:20, Michal Privoznik wrote:
On 27.06.2011 19:37, Christian Benvenuti (benve) wrote:
-Original Message-
From: Michal Privoznik [mailto:mpriv...@redhat.com]
Sent: Monday, June 27, 2011 8:34 AM
To: Christian Benvenuti (benve)
Cc: Laine Stump; libvir-list@redhat.com
Subject:
On 07/11/2011 04:49 PM, Jiri Denemark wrote:
On Sun, Jul 10, 2011 at 22:29:03 +0800, Guannan Ren wrote:
The three patches add support to delete volumes while it is building intead of
raising
an warning infomation,then abort.
For the volume of raw file, delete it directly without any effect on t
On 08.07.2011 22:46, Eric Blake wrote:
On 07/08/2011 07:48 AM, Michal Privoznik wrote:
This patch creates new element which, at this time has the only
s/the only/only the/
attribute useserial='yes|no'. This attribute allow users to use
Serial Graphics Adapter and see BIOS messages from the
On Fri, Jul 08, 2011 at 09:19:46AM -0500, Adam Litke wrote:
> Hi all,
>
> In order to nicely support domains that use qemu's SDL support,
> libvirt-cim is looking for a way to confirm if the underlying qemu
> emulator can support SDL. Libvirt already knows this information
> internally. It seems
On Fri, Jul 08, 2011 at 04:33:28PM -0600, Eric Blake wrote:
> On 07/07/2011 08:17 AM, Daniel P. Berrange wrote:
> > From: "Daniel P. Berrange"
> >
> > If libvirtd crashes then the pidfile may not be cleaned up,
> > making a later restart fail, even though the original process
> > no longer exists
On Mon, Jul 11, 2011 at 04:26:34PM +0800, Wen Congyang wrote:
> ---
> src/rpc/virnetsocket.c |4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/rpc/virnetsocket.c b/src/rpc/virnetsocket.c
> index 4b0c2ee..3392047 100644
> --- a/src/rpc/virnetsocket.c
> +++ b/src/
On Mon, Jul 11, 2011 at 09:25:40AM +0800, Wen Congyang wrote:
> At 07/01/2011 06:05 PM, Wen Congyang Write:
> > If virDomainSaveConfig() failed, we will return NULL to source,
> > and the vm is still available to restart during confirm() step in
> > v3 protocol. So we should kill it off in qemuMigr
Steps to produce this bug:
1. # virsh migrate vm1 --p2p qemu+tls:///system
error: End of file while reading data: Input/output error
Now the libvirtd crashed.
This bug only happened twice.
I use gdb to analyze the core file:
(gdb) info threads
6 Thread 3952 0x00351fe0b43c in pthread_c
On Sun, Jul 10, 2011 at 22:29:03 +0800, Guannan Ren wrote:
> The three patches add support to delete volumes while it is building intead
> of raising
> an warning infomation,then abort.
> For the volume of raw file, delete it directly without any effect on the
> thread of creating
> it.
> For the
On Mon, Jul 11, 2011 at 04:26:16PM +0800, Wen Congyang wrote:
> ---
> docs/news.html.in |2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/docs/news.html.in b/docs/news.html.in
> index 6c94afc..625e3b9 100644
> --- a/docs/news.html.in
> +++ b/docs/news.html.in
> @@ -15
---
docs/news.html.in |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/docs/news.html.in b/docs/news.html.in
index 6c94afc..625e3b9 100644
--- a/docs/news.html.in
+++ b/docs/news.html.in
@@ -151,7 +151,7 @@ and check the http://libvirt.org/git/?p=libvirt.git;a=log";>GIT lo
---
src/rpc/virnetsocket.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/rpc/virnetsocket.c b/src/rpc/virnetsocket.c
index 4b0c2ee..3392047 100644
--- a/src/rpc/virnetsocket.c
+++ b/src/rpc/virnetsocket.c
@@ -1042,8 +1042,8 @@ int virNetSocketAccept(virNetSocketPt
On Sat, Jul 09, 2011 at 03:38:32PM +0200, Matthias Bolte wrote:
> 2011/7/8 Eric Blake :
> > On 07/08/2011 02:13 AM, Matthias Bolte wrote:
> >> The drivers were accepting domain configs without checking if those
> >> were actually meant for them. For example the LXC driver happily
> >> accepts confi
65 matches
Mail list logo
