Re: [libvirt] libvirt support on QNX

2011-12-13 Thread Chandrashekhar Jamadarkhani (cjamadar)
In which dir the source code for libvirt RPC client driver located to port it to QNX ? Is it in libvirt-0.9.8/src/remote ? Thanks, Chandrashekhar Hi Daniel, Thanks Daniel for the info. I was talking only about porting libvirt RPC client driver to QNX for starting/monitoring VMs running on r

Re: [libvirt] [test-API][PATCH 1/2] Add test case get_cpu_shares.py for cpu scheduler info testing

2011-12-13 Thread Wayne Sun
On 12/13/2011 11:45 AM, Nan Zhang wrote: * repos/domain/get_cpu_shares.py: get the value of cpu_shares property of the guest. --- lib/domainAPI.py |2 +- repos/domain/get_cpu_shares.py | 117 2 files changed, 118 insertions(+), 1

Re: [libvirt] macvtap not working on kvm

2011-12-13 Thread Amit Tewari
Hi all, In same previous scenario of macvtap ,Im not able to assign dhcp address to guest interface, and if I assign static ip of my lan to guest interface , than also it is not able to connect to the network.. From: libvir-list-boun...@redhat.com [mailto:libv

Re: [libvirt] [test-API][PATCH 2/2] Add test case set_cpu_shares.py for setting cpu scheduler info

2011-12-13 Thread Wayne Sun
On 12/13/2011 11:45 AM, Nan Zhang wrote: * repos/domain/set_cpu_shares.py: set the value of cpu_shares property of the guest. --- repos/domain/set_cpu_shares.py | 121 1 files changed, 121 insertions(+), 0 deletions(-) create mode 100644 repos/dom

Re: [libvirt] [PATCH] python: Expose memoryPeek to Python binding

2011-12-13 Thread Osier Yang
On 2011年12月14日 02:38, Eric Blake wrote: On 12/13/2011 06:43 AM, Osier Yang wrote: --- python/libvirt-override-api.xml |8 python/libvirt-override.c | 33 + 2 files changed, 41 insertions(+), 0 deletions(-) +if ((buf = malloc(size))

Re: [libvirt] [PATCH 0/8] Refactor event state handling to fix crash

2011-12-13 Thread Alex Jia
On 12/14/2011 11:05 AM, Alex Jia wrote: Hi Daniel, I also met similar issue when I ran libvirt unit test yesterday, In addition, the case 'read-bufsiz' will be hung forever unless s/read-bufsiz/read-non-seekable/ typing ctrl+c to sends a SIGINT signal to the process. PASS: read-bufsiz FAIL: r

[libvirt] [PATCH 2/2] virsh: allow to specify pci address with attach-interface

2011-12-13 Thread KAMEZAWA Hiroyuki
From: KAMEZAWA Hiroyuki This patch adds 2 options to attach-interface as --address and --multifunction. I used --address rather than --pci_address becasue attach-disk has --address for the same purpose, already. --- tools/virsh.c | 38 -- tools/virsh.pod |

[libvirt] [PATCH 1/2] virsh: move At(De)tachInterface defintions below At(De)tachDisks

2011-12-13 Thread KAMEZAWA Hiroyuki
From: KAMEZAWA Hiroyuki This is for reusing PCIAddress parser etc..in AttachInterface. This patch just moves defs. No functional/logical changes at all. --- tools/virsh.c | 916 1 files changed, 458 insertions(+), 458 deletions(-) diff -

[libvirt] [PATCH 0/2] virsh: allow to specify pci address with attach-interface

2011-12-13 Thread KAMEZAWA Hiroyuki
Now, at using attach-interface, pci address of the device is determined automatically. This is nice. But in some situation, users may want to specify pci address by hand. For example, when users want to use multifunction pci device, he need to specify pci slot. This patch allows to specify pci ad

Re: [libvirt] [PATCH 0/8] Refactor event state handling to fix crash

2011-12-13 Thread Alex Jia
Hi Daniel, I also met similar issue when I ran libvirt unit test yesterday, In addition, the case 'read-bufsiz' will be hung forever unless typing ctrl+c to sends a SIGINT signal to the process. PASS: read-bufsiz FAIL: read-non-seekable PASS: start ./undefine: line 49: 26790 Segmentation fault

Re: [libvirt] [PATCH 3/3] spec: fix sanlock dependency

2011-12-13 Thread Wen Congyang
At 12/06/2011 01:38 AM, Eric Blake Write: > * libvirt.spec.in (with_sanlock): On RHEL, don't force sanlock > on architectures where it isn't available. > --- > libvirt.spec.in | 10 -- > 1 files changed, 8 insertions(+), 2 deletions(-) > > diff --git a/libvirt.spec.in b/libvirt.spec.in

[libvirt] [PATCH 7/8] Hide use of timers for domain event dispatch

2011-12-13 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Currently all drivers using domain events need to provide a callback for handling a timer to dispatch events in a clean stack. There is no technical reason for dispatch to go via driver specific code. It could trivially be dispatched directly from the domain event code,

[libvirt] [PATCH 6/8] Remove decl of all APIs related to domain event callbacks & queues

2011-12-13 Thread Daniel P. Berrange
From: "Daniel P. Berrange" The virDomainEventCallbackList and virDomainEventQueue APIs are now solely helpers used internally by virDomainEventState APIs. Remove their decls from domain_event.h since no driver code should need to use them any more. * src/conf/domain_event.c: Make virDomainEventC

[libvirt] [PATCH 5/8] Remove all domain event structs from header

2011-12-13 Thread Daniel P. Berrange
From: "Daniel P. Berrange" No caller of the domain events APIs should need to poke at the struct internals. Thus they should all be removed from the header file * src/conf/domain_event.h: Remove struct definitions * src/conf/domain_event.c: Add struct definitions --- src/conf/domain_event.c |

[libvirt] [PATCH 8/8] Only add the timer when a callback is registered

2011-12-13 Thread Daniel P. Berrange
From: "Daniel P. Berrange" The lifetime of the virDomainEventState object is tied to the lifetime of the driver, which in stateless drivers is tied to the lifetime of the virConnectPtr. If we add & remove a timer when allocating/freeing the virDomainEventState object, we can get a situation wher

[libvirt] [PATCH 3/8] Add APIs to allow management of callbacks purely with virDomainEventState

2011-12-13 Thread Daniel P. Berrange
From: "Daniel P. Berrange" While virDomainEventState has APIs for managing removal of callbacks, while locked, adding callbacks in the first place requires direct access to the virDomainEventCallbackList structure. This is not threadsafe since it is bypassing the virDomainEventState locks * src/

[libvirt] [PATCH 4/8] Convert drivers to thread safe APIs for adding callbacks

2011-12-13 Thread Daniel P. Berrange
From: "Daniel P. Berrange" * src/libxl/libxl_driver.c, src/lxc/lxc_driver.c, src/qemu/qemu_driver.c, src/remote/remote_driver.c, src/test/test_driver.c, src/uml/uml_driver.c, src/vbox/vbox_tmpl.c, src/xen/xen_driver.c: Convert to threadsafe APIs --- src/libxl/libxl_driver.c | 18

[libvirt] [PATCH 1/8] Convert Xen & VBox drivers to use virDomainEventState

2011-12-13 Thread Daniel P. Berrange
From: "Daniel P. Berrange" The Xen & VBox drivers deal with callbacks & dispatching of events directly. All the other drivers use a timer to dispatch events from a clean stack state, rather than deep inside the drivers. Convert Xen & VBox over to virDomainEventState so that they match behaviour o

[libvirt] [PATCH 0/8] Refactor event state handling to fix crash

2011-12-13 Thread Daniel P. Berrange
When running while true ; do date ; ../tools/virsh -q -c test:///default 'shutdown test; undefine test; dominfo test' ; done we often experiance hangs or crashes or memory corruption in glibc. The reason is that when the virConnectPtr is free'd this in turn frees the event state, which in t

[libvirt] [PATCH 2/8] Return count of callbacks when registering callbacks

2011-12-13 Thread Daniel P. Berrange
From: "Daniel P. Berrange" When registering a callback for a particular event some callers need to know how many callbacks already exist for that event. While it is possible to ask for a count, this is not free from race conditions when threaded. Thus the API for registering callbacks should retu

Re: [libvirt] [PATCH v2 5/6] util: Add helpers for safe domain console operations

2011-12-13 Thread Eric Blake
On 12/07/2011 11:08 AM, Peter Krempa wrote: > This patch adds a set of functions used in creating console streams for > domains using PTYs and ensures mutualy exculsive access to the PTYs. s/mutualy exculsive/mutually exclusive/ > > If mutualy exclusive access is not used, two clients may open t

Re: [libvirt] [PATCH v2 4/6] fdstream: Add internal callback on stream close

2011-12-13 Thread Eric Blake
On 12/07/2011 11:08 AM, Peter Krempa wrote: > This patch adds another callback to a FDstream object. The original > callback is used by the daemon stream driver to handle events. > > This callback is called if and only if the stream is about to be closed. > This might be used to handle cleanup ste

Re: [libvirt] [PATCH v2 3/6] fdstream: Emit stream abort callback even if poll() doesnt.

2011-12-13 Thread Eric Blake
On 12/07/2011 11:08 AM, Peter Krempa wrote: > This patch causes the fdstream driver to call the stream event callback > if virStreamAbort() is issued on a stream using this driver. This > prohibited to abort streams from the daemon, as the daemon remote > handler installs a callback to watch for st

Re: [libvirt] [PATCH] virsh: support multifunction in attach-disk

2011-12-13 Thread KAMEZAWA Hiroyuki
On Tue, 13 Dec 2011 16:14:18 -0700 Eric Blake wrote: > On 12/12/2011 11:12 PM, KAMEZAWA Hiroyuki wrote: > > From: KAMEZAWA Hiroyuki > > > > PCI can be specified by attach-disk but multifunction cannot > > be specified. add --multifunction support. > > --- > > tools/virsh.c |7 ++- >

Re: [libvirt] [PATCH v2 2/6] virsh: add support for VIR_DOMAIN_CONSOLE_FORCE flag

2011-12-13 Thread Eric Blake
On 12/07/2011 11:08 AM, Peter Krempa wrote: > This patch adds support for the newly introduced VIR_DOMAIN_CONSOLE s/$/_FORCE/ > flag. The console command now has an optional parameter --force that > specifies that the user wants to forcibly interrupt an ongoing console > session and create a new

Re: [libvirt] [PATCH v2 1/6] Add flags for virDomainOpenConsole

2011-12-13 Thread Daniel P. Berrange
On Tue, Dec 13, 2011 at 05:03:05PM -0700, Eric Blake wrote: > On 12/07/2011 11:08 AM, Peter Krempa wrote: > > This patch adds a set of flags to be used with the virDomainOpenConsole > > API call to specify if the user wishes to interrupt an existing console > > session or just to try open a new one

Re: [libvirt] [PATCH v2 1/6] Add flags for virDomainOpenConsole

2011-12-13 Thread Eric Blake
On 12/07/2011 11:08 AM, Peter Krempa wrote: > This patch adds a set of flags to be used with the virDomainOpenConsole > API call to specify if the user wishes to interrupt an existing console > session or just to try open a new one. > > VIR_DOMAIN_CONSOLE_TRY - specifies that the caller wants to t

Re: [libvirt] [PATCH v3] virsh: Add option to undefine storage with domains

2011-12-13 Thread Eric Blake
On 12/13/2011 05:44 AM, Peter Krempa wrote: > Add an option for virsh undefine command, to remove associated storage > volumes while undefining a domain. This patch alows the user to remove s/alows/allows/ > associated (libvirt managed ) storage volumes while undefining a domain. > > The new opt

Re: [libvirt] [PATCH] virsh: support multifunction in attach-disk

2011-12-13 Thread Eric Blake
On 12/12/2011 11:12 PM, KAMEZAWA Hiroyuki wrote: > From: KAMEZAWA Hiroyuki > > PCI can be specified by attach-disk but multifunction cannot > be specified. add --multifunction support. > --- > tools/virsh.c |7 ++- > tools/virsh.pod |3 ++- > 2 files changed, 8 insertions(+), 2 de

Re: [libvirt] [PATCH] virsh: support multifunction in attach-disk

2011-12-13 Thread Eric Blake
On 12/13/2011 12:14 AM, KAMEZAWA Hiroyuki wrote: > On Tue, 13 Dec 2011 14:51:58 +0800 > Wen Congyang wrote: > >> At 12/13/2011 02:12 PM, KAMEZAWA Hiroyuki Write: >>> From: KAMEZAWA Hiroyuki >>> >>> PCI can be specified by attach-disk but multifunction cannot >>> be specified. add --multifunct

Re: [libvirt] [PATCH] virsh: Print error message if argument parsing fails for cmdNodesuspend

2011-12-13 Thread Daniel P. Berrange
On Tue, Dec 13, 2011 at 03:32:12PM -0700, Eric Blake wrote: > On 12/13/2011 03:24 PM, Peter Krempa wrote: > >> Compilation without NLS will trigger gcc warnings that you are using a > >> printf-style interface without any %. Write this as vshError(ctl, "%s", > >> _("Invalid target argument")). > >

Re: [libvirt] [PATCH] docs: tweak 'virsh edit' wording

2011-12-13 Thread Eric Blake
On 12/13/2011 01:36 AM, Michal Privoznik wrote: > On 12.12.2011 22:31, Eric Blake wrote: >> I was wondering why 'virsh edit' didn't support the same >> '--inactive' option as 'virsh dumpxml'; reading the source >> code showed that --inactive was already implied, and that >> the only way to alter a

Re: [libvirt] [PATCH] python: Fix export of virDomainSnapshotListChildrenNames

2011-12-13 Thread Peter Krempa
Dňa 13.12.2011 16:06, Eric Blake wrote / napísal(a): On 12/13/2011 07:54 AM, Peter Krempa wrote: Commit f2013c9dd1ce468b8620ee35c232a93ef7026fb0 added implementation of virDomainSnapshotListChildrenNames override export, but registration of the newly exported function was not added. *python/

Re: [libvirt] [PATCH] virsh: Print error message if argument parsing fails for cmdNodesuspend

2011-12-13 Thread Eric Blake
On 12/13/2011 03:24 PM, Peter Krempa wrote: >> Compilation without NLS will trigger gcc warnings that you are using a >> printf-style interface without any %. Write this as vshError(ctl, "%s", >> _("Invalid target argument")). >> > > Oh! Now I understand why there's used notation "%s", "some cons

Re: [libvirt] [PATCH] virsh: Print error message if argument parsing fails for cmdNodesuspend

2011-12-13 Thread Peter Krempa
Dňa 13.12.2011 16:08, Eric Blake wrote / napísal(a): On 12/13/2011 07:31 AM, Michal Privoznik wrote: -if (vshCommandOptString(cmd, "target",&target)< 0) +if (vshCommandOptString(cmd, "target",&target)< 0) { +vshError(ctl, _("Invalid suspend target argument")); I'd do s/suspe

Re: [libvirt] [PATCH] virsh: Convert escape sequence string to uppercase

2011-12-13 Thread Eric Blake
On 12/13/2011 01:34 AM, Michal Privoznik wrote: > Macro for translating escape sequence to char expects it to be > all uppercase. Without this, various lowercase sequences are > malformed: e.g. ^e gets translated to %. > --- > tools/virsh.c |5 + > 1 files changed, 5 insertions(+), 0 delet

Re: [libvirt] [PATCH v2] Provide a helper method virDomainLiveConfigHelperMethod

2011-12-13 Thread Eric Blake
On 12/11/2011 10:16 PM, Lei Li wrote: > Changes since v1 > - With Eric's comments squashed in. I tend to put revision comments like this after the ---, so as to be helpful in the review but not part of the final commit (once it's part of the tree, we don't care how many prior reversions were om

[libvirt] git access [was: virtio console: name=foo is not supported]

2011-12-13 Thread Eric Blake
On 12/11/2011 06:18 PM, MATSUDA, Daiki wrote: > P.S. I can not use GIT, because live in restricted network. Not necessarily true. Git, being a distributed version control system, is great at letting you copy a repository via non-networked means between systems that can't share a network. For exa

Re: [libvirt] issues with migrating using copy-storage-all

2011-12-13 Thread Eric Blake
On 12/09/2011 06:04 AM, Reinier Schoof wrote: > Hi, > > today I was trying to use the --copy-storage-all feature of virsh > migrate, in an attempt to migrate KVM-instances to another storage > backend. Doing so, I ran into some trouble: > > First of all, it turned out the disk image-file has to b

Re: [libvirt] [PATCH] python: Expose memoryPeek to Python binding

2011-12-13 Thread Eric Blake
On 12/13/2011 06:43 AM, Osier Yang wrote: > --- > python/libvirt-override-api.xml |8 > python/libvirt-override.c | 33 + > 2 files changed, 41 insertions(+), 0 deletions(-) > > +if ((buf = malloc(size)) == NULL) > +return VIR_PY_N

Re: [libvirt] libvirt support on freeBSD

2011-12-13 Thread Eric Blake
On 12/13/2011 11:27 AM, Chandrashekhar Jamadarkhani (cjamadar) wrote: [We tend to avoid top-posting on this list] > Thanks Eric. I am looking for only source code not prebuilt bins. > GNUtls library is mandatory for building libvirt on any OS ? OR can we > use any other library that supports TLS

Re: [libvirt] [PATCH] python: Expose blockPeek API to python binding

2011-12-13 Thread Eric Blake
On 12/13/2011 06:32 AM, Osier Yang wrote: > --- > python/generator.py |1 + > python/libvirt-override-api.xml |9 + > python/libvirt-override.c | 35 +++ > 3 files changed, 45 insertions(+), 0 deletions(-) > > + > +if ((buf

Re: [libvirt] libvirt support on freeBSD

2011-12-13 Thread Chandrashekhar Jamadarkhani (cjamadar)
Thanks Eric. I am looking for only source code not prebuilt bins. GNUtls library is mandatory for building libvirt on any OS ? OR can we use any other library that supports TLS and SSL? Thanks, Chandrashekhar -Original Message- From: Eric Blake [mailto:ebl...@redhat.com] Sent: Tuesday,

Re: [libvirt] libvirt support on freeBSD

2011-12-13 Thread Eric Blake
On 12/13/2011 11:06 AM, Chandrashekhar Jamadarkhani (cjamadar) wrote: > Hi, > > Whether libvirt is ported to FreeBSD, Yes, libvirt has been built on FreeBSD for several releases now, at least based on the testing done on the release candidates and fixed in time for the final releases. For exampl

[libvirt] libvirt support on freeBSD

2011-12-13 Thread Chandrashekhar Jamadarkhani (cjamadar)
Hi, Whether libvirt is ported to FreeBSD, if yes where can I find libvirt source code for FreeBSD ? Appreciate your help. Thanks, Chandrashekhar -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] virsh: Print error message if argument parsing fails for cmdNodesuspend

2011-12-13 Thread Eric Blake
On 12/13/2011 07:31 AM, Michal Privoznik wrote: >> >> -if (vshCommandOptString(cmd, "target", &target) < 0) >> +if (vshCommandOptString(cmd, "target", &target) < 0) { >> +vshError(ctl, _("Invalid suspend target argument")); > I'd do s/suspend // in all strings you're adding. Compil

Re: [libvirt] [PATCH] python: Fix export of virDomainSnapshotListChildrenNames

2011-12-13 Thread Eric Blake
On 12/13/2011 07:54 AM, Peter Krempa wrote: > Commit f2013c9dd1ce468b8620ee35c232a93ef7026fb0 added implementation of > virDomainSnapshotListChildrenNames override export, but registration of > the newly exported function was not added. > > *python/libvirt-override.c: - register export of functio

[libvirt] [PATCH] python: Fix export of virDomainSnapshotListChildrenNames

2011-12-13 Thread Peter Krempa
Commit f2013c9dd1ce468b8620ee35c232a93ef7026fb0 added implementation of virDomainSnapshotListChildrenNames override export, but registration of the newly exported function was not added. *python/libvirt-override.c: - register export of function --- python/libvirt-override.c |1 + 1 files cha

Re: [libvirt] [PATCH v2 0/6] Console coruption with two or more clients series

2011-12-13 Thread Peter Krempa
ping? -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] virsh: Print error message if argument parsing fails for cmdNodesuspend

2011-12-13 Thread Peter Krempa
On 12/13/2011 03:31 PM, Michal Privoznik wrote: On 13.12.2011 14:53, Peter Krempa wrote: If parsing of arguments failed, virsh did silently exit returning and error state, but not specifying the possible problem. * tools/virsh: cmdNodesuspend: - error handling added --- tools/virsh.c | 12

Re: [libvirt] [PATCH] virsh: Print error message if argument parsing fails for cmdNodesuspend

2011-12-13 Thread Michal Privoznik
On 13.12.2011 14:53, Peter Krempa wrote: > If parsing of arguments failed, virsh did silently exit returning and > error state, but not specifying the possible problem. > > * tools/virsh: cmdNodesuspend: - error handling added > --- > tools/virsh.c | 12 +--- > 1 files changed, 9 inser

[libvirt] [PATCH] virsh: Print error message if argument parsing fails for cmdNodesuspend

2011-12-13 Thread Peter Krempa
If parsing of arguments failed, virsh did silently exit returning and error state, but not specifying the possible problem. * tools/virsh: cmdNodesuspend: - error handling added --- tools/virsh.c | 12 +--- 1 files changed, 9 insertions(+), 3 deletions(-) diff --git a/tools/virsh.c b/

Re: [libvirt] Audit records on suspend/pause

2011-12-13 Thread Daniel P. Berrange
On Tue, Dec 13, 2011 at 10:22:50AM -0200, Marcelo Cerri wrote: > Hi, > > I'd like to know if libvirt sends an event to audit system when a > guest is suspended. > > I took a look at source code and I noticed that libvirt already have > a good support for auditing life cycle events, but I couldn't

[libvirt] [PATCH] python: Expose memoryPeek to Python binding

2011-12-13 Thread Osier Yang
--- python/libvirt-override-api.xml |8 python/libvirt-override.c | 33 + 2 files changed, 41 insertions(+), 0 deletions(-) diff --git a/python/libvirt-override-api.xml b/python/libvirt-override-api.xml index 87db67b..2e0c7cb 100644 --- a/pytho

Re: [libvirt] [PATCH] python: Expose blockPeek API to python binding

2011-12-13 Thread Osier Yang
On 2011年12月13日 21:32, Osier Yang wrote: > --- > python/generator.py |1 + > python/libvirt-override-api.xml |9 + > python/libvirt-override.c | 35 +++ > 3 files changed, 45 insertions(+), 0 deletions(-) > > diff --git a/pyth

[libvirt] [PATCH] python: Expose blockPeek API to python binding

2011-12-13 Thread Osier Yang
--- python/generator.py |1 + python/libvirt-override-api.xml |9 + python/libvirt-override.c | 35 +++ 3 files changed, 45 insertions(+), 0 deletions(-) diff --git a/python/generator.py b/python/generator.py index 88c52b9..1657f

[libvirt] [PATCH v3] virsh: Add option to undefine storage with domains

2011-12-13 Thread Peter Krempa
Add an option for virsh undefine command, to remove associated storage volumes while undefining a domain. This patch alows the user to remove associated (libvirt managed ) storage volumes while undefining a domain. The new option --storage for the undefine command takes a string argument that cons

[libvirt] Audit records on suspend/pause

2011-12-13 Thread Marcelo Cerri
Hi, I'd like to know if libvirt sends an event to audit system when a guest is suspended. I took a look at source code and I noticed that libvirt already have a good support for auditing life cycle events, but I couldn't find any events being sent to audit system when a guest is suspended.

Re: [libvirt] macvtap not working on kvm

2011-12-13 Thread Amit Tewari
Hi, Actually udev renames the eth0 interface in guest to eth1 because macvtap0 has different mac address then eth0 on host.. Is there some way so that we can prevent changing this rename of eth0 to eth1 on guest. I don't want to change udev files. From: xhu

Re: [libvirt] macvtap not working on kvm

2011-12-13 Thread xhu
On 12/13/2011 12:59 PM, Amit Tewari wrote: Hi all, My test environment Host os=rhel6.1 Guest os = rhel6.1 Libvirt=0.9.8 Kvm hypervisor I have made this entry in guest xml file function='0x0'/> Now when I start the guest *#virsh start guest* Following macvtap0 is created on ho

Re: [libvirt] [PATCH] tests: plug memory leak on linuxTestNodeInfo

2011-12-13 Thread Michal Privoznik
On 13.12.2011 07:45, a...@redhat.com wrote: > From: Alex Jia > > Detected by valgrind. Leak introduced in commit 82ff25e. > > * tests/nodeinfotest.c: avoid memory leak on nodeinfo test case. > > * how to reproduce? > % cd tests && valgrind -v --leak-check=full ./nodeinfotest > > * actual val

Re: [libvirt] [PATCH] docs: tweak 'virsh edit' wording

2011-12-13 Thread Michal Privoznik
On 12.12.2011 22:31, Eric Blake wrote: > I was wondering why 'virsh edit' didn't support the same > '--inactive' option as 'virsh dumpxml'; reading the source > code showed that --inactive was already implied, and that > the only way to alter a running guest rather than affecting > next boot is by

[libvirt] [PATCH] virsh: Convert escape sequence string to uppercase

2011-12-13 Thread Michal Privoznik
Macro for translating escape sequence to char expects it to be all uppercase. Without this, various lowercase sequences are malformed: e.g. ^e gets translated to %. --- tools/virsh.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index d5