Re: [libvirt] [libvirt-glib 1/2] API to suspend a domain

2012-01-05 Thread Christophe Fergeau
ACK On Fri, Dec 23, 2011 at 09:58:22PM +0200, Zeeshan Ali (Khattak) wrote: > From: "Zeeshan Ali (Khattak)" > > --- > libvirt-gobject/libvirt-gobject-domain.c | 30 > ++ > libvirt-gobject/libvirt-gobject-domain.h |3 +++ > libvirt-gobject/libvirt-gobject.sym

Re: [libvirt] [PATCH] network: Avoid memory leaks on networkBuildDnsmasqArgv

2012-01-05 Thread Alex Jia
On 01/06/2012 03:11 PM, Osier Yang wrote: On 2012年01月06日 13:14, a...@redhat.com wrote: From: Alex Jia Detected by valgrind. Leaks introduced in commit 973af236. * src/network/bridge_driver.c: fix memory leaks on failure and successful path. * How to reproduce? % cd tests&& valgrind -v --le

Re: [libvirt] [PATCH] network: Avoid memory leaks on networkBuildDnsmasqArgv

2012-01-05 Thread Osier Yang
On 2012年01月06日 13:14, a...@redhat.com wrote: From: Alex Jia Detected by valgrind. Leaks introduced in commit 973af236. * src/network/bridge_driver.c: fix memory leaks on failure and successful path. * How to reproduce? % cd tests&& valgrind -v --leak-check=full ./networkxml2argvtest * Actual

Re: [libvirt] [PATCH] qemu: Avoid memory leaks on qemuParseRBDString

2012-01-05 Thread Osier Yang
On 2012年01月06日 14:36, a...@redhat.com wrote: From: Alex Jia Detected by valgrind. Leak introduced in commit 5745dc1. * src/qemu/qemu_command.c: fix memory leak on failure and successful path. * How to reproduce? % valgrind -v --leak-check=full ./qemuargv2xmltest * Actual result: ==2196== 80

[libvirt] [PATCH] qemu: Avoid memory leaks on qemuParseRBDString

2012-01-05 Thread ajia
From: Alex Jia Detected by valgrind. Leak introduced in commit 5745dc1. * src/qemu/qemu_command.c: fix memory leak on failure and successful path. * How to reproduce? % valgrind -v --leak-check=full ./qemuargv2xmltest * Actual result: ==2196== 80 bytes in 1 blocks are definitely lost in loss

[libvirt] [PATCH] network: Avoid memory leaks on networkBuildDnsmasqArgv

2012-01-05 Thread ajia
From: Alex Jia Detected by valgrind. Leaks introduced in commit 973af236. * src/network/bridge_driver.c: fix memory leaks on failure and successful path. * How to reproduce? % cd tests && valgrind -v --leak-check=full ./networkxml2argvtest * Actual result: ==2226== 3 bytes in 1 blocks are def

Re: [libvirt] In freeze for libvirt-0.9.9 and availability of rc2

2012-01-05 Thread Daniel Veillard
On Thu, Jan 05, 2012 at 09:11:18PM +0100, Peter Krempa wrote: > Dňa 5.1.2012 16:37, Daniel Veillard wrote / napísal(a): > >On Fri, Dec 30, 2011 at 02:30:43PM +0800, Daniel Veillard wrote: > >I have made a release candidate 2 tarball (and associated rpms) at > > ftp://libvirt.org/libvirt/libvir

[libvirt] 答复: hyperv connection

2012-01-05 Thread Andy Li
Dear Matthias Bolte It works, amazing. It hard to descript my road map on libvirt, but thank you very much. Thanks, Andy Li MFG Software Developer Department of Storage Products R&D, SCS Universal Scientific Industrial (Shanghai) Co., Ltd 421 Lishizhen Rd, Pudong New Area, Shanghai,P.R. China,

[libvirt] [PATCH] build: drop check for ANSI compiler

2012-01-05 Thread Eric Blake
Using automake.git (will become 1.12 someday), I got this error: configure.ac:90: error: automatic de-ANSI-fication support has been removed /usr/local/share/aclocal-1.11a/protos.m4:13: AM_C_PROTOTYPES is expanded from... configure.ac:90: the top level autom4te: /usr/bin/m4 failed with exit status

Re: [libvirt] QMP: Supporting off tree APIs

2012-01-05 Thread Luiz Capitulino
On Thu, 05 Jan 2012 09:56:44 -0600 Anthony Liguori wrote: > On 01/05/2012 09:35 AM, Eric Blake wrote: > > On 01/05/2012 07:16 AM, Luiz Capitulino wrote: > >>> I know. We're stuck in a hard place here again because NotSupported > >>> has been in the Image Streaming API spec and hence implemented

Re: [libvirt] In freeze for libvirt-0.9.9 and availability of rc2

2012-01-05 Thread Peter Krempa
Dňa 5.1.2012 16:37, Daniel Veillard wrote / napísal(a): On Fri, Dec 30, 2011 at 02:30:43PM +0800, Daniel Veillard wrote: I have made a release candidate 2 tarball (and associated rpms) at ftp://libvirt.org/libvirt/libvirt-0.9.9-rc2.tar.gz and the git tree is tagged. I've tested the rc2 on

Re: [libvirt] [PATCH] PolicyKit: Check auth before asking client to obtain it

2012-01-05 Thread Eric Blake
On 01/03/2012 03:35 PM, Jim Fehlig wrote: > I previously mentioned [1] a PolicyKit issue where libvirt would > proceed with authentication even though polkit-auth failed: > > testusr xen134:~> virsh list --all > Attempting to obtain authorization for org.libvirt.unix.manage. > polkit-grant-helper:

Re: [libvirt] [PATCHv2] qemu: fix a bug in numatune

2012-01-05 Thread Eric Blake
On 01/04/2012 02:41 AM, Hu Tao wrote: > When setting numa nodeset for a domain which has no nodeset set > before, libvirtd crashes by dereferring the pointer to the old s/dereferring/dereferencing/ > nodemask which is null in the case. > --- > src/qemu/qemu_driver.c | 45 ++

Re: [libvirt] [PATCHv3 2/2] qemu: add new disk device='lun' for bus='virtio' & type='block'

2012-01-05 Thread Eric Blake
On 01/05/2012 11:35 AM, Laine Stump wrote: > In the past, generic SCSI commands issued from a guest to a virtio > disk were always passed through to the underlying disk by qemu, and > the kernel would also pass them on. > > > v3 changes: > > 1) Add note to docs that the SCSI commands are not on

[libvirt] [PATCHv3 2/2] qemu: add new disk device='lun' for bus='virtio' & type='block'

2012-01-05 Thread Laine Stump
In the past, generic SCSI commands issued from a guest to a virtio disk were always passed through to the underlying disk by qemu, and the kernel would also pass them on. As a result of CVE-2011-4127 (see: http://seclists.org/oss-sec/2011/q4/536), qemu now honors its scsi=on|off device option for

Re: [libvirt] Using virtEvents

2012-01-05 Thread Eric Blake
On 12/29/2011 04:03 AM, D. Herrendoerfer wrote: > Sorry to come back on this. [Caveat - I didn't write the threading model used in libvirt, so my answers are my interpretation of the code as I have come to understand it, but might not be 100% accurate] > > How are the different threads of the li

Re: [libvirt] Using virtEvents

2012-01-05 Thread Daniel P. Berrange
On Thu, Dec 29, 2011 at 12:03:06PM +0100, D. Herrendoerfer wrote: > Sorry to come back on this. > > How are the different threads of the libvirt daemon separated ? > I understand that there are 2 separate threads running that are > forked. There are also 4 more that appear to be threads. > Is that

Re: [libvirt] [PATCHv2 2/2] qemu: add new disk device='lun' for bus='virtio' & type='block'

2012-01-05 Thread Laine Stump
On 01/05/2012 11:10 AM, Paolo Bonzini wrote: On 01/05/2012 04:59 PM, Laine Stump wrote: On 01/05/2012 03:44 AM, Paolo Bonzini wrote: Summary: two nits, one in the docs and one at the end of this email. [Osier, I'm CCing you because there is some food for thought for SCSI]. On 01/05/2012 05:17

Re: [libvirt] [PATCH] revert commit baade4cd2bf partly

2012-01-05 Thread Eric Blake
On 01/04/2012 11:36 PM, Alex Jia wrote: > On 01/05/2012 09:13 AM, Hu Tao wrote: >> On Tue, Jan 03, 2012 at 11:14:15AM +0800, Hu Tao wrote: >>> This is not a memory leak. See line 8029 and 8030 of qemu_driver.c. >>> >>> To ensure this, I tested twice following these steps: >>> >>>1. set bandwidt

Re: [libvirt] [PATCHv2 2/2] qemu: add new disk device='lun' for bus='virtio' & type='block'

2012-01-05 Thread Paolo Bonzini
On 01/05/2012 04:59 PM, Laine Stump wrote: On 01/05/2012 03:44 AM, Paolo Bonzini wrote: Summary: two nits, one in the docs and one at the end of this email. [Osier, I'm CCing you because there is some food for thought for SCSI]. On 01/05/2012 05:17 AM, Laine Stump wrote: diff --git a/docs/for

Re: [libvirt] [PATCHv2 2/2] qemu: add new disk device='lun' for bus='virtio' & type='block'

2012-01-05 Thread Eric Blake
On 01/05/2012 08:59 AM, Laine Stump wrote: >>> @@ -9607,7 +9609,8 @@ static int >>> qemuDomainSnapshotIsAllowed(virDomainObjPtr vm) >>> * that succeed as well >>> */ >>>for (i = 0; i< vm->def->ndisks; i++) { >>> -if (vm->def->disks[i]->device == VIR_DOMAIN_DISK_DE

Re: [libvirt] [PATCHv2 2/2] qemu: add new disk device='lun' for bus='virtio' & type='block'

2012-01-05 Thread Daniel P. Berrange
On Thu, Jan 05, 2012 at 09:44:27AM +0100, Paolo Bonzini wrote: > Summary: two nits, one in the docs and one at the end of this email. > > [Osier, I'm CCing you because there is some food for thought for SCSI]. > > On 01/05/2012 05:17 AM, Laine Stump wrote: > > @@ -4241,6 +4273,7 @@ qemuBuildComma

Re: [libvirt] [PATCHv2 2/2] qemu: add new disk device='lun' for bus='virtio' & type='block'

2012-01-05 Thread Laine Stump
On 01/05/2012 03:44 AM, Paolo Bonzini wrote: Summary: two nits, one in the docs and one at the end of this email. [Osier, I'm CCing you because there is some food for thought for SCSI]. On 01/05/2012 05:17 AM, Laine Stump wrote: diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.i

Re: [libvirt] QMP: Supporting off tree APIs

2012-01-05 Thread Anthony Liguori
On 01/05/2012 09:35 AM, Eric Blake wrote: On 01/05/2012 07:16 AM, Luiz Capitulino wrote: I know. We're stuck in a hard place here again because NotSupported has been in the Image Streaming API spec and hence implemented in libvirt for a while now. If we change this then an old client which onl

[libvirt] In freeze for libvirt-0.9.9 and availability of rc2

2012-01-05 Thread Daniel Veillard
On Fri, Dec 30, 2011 at 02:30:43PM +0800, Daniel Veillard wrote: > We are now entering the freeze for libvirt-0.9.9 . > We hadn't yet reviewed Taku Izumi second version of his patchset > maybe we can pull his next version in rc2. Sorry I made rc2 earlier today and Taku Izumi patch set is not i

Re: [libvirt] QMP: Supporting off tree APIs

2012-01-05 Thread Eric Blake
On 01/05/2012 07:16 AM, Luiz Capitulino wrote: >> I know. We're stuck in a hard place here again because NotSupported >> has been in the Image Streaming API spec and hence implemented in >> libvirt for a while now. If we change this then an old client which >> only understands NotSupported will n

Re: [libvirt] [PATCH 1/4 V2] libvirt: Add new public API virDomainGetPcpusUsage

2012-01-05 Thread Richard W.M. Jones
On Wed, Jan 04, 2012 at 12:09:18PM +0800, Lai Jiangshan wrote: > +int virDomainGetPcpusUsage(virDomainPtr dom, > + unsigned long long *usages, > + int *nr_usages, > + unsigned int flags); It'd be useful to get feedback f

Re: [libvirt] [PATCH 2/4 V2] remote: mplement new API virDomainGetPcpusUsage for remote driver

2012-01-05 Thread Richard W.M. Jones
The title for this should be 'implement', not 'mplement'. > +/* Upper limit on list of physic cpu parameters. */ 'physical' > +const REMOTE_DOMAIN_PCPUS_USAGE_PARAMETERS_MAX = 16; This seems a bit low. Is this limiting us to returning information about only 16 pCPUs? Meta-comment: libvirt nee

[libvirt] QMP: Supporting off tree APIs

2012-01-05 Thread Luiz Capitulino
On Thu, 5 Jan 2012 13:48:43 + Stefan Hajnoczi wrote: > On Wed, Jan 4, 2012 at 12:59 PM, Luiz Capitulino > wrote: > > On Tue, 13 Dec 2011 13:52:27 + > > Stefan Hajnoczi wrote: > > > >> Add the block_stream command, which starts copy backing file contents > >> into the image file.  Later

Re: [libvirt] hyperv connection

2012-01-05 Thread Matthias Bolte
2012/1/5 Andy Li : > Dear Sir or Madam: > > > > I am trying to connect hyper-v with libvirt0.9.8 with hyperv driver, but it > always reply the follow error > > > > virsh # connect hyperv://192.168.58.231:5985 > > Enter username for 192.168.58.231 [administrator]: > > Enter administrator's password

[libvirt] hyperv connection

2012-01-05 Thread Andy Li
Dear Sir or Madam: I am trying to connect hyper-v with libvirt0.9.8 with hyperv driver, but it always reply the follow error virsh # connect hyperv://192.168.58.231:5985 Enter username for 192.168.58.231 [administrator]: Enter administrator's password for 192.168.58.231: 2012-01-05 14:

Re: [libvirt] kvm-qemu emulator problem

2012-01-05 Thread Pankaj Rawat
Thanks for that, might be there is some other way to use fvd. Rather than the one I just used. -Original Message- From: Daniel P. Berrange [mailto:berra...@redhat.com] Sent: Thursday, January 05, 2012 5:05 PM To: Michal Novotny Cc: Pankaj Rawat; libvir-list@redhat.com Subject: Re: [libv

Re: [libvirt] kvm-qemu emulator problem

2012-01-05 Thread Michal Novotny
On 01/05/2012 12:34 PM, Daniel P. Berrange wrote: > On Thu, Jan 05, 2012 at 12:07:40PM +0100, Michal Novotny wrote: >> I don't have any experience with fvd however this is not libvirt-related >> issue rather than qemu-related. Please try to ask qemu guys how to fix this. > Actually it is a libvirt

Re: [libvirt] kvm-qemu emulator problem

2012-01-05 Thread Daniel P. Berrange
On Thu, Jan 05, 2012 at 12:07:40PM +0100, Michal Novotny wrote: > I don't have any experience with fvd however this is not libvirt-related > issue rather than qemu-related. Please try to ask qemu guys how to fix this. Actually it is a libvirt error message. if ((format = virStorageFileFor

Re: [libvirt] [PATCH] daemon: Allow overriding NOFILES ulimit for the daemon as well

2012-01-05 Thread Michal Privoznik
On 05.01.2012 11:50, Daniel P. Berrange wrote: > On Thu, Jan 05, 2012 at 11:16:32AM +0100, Michal Privoznik wrote: >> One of my latest patches (d8db0f9690) created support for setting >> the limit for the maximum of opened files by qemu user. However, >> since libvirtd keeps one FD opened per domai

Re: [libvirt] kvm-qemu emulator problem

2012-01-05 Thread Michal Novotny
I don't have any experience with fvd however this is not libvirt-related issue rather than qemu-related. Please try to ask qemu guys how to fix this. Michal On 01/05/2012 12:04 PM, Pankaj Rawat wrote: > Sorry for that > I defined it now > When I run the command > > [root@localhost qemu]# virs

Re: [libvirt] kvm-qemu emulator problem

2012-01-05 Thread Pankaj Rawat
Sorry for that I defined it now When I run the command [root@localhost qemu]# virsh start guestfvd error: Failed to start domain guestfvd error: internal error unknown disk format 'fvd' for /var/lib/libvirt/images/guestfvd I know this error sounds like the fvd is not installed but I havecompil

Re: [libvirt] [PATCH] daemon: Allow overriding NOFILES ulimit for the daemon as well

2012-01-05 Thread Daniel P. Berrange
On Thu, Jan 05, 2012 at 11:16:32AM +0100, Michal Privoznik wrote: > One of my latest patches (d8db0f9690) created support for setting > the limit for the maximum of opened files by qemu user. However, > since libvirtd keeps one FD opened per domain (well, for qemu at least) > it will likely hit thi

Re: [libvirt] kvm-qemu emulator problem

2012-01-05 Thread Michal Novotny
On 01/05/2012 11:43 AM, Pankaj Rawat wrote: > I created a xml file guestfvd.xml > > Then I made changes as u specified > And when run command > > > [root@localhost qemu]# virsh start guestfvd > error: failed to get domain 'guestfvd' > error: Domain not found: no domain with matching name 'guestfvd

Re: [libvirt] kvm-qemu emulator problem

2012-01-05 Thread Pankaj Rawat
I created a xml file guestfvd.xml Then I made changes as u specified And when run command [root@localhost qemu]# virsh start guestfvd error: failed to get domain 'guestfvd' error: Domain not found: no domain with matching name 'guestfvd' Now this error make sence since we have'nt created a gu

[libvirt] [PATCH] daemon: Allow overriding NOFILES ulimit for the daemon as well

2012-01-05 Thread Michal Privoznik
One of my latest patches (d8db0f9690) created support for setting the limit for the maximum of opened files by qemu user. However, since libvirtd keeps one FD opened per domain (well, for qemu at least) it will likely hit this limit on huge scenarios. --- daemon/libvirtd.aug |1 + daemon/libv

Re: [libvirt] kvm-qemu emulator problem

2012-01-05 Thread Michal Novotny
Hi, the libvirt XML configuration file is having the emulator set and if you start the guest using libvirt (e.g. using virsh start ) then it's being used. You can find the path to the emulator used for the VM in //domain/devices/emulator xPath query applied on the XML file, i.e.: ... hvm /u

Re: [libvirt] [PATCH] seclabel: fix regression in libvirtd restart

2012-01-05 Thread Daniel Veillard
On Wed, Jan 04, 2012 at 04:01:24PM -0700, Eric Blake wrote: > Commit b434329 has a logic bug: seclabel overrides don't set > def->type, but the default value is 0 (aka static). Restarting > libvirtd would thus reject the XML for any domain with an > override of (which happens quite > easily if a

Re: [libvirt] [PATCH] seclabel: fix regression in libvirtd restart

2012-01-05 Thread Michal Privoznik
On 05.01.2012 00:01, Eric Blake wrote: > Commit b434329 has a logic bug: seclabel overrides don't set > def->type, but the default value is 0 (aka static). Restarting > libvirtd would thus reject the XML for any domain with an > override of (which happens quite > easily if a disk image lives on N

[libvirt] kvm-qemu emulator problem

2012-01-05 Thread Pankaj Rawat
Hi all , I am trying to use fvd for my guest machine for that I refer the link http://sites.google.com/site/tangchq/qemu-fvd now all works fine except the last step which said that if libvirt is used then the xml configuration file need to be changed to include the modified emulator qemu-s

Re: [libvirt] [PATCH] Support Xen domctl v8

2012-01-05 Thread Daniel Veillard
On Wed, Jan 04, 2012 at 10:00:11AM -0700, Eric Blake wrote: > On 01/04/2012 08:52 AM, Jim Fehlig wrote: > > xen-unstable c/s 23874:651aed73b39c added another member to > > xen_domctl_getdomaininfo struct and bumped domctl version to 8. > > Add a corresponding domctl v8 struct in xen hypervisor sub-

Re: [libvirt] [PATCH v2] command: Discard FD_SETSIZE limit for opened files

2012-01-05 Thread Michal Privoznik
On 04.01.2012 19:51, Eric Blake wrote: > On 01/04/2012 09:58 AM, Michal Privoznik wrote: >> Currently, virCommand implementation uses FD_ macros from >> sys/select.h. However, those cannot handle more opened files >> than FD_SETSIZE. Therefore switch to generalized implementation >> based on array

Re: [libvirt] [PATCHv2 2/2] qemu: add new disk device='lun' for bus='virtio' & type='block'

2012-01-05 Thread Paolo Bonzini
Summary: two nits, one in the docs and one at the end of this email. [Osier, I'm CCing you because there is some food for thought for SCSI]. On 01/05/2012 05:17 AM, Laine Stump wrote: > diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in > index 18b7e22..dcdf91f 100644 > --- a/docs

Re: [libvirt] [PATCHv2 0/2] qemu: add new disk device='lun' for bus='virtio' & type='block'

2012-01-05 Thread Paolo Bonzini
On 01/05/2012 06:49 AM, KAMEZAWA Hiroyuki wrote: Hmm, won't this force admins to rewrite their domain definitions ? Some admin may need to reflesh 100s of domain defintions when he upgrade distro... How about (sdisk = secure disk) and make 'sdisk' as default ? We believe that most site

[libvirt] [PATCH v2][TCK] add test case for block job lifecycle testing

2012-01-05 Thread Xiaoqiang Hu
v2: Add skip block for qemu only and 120s timeout for test v1: Add tests for block job lifecyle and the test flow is as follows: create 50M qed img with qed backing img-> block pull->abort block job->resume block pull->set block job speed-> wait to finish --- scripts/qemu/300-blockjob-lifecycle.