[libvirt] [PATCH] qemu: unescape HMP commands before converting them to json

2012-02-24 Thread Josh Durgin
QMP commands don't need to be escaped since converting them to json also escapes special characters. When a QMP command fails, however, libvirt falls back to HMP commands. These fallback functions (qemuMonitorText*) do their own escaping, and pass the result directly to qemuMonitorHMPCommandWithFd.

[libvirt] [PATCH] build: update to latest gnulib

2012-02-24 Thread Eric Blake
It's been a while, and we're between releases, so now's as good a time as any to resync. I didn't notice any showstopper bugs being fixed, but we definitely get some improvements, such as tighter syntax checks. * .gnulib: Update to latest. * bootstrap: Resync. * cfg.mk (sc_prohibit_strncmp): Copy

Re: [libvirt] [PATCH v2 3/3] qemu: Implement virDomainPMWakeup API

2012-02-24 Thread Eric Blake
On 02/23/2012 01:44 AM, Michal Privoznik wrote: > On 15.02.2012 16:04, Michal Privoznik wrote: >> using 'system-wakeup' monitor command. It is supported only in JSON, >> as we are enabling it if possible. Moreover, this command is available >> in qemu-1.1+ which definitely has JSON. >> --- >> src/

Re: [libvirt] [PATCH v5 0/7] Console corruption patchset

2012-02-24 Thread Eric Blake
On 02/23/2012 07:03 AM, Peter Krempa wrote: > Yet another spin of the console corruption patches. > > Current state: > > * 1/7 - pidfile: Make checking binary path in virPidFileRead optional > - No changes to v4. > - ACKed by Eric > * 2/7 - Add flags for virDomainOpenConsole >

Re: [libvirt] [PATCH v5 6/7] util: Add helpers for safe domain console operations

2012-02-24 Thread Eric Blake
On 02/23/2012 07:03 AM, Peter Krempa wrote: > This patch adds a set of functions used in creating console streams for > domains using PTYs and ensures mutually exclusive access to the PTYs. > > If mutualy exclusive access is not used, two clients may open the same s/mutualy/mutually/ > console,

Re: [libvirt] [PATCH] Fixed URI parsing

2012-02-24 Thread Eric Blake
On 02/24/2012 11:48 AM, Martin Kletzander wrote: > Function xmlParseURI does not remove square brackets around IPv6 > address when parsing. One of the solutions is making wrappers around > functions working with xmlURI*. This assures that uri->server will be > always properly assigned and it doesn'

Re: [libvirt] [PATCH] Fixed service handling in specfile

2012-02-24 Thread Eric Blake
On 02/24/2012 04:28 AM, Martin Kletzander wrote: > After adding the libvirt-guests service into usual runlevels, we used > to start the libvirt-guests service. However this is usually not a > good practice. As mentioned on fedoraproject wiki, the installations > can be in changeroots, in an install

Re: [libvirt] Correct a check for capacity arg of storageVolumeResize()

2012-02-24 Thread Zeeshan Ali (Khattak)
On Fri, Feb 24, 2012 at 8:58 PM, Eric Blake wrote: > On 02/23/2012 08:00 PM, Zeeshan Ali (Khattak) wrote: >> From: "Zeeshan Ali (Khattak)" >> >> --- >>  src/storage/storage_driver.c |    2 +- >>  1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/src/storage/storage_driver.c b/sr

Re: [libvirt] [PATCH v3] Fixed URI parsing

2012-02-24 Thread Daniel P. Berrange
On Fri, Feb 24, 2012 at 07:09:49PM +0100, Martin Kletzander wrote: > +xmlURIPtr > +virURIParse(const char *uri) > +unsigned char * > +virURIFormat(xmlURIPtr uri) The data types here are wrong compared to the header. Also the return value should not be unsigned - that is libxml2 bad practice we s

Re: [libvirt] [PATCH] virsh: fix informational message in iface-bridge command

2012-02-24 Thread Laine Stump
On 02/24/2012 02:34 PM, Laine Stump wrote: > See: https://bugzilla.redhat.com/show_bug.cgi?id=797066 > > The position of the bridge name and ethernet device name were > accidentally swapped in the message informing of success creating the > bridge. > --- > tools/virsh.c |2 +- > 1 files change

[libvirt] [PATCH] virsh: fix informational message in iface-bridge command

2012-02-24 Thread Laine Stump
See: https://bugzilla.redhat.com/show_bug.cgi?id=797066 The position of the bridge name and ethernet device name were accidentally swapped in the message informing of success creating the bridge. --- tools/virsh.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tools/vir

Re: [libvirt] [PATCH v5 2/2] Add de-association handling to macvlan code

2012-02-24 Thread Laine Stump
While going through this code to clean up the white-space problems, I found 3 issues that need to be addressed before I can push it. Sorry I missed these before. If you can base the new (and I hope final! :-) version on the version where I've already corrected the whitespace, that would be very he

Re: [libvirt] Correct a check for capacity arg of storageVolumeResize()

2012-02-24 Thread Eric Blake
On 02/23/2012 08:00 PM, Zeeshan Ali (Khattak) wrote: > From: "Zeeshan Ali (Khattak)" > > --- > src/storage/storage_driver.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c > index df0e291..641944d 100644

[libvirt] [PATCH] Fixed URI parsing

2012-02-24 Thread Martin Kletzander
Function xmlParseURI does not remove square brackets around IPv6 address when parsing. One of the solutions is making wrappers around functions working with xmlURI*. This assures that uri->server will be always properly assigned and it doesn't have to be changed when used on some new place in the c

Re: [libvirt] Virt io blk buffer

2012-02-24 Thread Eric Blake
On 02/23/2012 11:53 PM, Pankaj Rawat wrote: > Hi all > > Can any one tell what is the default Vitio blk IO Buffer size You'll probably get better response on the qemu lists, since virtio is part of qemu. > > And can we change it ? if yes how? Libvirt does not currently expose anything to cha

Re: [libvirt] [PATCH v3] Fixed URI parsing

2012-02-24 Thread Eric Blake
On 02/24/2012 11:09 AM, Martin Kletzander wrote: > Function xmlParseURI does not remove square brackets around IPv6 > address when parsing. One of the solutions is making wrappers around > functions working with xmlURI*. This assures that uri->server will be > always properly assigned and it doesn'

[libvirt] [PATCH v3] Fixed URI parsing

2012-02-24 Thread Martin Kletzander
Function xmlParseURI does not remove square brackets around IPv6 address when parsing. One of the solutions is making wrappers around functions working with xmlURI*. This assures that uri->server will be always properly assigned and it doesn't have to be changed when used on some new place in the c

[libvirt] New QMP event interface (was Re: [Qemu-devel] [PATCH 5/5] qmp: add DEVICE_TRAY_MOVED event)

2012-02-24 Thread Anthony Liguori
On 02/24/2012 10:56 AM, Luiz Capitulino wrote: On Fri, 24 Feb 2012 10:44:11 -0600 Anthony Liguori wrote: I'm asking because the conversion of events to the qapi is not too far away, but I think that using QOM will somewhat deprecate the code you have in the glib branch (besides having to wait

Re: [libvirt] [PATCHv2] Error out when using SPICE TLS with spice_tls=0

2012-02-24 Thread Eric Blake
On 02/24/2012 03:41 AM, Daniel P. Berrange wrote: > On Fri, Feb 24, 2012 at 11:34:45AM +0100, Christophe Fergeau wrote: >> It's possible to disable SPICE TLS in qemu.conf. When this happens, >> libvirt ignores any SPICE TLS port or x509 directory that may have >> been set when it builds the qemu co

Re: [libvirt] [PATCH] Improve error reporting when virsh console is run without a TTY

2012-02-24 Thread Eric Blake
On 02/24/2012 08:13 AM, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > If attempting to run > > ssh root@somehost virsh console someguest > > You'll get an error > > 2012-02-15 13:11:47.683+: 4765: info : libvirt version: 0.9.10, > package: 1.fc18 (Unknown, 2012-02-15-11:4

Re: [libvirt] [PATCH] Workaround python header file insanity

2012-02-24 Thread Eric Blake
On 02/24/2012 08:13 AM, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > The /usr/include/python/pyconfig.h file pollutes the global > namespace with a huge number of HAVE_XXX and WITH_XXX > defines. These change what we detected in our own config.h > In particular if you try to build w

[libvirt] [PATCH] Workaround python header file insanity

2012-02-24 Thread Daniel P. Berrange
From: "Daniel P. Berrange" The /usr/include/python/pyconfig.h file pollutes the global namespace with a huge number of HAVE_XXX and WITH_XXX defines. These change what we detected in our own config.h In particular if you try to build without DTrace, python's headers turn it back on with predictab

[libvirt] [PATCH] Improve error reporting when virsh console is run without a TTY

2012-02-24 Thread Daniel P. Berrange
From: "Daniel P. Berrange" If attempting to run ssh root@somehost virsh console someguest You'll get an error 2012-02-15 13:11:47.683+: 4765: info : libvirt version: 0.9.10, package: 1.fc18 (Unknown, 2012-02-15-11:48:57, lettuce.camlab.fab.redhat.com) 2012-02-15 13:11:47.683+: 4

Re: [libvirt] [PATCH v5 2/2] Add de-association handling to macvlan code

2012-02-24 Thread D. Herrendoerfer
On Feb 24, 2012, at 3:29 PM, D. Herrendoerfer wrote: On Feb 23, 2012, at 11:16 PM, Laine Stump wrote: On 02/22/2012 08:17 AM, D. Herrendoerfer wrote: From: "D. Herrendoerfer" Add de-association handling for 802.1qbg (vepa) via lldpad netlink messages. Also adds the possibility to perform

Re: [libvirt] [PATCH v5 2/2] Add de-association handling to macvlan code

2012-02-24 Thread D. Herrendoerfer
On Feb 23, 2012, at 11:16 PM, Laine Stump wrote: On 02/22/2012 08:17 AM, D. Herrendoerfer wrote: From: "D. Herrendoerfer" Add de-association handling for 802.1qbg (vepa) via lldpad netlink messages. Also adds the possibility to perform an association request without waiting for a confirmatio

Re: [libvirt] [PATCH v2] Fixed URI parsing

2012-02-24 Thread Eric Blake
On 02/24/2012 06:30 AM, Martin Kletzander wrote: > Function xmlParseURI does not remove square brackets around IPv6 > address when parsing. One of the solutions is making wrappers around > functions working with xmlURI*. This assures that uri->server will be > always properly assigned and it doesn'

Re: [libvirt] [PATCH v2] Fixed URI parsing

2012-02-24 Thread Daniel P. Berrange
On Fri, Feb 24, 2012 at 02:30:11PM +0100, Martin Kletzander wrote: > Function xmlParseURI does not remove square brackets around IPv6 > address when parsing. One of the solutions is making wrappers around > functions working with xmlURI*. This assures that uri->server will be > always properly assi

[libvirt] [PATCH v2] Fixed URI parsing

2012-02-24 Thread Martin Kletzander
Function xmlParseURI does not remove square brackets around IPv6 address when parsing. One of the solutions is making wrappers around functions working with xmlURI*. This assures that uri->server will be always properly assigned and it doesn't have to be changed when used on some new place in the c

Re: [libvirt] RFC: Post-install behavior of libvirt(-client)

2012-02-24 Thread Martin Kletzander
On 02/23/2012 04:23 PM, Eric Blake wrote: > On 02/23/2012 07:25 AM, Martin Kletzander wrote: >> >> To me it seems more reasonable to just don't start anything. I don't >> want any service on my system started just because I installed it. > > I think we've reached a state of violent agreement :) I

Re: [libvirt] Add GSoC project ideas to the wiki!

2012-02-24 Thread Stefan Hajnoczi
On Fri, Feb 24, 2012 at 10:38 AM, Michal Privoznik wrote: > On 24.02.2012 10:19, Stefan Hajnoczi wrote: > Thank you for the opportunity. I was personally thinking about something > libvirt-snmp related. Nowdays, it is difficult to add new elements to > MIB, as some parts of code were generated by

Re: [libvirt] [Patch v2] vmx: Better Workstation vmx handling

2012-02-24 Thread Matthias Bolte
2012/2/23 Jean-Baptiste Rouault : > This patch adds support for vmx files with empty networkName > values (which is the case for vmx generated by Workstation). > It also adds support for vmx containing NATed network interfaces. > > Update test suite accordingly > --- ACK and pushed, thanks. -- M

Re: [libvirt] libvirt TCK wrapper for autotest review

2012-02-24 Thread Lucas Meneghel Rodrigues
On 02/23/2012 12:27 PM, Guannan Ren wrote: Hi Lucas, Thanks for your these good modifications. There is one place I noticed where you output each testcase of "*.t" into a separate file with .tap extension. hence, it has a corresponding log file with little content for each testcase. it seem a l

[libvirt] [PATCH] Fixed service handling in specfile

2012-02-24 Thread Martin Kletzander
After adding the libvirt-guests service into usual runlevels, we used to start the libvirt-guests service. However this is usually not a good practice. As mentioned on fedoraproject wiki, the installations can be in changeroots, in an installer context, or in other situations where we don't want th

Re: [libvirt] [PATCHv2] Error out when using SPICE TLS with spice_tls=0

2012-02-24 Thread Daniel P. Berrange
On Fri, Feb 24, 2012 at 11:34:45AM +0100, Christophe Fergeau wrote: > It's possible to disable SPICE TLS in qemu.conf. When this happens, > libvirt ignores any SPICE TLS port or x509 directory that may have > been set when it builds the qemu command line to use. However, it's > not ignoring the sec

Re: [libvirt] Add GSoC project ideas to the wiki!

2012-02-24 Thread Michal Privoznik
On 24.02.2012 10:19, Stefan Hajnoczi wrote: > This is a reminder that QEMU will apply for Google Summer of Code 2012 and we > need project ideas and mentors. Libvirt and kvm.ko projects are also welcome! > > http://wiki.qemu.org/Google_Summer_of_Code_2012 > > Please add yourself to the wiki now

[libvirt] [PATCHv2] Error out when using SPICE TLS with spice_tls=0

2012-02-24 Thread Christophe Fergeau
It's possible to disable SPICE TLS in qemu.conf. When this happens, libvirt ignores any SPICE TLS port or x509 directory that may have been set when it builds the qemu command line to use. However, it's not ignoring the secure channels that may have been set and adds tls-channel arguments to qemu c

[libvirt] [PATCH v4] Support for cpu64-rhel* qemu cpu models

2012-02-24 Thread Martin Kletzander
In qemu there are 2 cpu models (cpu64-rhel5 and cpu64-rhel6) not supported by libvirt. This patch adds the support with the flags specifications from /usr/share/qemu-kvm/cpu-model/cpu-x86_64.conf The only difference is that AMD-specific features are removed so the processor type is not vendor-speci

[libvirt] Add GSoC project ideas to the wiki!

2012-02-24 Thread Stefan Hajnoczi
This is a reminder that QEMU will apply for Google Summer of Code 2012 and we need project ideas and mentors. Libvirt and kvm.ko projects are also welcome! http://wiki.qemu.org/Google_Summer_of_Code_2012 Please add yourself to the wiki now if you want to mentor a project this summer. I will fil