On 03/15/2012 02:06 PM, Alex Jia wrote:
* tools/virsh.c (cmdDetachDisk): fix invalid free due to using
uninitialised value.
* How to reproduce?
# virsh detach-disk a b
error: failed to get domain 'a'
*** glibc detected *** virsh: double free or corruption (out):
0x7fff410ed1a0 ***
Good
On Thu, Mar 15, 2012 at 11:21:09AM +0530, Prerna Saxena wrote:
> Hi Daniel,
> Thank you for taking a look.
>
> On 03/14/2012 02:29 PM, Daniel Veillard wrote:
> > On Tue, Mar 13, 2012 at 11:10:16AM +0530, Prerna Saxena wrote:
> >> From: Prerna Saxena
> >> Date: Tue, 13 Mar 2012 15:33:43 +0530
> >>
* tools/virsh.c (cmdDetachDisk): fix invalid free due to using
uninitialised value.
* How to reproduce?
# virsh detach-disk a b
error: failed to get domain 'a'
*** glibc detected *** virsh: double free or corruption (out):
0x7fff410ed1a0 ***
=== Backtrace: =
/lib64/libc.so.6[0x
Hi Daniel,
Thank you for taking a look.
On 03/14/2012 02:29 PM, Daniel Veillard wrote:
> On Tue, Mar 13, 2012 at 11:10:16AM +0530, Prerna Saxena wrote:
>> From: Prerna Saxena
>> Date: Tue, 13 Mar 2012 15:33:43 +0530
>> Subject: [PATCH 2/2] Sysinfo : Allow x86 to fetch sysinfo from
>> /proc/cpui
On 03/12/2012 04:17 PM, Daniel Veillard wrote:
On Thu, Mar 08, 2012 at 09:36:26PM +0800, Osier Yang wrote:
numad is an user-level daemon that monitors NUMA topology and
processes resource consumption to facilitate good NUMA resource
alignment of applications/virtual machines to improve performan
On 03/14/2012 11:05 PM, Laine Stump wrote:
Wire up the domain graphics event notifications for SPICE. Adapted
from a RHEL-only patch written by Dan Berrange that used custom
__com.redhat_SPICE events - equivalent events are now available in
upstream QEMU (including a SPICE_CONNECTED event, which
256 (8 bits) is insufficient for large scale deployments. 65536 (16 bits) is a
more appropriate limit and should be sufficient. You are more likely to run
into other system limitations first, such as the 31998 inode link limit on
ext3.
---
src/remote/remote_protocol.x |2 +-
1 files changed, 1
I am using libvirt for large scale deployment of virtual machines. I ran into
an issue where virConnectListStoragePools and virConnectListDefinedStoragePools
return an error if there are more than 256 pools. The following patch increases
this limitation. Currently, I am only using in the neighbo
Hi,
last email hopefully. My last patch was broken because it double
locked vm. I discovered that virDomainFindBy* locks vm before
returning it. The new patch does not double-lock.
best,
Tom
From f2fd4cb72c8f2e01567320a643fe2d665308119e Mon Sep 17 00:00:00 2001
From: Thomas Hunger
Date: Thu, 15
Hey again,
attached is a patch against master that fixes the race condition for
me. Not sure if this is the best solution. My system is quite stable
now under load instead of dying every so often.
best,
Tom
From db8d9d3e674328b81fabc3dcb7981b4727a8e369 Mon Sep 17 00:00:00 2001
From: Thomas Hunger
Chunyan Liu wrote:
> Hi, Jim,
> I made some changes to the patch according to your comments:
> a. support concurrent migrations, add virBitmapPtr for probing migration ports
> b. update doParseURI:
> use virAsprintf instead of strdup and snprintf,
> support migration URI syntax hostname[:port],
Hi,
I've got a theory on what's happening now, but I am not sure how to
fix this. The following seems to be the order of events that kills
libvirtd:
[Thread A] lxcDomainDestroyFlags requested
[Thread A] acquires driver lock
[Thread A] cgroup killing triggers VIR_EVENT_HANDLE_HANGUP
[Thread B] lxc
Hi,
I'm running version 0.9.10 on debian [1]. When starting and stopping
containers I see deadlocks every so often. I attached a full backtrace
(see at the end of the log). This seems to happen in conditions
similar to the segfault I wrote about recently. I.e. usually when
destroying domains.
I'm
On Wed, Mar 14, 2012 at 12:00:04PM -0600, Eric Blake wrote:
> On 03/14/2012 11:53 AM, Daniel P. Berrange wrote:
>
> > In other words, I don't think it is acceptable to automagically
> > split '' and pass them as argv[]. We should only
> > use it for setting LIBVIRT_LXC_CMDLINE.
> >
> > We should
On 03/14/2012 11:53 AM, Daniel P. Berrange wrote:
> In other words, I don't think it is acceptable to automagically
> split '' and pass them as argv[]. We should only
> use it for setting LIBVIRT_LXC_CMDLINE.
>
> We should add a separate element for setting init's
> argv[] I think
as in:
com
On Wed, Mar 14, 2012 at 11:22:35AM -0600, Eric Blake wrote:
> On 03/14/2012 09:24 AM, Daniel P. Berrange wrote:
> > From: "Daniel P. Berrange"
> >
> > Currently for LXC we set LIBVIRT_LXC_CMDLINE to contain the
> > contents of It is more convenient
> > if we just set the argv[] of the init b
On Wed, Mar 14, 2012 at 11:10:24AM -0600, Eric Blake wrote:
> On 03/14/2012 10:50 AM, Daniel P. Berrange wrote:
> >> This looks like it is repeating some of the code in
> >> virsh.c:vshCommandStringGetArg; any chance we can combine them? In
> >> particular, the ability to mimic shell handling of \
On 03/14/2012 09:24 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange"
>
> Currently for LXC we set LIBVIRT_LXC_CMDLINE to contain the
> contents of It is more convenient
> if we just set the argv[] of the init binary directly though.
>
> * lxc/lxc_container.c: Set init argv from cm
On 03/14/2012 10:50 AM, Daniel P. Berrange wrote:
>> This looks like it is repeating some of the code in
>> virsh.c:vshCommandStringGetArg; any chance we can combine them? In
>> particular, the ability to mimic shell handling of \ escapes, as well as
>> the difference in behavior of \ inside "" vs
On Wed, Mar 14, 2012 at 10:40:41AM -0600, Eric Blake wrote:
> On 03/14/2012 09:19 AM, Daniel P. Berrange wrote:
> > From: "Daniel P. Berrange"
> >
> > To facilitate parsing of argv[] style strings, provide a
> > virStrSplitQuoted API which will split a string on the listed
> > separators, but als
On 03/14/2012 09:19 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange"
>
> To facilitate parsing of argv[] style strings, provide a
> virStrSplitQuoted API which will split a string on the listed
> separators, but also allow for quoting with ' or ".
>
> * src/libvirt_private.syms, src/ut
The QEMU bridge helper allows QEMU to be executed with bridge networking
support from a non-privileged user. For more details see:
http://lists.gnu.org/archive/html/qemu-devel/2012-01/msg03562.html
I would like to see if there is interest in adding support to allow
libvirt to execute guests wi
On 12-03-2012 11:44, Eric Blake wrote:
>>
>> ACK.
>
> Thanks; pushed.
Tested-By: Crístian Viana
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
From: "Daniel P. Berrange"
Currently for LXC we set LIBVIRT_LXC_CMDLINE to contain the
contents of It is more convenient
if we just set the argv[] of the init binary directly though.
* lxc/lxc_container.c: Set init argv from cmdline
---
src/lxc/lxc_container.c | 12
1 files
From: "Daniel P. Berrange"
To facilitate parsing of argv[] style strings, provide a
virStrSplitQuoted API which will split a string on the listed
separators, but also allow for quoting with ' or ".
* src/libvirt_private.syms, src/util/util.c,
src/util/util.h: Implement virStrSplitQuoted
* test
Wire up the domain graphics event notifications for SPICE. Adapted
from a RHEL-only patch written by Dan Berrange that used custom
__com.redhat_SPICE events - equivalent events are now available in
upstream QEMU (including a SPICE_CONNECTED event, which was missing in
the __COM.redhat_SPICE version
On 03/14/2012 05:06 AM, Osier Yang wrote:
> On 03/14/2012 01:45 PM, Laine Stump wrote:
>> Wire up the domain graphics event notifications for SPICE. Adapted
>> from a RHEL-only patch written by Dan Berrange that used custom
>> __com.redhat_SPICE events - equivalent events are now available in
>> up
This patch introduces a new event type for the QMP event
SUSPEND:
VIR_DOMAIN_EVENT_ID_PMSUSPEND
The event doesn't take any data, but considering there might
be reason for wakeup in future, the callback definition is:
typedef void
(*virConnectDomainEventSuspendCallback)(virConnectPtr conn,
This patch introduces a new event type for the QMP event
WAKEUP:
VIR_DOMAIN_EVENT_ID_PMWAKEUP
The event doesn't take any data, but considering there might
be reason for wakeup in future, the callback definition is:
typedef void
(*virConnectDomainEventWakeupCallback)(virConnectPtr conn,
On 03/14/2012 06:45 PM, Daniel Veillard wrote:
On Tue, Mar 13, 2012 at 11:05:31PM -0300, Lucas Meneghel Rodrigues wrote:
Hi Guannan:
I've worked on your first version of the libvirt-test-api wrapper
for autotest. Could you please check if you like the modified
version?
https://github.com/autot
--
Created this as a seperate patch, as I'm not quite sure if it's
good to do this in libvirt, it's more like a protection for
qemu problem, i.e. closing the physical drive tray won't close
the guest tray. Paolo persist in doing this in libvirt, but IMHO
QEMU is the better place to prevent that. An
This is similiar with physical world, one will be surprised if the
box starts with medium exists while the tray is open.
New tests are added, tests disk-{cdrom,floppy}-tray are for the qemu
supports "-device" flag, and disk-{cdrom,floppy}-no-device-cap are
for old qemu, i.e. which doesn't support
On 03/12/2012 09:33 PM, Paolo Bonzini wrote:
Il 12/03/2012 15:19, Osier Yang ha scritto:
And don't allow to hotplug a usb disk with "device == lun". This
is the missed pieces in previous virtio-scsi patchset:
http://www.redhat.com/archives/libvir-list/2012-February/msg01052.html
Looks good to
The "tray" is only allowed for removable disks, i.e. CDROM and
Floppy disks.
As the value for "tray" defaults to "closed", lots of tests are
updated to include "tray='closed'" in the disk target XML.
---
src/conf/domain_conf.c | 33 +++-
src/conf/doma
---
src/qemu/qemu_process.c | 13 +
1 files changed, 13 insertions(+), 0 deletions(-)
diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
index d55c269..e041f8d 100644
--- a/src/qemu/qemu_process.c
+++ b/src/qemu/qemu_process.c
@@ -1092,6 +1092,19 @@ qemuProcessHandlePMSu
This patch introduces a new event type for the QMP event
DEVICE_TRAY_MOVED, which occurs when the tray of a removable
disk is moved (i.e opened or closed):
VIR_DOMAIN_EVENT_ID_TRAY_CHANGE
The event's data includes the device alias and the reason
for tray status' changing, which indicates why
This introduces a new running reason VIR_DOMAIN_RUNNING_WAKEUP,
and new suspend event type VIR_DOMAIN_EVENT_STARTED_WAKEUP.
While a wakeup event is emitted, the domain which entered into
VIR_DOMAIN_PMSUSPENDED will be transferred to "running"
with reason VIR_DOMAIN_RUNNING_WAKEUP, and a new domain
This introduces a new domain state pmsuspended to represent
the domain which has been suspended by guest power management,
e.g. (entered itno s3 state). Because a "running" state could
be confused in this case, one will see the guest is paused
actually while playing. And state "paused" is for the d
Example XML:
---
docs/formatdomain.html.in | 13 +
docs/schemas/domaincommon.rng |8
2 files changed, 17 insertions(+), 4 deletions(-)
diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
index bf0675e..da335dd 100644
--
v1 ~ v2:
* Two more patches, [5/11] to prohibit tray='open' for
block type disk. And [9/11] to introduce a new domain
state 'pmsuspended'
* Definition (including name) for DEVICE_TRAY_MOVED event
is changed into:
typedef void
(*virConnectDomainEventTrayChangeCallbac
With this patch, libvirt won't start the guest with the medium
source which already ejected by guest when doing migration, or
saving/restoring.
---
src/qemu/qemu_process.c | 10 ++
1 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_pro
On 03/14/2012 07:45 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange"
>
> Currently if the URI passed to virConnectOpen* is NULL, then we
>
> - Look for LIBVIRT_DEFAULT_URI env var
> - Probe for drivers
>
> This changes it so that
>
> - Look for LIBVIRT_DEFAULT_URI env var
> - Loo
On 03/14/2012 07:38 AM, Daniel P. Berrange wrote:
> On Wed, Mar 14, 2012 at 06:54:40AM -0600, Eric Blake wrote:
>> On 03/14/2012 06:37 AM, Daniel P. Berrange wrote:
>>> From: "Daniel P. Berrange"
>>>
>>> Currently if the URI passed to virConnectOpen* is NULL, then we
>>>
>>> - Look for LIBVIRT_DE
From: "Daniel P. Berrange"
Currently if the URI passed to virConnectOpen* is NULL, then we
- Look for LIBVIRT_DEFAULT_URI env var
- Probe for drivers
This changes it so that
- Look for LIBVIRT_DEFAULT_URI env var
- Look for 'uri_default' in $HOME/.libvirt/libvirt.conf
- Probe for drivers
On 03/14/2012 07:35 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange"
>
> Systemd has declared that all container virtualization technologies
> should set 'container_uuid' to identify themselves.
>
> http://cgit.freedesktop.org/systemd/systemd/commit/?id=09b967eaa51a39dabb7f238927f67bd6
On Wed, Mar 14, 2012 at 06:54:40AM -0600, Eric Blake wrote:
> On 03/14/2012 06:37 AM, Daniel P. Berrange wrote:
> > From: "Daniel P. Berrange"
> >
> > Currently if the URI passed to virConnectOpen* is NULL, then we
> >
> > - Look for LIBVIRT_DEFAULT_URI env var
> > - Probe for drivers
> >
> >
From: "Daniel P. Berrange"
Systemd has declared that all container virtualization technologies
should set 'container_uuid' to identify themselves.
http://cgit.freedesktop.org/systemd/systemd/commit/?id=09b967eaa51a39dabb7f238927f67bd682466dbc
---
src/lxc/lxc_container.c |1 +
1 files change
On Wed, Mar 14, 2012 at 05:06:48PM +0800, Osier Yang wrote:
> On 03/14/2012 01:45 PM, Laine Stump wrote:
> >Wire up the domain graphics event notifications for SPICE. Adapted
> >from a RHEL-only patch written by Dan Berrange that used custom
> >__com.redhat_SPICE events - equivalent events are now
dom.getCPUStats(True, 0)
[{'cpu_time': 92913537401L, 'system_time': 547000L, 'user_time':
31000L}]
dom.getCPUStats(False, 0)
[{'cpu_time': 39476858499L}, {'cpu_time': 10627048370L}, {'cpu_time':
21270945682L}, {'cpu_time': 21556420641L}]
*generator.py Add a new n
On 03/14/2012 06:37 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange"
>
> Currently if the URI passed to virConnectOpen* is NULL, then we
>
> - Look for LIBVIRT_DEFAULT_URI env var
> - Probe for drivers
>
> This changes it so that
>
> - Look for LIBVIRT_DEFAULT_URI env var
> - Loo
From: "Daniel P. Berrange"
Currently if the URI passed to virConnectOpen* is NULL, then we
- Look for LIBVIRT_DEFAULT_URI env var
- Probe for drivers
This changes it so that
- Look for LIBVIRT_DEFAULT_URI env var
- Look for 'uri_default' in $HOME/.libvirt/libvirt.conf
- Probe for drivers
On 03/14/2012 06:12 AM, Guannan Ren wrote:
> On 03/14/2012 05:10 PM, Eric Blake wrote:
>> On 03/14/2012 03:02 AM, Daniel Veillard wrote:
>>> On Wed, Mar 14, 2012 at 03:06:38PM +0800, Alex Jia wrote:
On 03/14/2012 01:57 PM, Guannan Ren wrote:
> dom.cPUStats(True, 0)
I'd like getVcp
On 03/14/2012 05:10 PM, Eric Blake wrote:
On 03/14/2012 03:02 AM, Daniel Veillard wrote:
On Wed, Mar 14, 2012 at 03:06:38PM +0800, Alex Jia wrote:
On 03/14/2012 01:57 PM, Guannan Ren wrote:
dom.cPUStats(True, 0)
I'd like getVcpuStats or cpuStats function naming.
Based on existing conv
ack
On Tue, Mar 6, 2012 at 5:38 PM, Christophe Fergeau wrote:
> This is used to add the SPICE USB redirection channel. Even if
> the libvirt doc doesn't document it with the other devices deriving
> from GVirConfigDomainChardev, I think it makes sense to have this
> class derivers from GVirConfig
On 03/14/2012 05:38 AM, Michal Privoznik wrote:
> With current code, we pass true iff domain is cold booting. However,
> if disk is inaccessible and startupPolicy for that disk is set to
> 'requisite' we have to fail iff cold booting.
> ---
> src/qemu/qemu_domain.c |4 ++--
> 1 files changed,
With current code, we pass true iff domain is cold booting. However,
if disk is inaccessible and startupPolicy for that disk is set to
'requisite' we have to fail iff cold booting.
---
src/qemu/qemu_domain.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/qemu/qemu_
This email is automatically generated.
The test result is based on the following git commit:
19c7980 qemu: fix segfault when detaching non-existent network device
Analysis summary report:
Files analyzed : 254
Total LoC input to cov-analyze : 348334
Functi
On Tue, Mar 13, 2012 at 11:05:31PM -0300, Lucas Meneghel Rodrigues wrote:
> Hi Guannan:
>
> I've worked on your first version of the libvirt-test-api wrapper
> for autotest. Could you please check if you like the modified
> version?
>
> https://github.com/autotest/autotest/pull/230
>
> If you do
I did let the one month cycle go a bit for a change, last release
was on the 13th and considering how short Feb is and the fact that
aligning with end of month makes things easier to remember and plan
for, I suggest to slip by two week and plan for the end of March.
More specifically I would sug
Il 14/03/2012 10:38, Eric Blake ha scritto:
>> 2) in case the snapshotting is aborted early for any reason, oVirt has
>> to do a rebase operation manually. This is currently O(size-of-disk),
>> not O(changes-in-the-last-image), so it wastes both disk space and time.
>
> I don't follow the argumen
On 03/13/2012 08:01 PM, Eric Blake wrote:
On 03/07/2012 06:30 AM, Peter Krempa wrote:
This patch adds support for the new tsc-deadline feature flag
and a new model to the supported model list describing the
Intel Sandy Bridge platform.
---
ACK. That promised followup patch that sorts things i
On 03/14/2012 02:16 AM, Paolo Bonzini wrote:
>>
>>
>>
>>
>>
>>
>>
>>
>> would create a new libvirt snapshot object with /src/snap.img as the
>> read-write new image, and /dest/snap.img as the new write-only mirror.
>> On success, this rewrites the domain's li
On Wed, Mar 14, 2012 at 03:10:46AM -0600, Eric Blake wrote:
> On 03/14/2012 03:02 AM, Daniel Veillard wrote:
> > On Wed, Mar 14, 2012 at 03:06:38PM +0800, Alex Jia wrote:
> >> On 03/14/2012 01:57 PM, Guannan Ren wrote:
> >>>dom.cPUStats(True, 0)
> >> I'd like getVcpuStats or cpuStats function n
On 03/13/2012 11:57 PM, Guannan Ren wrote:
>dom.cPUStats(True, 0)
> [{'cpu_time': 370942649768L, 'system_time': 1164000L, 'user_time':
> 89000L}]
>
>dom.cPUStats(False, 0)
> [{'cpu_time': 38378374721L}, {'cpu_time': 12475521087L}, {'cpu_time':
> 127388622598L}, {'cpu_
Hi,
I am running libvirt 0.10 on debian [1] and I am getting the following
segfault [2] about once a day when using the lxc driver. I don't know
how to reproduce the circumstances unfortunately. It seems to happen
when destroying domains. I attached the debug log leading up to the
segfault. Is thi
On 03/14/2012 03:02 AM, Daniel Veillard wrote:
> On Wed, Mar 14, 2012 at 03:06:38PM +0800, Alex Jia wrote:
>> On 03/14/2012 01:57 PM, Guannan Ren wrote:
>>>dom.cPUStats(True, 0)
>> I'd like getVcpuStats or cpuStats function naming.
>
> Based on existing conventions, it should be getVcpuStats
On Wed, Mar 14, 2012 at 03:06:38PM +0800, Alex Jia wrote:
> On 03/14/2012 01:57 PM, Guannan Ren wrote:
> >dom.cPUStats(True, 0)
> I'd like getVcpuStats or cpuStats function naming.
Based on existing conventions, it should be getVcpuStats() method,
I agree,
Guannan could you fix this in th
From: "D. Herrendoerfer"
When libvirtd is restarted, also restart the netlink event
message callbacks for existing VEPA connections and send
a message to lldpad for these existing links, so it learns
the new libvirtd pid.
Note: This Patch provides fixes to a number of scenarios where
lldpad, swi
On Tue, Mar 13, 2012 at 11:10:16AM +0530, Prerna Saxena wrote:
> From: Prerna Saxena
> Date: Tue, 13 Mar 2012 15:33:43 +0530
> Subject: [PATCH 2/2] Sysinfo : Allow x86 to fetch sysinfo from
> /proc/cpuinfo in the event 'dmidecode' is absent in the system.
>
> Until now, libvirt on x86 flags an
Il 13/03/2012 20:15, Eric Blake ha scritto:
> > If the disk type is "block", and the source drive is a CD-ROM, the
> > virtual tray state should be tied to the physical tray, even though this
> > isn't always the case due to QEMU bugs.
>
> Are we trying to map the tray='open' to what the guest see
On 03/14/2012 01:45 PM, Laine Stump wrote:
Wire up the domain graphics event notifications for SPICE. Adapted
from a RHEL-only patch written by Dan Berrange that used custom
__com.redhat_SPICE events - equivalent events are now available in
upstream QEMU (including a SPICE_CONNECTED event, which
Il 13/03/2012 23:20, Eric Blake ha scritto:
> virDomainSnapshotCreateXML will learn a new flag:
> VIR_DOMAIN_SNAPSHOT_CREATE_ATOMIC. If this flag is present, then
> libvirt guarantees that the snapshot operation will either succeed, or
> that failure will be reported without changing domain XML or
On 03/14/2012 01:57 PM, Guannan Ren wrote:
dom.cPUStats(True, 0)
I'd like getVcpuStats or cpuStats function naming.
[{'cpu_time': 370942649768L, 'system_time': 1164000L, 'user_time':
89000L}]
dom.cPUStats(False, 0)
[{'cpu_time': 38378374721L}, {'cpu_time': 124755
73 matches
Mail list logo
