This works with newer qemu that doesn't allow escaping spaces.
It's backwards compatible as well.
Signed-off-by: Josh Durgin
---
src/qemu/qemu_command.c|2 +-
.../qemuxml2argv-disk-drive-network-rbd-auth.args |2 +-
2 files changed, 2 insertions(+), 2 deletio
Signed-off-by: Josh Durgin
---
src/qemu/qemu_driver.c | 14 ++
1 files changed, 10 insertions(+), 4 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 78899a4..86e82d6 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -9605,12 +9605,18
On 27/04/2012, at 5:45 AM, Cole Robinson wrote:
> For a complete list of changes since libvirt-0.9.11 GA, please see:
>
> http://wiki.libvirt.org/page/Stable_Releases
* Just as a FYI, this "Stable_Releases" page needs some linkage.
It's not referred to from the News section, there no link to
On Mon, Apr 30, 2012 at 5:38 PM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange"
>
> Flesh out the section intros for each of the Libvirt GLib
> library modules, providing using examples where needed, and
> adding any missing function docs.
Looks good, ACK!
--
Regards,
Zeeshan Ali (Kha
On 04/20/2012 10:01 AM, Dmitry Guryanov wrote:
> Add driver, which can report node info only.
Since this is the first commit in the series, can you please add more
information about pvs? This content from your 0/9 message would be
useful here:
>> Parallels Virtuozzo Server is a cloud-ready virtu
On 04/25/2012 06:59 AM, Stefan Berger wrote:
> This patch adds DHCP snooping support to libvirt. The learning method for
> IP addresses is specified by setting the "CTRL_IP_LEARNING" variable to one of
> "any" [default] (existing IP learning code), "none" (static only addresses)
> or "dhcp" (DHCP s
configure.ac:
Check for libnl-3. If found, find libnl-route-3. If not found,
do the original check to look for libnl-1.
src/util/virnetlink.c:
support libnl3 api. I could play games to make the patch smaller,
but this would just hide what is actually needing to be done at
the expense of clarity
The recent push to use correct scaling terms (kB for 1000, KiB for
1024 - such as commit 9dfdead) missed some places in virsh.
* tools/virsh.c (prettyCapacity, cmdDominfo, cmdFreecell)
(cmdNodeinfo, cmdNodeMemStats): Use KiB, not kB, when referring to
multiples of 1024.
* tests/virshtest.c: Update
On 04/30/2012 02:31 PM, Eric Blake wrote:
> The recent push to use correct scaling terms (kB for 1000, KiB for
> 1024 - such as commit 9dfdead) missed some places in virsh.
>
> * tools/virsh.c (prettyCapacity, cmdDominfo, cmdFreecell)
> (cmdNodeinfo, cmdNodeMemStats): Use KiB, not kB, when referri
Otherwise, a string such as _("Don't use \"" VAR "\".") would
complain about unmarked diagnostics.
* cfg.mk (sc_libvirt_unmarked_diagnostics): Handle \" in message.
---
I needed this patch to let me verify Stefan's DHCP Snooping series.
cfg.mk |2 +-
1 files changed, 1 insertions(+), 1 dele
Based on a report by Seth Vidal. Just because _you_ can use virsh
to connect to both source and destinations does not mean that libvirtd
on the source (aka _root_) can likewise connect to the destination;
this matters when setting up a peer-to-peer migration instead of a
native one.
* docs/migrat
The recent push to use correct scaling terms (kB for 1000, KiB for
1024 - such as commit 9dfdead) missed some places in virsh.
* tools/virsh.c (prettyCapacity, cmdDominfo, cmdFreecell)
(cmdNodeinfo, cmdNodeMemStats): Use KiB, not kB, when referring to
multiples of 1024.
---
tools/virsh.c | 24 +
https://bugzilla.redhat.com/show_bug.cgi?id=817244 mentions that
unlike most other tools, where --help or --version prevent all
further parsing of all later options, virsh was strange in that
--version stopped parsing but --help tried to plow on to the end.
There was no rationale for this original
Il 26/04/2012 22:55, Eric Blake ha scritto:
>
> Paolo proposed 'drive-mirror' to upstream qemu prior to Stefan
> Hajnoczi's patch to 'block-stream'. qemu 1.1 has included Stefan's
> patch, but Paolo's is still in limbo, and needs to be rebased if it will
> even make qemu 1.1. But it is a logical
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
On Mon, Apr 30, 2012 at 12:56:05PM -0600, Eric Blake thus spake:
>On 04/30/2012 12:43 PM, Jason Helfman wrote:
Is there any particular reason that the project is using the same naming
convention for stable releases? It appears to be a
On 04/30/2012 12:43 PM, Jason Helfman wrote:
>>>
>>> Is there any particular reason that the project is using the same naming
>>> convention for stable releases? It appears to be a minor revision update
>>> from the standard release cycle. From an outsiders prospective, I don't
>>> know how anyone
Hi,
New to the list so hopefully I'm following the correct protocol.
Attached is a patch (mostly untested at the moment) to change the
default storage location from .libvirt to the locations defined in the
XDG Base Directory Specification
(http://standards.freedesktop.org/basedir-spec/basedir-spe
On Mon, Apr 30, 2012 at 01:38:27PM -0500, Doug Goldstein thus spake:
On Sat, Apr 28, 2012 at 10:35 PM, Jason Helfman wrote:
Okay, I screwed up the tarball for the first stable release, due to not
building it from a fresh checkout :/ No changes for this one except a
version
bump and dist rebuild
On Sat, Apr 28, 2012 at 10:35 PM, Jason Helfman wrote:
>> Okay, I screwed up the tarball for the first stable release, due to not
>> building it from a fresh checkout :/ No changes for this one except a
>> version
>> bump and dist rebuild.
>>
>> This release can be downloaded at:
>>
>> http://libv
On 04/30/2012 08:52 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange"
>
> Currently the libvirt_lxc process uses VIR_DOMAIN_XML_INACTIVE
> when loading the XML for the container. This means it looses
s/looses/loses/
> any dynamic data such as the, just allocated, SELinux label.
>
> Fu
The subject line is pretty generic; it's better to add something like
the name of the function being fixed to minimize the chance of patch
name collision causing backporters minor confusion in deciding what to
backport.
On 04/28/2012 05:01 AM, Alex Jia wrote:
> In fact, the 'tapfd' is always NULL,
On 04/30/2012 10:50 AM, Stefan Berger wrote:
> On 04/30/2012 12:38 PM, Eric Blake wrote:
>> The previous storage patch missed an instance affected by the struct
>> member rename.
>>
>
>> @@ -589,11 +589,13 @@
>> virStorageBackendISCSIFindPoolSources(virConnectPtr conn
>> ATTRIBUTE_UNUSED,
>>
On 04/30/2012 12:55 PM, Daniel P. Berrange wrote:
On Mon, Apr 30, 2012 at 12:42:37PM -0400, Stefan Berger wrote:
> /libvirt/daemon/libvirtd.c:168:
> leaked_handle: Handle variable "stdinfd" going out of scope leaks the
handle.
This is refering to the 3rd line here:
switch
On Mon, Apr 30, 2012 at 12:42:37PM -0400, Stefan Berger wrote:
> On 04/30/2012 12:34 PM, Daniel P. Berrange wrote:
> >On Mon, Apr 30, 2012 at 12:28:26PM -0400, Stefan Berger wrote:
> >>Addressing the following reports:
> >>
> >None of those reports mention daemon/libvirtd.c and yet
> >
>
> These m
On 04/30/2012 12:38 PM, Eric Blake wrote:
The previous storage patch missed an instance affected by the struct
member rename.
@@ -589,11 +589,13 @@ virStorageBackendISCSIFindPoolSources(virConnectPtr conn
ATTRIBUTE_UNUSED,
}
for (i = 0 ; i< ntargets ; i++) {
-if (VIR_AL
On Mon, Apr 30, 2012 at 10:38:38AM -0600, Eric Blake wrote:
> The previous storage patch missed an instance affected by the struct
> member rename.
>
> * src/storage/storage_backend_iscsi.c
> (virStorageBackendISCSIFindPoolSources): Adjust to new struct.
> ---
>
> Pushing under the build-breaker
On 04/30/2012 12:34 PM, Daniel P. Berrange wrote:
On Mon, Apr 30, 2012 at 12:28:26PM -0400, Stefan Berger wrote:
Addressing the following reports:
None of those reports mention daemon/libvirtd.c and yet
These must have gotten lost:
Error: RESOURCE_LEAK:
/libvirt/daemon/libvirtd.c:147:
open
The previous storage patch missed an instance affected by the struct
member rename.
* src/storage/storage_backend_iscsi.c
(virStorageBackendISCSIFindPoolSources): Adjust to new struct.
---
Pushing under the build-breaker rule.
src/storage/storage_backend_iscsi.c | 12
1 files cha
On Mon, Apr 30, 2012 at 12:28:26PM -0400, Stefan Berger wrote:
> Addressing the following reports:
>
None of those reports mention daemon/libvirtd.c and yet
> daemon/libvirtd.c | 24 +++-
> Index: libvirt-acl/daemon/libvirtd.c
>
Addressing the following reports:
Error: RESOURCE_LEAK:
/libvirt/src/nodeinfo.c:631:
alloc_fn: Calling allocation function "fopen".
/libvirt/src/nodeinfo.c:631:
var_assign: Assigning: "cpuinfo" = storage returned from
"fopen("/proc/cpuinfo", "r")".
/libvirt/src/nodeinfo.c:640:
leaked_storage:
From: "Daniel P. Berrange"
Currently the libvirt_lxc process uses VIR_DOMAIN_XML_INACTIVE
when loading the XML for the container. This means it looses
any dynamic data such as the, just allocated, SELinux label.
Further there is an inconsistency in the libvirt LXC driver
whereby it saves the liv
From: "Daniel P. Berrange"
Flesh out the section intros for each of the Libvirt GLib
library modules, providing using examples where needed, and
adding any missing function docs.
---
cfg.mk |2 +-
configure.ac|1 +
docs/libvirt
On 2012年04月28日 18:13, Guannan Ren wrote:
usbFindDevice():get usb device according to
idVendor, idProduct, bus, device
it is the most strict search
usbFindDevByBus():get usb device according to bus, device
it returns only one usb device same as
On 04/30/2012 06:48 PM, Eric Blake wrote:
> On 04/30/2012 06:17 AM, Kashyap Chamarthy wrote:
>> Hi (Eric?),
>>
>> I got a couple of questions for 'snapshot-create' / 'snapshot-create-as' :
>>
>>
>>
>> 1/ can '--disk-only' option (when used with virsh snapshot-create-as) be run
>> on an offline
>>
I changed everything on my previous patch to change 'defconfig', but
forgot to actually change the variable data type.
As the incomplete change doesn't cause any issues or compiler warnings,
I am simply sending this additional patch instead of respinning the
whole series.
Signed-off-by: Eduardo H
On 04/30/2012 06:17 AM, Kashyap Chamarthy wrote:
> Hi (Eric?),
>
> I got a couple of questions for 'snapshot-create' / 'snapshot-create-as' :
>
>
>
> 1/ can '--disk-only' option (when used with virsh snapshot-create-as) be run
> on an offline
> guest and generate an 'external snapshot' ?
Not
On 2012年04月28日 17:06, Michal Privoznik wrote:
On 28.04.2012 10:22, Osier Yang wrote:
It doesn't break out the "for" loop even if duplicate pool is
found, and thus the "matchpool" could be overriden as NULL again
if there is different pool afterwards.
To address the problem in libvirt-user list:
On Sat, Apr 28, 2012 at 07:53:41AM +, Blue Swirl wrote:
> On Tue, Apr 24, 2012 at 20:32, Eduardo Habkost wrote:
> > Signed-off-by: Eduardo Habkost
> > ---
> > vl.c | 4 ++--
> > 1 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/vl.c b/vl.c
> > index 1e5e593..a4f4676 10
Hi (Eric?),
I got a couple of questions for 'snapshot-create' / 'snapshot-create-as' :
1/ can '--disk-only' option (when used with virsh snapshot-create-as) be run on
an offline
guest and generate an 'external snapshot' ? Or a running guest is needed?
2/ Can anyone point me to a bit more ver
On Wed, Apr 25, 2012 at 11:47:17AM +0100, Daniel P. Berrange wrote:
> On Wed, Apr 25, 2012 at 12:43:09PM +0200, Wido den Hollander wrote:
> > The current storage pools for NFS and iSCSI only require one host to
> > connect to. Future storage pools like RBD and Sheepdog will require
> > multiple hos
On Sat, Apr 28, 2012 at 08:35:19PM -0700, Jason Helfman wrote:
> > Okay, I screwed up the tarball for the first stable release, due to not
> > building it from a fresh checkout :/ No changes for this one except a
> > version
> > bump and dist rebuild.
> >
> > This release can be downloaded at:
> >
On 04/28/2012 12:13 PM, Guannan Ren wrote:
> usbFindDevice():get usb device according to
> idVendor, idProduct, bus, device
> it is the most strict search
>
> usbFindDevByBus():get usb device according to bus, device
> it returns only one usb devic
42 matches
Mail list logo