Re: [libvirt] Error when running "virsh version" and "virt-manager"

2012-05-28 Thread Osier Yang
On 2012年05月28日 20:27, Shradha Shah wrote: At this point when I run the command "virsh version" I see the following output: Compiled against library: libvir 0.9.12 Using library: libvir 0.9.12 Using API: QEMU 0.9.12 error: failed to get the hypervisor version error: internal error Cannot find sui

Re: [libvirt] [PATCH] Fix memory leak

2012-05-28 Thread Osier Yang
On 2012年05月29日 06:18, Stefan Berger wrote: Fix the following memory leak: ==3240== 23 bytes in 1 blocks are definitely lost in loss record 242 of 744 ==3240== at 0x4C2A4CD: malloc (vg_replace_malloc.c:236) ==3240== by 0x8077537: __vasprintf_chk (vasprintf_chk.c:82) ==3240== by 0x509C677: virVasp

Re: [libvirt] Compiling Error

2012-05-28 Thread Alex Jia
On 05/29/2012 01:36 AM, Dipankar Sarma wrote: On Mon, May 28, 2012 at 11:13:23AM +0100, Daniel P. Berrange wrote: On Mon, May 28, 2012 at 02:24:16AM -0400, Alex Jia wrote: Hi all, I met some compiling error since May 26: make[3]: Entering directory `/home/ajia/Workspace/libvirt/src' CCLD

[libvirt] [PATCH] Fix memory leak

2012-05-28 Thread Stefan Berger
Fix the following memory leak: ==3240== 23 bytes in 1 blocks are definitely lost in loss record 242 of 744 ==3240==at 0x4C2A4CD: malloc (vg_replace_malloc.c:236) ==3240==by 0x8077537: __vasprintf_chk (vasprintf_chk.c:82) ==3240==by 0x509C677: virVasprintf (stdio2.h:199) ==3240==by

Re: [libvirt] Compiling Error

2012-05-28 Thread Dipankar Sarma
On Mon, May 28, 2012 at 11:13:23AM +0100, Daniel P. Berrange wrote: > On Mon, May 28, 2012 at 02:24:16AM -0400, Alex Jia wrote: > > Hi all, > > I met some compiling error since May 26: > > > > make[3]: Entering directory `/home/ajia/Workspace/libvirt/src' > > CCLD libvirt_driver_qemu.la > > li

Re: [libvirt] [PATCH V14 2/5] nwfilter: add DHCP snooping

2012-05-28 Thread Stefan Berger
On 05/25/2012 11:59 PM, Eric Blake wrote: +Since 0.9.12 s/12/13/ (hmm, sorry for the delays) No problem. +# define virNWFilterSnoopLock() \ +do { \ +virMutexLock(&virNWFilterSnoopState.snoopLock); \ +} while (0); Ouch. Lose the trailing ';', or you will cause problems with:

Re: [libvirt] [PATCH] build: silence libtool during tests

2012-05-28 Thread Eric Blake
On 05/28/2012 02:28 AM, Daniel P. Berrange wrote: > On Fri, May 25, 2012 at 01:25:46PM -0600, Eric Blake wrote: >> Libtool is picky about linking against a module library (aka a .so); >> giving lots of warnings like this in the tests directory: >> >> CCLD networkxml2argvtest >> >> *** Warning:

Re: [libvirt] [PATCH] Santize the reporting of VIR_ERR_INVALID_ERROR

2012-05-28 Thread Eric Blake
On 05/28/2012 07:34 AM, Daniel P. Berrange wrote: > On Fri, May 25, 2012 at 05:35:20PM -0600, Eric Blake wrote: >> On 05/25/2012 11:44 AM, Daniel P. Berrange wrote: >>> From: "Daniel P. Berrange" >>> >>> To ensure consistent error reporting of invalid arguments, >>> provide a number of predefined

Re: [libvirt] [Qemu-devel] [PATCH qemu 5/6] implement -no-user-config command-line option (v3)

2012-05-28 Thread Andreas Färber
Am 28.05.2012 08:35, schrieb Paolo Bonzini: > Il 27/05/2012 16:02, Andreas Färber ha scritto: >> Any suggestion how to fix? Sorry, I forgot to reply here that I've sent a patch. > Does it work to "typedef _Bool __bool" before including altivec.h (and > in the same #ifdef)? Haven't tried but I'm

Re: [libvirt] [Qemu-devel] [PATCH qemu 5/6] implement -no-user-config command-line option (v3)

2012-05-28 Thread Andreas Färber
Am 02.05.2012 18:07, schrieb Eduardo Habkost: > Changes v2 -> v3: > - Rebase against latest qemu.git > > Changes v1 -> v2: > - Change 'userconfig' field/variables to bool instead of int > - Coding style change > > Signed-off-by: Eduardo Habkost > --- > arch_init.c | 11 --- > q

[libvirt] [PATCH] Add some missing hook functions

2012-05-28 Thread Daniel P. Berrange
From: "Daniel P. Berrange" A core use case of the hook scripts is to be able to do things to a guest's network configuration. It is possible to hook into the 'start' operation for a QEMU guest which runs just before the guest is started. The TAP devices will exist at this point, but the QEMU proc

Re: [libvirt] [PATCH] Santize the reporting of VIR_ERR_INVALID_ERROR

2012-05-28 Thread Daniel P. Berrange
On Fri, May 25, 2012 at 05:35:20PM -0600, Eric Blake wrote: > On 05/25/2012 11:44 AM, Daniel P. Berrange wrote: > > From: "Daniel P. Berrange" > > > > To ensure consistent error reporting of invalid arguments, > > provide a number of predefined helper methods & macros. > > > > - An arg which mu

[libvirt] Error when running "virsh version" and "virt-manager"

2012-05-28 Thread Shradha Shah
Hello all, I have pulled the latest changes from the upstream libvirt repo as of today morning. I have then self-built and installed libvirt using the following commands (machine OS RHEL6.2): 1) ./autogen.sh --system --enable-compile-warnings=error 2) make 3) make install 4) service libvirtd r

Re: [libvirt] [PATCH] qemu: configurable VNC port boundaries for domains

2012-05-28 Thread Daniel P. Berrange
On Tue, May 22, 2012 at 04:10:03PM +0200, Martin Kletzander wrote: > The defines QEMU_VNC_PORT_MIN and QEMU_VNC_PORT_MAX were used to find > free port when starting domains. As this was hardcoded to the same > ports as default VNC servers, there were races with these other > programs. This patch in

Re: [libvirt] [PATCH] qemu: configurable VNC port boundaries for domains

2012-05-28 Thread Daniel P. Berrange
On Mon, May 28, 2012 at 03:18:33PM +0300, Dan Kenigsberg wrote: > On Wed, May 23, 2012 at 10:31:12AM +0100, Daniel P. Berrange wrote: > > On Tue, May 22, 2012 at 11:00:16AM -0400, Dave Allan wrote: > > > On Tue, May 22, 2012 at 04:10:03PM +0200, Martin Kletzander wrote: > > > > The defines QEMU_VNC

Re: [libvirt] [PATCH] qemu: configurable VNC port boundaries for domains

2012-05-28 Thread Dan Kenigsberg
On Wed, May 23, 2012 at 10:31:12AM +0100, Daniel P. Berrange wrote: > On Tue, May 22, 2012 at 11:00:16AM -0400, Dave Allan wrote: > > On Tue, May 22, 2012 at 04:10:03PM +0200, Martin Kletzander wrote: > > > The defines QEMU_VNC_PORT_MIN and QEMU_VNC_PORT_MAX were used to find > > > free port when s

[libvirt] [PATCH] Fix linking to DTrace probes file

2012-05-28 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Pushing as a build-fix There was no rule forcing libvirt_qemu_probes.o to be built before libvirt_qemu_probes.lo was used. Also libvirtd was still referencing the .o file, rather than the .lo file. Both the .lo and .o file must be listed as DEPENDENCIES, otherwise lib

[libvirt] [PATCH] Fix Win32 build by linking to ole32

2012-05-28 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Pushing as a build fix The CoTaskMemFree function requires the ole32 DLL to be linked against. Currently this is only done for the VirtualBox driver. Also add it to libvirt_util.la * configure.ac: Unconditionally add ole32 DLL to Win32 * src/Makefile.am: Link old32 to

[libvirt] [PATCH] docs: typo in acceleration element

2012-05-28 Thread Martin Kletzander
"accel3d" was specified twice, the second one is obviously "accel2d" --- Pushed under "trivial" rule. docs/formatdomain.html.in |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 3875167..5d4cc36 100644 --- a/docs/

Re: [libvirt] Compiling Error

2012-05-28 Thread Daniel P. Berrange
On Mon, May 28, 2012 at 02:24:16AM -0400, Alex Jia wrote: > Hi all, > I met some compiling error since May 26: > > make[3]: Entering directory `/home/ajia/Workspace/libvirt/src' > CCLD libvirt_driver_qemu.la > libtool: link: `libvirt_qemu_probes.lo' is not a valid libtool object I see that to

Re: [libvirt] [PATCH] Santize the reporting of VIR_ERR_INVALID_ERROR

2012-05-28 Thread Daniel P. Berrange
On Fri, May 25, 2012 at 05:35:20PM -0600, Eric Blake wrote: > > +# define virReportInvalidNullArg(argname)\ > > +virRaiseErrorFull(__FILE__, __FUNCTION__, __LINE__, \ > > + VIR_FROM_THIS, \ > > +

[libvirt] New Bugzilla components for upstream bug reporting

2012-05-28 Thread Daniel P. Berrange
Historically we have told people to report all upstream bugs against Product: Virtualization Tools Component: libvirt We now provide much more than just the core libvirt package though. Thus we have created a large number of new components for reporting upstream bugs against, one for each p

Re: [libvirt] [PATCH] build: work around mingw isatty issues

2012-05-28 Thread Daniel P. Berrange
On Fri, May 25, 2012 at 10:03:28PM -0600, Eric Blake wrote: > On 05/07/2012 04:24 PM, Eric Blake wrote: > > Gnulib finally relaxed the isatty license, needed as first mentioned here: > > https://www.redhat.com/archives/libvir-list/2012-February/msg01022.html > > > > * .gnulib: Update to latest, fo

Re: [libvirt] [PATCH] build: silence libtool during tests

2012-05-28 Thread Daniel P. Berrange
On Fri, May 25, 2012 at 01:25:46PM -0600, Eric Blake wrote: > Libtool is picky about linking against a module library (aka a .so); > giving lots of warnings like this in the tests directory: > > CCLD networkxml2argvtest > > *** Warning: Linking the executable networkxml2argvtest against the l