[libvirt] [PATCH 8/9] conf: support partially-specified in parser and formatter

2012-08-04 Thread Laine Stump
Until now, all attributes in a parameter list that were acceptable for a particular type, were also required. There were no optional attributes. One of the aims of supporting in libvirt's virtual networks and portgroups is to allow specifying the group-wide parameters in the network's virtualpor

[libvirt] [PATCH 9/9] network: merge relevant virtualports rather than choosing one

2012-08-04 Thread Laine Stump
One of the original ideas behind allowing a in an interface definition as well as in the definition *and*one or more s within the network, was that guest-specific parameteres (like instanceid and interfaceid) could be given in the interface's virtualport, and more general things (portid, manageri

[libvirt] [PATCH 6/9] conf: make error returns from virDomainActualNetDefFormat consistent

2012-08-04 Thread Laine Stump
There was an error: label that simply did "return ret", but ret was defaulted to -1, and was never used other than setting it manually to 0 just before a non-error return. Aside from this, some of the error return paths used "goto error" and others used "return ret". This patch removes ret and the

[libvirt] [PATCH 5/9] conf: move virtPortProfile out of unions in virDomainNetDef

2012-08-04 Thread Laine Stump
virtPortProfile is now used by 4 different types of network devices (NETWORK, BRIDGE, DIRECT, and HOSTDEV), and it's getting cumbersome to replicate so much code in 4 different places just because each type has the virtPortProfile in a slightly different place. This patch puts a single virtPortProf

[libvirt] [PATCH 3/9] util: eliminate union in virNetDevVPortProfile

2012-08-04 Thread Laine Stump
virNetDevVPortProfile has (had) a type field that can be set to one of several values, and a union of several structs, one for each type. When a domain's interface object is of type "network", the domain config may not know beforehand which type of virtualport is going to be provided in the actual

[libvirt] [PATCH 2/9] util: add openvswitch case to virNetDevVPortProfileEqual

2012-08-04 Thread Laine Stump
This function was overlooked when openvswitch support was added. Fortunately it's only use for update-device, which is relatively new and seldom-used. --- src/util/virnetdevvportprofile.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/util/virnetdevvportprofile.c b/src/util/virnetde

[libvirt] [PATCH 7/9] conf: simplify Buffer Indentation in virDomainNetDefFormat

2012-08-04 Thread Laine Stump
This function has several calls to increase the buffer indent by 6, then decrease it again, then increase, then decrease. Additionally, there were several printfs that had 6 spaces at the beginning of the line. virDomainActualNetDefFormat, which is called by virDomainNetDefFormat, had similar ugli

[libvirt] [PATCH 4/9] util: utility functions for virNetDevVPortProfile

2012-08-04 Thread Laine Stump
This patch adds three utility functions that operate on virNetDevVPortProfile objects. * virNetDevVPortProfileCheckComplete() - verifies that all attributes required for the type of the given virtport are specified. * virNetDevVPortProfileCheckNoExtras() - verifies that there are no attri

[libvirt] [PATCH 1/9] util: make return value of virUUIDFormat and virMacAddrFormat useful

2012-08-04 Thread Laine Stump
Both of these functions returned void, but it's convenient for them to return a const char* of the char* that is passed in. This was you can call the function and use the result in the same expression/arg. --- src/util/uuid.c | 4 +++- src/util/uuid.h | 6 +++--- src/util/virmacaddr.c

[libvirt] [PATCH 0/9] network: properly support openvswitch in

2012-08-04 Thread Laine Stump
Although it's been possible (ever since openvswitch was added to libvirt in 0.9.11) for a libvirt network to use an openvswitch bridge (by adding ), the virtualport in the network would always have a default random interfaceid included, which would be re-used for all interfaces using that network,

[libvirt] [PATCH V3] Add proxy FS support to libvirt

2012-08-04 Thread M. Mohan Kumar
From: "M. Mohan Kumar" A new FS driver type 'proxy' is added to QEMU 9p server. This patch adds support for using proxy FS driver from libvirt. QEMU proxy FS driver uses socket for communicating between helper and qemu proxy FS driver. Proxy helper (a stand alone binary part of qemu) is invoked