[libvirt] Release candidate 2 of 0.10.2 is available

2012-09-20 Thread Daniel Veillard
I have just tagged the release candidate 2 version and provided tarball and rpms at ftp://libvirt.org/libvirt/ So far testing on rc1 is rather good, plus we fixed a number of small problems since them, so I'm rather positive about it, and unless there is last minute troubles I may push the rel

Re: [libvirt] [PATCH] Remove a redundant line in src/qemu/qemu_driver.c

2012-09-20 Thread Daniel Veillard
On Fri, Sep 21, 2012 at 11:50:08AM +0800, Tang Chen wrote: > Signed-off-by: Tang Chen > --- > src/qemu/qemu_driver.c |1 - > 1 file changed, 1 deletion(-) > > diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c > index 12ac15c..2f58eca 100644 > --- a/src/qemu/qemu_driver.c > +++ b/s

Re: [libvirt] [PATCH 2/2] network: backend for virNetworkUpdate of portgroups

2012-09-20 Thread Daniel Veillard
On Thu, Sep 20, 2012 at 10:25:41PM -0400, Laine Stump wrote: > portgroup elements are located in the toplevel of > objects. There can be multiple elements, and they each > have a unique name attribute. > > Add, delete, and modify are all supported for portgroup. When deleting > a portgroup, only

Re: [libvirt] [PATCH 1/2] network: backend for virNetworkUpdate of dhcp range

2012-09-20 Thread Daniel Veillard
On Thu, Sep 20, 2012 at 10:25:40PM -0400, Laine Stump wrote: > The dhcp range element is contained in the element of one of a > network's elements. There can be multiple > elements. Because there are only two attributes (start and end), and > those are exactly what you would use to identify a pa

[libvirt] [PATCH] Remove a redundant line in src/qemu/qemu_driver.c

2012-09-20 Thread Tang Chen
Signed-off-by: Tang Chen --- src/qemu/qemu_driver.c |1 - 1 file changed, 1 deletion(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 12ac15c..2f58eca 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -4050,7 +4050,6 @@ qemudDomainPinEmulator(virDomainP

Re: [libvirt] [PATCH] simplify xenXMDomainPinVcpu function

2012-09-20 Thread liguang
Hi, Peter 在 2012-09-20四的 14:07 +0200,Peter Krempa写道: > On 09/20/12 07:31, liguang wrote: > > supersede tedious statements getting cpu bitmap > > from parameter cpumap by virBitmapNewData function > > > > Signed-off-by: liguang > > --- > > src/xen/xm_internal.c | 38 +++

Re: [libvirt] TSC scaling interface to management

2012-09-20 Thread Marcelo Tosatti
On Fri, Sep 21, 2012 at 12:02:46AM +0300, Dor Laor wrote: > On 09/12/2012 06:39 PM, Marcelo Tosatti wrote: > > > > > >HW TSC scaling is a feature of AMD processors that allows a > >multiplier to be specified to the TSC frequency exposed to the guest. > > > >KVM also contains provision to trap TSC (

[libvirt] [PATCH 2/2] network: backend for virNetworkUpdate of portgroups

2012-09-20 Thread Laine Stump
portgroup elements are located in the toplevel of objects. There can be multiple elements, and they each have a unique name attribute. Add, delete, and modify are all supported for portgroup. When deleting a portgroup, only the name must be specified in the provided xml - all other attributes an

[libvirt] [PATCH 1/2] network: backend for virNetworkUpdate of dhcp range

2012-09-20 Thread Laine Stump
The dhcp range element is contained in the element of one of a network's elements. There can be multiple elements. Because there are only two attributes (start and end), and those are exactly what you would use to identify a particular range, it doesn't really make sense to modify an existing el

[libvirt] [PATCH 0/2] network: virNetworkUpdate section backends

2012-09-20 Thread Laine Stump
These patches are the backends for ip-dhcp-range and portgroups. Since virsh, the bridge driver, and the toplevel of the NetworkObj function of virNetworkUpdate already support all sections, only the lowest level routine in network_conf.c needs to be modified (an "unsupported" error log is replaced

Re: [libvirt] [PATCH] virsh: new net-update command

2012-09-20 Thread Laine Stump
On 09/20/2012 12:55 PM, Eric Blake wrote: > On 09/20/2012 09:05 AM, Laine Stump wrote: >> This new virsh command uses the new virNetworkUpdate() API to modify >> an existing network definition, and optionally have those >> modifications take effect immediately without restarting the network. >> >>

[libvirt] [PATCH] docs: fix typo in filesystem docs

2012-09-20 Thread Eric Blake
Noticed this by reading the page. It would be so much nicer if our tools could automatically flag things like this as part of 'make'. * docs/formatdomain.html.in: Remove extra '>'. --- Pushing under the trivial rule. docs/formatdomain.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(

[libvirt] [PATCH] blockdev: preserve readonly and snapshot states across media changes

2012-09-20 Thread Kevin Shanahan
If readonly=on is given at device creation time, the ->readonly flag needs to be set in the block driver state for this device so that readonly-ness is preserved across media changes (qmp change command). Similarly, to preserve the snapshot property requires ->open_flags to be correct. Signed-off-

[libvirt] [PATCH] maint: fix up copyright notice inconsistencies

2012-09-20 Thread Eric Blake
https://www.gnu.org/licenses/gpl-howto.html recommends that the 'If not, see .' phrase be a separate sentence. * tests/securityselinuxhelper.c: Remove doubled line. * tests/securityselinuxtest.c: Likewise. * globally: s/; If/. If/ --- Pushing under the trivial rule. Eliding most of this email,

Re: [libvirt] [PATCH 02/29] Add a test suite for validating SELinux labelling

2012-09-20 Thread Eric Blake
On 09/20/2012 09:01 AM, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > There are many aspects of the guest XML which result in the > SELinux driver applying file labelling. With the increasing > configuration options it is desirable to test this behaviour. > It is not possible to assu

Re: [libvirt] [PATCH] doc: include article about libvirt+audit in relatedlinks.html

2012-09-20 Thread Eric Blake
On 09/20/2012 03:31 PM, Marcelo Cerri wrote: > This patch adds to relatedlinks.html a link to an article about libvirt > describing how the Linux audit subsystem can be used to track qemu > guest's life-cycle. > --- > > This is an article that I wrote sometime ago that I think that can be > useful

Re: [libvirt] [PATCH 01/29] Add some autoconf helper macros for checking for libraries

2012-09-20 Thread Eric Blake
On 09/20/2012 09:01 AM, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > Most checks for libraries take the same format > > * --with-libFOO=yes|no|check|/some/path argument > * check for a function NNN in libFOO.so > * check for a header file DDD/HHH.h > * Define a WITH_FOO co

[libvirt] [PATCH] doc: include article about libvirt+audit in relatedlinks.html

2012-09-20 Thread Marcelo Cerri
This patch adds to relatedlinks.html a link to an article about libvirt describing how the Linux audit subsystem can be used to track qemu guest's life-cycle. --- This is an article that I wrote sometime ago that I think that can be useful for many people that make use of libvirt. docs/relatedli

[libvirt] [PATCH v2 2/2] doc: update description about security labels on formatdomain.html

2012-09-20 Thread Marcelo Cerri
This patch adds a brief description about labels for each security driver. --- docs/formatdomain.html.in | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index f05350e..ec57f4d 100644 --- a/docs/formatdomain.h

[libvirt] [PATCH v2 1/2] security: also parse user/group names instead of just IDs for DAC labels

2012-09-20 Thread Marcelo Cerri
The DAC driver is missing parsing of group and user names for DAC labels and currently just parses uid and gid. This patch extends it to support names, so the following security label definition is now valid: qemu:qemu qemu:qemu When it tries to parse an owner or a group, it fir

[libvirt] [PATCH v2 0/2] security: support for names on DAC labels

2012-09-20 Thread Marcelo Cerri
This patch series extends label parsing for DAC security driver and updates the related documentation. Marcelo Cerri (2): security: also parse user/group names instead of just IDs for DAC labels doc: update description about security labels on formatdomain.html docs/formatdomain.html.in

Re: [libvirt] TSC scaling interface to management

2012-09-20 Thread Dor Laor
On 09/12/2012 06:39 PM, Marcelo Tosatti wrote: HW TSC scaling is a feature of AMD processors that allows a multiplier to be specified to the TSC frequency exposed to the guest. KVM also contains provision to trap TSC ("KVM: Infrastructure for software and hardware based TSC rate scaling" cc578

Re: [libvirt] [PATCH] qemu: Fix failure path in disk hotplug

2012-09-20 Thread Eric Blake
On 09/20/2012 02:35 PM, Jiri Denemark wrote: > Disk hotplug is a two phase action: qemuMonitorAddDrive followed by > qemuMonitorAddDevice. When the first part succeeds but the second one > fails, we need to rollback the drive addition. > --- > src/qemu/qemu_hotplug.c | 14 ++ > 1 file

[libvirt] [PATCH] qemu: Fix failure path in disk hotplug

2012-09-20 Thread Jiri Denemark
Disk hotplug is a two phase action: qemuMonitorAddDrive followed by qemuMonitorAddDevice. When the first part succeeds but the second one fails, we need to rollback the drive addition. --- src/qemu/qemu_hotplug.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/s

[libvirt] [PATCH 10/12] Add a JSON properties parameter to virLogOutputFunc

2012-09-20 Thread Miloslav Trmač
... and update all users. No change in functionality, the parameter will be used in the next patch. Signed-off-by: Miloslav Trmač --- src/util/logging.c | 20 +++- src/util/logging.h | 2 ++ tests/testutils.c | 1 + 3 files changed, 14 insertions(+), 9 deletions(-) diff --gi

[libvirt] [PATCH 09/12] Add a JSON properties parameter to virLog{, V}Message

2012-09-20 Thread Miloslav Trmač
... and update all users. No change in functionality, the parameter will be used in later patches. Signed-off-by: Miloslav Trmač --- src/uml/uml_conf.c | 2 +- src/util/logging.c | 13 + src/util/logging.h | 17 + src/util/viraudit.c | 4 ++-- src/util/virte

[libvirt] [PATCH 12/12] Add a test for the new error reporting mechanism.

2012-09-20 Thread Miloslav Trmač
Signed-off-by: Miloslav Trmač --- src/libvirt_private.syms | 4 + tests/Makefile.am| 6 +- tests/errorjsontest.c| 211 +++ 3 files changed, 220 insertions(+), 1 deletion(-) create mode 100644 tests/errorjsontest.c diff --git a/src/libv

[libvirt] [PATCH 07/12] Split priority conversion from virLogOutputToSyslog

2012-09-20 Thread Miloslav Trmač
No change in functionality; the newly separated virLogPrioritySyslog function will be used by the next patch. Signed-off-by: Miloslav Trmač --- src/util/logging.c | 36 +--- 1 file changed, 17 insertions(+), 19 deletions(-) diff --git a/src/util/logging.c b/src/u

[libvirt] [PATCH 11/12] Add detailed error information to JSON syslog

2012-09-20 Thread Miloslav Trmač
When logging an error, don't throw away the detailed information. Example record when using the syslog/json output (line-wrapped for readability): Sep 18 17:03:24 kulicka libvirt: @cee: {"msg":"Domain not found", "category":"../../src/test/test_driver.c","priority":"err", "funcname

[libvirt] [PATCH 06/12] Pass the "raw" log message to each virLogOutputFunc

2012-09-20 Thread Miloslav Trmač
In addition to the preformatted text line, pass the raw message as well, to allow the output functions to use a different output format. This patch only changes the interface and callers, an output function that takes advantage of this will follow. Signed-off-by: Miloslav Trmač --- src/util/log

[libvirt] [PATCH 08/12] Add "syslog/json" log output format.

2012-09-20 Thread Miloslav Trmač
Add a "syslog/json" output format, which uses a JSON representation (as specified in Lumberjack project, and planned for the CEE standard) to format individual components, making the result easy to parse without writing custom code or using unreliable regexps. Example message (line-wrapped for rea

[libvirt] [PATCH 02/12] Add JSON API for preallocated objects.

2012-09-20 Thread Miloslav Trmač
Add a JSON API that allows creating a JSON data structure within variables preallocated on the stack, without allocating memory in the heap. Signed-off-by: Miloslav Trmač --- src/util/json.c | 82 + src/util/json.h | 11 2 files ch

[libvirt] [PATCH 00/12] Structured syslog (Lumberjack/CEE) support

2012-09-20 Thread Miloslav Trmač
This patch set adds structured syslog support to libvirt. In short, the idea is to embed JSON in a syslog record. This format is used in a new log output type called "syslog/json". Example "syslog/json" record (line-wrapped for readability): Sep 20 19:59:40 kulicka libvirt: @cee: {"msg":"libvir

[libvirt] [PATCH 05/12] Add a JSON generator API.

2012-09-20 Thread Miloslav Trmač
This allows incremental use of virJSONStringGeneratorAddProperties without constructing a full object first, while isolating the rest of libvirt from the yajl dependency. Will be used later. Signed-off-by: Miloslav Trmač --- src/util/json.c | 60 +

[libvirt] [PATCH 03/12] Split yajl_gen allocation into a separate function.

2012-09-20 Thread Miloslav Trmač
Split yajl_gen (and handling of the yajl version differences) into virYAJLInit(). No functionality changed; the function will be used in a later patch. Signed-off-by: Miloslav Trmač --- src/util/json.c | 35 ++- 1 file changed, 22 insertions(+), 13 deletions(-)

[libvirt] [PATCH 01/12] Drop unused return value of virLogOutputFunc

2012-09-20 Thread Miloslav Trmač
Nothing uses the return value, and creating it requries otherwise unnecessary strlen () calls. This cleanup is conceptually independent from the rest of the series (although the later patches won't apply without it). This just seems a good opportunity to clean this up, instead of entrenching the

[libvirt] [PATCH 04/12] Split adding object properties from virJSONValueToStringOne

2012-09-20 Thread Miloslav Trmač
No functionality change (well, the index is now a size_t instead of int), the function will be used later. Signed-off-by: Miloslav Trmač --- src/util/json.c | 35 ++- src/util/json.h | 12 2 files changed, 38 insertions(+), 9 deletions(-) diff --git

Re: [libvirt] [PATCH] security: also parse user/group names instead of just IDs for DAC labels

2012-09-20 Thread Eric Blake
On 09/20/2012 08:46 AM, Daniel P. Berrange wrote: >> You still didn't answer my bigger question - when migrating, do we care >> about the case where the same user name has different uid on the two >> machines, and if so, do we make it possible for the user to choose >> between migrating with const

Re: [libvirt] [PATCH] security: also parse user/group names instead of just IDs for DAC labels

2012-09-20 Thread Marcelo Cerri
On Thu, Sep 20, 2012 at 02:53:52PM +0200, Peter Krempa wrote: > On 09/19/12 23:32, Marcelo Cerri wrote: > >The DAC driver is missing parsing of group and user names for DAC labels > >and currently just parses uid and gid. This patch extends it to support > >names, so the following security label de

Re: [libvirt] [PATCH] security: also parse user/group names instead of just IDs for DAC labels

2012-09-20 Thread Marcelo Cerri
On Thu, Sep 20, 2012 at 08:43:35AM -0600, Eric Blake wrote: > On 09/20/2012 07:31 AM, Marcelo Cerri wrote: > >>> possible ambiguities (since it is legal [although stupid] to have a user > >>> name consisting of all digits and worse having the name differ from the > >>> underlying uid), > > >> The

Re: [libvirt] [PATCH] virsh: new net-update command

2012-09-20 Thread Eric Blake
On 09/20/2012 09:05 AM, Laine Stump wrote: > This new virsh command uses the new virNetworkUpdate() API to modify > an existing network definition, and optionally have those > modifications take effect immediately without restarting the network. > > An example usage: > > virsh net-update mynet

[libvirt] [PATCHv7.5 9/9] blockjob: relabel entire existing chain

2012-09-20 Thread Eric Blake
When using block copy to pivot over to a new chain, the backing files for the new chain might still need labeling (particularly if the user passes --reuse-ext with a relative backing file name). Relabeling a file that is already labeled won't hurt, so this just labels the entire chain at the point

[libvirt] [PATCH v3 0/2] Add to character devices.

2012-09-20 Thread Richard W.M. Jones
Previous discussion: https://www.redhat.com/archives/libvir-list/2012-September/thread.html#01037 This adds to character devices' elements, like this: I tested it by controlling the labelling of the libguestfs console socket (when unlabelled, SELinux pre

[libvirt] [PATCH v3 1/2] Make virSecurityDeviceLabelDefParseXML into generic device parser.

2012-09-20 Thread Richard W.M. Jones
From: "Richard W.M. Jones" This is just code motion, allowing us to reuse the same function to parse the from character devices too. --- src/conf/domain_conf.c | 36 +++- 1 file changed, 19 insertions(+), 17 deletions(-) diff --git a/src/conf/domain_conf.c b/s

[libvirt] [PATCH v3 2/2] Add to character devices.

2012-09-20 Thread Richard W.M. Jones
From: "Richard W.M. Jones" This allows the user to control labelling of each character device separately (the default is to inherit from the VM). --- docs/formatdomain.html.in |8 src/conf/domain_conf.c | 77 +-- src/conf/domain_conf.h

Re: [libvirt] [PATCH 00/29] Add selinux test & refactor configure.ac

2012-09-20 Thread Eric Blake
On 09/20/2012 09:01 AM, Daniel P. Berrange wrote: > This is an expanded version of this series which added a new > SELinux test case > > https://www.redhat.com/archives/libvir-list/2012-September/msg01381.html > > The change here is to fix some bugs in the previous autoconf > macros, and dramat

[libvirt] [PATCHv2 2/2] virsh: new net-update command (two string version)

2012-09-20 Thread Laine Stump
This new virsh command uses the new virNetworkUpdate() API to modify an existing network definition, and optionally have those modifications take effect immediately without restarting the network. An example usage: virsh net-update mynet add-last ip-dhcp-host \ --xml "" \ --live --config

[libvirt] [PATCH 13/29] Convert apparmor check to use LIBVIRT_CHECK_LIB

2012-09-20 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Signed-off-by: Daniel P. Berrange --- configure.ac| 70 +++-- m4/virt-apparmor.m4 | 19 +++ 2 files changed, 23 insertions(+), 66 deletions(-) create mode 100644 m4/virt-apparmor.m4 diff --git a/con

[libvirt] [PATCH 23/29] Convert avahi check to use LIBVIRT_CHECK_PKG

2012-09-20 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Signed-off-by: Daniel P. Berrange --- configure.ac | 34 ++ m4/virt-avahi.m4 | 9 + 2 files changed, 11 insertions(+), 32 deletions(-) create mode 100644 m4/virt-avahi.m4 diff --git a/configure.ac b/configure.ac index f3e

[libvirt] [PATCH 17/29] Convert cap-ng check to use LIBVIRT_CHECK_LIB

2012-09-20 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Signed-off-by: Daniel P. Berrange --- configure.ac | 47 ++- m4/virt-capng.m4 | 9 + 2 files changed, 11 insertions(+), 45 deletions(-) create mode 100644 m4/virt-capng.m4 diff --git a/configure.ac b/configure

[libvirt] [PATCH 28/29] Convert HAVE_LIBBLKID to WITH_LIBBLKID

2012-09-20 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Signed-off-by: Daniel P. Berrange --- configure.ac | 4 ++-- src/Makefile.am | 6 +++--- src/lxc/lxc_container.c | 8 src/storage/storage_backend_fs.c | 8 4 files changed, 13 insertions(+), 13 deletions(

[libvirt] [PATCH 16/29] Convert HAVE_CAPNG to WITH_CAPNG

2012-09-20 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Signed-off-by: Daniel P. Berrange --- configure.ac | 4 ++-- src/lxc/lxc_container.c | 4 ++-- src/lxc/lxc_controller.c | 4 ++-- src/util/command.c | 4 ++-- src/util/util.c | 2 +- 5 files changed, 9 insertions(+), 9 deletions(-) diff --

[libvirt] [PATCH 19/29] Convert netcf check to use LIBVIRT_CHECK_PKG

2012-09-20 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Signed-off-by: Daniel P. Berrange --- configure.ac | 42 ++ m4/virt-netcf.m4 | 23 +++ 2 files changed, 25 insertions(+), 40 deletions(-) create mode 100644 m4/virt-netcf.m4 diff --git a/configure.ac b/

[libvirt] [PATCHv2 0/2] two different possibilities for virsh net-update command

2012-09-20 Thread Laine Stump
The two following patches are alternate approaches that each have a slightly different commandline syntax. In V1 of the net-update patch, I tried having a single string option that could contain either an xml string, or the name of a file containing an xml string, then two options that would be us

[libvirt] [PATCH 25/29] Convert udev/pciaccess checks to use LIBVIRT_CHECK_PKG

2012-09-20 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Signed-off-by: Daniel P. Berrange --- configure.ac | 55 ++-- m4/virt-pciaccess.m4 | 9 + m4/virt-udev.m4 | 15 ++ 3 files changed, 26 insertions(+), 53 deletions(-) create mode 100644

[libvirt] [PATCH] virsh: new net-update command

2012-09-20 Thread Laine Stump
This new virsh command uses the new virNetworkUpdate() API to modify an existing network definition, and optionally have those modifications take effect immediately without restarting the network. An example usage: virsh net-update mynet add-last ip-dhcp-host \ "" \ --live --config If yo

[libvirt] [PATCH 02/29] Add a test suite for validating SELinux labelling

2012-09-20 Thread Daniel P. Berrange
From: "Daniel P. Berrange" There are many aspects of the guest XML which result in the SELinux driver applying file labelling. With the increasing configuration options it is desirable to test this behaviour. It is not possible to assume that the test suite has the ability to set SELinux labels.

[libvirt] [PATCH 20/29] Convert HAVE_DBUS to WITH_DBUS

2012-09-20 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Signed-off-by: Daniel P. Berrange --- configure.ac | 4 ++-- src/nwfilter/nwfilter_driver.c | 4 ++-- src/util/virdbus.c | 6 +++--- src/util/virdbus.h | 2 +- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/con

[libvirt] [PATCH 27/29] Convert HAL check to use LIBVIRT_CHECK_PKG

2012-09-20 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Signed-off-by: Daniel P. Berrange --- configure.ac | 47 ++- m4/virt-hal.m4 | 9 + 2 files changed, 11 insertions(+), 45 deletions(-) create mode 100644 m4/virt-hal.m4 diff --git a/configure.ac b/configure.ac in

[libvirt] [PATCH 26/29] Convert HAVE_HAL to WITH_HAL

2012-09-20 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Signed-off-by: Daniel P. Berrange --- configure.ac | 4 ++-- src/Makefile.am | 2 +- src/node_device/node_device_driver.c | 6 +++--- src/node_device/node_device_driver.h | 2 +- 4 files changed, 7 insertions(+), 7 deletion

[libvirt] [PATCH 15/29] Convert numactl checks to use LIBVIRT_CHECK_LIB

2012-09-20 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Signed-off-by: Daniel P. Berrange --- configure.ac | 53 - m4/virt-numactl.m4 | 9 + 2 files changed, 13 insertions(+), 49 deletions(-) create mode 100644 m4/virt-numactl.m4 diff --git a/configure.ac

[libvirt] [PATCH 29/29] Convert libblkid check over to use LIBVIRT_CHECK_PKG

2012-09-20 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Signed-off-by: Daniel P. Berrange --- configure.ac| 22 ++ m4/virt-libblkid.m4 | 9 + 2 files changed, 11 insertions(+), 20 deletions(-) create mode 100644 m4/virt-libblkid.m4 diff --git a/configure.ac b/configure.ac index b6a19b

[libvirt] [PATCH 24/29] Convert HAVE_UDEV to WITH_UDEV

2012-09-20 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Signed-off-by: Daniel P. Berrange --- configure.ac | 4 ++-- src/Makefile.am | 2 +- src/node_device/node_device_driver.c | 4 ++-- src/node_device/node_device_driver.h | 2 +- src/storage/storage_backend_scsi.c | 4 ++--

[libvirt] [PATCH 14/29] Convert HAVE_NUMACTL to WITH_NUMACTL

2012-09-20 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Signed-off-by: Daniel P. Berrange --- configure.ac | 4 ++-- docs/hacking.html.in | 2 +- src/lxc/lxc_controller.c | 4 ++-- src/nodeinfo.c | 10 +- src/qemu/qemu_process.c | 4 ++-- 5 files changed, 12 insertions(+), 12 deletion

[libvirt] [PATCH 18/29] Add LIBVIRT_CHECK_PKG wrapper around pkg-config

2012-09-20 Thread Daniel P. Berrange
From: "Daniel P. Berrange" To simplify use of PKG_CHECK_MODULES in association with a --with-XXX arg, introduce LIBVIRT_CHECK_PKG Signed-off-by: Daniel P. Berrange --- m4/virt-lib.m4 | 56 1 file changed, 56 insertions(+) diff --git a/m

[libvirt] [PATCH 10/29] Convert audit check to use LIBVIRT_CHECK_LIB

2012-09-20 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Signed-off-by: Daniel P. Berrange --- configure.ac | 51 ++- m4/virt-audit.m4 | 9 + 2 files changed, 11 insertions(+), 49 deletions(-) create mode 100644 m4/virt-audit.m4 diff --git a/configure.ac b/confi

[libvirt] [PATCH 11/29] Convert HAVE_SELINUX to WITH_SELINUX

2012-09-20 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Signed-off-by: Daniel P. Berrange --- configure.ac | 4 ++-- src/lxc/lxc_container.c | 2 +- src/storage/storage_backend.c | 6 +++--- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/configure.ac b/configure.ac index fd214eb..c3b2

[libvirt] [PATCH 04/29] Convert yajl check to use LIBVIRT_CHECK_LIB_FALLBACK

2012-09-20 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Signed-off-by: Daniel P. Berrange --- configure.ac| 86 ++--- m4/virt-yajl.m4 | 34 +++ 2 files changed, 36 insertions(+), 84 deletions(-) create mode 100644 m4/virt-yajl.m4 diff --git a/con

[libvirt] [PATCH 22/29] Convert HAVE_AVAHI to WITH_AVAHI

2012-09-20 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Signed-off-by: Daniel P. Berrange --- configure.ac | 2 +- src/rpc/virnetservermdns.c | 12 ++-- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/configure.ac b/configure.ac index 6f4fa90..f3e82d0 100644 --- a/configure.ac +++ b/co

[libvirt] [PATCH 21/29] Convert DBus check to use LIBVIRT_CHECK_PKG

2012-09-20 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Signed-off-by: Daniel P. Berrange --- configure.ac| 34 ++ m4/virt-dbus.m4 | 19 +++ 2 files changed, 21 insertions(+), 32 deletions(-) create mode 100644 m4/virt-dbus.m4 diff --git a/configure.ac b/configure.ac in

[libvirt] [PATCH 06/29] Convert sanlock check to use LIBVIRT_CHECK_LIB

2012-09-20 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Signed-off-by: Daniel P. Berrange --- configure.ac | 57 ++ m4/virt-sanlock.m4 | 9 + 2 files changed, 11 insertions(+), 55 deletions(-) create mode 100644 m4/virt-sanlock.m4 diff --git a/configure.a

[libvirt] [PATCH 05/29] Convert HAVE_SANLOCK to WITH_SANLOCK

2012-09-20 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Signed-off-by: Daniel P. Berrange --- configure.ac | 4 ++-- src/Makefile.am | 8 tools/Makefile.am | 4 ++-- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/configure.ac b/configure.ac index ef07386..ccd6480 100644 --- a/configure.ac ++

[libvirt] [PATCH 03/29] Convert HAVE_YAJL into WITH_YAJL

2012-09-20 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Signed-off-by: Daniel P. Berrange --- configure.ac | 6 +++--- src/qemu/qemu_capabilities.c | 2 +- src/qemu/qemu_driver.c | 4 ++-- src/util/json.c | 14 +++--- tests/Makefile.am| 2 +- tests/qemuhelptest.c

[libvirt] [PATCH 01/29] Add some autoconf helper macros for checking for libraries

2012-09-20 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Most checks for libraries take the same format * --with-libFOO=yes|no|check|/some/path argument * check for a function NNN in libFOO.so * check for a header file DDD/HHH.h * Define a WITH_FOO config.h symbol * Define a WITH_FOO make conditional * Substitut

[libvirt] [PATCH 00/29] Add selinux test & refactor configure.ac

2012-09-20 Thread Daniel P. Berrange
This is an expanded version of this series which added a new SELinux test case https://www.redhat.com/archives/libvir-list/2012-September/msg01381.html The change here is to fix some bugs in the previous autoconf macros, and dramatically expand their usage, removing ~700 lines of code from conf

[libvirt] [PATCH 09/29] Convert HAVE_AUDIT to WITH_AUDIT

2012-09-20 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Signed-off-by: Daniel P. Berrange --- configure.ac| 4 ++-- src/util/viraudit.c | 14 +++--- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/configure.ac b/configure.ac index f173c63..dbef499 100644 --- a/configure.ac +++ b/configure.ac

[libvirt] [PATCH 12/29] Convert selinux check to use LIBVIRT_CHECK_LIB

2012-09-20 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Signed-off-by: Daniel P. Berrange --- configure.ac | 63 ++ m4/virt-selinux.m4 | 33 2 files changed, 35 insertions(+), 61 deletions(-) create mode 100644 m4/virt-selinux.m4 diff

[libvirt] [PATCH 07/29] Convert HAVE_SASL to WITH_SASL

2012-09-20 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Signed-off-by: Daniel P. Berrange --- configure.ac | 4 ++-- daemon/Makefile.am | 2 +- daemon/libvirtd-config.c | 4 ++-- daemon/libvirtd.c| 4 ++-- daemon/libvirtd.h| 6 +++--- daemon/remote.c |

[libvirt] [PATCH 08/29] Convert sasl check to use LIBVIRT_CHECK_LIB_FALLBACK

2012-09-20 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Signed-off-by: Daniel P. Berrange --- configure.ac| 62 ++--- m4/virt-sasl.m4 | 12 +++ 2 files changed, 14 insertions(+), 60 deletions(-) create mode 100644 m4/virt-sasl.m4 diff --git a/configure.ac b/

Re: [libvirt] [PATCH v2 1/3] Add support for limiting guest coredump

2012-09-20 Thread Martin Kletzander
On 09/20/2012 02:54 PM, Michal Privoznik wrote: > On 20.09.2012 10:58, Martin Kletzander wrote: >> Sometimes when guest machine crashes, coredump can get huge due to the >> guest memory. This can be limited using madvise(2) system call and is >> being used in QEMU hypervisor. This patch adds an opt

Re: [libvirt] [PATCH v2 3/3] tests: Add tests for dump-core option

2012-09-20 Thread Martin Kletzander
On 09/20/2012 02:54 PM, Michal Privoznik wrote: > On 20.09.2012 10:58, Martin Kletzander wrote: >> --- >> tests/qemuargv2xmltest.c | 2 ++ >> .../qemuxml2argv-machine-core-off.args | 5 + >> .../qemuxml2argv-machine-core-off.xml | 26 >> +++

Re: [libvirt] [PATCH v2 3/3] QEMU Tests for reboot-timeout

2012-09-20 Thread Martin Kletzander
On 09/20/2012 11:59 AM, Peter Krempa wrote: > On 09/19/12 19:22, Martin Kletzander wrote: >> --- >> tests/qemuargv2xmltest.c| 4 >> .../qemuxml2argv-reboot-timeout-disabled.args | 3 +++ >> .../qemuxml2argv-reboot-timeout-disabled.xml| 21 >>

Re: [libvirt] [PATCH v2 2/3] qemu: add support for dump-guest-core option

2012-09-20 Thread Martin Kletzander
On 09/20/2012 02:54 PM, Michal Privoznik wrote: > On 20.09.2012 10:58, Martin Kletzander wrote: >> The "dump-guest-core' option is new option for the machine type >> (-machine pc,dump-guest-core) that controls whether the guest memory >> will be marked as dumpable. >> >> While testing this, I've fo

Re: [libvirt] [PATCH v2 1/3] Add support for reboot-timeout

2012-09-20 Thread Martin Kletzander
On 09/20/2012 11:54 AM, Peter Krempa wrote: > On 09/19/12 19:22, Martin Kletzander wrote: >> Whenever the guest machine fails to boot, new parameter (reboot-timeout) >> controls whether it should reboot and after how many ms it should do so. >> >> Docs included. >> --- >> docs/formatdomain.html.i

Re: [libvirt] [PATCH] security: also parse user/group names instead of just IDs for DAC labels

2012-09-20 Thread Daniel P. Berrange
On Thu, Sep 20, 2012 at 08:43:35AM -0600, Eric Blake wrote: > On 09/20/2012 07:31 AM, Marcelo Cerri wrote: > >>> possible ambiguities (since it is legal [although stupid] to have a user > >>> name consisting of all digits and worse having the name differ from the > >>> underlying uid), > > >> The

Re: [libvirt] [PATCH v2 2/3] qemu: Add support for reboot-timeout

2012-09-20 Thread Martin Kletzander
On 09/20/2012 03:32 PM, Peter Krempa wrote: > On 09/20/12 15:15, Martin Kletzander wrote: >> On 09/20/2012 12:22 PM, Peter Krempa wrote: @@ -8271,6 +8286,19 @@ virDomainDefPtr qemuParseCommandLine(virCapsPtr caps, qemuParseCommandLineBootDevs(def, token); >

Re: [libvirt] [PATCH] security: also parse user/group names instead of just IDs for DAC labels

2012-09-20 Thread Eric Blake
On 09/20/2012 07:31 AM, Marcelo Cerri wrote: >>> possible ambiguities (since it is legal [although stupid] to have a user >>> name consisting of all digits and worse having the name differ from the >>> underlying uid), >> The other option (that I prefer more) would be to document this >> behavior

Re: [libvirt] [PATCH] locking: Remove README file in favor of locking.html

2012-09-20 Thread Eric Blake
On 09/20/2012 06:56 AM, Jiri Denemark wrote: > The README file seems to be a leftover from some previous version of > locking driver. It is not consistent with what the code does nor is it > consistent with existing documentation in locking.html. > --- > src/locking/README | 165 > ---

Re: [libvirt] [PATCHv3] security: Don't ignore errors when parsing DAC security labels

2012-09-20 Thread Peter Krempa
On 09/20/12 16:04, Martin Kletzander wrote: On 09/19/2012 02:42 PM, Peter Krempa wrote: The DAC security driver silently ignored errors when parsing the DAC label and used default values instead. With a domain containing the following label definition: sdfklsdjlfjklsdjkl the domain would

Re: [libvirt] [libvirt-designer][PATCH 2/6] Create basic documentation

2012-09-20 Thread Christophe Fergeau
Hi, On Thu, Sep 20, 2012 at 04:18:47PM +0200, Michal Privoznik wrote: > On 19.09.2012 17:48, Christophe Fergeau wrote: > > On Tue, Sep 18, 2012 at 05:52:25PM +0200, Michal Privoznik wrote: > >> In fact, it's only bare skeleton for gtkdoc > > > > This seems to be missing a call to GTK_DOC_CHECK in

[libvirt] [libvirt-designer][PATCH v2] Create manpage for virtxml

2012-09-20 Thread Michal Privoznik
--- diff to v1: -move content from virtxml.pod to virtxml.c -wording and spelling as pointed out by Christophe .gitignore |1 + examples/Makefile.am |9 +++ examples/virtxml.c | 127 ++ libvirt-designer.spec.in |1 +

Re: [libvirt] [libvirt-designer][PATCH 2/6] Create basic documentation

2012-09-20 Thread Michal Privoznik
On 19.09.2012 17:48, Christophe Fergeau wrote: > On Tue, Sep 18, 2012 at 05:52:25PM +0200, Michal Privoznik wrote: >> In fact, it's only bare skeleton for gtkdoc > > This seems to be missing a call to GTK_DOC_CHECK in configure.ac, and > potentially DISTCHECK_CONFIGURE_FLAGS = --enable-gtk-doc=yes

Re: [libvirt] [PATCHv3] security: Don't ignore errors when parsing DAC security labels

2012-09-20 Thread Martin Kletzander
On 09/19/2012 02:42 PM, Peter Krempa wrote: > The DAC security driver silently ignored errors when parsing the DAC > label and used default values instead. > > With a domain containing the following label definition: > > > sdfklsdjlfjklsdjkl > > > the domain would start normaly but the disk

Re: [libvirt] [PATCH] security: also parse user/group names instead of just IDs for DAC labels

2012-09-20 Thread Marcelo Cerri
On Thu, Sep 20, 2012 at 03:00:17PM +0200, Peter Krempa wrote: > On 09/20/12 02:31, Eric Blake wrote: > >On 09/19/2012 03:32 PM, Marcelo Cerri wrote: > >>The DAC driver is missing parsing of group and user names for DAC labels > >>and currently just parses uid and gid. This patch extends it to suppo

Re: [libvirt] [PATCH v2 2/3] qemu: Add support for reboot-timeout

2012-09-20 Thread Peter Krempa
On 09/20/12 15:15, Martin Kletzander wrote: On 09/20/2012 12:22 PM, Peter Krempa wrote: @@ -8271,6 +8286,19 @@ virDomainDefPtr qemuParseCommandLine(virCapsPtr caps, qemuParseCommandLineBootDevs(def, token); } else if (STRPREFIX(token, "menu=on"))

Re: [libvirt] [PATCH v2 2/3] qemu: Add support for reboot-timeout

2012-09-20 Thread Martin Kletzander
On 09/20/2012 12:22 PM, Peter Krempa wrote: >> @@ -8271,6 +8286,19 @@ virDomainDefPtr qemuParseCommandLine(virCapsPtr >> caps, >> qemuParseCommandLineBootDevs(def, token); >> } else if (STRPREFIX(token, "menu=on")) { >> def->

Re: [libvirt] [PATCH] locking: Remove README file in favor of locking.html

2012-09-20 Thread Jiri Denemark
On Thu, Sep 20, 2012 at 14:56:33 +0200, Jiri Denemark wrote: > The README file seems to be a leftover from some previous version of > locking driver. It is not consistent with what the code does nor is it > consistent with existing documentation in locking.html. Hmm, we have two locking.html files

Re: [libvirt] [PATCH] security: also parse user/group names instead of just IDs for DAC labels

2012-09-20 Thread Peter Krempa
On 09/20/12 02:31, Eric Blake wrote: On 09/19/2012 03:32 PM, Marcelo Cerri wrote: The DAC driver is missing parsing of group and user names for DAC labels and currently just parses uid and gid. This patch extends it to support names, so the following security label definition is now valid:

[libvirt] [PATCH] locking: Remove README file in favor of locking.html

2012-09-20 Thread Jiri Denemark
The README file seems to be a leftover from some previous version of locking driver. It is not consistent with what the code does nor is it consistent with existing documentation in locking.html. --- src/locking/README | 165 - 1 file changed, 16

Re: [libvirt] [PATCH v2 1/3] Add support for limiting guest coredump

2012-09-20 Thread Michal Privoznik
On 20.09.2012 10:58, Martin Kletzander wrote: > Sometimes when guest machine crashes, coredump can get huge due to the > guest memory. This can be limited using madvise(2) system call and is > being used in QEMU hypervisor. This patch adds an option for configuring > that in the domain XML and rela

  1   2   >