On Fri, Oct 5, 2012 at 6:28 PM, Eric Blake wrote:
> On 10/05/2012 12:43 PM, Doug Goldstein wrote:
>> Add a read-only udev based backend for virInterface. Useful for distros
>> that do not have netcf support yet. Multiple libvirt based utilities use
>> a HAL based fallback when virInterface is not
The functions virGetUserID and virGetGroupID are now able to parse
user/group names and IDs in a similar way to coreutils' chown. So, user
and group parsing in security_dac can be simplified.
---
src/security/security_dac.c | 40 ++--
1 file changed, 10 insertio
This patch updates virGetUserID and virGetGroupID to be able to parse a
user or group name in a similar way to coreutils' chown. This means that
a numeric value with a leading plus sign is always parsed as an ID,
otherwise the functions try to parse the input first as a user or group
name and if th
This patch series moves the logic for parsing users and groups in a
similar way to coreutils' chown from security_dac.c to util.c, as
suggested by Eric Blake.
This change has two majors side effects:
1. Some error messages that were issued when security_dac.c tried to
parse an ID as a name a
On 10/05/2012 12:43 PM, Doug Goldstein wrote:
> Add a read-only udev based backend for virInterface. Useful for distros
> that do not have netcf support yet. Multiple libvirt based utilities use
> a HAL based fallback when virInterface is not available which is less
> than ideal. This implements:
>
On 10/06/2012 01:26 AM, Eric Blake wrote:
> On 10/05/2012 01:25 PM, Kashyap Chamarthy wrote:
>>>
>>> So, just to clarify, so I don't mess up, on libvirt's latest git, I'm
>>> applying only these
>>> two patches as below:
>>>
>>> [PATCH 1/2] blockjob: manage qemu block-commit monitor command
>>> [
On 10/05/2012 01:25 PM, Kashyap Chamarthy wrote:
>>
>> So, just to clarify, so I don't mess up, on libvirt's latest git, I'm
>> applying only these
>> two patches as below:
>>
>> [PATCH 1/2] blockjob: manage qemu block-commit monitor command
>> [PATCH 2/2] blockjob: wire up online qemu block-comm
On Fri, Oct 05, 2012 at 06:28:32AM -0600, Eric Blake wrote:
> On 10/05/2012 05:40 AM, Richard W.M. Jones wrote:
> > A simple implementation therefore would be to add a
> > element to . It would just add snapshot=on and ignore concerns
> > about $TMPDIR.
> >
> > Or reuse the flag? Note that the
On 10/06/2012 12:52 AM, Kashyap Chamarthy wrote:
> On 10/06/2012 12:34 AM, Eric Blake wrote:
>> On 10/05/2012 12:53 PM, Kashyap Chamarthy wrote:
>>
And Anthony just merged Jeff's patches into qemu.git today (now commit
ed61fc10), so I'll push this as soon as I complete another round
On 10/06/2012 12:34 AM, Eric Blake wrote:
> On 10/05/2012 12:53 PM, Kashyap Chamarthy wrote:
>
>>>
>>> And Anthony just merged Jeff's patches into qemu.git today (now commit
>>> ed61fc10), so I'll push this as soon as I complete another round of
>>> testing, as well as work towards proper SELinux
On 10/05/2012 12:53 PM, Kashyap Chamarthy wrote:
>
> Eric, Let me know how I can help you test here.
Other ideas of things to test - pass invalid arguments, and make sure
you get sane error messages (for example, a file that doesn't exist, or
omit --base, omit --top, specify --base and --top out
On 10/05/2012 12:53 PM, Kashyap Chamarthy wrote:
>>
>> And Anthony just merged Jeff's patches into qemu.git today (now commit
>> ed61fc10), so I'll push this as soon as I complete another round of
>> testing, as well as work towards proper SELinux behavior.
>
> Eric, Let me know how I can help yo
On 10/05/2012 02:51 PM, Eric Blake wrote:
On 10/05/2012 12:44 PM, Corey Bryant wrote:
Yes, this makes more sense. I'd like to mirror the add-fd QMP command
as much as possible:
{ 'command': 'add-fd', 'data': {'*fdset-id': 'int', '*opaque': 'str'},
'returns': 'AddfdInfo' }
So maybe we can
On 10/05/2012 08:33 PM, Eric Blake wrote:
> On 10/05/2012 08:00 AM, Michal Privoznik wrote:
>> On 04.10.2012 16:44, Eric Blake wrote:
>>> This is the bare minimum to kick off a block commit. In particular,
>>> flags support is missing (shallow requires us to crawl the backing
>>> chain to determin
On 10/05/2012 02:35 PM, Eric Blake wrote:
On 10/05/2012 12:07 PM, Corey Bryant wrote:
Currently, in order to use a file descriptor that resides in an
fd set, the access mode flag of the qemu_open() call has to be
an exact match of the access mode flag of an fd in the requested
fd set.
This pa
On 10/05/2012 12:44 PM, Corey Bryant wrote:
> Yes, this makes more sense. I'd like to mirror the add-fd QMP command
> as much as possible:
>
> { 'command': 'add-fd', 'data': {'*fdset-id': 'int', '*opaque': 'str'},
> 'returns': 'AddfdInfo' }
>
> So maybe we can make it:
>
> -add-fd fd=24,fdset
On 10/05/2012 02:25 PM, Blue Swirl wrote:
On Fri, Oct 5, 2012 at 6:07 PM, Corey Bryant wrote:
These new options can be used for passing drive file descriptors
on the command line, instead of using the file option to specify
a file name.
These new command line options mirror the existing add-
On 10/05/2012 02:30 PM, Eric Blake wrote:
On 10/05/2012 12:25 PM, Blue Swirl wrote:
On Fri, Oct 5, 2012 at 6:07 PM, Corey Bryant wrote:
These new options can be used for passing drive file descriptors
on the command line, instead of using the file option to specify
a file name.
These new co
Add a read-only udev based backend for virInterface. Useful for distros
that do not have netcf support yet. Multiple libvirt based utilities use
a HAL based fallback when virInterface is not available which is less
than ideal. This implements:
* virConnectNumOfInterfaces()
* virConnectListInterface
On 10/05/2012 02:26 PM, Eric Blake wrote:
On 10/05/2012 12:07 PM, Corey Bryant wrote:
This series adds command line file descriptor passing support
to the -drive option. This is a follow-on to the existing
QMP fd passing support provided in the following patch series:
comments.gmane.org/gmane
On 10/05/2012 12:25 PM, Blue Swirl wrote:
> On Fri, Oct 5, 2012 at 6:07 PM, Corey Bryant
> wrote:
>> These new options can be used for passing drive file descriptors
>> on the command line, instead of using the file option to specify
>> a file name.
>>
>> These new command line options mirror the
On 10/05/2012 12:07 PM, Corey Bryant wrote:
> Currently, in order to use a file descriptor that resides in an
> fd set, the access mode flag of the qemu_open() call has to be
> an exact match of the access mode flag of an fd in the requested
> fd set.
>
> This patch lightens up that restriction.
On Fri, Oct 5, 2012 at 6:07 PM, Corey Bryant wrote:
> These new options can be used for passing drive file descriptors
> on the command line, instead of using the file option to specify
> a file name.
>
> These new command line options mirror the existing add-fd QMP
> command which allows an fd to
On 10/05/2012 10:44 PM, Eric Blake wrote:
> On 10/05/2012 11:00 AM, Kashyap Chamarthy wrote:
>> On 10/05/2012 08:07 PM, Eric Blake wrote:
>>> On 10/05/2012 07:09 AM, Kashyap Chamarthy wrote:
Hi,
the below three internal snapshots were taken when the guest is running
'live'
On 10/05/2012 12:07 PM, Corey Bryant wrote:
> This series adds command line file descriptor passing support
> to the -drive option. This is a follow-on to the existing
> QMP fd passing support provided in the following patch series:
> comments.gmane.org/gmane.comp.emulators.qemu/165463
>
> An exa
Currently, in order to use a file descriptor that resides in an
fd set, the access mode flag of the qemu_open() call has to be
an exact match of the access mode flag of an fd in the requested
fd set.
This patch lightens up that restriction. For example, if QEMU
attempts to qemu_open() "/dev/fdset
These new options can be used for passing drive file descriptors
on the command line, instead of using the file option to specify
a file name.
These new command line options mirror the existing add-fd QMP
command which allows an fd to be passed to QEMU via SCM_RIGHTS and
added to an fd set. The o
qmp_add_fd() gets an fd that was received over a socket with
SCM_RIGHTS and adds it to an fd set. This patch adds support
that will enable adding an fd that was inherited on the
command line to an fd set.
This patch also prevents removal of an fd from an fd set during
initialization. This allows
This series adds command line file descriptor passing support
to the -drive option. This is a follow-on to the existing
QMP fd passing support provided in the following patch series:
comments.gmane.org/gmane.comp.emulators.qemu/165463
An example of using the new -drive fd and opaque options:
qemu
When an fd, and optionally opaque, are passed with -drive, they
are added to an automatically generated fd set. The file name
is also generated in the form of "/dev/fdset/nnn", where nnn is
the fd set ID. qemu_open() already knows how to handle a
filename of this format. qemu_open() searches the
On 10/05/2012 11:00 AM, Kashyap Chamarthy wrote:
> On 10/05/2012 08:07 PM, Eric Blake wrote:
>> On 10/05/2012 07:09 AM, Kashyap Chamarthy wrote:
>>>
>>> Hi,
>>>
>>> the below three internal snapshots were taken when the guest is running
>>> 'live'. Any hints
>>> on why the time to take snapshots k
On 10/05/2012 08:07 PM, Eric Blake wrote:
> On 10/05/2012 07:09 AM, Kashyap Chamarthy wrote:
>>
>> Hi,
>>
>> the below three internal snapshots were taken when the guest is running
>> 'live'. Any hints
>> on why the time to take snapshots keep increasing ?
>
> That's a question for qemu folks, as
On 10/05/2012 05:04 PM, Eric Blake wrote:
It doesn't hurt to go larger, say to 64k, if that will help prevent the
need to bump this again in the future. But I'm trusting you that your
choice of 8k is sufficient, as I don't have an s390 machine to test on, so:
ACK and pushed.
Thanks!
--
Mi
On 10/05/2012 07:59 AM, Viktor Mihajlovski wrote:
> The output buffer for virFileReadAll was too small for systems with
> more than 30 CPUs which leads to a log entry and incorrect behavior.
> The new size will be sufficient for the current
> architectural limits.
It doesn't hurt to go larger, say
On 10/05/2012 08:00 AM, Michal Privoznik wrote:
> On 04.10.2012 16:44, Eric Blake wrote:
>> This is the bare minimum to kick off a block commit. In particular,
>> flags support is missing (shallow requires us to crawl the backing
>> chain to determine the file name to pass to the qemu monitor comm
This reverts part of commit 5468594f4655d20674a9429a0671f6afa3538274;
the perl changes were sufficient. Since libvirt.syms is already a
generated file created from libvirt_private.syms, we don't need a
second pass over libvirt_private.syms in isolation.
---
Pushing under the build-breaker rule.
On 10/05/2012 08:42 AM, Eric Blake wrote:
> On 10/05/2012 07:05 AM, Michal Privoznik wrote:
>> Currently, we are checking if libvirt.so contains public symbols.
>> However, sometimes we rename an internal symbol and forget to
>> change libvirt_private.syms accordingly. Hence, it's safer to check
>>
On 10/05/2012 07:05 AM, Michal Privoznik wrote:
> Currently, we are checking if libvirt.so contains public symbols.
> However, sometimes we rename an internal symbol and forget to
> change libvirt_private.syms accordingly. Hence, it's safer to check
> for internal symbols as well.
> ---
> src/Make
On 10/05/2012 07:09 AM, Kashyap Chamarthy wrote:
>
> Hi,
>
> the below three internal snapshots were taken when the guest is running
> 'live'. Any hints
> on why the time to take snapshots keep increasing ?
That's a question for qemu folks, as it is a problem in qemu's 'savevm'
command and noth
Dear List,
Please note I am not subscribed to this list.
I just wanted to state my problem, and will wait for a fix when it comes.
I have sucessfully compiled libvirt-php-0.4.5 on Ubuntu 12.04. I ran into
some problems when
using the library in simple php code, specifically trying to retrieve a
s
On 04.10.2012 16:44, Eric Blake wrote:
> qemu 1.3 will be adding a 'block-commit' monitor command, per
> https://lists.gnu.org/archive/html/qemu-devel/2012-09/msg05199.html
> It matches nicely to the libvirt API virDomainBlockCommit.
>
> * src/qemu/qemu_capabilities.h (QEMU_CAPS_BLOCK_COMMIT): New
On 04.10.2012 16:44, Eric Blake wrote:
> This is the bare minimum to kick off a block commit. In particular,
> flags support is missing (shallow requires us to crawl the backing
> chain to determine the file name to pass to the qemu monitor command;
> delete requires us to track what needs to be d
The output buffer for virFileReadAll was too small for systems with
more than 30 CPUs which leads to a log entry and incorrect behavior.
The new size will be sufficient for the current
architectural limits.
Signed-off-by: Viktor Mihajlovski
---
src/util/sysinfo.c |4 ++--
1 files changed, 2
On 05.10.2012 15:13, Eric Blake wrote:
> On 10/05/2012 07:05 AM, Michal Privoznik wrote:
>> Currently, we are checking if libvirt.so contains public symbols.
>> However, sometimes we rename an internal symbol and forget to
>> change libvirt_private.syms accordingly. Hence, it's safer to check
>> fo
On 10/05/2012 07:05 AM, Michal Privoznik wrote:
> Currently, we are checking if libvirt.so contains public symbols.
> However, sometimes we rename an internal symbol and forget to
> change libvirt_private.syms accordingly. Hence, it's safer to check
> for internal symbols as well.
> ---
> src/Make
Hi,
the below three internal snapshots were taken when the guest is running 'live'.
Any hints
on why the time to take snapshots keep increasing ?
If you notice, the 2nd and 3rd internal snaphtots took more than 4 minutes each
(note:
there is no noticeable content change from snap1 )
#=
Currently, we are checking if libvirt.so contains public symbols.
However, sometimes we rename an internal symbol and forget to
change libvirt_private.syms accordingly. Hence, it's safer to check
for internal symbols as well.
---
src/Makefile.am |7 ++-
src/check-symfile.pl |2 +-
On 05.10.2012 14:23, Eric Blake wrote:
> On 10/05/2012 05:36 AM, Michal Privoznik wrote:
>> After it got renamed to virProcessKill (cf470068a11)
>> it is no longer needed in the private syms file.
>> ---
>>
>> It is trivial, but maybe worth inventing cfg.mk macro
>> that does check if all symbols f
On 10/05/2012 06:53 AM, Marcelo Cerri wrote:
> Just one question: do you think that makes sense for virGetUserID and
> virGetGroupID to check if a id exists when a numeric value is given?
Just because a uid hasn't been named in /etc/passwd doesn't mean it
won't be added in the future. If the user
Just one question: do you think that makes sense for virGetUserID and
virGetGroupID to check if a id exists when a numeric value is given?
Regards,
Marcelo
On Fri, Oct 05, 2012 at 09:44:46AM -0300, Marcelo Cerri wrote:
> On Thu, Oct 04, 2012 at 05:46:31PM -0600, Eric Blake wrote:
> > On 10/02/201
On Thu, Oct 04, 2012 at 05:46:31PM -0600, Eric Blake wrote:
> On 10/02/2012 11:57 AM, Marcelo Cerri wrote:
> > The DAC driver is missing parsing of group and user names for DAC labels
> > and currently just parses uid and gid. This patch extends it to support
> > names, so the following security la
On 10/05/2012 06:29 AM, Eric Blake wrote:
> On 10/05/2012 05:53 AM, Richard W.M. Jones wrote:
>>
>> And looking even more closely, I see disk->transient (not
>> implemented in the qemu driver ... why?)
>
> Lack of developer time :) [My usual excuse?]
By the way, this is:
https://bugzilla.redhat
On 10/05/2012 06:26 AM, Michal Privoznik wrote:
> On 04.10.2012 18:09, Eric Blake wrote:
>> I noticed that in two places, we require util-linux, and in a third,
>> we require util-linux-ng. On Fedora (I tested F15 through rawhide),
>> util-linux-ng is obsoleted by util-linux; on RHEL 6, util-linux
On 10/05/2012 05:40 AM, Richard W.M. Jones wrote:
>
> I notice that the qemu driver doesn't support snapshot drives
> (-drive file=foo,snapshot=on). This is important for libguestfs.
>
> Currently libguestfs hacks this using . That works fine for
> static disks in the libvirt XML, but lack of d
On 10/05/2012 05:53 AM, Richard W.M. Jones wrote:
>
> And looking even more closely, I see disk->transient (not
> implemented in the qemu driver ... why?)
Lack of developer time :) [My usual excuse?]
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://lib
After it got renamed to virProcessKill (cf470068a11)
it is no longer needed in the private syms file.
---
It is trivial, but maybe worth inventing cfg.mk macro
that does check if all symbols fro private syms are
defined somewhere. However, I am not that familiar
with cfg.mk, so if anybody has any
On 04.10.2012 18:09, Eric Blake wrote:
> I noticed that in two places, we require util-linux, and in a third,
> we require util-linux-ng. On Fedora (I tested F15 through rawhide),
> util-linux-ng is obsoleted by util-linux; on RHEL 6, util-linux
> is obsoleted by util-linux-ng. That is, on either
On 10/05/2012 05:36 AM, Michal Privoznik wrote:
> After it got renamed to virProcessKill (cf470068a11)
> it is no longer needed in the private syms file.
> ---
>
> It is trivial, but maybe worth inventing cfg.mk macro
> that does check if all symbols fro private syms are
> defined somewhere. Howev
On 10/05/2012 05:27 PM, Paolo Bonzini wrote:
Il 04/10/2012 15:31, Harsh Prateek Bora ha scritto:
Qemu accepts gluster protocol as supported storage backend beside others.
This patch allows users to specify disks on gluster backends like this:
Il 04/10/2012 15:31, Harsh Prateek Bora ha scritto:
> Qemu accepts gluster protocol as supported storage backend beside others.
> This patch allows users to specify disks on gluster backends like this:
>
>
>
>
>
>
>
>
>
> Note: In the element above,
On Fri, Oct 05, 2012 at 01:52:46PM +0200, Paolo Bonzini wrote:
> Il 05/10/2012 13:40, Richard W.M. Jones ha scritto:
> > I'm also concerned about the time is takes to run the external
> > 'qemu-img create' command, which is non-trivial in some versions
> > of qemu. In libguestfs, every millisecond
And looking even more closely, I see disk->transient (not
implemented in the qemu driver ... why?)
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
virt-top is 'top' for virtual machines. Tiny program with many
powerful monitoring features, net stats, disk
Il 05/10/2012 13:40, Richard W.M. Jones ha scritto:
> I'm also concerned about the time is takes to run the external
> 'qemu-img create' command, which is non-trivial in some versions
> of qemu. In libguestfs, every millisecond counts.
qemu-img create is a thin wrapper for bdrv_create that would
Reading back over the archives, I see there was a proposal to add a
attribute. I don't think that was ever
adopted.
http://www.redhat.com/archives/libvir-list/2011-July/msg00649.html
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
virt-p2v converts phys
I notice that the qemu driver doesn't support snapshot drives
(-drive file=foo,snapshot=on). This is important for libguestfs.
Currently libguestfs hacks this using . That works fine for
static disks in the libvirt XML, but lack of direct support in libvirt
is a blocker for adding hotplugging t
On 12.09.2012 18:28, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange"
>
> Add two new APIs virNetServerNewPostExecRestart and
> virNetServerPreExecRestart which allow a virNetServerPtr
> object to be created from a JSON object and saved to a
> JSON object, for the purpose of re-exec'ing a p
On 12.09.2012 18:29, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange"
>
> The virtlockd daemon will maintain locks on behalf of libvirtd.
> There are two reasons for it to be separate
>
> - Avoid risk of other libvirtd threads accidentally
>releasing fcntl() locks by opening + closing
On 12.09.2012 18:28, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange"
>
> Add two new APIs virNetServerServiceNewPostExecRestart and
> virNetServerServicePreExecRestart which allow a virNetServerServicePtr
> object to be created from a JSON object and saved to a
> JSON object, for the purpo
On 12.09.2012 18:28, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange"
>
> The previously introduced virFile{Lock,Unlock} APIs provide a
> way to acquire/release fcntl() locks on individual files. For
> unknown reason though, the POSIX spec says that fcntl() locks
> are released when *any* f
On 12.09.2012 18:28, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange"
>
> Add two new APIs virNetSocketNewPostExecRestart and
> virNetSocketPreExecRestart which allow a virNetSocketPtr
> object to be created from a JSON object and saved to a
> JSON object, for the purpose of re-exec'ing a p
On 12.09.2012 18:29, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange"
>
> The virtlockd daemon will be responsible for managing locks
> on virtual machines. Communication will be via the standard
> RPC infrastructure. This provides the XDR protocol definition
>
> * src/locking/lock_protoco
On 12.09.2012 18:29, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange"
>
> This adds a 'lockd' lock driver which is just a client which
> talks to the lockd daemon to perform all locking. This will
> be the default lock driver for any hypervisor which needs one.
>
> * src/Makefile.am: Add l
On 12.09.2012 18:28, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange"
>
> Add two new APIs virLockSpaceNewPostExecRestart and
> virLockSpacePreExecRestart which allow a virLockSpacePtr
> object to be created from a JSON object and saved to a
> JSON object, for the purposes of re-exec'ing a
On 12.09.2012 18:29, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange"
>
> Introduce a lock_daemon_dispatch.c file which implements the
> server side dispatcher the RPC APIs previously defined in the
> lock protocol.
>
> Signed-off-by: Daniel P. Berrange
> ---
> .gitignore
On 12.09.2012 18:28, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange"
>
> Add two new APIs virNetServerClientNewPostExecRestart and
> virNetServerClientPreExecRestart which allow a virNetServerClientPtr
> object to be created from a JSON object and saved to a
> JSON object, for the purpose
On 12.09.2012 18:29, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange"
>
> The virtlockd daemon maintains file locks on behalf of libvirtd
> and any VMs it is running. These file locks must be held for as
> long as any VM is running. If virtlockd itself ever quits, then
> it is expected that
On 12.09.2012 18:29, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange"
>
> This enhancement virtlockd so that it can receive a pre-opened
> UNIX domain socket from systemd at launch time, and adds the
> systemd service/socket unit files
>
> * daemon/libvirtd.service.in: Require virtlockd to
77 matches
Mail list logo
