Re: [libvirt] how to enable ceph-rbd in libvirt.

2012-10-10 Thread Josh Durgin
On 10/10/2012 10:52 PM, yue wrote: hi, now i rebuild libvirtd, version 0.10.2. and define ceph secret ,define ceph storage-pool. all fine up to now. i operate guest-os through virt-manager-GUI . i add a rbd-file(qemu-img create before) from ceph-rbd-pool, click 'finish',it pop error "NoneType o

Re: [libvirt] [RFC] New API to retrieve node CPU map

2012-10-10 Thread Viktor Mihajlovski
On 10/10/2012 11:23 PM, Eric Blake wrote: Are you interested in writing patches to implement this new API, if others agree with my alternate single-API signature? actually, I started to write up my proposal with the signature you suggested :-). A second thought was that having a function to

Re: [libvirt] how to enable ceph-rbd in libvirt.

2012-10-10 Thread yue
hi, now i rebuild libvirtd, version 0.10.2. and define ceph secret ,define ceph storage-pool. all fine up to now. i operate guest-os through virt-manager-GUI . i add a rbd-file(qemu-img create before) from ceph-rbd-pool, click 'finish',it pop error "NoneType object has no attribute startswith"

Re: [libvirt] [re-send][PATCH 1/3] add qemu driver hook

2012-10-10 Thread li guang
在 2012-10-10三的 15:00 +0100,Daniel P. Berrange写道: > On Mon, Oct 08, 2012 at 08:05:21PM -0600, Eric Blake wrote: > > On 10/08/2012 07:51 PM, liguang wrote: > > > this hook aimed at migration only, it supposed > > > to be used as a helper of migrate --copy-storage-* > > > features to remove the unreas

Re: [libvirt] [RFC] [PATCH v3 2/6] add fuse support for libvirt lxc

2012-10-10 Thread Gao feng
于 2012年10月08日 08:43, Gao feng 写道: > 于 2012年09月26日 02:37, Daniel P. Berrange 写道: >> > On Tue, Sep 11, 2012 at 10:54:48AM +0800, Gao feng wrote: >>> >> this patch addes fuse support for libvirt lxc. >>> >> we can use fuse filesystem to generate sysinfo dynamically, >>> >> So we can isolate /proc/memi

Re: [libvirt] [PATCH 1/3] conf: Do not allow vcpupin's cpuid exceed current vcpus number

2012-10-10 Thread Osier Yang
On 2012年10月10日 22:59, Martin Kletzander wrote: On 10/10/2012 01:14 PM, Osier Yang wrote: Setting pinning policy for vcpu which exceed current vcpus number makes no sense, and it could cause problem for APIs which associate the vcpu thread id with cgroup. --- src/conf/domain_conf.c |4 ++--

[libvirt] [PATCH v10] support offline migration

2012-10-10 Thread liguang
original migration did not aware of offline case, so, try to support offline migration quietly (did not disturb original migration) by pass VIR_MIGRATE_OFFLINE flag to migration APIs if only the domain is really inactive, and migration process will not puzzled by domain offline and exit unexpectedl

[libvirt] [PATCH] remove unnecessary eat-cookie

2012-10-10 Thread liguang
located at qemuMigrationConfirm Signed-off-by: liguang --- src/qemu/qemu_migration.c |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index 6845a97..26aacaf 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu

Re: [libvirt] [RFC] New API to retrieve node CPU map

2012-10-10 Thread Eric Blake
On 10/10/2012 10:02 PM, Osier Yang wrote: >> Are you interested in writing patches to implement this new API, if >> others agree with my alternate single-API signature? > > Agreed. A single-API and allocating the cpumap inside libvirt without > the need to known the maplen avoids the race. > > Bu

Re: [libvirt] [RFC] New API to retrieve node CPU map

2012-10-10 Thread Osier Yang
On 2012年10月11日 05:23, Eric Blake wrote: On 10/10/2012 09:18 AM, Viktor Mihajlovski wrote: Hi, in order to use the APIs listed below it is necessary for a client to know the maximum number of node CPUs which is passed via the maplen argument. virDomainGetEmulatorPinInfo virDomainGetVcpuPinInfo

Re: [libvirt] [PATCH 2/3] conf: Initialize the pinning policy for vcpus

2012-10-10 Thread Osier Yang
On 2012年10月10日 23:34, Martin Kletzander wrote: On 10/10/2012 01:14 PM, Osier Yang wrote: There are two branches to specifiy the pinning policy for vcpus. 1) def->cpuset: 6 2) def->cputune.vcpupins: def->cputune.vcpupins only maintains the pinning policy only for vcpus h

Re: [libvirt] [PATCH 3/7] snapshot: Add flag to enable creating checkpoints in paused state

2012-10-10 Thread Eric Blake
On 10/09/2012 07:39 AM, Peter Krempa wrote: > The default behavior while creating external checkpoints is to let the > guest run while the memory state is caputred. This leads to a larger s/caputred/captured/ > save file but minimizes the time needed to take the checkpoint. I'd rather swap the d

Re: [libvirt] [PATCH 1/7] qemu: Fix misleading comment for qemuDomainObjBeginJobWithDriver()

2012-10-10 Thread Eric Blake
On 10/09/2012 07:39 AM, Peter Krempa wrote: > The comment stated that you may call qemuDomainObjBeginJobWithDriver() > without passing qemud_driver to signalize it's not locked. signalize is a valid spelling, but unusual; I'd write it 'signal'. > qemuDomainObjBeginJobWithDriver still accesses the

Re: [libvirt] how to enable ceph-rbd in libvirt.

2012-10-10 Thread Josh Durgin
On 10/10/2012 07:52 PM, yue wrote: 1.my libvirtd version is 0.9.10. i rebuild qemu with --enable-rbd. it seems not work if guest-os has a rbd disk. -rbd disk info 2.---error log

[libvirt] how to enable ceph-rbd in libvirt.

2012-10-10 Thread yue
1.my libvirtd version is 0.9.10. i rebuild qemu with --enable-rbd. it seems not work if guest-os has a rbd disk. -rbd disk info 2.---error log- LC_ALL=C PATH=/sbin:/usr/sbin:/bin:/usr/bi

Re: [libvirt] [PATCH v9] support offline migration

2012-10-10 Thread li guang
在 2012-10-10三的 14:38 +0100,Daniel P. Berrange写道: > On Tue, Sep 25, 2012 at 03:45:24PM +0800, liguang wrote: > > original migration did not aware of offline case, > > so, try to support offline migration quietly > > (did not disturb original migration) by pass > > VIR_MIGRATE_OFFLINE flag to migrati

[libvirt] Fw:Re:Re: build libvirt error. lack of AppArmor .

2012-10-10 Thread yue
1.my configure options is "./configure --with-selinux=no --with-secdriver-selinux=no --with-apparmor=no --with-secdriver-apparmor=no --with-init-script=redhat" because i can not start spSP3-guest-OS,infos on the internet tell security-driver should be disabled. i just test it. so --with-

Re: [libvirt] [PATCH v2 3/3] qemu-config: Add new -add-fd command line option

2012-10-10 Thread Eric Blake
On 10/10/2012 08:20 AM, Corey Bryant wrote: > This option can be used for passing file descriptors on the > command line. It mirrors the existing add-fd QMP command which > allows an fd to be passed to QEMU via SCM_RIGHTS and added to an > fd set. > > This can be combined with commands such as -d

Re: [libvirt] [PATCH v2 2/3] monitor: Enable adding an inherited fd to an fd set

2012-10-10 Thread Eric Blake
On 10/10/2012 08:20 AM, Corey Bryant wrote: > qmp_add_fd() gets an fd that was received over a socket with > SCM_RIGHTS and adds it to an fd set. This patch adds support > that will enable adding an fd that was inherited on the > command line to an fd set. > > This patch also prevents removal of

Re: [libvirt] [PATCH v2 1/3] monitor: Allow add-fd to any specified fd set

2012-10-10 Thread Eric Blake
On 10/10/2012 08:20 AM, Corey Bryant wrote: > The first call to add an fd to an fd set was previously not > allowed to choose the fd set ID. The ID was generated as > the first available and ensuing calls could add more fds by > specifying the fd set ID. This change allows users to > choose the f

Re: [libvirt] [RFC] New API to retrieve node CPU map

2012-10-10 Thread Eric Blake
On 10/10/2012 09:18 AM, Viktor Mihajlovski wrote: > Hi, > > in order to use the APIs listed below it is necessary for a client to > know the maximum number of node CPUs which is passed via the maplen > argument. > > virDomainGetEmulatorPinInfo > virDomainGetVcpuPinInfo > virDomainGetVcpus > virDo

Re: [libvirt] build libvirt error. lack of AppArmor .

2012-10-10 Thread Eric Blake
On 10/10/2012 04:04 AM, yue wrote: > error occur when attach a rbd-disk to domain. > > 1.configure: error: You must install the AppArmor development package in > order to compile libvirt What command line did you pass to configure? AppArmor is optional (and in fact, Fedora does not use it); s

Re: [libvirt] Correct name of domain/pm/suspend-to-mem in docs

2012-10-10 Thread Eric Blake
On 10/10/2012 01:44 PM, Zeeshan Ali (Khattak) wrote: > From: "Zeeshan Ali (Khattak)" > > --- > docs/formatdomain.html.in | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in > index 3cc6c51..f9fe6ca 100644 > --- a/docs/fo

Re: [libvirt] [PATCH 4/6] qemu: Implement startupPolicy for USB passed through devices

2012-10-10 Thread Jiri Denemark
On Wed, Oct 10, 2012 at 16:39:06 +0100, Daniel P. Berrange wrote: > On Tue, Oct 09, 2012 at 02:13:25PM +0200, Jiri Denemark wrote: > > > > +virBufferAddLit(&buf, "usb-host"); > > +if (!dev->missing) { > > +virBufferAsprintf(&buf, ",hostbus=%d,hostaddr=%d", > > +

[libvirt] [libvirt-glib v2] gconfig: Add API to set domain/pm tree

2012-10-10 Thread Zeeshan Ali (Khattak)
From: "Zeeshan Ali (Khattak)" API for new domain power management configuration. --- libvirt-gconfig/Makefile.am| 2 + .../libvirt-gconfig-domain-power-management.c | 100 + .../libvirt-gconfig-domain-power-management.h | 73 ++

Re: [libvirt] [libvirt-glib] gconfig: Add API to set domain/pm tree

2012-10-10 Thread Zeeshan Ali (Khattak)
On Wed, Oct 10, 2012 at 7:40 PM, Zeeshan Ali (Khattak) wrote: > On Tue, Oct 9, 2012 at 11:04 PM, Zeeshan Ali (Khattak) > wrote: >> From: "Zeeshan Ali (Khattak)" >> >> API for new domain power management configuration. > > Forgot to mention that while this patch does correctly put the 'pm' > tree

[libvirt] Correct name of domain/pm/suspend-to-mem in docs

2012-10-10 Thread Zeeshan Ali (Khattak)
From: "Zeeshan Ali (Khattak)" --- docs/formatdomain.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 3cc6c51..f9fe6ca 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -983,7 +983,7 @@

[libvirt] feature?

2012-10-10 Thread Gene Czarcinski
By accident I had virtual guests running where the ip6 network definition was different than the one specified in the network xml file ... and it worked! Of course I did get an "extra" network address on the interface (due I assume to radvd) but it worked. Now, this is really an isolated net

Re: [libvirt] [PATCH] storage: Report UUID/name consistently in driver errors

2012-10-10 Thread Cole Robinson
On 10/10/2012 12:30 PM, Eric Blake wrote: > On 10/10/2012 10:18 AM, Cole Robinson wrote: >> Done with: >> >> sed -i -e "s/no pool with matching uuid/no storage pool with matching >> uuid/g" src/storage/storage_driver.c >> sed -i -e 's/"%s", _("no storage pool with matching uuid")/_("no storage >>

Re: [libvirt] [libvirt-glib] gconfig: Add API to set domain/pm tree

2012-10-10 Thread Zeeshan Ali (Khattak)
On Tue, Oct 9, 2012 at 11:04 PM, Zeeshan Ali (Khattak) wrote: > From: "Zeeshan Ali (Khattak)" > > API for new domain power management configuration. Forgot to mention that while this patch does correctly put the 'pm' tree into the configuration XML, libvirt seems to remove it and hence its curre

Re: [libvirt] [PATCH] storage: Report UUID/name consistently in driver errors

2012-10-10 Thread Eric Blake
On 10/10/2012 10:18 AM, Cole Robinson wrote: > Done with: > > sed -i -e "s/no pool with matching uuid/no storage pool with matching uuid/g" > src/storage/storage_driver.c > sed -i -e 's/"%s", _("no storage pool with matching uuid")/_("no storage pool > with matching uuid %s"), obj->uuid/g' src/s

Re: [libvirt] [PATCH 2/3] conf: Initialize the pinning policy for vcpus

2012-10-10 Thread Eric Blake
On 10/10/2012 09:34 AM, Martin Kletzander wrote: > On 10/10/2012 01:14 PM, Osier Yang wrote: >> There are two branches to specifiy the pinning policy for vcpus. >> >> 1) def->cpuset: >> >>6 >> >> 2) def->cputune.vcpupins: >> >> >> >> >> >> def->cputune.vcpupins only maintains the

[libvirt] [PATCH] storage: Report UUID/name consistently in driver errors

2012-10-10 Thread Cole Robinson
Done with: sed -i -e "s/no pool with matching uuid/no storage pool with matching uuid/g" src/storage/storage_driver.c sed -i -e 's/"%s", _("no storage pool with matching uuid")/_("no storage pool with matching uuid %s"), obj->uuid/g' src/storage/storage_driver.c sed -i -e 's/"%s", _("storage poo

Re: [libvirt] [PATCH 2/2] Shut down session libvirtd cleanly

2012-10-10 Thread Daniel P. Berrange
On Tue, Oct 09, 2012 at 05:26:29PM +0200, Alexander Larsson wrote: > When the session dies or when the system is going to be shut down > we save all active VMs and exit libvirtd. > > Additionally whenever there is an active domain we hold a > shutdown inhibitor to avoid shutting down before all th

Re: [libvirt] [PATCH] Make virInitialize thread safe

2012-10-10 Thread Eric Blake
On 10/10/2012 09:32 AM, Matthias Bolte wrote: > 2012/10/10 Daniel P. Berrange : >> From: "Daniel P. Berrange" >> >> Currently there is a restriction that multi-threaded applications >> must manually call virInitialize, before threads start using >> libvirt, because it is not thread-safe. By switch

Re: [libvirt] [PATCH] Make virInitialize thread safe

2012-10-10 Thread Daniel P. Berrange
On Wed, Oct 10, 2012 at 05:32:21PM +0200, Matthias Bolte wrote: > 2012/10/10 Daniel P. Berrange : > > From: "Daniel P. Berrange" > > > > Currently there is a restriction that multi-threaded applications > > must manually call virInitialize, before threads start using > > libvirt, because it is not

Re: [libvirt] [PATCH 6/6] qemu: Make save/restore with USB devices usable

2012-10-10 Thread Daniel P. Berrange
On Tue, Oct 09, 2012 at 02:13:27PM +0200, Jiri Denemark wrote: > Save/restore with passed through USB devices currently only works if the > USB device can be found at the same USB address where it used to be > before saving a domain. This makes sense in case a user explicitly > configure the USB ad

Re: [libvirt] [PATCH 3/6] qemu: Add option to treat missing USB devices as success

2012-10-10 Thread Daniel P. Berrange
On Tue, Oct 09, 2012 at 02:13:24PM +0200, Jiri Denemark wrote: > All USB device lookup functions emit an error when they cannot find the > requested device. With this patch, their caller can choose if a missing > device is an error or normal condition. > --- > src/conf/domain_conf.h | 1

Re: [libvirt] [PATCH 4/6] qemu: Implement startupPolicy for USB passed through devices

2012-10-10 Thread Daniel P. Berrange
On Tue, Oct 09, 2012 at 02:13:25PM +0200, Jiri Denemark wrote: > --- > src/qemu/qemu_cgroup.c | 2 ++ > src/qemu/qemu_command.c | 20 +++- > src/qemu/qemu_hostdev.c | 20 +++- > src/qemu/qemu_hostdev.h | 3 ++- > src/qemu/qemu_process.c | 2 +- > 5 files changed

Re: [libvirt] [PATCH 1/6] conf: Add support for startupPolicy for USB devices

2012-10-10 Thread Daniel P. Berrange
On Tue, Oct 09, 2012 at 02:13:22PM +0200, Jiri Denemark wrote: > USB devices can disappear without OS being mad about it, which makes > them ideal for startupPolicy. With this attribute, USB devices can be > configured to be mandatory (the default), requisite (will disappear > during migration if t

Re: [libvirt] [PATCH] Make virInitialize thread safe

2012-10-10 Thread Matthias Bolte
2012/10/10 Daniel P. Berrange : > From: "Daniel P. Berrange" > > Currently there is a restriction that multi-threaded applications > must manually call virInitialize, before threads start using > libvirt, because it is not thread-safe. By switching it to use > a virOnceControl initializer we gain

Re: [libvirt] [PATCH 2/3] conf: Initialize the pinning policy for vcpus

2012-10-10 Thread Martin Kletzander
On 10/10/2012 01:14 PM, Osier Yang wrote: > There are two branches to specifiy the pinning policy for vcpus. > > 1) def->cpuset: > >6 > > 2) def->cputune.vcpupins: > > > > > > def->cputune.vcpupins only maintains the pinning policy only for > vcpus have specified explictly,

Re: [libvirt] [PATCH 2/6] qemu: Introduce qemuFindHostdevUSBDevice

2012-10-10 Thread Daniel P. Berrange
On Tue, Oct 09, 2012 at 02:13:23PM +0200, Jiri Denemark wrote: > The code which looks up a USB device specified by hostdev is duplicated > in two places. This patch creates a dedicated function that can be > called in both places. > --- > src/qemu/qemu_hostdev.c | 73 > +++

[libvirt] [RFC] New API to retrieve node CPU map

2012-10-10 Thread Viktor Mihajlovski
Hi, in order to use the APIs listed below it is necessary for a client to know the maximum number of node CPUs which is passed via the maplen argument. virDomainGetEmulatorPinInfo virDomainGetVcpuPinInfo virDomainGetVcpus virDomainPinEmulator virDomainPinVcpu virDomainPinVcpuFlags The curren

[libvirt] [PATCH] Make virInitialize thread safe

2012-10-10 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Currently there is a restriction that multi-threaded applications must manually call virInitialize, before threads start using libvirt, because it is not thread-safe. By switching it to use a virOnceControl initializer we gain thread safety, and thus applications no lon

Re: [libvirt] [PATCH 1/3] conf: Do not allow vcpupin's cpuid exceed current vcpus number

2012-10-10 Thread Martin Kletzander
On 10/10/2012 01:14 PM, Osier Yang wrote: > Setting pinning policy for vcpu which exceed current vcpus number > makes no sense, and it could cause problem for APIs which > associate the vcpu thread id with cgroup. > --- > src/conf/domain_conf.c |4 ++-- > 1 files changed, 2 insertions(+), 2 de

[libvirt] [PATCH v2 3/3] qemu-config: Add new -add-fd command line option

2012-10-10 Thread Corey Bryant
This option can be used for passing file descriptors on the command line. It mirrors the existing add-fd QMP command which allows an fd to be passed to QEMU via SCM_RIGHTS and added to an fd set. This can be combined with commands such as -drive to link file descriptors in an fd set to a drive:

[libvirt] [PATCH v2 0/3] command line fd passing using fd sets

2012-10-10 Thread Corey Bryant
This series adds command line file descriptor passing support via a new -add-fd option. This is a follow-on to the existing QMP fd passing support provided in the following patch series: comments.gmane.org/gmane.comp.emulators.qemu/165463 The new -add-fd option is designed to mirror the add-fd QM

[libvirt] [PATCH v2 1/3] monitor: Allow add-fd to any specified fd set

2012-10-10 Thread Corey Bryant
The first call to add an fd to an fd set was previously not allowed to choose the fd set ID. The ID was generated as the first available and ensuing calls could add more fds by specifying the fd set ID. This change allows users to choose the fd set ID on the first call. Signed-off-by: Corey Brya

[libvirt] [PATCH v2 2/3] monitor: Enable adding an inherited fd to an fd set

2012-10-10 Thread Corey Bryant
qmp_add_fd() gets an fd that was received over a socket with SCM_RIGHTS and adds it to an fd set. This patch adds support that will enable adding an fd that was inherited on the command line to an fd set. This patch also prevents removal of an fd from an fd set during initialization. This allows

Re: [libvirt] [PATCH v2 5/6] locking: Add support for lock failure action

2012-10-10 Thread Daniel P. Berrange
On Wed, Oct 10, 2012 at 01:35:32PM +0200, Jiri Denemark wrote: > --- > Notes: > Version 2: > - no changes > > src/Makefile.am | 2 +- > src/locking/domain_lock.c | 11 +++ > src/locking/lock_driver.h | 5 - > src/locking/lock_driver_nop.c

Re: [libvirt] [PATCH v2 6/6] locking: Implement lock failure action in sanlock driver

2012-10-10 Thread Daniel P. Berrange
On Wed, Oct 10, 2012 at 01:35:33PM +0200, Jiri Denemark wrote: > While the changes to sanlock driver should be stable, the actual > implementation of sanlock_helper is supposed to be replaced in the > future. However, before we can implement a better sanlock_helper, we > need an administrative inte

Re: [libvirt] [PATCH v2 4/6] locking: Pass hypervisor driver name when acquiring locks

2012-10-10 Thread Daniel P. Berrange
On Wed, Oct 10, 2012 at 01:35:31PM +0200, Jiri Denemark wrote: > This is required in case a lock manager needs to contact libvirtd in > case of an unexpected event. > --- > Notes: > Version 2: > - update after dropping ``qemu: Use macro instead of "qemu" in the > context of URI scheme

Re: [libvirt] [re-send][PATCH 1/3] add qemu driver hook

2012-10-10 Thread Daniel P. Berrange
On Mon, Oct 08, 2012 at 08:05:21PM -0600, Eric Blake wrote: > On 10/08/2012 07:51 PM, liguang wrote: > > this hook aimed at migration only, it supposed > > to be used as a helper of migrate --copy-storage-* > > features to remove the unreasonable limitation > > of pre-exist disk images at migration

Re: [libvirt] [PATCH v2 1/6] conf: Rename life cycle actions to event actions

2012-10-10 Thread Daniel P. Berrange
On Wed, Oct 10, 2012 at 01:35:28PM +0200, Jiri Denemark wrote: > While current on_{poweroff,reboot,crash} action configuration is about > configuring life cycle actions, they can all be considered events and > actions that need to be done on a particular event. Let's generalize the > code this way

Re: [libvirt] [PATCH v2 3/6] locking: Add const char * parameter to avoid ugly typecasts

2012-10-10 Thread Daniel P. Berrange
On Wed, Oct 10, 2012 at 01:35:30PM +0200, Jiri Denemark wrote: > --- > Notes: > Version 2: > - no changes > > src/locking/lock_driver.h | 2 ++ > src/locking/lock_manager.c | 3 +++ > 2 files changed, 5 insertions(+) ACK Daniel -- |: http://berrange.com -o-http://www.flickr.

Re: [libvirt] [PATCH v2 2/6] conf: Add on_lockfailure event configuration

2012-10-10 Thread Daniel P. Berrange
On Wed, Oct 10, 2012 at 01:35:29PM +0200, Jiri Denemark wrote: > Using this new element, one can configure an action that should be > performed when resource locks are lost. > --- > Notes: > Version 2: > - no changes > > docs/formatdomain.html.in | 22 ++ > docs/sc

Re: [libvirt] [libvirt-glib] gconfig: Add API to set domain/pm tree

2012-10-10 Thread Zeeshan Ali (Khattak)
On Wed, Oct 10, 2012 at 1:12 PM, Christophe Fergeau wrote: > On Tue, Oct 09, 2012 at 11:04:46PM +0300, Zeeshan Ali (Khattak) wrote: >> From: "Zeeshan Ali (Khattak)" >> >> diff --git a/libvirt-gconfig/libvirt-gconfig-domain-power-management.c >> b/libvirt-gconfig/libvirt-gconfig-domain-power-mana

Re: [libvirt] [PATCH 1/2] virdbus: Add virDBusGetSessionBus helper

2012-10-10 Thread Daniel P. Berrange
On Tue, Oct 09, 2012 at 05:26:28PM +0200, Alexander Larsson wrote: > This splits out some common code from virDBusGetSystemBus and > uses it to implement a new virDBusGetSessionBus helper. > --- > src/libvirt_private.syms | 1 + > src/util/virdbus.c | 84 > +

Re: [libvirt] [PATCH v9] support offline migration

2012-10-10 Thread Daniel P. Berrange
On Tue, Sep 25, 2012 at 03:45:24PM +0800, liguang wrote: > original migration did not aware of offline case, > so, try to support offline migration quietly > (did not disturb original migration) by pass > VIR_MIGRATE_OFFLINE flag to migration APIs if only > the domain is really inactive, and > migr

[libvirt] Schedule for the next release: 1.0.0

2012-10-10 Thread Daniel Veillard
After checking with Dan and other developpers, there is some agreement that we should finally bump the major release number, and we would like to do it beginning of November i.e. in sync for the next release. As usual all API and ABIs will be kept, this is just a numbering issue ! To try to avoi

Re: [libvirt] [PATCH] libvirt: Change maximum CPU per node calculation.

2012-10-10 Thread Daniel P. Berrange
On Wed, Oct 10, 2012 at 02:50:28PM +0200, Viktor Mihajlovski wrote: > On 10/10/2012 02:23 PM, Daniel P. Berrange wrote: > > > >NACK, this breaks ABI compatibility of the public API > > > > I see ... before I venture a different approach: would the > definition of VIR_NODEINFO_MAXCPUS be considered

Re: [libvirt] [PATCH] libvirt: Change maximum CPU per node calculation.

2012-10-10 Thread Viktor Mihajlovski
On 10/10/2012 02:23 PM, Daniel P. Berrange wrote: NACK, this breaks ABI compatibility of the public API I see ... before I venture a different approach: would the definition of VIR_NODEINFO_MAXCPUS be considered part of the public API as well? -- Mit freundlichen Grüßen/Kind Regards Vik

Re: [libvirt] [PATCH] libvirt: Change maximum CPU per node calculation.

2012-10-10 Thread Daniel P. Berrange
On Wed, Oct 10, 2012 at 02:05:25PM +0200, Viktor Mihajlovski wrote: > The macro VIR_NODEINFO_MAXCPUS computes the maximum number of supported > CPUs for a node as the product of sockets, cores and threads from the > virNodeInfo structure. > Since topology cannot be discovered for offline CPUs, any

[libvirt] [PATCH] libvirt: Change maximum CPU per node calculation.

2012-10-10 Thread Viktor Mihajlovski
The macro VIR_NODEINFO_MAXCPUS computes the maximum number of supported CPUs for a node as the product of sockets, cores and threads from the virNodeInfo structure. Since topology cannot be discovered for offline CPUs, any of the values for sockets, cores or threads can be wrong (too small). As a c

[libvirt] [PATCH v2 5/6] locking: Add support for lock failure action

2012-10-10 Thread Jiri Denemark
--- Notes: Version 2: - no changes src/Makefile.am | 2 +- src/locking/domain_lock.c | 11 +++ src/locking/lock_driver.h | 5 - src/locking/lock_driver_nop.c | 1 + src/locking/lock_driver_sanlock.c | 1 + src/locking/lock_manager.c

[libvirt] [PATCH v2 6/6] locking: Implement lock failure action in sanlock driver

2012-10-10 Thread Jiri Denemark
While the changes to sanlock driver should be stable, the actual implementation of sanlock_helper is supposed to be replaced in the future. However, before we can implement a better sanlock_helper, we need an administrative interface to libvirtd so that the helper can just pass a "leases lost" even

[libvirt] [PATCH v2 3/6] locking: Add const char * parameter to avoid ugly typecasts

2012-10-10 Thread Jiri Denemark
--- Notes: Version 2: - no changes src/locking/lock_driver.h | 2 ++ src/locking/lock_manager.c | 3 +++ 2 files changed, 5 insertions(+) diff --git a/src/locking/lock_driver.h b/src/locking/lock_driver.h index 83ef323..c33aea7 100644 --- a/src/locking/lock_driver.h +++ b/src/locking/lo

[libvirt] [PATCH v2 2/6] conf: Add on_lockfailure event configuration

2012-10-10 Thread Jiri Denemark
Using this new element, one can configure an action that should be performed when resource locks are lost. --- Notes: Version 2: - no changes docs/formatdomain.html.in | 22 ++ docs/schemas/domaincommon.rng | 22 ++ src/conf/domain_conf.c

[libvirt] [PATCH v2 4/6] locking: Pass hypervisor driver name when acquiring locks

2012-10-10 Thread Jiri Denemark
This is required in case a lock manager needs to contact libvirtd in case of an unexpected event. --- Notes: Version 2: - update after dropping ``qemu: Use macro instead of "qemu" in the context of URI scheme'' - pass driver URI rather than its name - rename driver parameter t

[libvirt] [PATCH v2 1/6] conf: Rename life cycle actions to event actions

2012-10-10 Thread Jiri Denemark
While current on_{poweroff,reboot,crash} action configuration is about configuring life cycle actions, they can all be considered events and actions that need to be done on a particular event. Let's generalize the code this way so that it can be reused later for non-lifecycle events. --- Notes:

[libvirt] [PATCH v2 0/6] Add support for lock failure action

2012-10-10 Thread Jiri Denemark
When sanlock is used as a locking driver and sanlock deamon loses access to its lockspace, it automatically kills off the domains that had their locks stored there. Apparently some management apps would like to change this behavior by configuring what should happen when locks are lost. Patch 3/7 f

[libvirt] [PATCH 3/3] qemu: Initialize cpuset for hotplugged vcpu as def->cpuset

2012-10-10 Thread Osier Yang
The onlined vcpu pinning policy should inherit def->cpuset if it's not specified explicitly, and the affinity should be set in this case. Oppositely, the offlined vcpu pinning policy should be free()'ed. --- src/conf/domain_conf.c | 21 + src/conf/domain_conf.h |3 ++ src/lib

Re: [libvirt] [PATCH] qemu: Create or remove cgroup when doing vcpu (un)hotpluging

2012-10-10 Thread Osier Yang
On 2012年10月10日 17:11, Peter Krempa wrote: On 10/09/12 18:08, Osier Yang wrote: Various APIs use cgroup to either set or get the statistics of host or guest. Hotplug or unhotplug new vcpus without creating or removing the cgroup for the vcpus could cause problems for those APIs. E.g. % virsh vcp

[libvirt] [PATCH 2/3] conf: Initialize the pinning policy for vcpus

2012-10-10 Thread Osier Yang
There are two branches to specifiy the pinning policy for vcpus. 1) def->cpuset: 6 2) def->cputune.vcpupins: def->cputune.vcpupins only maintains the pinning policy only for vcpus have specified explictly, this works fine before cgroup is widely used for domain. But since now

[libvirt] [PATCH 1/3] conf: Do not allow vcpupin's cpuid exceed current vcpus number

2012-10-10 Thread Osier Yang
Setting pinning policy for vcpu which exceed current vcpus number makes no sense, and it could cause problem for APIs which associate the vcpu thread id with cgroup. --- src/conf/domain_conf.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/conf/domain_conf.c b/src/

[libvirt] [PATCH 0/3] vcpupin improvements

2012-10-10 Thread Osier Yang
These 3 patches are to improve vcpu pinning problems: problem 1: vcpu hotplug is supported for some time, but it doesn't set pinning policy for the vcpus onlined, or doesn't remove the pinning policy for offlined vcpus. problem 2: Also each vcpu doesn't inherit the pinning policy from def->cpuset

Re: [libvirt] [libvirt-glib] gconfig: Add API to set domain/pm tree

2012-10-10 Thread Christophe Fergeau
On Tue, Oct 09, 2012 at 11:04:46PM +0300, Zeeshan Ali (Khattak) wrote: > From: "Zeeshan Ali (Khattak)" > > API for new domain power management configuration. > --- > libvirt-gconfig/Makefile.am| 2 + > .../libvirt-gconfig-domain-power-management.c | 101 >

[libvirt] build libvirt error. lack of AppArmor .

2012-10-10 Thread yue
error occur when attach a rbd-disk to domain. 1.configure: error: You must install the AppArmor development package in order to compile libvirt 2. 2012-10-10 17:36:16.305+: 3808: warning : qemuDomainObjTaint:1297 : Domain id=2 name='xpSP3' uuid=b45bd66a-6700-4905-c5f4-4c799413d7b7 is taint

Re: [libvirt] [PATCH] qemu: Create or remove cgroup when doing vcpu (un)hotpluging

2012-10-10 Thread Peter Krempa
On 10/09/12 18:08, Osier Yang wrote: Various APIs use cgroup to either set or get the statistics of host or guest. Hotplug or unhotplug new vcpus without creating or removing the cgroup for the vcpus could cause problems for those APIs. E.g. % virsh vcpucount dom maximum config10 ma

Re: [libvirt] [PATCH v1 0/3] libvirt: Implement CPU model driver for PowerPC

2012-10-10 Thread Li Zhang
Hi, I read x86 CPU model driver and have some understanding. Then do some work on Power as x86. Maybe there some problems. Can someone help review these patches? Thanks in advance. :-) On Tue, Oct 9, 2012 at 3:58 PM, Li Zhang wrote: > CPU model driver is to get host's CPU information and it al

Re: [libvirt] [PATCH] qemu: Create or remove cgroup when doing vcpu (un)hotpluging

2012-10-10 Thread Martin Kletzander
On 10/09/2012 06:08 PM, Osier Yang wrote: > Various APIs use cgroup to either set or get the statistics of > host or guest. Hotplug or unhotplug new vcpus without creating > or removing the cgroup for the vcpus could cause problems for > those APIs. E.g. > > % virsh vcpucount dom > maximum co