Re: [libvirt] [PATCH][RFC] helper of copy-storage-* features

2012-10-17 Thread li guang
在 2012-10-18四的 01:03 -0500,Doug Goldstein写道: > On Thu, Oct 18, 2012 at 12:47 AM, li guang wrote: > > 在 2012-10-17三的 21:50 -0500,Doug Goldstein写道: > >> On Sun, Oct 14, 2012 at 9:48 PM, liguang wrote: > >> > help to create disk images copy-storage-* required, > >> > try to do non-shared migration w

Re: [libvirt] [PATCH v11] support offline migration

2012-10-17 Thread Doug Goldstein
On Wed, Oct 17, 2012 at 7:42 PM, liguang wrote: > original migration did not aware of offline case, > so, try to support offline migration quietly > (did not disturb original migration) by pass > VIR_MIGRATE_OFFLINE flag to migration APIs if only > the domain is really inactive, and > migration pr

Re: [libvirt] [PATCH] migration: offline / inactive domain support

2012-10-17 Thread Doug Goldstein
On Thu, Oct 18, 2012 at 1:06 AM, Doug Goldstein wrote: > Supports migrating a domain that is currently inactive. This patchset > adds a new migration flag called VIR_MIGRATE_OFFLINE, which can only be > used on domains that are inactive. Offline migration does not support > copying non-shared stor

[libvirt] [PATCH] migration: offline / inactive domain support

2012-10-17 Thread Doug Goldstein
Supports migrating a domain that is currently inactive. This patchset adds a new migration flag called VIR_MIGRATE_OFFLINE, which can only be used on domains that are inactive. Offline migration does not support copying non-shared storage in any case. --- src/qemu/qemu_driver.c| 29 +

Re: [libvirt] [PATCH][RFC] helper of copy-storage-* features

2012-10-17 Thread Doug Goldstein
On Thu, Oct 18, 2012 at 12:47 AM, li guang wrote: > 在 2012-10-17三的 21:50 -0500,Doug Goldstein写道: >> On Sun, Oct 14, 2012 at 9:48 PM, liguang wrote: >> > help to create disk images copy-storage-* required, >> > try to do non-shared migration without bothering to >> > create disk images at target b

Re: [libvirt] [PATCH][RFC] helper of copy-storage-* features

2012-10-17 Thread li guang
在 2012-10-17三的 21:50 -0500,Doug Goldstein写道: > On Sun, Oct 14, 2012 at 9:48 PM, liguang wrote: > > help to create disk images copy-storage-* required, > > try to do non-shared migration without bothering to > > create disk images at target by hand. > > > > consider this situation: > > 1. non-share

Re: [libvirt] [RFC] [PATCH v3 2/6] add fuse support for libvirt lxc

2012-10-17 Thread Gao feng
于 2012年10月16日 20:23, Daniel P. Berrange 写道: > On Mon, Oct 08, 2012 at 08:43:28AM +0800, Gao feng wrote: >> 于 2012年09月26日 02:37, Daniel P. Berrange 写道: >>> On Tue, Sep 11, 2012 at 10:54:48AM +0800, Gao feng wrote: this patch addes fuse support for libvirt lxc. we can use fuse filesystem to

Re: [libvirt] [PATCH][RFC] helper of copy-storage-* features

2012-10-17 Thread Doug Goldstein
On Sun, Oct 14, 2012 at 9:48 PM, liguang wrote: > help to create disk images copy-storage-* required, > try to do non-shared migration without bothering to > create disk images at target by hand. > > consider this situation: > 1. non-shared migration >virsh migrate --copy-storage-all ... > 2.

Re: [libvirt] [PATCH][RFC] helper of copy-storage-* features

2012-10-17 Thread li guang
ping ... 在 2012-10-15一的 10:48 +0800,liguang写道: > help to create disk images copy-storage-* required, > try to do non-shared migration without bothering to > create disk images at target by hand. > > consider this situation: > 1. non-shared migration >virsh migrate --copy-storage-all ... > 2.

Re: [libvirt] [PATCHv2 17/16] blockjob: refactor qemu disk chain permission grants

2012-10-17 Thread Eric Blake
On 10/17/2012 06:09 PM, Laine Stump wrote: > On 10/16/2012 06:03 PM, Eric Blake wrote: >> Previously, snapshot code did its own permission granting (lock >> manager, cgroup device controller, and security manager labeling) >> inline. But now that we are adding block-commit and block-copy >> which

[libvirt] [PATCH v11] support offline migration

2012-10-17 Thread liguang
original migration did not aware of offline case, so, try to support offline migration quietly (did not disturb original migration) by pass VIR_MIGRATE_OFFLINE flag to migration APIs if only the domain is really inactive, and migration process will not puzzled by domain offline and exit unexpectedl

Re: [libvirt] [PATCHv2 17/16] blockjob: refactor qemu disk chain permission grants

2012-10-17 Thread Laine Stump
On 10/16/2012 06:03 PM, Eric Blake wrote: > Previously, snapshot code did its own permission granting (lock > manager, cgroup device controller, and security manager labeling) > inline. But now that we are adding block-commit and block-copy > which also have to change permissions, it's better to r

[libvirt] [HELP] QEMU guest agent via ISA serial port, or shutdown hooks?

2012-10-17 Thread Thorsten Glaser
Hi, http://www.redhat.com/archives/libvir-list/2012-January/msg00629.html added support only for when using the virtio channel to the guest. However, QEMU Guest Agent support is most useful to guests that do not implement ACPI shutdown support; these usually don’t have virtio (especially since I

Re: [libvirt] [PATCH] qemu: Fixed default machine detection in qemuCapsParseMachineTypesStr

2012-10-17 Thread Eric Blake
On 10/17/2012 08:48 AM, Viktor Mihajlovski wrote: > The machine in the last output line of -M ? > was always reported as default machine even if this wasn't the > actual default. Trivial fix. > > Signed-off-by: Viktor Mihajlovski > --- > src/qemu/qemu_capabilities.c |2 +- > 1 files changed

Re: [libvirt] [PATCH 3/3] qemu: Add support for HyperV Enlightenment feature "relaxed"

2012-10-17 Thread Eric Blake
On 10/17/2012 07:54 AM, Peter Krempa wrote: > This patch adds support for the "relaxed" feature implemented by > previous patch. > --- > src/qemu/qemu_command.c | 38 > + > tests/qemuxml2argvdata/qemuxml2argv-hyperv.args | 4 +++ > tests/qemuxml2ar

Re: [libvirt] [PATCH 2/3] conf: Add support for HyperV Enlightenment features

2012-10-17 Thread Eric Blake
On 10/17/2012 07:54 AM, Peter Krempa wrote: > Hypervisors are starting to support HyperV englightenment features that > improve behavior of guests running Microsoft Windows operating systems. s/englightenment/enlightenment/ > > This patch adds support for the "relaxed" feature that improves time

Re: [libvirt] [PATCH 1/3] conf: Make tri-state feature options more universal

2012-10-17 Thread Eric Blake
On 10/17/2012 07:54 AM, Peter Krempa wrote: > The apic-eoi feature enum and implementation can be made more universal > to allow re-use of the enum for other features. > --- > src/conf/domain_conf.c | 6 +++--- > src/conf/domain_conf.h | 14 +++--- > src/libvirt_private.syms | 4 ++--

[libvirt] [PATCHv3 15/19] blockjob: manage qemu block-commit monitor command

2012-10-17 Thread Eric Blake
qemu 1.3 will be adding a 'block-commit' monitor command, per qemu.git commit ed61fc1. It matches nicely to the libvirt API virDomainBlockCommit. * src/qemu/qemu_capabilities.h (QEMU_CAPS_BLOCK_COMMIT): New bit. * src/qemu/qemu_capabilities.c (qemuCapsProbeQMPCommands): Set it. * src/qemu/qemu_mo

[libvirt] [PATCHv3 17/19] blockjob: implement shallow commit flag in qemu

2012-10-17 Thread Eric Blake
Now that we can crawl the chain of backing files, we can do argument validation and implement the 'shallow' flag. In testing this, I discovered that it can be handy to pass the shallow flag and an explicit base, as a means of validating that the base is indeed the file we expected. * src/qemu/qem

[libvirt] [PATCHv3 14/19] blockjob: remove unused parameters after previous patch

2012-10-17 Thread Eric Blake
Minor cleanup made possible by previous simplifications. * src/qemu/qemu_cgroup.h (qemuSetupDiskCgroup) (qemuTeardownDiskCgroup): Alter signature. * src/qemu/qemu_cgroup.c (qemuSetupDiskCgroup) (qemuTeardownDiskCgroup, qemuSetupCgroup): Update all uses. * src/qemu/qemu_hotplug.c (qemuDomainDetachP

[libvirt] [PATCHv3 13/19] storage: use cache to walk backing chain

2012-10-17 Thread Eric Blake
We used to walk the backing file chain at least twice per disk, once to set up cgroup device whitelisting, and once to set up security labeling. Rather than walk the chain every iteration, which possibly includes calls to fork() in order to open root-squashed NFS files, we can exploit the cache of

[libvirt] [PATCHv3 11/19] storage: make it easier to find file within chain

2012-10-17 Thread Eric Blake
In order to temporarily label files read/write during a commit operation, we need to crawl the backing chain and find the absolute file name that needs labeling in the first place, as well as the name of the file that owns the backing file. * src/util/storage_file.c (virStorageFileChainLookup): Ne

[libvirt] [PATCHv3 18/19] blockjob: refactor qemu disk chain permission grants

2012-10-17 Thread Eric Blake
Previously, snapshot code did its own permission granting (lock manager, cgroup device controller, and security manager labeling) inline. But now that we are adding block-commit and block-copy which also have to change permissions, it's better to reuse common code for the task. While snapshot sho

[libvirt] [PATCHv3 12/19] storage: cache backing chain while qemu domain is live

2012-10-17 Thread Eric Blake
Technically, we should not be re-probing any file that qemu might be currently writing to. As such, we should cache the backing file chain prior to starting qemu. This patch adds the cache, but does not use it until the next patch. Ultimately, we want to also store the chain in domain XML, so th

[libvirt] [PATCHv3 16/19] blockjob: wire up online qemu block-commit

2012-10-17 Thread Eric Blake
This is the bare minimum to kick off a block commit. In particular, flags support is missing (shallow requires us to crawl the backing chain to determine the file name to pass to the qemu monitor command; delete requires us to track what needs to be deleted at the time the completion event fires).

[libvirt] [PATCHv3 19/19] blockjob: properly label disks for qemu block-commit

2012-10-17 Thread Eric Blake
I finally have all the pieces in place to perform a block-commit with SELinux enforcing. There's still missing cleanup work when the commit completes, but doing that requires tracking both the backing chain and the base and top files within that chain in domain XML across libvirtd restarts. Furth

[libvirt] [PATCHv3 10/19] storage: remember relative names in backing chain

2012-10-17 Thread Eric Blake
In order to search for a backing file name as literally present in a chain, we need to remember if the chain had relative names. Also, searching for absolute names is easier if we only have to canonicalize once, rather than on every iteration. * src/util/storage_file.h (_virStorageFileMetadata): A

[libvirt] [PATCHv3 09/19] storage: don't require caller to pre-allocate metadata struct

2012-10-17 Thread Eric Blake
Requiring pre-allocation was an unusual idiom. It allowed iteration over the backing chain to use fewer mallocs, but made one-shot clients harder to read. Also, this makes it easier for a future patch to move away from opening fds on every iteration over the chain. * src/util/storage_file.h (vir

[libvirt] [PATCHv3 03/19] storage: match RNG to supported driver types

2012-10-17 Thread Eric Blake
At one point, the code passed through arbitrary strings for file formats, which supposedly lets qemu handle a new file type even before libvirt has been taught to handle it. However, to properly label files, libvirt has to learn the file type anyway, so we might as well make our life easier by onl

[libvirt] [PATCHv3 05/19] storage: use enum for disk driver type

2012-10-17 Thread Eric Blake
Actually use the enum in the domain conf structure. * src/conf/domain_conf.h (_virDomainDiskDef): Store enum rather than string for disk type. * src/conf/domain_conf.c (virDomainDiskDefFree) (virDomainDiskDefParseXML, virDomainDiskDefFormat) (virDomainDiskDefForeachPath): Adjust users. * src/xenxs

[libvirt] [PATCHv3 01/19] storage: list more file types

2012-10-17 Thread Eric Blake
When an image has no backing file, using VIR_STORAGE_FILE_AUTO for its type is a bit confusing. Additionally, a future patch would like to reserve a default value for the case of no file type specified in the XML, but different from the current use of -1 to imply probing, since probing is not alwa

[libvirt] [PATCHv3 07/19] storage: don't probe non-files

2012-10-17 Thread Eric Blake
Backing chains can end on a network protocol, such as nbd:xxx; we should not attempt to probe the file system in this case. * src/storage/storage_backend_fs.c (virStorageBackendProbeTarget): Only probe files. --- src/storage/storage_backend_fs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletio

[libvirt] [PATCHv3 06/19] storage: use enum for snapshot driver type

2012-10-17 Thread Eric Blake
This is the last use of raw strings for disk formats throughout the src/conf directory. * src/conf/snapshot_conf.h (_virDomainSnapshotDiskDef): Store enum rather than string for disk type. * src/conf/snapshot_conf.c (virDomainSnapshotDiskDefClear) (virDomainSnapshotDiskDefParseXML, virDomainSnapsh

[libvirt] [PATCHv3 08/19] storage: get entire metadata chain in one call

2012-10-17 Thread Eric Blake
Previously, no one was using virStorageFileGetMetadata, and for good reason - it couldn't support root-squash NFS. Change the signature and make it useful to future patches, including enhancing the metadata to recursively track the entire chain. * src/util/storage_file.h (_virStorageFileMetadata)

[libvirt] [PATCHv3 02/19] storage: treat 'aio' like 'raw' at parse time

2012-10-17 Thread Eric Blake
We have historically allowed 'aio' as a synonym for 'raw' for back-compat to xen, but since a future patch will move to using an enum value, we have to pick one to be our preferred output name. This is a slight change in the output XML, but the sexpr and xm outputs should still be identical, and t

[libvirt] [PATCHv3 00/19] qemu block-commit support

2012-10-17 Thread Eric Blake
This v3 posting resolves all the comments I had from Doug, Laine, and myself, and has passed my testing with SELinux enabled. v2 was here: https://www.redhat.com/archives/libvir-list/2012-October/msg00633.html See below for interdiff, and individual patches for more notes about changes Also avail

[libvirt] [PATCHv3 04/19] storage: use enum for default driver type

2012-10-17 Thread Eric Blake
Express the default disk type as an enum, for easier handling. * src/conf/capabilities.h (_virCaps): Store enum rather than string for disk type. * src/conf/domain_conf.c (virDomainDiskDefParseXML): Adjust clients. * src/qemu/qemu_driver.c (qemuCreateCapabilities): Likewise. --- src/conf/capabili

Re: [libvirt] [PATCHv2 16/16] blockjob: implement shallow commit flag in qemu

2012-10-17 Thread Eric Blake
On 10/17/2012 03:28 PM, Laine Stump wrote: > On 10/13/2012 06:00 PM, Eric Blake wrote: >> Now that we can crawl the chain of backing files, we can do >> argument validation and implement the 'shallow' flag. In >> testing this, I discovered that it can be handy to pass the >> shallow flag and an ex

Re: [libvirt] Add hyperthreaded sibling info to virsh capabilities

2012-10-17 Thread Eric Blake
On 10/17/2012 03:06 PM, Dusty Mabe wrote: > Hi, > > Would it be possible to augment the output produced in virsh > capabilities to also provide the hyperthreaded sibling of a processor? > For example the information would look something like: > > > > > > > >

Re: [libvirt] [PATCHv2 16/16] blockjob: implement shallow commit flag in qemu

2012-10-17 Thread Laine Stump
On 10/13/2012 06:00 PM, Eric Blake wrote: > Now that we can crawl the chain of backing files, we can do > argument validation and implement the 'shallow' flag. In > testing this, I discovered that it can be handy to pass the > shallow flag and an explicit base, as a means of validating > that the

Re: [libvirt] [PATCHv2 13/16] storage: use cache to walk backing chain

2012-10-17 Thread Eric Blake
On 10/16/2012 03:16 PM, Eric Blake wrote: >>> +if (disk->format > 0) >>> +format = disk->format; >>> +else if (ctl->allowDiskFormatProbing) >>> +format = VIR_STORAGE_FILE_AUTO; >>> +else >>> +format = VIR_STORAGE_FILE_RAW; >> >> It seems

Re: [libvirt] [PATCHv2 15/16] blockjob: wire up online qemu block-commit

2012-10-17 Thread Laine Stump
On 10/13/2012 06:00 PM, Eric Blake wrote: > This is the bare minimum to kick off a block commit. In particular, > flags support is missing (shallow requires us to crawl the backing > chain to determine the file name to pass to the qemu monitor command; > delete requires us to track what needs to b

[libvirt] [PATCH 3/5] Use helper functions to format the journal iov array

2012-10-17 Thread Miloslav Trmač
This simplifies the top-level code, at the cost of using a little more stack space. The primary benefit is being able to send more fields without knowing in advance how many of them, and of which types, these fields will be, and without having to individually add buffer variables. The code impose

[libvirt] [PATCH 4/5] Add detailed error information to journal

2012-10-17 Thread Miloslav Trmač
When logging an error, don't throw away the detailed information. Example record when using the journald output: MESSAGE=Domain not found PRIORITY=4 LIBVIRT_SOURCE=error CODE_FILE=../../src/test/test_driver.c CODE_LINE=1405 CODE_FUNC=testLookupDomain

[libvirt] [PATCH 5/5] Add "syslog/json" log output format.

2012-10-17 Thread Miloslav Trmač
This is independent from the rest of the series, sending it anyway for consideration; this makes the metadata available to users on non-systemd platforms. I believe the technical objections (primarily async-signal-safety) have been resolved; the question of whether the project wants to support thi

[libvirt] [PATCH 2/5] Add metadata to virLogOutputFunc

2012-10-17 Thread Miloslav Trmač
... and update all users. No change in functionality, the parameter will be used in the next patch. Signed-off-by: Miloslav Trmač --- src/util/logging.c | 14 +- src/util/logging.h | 2 ++ tests/testutils.c | 1 + 3 files changed, 12 insertions(+), 5 deletions(-) diff --git a/sr

[libvirt] [PATCH 0/5] Structured error logging and syslog support

2012-10-17 Thread Miloslav Trmač
This is sort of a v2 of the "Structured syslog" series. Patches 1-4 allow callers virLogMessage to add arbitrary additional data, and use it in virRaiseErrorFull and its callers. This data is sent to journal (and ignored for other outputs). Because the additional fields for errors include virErr

[libvirt] [PATCH 1/5] Add a metadata parameter to virLog{, V}Message

2012-10-17 Thread Miloslav Trmač
... and update all users. No change in functionality, the parameter will be used later. The metadata representation is as minimal as possible, but requires the caller to allocate an array on stack explicitly. The alternative of using varargs in the virLogMessage() callers: * Would not allow the

Re: [libvirt] [PATCH] qemu: Pin the emulator when only cpuset is specified

2012-10-17 Thread Martin Kletzander
On 10/17/2012 06:02 PM, Michal Privoznik wrote: > On 17.10.2012 17:38, Martin Kletzander wrote: >> According to our recent changes (clarifications), we should be pinning >> qemu's emulator processes using the 'cpuset' attribute in case >> there is no specified. This however doesn't work >> entir

Re: [libvirt] [PATCH 1/2] selinux: fix wrong tapfd relablling

2012-10-17 Thread Guannan Ren
On 10/17/2012 11:39 PM, Laine Stump wrote: On 10/16/2012 11:32 PM, Guannan Ren wrote: It should relabel tapfd of virtual network of type VIR_DOMAIN_NET_TYPE_DIRECT rather than VIR_DOMAIN_NET_TYPE_NETWORK and VIR_DOMAIN_NET_TYPE_BRIDGE (commit ae368ebfcc4923d0b32e83d4ca96a6f599625785 introduced t

Re: [libvirt] [PATCH] qemu: Pin the emulator when only cpuset is specified

2012-10-17 Thread Michal Privoznik
On 17.10.2012 17:38, Martin Kletzander wrote: > According to our recent changes (clarifications), we should be pinning > qemu's emulator processes using the 'cpuset' attribute in case > there is no specified. This however doesn't work > entirely as expected and this patch should resolve all the

[libvirt] [PATCH] qemu: Pin the emulator when only cpuset is specified

2012-10-17 Thread Martin Kletzander
According to our recent changes (clarifications), we should be pinning qemu's emulator processes using the 'cpuset' attribute in case there is no specified. This however doesn't work entirely as expected and this patch should resolve all the remaining issues. --- src/qemu/qemu_cgroup.c | 25 ++

[libvirt] [PATCHv2 7/9] virNodeGetCPUMapFlags: Implement support function in nodeinfo

2012-10-17 Thread Viktor Mihajlovski
Added an implemention of virNodeGetCPUMapFlags to nodeinfo.c, (nodeGetCPUMapFlags) which can be used by all drivers for a Linux hypervisor host. Signed-off-by: Viktor Mihajlovski --- src/libvirt_private.syms |1 + src/nodeinfo.c | 49 ++

Re: [libvirt] [PATCH 1/2] selinux: fix wrong tapfd relablling

2012-10-17 Thread Laine Stump
On 10/16/2012 11:32 PM, Guannan Ren wrote: > It should relabel tapfd of virtual network of type VIR_DOMAIN_NET_TYPE_DIRECT > rather than VIR_DOMAIN_NET_TYPE_NETWORK and VIR_DOMAIN_NET_TYPE_BRIDGE > (commit ae368ebfcc4923d0b32e83d4ca96a6f599625785 introduced this bug) > --- > src/qemu/qemu_command.

Re: [libvirt] [PATCH v3 4/4] qemu-config: Add new -add-fd command line option

2012-10-17 Thread Eric Blake
On 10/17/2012 08:02 AM, Kevin Wolf wrote: > Am 17.10.2012 06:16, schrieb Eric Blake: >> I'm still seeing the corner case of: >> >> qemu-kvm -add-fd fd=3,set=1 -add-fd fd=4,set=2 4<&- >> >> where the dup(3) will populate fd 4 prior to the point where we get to >> process the -add-fd fd=4 command to

Re: [libvirt] [PATCH v3 4/4] qemu-config: Add new -add-fd command line option

2012-10-17 Thread Kevin Wolf
Am 17.10.2012 17:01, schrieb Eric Blake: > On 10/17/2012 08:02 AM, Kevin Wolf wrote: >> Am 17.10.2012 06:16, schrieb Eric Blake: >>> I'm still seeing the corner case of: >>> >>> qemu-kvm -add-fd fd=3,set=1 -add-fd fd=4,set=2 4<&- >>> >>> where the dup(3) will populate fd 4 prior to the point where

[libvirt] [PATCH] qemu: Fixed default machine detection in qemuCapsParseMachineTypesStr

2012-10-17 Thread Viktor Mihajlovski
The machine in the last output line of -M ? was always reported as default machine even if this wasn't the actual default. Trivial fix. Signed-off-by: Viktor Mihajlovski --- src/qemu/qemu_capabilities.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/qemu/qemu_capa

Re: [libvirt] [PATCH 2/3] Add a "forward family" option

2012-10-17 Thread Benjamin Cama
Hi, First, thanks Michal for your review. Le lundi 15 octobre 2012 à 11:31 -0700, Laine Stump a écrit : > On 10/15/2012 10:54 AM, Michal Privoznik wrote: > > On 15.10.2012 12:27, Benjamin Cama wrote: > >> It allows to specify forwarding only for IPv4 or IPv6. Not specifying it > >> enables forwar

Re: [libvirt] [PATCH 1/3] Only check for IP forwarding, do not enable it

2012-10-17 Thread Benjamin Cama
Hi everyone, Le lundi 15 octobre 2012 à 09:36 -0700, Cole Robinson a écrit : > On 10/15/2012 12:04 PM, Cole Robinson wrote: > > On 10/15/2012 10:54 AM, Michal Privoznik wrote: > >> On 15.10.2012 12:26, Benjamin Cama wrote: > >>> > >>> static int > >>> networkSetIPv6Sysctls(virNetworkObjPtr net

Re: [libvirt] [PATCH v3 4/4] qemu-config: Add new -add-fd command line option

2012-10-17 Thread Kevin Wolf
Am 17.10.2012 06:16, schrieb Eric Blake: > I'm still seeing the corner case of: > > qemu-kvm -add-fd fd=3,set=1 -add-fd fd=4,set=2 4<&- > > where the dup(3) will populate fd 4 prior to the point where we get to > process the -add-fd fd=4 command to notice that the user started > qemu-kvm with fd

[libvirt] [PATCH 1/3] conf: Make tri-state feature options more universal

2012-10-17 Thread Peter Krempa
The apic-eoi feature enum and implementation can be made more universal to allow re-use of the enum for other features. --- src/conf/domain_conf.c | 6 +++--- src/conf/domain_conf.h | 14 +++--- src/libvirt_private.syms | 4 ++-- src/qemu/qemu_command.c | 6 +++--- 4 files changed,

[libvirt] [PATCH 0/3] Add support for HyperV Enlightenment features

2012-10-17 Thread Peter Krempa
This series adds framework to deal with various HyperV Enlightenment features that improve behavior of Microsoft Windows guests. First of the features implemented is "relaxed" that changes the behavior of timers. The series is designed to ease addition of other hyperv features in the future. Pet

[libvirt] [PATCH 3/3] qemu: Add support for HyperV Enlightenment feature "relaxed"

2012-10-17 Thread Peter Krempa
This patch adds support for the "relaxed" feature implemented by previous patch. --- src/qemu/qemu_command.c | 38 + tests/qemuxml2argvdata/qemuxml2argv-hyperv.args | 4 +++ tests/qemuxml2argvdata/qemuxml2argv-hyperv.xml | 28 ++ te

[libvirt] [PATCH 2/3] conf: Add support for HyperV Enlightenment features

2012-10-17 Thread Peter Krempa
Hypervisors are starting to support HyperV englightenment features that improve behavior of guests running Microsoft Windows operating systems. This patch adds support for the "relaxed" feature that improves timer behavior and also establishes a framework to add these features in future. --- docs

Re: [libvirt] [PATCH] qemu: Clear async job when p2p migration fails early

2012-10-17 Thread Jiri Denemark
On Wed, Oct 17, 2012 at 14:34:25 +0200, Peter Krempa wrote: > On 10/17/12 14:29, Jiri Denemark wrote: > > When p2p migration fails early because qemuMigrationIsAllowed or > > qemuMigrationIsSafe say migration should be cancelled, we fail to clear > > the migration-out async job. As a result of that

Re: [libvirt] [PATCH v3 2/4] monitor: Enable adding an inherited fd to an fd set

2012-10-17 Thread Kevin Wolf
Am 16.10.2012 20:08, schrieb Corey Bryant: > qmp_add_fd() gets an fd that was received over a socket with > SCM_RIGHTS and adds it to an fd set. This patch adds support > that will enable adding an fd that was inherited on the > command line to an fd set. > > Note: All of the code added to monito

Re: [libvirt] [PATCH] qemu: Clear async job when p2p migration fails early

2012-10-17 Thread Jiri Denemark
On Wed, Oct 17, 2012 at 14:29:04 +0200, Jiri Denemark wrote: > When p2p migration fails early because qemuMigrationIsAllowed or > qemuMigrationIsSafe say migration should be cancelled, we fail to clear > the migration-out async job. As a result of that, further APIs called > for the same domain may

Re: [libvirt] [PATCH] qemu: Clear async job when p2p migration fails early

2012-10-17 Thread Peter Krempa
On 10/17/12 14:29, Jiri Denemark wrote: When p2p migration fails early because qemuMigrationIsAllowed or qemuMigrationIsSafe say migration should be cancelled, we fail to clear the migration-out async job. As a result of that, further APIs called for the same domain may fail with Timed out during

[libvirt] [PATCH] qemu: Clear async job when p2p migration fails early

2012-10-17 Thread Jiri Denemark
When p2p migration fails early because qemuMigrationIsAllowed or qemuMigrationIsSafe say migration should be cancelled, we fail to clear the migration-out async job. As a result of that, further APIs called for the same domain may fail with Timed out during operation: cannot acquire state change lo

Re: [libvirt] [PATCH] interface: add virInterfaceGetXMLDesc() in udev

2012-10-17 Thread Michal Privoznik
On 15.10.2012 00:02, Doug Goldstein wrote: > Added support for retrieving the XML defining a specific interface via > the udev based backend to virInterface. Implement the following APIs > for the udev based backend: > * virInterfaceGetXMLDesc() > > Note: Does not support bond devices. > --- > sr

Re: [libvirt] [PATCH 1/2] selinux: fix wrong tapfd relablling

2012-10-17 Thread Guannan Ren
On 10/17/2012 04:30 PM, Daniel P. Berrange wrote: On Wed, Oct 17, 2012 at 11:32:45AM +0800, Guannan Ren wrote: It should relabel tapfd of virtual network of type VIR_DOMAIN_NET_TYPE_DIRECT rather than VIR_DOMAIN_NET_TYPE_NETWORK and VIR_DOMAIN_NET_TYPE_BRIDGE (commit ae368ebfcc4923d0b32e83d4ca96

[libvirt] [PATCHv2 0/9] New API to retrieve host node CPU map

2012-10-17 Thread Viktor Mihajlovski
V2 Changes: Added python binding for virNodeGetCPUMapFlags. Removed RFC stanza. --- Viktor Mihajlovski (9): virNodeGetCPUMapFlags: Define public API. virNodeGetCPUMapFlags: Define driver API. virNodeGetCPUMapFlags: Implement public API. virNodeGetCPUMapFlags: Implement wire protocol.

[libvirt] [PATCHv2 4/9] virNodeGetCPUMapFlags: Implement wire protocol.

2012-10-17 Thread Viktor Mihajlovski
- Defined the wire protocol format for virNodeGetCPUMapFlags and its arguments - Implemented remote method invocation (remoteNodeGetCPUMapFlags) - Implemented method dispacher (remoteDispatchNodeGetCPUMapFlags) Signed-off-by: Viktor Mihajlovski --- daemon/remote.c | 44 +

Re: [libvirt] [PATCH 2/2] Add syntax-check rule to look for 'function (...args...)' violations

2012-10-17 Thread Martin Kletzander
On 10/17/2012 11:31 AM, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > Checking for 'function (...args...)' is quite difficult since it > needs to ignore valid usage with keywords like 'if (...test...)' > and while/for/switch. It must also ignore source comments and > quoted strings.

Re: [libvirt] [PATCH 1/2] Remove spurious whitespace between function name & open brackets

2012-10-17 Thread Martin Kletzander
On 10/17/2012 11:31 AM, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > The libvirt coding standard is to use 'function(...args...)' > instead of 'function (...args...)'. A non-trivial number of > places did not follow this rule and are fixed in this patch. > > Signed-off-by: Daniel P

[libvirt] [PATCH] AUTHORS: Remove double entry

2012-10-17 Thread Michal Privoznik
I've accidentally added Li Zhang to AUTHORS, even if he already was there. --- Pushing under trivial rule. AUTHORS |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/AUTHORS b/AUTHORS index 221912d..27c4eda 100644 --- a/AUTHORS +++ b/AUTHORS @@ -268,7 +268,6 @@ Patches hav

Re: [libvirt] [PATCH v2 1/3] Add one file cpu_ppc_data.h to define CPU data for PPC

2012-10-17 Thread Li Zhang
On Wed, Oct 17, 2012 at 4:16 PM, Michal Privoznik wrote: > On 15.10.2012 11:07, Li Zhang wrote: >> CPU version can be got by PVR on PowerPC. So this PVR is defined in >> the CPU data in cpuData structure. >> >> Signed-off-by: Li Zhang >> Acked-by: Michal Privoznik > > We tend to write space betwe

[libvirt] [PATCH 2/2] Add syntax-check rule to look for 'function (...args...)' violations

2012-10-17 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Checking for 'function (...args...)' is quite difficult since it needs to ignore valid usage with keywords like 'if (...test...)' and while/for/switch. It must also ignore source comments and quoted strings. It is not possible todo this with a simple regex in the norma

Re: [libvirt] [PATCH v2 2/3] Implement CPU model driver for PowerPC

2012-10-17 Thread Li Zhang
On Wed, Oct 17, 2012 at 4:21 PM, Michal Privoznik wrote: > Oh, I've just hit 'Send' without noticing > > On 15.10.2012 11:07, Li Zhang wrote: >> Currently, the CPU model driver is not implemented for PowerPC. >> Host's CPU information is needed to exposed to guests' XML file some >> time. >>

[libvirt] [PATCH 0/2] Kill off 'function (...args...)' whitespace

2012-10-17 Thread Daniel P. Berrange
Libvirt normally omits whitespace between the function name and its args, but there are still approx 1000 places where whitespace is included. Since people can't follow the style, clean this up and then enforce it with syntax-check. -- libvir-list mailing list libvir-list@redhat.com https://www.re

Re: [libvirt] [PATCH v2 0/3] Implement CPU model driver for PowerPC

2012-10-17 Thread Li Zhang
On Wed, Oct 17, 2012 at 4:22 PM, Michal Privoznik wrote: > On 15.10.2012 11:07, Li Zhang wrote: >> CPU model driver is to get host's CPU information and it also provides >> one mechanism to expose host's CPU information to guests during migration. >> >> When migrating one guest from one machine to

Re: [libvirt] [PATCH 1/2] selinux: fix wrong tapfd relablling

2012-10-17 Thread Daniel P. Berrange
On Wed, Oct 17, 2012 at 11:32:45AM +0800, Guannan Ren wrote: > It should relabel tapfd of virtual network of type VIR_DOMAIN_NET_TYPE_DIRECT > rather than VIR_DOMAIN_NET_TYPE_NETWORK and VIR_DOMAIN_NET_TYPE_BRIDGE > (commit ae368ebfcc4923d0b32e83d4ca96a6f599625785 introduced this bug) Why ? IMHO,

Re: [libvirt] [PATCH v2 2/3] Implement CPU model driver for PowerPC

2012-10-17 Thread Michal Privoznik
Oh, I've just hit 'Send' without noticing On 15.10.2012 11:07, Li Zhang wrote: > Currently, the CPU model driver is not implemented for PowerPC. > Host's CPU information is needed to exposed to guests' XML file some > time. > > This patch is to implement the callback functions of CPU model d

Re: [libvirt] [PATCH v2 0/3] Implement CPU model driver for PowerPC

2012-10-17 Thread Michal Privoznik
On 15.10.2012 11:07, Li Zhang wrote: > CPU model driver is to get host's CPU information and it also provides > one mechanism to expose host's CPU information to guests during migration. > > When migrating one guest from one machine to another machine, it will > compare the CPU information. If it

Re: [libvirt] [PATCH v2 1/3] Add one file cpu_ppc_data.h to define CPU data for PPC

2012-10-17 Thread Michal Privoznik
On 15.10.2012 11:07, Li Zhang wrote: > CPU version can be got by PVR on PowerPC. So this PVR is defined in > the CPU data in cpuData structure. > > Signed-off-by: Li Zhang > Acked-by: Michal Privoznik We tend to write space between name and e-mail address. > --- > src/cpu/cpu.h |3

Re: [libvirt] [PATCH v2 3/3] Doc-fix for PowerPC CPU model driver

2012-10-17 Thread Michal Privoznik
On 15.10.2012 11:07, Li Zhang wrote: > There are some descriptions not right in PowerPC CPU model driver. > This patch is to fix them. > > Signed-off-by: Li Zhang > Acked-by: Michal Privoznik > --- > src/cpu/cpu_powerpc.c |4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) ACK Mich

Re: [libvirt] [PATCH v2 2/3] Implement CPU model driver for PowerPC

2012-10-17 Thread Michal Privoznik
On 15.10.2012 11:07, Li Zhang wrote: > Currently, the CPU model driver is not implemented for PowerPC. > Host's CPU information is needed to exposed to guests' XML file some > time. > > This patch is to implement the callback functions of CPU model driver. > > Signed-off-by: Li Zhang > --- > po