Re: [libvirt] [PATCH] qemu: Cleanup the unused 'nodeinfo'

2012-10-21 Thread Osier Yang
On 2012年10月20日 00:13, Eric Blake wrote: On 10/18/2012 10:09 PM, Osier Yang wrote: "nodeinfo" is not used in these two functions, and it's waste of goto in qemuProcessSetEmulatorAffinites --- src/qemu/qemu_process.c | 20 1 files changed, 4 insertions(+), 16 deletions(-)

Re: [libvirt] [PATCH] qemu: Pin the emulator when only cpuset is specified

2012-10-21 Thread Osier Yang
On 2012年10月19日 16:42, Martin Kletzander wrote: On 10/19/2012 05:45 AM, Osier Yang wrote: On 2012年10月17日 23:38, Martin Kletzander wrote: According to our recent changes (clarifications), we should be pinning qemu's emulator processes using the 'cpuset' attribute in case there is no specified

Re: [libvirt] [RFC] [PATCH v3 2/6] add fuse support for libvirt lxc

2012-10-21 Thread Gao feng
Hi I will rebase and send this patchset as I think you all agree with me. Thanks! Gao -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH RFC] helper of copy-storage-* features

2012-10-21 Thread li guang
在 2012-10-21日的 21:09 -0500，Doug Goldstein写道： > On Sun, Oct 21, 2012 at 7:53 PM, liguang wrote: > > help to create disk images copy-storage-* required, > > try to do non-shared migration without bothering to > > create disk images at target by hand. > > > > consider this situation: > > 1. non-share

Re: [libvirt] [PATCH RFC] helper of copy-storage-* features

2012-10-21 Thread Doug Goldstein
On Sun, Oct 21, 2012 at 7:53 PM, liguang wrote: > help to create disk images copy-storage-* required, > try to do non-shared migration without bothering to > create disk images at target by hand. > > consider this situation: > 1. non-shared migration >virsh migrate --copy-storage-all ... > 2.

[libvirt] [PATCH RFC] helper of copy-storage-* features

2012-10-21 Thread liguang
help to create disk images copy-storage-* required, try to do non-shared migration without bothering to create disk images at target by hand. consider this situation: 1. non-shared migration virsh migrate --copy-storage-all ... 2. migration fails 3. create disk images required qemu-img creat

Re: [libvirt] [PATCH] network: always create dnsmasq hosts and addnhosts files, even if empty

2012-10-21 Thread Laine Stump
On 10/20/2012 12:44 PM, Eric Blake wrote: > On 10/20/2012 01:52 AM, Laine Stump wrote: >> This fixes the problem reported in: >> >> https://bugzilla.redhat.com/show_bug.cgi?id=868389 >> >> Previously, the dnsmasq hosts file (used for static dhcp entries, and >> addnhosts file (used for additional

Re: [libvirt] RFC: advertising graphics support (vnc, spice, sdl)

2012-10-21 Thread Doug Goldstein
On Sun, Oct 21, 2012 at 3:26 PM, Cole Robinson wrote: > On 10/19/2012 02:31 AM, Doug Goldstein wrote: >> Currently consumers of libvirt's APIs must assume/attempt to define a >> VM that uses spice, vnc, or sdl without knowing if the actual >> hypervisor supports it. Obviously my discussion is very

Re: [libvirt] [PATCH] qemu: Fix domxml-to-native network model conversion

2012-10-21 Thread Cole Robinson
On 10/21/2012 05:59 AM, Peter Krempa wrote: > On 10/21/12 04:49, Cole Robinson wrote: >> https://bugzilla.redhat.com/show_bug.cgi?id=636832 >> --- >> src/qemu/qemu_driver.c | 9 + >> 1 file changed, 9 insertions(+) >> >> diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c >> ind

Re: [libvirt] [PATCH] tools: Only install guests init script if --with-init=script=redhat

2012-10-21 Thread Cole Robinson
On 10/21/2012 07:08 AM, Peter Krempa wrote: > On 10/21/12 04:49, Cole Robinson wrote: >> Required to fix https://bugzilla.redhat.com/show_bug.cgi?id=789747 >> --- >> libvirt.spec.in | 5 - >> tools/Makefile.am | 4 ++-- >> 2 files changed, 6 insertions(+), 3 deletions(-) >> > > Unfortuna

[libvirt] [PATCH v2] qemu: Fix domxml-to-native network model conversion

2012-10-21 Thread Cole Robinson
https://bugzilla.redhat.com/show_bug.cgi?id=636832 --- v2: Don't needlessly reallocate model src/qemu/qemu_driver.c | 4 1 file changed, 4 insertions(+) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index feda4d9..7c462a2 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qem

[libvirt] [PATCH] selinux: Don't fail RestoreAll if file doesn't have a default label

2012-10-21 Thread Cole Robinson
When restoring selinux labels after a VM is stopped, any non-standard path that doesn't have a default selinux label causes the process to stop and exit early. This isn't really an error condition IMO. Of course the selinux API could be erroring for some other reason but hopefully that's rare enou

[libvirt] [PATCH v2] tools: Only install guests init script if --with-init=script=redhat

2012-10-21 Thread Cole Robinson
Most of this deals with moving the libvirt-guests.sh script which does all the work to /usr/libexec, so it can be shared by both systemd and traditional init. Previously systemd depended on the script being in /etc/init.d Required to fix https://bugzilla.redhat.com/show_bug.cgi?id=789747 --- v2:

Re: [libvirt] RFC: advertising graphics support (vnc, spice, sdl)

2012-10-21 Thread Cole Robinson
On 10/19/2012 02:31 AM, Doug Goldstein wrote: > Currently consumers of libvirt's APIs must assume/attempt to define a > VM that uses spice, vnc, or sdl without knowing if the actual > hypervisor supports it. Obviously my discussion is very QEMU oriented > but it would be good to leave expansion for

Re: [libvirt] [PATCH] Fix disabling of apparmor security driver

2012-10-21 Thread Christophe Fergeau
self NACK, a similar issue seems to be present a bit further in configure.ac, I'll have to look some more and send a v2 Christophe On Sun, Oct 21, 2012 at 08:38:49PM +0200, Christophe Fergeau wrote: > When using --without-apparmor --without-secdriver-apparmor, configure > will fail saying that Ap

[libvirt] [PATCH] Fix disabling of apparmor security driver

2012-10-21 Thread Christophe Fergeau
When using --without-apparmor --without-secdriver-apparmor, configure will fail saying that AppArmor development package must be installed. This is caused by a small bug in --with-secdriver-apparmor handling in configure.ac which treats --without-secdriver-apparmor as if the user had requested to e

Re: [libvirt] [PATCH] Log file name passed to virConfReadFile

2012-10-21 Thread Cole Robinson
On 10/20/2012 03:49 PM, Eric Blake wrote: > On 10/20/2012 01:41 PM, Cole Robinson wrote: >> --- >> src/util/conf.c | 3 +++ >> 1 file changed, 3 insertions(+) > > ACK. > Thanks Eric, pushed now. - Cole -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/

Re: [libvirt] [PATCH] docs: virsh: clarify behavior of send-key

2012-10-21 Thread Cole Robinson
On 10/21/2012 05:36 AM, Peter Krempa wrote: > On 10/21/12 02:31, Cole Robinson wrote: >> https://bugzilla.redhat.com/show_bug.cgi?id=860004 >> --- >> tools/virsh.pod | 10 +- >> 1 file changed, 9 insertions(+), 1 deletion(-) >> > > ACK. > Thanks Peter, pushed now. - Cole -- libvir-l

Re: [libvirt] [PATCH] Log parameters passed to virFileMakePath

2012-10-21 Thread Cole Robinson
On 10/21/2012 05:37 AM, Peter Krempa wrote: > On 10/21/12 00:31, Cole Robinson wrote: >> --- >> src/util/util.c | 2 ++ >> 1 file changed, 2 insertions(+) >> > > ACK. > Thanks Peter, pushed now. - Cole -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinf

Re: [libvirt] [PATCH] daemon: Avoid 'Could not find keytab file' in syslog

2012-10-21 Thread Cole Robinson
On 10/20/2012 03:15 PM, Eric Blake wrote: > On 10/20/2012 12:51 PM, Cole Robinson wrote: >> On F17 at least, every time libvirtd starts we get this in syslog: >> >> libvirtd: Could not find keytab file: /etc/libvirt/krb5.tab: No such file or >> directory >> >> This comes from cyrus-sasl, and happe

Re: [libvirt] [PATCH] qemu: Don't use -enable-nesting with qemu 1.2.0+

2012-10-21 Thread Cole Robinson
On 10/20/2012 03:49 PM, Eric Blake wrote: > On 10/20/2012 01:28 PM, Cole Robinson wrote: >> Since the option doesn't exist. Fixes booting with >> cpu mode='host-model' and qemu 1.2.0 >> --- >> src/qemu/qemu_capabilities.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/src/qemu/qemu_cap

[libvirt] [PATCH] storage: Don't do wait loops from VolLookupByPath

2012-10-21 Thread Cole Robinson
virStorageVolLookupByPath is an API call that virt-manager uses quite a bit when dealing with storage. This call use BackendStablePath which has several usleep() heuristics that can be tripped up and hang virt-manager for a while. Current example: an empty mpath pool pointing to /dev/mapper makes

Re: [libvirt] [libvirt-tck PATCH] Use recent Fedora version

2012-10-21 Thread Guido Günther
On Sun, Oct 21, 2012 at 12:52:58PM +0200, Peter Krempa wrote: > On 10/21/12 12:28, Guido Günther wrote: > >F12 isn't available on standard mirrors anymore. > >--- > > conf/ks.cfg |2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > ACK Pushed. Thanks, -- Guido -- libvir-list mailing

Re: [libvirt] [libvirt-tck PATCH] Debian calls mkisofs genisoimage

2012-10-21 Thread Guido Günther
On Sat, Oct 20, 2012 at 10:37:50AM -0600, Eric Blake wrote: > On 10/20/2012 02:26 AM, Guido Günther wrote: > > so check for that too when generating the iso. > > --- > > lib/Sys/Virt/TCK/NetworkHelpers.pm |4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/lib/Sys

Re: [libvirt] [PATCH] network: don't allow multiple default portgroups

2012-10-21 Thread Laine Stump
On 10/20/2012 12:49 PM, Eric Blake wrote: > On 10/20/2012 02:45 AM, Laine Stump wrote: >> This resolves: https://bugzilla.redhat.com/show_bug.cgi?id=868483 >> >> virNetworkUpdate, virNetworkDefine, and virNetworkCreate all three >> allow network definitions to contain multiple elements >> with def

Re: [libvirt] 0.10.2 virtualport profileid (802.1Qbh) malformed

2012-10-21 Thread Laine Stump
On 10/21/2012 08:02 AM, Tom Lanyon wrote: > Hi, > > I've just upgraded a test libvirtd host to 0.10.2 from 0.9.4 to be able to > make use of the new 'virsh net-update add portgroup' live updates, however > can't get my private/802.1Qbh interfaces working at all after the upgrade. > > Trying to st

Re: [libvirt] how libvirt communicate with qemu?

2012-10-21 Thread Kashyap Chamarthy
On 10/21/2012 03:12 PM, yue wrote: > i am reading source code, begin with tracing simple command line ,like virsh > list and forth. > please look at my qurestions > 1.how libvirt communicate with qemu? For starters, before diving into code, I'm learning it this way, by tracing all the commands(l

[libvirt] 0.10.2 virtualport profileid (802.1Qbh) malformed

2012-10-21 Thread Tom Lanyon
Hi, I've just upgraded a test libvirtd host to 0.10.2 from 0.9.4 to be able to make use of the new 'virsh net-update add portgroup' live updates, however can't get my private/802.1Qbh interfaces working at all after the upgrade. Trying to start an existing domain or install a new domain after t

Re: [libvirt] [PATCH] tools: Only install guests init script if --with-init=script=redhat

2012-10-21 Thread Peter Krempa
On 10/21/12 04:49, Cole Robinson wrote: Required to fix https://bugzilla.redhat.com/show_bug.cgi?id=789747 --- libvirt.spec.in | 5 - tools/Makefile.am | 4 ++-- 2 files changed, 6 insertions(+), 3 deletions(-) Unfortunately, the systemd unit file is calling the init scprit as we di

Re: [libvirt] [libvirt-tck PATCH] Use recent Fedora version

2012-10-21 Thread Peter Krempa
On 10/21/12 12:28, Guido Günther wrote: F12 isn't available on standard mirrors anymore. --- conf/ks.cfg |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ACK -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [libvirt-tck PATCH] Use recent Fedora version

2012-10-21 Thread Guido Günther
F12 isn't available on standard mirrors anymore. --- conf/ks.cfg |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/conf/ks.cfg b/conf/ks.cfg index de82a26..b6269e9 100644 --- a/conf/ks.cfg +++ b/conf/ks.cfg @@ -1,6 +1,6 @@ install text -url --url=http://ftp-stud.hs-esslinge

Re: [libvirt] [libvirt-tck PATCH] Add missing %end to kickstart file

2012-10-21 Thread Guido Günther
On Sat, Oct 20, 2012 at 02:21:18PM -0600, Eric Blake wrote: > On 10/20/2012 02:08 PM, Guido Günther wrote: > > --- > > conf/ks.cfg |1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/conf/ks.cfg b/conf/ks.cfg > > index 27e50e4..de82a26 100644 > > --- a/conf/ks.cfg > > +++ b/conf/ks.

Re: [libvirt] [PATCH] qemu: Fix domxml-to-native network model conversion

2012-10-21 Thread Peter Krempa
On 10/21/12 04:49, Cole Robinson wrote: https://bugzilla.redhat.com/show_bug.cgi?id=636832 --- src/qemu/qemu_driver.c | 9 + 1 file changed, 9 insertions(+) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index feda4d9..c2ddba7 100644 --- a/src/qemu/qemu_driver.c +++ b/sr

[libvirt] how libvirt communicate with qemu?

2012-10-21 Thread yue
i am reading source code, begin with tracing simple command line ,like virsh list and forth. please look at my qurestions 1.how libvirt communicate with qemu? call qemu'lib or open special device/socket? 2. i do not find the implement of function qemuAgentOpen>qemuAgentInitialize(). i also

Re: [libvirt] [PATCH] Log parameters passed to virFileMakePath

2012-10-21 Thread Peter Krempa
On 10/21/12 00:31, Cole Robinson wrote: --- src/util/util.c | 2 ++ 1 file changed, 2 insertions(+) ACK. Peter -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] docs: virsh: clarify behavior of send-key

2012-10-21 Thread Peter Krempa
On 10/21/12 02:31, Cole Robinson wrote: https://bugzilla.redhat.com/show_bug.cgi?id=860004 --- tools/virsh.pod | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) ACK. Peter -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list