On 10/27/12 01:00, Eric Blake wrote:
Upstream qemu 1.3 is adding two new monitor commands, 'drive-mirror'
and 'block-job-complete'[1], which can drive live block copy and
storage migration. [Additionally, RHEL 6.3 had backported an earlier
version of most of the same functionality, but under the
On Fri, Oct 26, 2012 at 10:27 PM, Harsh Prateek Bora
wrote:
> @@ -1624,7 +1626,15 @@
> one of the sheepdog servers (default is localhost:7000)
>
> zero or one
>
> +
> + gluster
> + a server running glusterd daemon
Its
On 10/26/12 23:52, Eric Blake wrote:
On 10/26/2012 07:08 AM, Peter Krempa wrote:
On 10/23/12 04:10, Eric Blake wrote:
Since libvirt drops locks between issuing a monitor command and
getting a response, it is possible for libvirtd to be restarted
before getting a response on a drive-reopen comma
Hi Jim,
The libvirt libxl driver doesn't build with xen 4.2. There was a small thread
about it on fedora's virt list:
http://lists.fedoraproject.org/pipermail/virt/2012-October/003446.html
I saw that you had a few xen 4.2 patches land recently, and I'm just curious
if you were aware of the libxl
On 10/26/2012 04:54 PM, Eric Blake wrote:
> On 10/25/2012 02:31 PM, Laine Stump wrote:
>> This resolves:
>>
>>https://bugzilla.redhat.com/show_bug.cgi?id=862515
>>
>> which describes inconsistencies in dealing with duplicate mac
>> addresses on network devices in a domain.
>>
>> (at any rate, i
Port to RHEL 6.3 early backport naming of __com.redhat_drive-mirror
and __com.redhat_drive-reopen (with more arguments than
block-job-complete). Thankfully, the rest of our code is nicely
isolated from the difference in JSON code.
* src/qemu/qemu_capabilities.c (qemuCapsProbeQMPCommands): Probe
a
Upstream qemu 1.3 is adding two new monitor commands, 'drive-mirror'
and 'block-job-complete'[1], which can drive live block copy and
storage migration. [Additionally, RHEL 6.3 had backported an earlier
version of most of the same functionality, but under the names
'__com.redhat_drive-mirror' and
On Fri, Oct 26, 2012 at 11:59 AM, Philipp Hahn wrote:
> Hello,
>
> just a nit:
>
> On Tuesday 23 October 2012 10:09:11 li guang wrote:
>> > +++ b/src/qemu/qemu_driver.c
>> > @@ -9622,6 +9622,20 @@ qemuDomainMigrateBegin3(virDomainPtr domain,
>> > }
>> >
>> > if (!virDomainObjIsActive(vm)
On 10/26/2012 07:08 AM, Peter Krempa wrote:
> On 10/23/12 04:10, Eric Blake wrote:
>> Since libvirt drops locks between issuing a monitor command and
>> getting a response, it is possible for libvirtd to be restarted
>> before getting a response on a drive-reopen command; worse, it is
>> also possi
On 10/26/2012 06:22 AM, Jiri Denemark wrote:
>>
>> I suppose it's not too hard to split this into two patches - one for
>> upstream that uses only drive-mirror (and provides but not populates the
>> feature "drive-reopen",), and one for backporting to RHEL but omitting
>> from upstream that checks
On 10/26/2012 02:50 PM, Peter Krempa wrote:
>>
>> +int
>> +nodeGetCPUCount(void)
>> +{
>> +#ifdef __linux__
>> +/* XXX should we also work on older kernels, like RHEL5, that lack
>> + * cpu/present and cpu/online files? Those kernels also lack cpu
>> + * hotplugging, so it would be a m
On 10/25/2012 02:31 PM, Laine Stump wrote:
> This resolves:
>
>https://bugzilla.redhat.com/show_bug.cgi?id=862515
>
> which describes inconsistencies in dealing with duplicate mac
> addresses on network devices in a domain.
>
> (at any rate, it resolves *almost* everything, and prints out an
On 10/26/12 19:52, Eric Blake wrote:
It turns out that the cpuacct results properly account for offline
cpus, and always returns results for every possible cpu, not just
the online ones. So there is no need to check the map of online
cpus in the first place, merely only a need to know the maximu
Commit 246143b fixed a warning on older gcc, but caused a warning
on newer gcc.
../../src/rpc/virnetserverservice.c: In function
'virNetServerServiceNewPostExecRestart':
../../src/rpc/virnetserverservice.c:277:41: error: pointer targets in passing
argument 3 of 'virJSONValueObjectGetNumberUint'
On 10/26/2012 01:19 PM, Laine Stump wrote:
On 10/26/2012 01:01 PM, Gene Czarcinski wrote:
All doc and the libvirt software itself is very insistent that dhcp4
will be supported on one and only one IPv4 subnetwork. Why is true?
Not "will be". "is". It's this way because nobody has submitted a p
On 10/26/2012 10:36 AM, Laine Stump wrote:
On 10/24/2012 04:27 PM, Gene Czarcinski wrote:
On 10/24/2012 01:31 PM, Laine Stump wrote:
Is there some way (some command) that will cause dnsmasq to be
restarted (possibly with new parameters as it re-does its
configuration). If this was done, then l
On 10/26/2012 11:36 AM, Martin Kletzander wrote:
> On 10/26/2012 06:06 PM, Eric Blake wrote:
>> Patch 61299a1 fixed a long-standing pod error in the man page.
>> But we should be preventing these up front.
>>
>> * tools/Makefile.am (virt-xml-validate.1, virt-pki-validate.1)
>> (virt-host-validate.1
On 10/26/2012 12:58 PM, Eric Blake wrote:
> With older gcc and 64-bit size_t, the compiler issues a real warning:
> rpc/virnetserverservice.c:277: warning: dereferencing type-punned pointer
> will break strict-aliasing rules [-Wstrict-aliasing]
>
> Introduced in commit 0cc79255. Depending on mac
With older gcc and 64-bit size_t, the compiler issues a real warning:
rpc/virnetserverservice.c:277: warning: dereferencing type-punned pointer will
break strict-aliasing rules [-Wstrict-aliasing]
Introduced in commit 0cc79255. Depending on machine endianness,
this warning represents a real bug
On 10/23/2012 11:07 AM, Gene Czarcinski wrote:
> The problem is that, without interface=, bind-interfaces does not
> work. Bind-interfaces uses SO_BINDTODEVICE. Unless this in
> in effect, there is no guarantee that the kernel will route
> DHCP (v4 or v6) packets to the correct instance of dnsmas
On 10/26/2012 07:08 PM, Jiri Denemark wrote:
On Fri, Oct 26, 2012 at 15:06:19 +0530, Harsh Bora wrote:
On 10/05/2012 05:27 PM, Paolo Bonzini wrote:
Il 04/10/2012 15:31, Harsh Prateek Bora ha scritto:
Qemu accepts gluster protocol as supported storage backend beside others.
This patch allows us
It turns out that the cpuacct results properly account for offline
cpus, and always returns results for every possible cpu, not just
the online ones. So there is no need to check the map of online
cpus in the first place, merely only a need to know the maximum
possible cpu. Meanwhile, virNodeGetC
On 10/26/2012 06:06 PM, Eric Blake wrote:
> Patch 61299a1 fixed a long-standing pod error in the man page.
> But we should be preventing these up front.
>
> * tools/Makefile.am (virt-xml-validate.1, virt-pki-validate.1)
> (virt-host-validate.1, virt-sanlock-cleanup.8, virsh.1): Reject
> pod conver
Found this when building on RHEL5:
parallels/parallels_storage.c: In function 'parallelsStorageOpen':
parallels/parallels_storage.c:180: error: 'for' loop initial declaration used
outside C99 mode
(and similar error in parallels_driver.c). This was in spite of
configuring with "-Wno-error".
---
On 10/26/2012 01:01 PM, Gene Czarcinski wrote:
> All doc and the libvirt software itself is very insistent that dhcp4
> will be supported on one and only one IPv4 subnetwork. Why is true?
Not "will be". "is". It's this way because nobody has submitted a patch
to support it.
It is possible (as fa
All doc and the libvirt software itself is very insistent that dhcp4
will be supported on one and only one IPv4 subnetwork. Why is true?
Certainly dnsmasq supports multiple dhcp-range definitions and the
actual parameters passed to dnsmasq would be more or less the same! I
can understand som
Signed-off-by: Harsh Prateek Bora
---
tests/qemuargv2xmltest.c | 1 +
.../qemuxml2argv-disk-drive-network-gluster.args | 1 +
.../qemuxml2argv-disk-drive-network-gluster.xml| 35 ++
tests/qemuxml2argvtest.c | 2 ++
4
Hello,
just a nit:
On Tuesday 23 October 2012 10:09:11 li guang wrote:
> > +++ b/src/qemu/qemu_driver.c
> > @@ -9622,6 +9622,20 @@ qemuDomainMigrateBegin3(virDomainPtr domain,
> > }
> >
> > if (!virDomainObjIsActive(vm)) {
> > + if (flags & VIR_MIGRATE_OFFLINE) {
> > +
Qemu accepts gluster protocol as supported storage backend beside others.
This patch allows users to specify disks on gluster backends like this:
In the element above, transport is a new optional attribute.
Valid transport values are tcp, unix or rd
Changelog:
v3 updated:
- Fix other network backends (nbd, rbd, sheepdog) to initialize new members
(transport, socket) of _virDomainDiskHostDef appropriately so that garbage
values doesnt break the argv2xml tests.
v3:
- RNG schema updated as required for unix transport [Paolo]
- introduced a
Hello Eoric,
Forget my previous mail, that was a patched version.
qemuDomainRemoveInactive() is deleting the snapshots, but still: I would
prefer to check for snapshots to extend for inactive domains as well.
Sincerely
Philipp
--
Philipp Hahn Open Source Software Engineer h...@u
Patch 61299a1 fixed a long-standing pod error in the man page.
But we should be preventing these up front.
* tools/Makefile.am (virt-xml-validate.1, virt-pki-validate.1)
(virt-host-validate.1, virt-sanlock-cleanup.8, virsh.1): Reject
pod conversion errors.
* daemon/Makefile.am ($(srcdir)/libvirtd.
On 10/26/2012 07:59 AM, Peter Krempa wrote:
> On 10/25/12 22:57, Eric Blake wrote:
>> It turns out that the cpuacct results properly account for offline
>> cpus, and always returns results for every possible cpu, not just
>> the online ones. So there is no need to check the map of online
>> cpus i
Hello Eric,
On Friday 02 September 2011 06:25:01 Eric Blake wrote:
> Just as leaving managed save metadata behind can cause problems
> when creating a new domain that happens to collide with the name
> of the just-deleted domain, the same is true of leaving any
> snapshot metadata behind.
I just
Il 26/10/2012 16:01, Paolo Bonzini ha scritto:
>> > What about moving the transport to source:
>> >
>> >
>> >
>> >
>> >
>> >
>> >
>> >
>> >
>> > where hypothetically an ssh transport could have both host and socke
On 10/24/2012 04:27 PM, Gene Czarcinski wrote:
> On 10/24/2012 01:31 PM, Laine Stump wrote:
>>> >Is there some way (some command) that will cause dnsmasq to be
>>> >restarted (possibly with new parameters as it re-does its
>>> >configuration). If this was done, then little, except some cached
>>>
Il 26/10/2012 15:55, Jiri Denemark ha scritto:
>> > What about moving the transport to source:
>> >
>> >
>> >
>> >
>> >
>> >
>> >
>> >
>> >
>> > where hypothetically an ssh transport could have both host and socket
>> > sub-elements.
> Hmm, I'm starting to think we ar
On 10/25/12 22:57, Eric Blake wrote:
It turns out that the cpuacct results properly account for offline
cpus, and always returns results for every possible cpu, not just
the online ones. So there is no need to check the map of online
cpus in the first place, merely only a need to know the maximu
On 10/26/2012 04:38 AM, Philipp Hahn wrote:
> Replace '%' by '&' for correct escaping of '>' in Domain specification.
>
> Signed-off-by: Philipp Hahn
> ---
> docs/formatdomain.html.in |2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/docs/formatdomain.html.in b/docs/f
On Fri, Oct 26, 2012 at 15:49:01 +0200, Paolo Bonzini wrote:
> Il 26/10/2012 15:38, Jiri Denemark ha scritto:
> > or
> >
> >
> > However, I don't like this too much either. What if we add a general socket
> > element? In other words,
> >
> > or
> >
> >
> > where the type attr
Il 26/10/2012 15:38, Jiri Denemark ha scritto:
> or
>
>
> However, I don't like this too much either. What if we add a general socket
> element? In other words,
>
> or
>
>
> where the type attribute in socket element would determine what other
> attributes can be used (path f
On 10/26/2012 08:58 AM, Peter Krempa wrote:
> When assigning the new persistent definition for a transient network
> (thus making it persistent) the network needs to be marked persistent
> before actually atempting to assign the definition.
> ---
> src/network/bridge_driver.c | 7 +++
> 1 file
On 10/26/2012 08:55 AM, Peter Krempa wrote:
> When the assignment fails, the network object is not unlocked and next
> call that would use it deadlocks.
> ---
> src/conf/network_conf.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/src/conf/network_conf.c b/src/conf/network_conf.c
> inde
On 10/23/12 04:10, Eric Blake wrote:
When using block copy to pivot over to a new chain, the backing files
for the new chain might still need labeling (particularly if the user
passes --reuse-ext with a relative backing file name). Relabeling a
file that is already labeled won't hurt, so this ju
On Fri, Oct 26, 2012 at 15:06:19 +0530, Harsh Bora wrote:
> On 10/05/2012 05:27 PM, Paolo Bonzini wrote:
> > Il 04/10/2012 15:31, Harsh Prateek Bora ha scritto:
> >> Qemu accepts gluster protocol as supported storage backend beside others.
> >> This patch allows users to specify disks on gluster ba
On 10/23/12 04:10, Eric Blake wrote:
Use the recent addition of qemuDomainPrepareDiskChainElement to
obtain locking manager lease, permit a block device through cgroups,
and set the SELinux label; then audit the fact that we hand a new
file over to qemu. Alas, releasing the lease and label at th
On 10/23/12 04:10, Eric Blake wrote:
Support the REUSE_EXT flag, in part by copying sanity checks from
snapshot code. This code introduces a case of probing an external
file for its type; such an action would be a security risk if the
existing file is supposed to be raw but the contents resemble
Qemu accepts gluster protocol as supported storage backend beside others.
This patch allows users to specify disks on gluster backends like this:
In the element above, transport is a new optional attribute.
Valid transport values are tcp, unix or rd
On 10/23/12 04:10, Eric Blake wrote:
Minimal patch to wire up all the pieces in the previous patches
to actually enable a block copy job. By minimal, I mean that
qemu creates the file (that is, no REUSE_EXT flag support yet),
SELinux must be disabled, a lock manager is not informed, and the
audi
Modified the places where virNodeGetInfo was used for the purpose
of obtaining the maximum node CPU number. Transparently falling
back to virNodeGetInfo in case of failure.
Signed-off-by: Viktor Mihajlovski
---
python/libvirt-override.c | 100 ++
1 fil
This patchset provides support for Gluster protocol based network disks.
Changelog:
v3:
- RNG schema updated as required for unix transport [Paolo]
- introduced another new attribute 'socket' for unix transport [Paolo]
- Uses virURIFormat and virURIParse for URI parsing. [danpb]
- updated documen
This series concludes the introduction of the virNodeGetCPUMap API
by replacing calls to virNodeGetInfo used only for the purpose
of computing the maximum number of node CPUs (which has the potential
to yield the incorrect number).
Most prominently, with patch 3/3 the output of virsh vcpuinfo will
Signed-off-by: Harsh Prateek Bora
---
tests/qemuargv2xmltest.c | 1 +
.../qemuxml2argv-disk-drive-network-gluster.args | 1 +
.../qemuxml2argv-disk-drive-network-gluster.xml| 35 ++
tests/qemuxml2argvtest.c | 2 ++
4
The drivers for QEMU and LXC use virNodeGetInfo to determine the
number of host CPUs. This approach can lead to a wrong (too small)
number if one or more CPUs are offline.
It is better to use virNodeGetCPUMap if available, which is the
case here.
Signed-off-by: Viktor Mihajlovski
---
src/lxc/lxc
Modified the places where virNodeGetInfo was used for the purpose
of obtaining the maximum node CPU number. Transparently falling
back to virNodeGetInfo in case of failure.
Signed-off-by: Viktor Mihajlovski
---
tools/virsh-domain.c | 36
1 file changed, 24 in
On 10/26/12 15:07, Jiri Denemark wrote:
This reverts commit 8d75e47edefdd77b86df1ee9af3cd5001d456f73.
Libvirt was never released with support for migration cookies without
hostuuid.
---
src/qemu/qemu_migration.c | 31 +++
1 file changed, 15 insertions(+), 16 deleti
This reverts commit 8d75e47edefdd77b86df1ee9af3cd5001d456f73.
Libvirt was never released with support for migration cookies without
hostuuid.
---
src/qemu/qemu_migration.c | 31 +++
1 file changed, 15 insertions(+), 16 deletions(-)
diff --git a/src/qemu/qemu_migration
On 10/23/12 04:10, Eric Blake wrote:
Since libvirt drops locks between issuing a monitor command and
getting a response, it is possible for libvirtd to be restarted
before getting a response on a drive-reopen command; worse, it is
also possible for the guest to shut itself down during the window
On Tue, Oct 23, 2012 at 09:54:50 -0600, Eric Blake wrote:
> On 10/23/2012 09:22 AM, Daniel P. Berrange wrote:
> > On Fri, Oct 19, 2012 at 04:31:44PM +0200, Jiri Denemark wrote:
> >> Having hostuuid in migration cookie is a nice bonus since it provides an
> >> easy way of detecting migration to the
On 10/23/12 04:10, Eric Blake wrote:
This is the bare minimum to end a copy job (of course, until a
later patch adds the ability to start a copy job, this patch
doesn't do much in isolation; I've just split the patches to
ease the review).
This patch intentionally avoids SELinux, lock manager, a
When assigning the new persistent definition for a transient network
(thus making it persistent) the network needs to be marked persistent
before actually atempting to assign the definition.
---
src/network/bridge_driver.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/src/network/brid
When the assignment fails, the network object is not unlocked and next
call that would use it deadlocks.
---
src/conf/network_conf.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/conf/network_conf.c b/src/conf/network_conf.c
index 93d1b4c..1955853 100644
--- a/src/conf/network_conf.c
+++
Sorting of the .gitignore file was broken after the last addition. After
a clean build the scripts re-sort it making the working tree dirty.
---
Pushed under trivial rule.
---
.gitignore | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.gitignore b/.gitignore
index 51d83a6..98ce
On 10/23/12 04:10, Eric Blake wrote:
Handle the new type of block copy event and info. Of course,
this patch does nothing until a later patch actually allows the
creation/abort of a block copy job. The new event is available
in qemu 1.3, but not in RHEL 6.3; rather than doing polling
ourselves
On Tue, Oct 23, 2012 at 14:16:22 -0600, Eric Blake wrote:
> On 10/23/2012 01:52 PM, Peter Krempa wrote:
> > On 10/23/12 04:10, Eric Blake wrote:
> > I know that it's convenient to have this in the upstream release as it
> > would remove the need to backport that feature every time. Said this, I
> >
On Fri, Oct 26, 2012 at 12:34:50 +0200, Peter Krempa wrote:
> On 10/26/12 12:27, Jiri Denemark wrote:
> > The first two hunks fix "Unterminated I<...> sequence" error and the
> > last one fixes "’=item’ outside of any ’=over’" error.
> > ---
> > tools/virsh.pod | 6 ++
> > 1 file changed, 2
On 10/26/2012 05:58 AM, Peter Krempa wrote:
> The network driver didn't care about config files when a network was
> destroyed, just when it was undefined leaving behind files for transient
> networks.
>
> This patch splits out the cleanup code to a helper function that handles
> the cleanup if the
On Thu, Oct 25, 2012 at 09:43:28 -0400, Dave Allan wrote:
> On Thu, Oct 25, 2012 at 07:16:35AM -0600, Eric Blake wrote:
> > I disagree - there's no point in keeping a hidden argument. It is a
> > disservice to users to make them have to pass a numeric flags value - if
> > they know they are talkin
On 10/26/12 12:27, Jiri Denemark wrote:
The first two hunks fix "Unterminated I<...> sequence" error and the
last one fixes "’=item’ outside of any ’=over’" error.
---
tools/virsh.pod | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
ACK.
Peter
--
libvir-list mailing list
libvir
On 10/23/12 22:16, Eric Blake wrote:
On 10/23/2012 01:52 PM, Peter Krempa wrote:
On 10/23/12 04:10, Eric Blake wrote:
Upstream qemu 1.3 is adding two new monitor commands, 'drive-mirror'
and 'block-job-complete'[1], which can drive live block copy and
storage migration. Additionally, RHEL 6.3
Eric Blake wrote:
> On 10/25/2012 05:12 PM, Laine Stump wrote:
>>
>> What would be *really* nice is if git could give a *warning* if you
>> tried to do git add . and it found any of those files - it would prevent
>> the cases where you forget to save a file that you've modified.
If you write Chang
The first two hunks fix "Unterminated I<...> sequence" error and the
last one fixes "’=item’ outside of any ’=over’" error.
---
tools/virsh.pod | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/tools/virsh.pod b/tools/virsh.pod
index 61822bb..07d6a67 100644
--- a/tools/virs
Il 26/10/2012 11:36, Harsh Bora ha scritto:
> On 10/05/2012 05:27 PM, Paolo Bonzini wrote:
>> Il 04/10/2012 15:31, Harsh Prateek Bora ha scritto:
>>> Qemu accepts gluster protocol as supported storage backend beside
>>> others.
>>> This patch allows users to specify disks on gluster backends like t
The network driver didn't care about config files when a network was
destroyed, just when it was undefined leaving behind files for transient
networks.
This patch splits out the cleanup code to a helper function that handles
the cleanup if the inactive network object is being removed and re-uses
t
On 10/05/2012 05:27 PM, Paolo Bonzini wrote:
Il 04/10/2012 15:31, Harsh Prateek Bora ha scritto:
Qemu accepts gluster protocol as supported storage backend beside others.
This patch allows users to specify disks on gluster backends like this:
This is a follow-up to https://bugzilla.redhat.com/show_bug.cgi?id=861309
If one has USB disks configured for domain with explicit , libvirtd
ignores that node when building qemu command line. So, disk is connected to
the first free USB port implicitly by qemu.
That breaks other USB devices which
---
src/qemu/qemu_command.c |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 898c4c0..9fb7144 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
@@ -2624,6 +2624,9 @@ qemuBuildDriveDevStr(virDomainDef
Replace '%' by '&' for correct escaping of '>' in Domain specification.
Signed-off-by: Philipp Hahn
---
docs/formatdomain.html.in |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
index 2417943..c8da33d 100644
--- a/do
On 10/25/2012 07:34 PM, Eric Blake wrote:
ACK and pushed with this squashed in:
Thanks (also for guiding me through my first API).
--
Mit freundlichen Grüßen/Kind Regards
Viktor Mihajlovski
IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Martin Jetter
Geschäft
79 matches
Mail list logo
