On Wed, Nov 14, 2012 at 7:50 PM, Daniel Veillard wrote:
> I just checked and we have "only" 63 commits since 1.0.0 was released,
> so even if we were to increase the rate dramatically next week, it
> doesn't look like there is a high pressure for a release at the end
> of the month. Taking into a
On 11/13/2012 05:54 AM, Viktor Mihajlovski wrote:
> Since /sys/devices/system/cpu/present is not available on
> older kernels like on RHEL 5.x nodeGetCPUCount will
> fail there. The fallback implemented is to scan for
> /sys/devices/system/cpu/cpuNN entries.
>
> Signed-off-by: Viktor Mihajlovski
On 11/14/2012 08:30 AM, Daniel P. Berrange wrote:
> On Wed, Oct 17, 2012 at 08:17:16PM +0200, Miloslav Trmač wrote:
>> This simplifies the top-level code, at the cost of using a little more
>> stack space. The primary benefit is being able to send more fields
>> without knowing in advance how many
> -Original Message-
> From: Daniel P. Berrange [mailto:berra...@redhat.com]
> Sent: Wednesday, November 14, 2012 6:45 PM
> To: Ichikawa, Ken/市川 顕
> Cc: libvir-list@redhat.com; ebl...@redhat.com; gaof...@cn.fujitsu.com;
> Kaneshige, Kenji/金重 憲治
> Subject: Re: [PATCH] qemu conf: Use host-mo
(2012/11/14 18:44:44), Daniel P. Berrange wrote:
> On Wed, Nov 14, 2012 at 03:10:48AM +, Ichikawa, Ken wrote:
> > Now, qemu guest's default cpu model is qemu32/64 and it can be
> > configured per domain. In some case, host-model mode is suitable for
> > getting enough performance in the guest
v1 was here:
https://www.redhat.com/archives/libvir-list/2012-November/msg00604.html
Diff in v2: Prefer active/inactive over online/offline; use XPath rather
than strstr for parsing XML, rebase to latest
Eric Blake (4):
snapshot: add two more filter sets to API
snapshot: add virsh back-compat
Now that we can filter on this information, we should also make
it easy to get at.
* tools/virsh-snapshot.c (cmdSnapshotInfo): Add another output
row, and switch to XPath queries rather than strstr.
---
tools/virsh-snapshot.c | 57 +++---
1 file changed
Snapshot filtering based on types is useful enough to add
back-compat support into virsh. It is also rather easy - all
versions of libvirt that don't understand the new filter flags
already gave us sufficient information in a single XML field
to reconstruct all the information we need (that is, it
As we enable more modes of snapshot creation, it becomes more important
to be able to quickly filter based on snapshot properties. This patch
introduces new filter flags; subsequent patches will introduce virsh
back-compat filtering, as well as actual libvirt filtering.
* include/libvirt/libvirt.
Relatively straight-forward. And since qemu was already using
VIR_DOMAIN_SNAPSHOT_FILTERS_ALL, with 6 different APIs all calling
into this common code, I've instantly added all 5 flags to 6 APIs.
* src/conf/snapshot_conf.h (VIR_DOMAIN_SNAPSHOT_FILTERS_ALL):
Enable new filters.
* src/conf/snapshot
On 2012年11月15日 10:01, Eric Blake wrote:
On 11/14/2012 06:54 AM, Osier Yang wrote:
QEMU supports to set vendor and product strings for disk since
s/to set/setting/
1.2.0 (only scsi-disk, scsi-hd, scsi-cd support it), this patch
exposes it with new XML elements and of disk
device.
---
+++ b/
On 11/14/2012 06:54 AM, Osier Yang wrote:
> QEMU supports to set vendor and product strings for disk since
s/to set/setting/
> 1.2.0 (only scsi-disk, scsi-hd, scsi-cd support it), this patch
> exposes it with new XML elements and of disk
> device.
> ---
> +++ b/docs/schemas/domaincommon.rng
> @
try to do non-shared migration without bothering to
create disk images at target by hand.
consider this situation:
1. non-shared migration
virsh migrate --copy-storage-all ...
2. migration fails
3. create disk images required
qemu-img create ...
4 migration run smoothly
so, try do remove st
qemuImgBinary is a poor name, change to qemuImgTool,
and init it at qemu driver start-up phase, before this
change, if we need qemu-img or kvm-img we have to call
qemuFindQemuImgBinary every time, seems a little boring,
from then on, we can use qemuImgTool directly,
e.g.
use virCommandRun(driver->q
On 11/14/2012 08:35 AM, Eric Blake wrote:
> On 11/14/2012 07:51 AM, Ján Tomko wrote:
>> Allow bootindex to be specified for redirected USB devices and host USB
>> devices.
>>
>> Bug: https://bugzilla.redhat.com/show_bug.cgi?id=805414
>>
>> +(hostdev->source.subsys.type !=
>> VIR_D
I just checked and we have "only" 63 commits since 1.0.0 was released,
so even if we were to increase the rate dramatically next week, it
doesn't look like there is a high pressure for a release at the end
of the month. Taking into account the extra factors that end of
December is usually low traf
在 2012-11-14三的 07:07 -0700，Eric Blake写道：
> On 11/14/2012 01:57 AM, li guang wrote:
> > 在 2012-11-14三的 02:28 -0600，Doug Goldstein写道：
> >> On Wed, Nov 14, 2012 at 1:56 AM, li guang wrote:
> >>> 在 2012-11-14三的 01:38 -0600，Doug Goldstein写道：
> On Tue, Nov 13, 2012 at 9:03 PM, liguang wrote:
> >>>
On 11/14/2012 11:43 AM, Eric Blake wrote:
>> Bleah. Raw XML parsing. Wouldn't it be easier in and cleaner convert
>> this piece code to use the XML parser and xpath?
>
> Not the first time we've done this. I agree that using the XML parser
> and xpath is probably nicer, but it actually takes more
Ever since commit 7b21981c started generating AUTHORS, we now have
the situation that if you flip between two branches in the same
git repository that cross that commit boundary, then 'make' will
fail due to automake complaining about AUTHORS not existing. The
simplest solution is to realize that
On 11/13/2012 05:16 PM, Peter Krempa wrote:
> On 11/13/12 20:09, Eric Blake wrote:
>> Now that we can filter on this information, we should also make
>> it easy to get at.
>>
>> * tools/virsh-snapshot.c (cmdSnapshotInfo): Add another output
>> row.
>> ---
>> tools/virsh-snapshot.c | 32 ++
On 11/13/2012 04:50 PM, Peter Krempa wrote:
> On 11/13/12 20:09, Eric Blake wrote:
>> As we enable more modes of snapshot creation, it becomes more important
>> to be able to quickly filter based on snapshot properties. This patch
>> introduces new filter flags; subsequent patches will introduce v
On 11/14/2012 12:18 PM, Eric Blake wrote:
> On 11/14/2012 10:12 AM, Laine Stump wrote:
>> The "restart" function for locks allocates a new array according to
>> and pre-sets its length, then reads the owner pids from a JSON
>> document in a loop. Rather than adding each owner at a different
>> inde
On 11/14/2012 10:12 AM, Laine Stump wrote:
> The "restart" function for locks allocates a new array according to
> and pre-sets its length, then reads the owner pids from a JSON
> document in a loop. Rather than adding each owner at a different
> index, though, it repeatedly overwrites the last ele
The "restart" function for locks allocates a new array according to
and pre-sets its length, then reads the owner pids from a JSON
document in a loop. Rather than adding each owner at a different
index, though, it repeatedly overwrites the last element of the array
with all the owners.
---
src/uti
On 11/14/2012 09:25 AM, Daniel P. Berrange wrote:
> On Wed, Nov 14, 2012 at 05:06:08PM +0100, Michal Privoznik wrote:
>> I've proposed both approaches in the past. However, none of them was
>> accepted as we ought to agree on $subj first. Frankly, both makes sense
>> to me, both has advantages and
On Wed, Nov 14, 2012 at 05:06:08PM +0100, Michal Privoznik wrote:
> I've proposed both approaches in the past. However, none of them was
> accepted as we ought to agree on $subj first. Frankly, both makes sense
> to me, both has advantages and disadvantages.
>
> XML - keeps things more consistent
On Thu, Nov 1, 2012 at 11:32 PM, Dusty Mabe wrote:
> On Thu, Nov 1, 2012 at 11:09 AM, Eric Blake wrote:
>> Basically, you would create a virGroupPtr that describes the entire
>> resources you are willing to allow to VMs, then ensure that all VMs are
>> members of that virGroupPtr.
>
> Thanks for
I've proposed both approaches in the past. However, none of them was
accepted as we ought to agree on $subj first. Frankly, both makes sense
to me, both has advantages and disadvantages.
XML - keeps things more consistent as libvirt is tied to XML, right?
Pros:
- can add items over the time
Cons
From: "Daniel P. Berrange"
The lack of initialization of 'opts' caused a SEGV in the
cleanup: path if the root->src directory did not exist
Pushed under trivial rule
---
src/lxc/lxc_controller.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/lxc/lxc_controller.c b/src/
On 11/14/2012 07:51 AM, Ján Tomko wrote:
> Allow bootindex to be specified for redirected USB devices and host USB
> devices.
>
> Bug: https://bugzilla.redhat.com/show_bug.cgi?id=805414
>
> ---
> Bootindex for these devices is supported since QEMU 1.1.0 (or commit 65bb3a5c)
> but the actual booti
On Wed, Oct 17, 2012 at 08:17:16PM +0200, Miloslav Trmač wrote:
> This simplifies the top-level code, at the cost of using a little more
> stack space. The primary benefit is being able to send more fields
> without knowing in advance how many of them, and of which types, these
> fields will be, a
On Wed, Oct 17, 2012 at 08:17:18PM +0200, Miloslav Trmač wrote:
> This is independent from the rest of the series, sending it anyway for
> consideration; this makes the metadata available to users on non-systemd
> platforms. I believe the technical objections (primarily
> async-signal-safety) have
On Wed, Oct 17, 2012 at 08:17:17PM +0200, Miloslav Trmač wrote:
> When logging an error, don't throw away the detailed information.
> Example record when using the journald output:
>
> MESSAGE=Domain not found
> PRIORITY=4
> LIBVIRT_SOURCE=error
> CODE_FILE=../../sr
On Wed, Oct 17, 2012 at 08:17:15PM +0200, Miloslav Trmač wrote:
> ... and update all users. No change in functionality, the parameter
> will be used in the next patch.
>
> Signed-off-by: Miloslav Trmač
> ---
> src/util/logging.c | 14 +-
> src/util/logging.h | 2 ++
> tests/testuti
On Wed, Oct 17, 2012 at 08:17:14PM +0200, Miloslav Trmač wrote:
> ... and update all users. No change in functionality, the parameter
> will be used later.
>
> The metadata representation is as minimal as possible, but requires
> the caller to allocate an array on stack explicitly.
>
> The alter
On Wed, Nov 14, 2012 at 3:16 PM, Christophe Fergeau wrote:
> g_type_init has been deprecated in glib 2.35, not 2.34. With versions
> older than 2.35, we have to call it or we'll get a runtime failure.
ACK
--
Regards,
Zeeshan Ali (Khattak)
FSF member#5124
--
libvir-list mailing list
libvir-lis
On 14.11.2012 15:51, Christophe Fergeau wrote:
> Hey,
>
> On Wed, Nov 14, 2012 at 03:45:00PM +0100, Michal Privoznik wrote:
>> On 14.11.2012 15:16, Christophe Fergeau wrote:
>>> g_type_init has been deprecated in glib 2.35, not 2.34. With versions
>>> older than 2.35, we have to call it or we'll g
On 14.11.2012 15:16, Christophe Fergeau wrote:
> g_type_init has been deprecated in glib 2.35, not 2.34. With versions
> older than 2.35, we have to call it or we'll get a runtime failure.
> ---
> libvirt-gconfig/libvirt-gconfig-compat.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
Hey,
On Wed, Nov 14, 2012 at 03:45:00PM +0100, Michal Privoznik wrote:
> On 14.11.2012 15:16, Christophe Fergeau wrote:
> > g_type_init has been deprecated in glib 2.35, not 2.34. With versions
> > older than 2.35, we have to call it or we'll get a runtime failure.
> > ---
> > libvirt-gconfig/lib
Allow bootindex to be specified for redirected USB devices and host USB
devices.
Bug: https://bugzilla.redhat.com/show_bug.cgi?id=805414
---
Bootindex for these devices is supported since QEMU 1.1.0 (or commit 65bb3a5c)
but the actual booting from usb-host devices is broken since a844ed84
(before
On 14.11.2012 15:16, Christophe Fergeau wrote:
> This method returns a version number, which can be 0, so we cannot
> check the return value for 0 to know if an error happened. Test if
> the GError is set instead to detect errors.
> ---
> examples/conn-test.c | 3 ++-
> 1 file changed, 2 insertion
On 11/14/2012 04:33 AM, Guannan Ren wrote:
>>> For example there is a snapshot chain like
>>> baseimage->snap1->snap2->snap3
>>>
>>>
>>> If we plan to go back to snap1, it will become as follows, is it
>>> right?
>>> baseimage-->snap1-->snap2-->snap3
>>>
On Wed, Nov 14, 2012 at 3:16 PM, Christophe Fergeau wrote:
> When GLib deprecated g_mutex_new/g_mutex_free, we introduced a
> compatibility wrapper to implement these using non-deprecated
> functions. This was done by allocating 0-filled memory by the
> mutex, and then letting GLib initialize the
This method returns a version number, which can be 0, so we cannot
check the return value for 0 to know if an error happened. Test if
the GError is set instead to detect errors.
---
examples/conn-test.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/examples/conn-test.c b/ex
When GLib deprecated g_mutex_new/g_mutex_free, we introduced a
compatibility wrapper to implement these using non-deprecated
functions. This was done by allocating 0-filled memory by the
mutex, and then letting GLib initialize the structure when
needed. However, we must call g_mutex_clear when dest
g_type_init has been deprecated in glib 2.35, not 2.34. With versions
older than 2.35, we have to call it or we'll get a runtime failure.
---
libvirt-gconfig/libvirt-gconfig-compat.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libvirt-gconfig/libvirt-gconfig-compat.h
b/lib
On 11/14/2012 01:57 AM, li guang wrote:
> 在 2012-11-14三的 02:28 -0600，Doug Goldstein写道：
>> On Wed, Nov 14, 2012 at 1:56 AM, li guang wrote:
>>> 在 2012-11-14三的 01:38 -0600，Doug Goldstein写道：
On Tue, Nov 13, 2012 at 9:03 PM, liguang wrote:
> Signed-off-by: liguang
> ---
Your commit mes
On 11/14/2012 01:18 AM, Doug Goldstein wrote:
>> +if (VIR_ALLOC_N(mig->disk, def->ndisks) < 0)
>> +goto no_memory;
>> +if (!driver->qemuImgBinary) {
>> +virReportError(VIR_ERR_INTERNAL_ERROR,
>> + "%s", _("unable to find kvm-img or qemu-img"));
>
> Us
On Wed, Nov 14, 2012 at 2:38 PM, Zeeshan Ali (Khattak)
wrote:
> From: "Zeeshan Ali (Khattak)"
>
> ---
> libvirt-gobject/libvirt-gobject-domain.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
I already pushed this under trivial rule.
--
Regards,
Zeeshan Ali (Khattak)
FSF membe
QEMU supports to set vendor and product strings for disk since
1.2.0 (only scsi-disk, scsi-hd, scsi-cd support it), this patch
exposes it with new XML elements and of disk
device.
---
docs/formatdomain.html.in | 12 ++
docs/schemas/domaincommon.rng
On Tue, Nov 6, 2012 at 1:45 PM, Christophe Fergeau wrote:
> ---
> libvirt-gobject/libvirt-gobject-storage-pool.c | 105
> +
> libvirt-gobject/libvirt-gobject-storage-pool.h | 11 +++
> libvirt-gobject/libvirt-gobject.sym| 3 +
> 3 files changed, 119 inserti
On Tue, Nov 6, 2012 at 1:45 PM, Christophe Fergeau wrote:
> ---
> libvirt-gobject/libvirt-gobject-storage-pool.c | 90
> ++
> libvirt-gobject/libvirt-gobject-storage-pool.h | 11
> libvirt-gobject/libvirt-gobject.sym| 3 +
> 3 files changed, 104 insertio
From: "Zeeshan Ali (Khattak)"
---
libvirt-gobject/libvirt-gobject-domain.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/libvirt-gobject/libvirt-gobject-domain.c
b/libvirt-gobject/libvirt-gobject-domain.c
index 34d7519..4b82db9 100644
--- a/libvirt-gobject/libvirt-gob
On Tue, Nov 6, 2012 at 1:45 PM, Christophe Fergeau wrote:
> ---
> libvirt-gobject/libvirt-gobject-storage-pool.c | 90
> ++
> libvirt-gobject/libvirt-gobject-storage-pool.h | 10 +++
> libvirt-gobject/libvirt-gobject.sym| 6 ++
> 3 files changed, 106 insertio
On Tue, Nov 13, 2012 at 6:30 PM, Christophe Fergeau wrote:
> When GLib deprecated g_mutex_new/g_mutex_free, we introduced a
> compatibility wrapper to implement these using non-deprecated
> functions. This was done by allocating 0-filled memory by the
> mutex, and then letting GLib initialize the
On Wed, Nov 14, 2012 at 02:05:11PM +0100, Zeeshan Ali (Khattak) wrote:
> On Wed, Nov 14, 2012 at 10:31 AM, Christophe Fergeau
> wrote:
> > On Tue, Nov 13, 2012 at 06:45:56PM +0100, Zeeshan Ali (Khattak) wrote:
> >> On Tue, Nov 6, 2012 at 1:45 PM, Christophe Fergeau
> >> wrote:
> >> > gvir_storag
On Wed, Nov 14, 2012 at 10:31 AM, Christophe Fergeau
wrote:
> On Tue, Nov 13, 2012 at 06:45:56PM +0100, Zeeshan Ali (Khattak) wrote:
>> On Tue, Nov 6, 2012 at 1:45 PM, Christophe Fergeau
>> wrote:
>> > gvir_storage_pool_refresh must be called and must be successful before
>> > trying to use gvir
On 11/14/12 01:47, Eric Blake wrote:
On 11/13/2012 08:26 AM, Peter Krempa wrote:
On 11/09/12 05:47, Eric Blake wrote:
Right now, libvirt refuses to revert to the state at the time
of an external snapshot, because doing so would reset things so
that the next time the domain boots, we are using t
On 11/14/2012 07:06 PM, Peter Krempa wrote:
On 11/14/12 10:29, Guannan Ren wrote:
On 11/09/2012 12:47 PM, Eric Blake wrote:
Right now, libvirt refuses to revert to the state at the time
of an external snapshot, because doing so would reset things so
that the next time the domain boots, we are u
On 11/14/12 10:29, Guannan Ren wrote:
On 11/09/2012 12:47 PM, Eric Blake wrote:
Right now, libvirt refuses to revert to the state at the time
of an external snapshot, because doing so would reset things so
that the next time the domain boots, we are using the backing
file; but modifying the back
Any idea on my assumed scenario?
If this is really an issue, it's something we need fix it IMHO.
Thanks
--jyh
> -Original Message-
> From: Jiang, Yunhong
> Sent: Friday, November 02, 2012 4:52 PM
> To: Eric Blake
> Cc: libvir-list@redhat.com
> Subject: RE: [libvirt] Is possible that cpu_m
On Tue, Nov 13, 2012 at 06:50:11PM +0100, Zeeshan Ali (Khattak) wrote:
> On Tue, Nov 6, 2012 at 1:41 PM, Christophe Fergeau
> wrote:
> > They are similar to g_warning/g_critical, but also log the last
> > libvirt error. They are meant to be called right after a libvirt
> > call failed, in other c
On Tue, Nov 13, 2012 at 06:30:26PM +0100, Christophe Fergeau wrote:
>
> This series does misc leak fixes in libvirt-glib, as well as an API doc
> fix, and a deprecation warning fix.
Pushed all of this except 4/5, I've split the g_type_init() one into 2
separate commits.
Christophe
pgplDrfaBwwK
On Wed, Nov 14, 2012 at 03:10:48AM +, Ichikawa, Ken wrote:
> Now, qemu guest's default cpu model is qemu32/64 and it can be
> configured per domain. In some case, host-model mode is suitable for
> getting enough performance in the guest because of features from cpu
> spec.
>
> This patch adds
On Tue, Nov 13, 2012 at 06:45:56PM +0100, Zeeshan Ali (Khattak) wrote:
> On Tue, Nov 6, 2012 at 1:45 PM, Christophe Fergeau
> wrote:
> > gvir_storage_pool_refresh must be called and must be successful before
> > trying to use gvir_storage_pool_get_volume,
> > gvir_storage_pool_get_volumes and gvi
this patch addes fuse support for libvirt lxc.
we can use fuse filesystem to generate sysinfo dynamically,
So we can isolate /proc/meminfo,cpuinfo and so on through
fuse filesystem.
we mount fuse filesystem for every container.
the mount name is libvirt,mount point is
localstatedir/run/libvirt/lxc
On Wed, Nov 14, 2012 at 01:12:39AM +0100, Zeeshan Ali (Khattak) wrote:
> On Tue, Nov 13, 2012 at 8:06 PM, Christophe Fergeau
> wrote:
> > On Tue, Nov 13, 2012 at 07:22:35PM +0100, Zeeshan Ali (Khattak) wrote:
> >> On Tue, Nov 13, 2012 at 7:10 PM, Alexander Larsson
> >> wrote:
> >> > This is a w
于 2012年11月12日 15:02, Gao feng 写道:
> this patch addes fuse support for libvirt lxc.
> we can use fuse filesystem to generate sysinfo dynamically,
> So we can isolate /proc/meminfo,cpuinfo and so on through
> fuse filesystem.
>
> we mount fuse filesystem for every container.
> the mount name is libv
On 11/09/2012 12:47 PM, Eric Blake wrote:
Right now, libvirt refuses to revert to the state at the time
of an external snapshot, because doing so would reset things so
that the next time the domain boots, we are using the backing
file; but modifying the backing file invalidates all qcow2
files th
在 2012-11-14三的 02:28 -0600，Doug Goldstein写道：
> On Wed, Nov 14, 2012 at 1:56 AM, li guang wrote:
> > 在 2012-11-14三的 01:38 -0600，Doug Goldstein写道：
> >> On Tue, Nov 13, 2012 at 9:03 PM, liguang wrote:
> >> > Signed-off-by: liguang
> >> > ---
> >> > src/qemu/qemu_domain.c |2 +-
> >> > src/qemu
On Wed, Nov 14, 2012 at 1:56 AM, li guang wrote:
> 在 2012-11-14三的 01:38 -0600，Doug Goldstein写道：
>> On Tue, Nov 13, 2012 at 9:03 PM, liguang wrote:
>> > Signed-off-by: liguang
>> > ---
>> > src/qemu/qemu_domain.c |2 +-
>> > src/qemu/qemu_driver.c |3 +++
>> > 2 files changed, 4 insertio
On Tue, Nov 13, 2012 at 9:03 PM, liguang wrote:
> try to do non-shared migration without bothering to
> create disk images at target by hand.
>
> consider this situation:
> 1. non-shared migration
>virsh migrate --copy-storage-all ...
> 2. migration fails
> 3. create disk images required
>
在 2012-11-14三的 01:38 -0600，Doug Goldstein写道：
> On Tue, Nov 13, 2012 at 9:03 PM, liguang wrote:
> > Signed-off-by: liguang
> > ---
> > src/qemu/qemu_domain.c |2 +-
> > src/qemu/qemu_driver.c |3 +++
> > 2 files changed, 4 insertions(+), 1 deletions(-)
> >
> > diff --git a/src/qemu/qemu_d
73 matches
Mail list logo
