QEMU supports setting vendor and product strings for disk since
1.2.0 (only scsi-disk, scsi-hd, scsi-cd support it), this patch
exposes it with new XML elements and of disk
device.
v3 - v4:
* Per Paolo's feedback, allows all printable chars.
---
docs/formatdomain.html.in
在 2012-11-22四的 13:41 +0800，li guang写道：
> 在 2012-11-21三的 23:21 -0600，Doug Goldstein写道：
> > On Nov 21, 2012, at 8:14 PM, li guang wrote:
> >
> > > ping ...
> >
> > The last review I asked that you drop the usage of qemu-img and use
> > libvirt's block APIs and extend them as necessary to make it
On Nov 21, 2012, at 11:41 PM, li guang wrote:
> 在 2012-11-21三的 23:21 -0600，Doug Goldstein写道：
>> On Nov 21, 2012, at 8:14 PM, li guang wrote:
>>
>>> ping ...
>>
>> The last review I asked that you drop the usage of qemu-img and use
>> libvirt's block APIs and extend them as necessary to make i
On Nov 21, 2012, at 8:55 PM, Laine Stump wrote:
> This bug resolves CVE-2012-3411, which is described in the following
> bugzilla report:
>
> https://bugzilla.redhat.com/show_bug.cgi?id=833033
>
> The following report is specifically for libvirt on Fedora:
>
> https://bugzilla.redhat.com/sho
On Nov 21, 2012, at 8:55 PM, Laine Stump wrote:
> This new function returns true if the given address is in the range of
> any "private" or "local" networks as defined in RFC1918 (IPv4) or
> RFC4193 (IPv6), otherwise they return false.
>
> These ranges are:
>
> 192.168.0.0/16
> 172.16.0.0/1
On Nov 21, 2012, at 8:55 PM, Laine Stump wrote:
> In order to optionally take advantage of new features in dnsmasq when
> the host's version of dnsmasq supports them, but still be able to run
> on hosts that don't support the new features, we need to be able to
> detect the version of dnsmasq run
在 2012-11-21三的 23:21 -0600，Doug Goldstein写道：
> On Nov 21, 2012, at 8:14 PM, li guang wrote:
>
> > ping ...
>
> The last review I asked that you drop the usage of qemu-img and use libvirt's
> block APIs and extend them as necessary to make it easier to call it.
> Otherwise you are duplicating f
On Nov 21, 2012, at 8:55 PM, Laine Stump wrote:
> In order to optionally take advantage of new features in dnsmasq when
> the host's version of dnsmasq supports them, but still be able to run
> on hosts that don't support the new features, we need to be able to
> detect the version of dnsmasq run
On Nov 21, 2012, at 8:14 PM, li guang wrote:
> ping ...
The last review I asked that you drop the usage of qemu-img and use libvirt's
block APIs and extend them as necessary to make it easier to call it. Otherwise
you are duplicating functionality, not respecting the probe option, and only
su
The managedsave test cases and test suite cover test include
verifying virsh commands managedsave(include all flags and their
combination)/managedsave-remove and managedSaveRemove/ManagedSave/
hasManagedSaveImage python APIs.
The following new files be created.
new file: cases/managedsave.conf
- Te
On 11/20/2012 01:49 PM, Laine Stump wrote:
Since we can't (currently) rely on the ability to provide blanket
support for all possible network changes by calling the toplevel
netdev hostside disconnect/connect functions (due to qemu only
supporting a lockstep between initialization of host side an
On 2012年11月21日 21:47, Eric Blake wrote:
On 11/20/2012 07:41 PM, Osier Yang wrote:
It's actually not used for DIR pool. So removing the checking.
---
src/storage/storage_backend_fs.c |5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
ACK.
Thanks, pushed.
--
libvir-list mailin
On 2012年11月21日 21:20, Peter Krempa wrote:
On 11/21/12 04:22, Osier Yang wrote:
Regression introduced by commit 258e06c85b7, "ret" could be set to 1
or 0 by virStorageBackendFileSystemIsMounted before goto cleanup.
This could mislead the callers (up to the public API
virStoragePoolDestroy) to ret
The 3 options accept 0, checking with if on the values of these
options causes wrong results.
---
tools/virsh-host.c | 40 ++--
1 files changed, 22 insertions(+), 18 deletions(-)
diff --git a/tools/virsh-host.c b/tools/virsh-host.c
index 5e6842a..3701f56 1006
It makes no sense to fail the whole command if there is parameter
unsupported by the kernel. This patch fixes it by ignoring the
unsupported parameter for getMemoryParameters, and ignoring the
unsupported parameter for setMemoryParameters too if there are
more than one parameters to set, otherwise
This bug resolves CVE-2012-3411, which is described in the following
bugzilla report:
https://bugzilla.redhat.com/show_bug.cgi?id=833033
The following report is specifically for libvirt on Fedora:
https://bugzilla.redhat.com/show_bug.cgi?id=874702
In short, a dnsmasq instance run with the i
This new function returns true if the given address is in the range of
any "private" or "local" networks as defined in RFC1918 (IPv4) or
RFC4193 (IPv6), otherwise they return false.
These ranges are:
192.168.0.0/16
172.16.0.0/16
10.0.0.0/24
FC00::/7
---
src/libvirt_private.syms | 1
In order to optionally take advantage of new features in dnsmasq when
the host's version of dnsmasq supports them, but still be able to run
on hosts that don't support the new features, we need to be able to
detect the version of dnsmasq running on the host, and possibly
determine from the help out
This patch series resolves the libvirt part of CVE 2012-3411:
https://bugzilla.redhat.com/show_bug.cgi?id=833033
Further details are in PATCH 3/3.
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
ping ...
在 2012-11-15四的 10:04 +0800，liguang写道：
> try to do non-shared migration without bothering to
> create disk images at target by hand.
>
> consider this situation:
> 1. non-shared migration
>virsh migrate --copy-storage-all ...
> 2. migration fails
> 3. create disk images required
>
On Wed, Nov 21, 2012 at 07:08:54AM -0700, Eric Blake wrote:
> On 11/09/2012 01:47 AM, Hu Tao wrote:
> > If .gnulib is deleted unexpectedly, autogen.sh will fail with message:
> >
> > fatal: ambiguous argument '.gnulib': unknown revision or path not in the
> > working tree.
> > Use '--' to separat
On Wed, Nov 21, 2012 at 10:13 AM, Martin Kletzander wrote:
> On 11/21/2012 05:06 PM, Ján Tomko wrote:
>> On 11/21/12 16:37, Martin Kletzander wrote:
>>> The 'virsh domdisplay' command is able to display the password
>>> configured for spice, but it was missing for vnc type graphics.
>>> This is ju
On 11/19/2012 03:53 PM, Eric Blake wrote:
> On 11/19/2012 09:06 AM, Peter Krempa wrote:
>> Some hypervisors require a respawn of the hypervisor to allow reverting
>> to some snapshot states. This patch adds flag to remove the default
>> safe approach to not allow this. When this flag is specified t
The DHCPv6 support includes IPV6 dhcp-range and dhcp-host for one
IPv6 subnetwork on one interface. This support will only work
if dnsmasq version >= 2.64; otherwise an error occurs if
dhcp-range or dhcp-host is specified.
Note that the check for dnsmasq version is performed at
network start and
This patch changes how parameters are passed to dnsmasq. Instead of
being on the command line, the parameters are put into a file (one
parameter per line) and the command line parameter --conf-file=
to specify the location of the file. This file is located in
the same directory as the leases file
The three patches are submitted with "one" because there is a
dependency between them. That is, patch 2 (DHCPv6) assumes that
patch 1 (guest-to-guest IPV6) has been applied and patch 3
(dnsmasq conf-file) assumes that patch 2 has been applied. While
other files are also changed, most of the chang
This patch adds the capability for virtual guests to do IPv6
communication via a virtual network interface with no IPv6
(gateway) addresses specified. That is, ip6tables rules
are added to permit the communications. This capability
currently exists for IPv4.
This patch allows creation of a compl
On 11/21/2012 11:06 AM, Scott Sullivan wrote:
> Hello,
>
> We were able to come up with this patch, which does fix the problem in
> our use case:
>
> http://pastebin.com/izx40mRd
>
Pastebins are transient; so reposting here:
> index d01e366..3b37ece 100644
> --- a/src/qemu/qemu_domain.c
> +++
On 11/21/2012 07:16 AM, Peter Krempa wrote:
+/* wipe and re-create disk images - qemu-img doesn't care if it
exists*/
+if (qemuDomainSnapshotCreateInactiveExternal(driver, vm, snap,
false) < 0)
+goto endjob;
>>>
>>> This comment says you are throwing away s
Hello,
We were able to come up with this patch, which does fix the problem in
our use case:
http://pastebin.com/izx40mRd
Interested to hear any feedback on the patch.
On 11/21/2012 12:13 PM, Eric Blake wrote:
On 11/21/2012 09:45 AM, Scott Sullivan wrote:
Hello,
I have been testing lib
On Wed, Nov 21, 2012 at 12:49 PM, Christophe Fergeau
wrote:
> On Tue, Nov 20, 2012 at 08:51:23PM +0200, Zeeshan Ali (Khattak) wrote:
>> From: "Zeeshan Ali (Khattak)"
>>
>> Without this patch, storage pool still lists the volume even after it is
>> deleted.
>>
>> Related Boxes bug: https://bugzill
From: "Zeeshan Ali (Khattak)"
Without this patch, storage pool still lists the volume even after it is
deleted.
Related Boxes bug: https://bugzilla.gnome.org/show_bug.cgi?id=688724
---
.../libvirt-gobject-storage-pool-private.h | 33 ++
libvirt-gobject/libvirt-gobjec
On 11/21/2012 10:43 AM, Michal Privoznik wrote:
> On 20.11.2012 19:47, Ján Tomko wrote:
>> Commit a4c19459aa8634c43b51e8138fb1d7eec4c17824 missed the functionality
>> for redirected USB devices (fixed in 1/4), documentation and tests.
>>
>> https://bugzilla.redhat.com/show_bug.cgi?id=805414
>>
>>
>
On 11/21/2012 10:43 AM, Michal Privoznik wrote:
>> +++ b/tests/qemuxml2argvdata/qemuxml2argv-usb-redir-boot.args
>> @@ -0,0 +1,10 @@
>> +LC_ALL=C PATH=/bin HOME=/home/test USER=test LOGNAME=test /usr/bin/qemu -S
>> -M pc -m 214 -smp 1 -nographic -nodefconfig -nodefaults -chardev
>> socket,id=cha
On 11/21/2012 10:44 AM, Michal Privoznik wrote:
> On 20.11.2012 19:47, Ján Tomko wrote:
>> Both generated with
>> qemu-system-x86_64 --help > qemu-1.2.0
>>
>> qemu-system-x86_64 \
>> -device ? \
>> -device pci-assign,? \
>> -device virtio-blk-pci,? \
>> -device virtio-net-pci,? \
>> -device scsi-di
On 20.11.2012 19:47, Ján Tomko wrote:
> And a few spaces.
> ---
> docs/formatdomain.html.in | 27 +++
> 1 files changed, 19 insertions(+), 8 deletions(-)
>
> diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
> index c8da33d..6a3b976 100644
> --- a/docs/f
On 20.11.2012 19:47, Ján Tomko wrote:
> ---
> ...muxml2argv-hostdev-usb-address-device-boot.args |6 +++
> ...emuxml2argv-hostdev-usb-address-device-boot.xml | 28 +
> .../qemuxml2argv-usb-redir-boot.args | 10 +
> .../qemuxml2argv-usb-redir-boot.xml
On 20.11.2012 19:47, Ján Tomko wrote:
> Both generated with
> qemu-system-x86_64 --help > qemu-1.2.0
>
> qemu-system-x86_64 \
> -device ? \
> -device pci-assign,? \
> -device virtio-blk-pci,? \
> -device virtio-net-pci,? \
> -device scsi-disk,? \
> -device PIIX4_PM,? \
> -device usb-redir,? \
> -d
On 20.11.2012 19:47, Ján Tomko wrote:
> Commit a4c19459aa8634c43b51e8138fb1d7eec4c17824 only added the
> QEMU capability flag, command line option and added the boot element
> for redirdev's in the XML schema.
>
> This patch adds support for parsing and writing the XML with redirdevs
> with the bo
On 20.11.2012 19:47, Ján Tomko wrote:
> Commit a4c19459aa8634c43b51e8138fb1d7eec4c17824 missed the functionality
> for redirected USB devices (fixed in 1/4), documentation and tests.
>
> https://bugzilla.redhat.com/show_bug.cgi?id=805414
>
> Ján Tomko (4):
> conf: add support for booting from r
On 11/21/12 17:13, Martin Kletzander wrote:
> On 11/21/2012 05:06 PM, Ján Tomko wrote:
>>
>> Wouldn't it be better to put the password before the host
>> (vnc://:passwd@host:port) so that at least some clients (krdc from the
>> few that I've tried) can understand the whole URI?
>>
>> Jan
>>
>
> TB
On 11/21/2012 09:45 AM, Scott Sullivan wrote:
> Hello,
>
> I have been testing libvirt v1.0.0 for deployment within my
> organization, and in the process discovered what appears to be a bug
> that breaks virsh attach-device, when attaching an RBD volume to an
> instance. First, here is the error p
Hello,
I have been testing libvirt v1.0.0 for deployment within my
organization, and in the process discovered what appears to be a bug
that breaks virsh attach-device, when attaching an RBD volume to an
instance. First, here is the error presented, with v1.0.0 (this worked
in v0.10.2):
[ro
On 11/21/2012 05:06 PM, Ján Tomko wrote:
> On 11/21/12 16:37, Martin Kletzander wrote:
>> The 'virsh domdisplay' command is able to display the password
>> configured for spice, but it was missing for vnc type graphics.
>> This is just a simple patch for that to work properly.
>> ---
>> tools/virs
On 11/21/12 16:37, Martin Kletzander wrote:
> The 'virsh domdisplay' command is able to display the password
> configured for spice, but it was missing for vnc type graphics.
> This is just a simple patch for that to work properly.
> ---
> tools/virsh-domain.c | 17 +
> 1 file chan
On 11/21/2012 04:39 PM, Daniel P. Berrange wrote:
> On Wed, Nov 21, 2012 at 04:37:35PM +0100, Martin Kletzander wrote:
>> The 'virsh domdisplay' command is able to display the password
>> configured for spice, but it was missing for vnc type graphics.
>> This is just a simple patch for that to work
Il 20/11/2012 11:17, Daniel P. Berrange ha scritto:
> If we do the mapping of HBAs to guest domains using storage
> pools, then at a guest level, migration requires zero work.
I guess that means adding ?
> It is simply upto the management app to create the storage
> pool on the destination host w
On Wed, Nov 21, 2012 at 04:37:35PM +0100, Martin Kletzander wrote:
> The 'virsh domdisplay' command is able to display the password
> configured for spice, but it was missing for vnc type graphics.
> This is just a simple patch for that to work properly.
> ---
> tools/virsh-domain.c | 17 +
The 'virsh domdisplay' command is able to display the password
configured for spice, but it was missing for vnc type graphics.
This is just a simple patch for that to work properly.
---
tools/virsh-domain.c | 17 +
1 file changed, 17 insertions(+)
diff --git a/tools/virsh-domain.c
On Wed, Nov 21, 2012 at 02:59:47PM +0100, Ján Tomko wrote:
> bridge_driver.h: silence gcc warnings:
> statement with no effect [-Wunused-value]
> unused variable 'net' [-Wunused-variable]
>
> virdrivermoduletest.c: don't require network driver module
> if it hasn't been built.
> ---
> src/network
On 11/21/12 15:14, Eric Blake wrote:
On 11/21/2012 04:05 AM, Peter Krempa wrote:
Commit e0c469e58b93f852a72265919703cb6abd3779f8 that fixes the detection
of image chain wasn't complete. Iteration through the backing image
chain has to stop at the last existing image if some of the images are
mis
On 11/21/2012 06:59 AM, Ján Tomko wrote:
> bridge_driver.h: silence gcc warnings:
> statement with no effect [-Wunused-value]
> unused variable 'net' [-Wunused-variable]
>
> virdrivermoduletest.c: don't require network driver module
> if it hasn't been built.
> ---
> src/network/bridge_driver.h |
virConnectGetVersion can return 0 'if the version can't be extracted
by lack of capabilities'. I've also seen it return 0 when libvirtd
1.0 is running but virsh 0.10.2 is used to get the version.
gvir_connection_get_version is documented as returning 0 on error.
However, currently it only sets the
On 11/21/2012 06:05 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange"
>
> The LXC controller code currently directly invokes the
> libvirt main loop code. The problem is that this misses
> the cleanup of virNetServerClient connections that
> virNetServerRun takes care of.
>
> The result
On 11/21/12 01:37, Eric Blake wrote:
On 11/19/2012 04:51 PM, Eric Blake wrote:
On 11/19/2012 09:06 AM, Peter Krempa wrote:
This patch adds support for reverting of external snapshots. The support
is somewhat limited yet (you can only revert to a snapshot that has no
children or delete the child
On 11/21/2012 04:05 AM, Peter Krempa wrote:
> Commit e0c469e58b93f852a72265919703cb6abd3779f8 that fixes the detection
> of image chain wasn't complete. Iteration through the backing image
> chain has to stop at the last existing image if some of the images are
> missing otherwise the backing chain
On 11/09/2012 01:47 AM, Hu Tao wrote:
> If .gnulib is deleted unexpectedly, autogen.sh will fail with message:
>
> fatal: ambiguous argument '.gnulib': unknown revision or path not in the
> working tree.
> Use '--' to separate paths from revisions, like this:
> 'git [...] -- [...]'
>
> which is
bridge_driver.h: silence gcc warnings:
statement with no effect [-Wunused-value]
unused variable 'net' [-Wunused-variable]
virdrivermoduletest.c: don't require network driver module
if it hasn't been built.
---
src/network/bridge_driver.h |4 ++--
tests/virdrivermoduletest.c |8
On 11/20/2012 07:41 PM, Osier Yang wrote:
> It's actually not used for DIR pool. So removing the checking.
> ---
> src/storage/storage_backend_fs.c |5 ++---
> 1 files changed, 2 insertions(+), 3 deletions(-)
ACK.
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization l
On 11/21/12 04:22, Osier Yang wrote:
Regression introduced by commit 258e06c85b7, "ret" could be set to 1
or 0 by virStorageBackendFileSystemIsMounted before goto cleanup.
This could mislead the callers (up to the public API
virStoragePoolDestroy) to return success even the underlying umount
comm
From: "Daniel P. Berrange"
The LXC controller code currently directly invokes the
libvirt main loop code. The problem is that this misses
the cleanup of virNetServerClient connections that
virNetServerRun takes care of.
The result is that when libvirtd is stopped, the
libvirt_lxc controller proc
On 11/21/2012 07:31 AM, Daniel P. Berrange wrote:
On Wed, Nov 21, 2012 at 07:18:20AM -0500, Gene Czarcinski wrote:
On 11/20/2012 05:29 PM, Laine Stump wrote:
On 11/20/2012 02:36 PM, Gene Czarcinski wrote:
Laine mentioned something yesterday that got me to thinking: being
able to specify that d
This patch adds the capability for virtual guests to do IPv6
communication via a virtual network interface with no IPv6
(gateway) addresses specified. This capability currently
exists for IPv4.
This patch allows creation of a completely isolated IPv6 network.
Note that virtual guests cannot comm
On Wed, Nov 21, 2012 at 07:18:20AM -0500, Gene Czarcinski wrote:
> On 11/20/2012 05:29 PM, Laine Stump wrote:
> >On 11/20/2012 02:36 PM, Gene Czarcinski wrote:
> >>Laine mentioned something yesterday that got me to thinking: being
> >>able to specify that dnsmasq is not to be started for an interfa
On 11/20/2012 05:29 PM, Laine Stump wrote:
On 11/20/2012 02:36 PM, Gene Czarcinski wrote:
Laine mentioned something yesterday that got me to thinking: being
able to specify that dnsmasq is not to be started for an interface.
Let me expand that by saying that libvirt would not start dnsmasq for
On Wed, Nov 21, 2012 at 11:56:54AM +0100, Ján Tomko wrote:
> On 11/21/12 10:06, Daniel P. Berrange wrote:
> > On Wed, Nov 21, 2012 at 09:22:25AM +0100, Ján Tomko wrote:
> >> On 11/20/12 20:36, Toralf Förster wrote:
> >>>
> >>> n22 /var/tmp/portage/app-emulation/libvirt-1.0.0/work/libvirt-1.0.0/test
Commit e0c469e58b93f852a72265919703cb6abd3779f8 that fixes the detection
of image chain wasn't complete. Iteration through the backing image
chain has to stop at the last existing image if some of the images are
missing otherwise the backing chain that is cached contains entries with
paths being se
On 11/21/12 10:06, Daniel P. Berrange wrote:
> On Wed, Nov 21, 2012 at 09:22:25AM +0100, Ján Tomko wrote:
>> On 11/20/12 20:36, Toralf Förster wrote:
>>>
>>> n22 /var/tmp/portage/app-emulation/libvirt-1.0.0/work/libvirt-1.0.0/tests #
>>> VIR_TEST_DEBUG=1 ./virdrivermoduletest
>>> TEST: virdrivermo
On Tue, Nov 20, 2012 at 08:51:23PM +0200, Zeeshan Ali (Khattak) wrote:
> From: "Zeeshan Ali (Khattak)"
>
> Without this patch, storage pool still lists the volume even after it is
> deleted.
>
> Related Boxes bug: https://bugzilla.gnome.org/show_bug.cgi?id=688724
> ---
> libvirt-gobject/libvirt
On Wed, Nov 21, 2012 at 09:30:02AM +0100, Michal Privoznik wrote:
> On 20.11.2012 19:51, Zeeshan Ali (Khattak) wrote:
> The latter one has been already checked as can be seen in context of the
> last chunk. The first one should not fail since it is us who inserted
> the value into volume->priv->vol
ping...
On Fri, Nov 09, 2012 at 04:47:04PM +0800, Hu Tao wrote:
> If .gnulib is deleted unexpectedly, autogen.sh will fail with message:
>
> fatal: ambiguous argument '.gnulib': unknown revision or path not in the
> working tree.
> Use '--' to separate paths from revisions, like this:
> 'git [.
ping...
On Wed, Nov 07, 2012 at 06:38:40PM +0800, Hu Tao wrote:
> The reason to disable cgroup cpuset by default is: currently,
> sub-directories of cgroup cpuset won't be auto-updated if
> cpu hot-plug happens. For example, if we now have 0-3,5-7 pcpus
> online, the value of /sys/fs/cgroup/cpuset
On Wed, Nov 21, 2012 at 09:22:25AM +0100, Ján Tomko wrote:
> On 11/20/12 20:36, Toralf Förster wrote:
> >
> > n22 /var/tmp/portage/app-emulation/libvirt-1.0.0/work/libvirt-1.0.0/tests #
> > VIR_TEST_DEBUG=1 ./virdrivermoduletest
> > TEST: virdrivermoduletest
> > 1) Test driver "storage"
- Original Message -
> On Tue, Nov 20, 2012 at 01:16:56PM -0500, Andrew Jones wrote:
> >
> > This mail is meant to get a discussion started. Please keep me on
> > cc
> > for the discussion, as I'm not subscribed to libvir-list.
> >
> > ivshmem is an implementation of an inter-VM communi
original migration did not aware of offline case,
so, try to support offline migration quietly
(did not disturb original migration) by pass
VIR_MIGRATE_OFFLINE flag to migration APIs if only
the domain is really inactive, and
migration process will not puzzled by domain
offline and exit unexpectedl
On 20.11.2012 19:51, Zeeshan Ali (Khattak) wrote:
> From: "Zeeshan Ali (Khattak)"
>
> Without this patch, storage pool still lists the volume even after it is
> deleted.
>
> Related Boxes bug: https://bugzilla.gnome.org/show_bug.cgi?id=688724
> ---
> libvirt-gobject/libvirt-gobject-storage-pool
On 11/20/12 20:36, Toralf Förster wrote:
>
> n22 /var/tmp/portage/app-emulation/libvirt-1.0.0/work/libvirt-1.0.0/tests #
> VIR_TEST_DEBUG=1 ./virdrivermoduletest
> TEST: virdrivermoduletest
> 1) Test driver "storage" ... OK
> 2) Test driver "nodedev"
77 matches
Mail list logo
