[libvirt] [PATCH 2/2] Qemu FreeBSD: fix compilation

2012-12-11 Thread Roman Bogorodskiy
* Autotools changes: - Don't assume Qemu is Linux-only - Check Linux headers only on Linux - Disable firewalld on FreeBSD * Initctl: Initctl seem to present only on Linux, so stub it on other platforms * Raw I/O: Linux-only as well * Headers cleanup --- configure.ac| 42 +++

[libvirt] [PATCH 1/2] Drop mntent.h include.

2012-12-11 Thread Roman Bogorodskiy
It's no longer used and also causes build fail on FreeBSD. --- src/qemu/qemu_conf.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c index 8d380a1..e95609c 100644 --- a/src/qemu/qemu_conf.c +++ b/src/qemu/qemu_conf.c @@ -34,7 +34,6 @@ #include #incl

[libvirt] [PATCH 0/2] qemu driver FreeBSD support: fix compilation, second round

2012-12-11 Thread Roman Bogorodskiy
Second version of the patch which addresses issues pointed out by the reviewers. Roman Bogorodskiy (2): Drop mntent.h include. Qemu FreeBSD: fix compilation configure.ac| 42 ++ src/qemu/qemu_conf.c| 1 - src/qemu/qemu_process.c | 12 +

Re: [libvirt] [PATCH] Revert "dnsmasq: Fix parsing of the version number"

2012-12-11 Thread Michal Privoznik
On 12.12.2012 02:14, Cole Robinson wrote: > On 12/10/2012 08:49 AM, Michal Privoznik wrote: >> This reverts commit 5114431396fd125b6ebe4d1a20a98f948ee7 >> which was pushed accidentally. >> --- >> >> Sorry for the inconvenience. >> >> src/util/dnsmasq.c |4 ++-- >> 1 files changed, 2 insert

[libvirt] [PATCHv2 2/5] qemu: Refactor managed save functions to use domain lookup helpers

2012-12-11 Thread Peter Krempa
--- Diff to v1: -unlock the domain in qemuDomainHasManagedSaveImage() --- src/qemu/qemu_driver.c | 53 +- 1 file changed, 13 insertions(+), 40 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 9173413..4144e6f 100644 -

Re: [libvirt] [PATCH 2/4] qemu: Refactor managed save functions to use domain lookup helpers

2012-12-11 Thread Peter Krempa
On 12/11/12 22:50, Eric Blake wrote: On 12/11/2012 11:48 AM, Peter Krempa wrote: --- src/qemu/qemu_driver.c | 54 +++--- 1 file changed, 12 insertions(+), 42 deletions(-) Nice reduction in size. However, you need a v2... [...] -cleanup: -

Re: [libvirt] [PATCH 01/12] qemu: Add a hash table for the shared disks

2012-12-11 Thread Osier Yang
On 2012年12月11日 21:37, Osier Yang wrote: This introduces a hash table for qemu driver, to store the shared disk's info as (@disk_path, {@ref_count, @orig_cdbfilter}). @ref_count is the number of domains which shares the disk. @orig_cdbfilter is the original cdbfilter setting of the shared disk, it

Re: [libvirt] [PATCH 01/12] qemu: Add a hash table for the shared disks

2012-12-11 Thread Osier Yang
On 2012年12月12日 11:35, Osier Yang wrote: On 2012年12月11日 21:37, Osier Yang wrote: This introduces a hash table for qemu driver, to store the shared disk's info as (@disk_path, {@ref_count, @orig_cdbfilter}). @ref_count is the number of domains which shares the disk. @orig_cdbfilter is the original

Re: [libvirt] [PATCH v2 3/4] qemu: use newer -device video device in qemu commandline

2012-12-11 Thread Guannan Ren
On 12/12/2012 02:25 AM, Eric Blake wrote: On 12/11/2012 07:14 AM, Guannan Ren wrote: '-device VGA' maps to '-vga std' '-device cirrus-vga' maps to '-vga cirrus' '-device qxl-vga' maps to '-vga qxl' (there is also '-device qxl' for secondary devices) '-device vmware-svga' maps to '-

[libvirt] Entering freeze for libvirt-1.0.1

2012-12-11 Thread Daniel Veillard
As planned I have just tagged the tree and pushed a release candidate 1 tarball and assorted rpms to ftp://libvirt.org/libvirt/ If everything goes well, I will push an rc2 on Friday incorporating the various fixes found in the meantime and plan to push the final release early Monday 17. G

Re: [libvirt] [Fedora-xen] [Xen-devel] [PATCH] Convert libxl driver to Xen 4.2

2012-12-11 Thread Cole Robinson
On 12/07/2012 11:18 AM, Dario Faggioli wrote: > On Thu, 2012-12-06 at 16:20 -0700, Jim Fehlig wrote: V2: Remove 128 vcpu limit. Remove split_string_into_string_list() function copied from xen sources since libvirt now has virStringSplit(). >>> >>> Tested on Fedo

[libvirt] ANNOUNCE: libvirt 0.9.11.8 maintenance release

2012-12-11 Thread Cole Robinson
libvirt 0.9.11.8 maintenance release is now available. This is libvirt 0.9.11 with additional bugfixes that have accumulated upstream since the initial release. This release can be downloaded at: http://libvirt.org/sources/stable_updates/libvirt-0.9.11.8.tar.gz Changes in this version: * qemu:

[libvirt] ANNOUNCE: libvirt 0.10.2.2 maintenance release

2012-12-11 Thread Cole Robinson
libvirt 0.10.2.2 maintenance release is now available. This is libvirt 0.10.2 with additional bugfixes that have accumulated upstream since the initial release. This release can be downloaded at: http://libvirt.org/sources/stable_updates/libvirt-0.10.2.2.tar.gz Changes in this version: * dnsmas

Re: [libvirt] [PATCH RESEND] tools: Only install guests init script if --with-init=script=redhat

2012-12-11 Thread Cole Robinson
On 12/11/2012 04:19 PM, Eric Blake wrote: > On 12/08/2012 08:23 PM, Cole Robinson wrote: >> Most of this deals with moving the libvirt-guests.sh script which >> does all the work to /usr/libexec, so it can be shared by both >> systemd and traditional init. Previously systemd depended on >> the scri

Re: [libvirt] [PATCH] uml: Report error if inotify fails on driver startup

2012-12-11 Thread Cole Robinson
On 12/09/2012 02:44 PM, Peter Krempa wrote: > On 12/09/12 02:48, Cole Robinson wrote: >> --- >> Someone at KVM forum was actually hitting an error here, since their system >> had exceeded the max number of inotify watches somehow. >> >> src/uml/uml_driver.c | 7 ++- >> 1 file changed, 6 inse

Re: [libvirt] [PATCH] Revert "dnsmasq: Fix parsing of the version number"

2012-12-11 Thread Cole Robinson
On 12/10/2012 08:49 AM, Michal Privoznik wrote: > This reverts commit 5114431396fd125b6ebe4d1a20a98f948ee7 > which was pushed accidentally. > --- > > Sorry for the inconvenience. > > src/util/dnsmasq.c |4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/util

Re: [libvirt] [PATCH] BZ 657918 Default iptables setup in libvirt breaks mDNS

2012-12-11 Thread Brian J. Murrell
On 12-12-11 06:24 PM, Eric Blake wrote: > > Thanks! NP. Had it just lying around here anyway. :-) > Comment should now mention 4 rules. Doh! Missed that in the patch port. Updated in my local copy (which I will of course resend once all of the initial review is done). >> +/* exempt mu

Re: [libvirt] [PATCH 04/14] Remove bogus const return values in storage file APIs

2012-12-11 Thread Eric Blake
On 12/11/2012 01:41 PM, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > virStorageFileGetLVMKey and virStorageFileGetSCSIKey > both return heap allocated strings, so the return value > should not be marked const. > > Signed-off-by: Daniel P. Berrange > --- > src/util/storage_file.c

Re: [libvirt] [PATCH] BZ 657918 Default iptables setup in libvirt breaks mDNS

2012-12-11 Thread Eric Blake
On 12/11/2012 03:54 PM, Brian J. Murrell wrote: > Hi, > > Per the request on https://bugzilla.redhat.com/show_bug.cgi?id=657918 > please find attached a patch that should address the issue. Thanks! > > I'm not subscribed to this list though (I know, it's pretty rude, but > my e-mail traffic is

[libvirt] [PATCH] BZ 657918 Default iptables setup in libvirt breaks mDNS

2012-12-11 Thread Brian J. Murrell
Hi, Per the request on https://bugzilla.redhat.com/show_bug.cgi?id=657918 please find attached a patch that should address the issue. I'm not subscribed to this list though (I know, it's pretty rude, but my e-mail traffic is already too heavy to add another list to it), so if you could either CC

Re: [libvirt] [PATCH] Fix sorting of libvirt_private.syms and add syntax check rule

2012-12-11 Thread Eric Blake
On 12/11/2012 03:27 PM, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > Add check-symsorting.pl to perform case-insensitive alphabetical > sorting of groups of symbols. Fix all violations it reports > > Signed-off-by: Daniel P. Berrange > --- > src/Makefile.am | 4 +- > s

[libvirt] [PATCH] Fix sorting of libvirt_private.syms and add syntax check rule

2012-12-11 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Add check-symsorting.pl to perform case-insensitive alphabetical sorting of groups of symbols. Fix all violations it reports Signed-off-by: Daniel P. Berrange --- src/Makefile.am | 4 +- src/check-symsorting.pl | 66 +++ src/libvirt_esx.s

Re: [libvirt] [PATCH 2/2] add vnc unix sockets to apparmor policy (v2)

2012-12-11 Thread Serge Hallyn
Quoting Eric Blake (ebl...@redhat.com): > On 12/11/2012 01:25 PM, Daniel P. Berrange wrote: > > On Tue, Dec 11, 2012 at 08:20:30PM +, se...@hallyn.com wrote: > > Instead of putting '(v2)' as a suffix (which I then have to manually > strip via 'git commit --amend'), it is nicer to put it in the

Re: [libvirt] [PATCH 4/4] qemu: Improve error reporting from qemuDomainManagedSaveRemove

2012-12-11 Thread Eric Blake
On 12/11/2012 11:48 AM, Peter Krempa wrote: > Report an error if unlink of the managedsave file fails. > --- > Hm, this patch changes semantics a little bit. If the unlink() fails now, > the domain isn't marked as not having a managed save file. If somebody does > not like this change I will return

Re: [libvirt] [PATCH 03/14] Refactor creation of lock manager plugins

2012-12-11 Thread Eric Blake
On 12/11/2012 01:41 PM, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > Refactor virLockManagerPluginNew() so that the caller does > not need to pass in the config file path itself - just the > config directory and driver name. > > Fix QEMU to actually pass in a config file when creat

Re: [libvirt] [PATCH 3/4] qemu: Small code cleanups in the managedsave functions

2012-12-11 Thread Eric Blake
On 12/11/2012 11:48 AM, Peter Krempa wrote: > Save a few lines moving assignments into conditions and fix braces > position. > --- > src/qemu/qemu_driver.c | 9 - > 1 file changed, 4 insertions(+), 5 deletions(-) > ACK. Cosmetic, but brings it more in line with our style. -- Eric Blak

Re: [libvirt] [PATCH 2/4] qemu: Refactor managed save functions to use domain lookup helpers

2012-12-11 Thread Eric Blake
On 12/11/2012 11:48 AM, Peter Krempa wrote: > --- > src/qemu/qemu_driver.c | 54 > +++--- > 1 file changed, 12 insertions(+), 42 deletions(-) Nice reduction in size. However, you need a v2... > @@ -3323,50 +3316,28 @@ cleanup: > static int > qemuDom

Re: [libvirt] [PATCH 1/4] qemu: Add a new domain lookup helper and improve the docs

2012-12-11 Thread Eric Blake
On 12/11/2012 11:48 AM, Peter Krempa wrote: > This patch adds a new domain lookup helper qemuDomObjFromDomainDriver > that lookups the domain and leaves the driver locked. The driver is > returned as the second argument of that function. If the lookup fails > the driver is unlocked to help avoid cl

Re: [libvirt] [PATCH 02/14] Add missing export of virStorageFileGetLVMKey & virStorageFileGetSCSIKey

2012-12-11 Thread Daniel P. Berrange
On Tue, Dec 11, 2012 at 02:31:00PM -0700, Eric Blake wrote: > On 12/11/2012 01:41 PM, Daniel P. Berrange wrote: > > From: "Daniel P. Berrange" > > > > --- > > src/libvirt_private.syms | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/src/libvirt_private.syms b/src/libvirt_private

Re: [libvirt] [PATCH 2/2] add vnc unix sockets to apparmor policy (v2)

2012-12-11 Thread Eric Blake
On 12/11/2012 01:25 PM, Daniel P. Berrange wrote: > On Tue, Dec 11, 2012 at 08:20:30PM +, se...@hallyn.com wrote: Instead of putting '(v2)' as a suffix (which I then have to manually strip via 'git commit --amend'), it is nicer to put it in the prefix [PATCHv2 2/2] (doable with 'git send-email

Re: [libvirt] [PATCH 02/14] Add missing export of virStorageFileGetLVMKey & virStorageFileGetSCSIKey

2012-12-11 Thread Eric Blake
On 12/11/2012 01:41 PM, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > --- > src/libvirt_private.syms | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms > index 7d083e4..7949d5b 100644 > --- a/src/libvirt_private.syms > +++

Re: [libvirt] [PATCH RESEND] tools: Only install guests init script if --with-init=script=redhat

2012-12-11 Thread Eric Blake
On 12/08/2012 08:23 PM, Cole Robinson wrote: > Most of this deals with moving the libvirt-guests.sh script which > does all the work to /usr/libexec, so it can be shared by both > systemd and traditional init. Previously systemd depended on > the script being in /etc/init.d > > Required to fix htt

Re: [libvirt] [PATCH v3 1/2] storage: allow metadata preallocation when creating qcow2 images

2012-12-11 Thread Eric Blake
On 12/05/2012 09:29 AM, Michal Privoznik wrote: >> + * >> + * Since 1.0.1 VIR_STORAGE_VOL_CREATE_PREALLOC_METADATA >> + * in flags can be used to get higher performance with >> + * qcow2 image files which don't support full preallocation, >> + * by creating a sparse image file with metadata. > >

Re: [libvirt] [PATCH 01/14] Avoid polluting logs when querying LVM/SCSI ID

2012-12-11 Thread Peter Krempa
On 12/11/12 21:41, Daniel P. Berrange wrote: From: "Daniel P. Berrange" When we invoke lvs or scsi_id to extract ID for block devices, we don't want virCommandWait logging errors messages. Thus we must explicitly check 'status != 0', rather than letting virCommandWait do it. Also move the check

Re: [libvirt] [PATCH] maint: mention when HACKING is rebuilt during make

2012-12-11 Thread Eric Blake
On 12/06/2012 04:44 PM, Eric Blake wrote: > I noticed that on Fedora 18, xlstproc decides to regenerate > HACKING with additional whitespace. I haven't figured out why > that is happening (although fixing it would probably be a task > for xlstproc), but in the process of investigating, I noticed >

Re: [libvirt] [PATCH 02/14] Add missing export of virStorageFileGetLVMKey & virStorageFileGetSCSIKey

2012-12-11 Thread Peter Krempa
On 12/11/12 21:41, Daniel P. Berrange wrote: From: "Daniel P. Berrange" --- src/libvirt_private.syms | 2 ++ 1 file changed, 2 insertions(+) ACK Peter -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH 00/14 v4] Implement virtlockd daemon

2012-12-11 Thread Daniel P. Berrange
This is an update of https://www.redhat.com/archives/libvir-list/2012-September/msg00816.html This series was previously fully acked, but before pushing I noticed some problems and stopped. Since then I've done quite a few more changes to rebase to latest GIT & follow new best practice. I've a

[libvirt] [PATCH 11/14] Add ability to maintain disk leases indirectly

2012-12-11 Thread Daniel P. Berrange
From: "Daniel P. Berrange" The default lockd driver behavour is to acquire leases directly on the disk files. This introduces an alternative mode, where leases are acquire indirectly on a file that is based on a SHA256 hash of the disk filename. Signed-off-by: Daniel P. Berrange --- bootstrap.

[libvirt] [PATCH 12/14] Add support for locking based on LVM volume uuid

2012-12-11 Thread Daniel P. Berrange
From: "Daniel P. Berrange" --- src/locking/lock_driver_lockd.c | 35 ++- src/locking/lockd.conf | 14 ++ 2 files changed, 48 insertions(+), 1 deletion(-) diff --git a/src/locking/lock_driver_lockd.c b/src/locking/lock_driver_lockd.c index aa0

[libvirt] [PATCH 10/14] Add a virtlockd client as a lock driver impl

2012-12-11 Thread Daniel P. Berrange
From: "Daniel P. Berrange" This adds a 'lockd' lock driver which is just a client which talks to the lockd daemon to perform all locking. This will be the default lock driver for any hypervisor which needs one. * src/Makefile.am: Add lockd.so plugin * src/locking/lock_driver_lockd.c: Lockd drive

[libvirt] [PATCH 13/14] Add support for locking based on SCSI volume ID

2012-12-11 Thread Daniel P. Berrange
From: "Daniel P. Berrange" --- src/locking/lock_driver_lockd.c | 31 +++ src/locking/lockd.conf | 14 ++ 2 files changed, 45 insertions(+) diff --git a/src/locking/lock_driver_lockd.c b/src/locking/lock_driver_lockd.c index abae52d..8b07875 10064

[libvirt] [PATCH 08/14] Enable systemd socket activation with virtlockd

2012-12-11 Thread Daniel P. Berrange
From: "Daniel P. Berrange" This enhancement virtlockd so that it can receive a pre-opened UNIX domain socket from systemd at launch time, and adds the systemd service/socket unit files * daemon/libvirtd.service.in: Require virtlockd to be running * libvirt.spec.in: Add virtlockd systemd files *

[libvirt] [PATCH 07/14] Implement dispatch functions for lock protocol in virtlockd

2012-12-11 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Introduce a lock_daemon_dispatch.c file which implements the server side dispatcher the RPC APIs previously defined in the lock protocol. Signed-off-by: Daniel P. Berrange --- .gitignore | 1 + po/POTFILES.in | 1 + src

[libvirt] [PATCH 14/14] Change the default QEMU lock manager to 'lockd'

2012-12-11 Thread Daniel P. Berrange
From: "Daniel P. Berrange" The current default QEMU lock manager is the 'nop' lock manager, which obviously does not perform any locking. The new virtlockd daemon is able to work out of the box with zero configuration in single-host only mode. Enable this as the default lock manager for all QEMU

[libvirt] [PATCH 06/14] Define a wire protocol for talking to the virtlockd daemon

2012-12-11 Thread Daniel P. Berrange
From: "Daniel P. Berrange" The virtlockd daemon will be responsible for managing locks on virtual machines. Communication will be via the standard RPC infrastructure. This provides the XDR protocol definition * src/locking/lock_protocol.x: Wire protocol for virtlockd * src/Makefile.am: Include l

[libvirt] [PATCH 09/14] Add support for re-exec() of virtlockd upon SIGUSR1

2012-12-11 Thread Daniel P. Berrange
From: "Daniel P. Berrange" The virtlockd daemon maintains file locks on behalf of libvirtd and any VMs it is running. These file locks must be held for as long as any VM is running. If virtlockd itself ever quits, then it is expected that a node would be fenced/rebooted. Thus to allow for softwar

[libvirt] [PATCH 02/14] Add missing export of virStorageFileGetLVMKey & virStorageFileGetSCSIKey

2012-12-11 Thread Daniel P. Berrange
From: "Daniel P. Berrange" --- src/libvirt_private.syms | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 7d083e4..7949d5b 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -1169,6 +1169,8 @@ virStorageFileChainL

[libvirt] [PATCH 05/14] Introduce basic infrastructure for virtlockd daemon

2012-12-11 Thread Daniel P. Berrange
From: "Daniel P. Berrange" The virtlockd daemon will maintain locks on behalf of libvirtd. There are two reasons for it to be separate - Avoid risk of other libvirtd threads accidentally releasing fcntl() locks by opening + closing a file that is locked - Ensure locks can be preserved ac

[libvirt] [PATCH 04/14] Remove bogus const return values in storage file APIs

2012-12-11 Thread Daniel P. Berrange
From: "Daniel P. Berrange" virStorageFileGetLVMKey and virStorageFileGetSCSIKey both return heap allocated strings, so the return value should not be marked const. Signed-off-by: Daniel P. Berrange --- src/util/storage_file.c | 8 src/util/storage_file.h | 4 ++-- 2 files changed, 6 i

[libvirt] [PATCH 01/14] Avoid polluting logs when querying LVM/SCSI ID

2012-12-11 Thread Daniel P. Berrange
From: "Daniel P. Berrange" When we invoke lvs or scsi_id to extract ID for block devices, we don't want virCommandWait logging errors messages. Thus we must explicitly check 'status != 0', rather than letting virCommandWait do it. Also move the check for converting from "" to NULL, after the clea

[libvirt] [PATCH 03/14] Refactor creation of lock manager plugins

2012-12-11 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Refactor virLockManagerPluginNew() so that the caller does not need to pass in the config file path itself - just the config directory and driver name. Fix QEMU to actually pass in a config file when creating the default lock manager plugin, rather than NULL. Signed-o

[libvirt] [PATCH] util: rework error reporting in virGet(User|Group)IDByName

2012-12-11 Thread Peter Krempa
This patch gets rid of the undeterministic error reporting code done on return values of get(pw|gr)nam_r. With this patch, if the group record is not returned by the corresponding function this error is not considered fatal even if errno != 0. The error is logged in such case. --- src/util/util.c

Re: [libvirt] [PATCH 1/2] add security hook for permitting hugetlbfs access (v2)

2012-12-11 Thread Daniel P. Berrange
On Tue, Dec 11, 2012 at 08:20:29PM +, se...@hallyn.com wrote: > From: Serge Hallyn > > When a qemu domain is backed by huge pages, apparmor needs to grant the domain > rw access to files under the hugetlbfs mount point. Add a hook, called in > qemu_process.c, which ends up adding the read-wr

Re: [libvirt] [PATCH 2/2] add vnc unix sockets to apparmor policy (v2)

2012-12-11 Thread Daniel P. Berrange
On Tue, Dec 11, 2012 at 08:20:30PM +, se...@hallyn.com wrote: > From: Serge Hallyn > > When using vnc gaphics over a unix socket, virt-aa-helper needs to provide > access for the qemu domain to access the sockfile. > > Changelog: > v2: add testcase to virt-aa-helper-tests to make sure xml w

[libvirt] [PATCH 2/2] add vnc unix sockets to apparmor policy (v2)

2012-12-11 Thread serge
From: Serge Hallyn When using vnc gaphics over a unix socket, virt-aa-helper needs to provide access for the qemu domain to access the sockfile. Changelog: v2: add testcase to virt-aa-helper-tests to make sure xml with vnc socket works. Signed-off-by: Serge Hallyn --- src/security/virt-

[libvirt] [PATCH 1/2] add security hook for permitting hugetlbfs access (v2)

2012-12-11 Thread serge
From: Serge Hallyn When a qemu domain is backed by huge pages, apparmor needs to grant the domain rw access to files under the hugetlbfs mount point. Add a hook, called in qemu_process.c, which ends up adding the read-write access through virt-aa-helper. Qemu will be creating a randomly named f

Re: [libvirt] [PATCH v2 2/4] conf: add optional attribte primary to video element

2012-12-11 Thread Laine Stump
On 12/11/2012 01:11 PM, Eric Blake wrote: > On 12/11/2012 07:14 AM, Guannan Ren wrote: >> If there are multiple video devices >> primary = 'yes' marks this video device as the primary one. >> The rest are secondary video devices. No more than one could be >> mark as primary. If none of them has pri

Re: [libvirt] [PATCH 1/N] qemu driver FreeBSD support: fix compilation

2012-12-11 Thread Jiri Denemark
On Tue, Dec 11, 2012 at 23:08:07 +0400, Roman Bogorodskiy wrote: > Another round of the FreeBSD patches. Here's the first chunk to fix > compilation. > > Roman Bogorodskiy ... > diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c > index ab04599..5d355eb 100644 > --- a/src/qemu/qemu_pro

Re: [libvirt] [PATCH 1/N] qemu driver FreeBSD support: fix compilation

2012-12-11 Thread Daniel P. Berrange
On Tue, Dec 11, 2012 at 01:33:33PM -0600, Doug Goldstein wrote: > On Tue, Dec 11, 2012 at 1:08 PM, Roman Bogorodskiy > diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c > index ab04599..5d355eb 100644 > --- a/src/qemu/qemu_process.c > +++ b/src/qemu/qemu_process.c > @@ -27,7 +27,12 @@

Re: [libvirt] [PATCH] docs: Document offline migration

2012-12-11 Thread Jiri Denemark
On Tue, Dec 11, 2012 at 11:15:37 -0700, Eric Blake wrote: > On 12/11/2012 07:30 AM, Jiri Denemark wrote: > > --- > > docs/migration.html.in | 14 ++ > > 1 file changed, 14 insertions(+) > > > > ACK with those grammar fixes. Fixed and pushed, thanks. Jirka -- libvir-list mailing li

Re: [libvirt] [PATCH 1/N] qemu driver FreeBSD support: fix compilation

2012-12-11 Thread Roman Bogorodskiy
Doug Goldstein wrote: > On Tue, Dec 11, 2012 at 1:08 PM, Roman Bogorodskiy > wrote: > > Another round of the FreeBSD patches. Here's the first chunk to fix > > compilation. > > > > Roman Bogorodskiy > > > > Not to nitpick, but if possible in the future send the patches inline > to the mailing

Re: [libvirt] [PATCH 1/N] qemu driver FreeBSD support: fix compilation

2012-12-11 Thread Doug Goldstein
On Tue, Dec 11, 2012 at 1:08 PM, Roman Bogorodskiy wrote: > Another round of the FreeBSD patches. Here's the first chunk to fix > compilation. > > Roman Bogorodskiy > Not to nitpick, but if possible in the future send the patches inline to the mailing list. You can accomplish this by doing the fo

[libvirt] [PATCH 1/N] qemu driver FreeBSD support: fix compilation

2012-12-11 Thread Roman Bogorodskiy
Another round of the FreeBSD patches. Here's the first chunk to fix compilation. Roman Bogorodskiy commit 4205ba22dcef12ac41cf11cf8fe2a84f42612154 Author: Roman Bogorodskiy Date: Tue Dec 11 22:31:39 2012 +0400 Qemu FreeBSD: fix compilation * Autotools changes: - Don't assum

Re: [libvirt] [PATCH 4/5] qemu: reuse qemuMigrationIsAllowed when doing save and managedsave

2012-12-11 Thread Peter Krempa
On 12/11/12 17:18, Eric Blake wrote: On 12/07/2012 04:30 AM, Peter Krempa wrote: Save and managedsave use both migration to file. This patch reuses s/use both/both use/ qemuMigrationIsAllowed to check if the migration could happen before trying. --- src/qemu/qemu_driver.c | 6 ++ 1 fi

Re: [libvirt] [PATCH 3/5] qemu: snapshot: Report better error message if migration isn't allowed

2012-12-11 Thread Peter Krempa
On 12/11/12 17:17, Eric Blake wrote: On 12/07/2012 04:30 AM, Peter Krempa wrote: Qemu doesn't support migration on guests with host devices. This patch adds a check to ensure migration is safe before actualy doing so. s/actualy/actually/ --- src/qemu/qemu_driver.c | 4 1 file changed

Re: [libvirt] [PATCH 2/5] qemu: Make qemuMigrationIsAllowed more reusable

2012-12-11 Thread Peter Krempa
On 12/11/12 17:17, Eric Blake wrote: On 12/07/2012 04:30 AM, Peter Krempa wrote: This patch exports qemuMigrationIsAllowed and adds a new parameter to it to denote if it's a remote migration or a local migration. Local migrations are used in snapshots and saving of the machine state and have few

[libvirt] [PATCH 4/4] qemu: Improve error reporting from qemuDomainManagedSaveRemove

2012-12-11 Thread Peter Krempa
Report an error if unlink of the managedsave file fails. --- Hm, this patch changes semantics a little bit. If the unlink() fails now, the domain isn't marked as not having a managed save file. If somebody does not like this change I will return it to the previous semantics. --- src/qemu/qemu_driv

[libvirt] [PATCH 3/4] qemu: Small code cleanups in the managedsave functions

2012-12-11 Thread Peter Krempa
Save a few lines moving assignments into conditions and fix braces position. --- src/qemu/qemu_driver.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 72da014..b1cb185 100644 --- a/src/qemu/qemu_driver.c +++ b/src/

[libvirt] [PATCH 0/4] qemu: Refactor ManagedSave code and fix error reporting

2012-12-11 Thread Peter Krempa
This series improves helpers to retrieve domain objects from virDomainPtrs and uses the improvements in the ManagedSave APIs. This series also fixes a bug in error reporting of qemuDomainManagedSaveRemove where if unlink() failed no error was reported but an error code was returned. Although ther

[libvirt] [PATCH 1/4] qemu: Add a new domain lookup helper and improve the docs

2012-12-11 Thread Peter Krempa
This patch adds a new domain lookup helper qemuDomObjFromDomainDriver that lookups the domain and leaves the driver locked. The driver is returned as the second argument of that function. If the lookup fails the driver is unlocked to help avoid cleanup codepaths. This patch also improves docs for

[libvirt] [PATCH 2/4] qemu: Refactor managed save functions to use domain lookup helpers

2012-12-11 Thread Peter Krempa
--- src/qemu/qemu_driver.c | 54 +++--- 1 file changed, 12 insertions(+), 42 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 1f43386..72da014 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -3246,8 +32

Re: [libvirt] [PATCH v2 3/4] qemu: use newer -device video device in qemu commandline

2012-12-11 Thread Eric Blake
On 12/11/2012 07:14 AM, Guannan Ren wrote: > '-device VGA' maps to '-vga std' > '-device cirrus-vga' maps to '-vga cirrus' > '-device qxl-vga' maps to '-vga qxl' > (there is also '-device qxl' for secondary devices) > '-device vmware-svga' maps to '-vga vmware' > > For qemu(>=1.2), we

Re: [libvirt] [PATCH] docs: Document offline migration

2012-12-11 Thread Eric Blake
On 12/11/2012 07:30 AM, Jiri Denemark wrote: > --- > docs/migration.html.in | 14 ++ > 1 file changed, 14 insertions(+) > > diff --git a/docs/migration.html.in b/docs/migration.html.in > index c6b62f7..f311655 100644 > --- a/docs/migration.html.in > +++ b/docs/migration.html.in > @@ -

Re: [libvirt] [PATCH v2 2/4] conf: add optional attribte primary to video element

2012-12-11 Thread Eric Blake
On 12/11/2012 07:14 AM, Guannan Ren wrote: > If there are multiple video devices > primary = 'yes' marks this video device as the primary one. > The rest are secondary video devices. No more than one could be > mark as primary. If none of them has primary attribute, the first > one will be the prim

Re: [libvirt] [PATCH v2 4/4] doc: add attribute primary doc to video model element

2012-12-11 Thread Eric Blake
On 12/11/2012 07:14 AM, Guannan Ren wrote: > --- > docs/formatdomain.html.in | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) Squash this into 2/4. But still missing the RNG schema update, and preferably also an addition to tests/ that proves we can parse the new XML correctly. > >

Re: [libvirt] [PATCH v2 1/4] qemu: add qemu various VGA devices Caps flag

2012-12-11 Thread Eric Blake
On 12/11/2012 07:14 AM, Guannan Ren wrote: > QEMU_CAPS_DEVICE_QXL -device qxl > QEMU_CAPS_DEVICE_VGA -device VGA > QEMU_CAPS_DEVICE_CIRRUS_VGA -device cirrus-vga > QEMU_CAPS_DEVICE_VMWARE_SVGA -device vmware-svga > > Fix a typo in qemuCapsObjectTypes, the string 'qxl' here > s

Re: [libvirt] virDomainSetMetadata --> qemuDomainSetMetadata

2012-12-11 Thread SHAH, Ronak (Ronak R)
Hi Eric, Daniel, Thanks for the response. Sure let me try that. Its defeats the purpose of virDomainSetMetadata if you cant set :) Individual API is written just to support that (obviously along with setting and ). API takes domain pointer as its first argument which is the return value of vir

Re: [libvirt] [PATCH] qemu: assume seccomp sandbox is supported since qemu 1.2

2012-12-11 Thread Michal Privoznik
On 10.12.2012 16:28, Ján Tomko wrote: > Currently there is no way to detect it via QMP and requesting "-sandbox > off" works correctly even if it was compiled out, so this will work > unless someone both requests the sandbox in qemu.conf and builds QEMU > without the support for it. > --- > Relevan

Re: [libvirt] [PATCH v3 8/8] domain: Keep assigned class_id in domstatus XML

2012-12-11 Thread Michal Privoznik
On 11.12.2012 17:38, Laine Stump wrote: > On 12/11/2012 11:09 AM, Michal Privoznik wrote: >> Interfaces keeps a class_id, which is an ID from which bridge >> part of QoS settings is derived. We need to store class_id >> in domain status file, so we can later pass it to >> virNetDevBandwidthUnplug.

Re: [libvirt] [PATCH 1/6] Introduce a set of APIs for managing architectures

2012-12-11 Thread Eric Blake
On 12/11/2012 07:53 AM, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > Introduce a 'virArch' enum for CPU architectures. Include > data type providing wordsize and endianness, and APIs to > query this info and convert to/from enum and string form. > > Signed-off-by: Daniel P. Berrang

Re: [libvirt] [PATCH v3 3/8] bandwidth: Create hierarchical shaping classes

2012-12-11 Thread Laine Stump
On 12/11/2012 11:09 AM, Michal Privoznik wrote: > These classes can borrow unused bandwidth. Basically, > only egress qdsics can have classes, therefore we can s/qdsic/qdisc/ > do this kind of traffic shaping only on host's outgoing, > that is domain's incoming traffic. > --- > src/lxc/lxc_proce

Re: [libvirt] [PATCH v3 6/8] bandwidth: Create network bandwidth (un)plug functions

2012-12-11 Thread Laine Stump
On 12/11/2012 11:09 AM, Michal Privoznik wrote: > Network should be notified if we plug in or unplug an > interface, so it can perform some action, e.g. set/unset > network part of QoS. However, we are doing this in very > early stage, so iface->ifname isn't filled in yet. So > whenever we want to

Re: [libvirt] [PATCH v3 4/8] bandwidth: Create (un)plug functions

2012-12-11 Thread Laine Stump
On 12/11/2012 11:09 AM, Michal Privoznik wrote: > These set bridge part of QoS when bringing domain's interface up. > Long story short, if there's a 'floor' set, a new QoS class is created. > ClassID MUST be unique within the bridge and should be kept for > unplug phase. > --- > po/POTFILES.in

Re: [libvirt] [PATCH v3 5/8] bandwidth: Create rate update function

2012-12-11 Thread Laine Stump
On 12/11/2012 11:09 AM, Michal Privoznik wrote: > This will be used whenever a NIC with guaranteed throughput is to > be plugged into a bridge. It will adjust the average throughput of > non guaranteed NICs (classid 1:2) to meet new requirements. > --- > src/util/virnetdevbandwidth.c | 49 > +++

Re: [libvirt] [PATCH v0] qemu driver FreeBSD support

2012-12-11 Thread Roman Bogorodskiy
Daniel P. Berrange wrote: > On Sun, Dec 09, 2012 at 09:17:01PM +0400, Roman Bogorodskiy wrote: > > Hello, > > > > Attached an initial version of the patch providing FreeBSD support for > > qemu driver. Initial discussion on the topic started here: > > > > https://www.redhat.com/archives/libvir

Re: [libvirt] [PATCH v3 7/8] network: Create real network status files

2012-12-11 Thread Laine Stump
On 12/11/2012 11:09 AM, Michal Privoznik wrote: > Currently, we are only keeping a inactive XML configuration > in status dir. This is no longer enough as we need to keep > this class_id attribute so we don't overwrite old entries > when the daemon restarts. However, since there has already > been

Re: [libvirt] [PATCH v3 8/8] domain: Keep assigned class_id in domstatus XML

2012-12-11 Thread Laine Stump
On 12/11/2012 11:09 AM, Michal Privoznik wrote: > Interfaces keeps a class_id, which is an ID from which bridge > part of QoS settings is derived. We need to store class_id > in domain status file, so we can later pass it to > virNetDevBandwidthUnplug. > --- > src/conf/domain_conf.c | 13 +++

Re: [libvirt] [PATCH v3 1/8] bandwidth: Attach sfq to leaf node

2012-12-11 Thread Laine Stump
On 12/11/2012 11:09 AM, Michal Privoznik wrote: > SFQ is qdisc which doesn't really shape any traffic but > 'just' re-arrange packets in sending buffer so no stream > starve. The goal is to ensure fairness. There is basically > only one configuration parameter (perturb) which is set to > advised v

Re: [libvirt] [PATCH v3 2/8] bandwidth: add new 'floor' attribute

2012-12-11 Thread Laine Stump
On 12/11/2012 11:09 AM, Michal Privoznik wrote: > This is however supported only on domain interfaces with > type='network'. Moreover, target network needs to have at least > inbound QoS set. This is required by hierarchical traffic shaping. > > >From now on, the required attribute for is either '

Re: [libvirt] [PATCH 2/5] qemu: Make qemuMigrationIsAllowed more reusable

2012-12-11 Thread Eric Blake
On 12/07/2012 04:30 AM, Peter Krempa wrote: > This patch exports qemuMigrationIsAllowed and adds a new parameter to it > to denote if it's a remote migration or a local migration. Local > migrations are used in snapshots and saving of the machine state and > have fewer restrictions. This patch also

Re: [libvirt] [PATCH 07/12] qemu: Error out when domain starting if the cdbfilter setting conflicts

2012-12-11 Thread Osier Yang
On 2012年12月11日 21:37, Osier Yang wrote: This prevents the domain starting if the shared disk's setting conflicts with other active domain(s), E.g. A domain with "cdbfilter" set as "yes", however, another active domain is using it set as "no". --- src/qemu/qemu_process.c | 44 +

Re: [libvirt] [PATCH 5/5] [OPTIONAL] qemu: allow save and managedsave on guests marked as autodestroyable

2012-12-11 Thread Eric Blake
On 12/07/2012 06:27 AM, Peter Krempa wrote: > On 12/07/12 14:19, Gao Yongwei wrote: >> >> >> 2012/12/7 Peter Krempa mailto:pkre...@redhat.com>> >> > > [...] > >> >> I think, if a vm is marked has autodestroyed,then this means that we do >> not need this vm again on next reboot.? if so,what's the

[libvirt] [PATCH v3 6/8] bandwidth: Create network bandwidth (un)plug functions

2012-12-11 Thread Michal Privoznik
Network should be notified if we plug in or unplug an interface, so it can perform some action, e.g. set/unset network part of QoS. However, we are doing this in very early stage, so iface->ifname isn't filled in yet. So whenever we want to report an error, we must use a different identifier, e.g.

[libvirt] [PATCH v3 5/8] bandwidth: Create rate update function

2012-12-11 Thread Michal Privoznik
This will be used whenever a NIC with guaranteed throughput is to be plugged into a bridge. It will adjust the average throughput of non guaranteed NICs (classid 1:2) to meet new requirements. --- src/util/virnetdevbandwidth.c | 49 + src/util/virnetdevban

Re: [libvirt] [PATCH 4/5] qemu: reuse qemuMigrationIsAllowed when doing save and managedsave

2012-12-11 Thread Eric Blake
On 12/07/2012 04:30 AM, Peter Krempa wrote: > Save and managedsave use both migration to file. This patch reuses s/use both/both use/ > qemuMigrationIsAllowed to check if the migration could happen before > trying. > --- > src/qemu/qemu_driver.c | 6 ++ > 1 file changed, 2 insertions(+), 4 d

Re: [libvirt] [PATCH 3/5] qemu: snapshot: Report better error message if migration isn't allowed

2012-12-11 Thread Eric Blake
On 12/07/2012 04:30 AM, Peter Krempa wrote: > Qemu doesn't support migration on guests with host devices. This patch > adds a check to ensure migration is safe before actualy doing so. s/actualy/actually/ > --- > src/qemu/qemu_driver.c | 4 > 1 file changed, 4 insertions(+) ACK. > > diff

Re: [libvirt] [PATCH 0/8] parallels: add networking support

2012-12-11 Thread Dmitry Guryanov
On 121211 22:55:59, Daniel Veillard wrote: > On Tue, Dec 11, 2012 at 02:59:41PM +0400, Dmitry Guryanov wrote: > > The goal of this patch series is to add initial support of > > networking to Parallels Cloud Server driver. > > > > Parallels driver will be able to show read-only list of virtual > >

[libvirt] [PATCH v3 4/8] bandwidth: Create (un)plug functions

2012-12-11 Thread Michal Privoznik
These set bridge part of QoS when bringing domain's interface up. Long story short, if there's a 'floor' set, a new QoS class is created. ClassID MUST be unique within the bridge and should be kept for unplug phase. --- po/POTFILES.in|1 + src/util/virnetdevbandwidth.c | 182 +

[libvirt] [PATCH v3 7/8] network: Create real network status files

2012-12-11 Thread Michal Privoznik
Currently, we are only keeping a inactive XML configuration in status dir. This is no longer enough as we need to keep this class_id attribute so we don't overwrite old entries when the daemon restarts. However, since there has already been release which has just as root element, and we want to ke

[libvirt] [PATCH v3 3/8] bandwidth: Create hierarchical shaping classes

2012-12-11 Thread Michal Privoznik
These classes can borrow unused bandwidth. Basically, only egress qdsics can have classes, therefore we can do this kind of traffic shaping only on host's outgoing, that is domain's incoming traffic. --- src/lxc/lxc_process.c |3 +- src/network/bridge_driver.c |3 +- src/qemu/qem

  1   2   >