On 02/01/2013 09:16 PM, Eric Blake wrote:
We had an easy way to iterate set bits, but not for iterating
cleared bits.
* src/util/virbitmap.h (virBitmapNextClearBit): New prototype.
* src/util/virbitmap.c (virBitmapNextClearBit): Implement it.
* src/libvirt_private.syms (bitmap.h): Export it.
* t
On 02/01/2013 07:13 PM, Osier Yang wrote:
> On 2013年02月02日 07:04, Eric Blake wrote:
>> Commit 6094ad7b (0.9.3 release) promoted several functions from
>> internal to public, but forgot to fix the documentation generator
>> to provide details about those functions.
>>
>> For an example of what this
We had an easy way to iterate set bits, but not for iterating
cleared bits.
* src/util/virbitmap.h (virBitmapNextClearBit): New prototype.
* src/util/virbitmap.c (virBitmapNextClearBit): Implement it.
* src/libvirt_private.syms (bitmap.h): Export it.
* tests/virbitmaptest.c (test4): Test it.
---
On 2013年02月02日 07:04, Eric Blake wrote:
Commit 6094ad7b (0.9.3 release) promoted several functions from
internal to public, but forgot to fix the documentation generator
to provide details about those functions.
For an example of what this fixes, look at:
file:///path/to/libvirt/docs/html/libvir
Add function to find the next available bit in the bitmap and set it.
Signed-off-by: Stefan Berger
---
src/libvirt_private.syms |1 +
src/util/virbitmap.c | 34 ++
src/util/virbitmap.h |3 +++
3 files changed, 38 insertions(+)
Index: libvirt/sr
Commit 6094ad7b (0.9.3 release) promoted several functions from
internal to public, but forgot to fix the documentation generator
to provide details about those functions.
For an example of what this fixes, look at:
file:///path/to/libvirt/docs/html/libvirt-libvirt.html#virEventAddHandle
before an
On 02/01/2013 02:57 PM, Stefan Berger wrote:
> Add function to find the next available bit in the bitmap and set it.
>
> Signed-off-by: Stefan Berger
>
> ---
> src/libvirt_private.syms |1 +
> src/util/virbitmap.c | 34 ++
> src/util/virbitmap.h |
Add a file descriptor set to the QEMU private domain structure.
Stefan Berger
---
src/qemu/qemu_domain.c |9 -
src/qemu/qemu_domain.h |3 +++
2 files changed, 11 insertions(+), 1 deletion(-)
Index: libvirt/src/qemu/qemu_domain.c
=
The following patch series adds initial support for QEMU file
descriptor sets implementing support for creating the proper
command line. Some devices are using the sets now.
Regards,
Stefan
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Add support for file descriptor sets by converting some of the
command line parameters to use /dev/fdset/%d if -add-fd is found
to be supported by QEMU. For those devices libvirt now open()s
the device to obtain the file descriptor and 'transfers' the
fd using virCommand.
For the following fragm
On 02/01/2013 12:55 PM, Serge Hallyn wrote:
> Quoting Eric Blake (ebl...@redhat.com):
>> On 01/30/2013 08:05 PM, Serge Hallyn wrote:
>>> Without these two string changes in generator.py, the
>>> virGetLastError wrapper does not get created in
>>> /usr/share/pyshared/libvirt.py. Noticed when runnin
On Fri, Feb 01, 2013 at 11:18:24 +, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange"
>
> The APIs names for accessing the domain list object are
> very inconsistent. Rename them all to have a standard
> virDomainObjList prefix.
> ---
> src/conf/domain_conf.c| 156 ++
On Fri, Feb 01, 2013 at 11:18:23 +, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange"
>
> Currently the virQEMUDriverPtr struct contains an wide variety
> of data with varying access needs. Move all the static config
> data into a dedicated virQEMUDriverConfigPtr object. The only
> locki
Quoting Eric Blake (ebl...@redhat.com):
> On 01/30/2013 08:05 PM, Serge Hallyn wrote:
> > Without these two string changes in generator.py, the
> > virGetLastError wrapper does not get created in
> > /usr/share/pyshared/libvirt.py. Noticed when running
> > tests with virt-install.
> >
> > Signed-
The only two network pools we supported are "rbd" and "sheepdog",
and attributes "socket", "transport" are not supported in storage
pool conf yet, this uses the default setting (TCP for 'transport',
and "socket" is not set) temporarily. Future patches will extend
the storage pool conf to support 't
Quoting Gene Czarcinski (g...@czarc.net):
> I seem to remember that, if you use net-define, the network will be
> persistent and, if you use net-create, the network will not be
> persistent.
>
> I am now running libvirt-1.0.2 on Fedora 18.
>
> When I use net-define a network from a template and t
2013/2/1 harryxiyou
> On Fri, Feb 1, 2013 at 6:14 PM, Gao Yongwei wrote:
> [...]
> >> We can get "Boot VMs from sheepdog volumes in Libvirt" way
> >> from https://github.com/collie/sheepdog/wiki/Libvirt like following.
> >>
> >> a, prepare a file containing an XML domain description
> >>
> >>
It iterates over all the domain disks, and translate the source of
all the disks of 'volume' type from storage pool/volume to the real
underlying source.
Disks of type 'file', 'block', and 'dir' are supported now. Network
type is not supported yet, it will be another patch.
src/storage/storage_dr
On 02/01/2013 05:48 AM, Claudio Bley wrote:
> The point is, we skip checking all functions contained in the
> "ignored_functions" dictionary in apibuild.py.
>
> We would have to do the same filtering inside the stylesheet also.
>
> But why bother? We never get to XSL processing when apibuild.py f
On Sat, Feb 2, 2013 at 12:49 AM, Eric Blake wrote:
> On 02/01/2013 04:08 AM, harryxiyou wrote:
>> Hi all,
>>
>> I wanna boot VMs from sheepdog volumes so i do according to
>> https://github.com/collie/sheepdog/wiki/Libvirt
>> However, some errors happened to me like following.
>>
>> $ ./virsh crea
On Fri, Feb 01, 2013 at 10:06:28AM -0700, Eric Blake wrote:
> On 02/01/2013 05:53 AM, Jiri Denemark wrote:
> > When a changelog entry references an RPM macro, % needs to be escaped so
> > that it does not appear expanded in package changelog.
> >
> > Fri Mar 4 2009 is incorrect since Mar 4 was We
On 02/01/2013 05:53 AM, Jiri Denemark wrote:
> When a changelog entry references an RPM macro, % needs to be escaped so
> that it does not appear expanded in package changelog.
>
> Fri Mar 4 2009 is incorrect since Mar 4 was Wednesday. Since
> libvirt-0.6.1 was released on Mar 4 2009, we should c
On 02/01/2013 04:08 AM, harryxiyou wrote:
> Hi all,
>
> I wanna boot VMs from sheepdog volumes so i do according to
> https://github.com/collie/sheepdog/wiki/Libvirt
> However, some errors happened to me like following.
>
> $ ./virsh create os.xml
> error:create domain from os.xml failure
> error
On 02/01/2013 12:16 AM, Jiri Denemark wrote:
> On Thu, Jan 31, 2013 at 16:34:24 -0700, Eric Blake wrote:
>> CVE-2013-0242 in glibc's regex() can cause a DoS in any daemon
>> that runs a regex search on user input while in a multibyte locale.
>> I'm not sure how hard it would be to trigger such a se
On Fri, Feb 01, 2013 at 11:19:49AM -0500, Daniel J Walsh wrote:
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA1
>
>
> Simple patch to make sure /sys/kernel/security is mounted inside the
> container. Systemd attempts to use/mount this file system if it is not
> present.
>
>
> One of these d
On Fri, Jan 25, 2013 at 02:39:25PM -0500, Daniel J Walsh wrote:
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA1
>
> (2nd pass)
>
>
> lxc-enter-namespace allows a process from outside a container to start a
> process inside a container. One problem with the current code is the process
> runni
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Simple patch to make sure /sys/kernel/security is mounted inside the
container. Systemd attempts to use/mount this file system if it is not present.
One of these days I will figure out how to merge patches.
securityfs has to be mounted after /sys
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 01/25/2013 02:39 PM, Daniel J Walsh wrote:
> (2nd pass)
>
>
> lxc-enter-namespace allows a process from outside a container to start a
> process inside a container. One problem with the current code is the
> process running within the container
= Info =
Someone reports errors withing "PHP_FUNCTION(libvirt_domain_migrate)" due to
"set_error":
libvirt-php.c: In function ‘zif_libvirt_domain_migrate’:
libvirt-php.c:5456:3: error: too few arguments to function ‘set_error’
= Background =
Michal Novotny already reacted to Gentoos bug:
Bug 4376
---
src/libvirt-php.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/src/libvirt-php.c b/src/libvirt-php.c
index 7e7710c..0b8345a 100644
--- a/src/libvirt-php.c
+++ b/src/libvirt-php.c
@@ -1615,7 +1615,7 @@ PHP_FUNCTION(libvirt_node_get_cpu_stats)
#else
PHP_FUNC
At Fri, 01 Feb 2013 13:48:45 +0100,
Claudio Bley wrote:
>
> At Thu, 31 Jan 2013 13:41:10 -0700,
> Eric Blake wrote:
> >
> > On 01/30/2013 08:38 AM, Claudio Bley wrote:
> > > When function arguments or return values lack a description there's no
> > > use in generating a meaningless "ARG1: " stanz
On Fri, Feb 01, 2013 at 11:18:35 +, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange"
>
> ---
> src/qemu/qemu_domain.c | 11 +++
> src/qemu/qemu_driver.c | 3 +++
> 2 files changed, 6 insertions(+), 8 deletions(-)
>
> diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.
When a changelog entry references an RPM macro, % needs to be escaped so
that it does not appear expanded in package changelog.
Fri Mar 4 2009 is incorrect since Mar 4 was Wednesday. Since
libvirt-0.6.1 was released on Mar 4 2009, we should change Fri to Wed.
---
libvirt.spec.in | 4 ++--
1 file
On Fri, Feb 01, 2013 at 13:45:01 +0100, Jiri Denemark wrote:
> When a changelog entry references an RPM macro, % needs to be escaped so
> that it does not appear expanded in package changelog.
>
> Wed Jul 5 2011 is incorrect since Jul 5 was Tuesday. Let's suppose it
> was a result of incomplete up
At Thu, 31 Jan 2013 13:41:10 -0700,
Eric Blake wrote:
>
> On 01/30/2013 08:38 AM, Claudio Bley wrote:
> > When function arguments or return values lack a description there's no
> > use in generating a meaningless "ARG1: " stanza.
>
> Can you point to an example of an argument lacking a descriptio
When a changelog entry references an RPM macro, % needs to be escaped so
that it does not appear expanded in package changelog.
Wed Jul 5 2011 is incorrect since Jul 5 was Tuesday. Let's suppose it
was a result of incomplete update (Tue -> Wed) and change Jul 5 to Jul 6.
---
libvirt.spec.in | 4 +
libvirt.c calls curl_global_init() if WITH_CURL is defined and thus it
should be linked with libcurl. This fixes link failure in case neither
xenapi nor esx driver is enabled (they are the only users of libcurl).
---
src/Makefile.am | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff
At Thu, 31 Jan 2013 09:20:28 -0700,
Eric Blake wrote:
>
> On 01/31/2013 02:47 AM, Claudio Bley wrote:
>
> >
> > IMO, these files are "object files", as far as the GPL v3 is
> > concerned.
> >
> > ,[ GPL v3 1. Source Code ]
> > | The "source code" for a work means the preferred form of the w
On Fri, Feb 1, 2013 at 6:14 PM, Gao Yongwei wrote:
[...]
>> We can get "Boot VMs from sheepdog volumes in Libvirt" way
>> from https://github.com/collie/sheepdog/wiki/Libvirt like following.
>>
>> a, prepare a file containing an XML domain description
>>
>> $ cat > sheepdog.xml
>>
>>
From: "Daniel P. Berrange"
Annotate the fields in virQEMUDriverPtr to indicate the locking
rules for their use
Signed-off-by: Daniel P. Berrange
---
src/qemu/qemu_conf.h | 22 ++
1 file changed, 22 insertions(+)
diff --git a/src/qemu/qemu_conf.h b/src/qemu/qemu_conf.h
inde
From: "Daniel P. Berrange"
Currently the activePciHostdevs, inactivePciHostdevsd and
activeUsbHostdevs lists are all implicitly protected by the
QEMU driver lock. Now that the lists all inherit from the
virObjectLockable, we can make the locking explicit, removing
the dependency on the QEMU drive
From: "Daniel P. Berrange"
Use atomic ops to increment nextvmid and encapsulate it in a
methd to prevent accidental non-atomic access
---
src/qemu/qemu_conf.c| 6 ++
src/qemu/qemu_conf.h| 2 ++
src/qemu/qemu_process.c | 4 ++--
3 files changed, 10 insertions(+), 2 deletions(-)
diff
From: "Daniel P. Berrange"
Switch virDomainObjList to inherit from virObjectLockable and
make all the APIs acquire/release the mutex when running. This
makes virDomainObjList completely self-locking and no longer
reliant on the hypervisor driver locks
---
src/conf/domain_conf.c | 75
From: "Daniel P. Berrange"
---
src/qemu/qemu_domain.c | 11 +++
src/qemu/qemu_driver.c | 3 +++
2 files changed, 6 insertions(+), 8 deletions(-)
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index cb031d8..5bf0ab0 100644
--- a/src/qemu/qemu_domain.c
+++ b/src/qemu/qemu_d
From: "Daniel P. Berrange"
To allow modifications to the lists to be synchronized, convert
virPCIDeviceList and virUSBDeviceList into virObjectLockable
classes. The locking, however, will not be self-contained. The
users of these classes will have to call virObjectLock/Unlock
in the critical regi
From: "Daniel P. Berrange"
The duplicate VM checking should be done atomically with
virDomainObjListAdd, so shoud not be a separate function.
Instead just use flags to indicate what kind of checks are
required.
This pair, used in virDomainCreateXML:
if (virDomainObjListIsDuplicate(privconn->
From: "Daniel P. Berrange"
The QEMU driver struct has a 'qemuVersion' field that was previously
used to cache the version lookup from capabilities. With the recent
QEMU capabilities rewrite the caching happens at a lower level so
this field is pointless. Removing it avoids worries about locking
w
From: "Daniel P. Berrange"
As a step towards making virDomainObjList thread-safe turn it
into an opaque virObject, preventing any direct access to its
internals.
As part of this a new method virDomainObjListForEach is
introduced to replace all existing usage of virHashForEach
---
src/conf/domai
An update of
https://www.redhat.com/archives/libvir-list/2013-January/msg01407.html
This series does more general refactoring to help in the goal of killing
the big QEMU driver lock. There are 3 key changes in this series
- Isolating all QEMU configuration parameters in one struct.
- Making
Hi all,
I wanna boot VMs from sheepdog volumes so i do according to
https://github.com/collie/sheepdog/wiki/Libvirt
However, some errors happened to me like following.
$ ./virsh create os.xml
error:create domain from os.xml failure
error:(domain_definition):14: Premature end of data in tag domain
2013/2/1 harryxiyou
> Hi all,
>
> We can get "Boot VMs from sheepdog volumes in Libvirt" way
> from https://github.com/collie/sheepdog/wiki/Libvirt like following.
>
> a, prepare a file containing an XML domain description
>
> $ cat > sheepdog.xml
>
> testvm
> 1048576
>
On Thu, Jan 31, 2013 at 10:00:35PM +, Lempereur, Brett wrote:
> Hi,
>
> Is there a canonical paper I can cite for Libvirt in academic publications?
> The best I've found so far is
>
>
> Bolt, M., Birkenheuer, G., Niehörster, O., & Brinkmann, A. (2010).
> Non-Intrusive Virtualization Manageme
At Thu, 31 Jan 2013 14:55:55 -0700,
Eric Blake wrote:
>
> On 01/30/2013 08:38 AM, Claudio Bley wrote:
> > It's simpler to render and it prevents wrapping the line too early
> > because of the table spacing, border et cetera.
> >
> > Signed-off-by: Claudio Bley
> > ---
> > docs/libvirt.css |
At Thu, 31 Jan 2013 12:15:49 -0700,
Eric Blake wrote:
>
> On 01/30/2013 08:38 AM, Claudio Bley wrote:
> > When a function has no associated information to one of its
> > arguments or its return type we report it and stop with an error.
> >
> > Signed-off-by: Claudio Bley
> > ---
> > docs/apibui
At Thu, 31 Jan 2013 10:21:25 -0700,
Eric Blake wrote:
>
> [1 ]
> On 01/30/2013 08:38 AM, Claudio Bley wrote:
> >
> > Signed-off-by: Claudio Bley
> > ---
> > include/libvirt/libvirt.h.in |2 ++
> > 1 file changed, 2 insertions(+)
>
> Hmm, I wonder if we should at least log any situation wh
At Thu, 31 Jan 2013 05:52:18 -0700,
Eric Blake wrote:
>
> On 01/30/2013 08:38 AM, Claudio Bley wrote:
> >
> > Signed-off-by: Claudio Bley
> > ---
> > include/libvirt/libvirt.h.in |2 ++
> > 1 file changed, 2 insertions(+)
>
> ACK. I had to go hunting for where this callback was used, but
At Wed, 30 Jan 2013 21:57:01 -0700,
Eric Blake wrote:
>
> [1 ]
> On 01/30/2013 08:38 AM, Claudio Bley wrote:
> > In commit 3ac26e2645e6456389a918455213d7e3824f63f9 parameter "path" was
> > renamed to "disk" but this change was not reflected in the documentation.
>
> Oops - that puts the blame on
At Wed, 30 Jan 2013 21:55:37 -0700,
Eric Blake wrote:
>
> [1 ]
> On 01/30/2013 08:38 AM, Claudio Bley wrote:
> >
> > Signed-off-by: Claudio Bley
> > ---
> > include/libvirt/libvirt.h.in |9 +
> > 1 file changed, 9 insertions(+)
>
> ACK.
Pushed. Thanks.
Claudio
--
AV-Test GmbH,
58 matches
Mail list logo