Re: [libvirt] [PATCH 1/1] Set legacy USB option with default for ppc64.

2013-03-06 Thread Li Zhang
ping ? This is needed for ppc64 to support FC18. Any comment? Thanks in advance. :-) On 2013年03月04日 14:47, Li Zhang wrote: From: Li Zhang Currently, -device xxx still can't work well for ppc64 platform. It's better use legacy USB option with default for ppc64. This patch is to legacy USB o

Re: [libvirt] [PATCH] Add NUMA memory information to virsh capabilities output.

2013-03-06 Thread Dusty Mabe
On Wed, Mar 6, 2013 at 5:07 PM, Daniel P. Berrange wrote: > On Thu, Feb 14, 2013 at 12:52:38PM -0500, Dusty Mabe wrote: >> >> +if (numa_available() < 0) { >> +virReportError(VIR_ERR_INTERNAL_ERROR, >> + "%s", _("NUMA not supported on this host")); >> +goto

[libvirt] when define NAT network, assign what kind of forward dev is better

2013-03-06 Thread yue
hi all: in my case, my physical machine has one ethernet, i want to use both bridge and nat network. i create a bridge outbr0(addif eth0), when creating NAT network, there are 3 options for forward-dev 1. 2. 3. i do not know which one is the best? thanks -- libvir-list mailing list libvir-l

Re: [libvirt] Cannot download gnulib

2013-03-06 Thread harryxiyou
On Wed, Mar 6, 2013 at 11:35 PM, Guannan Ren wrote: [...] >I am not quite sure it was fixed by a patch. >It probably caused by gnulib git server problem(I guess) >I just tried just now, it worked well. Ok, thanks very much ;-) -- Thanks Harry Wei -- libvir-list mailing list libvir

Re: [libvirt] [PATCH] Fix starting qemu instances when apparmor driver is enabled

2013-03-06 Thread Jim Fehlig
Guannan Ren wrote: > On 03/02/2013 12:41 AM, Jim Fehlig wrote: >> Guannan Ren wrote: >> >>> Hi Jim >>> >>> In selinux, libvirt added a label for tapfd. >>> Do you think this patch makes sense for apparmor? >>> https://www.redhat.com/archives/libvir-list/2012-October/msg01461.ht

Re: [libvirt] [PATCH] Add NUMA memory information to virsh capabilities output.

2013-03-06 Thread Daniel P. Berrange
On Thu, Feb 14, 2013 at 12:52:38PM -0500, Dusty Mabe wrote: > --- > docs/schemas/capability.rng | 10 > src/conf/capabilities.c | 8 +++ > src/conf/capabilities.h | 2 + > src/nodeinfo.c| 64 +-

Re: [libvirt] [PATCH] Resolve valgrind error

2013-03-06 Thread John Ferlan
On 03/06/2013 09:21 AM, Guannan Ren wrote: > On 03/06/2013 09:49 PM, John Ferlan wrote: >> --- >> src/conf/domain_conf.c | 1 + >> 1 file changed, 1 insertion(+) > > ACK > > Guannan > > Pushed, thanks John -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/m

[libvirt] Add NUMA memory info to libvirt

2013-03-06 Thread Dusty Mabe
Hi guys, Could someone possibly look at my proposed patch (http://www.redhat.com/archives/libvir-list/2013-February/msg00776.html)? It is a small code change that gives us some important information about how much memory each NUMA node of a server has. It is strictly for informational purposes and

Re: [libvirt] [PATCH] rng: restrict passthrough names to known-good files

2013-03-06 Thread Laine Stump
On 03/05/2013 02:28 AM, Peter Krempa wrote: > On 03/04/13 23:49, Eric Blake wrote: >> There is some controversy[1] on the qemu list on whether qemu should >> have ever allowed arbitrary file name passthrough, or whether it >> should be restricted to JUST /dev/random and /dev/hwrng. It is >> always

Re: [libvirt] Minor fixes to ocaml bindings for storage pools/volumes

2013-03-06 Thread David Scott
On Wed, Mar 6, 2013 at 5:01 PM, Richard W.M. Jones wrote: > On Wed, Mar 06, 2013 at 04:18:02PM +, David Scott wrote: > > These patches fix a couple of minor issues I encountered while > > trying to manipulate storage pools and volumes from an OCaml > > program. > > > > If you're interested, th

Re: [libvirt] Minor fixes to ocaml bindings for storage pools/volumes

2013-03-06 Thread Richard W.M. Jones
On Wed, Mar 06, 2013 at 04:18:02PM +, David Scott wrote: > These patches fix a couple of minor issues I encountered while > trying to manipulate storage pools and volumes from an OCaml > program. > > If you're interested, the OCaml client code is a simple adapter > to allow an XCP host to use

[libvirt] Minor fixes to ocaml bindings for storage pools/volumes

2013-03-06 Thread David Scott
These patches fix a couple of minor issues I encountered while trying to manipulate storage pools and volumes from an OCaml program. If you're interested, the OCaml client code is a simple adapter to allow an XCP host to use libvirt (for storage only atm, more later). The client code (so far) is h

[libvirt] [PATCH 2/3] Volume.delete takes a flags parameter

2013-03-06 Thread David Scott
This corrects a mismatch between the generated C stubs and the .ml interface. Signed-off-by: David Scott --- libvirt/libvirt.ml |2 +- libvirt/libvirt.mli |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libvirt/libvirt.ml b/libvirt/libvirt.ml index 443b22b..1fbb8ca

[libvirt] [PATCH 1/3] Correct typos in the storage interface's phantom types

2013-03-06 Thread David Scott
A connection is either read/write (type rw = [`R|`W]) or read/only (type ro = [`R]). A function which requires the ability to write needs to take a parameter [> `W] rather than [`W] (which would correspond to a write-only connection). We can now use a read/write connection to call: Pool.set_auto

[libvirt] [PATCH 1/3] Add method for checking if a string is (probably) a log message

2013-03-06 Thread Daniel P. Berrange
From: "Daniel P. Berrange" When reading log output from QEMU/LXC we need to skip over any libvirt log messages. Currently the QEMU driver checks for a fixed string, but this is better done with a regex. Add a method virLogProbablyLogMessage to do a regex check Signed-off-by: Daniel P. Berrange

[libvirt] [PATCH 3/3] Functions returning "unit" correspond to C fns which use -1 for failure

2013-03-06 Thread David Scott
This affects the following functions: virStoragePoolBuild virStoragePoolDelete virStorageVolDelete Previously a call to virStorageVolDelete would succeed returning 0, which was interpreted as false, causing us to raise an exception with VIR_ERR_NONE. Signed-off-by: David Scott --- libvirt

Re: [libvirt] [PATCH] Include pid namespace inode in LXC audit messages

2013-03-06 Thread Eric Blake
On 03/06/2013 08:10 AM, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > To allow the efficient correlation of container audit messages > with host hosts, include the pid namespace inode in audit > messages. > > The resulting audit message will be > > type=VIRT_CONTROL msg=audit(13625

Re: [libvirt] [PATCH] Include pid namespace inode in LXC audit messages

2013-03-06 Thread Daniel P. Berrange
On Wed, Mar 06, 2013 at 09:19:08AM -0700, Eric Blake wrote: > On 03/06/2013 08:10 AM, Daniel P. Berrange wrote: > > From: "Daniel P. Berrange" > > > > To allow the efficient correlation of container audit messages > > with host hosts, include the pid namespace inode in audit > > messages. > > >

[libvirt] [PATCH 3/3] Convert QEMU driver to use virLogProbablyLogMessage

2013-03-06 Thread Daniel P. Berrange
From: "Daniel P. Berrange" The current QEMU code for skipping log messages only skips over 'debug' message, switch to virLogProbablyLogMessage to make sure it skips over all of them --- src/qemu/qemu_process.c | 12 ++-- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/src/

[libvirt] [PATCH 2/3] Improve LXC startup error reporting

2013-03-06 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Currently we rely on a VIR_ERROR message being logged by the virRaiseError function to report LXC startup errors. This gives the right message, but is rather ugly and can be truncated if lots of log messages are written. Change the LXC controller to explicitly print any

[libvirt] [PATCHv2 17/21] conf: Add argument to support use of the driver adjust callbacks

2013-03-06 Thread Peter Krempa
This patch adds a argument to the virDomainXMLConfNew constructor to pass the driver adjust callback pointers and fixes the fallout of this change. --- src/conf/domain_conf.c | 4 src/conf/domain_conf.h | 1 + src/esx/esx_driver.c | 2 +- src/lxc/lxc_conf.c

[libvirt] [PATCHv2 06/21] fix fallout in src/parallels

2013-03-06 Thread Peter Krempa
--- src/parallels/parallels_driver.c | 12 src/parallels/parallels_utils.h | 1 + 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/src/parallels/parallels_driver.c b/src/parallels/parallels_driver.c index 8f8fdac..88f41f7 100644 --- a/src/parallels/parallels_driver.c +

[libvirt] [PATCHv2 19/21] fix fallout of the change of the network device default

2013-03-06 Thread Peter Krempa
--- tests/qemuxml2argvdata/qemuxml2argv-net-bandwidth.xml | 1 + tests/qemuxml2argvdata/qemuxml2argv-net-client.args | 6 +- tests/qemuxml2argvdata/qemuxml2argv-net-eth-ifname.args | 6 +- tests/qemuxml2argvdata/qemuxml2argv-net-eth-ifname.xml

[libvirt] [PATCHv2 07/21] fix fallout in phyp driver

2013-03-06 Thread Peter Krempa
--- src/phyp/phyp_driver.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/phyp/phyp_driver.c b/src/phyp/phyp_driver.c index 8c67338..f5cae48 100644 --- a/src/phyp/phyp_driver.c +++ b/src/phyp/phyp_driver.c @@ -3633,8 +3633,8 @@ phypDomainCreateAndStart(virConnectPtr co

[libvirt] [PATCHv2 08/21] fix fallout in src/qemu/

2013-03-06 Thread Peter Krempa
--- src/qemu/qemu_command.c | 9 ++-- src/qemu/qemu_command.h | 3 ++ src/qemu/qemu_conf.c | 10 ++-- src/qemu/qemu_conf.h | 4 ++ src/qemu/qemu_domain.c| 58 +- src/qemu/qemu_domain.h| 6 +-- src/qemu/qemu_driver.c| 123 +

[libvirt] [PATCHv2 00/21] Driver XML conf adjustment callbacks [READ FIRST]

2013-03-06 Thread Peter Krempa
This series implements the driver XML parsing callbacks as Dan suggested. This series may appear to be monstrous but I chose to split some patches to separate ones although the code does not compile afterwards to ease review. The patches starting with the word "fix" will need to be squashed into

Re: [libvirt] [PATCH] qdev: DEVICE_DELETED event

2013-03-06 Thread Eric Blake
[adding libvirt] On 03/06/2013 07:52 AM, Paolo Bonzini wrote: > Il 06/03/2013 15:44, Eric Blake ha scritto: >> Question - if libvirt misses the event (for example, if libvirtd >> requests a remove, but then gets restarted, and the event arrives before >> libvirtd is back up), is there a way to pol

[libvirt] [PATCHv2 12/21] fix fallout in src/uml

2013-03-06 Thread Peter Krempa
--- src/uml/uml_conf.h | 1 + src/uml/uml_driver.c | 32 2 files changed, 21 insertions(+), 12 deletions(-) diff --git a/src/uml/uml_conf.h b/src/uml/uml_conf.h index ff71b45..488c1b7 100644 --- a/src/uml/uml_conf.h +++ b/src/uml/uml_conf.h @@ -63,6 +63,7 @@ st

[libvirt] [PATCHv2 18/21] qemu: Implement the device parse callback and use it for interfaces

2013-03-06 Thread Peter Krempa
This patch implements the callback that is used to fill the qemu default network card into the XML if none is specified. Libvirt assumes that the network card for qemu if none specified is the "rtl8139". Record this in the XML using the new callback to avoid user confusion. --- src/qemu/qemu_conf

[libvirt] [PATCHv2 15/21] conf: Add separate defaults addition and validation for XML parsing

2013-03-06 Thread Peter Krempa
This patch adds instrumentation that will ultimately allow to split out filling of defaults and input validation from the XML parser to separate functions. With this patch, after the XML is parsed, a callback to the driver is issued requesing to fill and validate driver specific details of the con

[libvirt] [PATCHv2 13/21] fix fallout in test driver

2013-03-06 Thread Peter Krempa
--- src/test/test_driver.c | 61 ++ 1 file changed, 42 insertions(+), 19 deletions(-) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 30ce8e7..f61cf90 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -82,6 +82,7

[libvirt] [PATCHv2 14/21] fix fallout in vbox driver

2013-03-06 Thread Peter Krempa
--- src/vbox/vbox_tmpl.c | 19 +++ 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/src/vbox/vbox_tmpl.c b/src/vbox/vbox_tmpl.c index cd88579..aa7466b 100644 --- a/src/vbox/vbox_tmpl.c +++ b/src/vbox/vbox_tmpl.c @@ -193,6 +193,7 @@ typedef struct { unsigned long

[libvirt] [PATCHv2 03/21] fix fallout in src/esx

2013-03-06 Thread Peter Krempa
--- src/esx/esx_driver.c | 14 ++ src/esx/esx_private.h | 2 ++ 2 files changed, 12 insertions(+), 4 deletions(-) diff --git a/src/esx/esx_driver.c b/src/esx/esx_driver.c index 046035d..fc8a3ae 100644 --- a/src/esx/esx_driver.c +++ b/src/esx/esx_driver.c @@ -71,6 +71,7 @@ esxFreePri

[libvirt] [PATCHv2 16/21] fix fallout from adding new parameter to internal APIs

2013-03-06 Thread Peter Krempa
--- src/conf/domain_conf.c | 4 +++- src/conf/domain_conf.h | 2 ++ src/lxc/lxc_driver.c | 6 -- src/openvz/openvz_driver.c | 4 ++-- src/phyp/phyp_driver.c | 4 ++-- src/qemu/qemu_driver.c | 11 +++ src/uml/uml_driver.c | 4 ++-- src/vbox/vbox_tmpl.c

[libvirt] [PATCHv2 10/21] fix fallout in src/xen

2013-03-06 Thread Peter Krempa
--- src/xen/xen_driver.c| 8 ++-- src/xen/xen_driver.h| 1 + src/xen/xend_internal.c | 8 src/xen/xm_internal.c | 2 +- 4 files changed, 12 insertions(+), 7 deletions(-) diff --git a/src/xen/xen_driver.c b/src/xen/xen_driver.c index d896893..fd20b73 100644 --- a/src/xen/xen

[libvirt] [PATCHv2 09/21] fix fallout in tests/

2013-03-06 Thread Peter Krempa
--- tests/domainsnapshotxml2xmltest.c | 5 + tests/lxcxml2xmltest.c| 7 ++- tests/qemuargv2xmltest.c | 8 ++-- tests/qemumonitorjsontest.c | 29 +++-- tests/qemumonitortestutils.c | 4 ++-- tests/qemumonitortestutils.h |

[libvirt] [PATCHv2 21/21] virCaps: get rid of "defaultInitPath" value in the virCaps struct

2013-03-06 Thread Peter Krempa
This gets rid of the parameter in favor of using the new callback infrastructure to do the same stuff. This patch implements the domain adjustment callback in the openVZ driver and moves the check from the parser to a new validation method in the callback infrastructure. --- src/conf/capabilities

[libvirt] [PATCHv2 20/21] conf: Move validation of domain title

2013-03-06 Thread Peter Krempa
Use the helper to avoid doing this in the parser. --- src/conf/domain_conf.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 0432483..d68e30a 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @

[libvirt] [PATCHv2 11/21] fix fallout in src/vmware

2013-03-06 Thread Peter Krempa
--- src/vmware/vmware_conf.c | 3 ++- src/vmware/vmware_conf.h | 1 + src/vmware/vmware_driver.c | 25 + 3 files changed, 20 insertions(+), 9 deletions(-) diff --git a/src/vmware/vmware_conf.c b/src/vmware/vmware_conf.c index a17b2e1..19be62a 100644 --- a/src/vmware/

[libvirt] [PATCHv2 01/21] virCaps: conf: start splitting out irrelevat data

2013-03-06 Thread Peter Krempa
The virCaps structure gathered a ton of irrelevant data over time that. The original reason is that it was propagated to the XML parser functions. This patch aims to create a new data structure virDomainXMLConf that will contain immutable data that are used by the XML parser. This will allow two t

[libvirt] [PATCHv2 04/21] fix fallout in src/lxc

2013-03-06 Thread Peter Krempa
--- src/Makefile.am | 2 ++ src/lxc/lxc_conf.c | 8 src/lxc/lxc_conf.h | 2 ++ src/lxc/lxc_controller.c | 7 ++- src/lxc/lxc_domain.c | 13 ++--- src/lxc/lxc_domain.h | 2 +- src/lxc/lxc_driver.c | 43 --

[libvirt] [PATCHv2 05/21] fix fallout in src/openvz

2013-03-06 Thread Peter Krempa
--- src/openvz/openvz_conf.c | 12 ++-- src/openvz/openvz_conf.h | 3 +++ src/openvz/openvz_driver.c | 16 ++-- 3 files changed, 23 insertions(+), 8 deletions(-) diff --git a/src/openvz/openvz_conf.c b/src/openvz/openvz_conf.c index fde32ce..63663ab 100644 --- a/src/openv

[libvirt] [PATCHv2 02/21] fix fallout in src/conf/

2013-03-06 Thread Peter Krempa
--- src/conf/domain_conf.c | 98 ++-- src/conf/domain_conf.h | 20 +++--- src/conf/snapshot_conf.c | 3 +- src/conf/snapshot_conf.h | 1 + src/libvirt_private.syms | 2 + 5 files changed, 81 insertions(+), 43 deletions(-) diff --git a/src/con

Re: [libvirt] Cannot download gnulib

2013-03-06 Thread Guannan Ren
On 03/06/2013 08:09 PM, harryxiyou wrote: On Tue, Mar 5, 2013 at 11:15 PM, Guannan Ren wrote: Hi Guannan, I met this problem yesterday too, but now, it is fixed. you can try again. We have to reset libvirt git tree to libvirt v1.0.1 so that our patches work well. Therefore, could y

Re: [libvirt] [PATCH v4 4/4] auto-create pci-bridge controller info

2013-03-06 Thread Daniel P. Berrange
On Wed, Mar 06, 2013 at 04:15:28PM +0100, Ján Tomko wrote: > On 03/05/13 11:36, Daniel P. Berrange wrote: > > On Mon, Mar 04, 2013 at 02:39:40PM -0500, Laine Stump wrote: > >> On 03/04/2013 11:51 AM, Ján Tomko wrote: > >>> It would be nice if we could add pci bridges even when there weren't any > >

Re: [libvirt] [PATCH v4 4/4] auto-create pci-bridge controller info

2013-03-06 Thread Ján Tomko
On 03/05/13 11:36, Daniel P. Berrange wrote: > On Mon, Mar 04, 2013 at 02:39:40PM -0500, Laine Stump wrote: >> On 03/04/2013 11:51 AM, Ján Tomko wrote: >>> It would be nice if we could add pci bridges even when there weren't any >>> specified in the XML, but there are too many PCI devices. I don't

[libvirt] [PATCH] Include pid namespace inode in LXC audit messages

2013-03-06 Thread Daniel P. Berrange
From: "Daniel P. Berrange" To allow the efficient correlation of container audit messages with host hosts, include the pid namespace inode in audit messages. The resulting audit message will be type=VIRT_CONTROL msg=audit(1362582468.378:50): pid=19284 uid=0 auid=0 ses=312 subj=unconfined_u:unc

Re: [libvirt] [PATCH] storage: Cleanup logical volume creation code

2013-03-06 Thread John Ferlan
On 03/06/2013 08:59 AM, Jiri Denemark wrote: > On Wed, Mar 06, 2013 at 08:46:15 -0500, John Ferlan wrote: >> On 03/06/2013 08:04 AM, Jiri Denemark wrote: > Oops, you're right. Looks like a bad day today :-) > > Is this an ACK or do you need yet another version for adding cmd = NULL? > > Jirka >

Re: [libvirt] [PATCH] Resolve valgrind error

2013-03-06 Thread Guannan Ren
On 03/06/2013 09:49 PM, John Ferlan wrote: Resolves the following valgrind error from qemuxml2argvtest: ==20393== 5 bytes in 1 blocks are definitely lost in loss record 2 of 60 ==20393==at 0x4A0883C: malloc (vg_replace_malloc.c:270) ==20393==by 0x38D690A167: __vasprintf_chk (in /usr/lib6

Re: [libvirt] [PATCH] storage: Cleanup logical volume creation code

2013-03-06 Thread Jiri Denemark
On Wed, Mar 06, 2013 at 14:59:51 +0100, Jiri Denemark wrote: > On Wed, Mar 06, 2013 at 08:46:15 -0500, John Ferlan wrote: > > On 03/06/2013 08:04 AM, Jiri Denemark wrote: > > > @@ -741,11 +741,12 @@ virStorageBackendLogicalCreateVol(virConnectPtr > > > conn, > > > virCommandAddArg(cmd, po

[libvirt] [PATCH v2 4/4] security_dac: Favour ACLs over chown()

2013-03-06 Thread Michal Privoznik
On filesystems supporting ACLs we don't need to do a chown but we can just set ACLs to gain access for qemu. However, since we are setting these on too low level, where we don't know if disk is just a read only or read write, we set read write access unconditionally. --- src/security/security_dac.

[libvirt] [PATCH v2 1/4] virFile: Add APIs for extended attributes handling

2013-03-06 Thread Michal Privoznik
Currently, only three wrappers are being implemented: virFileSetAttr for setting attributes virFileGetAttr for querying attributes (note we need to call it twice, first time to get length of attribute value, second to get actual value) virFileRemoveAttr for removing attributes --- configure.ac

[libvirt] [PATCH v2 3/4] virfile: Introduce internal API for managing ACL

2013-03-06 Thread Michal Privoznik
For now, only two APIs are implemented: virFileSetACL for setting requested permissions for a specific user, virFileRemoveACL to remove those permissions. Both these traverse the whole path from root directory and set or unset S_IXUSR flag on all directories met so user can really access the file.

[libvirt] [PATCH v2 0/4] Keep original file label

2013-03-06 Thread Michal Privoznik
This is a rework of v1 with which it doesn't have a single line in common :) This version uses XATTR heavily. The first two patches utilize extended attributes to store the original owner and the reference counter, while the next two are just a proof of concept. They suffer with a serious defect -

[libvirt] [PATCH v2 2/4] security_dac: Remember owner prior chown() and restore on relabel

2013-03-06 Thread Michal Privoznik
Currently, on domain startup a labeling of domain resources (e.g. disk images, sockets, ...) is done. However, we don't store the original owner anywhere. So when domain is shutting down, we cannot restore the original owner of files we have chown()-ed. This patch resolves this issue for DAC driver

Re: [libvirt] [PATCH] storage: Cleanup logical volume creation code

2013-03-06 Thread Jiri Denemark
On Wed, Mar 06, 2013 at 08:46:15 -0500, John Ferlan wrote: > On 03/06/2013 08:04 AM, Jiri Denemark wrote: > > @@ -741,11 +741,12 @@ virStorageBackendLogicalCreateVol(virConnectPtr conn, > > virCommandAddArg(cmd, pool->def->source.name); > > > > if (virCommandRun(cmd, NULL) < 0) > >

[libvirt] [PATCH] Resolve valgrind error

2013-03-06 Thread John Ferlan
Resolves the following valgrind error from qemuxml2argvtest: ==20393== 5 bytes in 1 blocks are definitely lost in loss record 2 of 60 ==20393==at 0x4A0883C: malloc (vg_replace_malloc.c:270) ==20393==by 0x38D690A167: __vasprintf_chk (in /usr/lib64/libc-2.16.so) ==20393==by 0x4CB0D97: vi

Re: [libvirt] [PATCH] storage: Cleanup logical volume creation code

2013-03-06 Thread John Ferlan
On 03/06/2013 08:04 AM, Jiri Denemark wrote: > This patch plugs two memory leaks, removes some useless and confusing > constructs and renames renames "cleanup" label as "error" since it is > only used for error path rather then being common for both success and > error paths. > --- > src/storage/s

Re: [libvirt] [PATCH RFC 2/5] conf: Introduce scsi hostdev

2013-03-06 Thread Han Cheng
Acutally, I've changed xml from Paolo's proposal. I deleted the as it is not easy to parse for virDomainDeviceInfoParseXML and there is nothing else. And I changed address type from scsi to drive as they are the same. On 03/06/2013 09:09 PM, Han Cheng wrote: > On 03/06/2013 02:24 PM, Osier Yang w

Re: [libvirt] [PATCH RFC 2/5] conf: Introduce scsi hostdev

2013-03-06 Thread Han Cheng
On 03/06/2013 02:24 PM, Osier Yang wrote: > On 2013年03月04日 14:01, Han Cheng wrote: >> Adding scsi hostdev, it should like: >> >> >> >> >> >> >> >> >> @@ -3893,4 +3921,9 @@ >> >> >> >> + >> + >> +scsi_host[0-9]{1,2}

Re: [libvirt] [PATCH RFC 1/5] conf: Introduce readonly to hostdev and change helper function

2013-03-06 Thread Han Cheng
Thanks for your comments~ Please correct me if I'm wrong. As I know, in is parsed by virDomainHostdevSubsys(Pci/Usb)DefParseXML. Everything else in is parsed by virDomainDeviceInfoParseXML. I add readonly follow this. And this XML is tested by hostdev-scsi-readonly(named by your advice). Othe

[libvirt] [PATCH] storage: Cleanup logical volume creation code

2013-03-06 Thread Jiri Denemark
This patch plugs two memory leaks, removes some useless and confusing constructs and renames renames "cleanup" label as "error" since it is only used for error path rather then being common for both success and error paths. --- src/storage/storage_backend_logical.c | 23 --- 1

Re: [libvirt] [PATCH] storage: Fix memory leak in error path

2013-03-06 Thread Jiri Denemark
On Wed, Mar 06, 2013 at 07:35:15 -0500, John Ferlan wrote: > On 03/06/2013 06:59 AM, Jiri Denemark wrote: > > This also renames cleanup label as error since it is only used for error > > path rather then being common for both success and error paths. > > --- > > src/storage/storage_backend_logical

[libvirt] [PATCH 2/8] Remove hack using existance of an 'identity' string to disable auth

2013-03-06 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Currently the server determines whether authentication of clients is complete, by checking whether an identity is set. This patch removes that lame hack and replaces it with an explicit method for changing the client auth code * daemon/remote.c: Update for new APis * s

[libvirt] [PATCH 1/8] Add API for thread cancellation

2013-03-06 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Add a virThreadCancel function. This functional is inherantly dangerous and not something we want to use in general, but integration with SELinux requires that we provide this stub. We leave out any Win32 impl to discourage further use and because obviously SELinux isn'

[libvirt] [PATCH 7/8] Add ability to get a virIdentity from a virNetServerClientPtr

2013-03-06 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Add APIs which allow creation of a virIdentity from the info associated with a virNetServerClientPtr instance. This is done based on the results of client authentication processes like TLS, x509, SASL, SO_PEERCRED Signed-off-by: Daniel P. Berrange --- src/libvirt_pri

[libvirt] [PATCH 3/8] Add APIs to get at more client security data

2013-03-06 Thread Daniel P. Berrange
From: "Daniel P. Berrange" A socket object has various pieces of security data associated with it, such as the SELinux context, the SASL username and the x509 distinguished name. Add new APIs to virNetServerClient and related modules to access this data. Signed-off-by: Daniel P. Berrange --- s

[libvirt] [PATCH 6/8] Add API to get the system identity

2013-03-06 Thread Daniel P. Berrange
From: "Daniel P. Berrange" If no user identity is available, some operations may wish to use the system identity. ie the identity of the current process itself. Add an API to get such an identity. Signed-off-by: Daniel P. Berrange --- src/util/viridentity.c | 71 +++

[libvirt] [PATCH 4/8] Define internal APIs for managing identities

2013-03-06 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Introduce a local object virIdentity for managing security attributes used to form a client application's identity. Instances of this object are intended to be used as if they were immutable, once created & populated with attributes Signed-off-by: Daniel P. Berrange -

[libvirt] [PATCH 0/8] Identity management APIs for RBAC

2013-03-06 Thread Daniel P. Berrange
The patches in this series provide the identity management framework which is a pre-requisite for later role based access control patches. -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH 8/8] Set the current client identity during API call dispatch

2013-03-06 Thread Daniel P. Berrange
From: "Daniel P. Berrange" When dispatching an RPC API call, setup the current identity to hold the identity of the network client associated with the RPC message being dispatched. The setting is thread-local, so only affects the API call in this thread Signed-off-by: Daniel P. Berrange --- sr

[libvirt] [PATCH 5/8] Add APIs for associating a virIdentityPtr with the current thread

2013-03-06 Thread Daniel P. Berrange
From: "Daniel P. Berrange" To allow any internal API to get the current identity, add APIs to associate a virIdentityPtr with the current thread, via a thread local Signed-off-by: Daniel P. Berrange --- src/util/viridentity.c | 59 ++ src/util/vi

Re: [libvirt] [PATCHv4 2/5] S390: domain_conf support for CCW

2013-03-06 Thread Viktor Mihajlovski
On 03/06/2013 12:57 PM, Han Cheng wrote: + +if (cssid&& ssid&& devno) { . +} else if (cssid || ssid || devno) { This if is duplicate. thanks for taking a look, but this is actually as intended, namely to ensure full specification of the bus address or none at all in which cas

Re: [libvirt] [PATCH] storage: Fix memory leak in error path

2013-03-06 Thread John Ferlan
On 03/06/2013 07:35 AM, John Ferlan wrote: > On 03/06/2013 06:59 AM, Jiri Denemark wrote: >> +virFreeError(err); > > Not that it matters here, but I did find at least one path where a > virSaveLastError() didn't call virFreeError() (e.g in > storage_backend_logical.c). > Oy - wrong window -

Re: [libvirt] [PATCH] storage: Fix memory leak in error path

2013-03-06 Thread Peter Krempa
On 03/06/13 12:59, Jiri Denemark wrote: This also renames cleanup label as error since it is only used for error path rather then being common for both success and error paths. --- src/storage/storage_backend_logical.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) AC

Re: [libvirt] [PATCH] storage: Fix memory leak in error path

2013-03-06 Thread John Ferlan
On 03/06/2013 06:59 AM, Jiri Denemark wrote: > This also renames cleanup label as error since it is only used for error > path rather then being common for both success and error paths. > --- > src/storage/storage_backend_logical.c | 15 --- > 1 file changed, 8 insertions(+), 7 deletio

Re: [libvirt] Cannot download gnulib

2013-03-06 Thread harryxiyou
On Tue, Mar 5, 2013 at 11:15 PM, Guannan Ren wrote: Hi Guannan, > > I met this problem yesterday too, but now, it is fixed. > you can try again. > We have to reset libvirt git tree to libvirt v1.0.1 so that our patches work well. Therefore, could you please tell us the patches location,

[libvirt] [PATCH] storage: Fix memory leak in error path

2013-03-06 Thread Jiri Denemark
This also renames cleanup label as error since it is only used for error path rather then being common for both success and error paths. --- src/storage/storage_backend_logical.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/src/storage/storage_backend_logical

Re: [libvirt] [PATCHv4 2/5] S390: domain_conf support for CCW

2013-03-06 Thread Han Cheng
On 03/05/2013 11:44 PM, Viktor Mihajlovski wrote: Add necessary handling code for the new s390 CCW address type to virDomainDeviceInfo. Further, introduce memory management, XML parsing, output formatting and range validation for the new virDomainDeviceCCWAddress type. Signed-off-by: Viktor M

Re: [libvirt] virsh qemu+tls login error

2013-03-06 Thread yue
how to deal with it ? At 2013-03-06 17:37:50,"Daniel P. Berrange" wrote: >On Wed, Mar 06, 2013 at 03:13:34PM +0800, yue wrote: >> hi all >> on client side , (cacert.pem,clientcert.pem,clientkey.pem) certificate are >> in position. spicec can connect server(kvm host) successfully. >> 'vir

Re: [libvirt] virsh qemu+tls login error

2013-03-06 Thread Daniel P. Berrange
On Wed, Mar 06, 2013 at 03:13:34PM +0800, yue wrote: > hi all > on client side , (cacert.pem,clientcert.pem,clientkey.pem) certificate are > in position. spicec can connect server(kvm host) successfully. > 'virsh -c qemu+tcp ' can work well. > but virsh command line error when launch virsh -c qe