Re: [libvirt] [PATCH] Use camelCase for XML attribute numQueues

2013-04-22 Thread Daniel Veillard
On Mon, Apr 22, 2013 at 10:43:35AM -0400, Laine Stump wrote: > On 04/22/2013 10:13 AM, Laine Stump wrote: > > Of course in this case, we *could* avoid the camelCase vs underscore > > entirely by just naming the attribute "queues" instead of numQueues or > > num_queues (the fact that the attribute i

[libvirt] internal error Cannot find suitable CPU model for given data

2013-04-22 Thread yue
hi,all: if xml configuration is not right? Nehalem thanks-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] Omitting braces with a single-line body

2013-04-22 Thread harryxiyou
On Mon, Apr 22, 2013 at 10:33 PM, Eric Blake wrote: [...] > It's capital 'I', not lower case 'l'. That's shorthand using sed syntax > for an in-place replacement you should perform on your text. It means > you should have written: > After I read libvirt/HACKING file, I find we should > for that

[libvirt] Bug Reports

2013-04-22 Thread Dennis Zou (yunzou)
1.Lost soapAction in http request header When I tried to retrieve the property of storage.perDatastoreUsage under specify virtual machine and got a invalidProperty error but other properties(e.g. summary.storage, guest) under the same virtual machine are ok. Then I write a same program u

Re: [libvirt] [PATCH v3 4/5] qemu: auto-add pci-root controller for pc machine types

2013-04-22 Thread Eric Blake
On 04/22/2013 02:37 PM, Laine Stump wrote: > On 04/22/2013 02:43 PM, Ján Tomko wrote: >> >> is auto-added to pc* machine types. >> Without this controller PCI bus 0 is not available and >> no PCI addresses are assigned by default. >> >> Since older libvirt supported PCI bus 0 even without >> this

Re: [libvirt] [PATCH v3 5/5] qemu: auto-add bridges and allow using them

2013-04-22 Thread Eric Blake
On 04/22/2013 12:43 PM, Ján Tomko wrote: > Add a "dry run" address allocation to figure out how many bridges > will be needed for all the devices without explicit addresses. > > Auto-add just enough bridges to put all the devices on, or up to the > bridge with the largest specified index. > --- I

Re: [libvirt] [PATCHv2] Configure native vlan modes on Open vSwitch ports

2013-04-22 Thread Laine Stump
(I'm not sure what you did differently when you sent this mail, but somehow your mailer botched the "In-Reply-To:" header, which broke the threaded display in Thunderbird. No big deal, but I thought you might want to know.) On 04/22/2013 12:51 PM, james robson wrote: >> Date: Thu, 18 Apr 2013 14:1

Re: [libvirt] [PATCH v3 5/5] qemu: auto-add bridges and allow using them

2013-04-22 Thread Laine Stump
(before anything else - you committed an unresolved merge conflict in qemu_command.h. You'll need to remove the extra "> blah" text.) Hopefully Eric can once again review the logic of the code that determines what bridges need to be auto-added, and assign PCI addresses to devices, since he

Re: [libvirt] [PATCH v3 4/5] qemu: auto-add pci-root controller for pc machine types

2013-04-22 Thread Laine Stump
On 04/22/2013 02:43 PM, Ján Tomko wrote: > > is auto-added to pc* machine types. > Without this controller PCI bus 0 is not available and > no PCI addresses are assigned by default. > > Since older libvirt supported PCI bus 0 even without > this controller, it is removed from the XML when migratin

Re: [libvirt] [PATCH qom-cpu 6/9] target-i386: Add "feature-words" property

2013-04-22 Thread Eric Blake
On 04/22/2013 01:00 PM, Eduardo Habkost wrote: > This property will be useful for libvirt, as libvirt already has logic > based on low-level feature bits (not feature names), so it will be > really easy to convert the current libvirt logic to something using the > "feature-words" property. > > The

Re: [libvirt] [PATCH v3 3/5] qemu: build command line for pci-bridge device

2013-04-22 Thread Laine Stump
On 04/22/2013 02:43 PM, Ján Tomko wrote: > From: liguang Add a "Signed-off-by:" line for yourself. > > --- > src/qemu/qemu_capabilities.c | 3 +++ > src/qemu/qemu_capabilities.h | 1 + > src/qemu/qemu_command.c | 30 +- > tests/qemuhelptest.c | 21 ++

Re: [libvirt] [PATCH v3 2/5] conf: add PCI controllers

2013-04-22 Thread Laine Stump
On 04/22/2013 02:43 PM, Ján Tomko wrote: > Add new controller type 'pci' with models 'pci-root' and 'pci-bridge'. > --- > docs/formatdomain.html.in | 22 +- > docs/schemas/domaincommon.rng | 12 > src/conf/domain_conf.c| 21 - > src/

Re: [libvirt] [PATCH v3 1/5] qemu: call post-parse callbacks when parsing command line too

2013-04-22 Thread Laine Stump
On 04/22/2013 02:43 PM, Ján Tomko wrote: > Assume format type is 'auto' when none is specified on > qemu command line. > --- > src/conf/domain_conf.c | 2 +- > src/conf/domain_conf.h | 5 + > src/libvirt_

[libvirt] [libvirt-designer] Add missing files to EXTRA_DIST

2013-04-22 Thread Christophe Fergeau
This fixes make distcheck --- I've pushed this under the trivial rule. Christophe Makefile.am | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Makefile.am b/Makefile.am index 9ef319a..726d475 100644 --- a/Makefile.am +++ b/Makefile.am @@ -10,6 +10,8 @@ EXTRA_DIST = \ $(PACKAGE).spec

[libvirt] [PATCH qom-cpu 8/9] target-i386: Introduce X86CPU.filtered_features field

2013-04-22 Thread Eduardo Habkost
This field will contain the feature bits that were filtered out because of missing host support. Signed-off-by: Eduardo Habkost --- target-i386/cpu-qom.h | 3 +++ target-i386/cpu.c | 9 ++--- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/target-i386/cpu-qom.h b/target-i3

[libvirt] [PATCH qom-cpu 3/9] target-i386/cpu.c: Break lines so they don't get too long

2013-04-22 Thread Eduardo Habkost
Break lines on kvm_check_features_against_host(), kvm_cpu_fill_host(), and builtin_x86_defs, so they don't get too long once the *_features fields are replaced by an array. Signed-off-by: Eduardo Habkost Reviewed-By: Igor Mammedov --- Changes v9: * Merged all "Break lines" patches from previous

[libvirt] [PATCH qom-cpu 2/9] target-i386/kvm.c: Code formatting changes

2013-04-22 Thread Eduardo Habkost
Add appropriate spaces around operators, and break line where it needs to be broken to allow feature-words array to be introduced without having too-long lines. Signed-off-by: Eduardo Habkost Reviewed-By: Igor Mammedov --- Changes v9: * 1-char alignment change: keep the opening parenthesis of b

[libvirt] [PATCH qom-cpu 1/9] target-i386: cleanup: Group together level, xlevel, xlevel2 fields

2013-04-22 Thread Eduardo Habkost
Consolidate level, xlevel, xlevel2 fields in x86_def_t and CPUX86State. Signed-off-by: Eduardo Habkost Reviewed-By: Igor Mammedov --- Changes v9: * Merged "target-i386: Move cpuid_xlevel, cpuid_xlevel2 fields in X86CPU" and "target-i386: Move xlevel/xlevel2 in struct x86_def_t" in a singl

[libvirt] [PATCH qom-cpu 4/9] target-i386: Replace cpuid_*features fields with a feature word array

2013-04-22 Thread Eduardo Habkost
This replaces the feature-bit fields on both X86CPU and x86_def_t structs with an array. With this, we will be able to simplify code that simply does the same operation on all feature words (e.g. kvm_check_features_against_host(), filter_features_for_kvm(), add_flagname_to_bitmaps(), CPU feature-b

[libvirt] [PATCH qom-cpu 5/9] target-i386: Add ECX information to FeatureWordInfo

2013-04-22 Thread Eduardo Habkost
FEAT_7_0_EBX uses ECX as input, so we have to take that into account when reporting feature word values. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 110ef98..314931

[libvirt] [PATCH qom-cpu 9/9] target-i386: Add "filtered-features" property to X86CPU

2013-04-22 Thread Eduardo Habkost
This property will contain all the features that were removed from the CPU because they are not supported by the host. This way, libvirt or other management tools can emulate the check/enforce behavior by checking if filtered-properties is all zeroes, before starting the guest. Example output whe

[libvirt] [PATCH qom-cpu 6/9] target-i386: Add "feature-words" property

2013-04-22 Thread Eduardo Habkost
This property will be useful for libvirt, as libvirt already has logic based on low-level feature bits (not feature names), so it will be really easy to convert the current libvirt logic to something using the "feature-words" property. The property will have two main use cases: - Checking host ca

[libvirt] [PATCH qom-cpu 0/9] x86: feature words array (v11) + "feature-words" property

2013-04-22 Thread Eduardo Habkost
This series includes the previous "replace cpuid_*features fields with a feature word array" series. The first 4 patches already have a Reviewed-by from Igor, they correspond to v10 plus a small indent fix requested by him. As the cpuid_*features series was holding my "feature-words"/"filtered-fe

[libvirt] [PATCH qom-cpu 7/9] target-i386: Use FeatureWord loop on filter_features_for_kvm()

2013-04-22 Thread Eduardo Habkost
Instead of open-coding the filtering code for each feature word, change the existing code to use the feature_word_info array, that have exactly the same CPUID eax/ecx/register values for each feature word. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 24 +++- 1 file

[libvirt] [PATCH v3 2/5] conf: add PCI controllers

2013-04-22 Thread Ján Tomko
Add new controller type 'pci' with models 'pci-root' and 'pci-bridge'. --- docs/formatdomain.html.in | 22 +- docs/schemas/domaincommon.rng | 12 src/conf/domain_conf.c| 21 - src/conf/domain_conf.h| 9 + 4 files cha

[libvirt] [PATCH v3 0/5] qemu: add PCI bridge support

2013-04-22 Thread Ján Tomko
Add new 'pci' controller type with two models: pci-root - auto-added to machines with implicit pci bus pci-bridge - auto-added if the devices would not leave at least one slot empty on bus 0 or bus >0 is specified v3: moved the implicit PCI root addition to qemu's post parse callback, added an xml

[libvirt] [PATCH v3 3/5] qemu: build command line for pci-bridge device

2013-04-22 Thread Ján Tomko
From: liguang --- src/qemu/qemu_capabilities.c | 3 +++ src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 30 +- tests/qemuhelptest.c | 21 ++--- 4 files changed, 47 insertions(+), 8 deletions(-) diff --git a/src/qemu/qemu_c

[libvirt] [PATCH v3 5/5] qemu: auto-add bridges and allow using them

2013-04-22 Thread Ján Tomko
Add a "dry run" address allocation to figure out how many bridges will be needed for all the devices without explicit addresses. Auto-add just enough bridges to put all the devices on, or up to the bridge with the largest specified index. --- src/conf/domain_conf.c |

[libvirt] [PATCH v3 1/5] qemu: call post-parse callbacks when parsing command line too

2013-04-22 Thread Ján Tomko
Assume format type is 'auto' when none is specified on qemu command line. --- src/conf/domain_conf.c | 2 +- src/conf/domain_conf.h | 5 + src/libvirt_private.syms

Re: [libvirt] [PATCH 0/3] Ignore libvirt logs when reading QEMU error output

2013-04-22 Thread Jiri Denemark
On Mon, Apr 22, 2013 at 18:40:07 +0200, Jiri Denemark wrote: > Jiri Denemark (3): > qemu: Move QEMU log reading into a separate function > qemu: Ignore libvirt logs when reading QEMU error output > logging: Make log regexp more compact (and readable) > > src/qemu/qemu_process.c | 81 >

Re: [libvirt] [PATCH] update input ip processing

2013-04-22 Thread Laine Stump
On 04/21/2013 10:34 AM, Gene Czarcinski wrote: > 1. Handle invalid ULong prefix specified. > When parsing for @prefix as a ULong, a -2 can be returned > if the specification is not a valid ULong. > > 2. Error out if address= is not specified. > > 3. Merge netmask process/tests under family tests.

Re: [libvirt] [libvirt-designer PATCHv2 9/9] Implement gvir_designer_domain_add_video()

2013-04-22 Thread Christophe Fergeau
On Thu, Apr 18, 2013 at 06:12:33PM +0200, Christophe Fergeau wrote: > diff --git a/libvirt-designer/libvirt-designer-domain.c > b/libvirt-designer/libvirt-designer-domain.c > index 7aec002..73dbc8d 100644 > --- a/libvirt-designer/libvirt-designer-domain.c > +++ b/libvirt-designer/libvirt-designer-

Re: [libvirt] [libvirt-designer PATCHv2 3/3] Rework disk bus type handling

2013-04-22 Thread Christophe Fergeau
On Fri, Apr 19, 2013 at 11:46:21AM +0200, Michal Privoznik wrote: > On 18.04.2013 18:08, Christophe Fergeau wrote: > > +static OsinfoDevice * > > +gvir_designer_domain_get_fallback_disk_controller(GVirDesignerDomain > > *design, > > + GError **error

Re: [libvirt] [libvirt-designer 2/3] Automatically set min versions in README

2013-04-22 Thread Daniel P. Berrange
On Mon, Apr 22, 2013 at 06:57:11PM +0200, Christophe Fergeau wrote: > Minimum libvirt-gconfig and libosinfo versions appear in both > README and configure.ac, which means they easily get out of sync. > This commit renames README to README.in so that we can substitute > the configure.ac version in t

Re: [libvirt] [PATCH 1/3] qemu: Move QEMU log reading into a separate function

2013-04-22 Thread Osier Yang
On 23/04/13 00:40, Jiri Denemark wrote: --- src/qemu/qemu_process.c | 61 ++--- 1 file changed, 38 insertions(+), 23 deletions(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index ce9f501..a1fbd5f 100644 --- a/src/qemu/qemu_proces

Re: [libvirt] [PATCH 2/3] qemu: Ignore libvirt logs when reading QEMU error output

2013-04-22 Thread Osier Yang
On 23/04/13 00:40, Jiri Denemark wrote: When QEMU fails to start, libvirt read its error output and reports it back in an error message. However, when libvirtd is configured to log debug messages, one would get the following unhelpful garbage: virsh # start cd error: Failed to start do

Re: [libvirt] [PATCH 3/3] logging: Make log regexp more compact (and readable)

2013-04-22 Thread Osier Yang
On 23/04/13 00:40, Jiri Denemark wrote: --- src/util/virlog.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/util/virlog.c b/src/util/virlog.c index 721c9bd..e31abb0 100644 --- a/src/util/virlog.c +++ b/src/util/virlog.c @@ -79,8 +79,8 @@ static int virLogEnd = 0;

Re: [libvirt] [libvirt-designer 3/3] Set min versions from configure in .spec file

2013-04-22 Thread Daniel P. Berrange
On Mon, Apr 22, 2013 at 06:57:12PM +0200, Christophe Fergeau wrote: > Minimum libvirt-gobject, libvirt-gconfig and libosinfo versions > are set in configure.ac, it's better not to duplicate them in > libvirt-designer.spec.in, it's too easy to get them out of sync. > --- > configure.ac

Re: [libvirt] [libvirt-designer 1/3] Fix 'dependancy' typo in README file

2013-04-22 Thread Daniel P. Berrange
On Mon, Apr 22, 2013 at 06:57:10PM +0200, Christophe Fergeau wrote: > --- > README | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/README b/README > index ed39b9d..b7ca356 100644 > --- a/README > +++ b/README > @@ -24,7 +24,7 @@ Or to install into a private user specific

Re: [libvirt] [libvirt-designer PATCHv2 2/3] Add gvir_designer_domain_get_supported_devices()

2013-04-22 Thread Christophe Fergeau
On Fri, Apr 19, 2013 at 11:46:22AM +0200, Michal Privoznik wrote: > > --- a/configure.ac > > +++ b/configure.ac > > @@ -10,7 +10,7 @@ AC_CANONICAL_HOST > > > > AM_SILENT_RULES([yes]) > > > > -LIBOSINFO_REQUIRED=0.2.3 > > +LIBOSINFO_REQUIRED=0.2.6 > > LIBVIRT_GCONFIG_REQUIRED=0.0.9 > > LIBVIR

[libvirt] [libvirt-designer 2/3] Automatically set min versions in README

2013-04-22 Thread Christophe Fergeau
Minimum libvirt-gconfig and libosinfo versions appear in both README and configure.ac, which means they easily get out of sync. This commit renames README to README.in so that we can substitute the configure.ac version in the README file. This way they are always in sync. --- Makefile.am |

[libvirt] [libvirt-designer 3/3] Set min versions from configure in .spec file

2013-04-22 Thread Christophe Fergeau
Minimum libvirt-gobject, libvirt-gconfig and libosinfo versions are set in configure.ac, it's better not to duplicate them in libvirt-designer.spec.in, it's too easy to get them out of sync. --- configure.ac | 2 +- libvirt-designer.spec.in | 8 2 files changed, 5 insertions(+

[libvirt] [libvirt-designer 1/3] Fix 'dependancy' typo in README file

2013-04-22 Thread Christophe Fergeau
--- README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README b/README index ed39b9d..b7ca356 100644 --- a/README +++ b/README @@ -24,7 +24,7 @@ Or to install into a private user specific location make make install -The following mandatory dependancies are required

Re: [libvirt] [PATCH] qemu: Fix setting of memory tunables

2013-04-22 Thread Eric Blake
On 04/19/2013 04:01 AM, Peter Krempa wrote: > Refactoring done in 19c6ad9ac7e7eb2fd3c8262bff5f087b508ad07f didn't > correctly take into account the order cgroup limit modification needs to > be done in. This resulted into errors when decreasing the limits. > > The operations need to take place in

Re: [libvirt] [PATCHv2] Configure native vlan modes on Open vSwitch ports

2013-04-22 Thread james robson
> Date: Thu, 18 Apr 2013 14:14:32 -0400 > From: Laine Stump > To: libvir-list@redhat.com > Subject: Re: [libvirt] [PATCHv2] Configure native vlan modes on Open > vSwitch ports > Message-ID: <51703808.2000...@laine.org> > Content-Type: text/plain; charset=ISO-8859-1 > > On 04/18/2013 01:44

[libvirt] [PATCH 1/3] qemu: Move QEMU log reading into a separate function

2013-04-22 Thread Jiri Denemark
--- src/qemu/qemu_process.c | 61 ++--- 1 file changed, 38 insertions(+), 23 deletions(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index ce9f501..a1fbd5f 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -1346,6

[libvirt] [sandbox PATCH 1/3] Add UID/GID support for use with interactive containers.

2013-04-22 Thread dwalsh
From: Dan Walsh Openshift Containers will be run with a unique UID and GID --- bin/virt-sandbox-service| 43 +-- bin/virt-sandbox-service-bash-completion.sh | 8 +++-- bin/virt-sandbox-service-create.pod | 53 - 3 files

Re: [libvirt] [sandbox PATCH 3/3] Do not run a shell within a lxc container by default.

2013-04-22 Thread Daniel P. Berrange
On Mon, Apr 22, 2013 at 12:26:31PM -0400, dwa...@redhat.com wrote: > From: Dan Walsh > > We want to make sure we use as little overhead as possible. > If a user connects to a lxc container, it will be the same as executing > a shell within the container. > --- > bin/virt-sandbox-service | 15 +++

Re: [libvirt] [sandbox PATCH 2/3] Only create the destination path if it does not exist.

2013-04-22 Thread Daniel P. Berrange
On Mon, Apr 22, 2013 at 12:26:30PM -0400, dwa...@redhat.com wrote: > From: Dan Walsh > > OpenShift will be creating the path within its management layer. > --- > bin/virt-sandbox-service | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/bin/virt-sandbox-service b/bin

[libvirt] [PATCH 0/3] Ignore libvirt logs when reading QEMU error output

2013-04-22 Thread Jiri Denemark
Jiri Denemark (3): qemu: Move QEMU log reading into a separate function qemu: Ignore libvirt logs when reading QEMU error output logging: Make log regexp more compact (and readable) src/qemu/qemu_process.c | 81 + src/util/virlog.c | 4

Re: [libvirt] [sandbox PATCH 1/3] Add UID/GID support for use with interactive containers.

2013-04-22 Thread Daniel P. Berrange
On Mon, Apr 22, 2013 at 12:26:29PM -0400, dwa...@redhat.com wrote: > From: Dan Walsh > > Openshift Containers will be run with a unique UID and GID > --- > bin/virt-sandbox-service| 43 +-- > bin/virt-sandbox-service-bash-completion.sh | 8 +++-- > bin/vi

[libvirt] Add UID/GID support to virt-sandbox-service

2013-04-22 Thread dwalsh
This patch set is adding support for UID/GID/USERNAME/USERDIR for use with openshift containers Also fixes virt-sandbox-service to not complain if the destdir has been precreated. Finally we also do not want excess processes running withing containers (/bin/sh). [sandbox PATCH 1/3] Add UID/GI

[libvirt] [sandbox PATCH 3/3] Do not run a shell within a lxc container by default.

2013-04-22 Thread dwalsh
From: Dan Walsh We want to make sure we use as little overhead as possible. If a user connects to a lxc container, it will be the same as executing a shell within the container. --- bin/virt-sandbox-service | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/bin/v

[libvirt] [sandbox PATCH 2/3] Only create the destination path if it does not exist.

2013-04-22 Thread dwalsh
From: Dan Walsh OpenShift will be creating the path within its management layer. --- bin/virt-sandbox-service | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/bin/virt-sandbox-service b/bin/virt-sandbox-service index 31aa6a1..dd30993 100755 --- a/bin/virt-sandbox-service

[libvirt] [PATCH 3/3] logging: Make log regexp more compact (and readable)

2013-04-22 Thread Jiri Denemark
--- src/util/virlog.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/util/virlog.c b/src/util/virlog.c index 721c9bd..e31abb0 100644 --- a/src/util/virlog.c +++ b/src/util/virlog.c @@ -79,8 +79,8 @@ static int virLogEnd = 0; static regex_t *virLogRegex = NULL; -#d

[libvirt] [PATCH 2/3] qemu: Ignore libvirt logs when reading QEMU error output

2013-04-22 Thread Jiri Denemark
When QEMU fails to start, libvirt read its error output and reports it back in an error message. However, when libvirtd is configured to log debug messages, one would get the following unhelpful garbage: virsh # start cd error: Failed to start domain cd error: internal error process ex

Re: [libvirt] [PATCH] rpc: message related sizes enlarged

2013-04-22 Thread Daniel P. Berrange
On Mon, Apr 22, 2013 at 06:18:04PM +0200, Viktor Mihajlovski wrote: > On 04/22/2013 04:34 PM, Daniel P. Berrange wrote: > >On Mon, Apr 22, 2013 at 04:22:26PM +0200, Viktor Mihajlovski wrote: > >I'm not against this in general, but before we enlarge this so much > >there needs to be some code work t

[libvirt] [PATCH] Replace more cases of /system with /machine

2013-04-22 Thread Daniel P. Berrange
From: "Daniel P. Berrange" The change in commit aed4986322fe77bdf718e31a0587d00f04f3d97a was incomplete, missing a couple of cases of /system. This caused failure to start VMs. Pushed under trivial rule Signed-off-by: Daniel P. Berrange --- src/lxc/lxc_cgroup.c | 2 +- src/qemu/qemu_cgroup.

Re: [libvirt] [PATCH] rpc: message related sizes enlarged

2013-04-22 Thread Viktor Mihajlovski
On 04/22/2013 04:34 PM, Daniel P. Berrange wrote: On Mon, Apr 22, 2013 at 04:22:26PM +0200, Viktor Mihajlovski wrote: I'm not against this in general, but before we enlarge this so much there needs to be some code work to make RPC message encoding more efficient. Currently virNetMessageEncodeHead

Re: [libvirt] [PATCH-v4 2/2] Support for static routes on a virtual bridge

2013-04-22 Thread Laine Stump
(I had thought there would be just a few tweaks to the documentation that I could squash in and push, but as I reviewed I found more issues, and don't have time to fix them myself. It is *very* close though, and the freeze for 1.0.5 is coming up (within a couple days, I think?), so if you can make

Re: [libvirt] [PATCH-v4 1/2] create virSocketAddrGetIpPrefix utility function

2013-04-22 Thread Laine Stump
On 04/22/2013 10:20 AM, Laine Stump wrote: > On 04/20/2013 03:45 PM, Gene Czarcinski wrote: >> Create the utility function virSocketAddrGetIpPrefix() to >> determine the prefix for this network. The code in this >> function was adapted from virNetworkIpDefPrefix(). >> >> Update virNetworkIpDefPref

Re: [libvirt] virCommandProcessIO: hangs on poll()

2013-04-22 Thread Eric Blake
On 04/19/2013 01:32 AM, wangxiaojun wrote: > recent qemu (git resp) with param like: > #>qemu-kvm -S -no-user-config -nodefaults -nographic -M none -qmp > monarg -pidfile pidfile > > will just hangs forever. no any output or errors . > and when libvirt Try to get caps via QMP qemuCap

Re: [libvirt] [PATCH] rng: tighten up domain schema

2013-04-22 Thread Eric Blake
On 04/22/2013 08:00 AM, Laine Stump wrote: > On 04/19/2013 11:25 AM, Laine Stump wrote: >>> On 04/18/2013 06:36 AM, Laine Stump wrote: Trimming a rather deep nesting... > > Okay, I misunderstood what you said - you weren't saying that you had > put num_queues in the element (obviously

Re: [libvirt] [PATCH] Use camelCase for XML attribute numQueues

2013-04-22 Thread Osier Yang
On 22/04/13 22:43, Laine Stump wrote: On 04/22/2013 10:13 AM, Laine Stump wrote: Of course in this case, we *could* avoid the camelCase vs underscore entirely by just naming the attribute "queues" instead of numQueues or num_queues (the fact that the attribute is a number makes it pretty obvious

Re: [libvirt] [PATCH] rng: tighten up domain schema

2013-04-22 Thread Osier Yang
On 22/04/13 22:00, Laine Stump wrote: On 04/19/2013 11:25 AM, Laine Stump wrote: On 04/19/2013 04:32 AM, Osier Yang wrote: On 18/04/13 19:59, Laine Stump wrote: On 04/18/2013 07:27 AM, Osier Yang wrote: On 18/04/13 19:16, Laine Stump wrote: On 04/18/2013 05:41 AM, Martin Kletzander wrote: O

Re: [libvirt] [PATCH] Use camelCase for XML attribute numQueues

2013-04-22 Thread Laine Stump
On 04/22/2013 10:13 AM, Laine Stump wrote: > Of course in this case, we *could* avoid the camelCase vs underscore > entirely by just naming the attribute "queues" instead of numQueues or > num_queues (the fact that the attribute is a number makes it pretty > obvious that it is the "number of queues

Re: [libvirt] [PATCH] rpc: message related sizes enlarged

2013-04-22 Thread Michal Privoznik
On 22.04.2013 16:22, Viktor Mihajlovski wrote: > From: Daniel Hansel > > We have seen an issue on s390x platform where domain XMLs larger than 1MB > were used. The define command was finished successfully. The dumpxml command > was not successful (i.e. could not encode message payload). > > Enla

Re: [libvirt] [PATCH] Omitting braces with a single-line body

2013-04-22 Thread Eric Blake
On 04/22/2013 07:40 AM, harryxiyou wrote: > On Mon, Apr 22, 2013 at 9:13 PM, Osier Yang wrote: >> On 22/04/13 20:33, harryxi...@gmail.com wrote: >>> >>> From: Harry Wei >>> >>> After i read libvirt/HACKING file, i find we should >> >> >> s/i/I/, > > Actually, i wonder what 's/i/l/' means? It's

Re: [libvirt] [PATCH] rpc: message related sizes enlarged

2013-04-22 Thread Daniel P. Berrange
On Mon, Apr 22, 2013 at 04:22:26PM +0200, Viktor Mihajlovski wrote: > From: Daniel Hansel > > We have seen an issue on s390x platform where domain XMLs larger than 1MB > were used. The define command was finished successfully. The dumpxml command > was not successful (i.e. could not encode messag

[libvirt] [PATCH v1 07/12] qemu: Allow multiple vhost-net openings

2013-04-22 Thread Michal Privoznik
With multiqueue network feature, we are advised to pass multiple vhost-net FDs as well. The ratio should be 1:1. Therefore we must alter the qemuOpenVhostNet function to allow that. --- src/qemu/qemu_command.c | 40 ++-- src/qemu/qemu_command.h | 3 ++- src/qem

[libvirt] [PATCH v1 00/12] Multiple TX queue support

2013-04-22 Thread Michal Privoznik
Kernel and subsequently QEMU learned multiple transmit queues a while ago. The feature has a nice advantage, it alloes a single guest to transmit multiple flows of network data using multiple CPUs simultaneously which increase traffic bandwidth. A lot. The documentation how to use this is availabl

[libvirt] [PATCH v1 10/12] qemu: Change qemuOpenVhostNet return value

2013-04-22 Thread Michal Privoznik
Currently, need for use of vhost-net is signalized by returning zero, and setting passed FD to a value different to negative one. However, when using multiple vhost-net devices, it is not so easy so we should use return value for that. --- src/qemu/qemu_command.c | 22 +- 1 fil

[libvirt] [PATCH v1 05/12] qemu: Adapt command line generation to multiqueue net

2013-04-22 Thread Michal Privoznik
The qemuBuildHostNetStr() function which is responsible for generating command line for a network interface needs to be aware of multiqueue network interface as we are required to use: - fd=%d in case of one FD - fds=%d:%d:%d:...:%d in case of multiple FDs These two approaches can't be mixed

[libvirt] [PATCH v1 11/12] qemu: Adapt qemuBuildInterfaceCommandLine to to multiqueue net

2013-04-22 Thread Michal Privoznik
--- src/qemu/qemu_command.c | 88 +++-- 1 file changed, 64 insertions(+), 24 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index dfcfedc..60873c7 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -5816,1

[libvirt] [PATCH v1 09/12] qemu: Adapt qemuDomainAttachNetDevice to multiqueue net

2013-04-22 Thread Michal Privoznik
--- src/qemu/qemu_hotplug.c | 96 - 1 file changed, 63 insertions(+), 33 deletions(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index 3505c52..3a00811 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -683,10

[libvirt] [PATCH v1 02/12] qemu: Move interface cmd line construction into a separate function

2013-04-22 Thread Michal Privoznik
Currently, we have one huge function to construct qemu command line. This is very ineffective esp. if there's a fault somewhere. --- src/qemu/qemu_command.c | 323 +--- 1 file changed, 171 insertions(+), 152 deletions(-) diff --git a/src/qemu/qemu_comma

[libvirt] [PATCH v1 06/12] util: Learn virNetDevTapCreate multiqueue network

2013-04-22 Thread Michal Privoznik
Currently, the function knows how to open a TAP device for a single time. However, in case of multiqueue network we need to open it multiple times. Moreover, when doing TUNSETIFF ioctl, the IFF_MULTI_QUEUE flag shall be requested. This commit changes a behaviour slightly as well. Till now it was po

[libvirt] [PATCH v1 12/12] qemu: Enable multiqueue network

2013-04-22 Thread Michal Privoznik
--- src/qemu/qemu_command.c | 10 ++ src/qemu/qemu_hotplug.c | 5 +++-- 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 60873c7..a7d422a 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -5887,12 +5

[libvirt] [PATCH v1 01/12] Introduce /domain/devices/interface/driver/@queues attribute

2013-04-22 Thread Michal Privoznik
This attribute is going to represent number of queues for multique vhost network interface. This commit implements XML extension part of the feature and add one test as well. For now, we can only do xml2xml test as qemu command line generation code is not adapted yet. --- docs/formatdomain.html.in

[libvirt] [PATCH v1 03/12] qemu: Make qemuMonitorAddHostNetwork to pass multiple FDs

2013-04-22 Thread Michal Privoznik
Currently, only one tapfd and one vhostfd could be passed. However, multiqueue network requires several FDs to be passed to qemu so we must adapt out monitor handling functions to cope with that. --- src/qemu/qemu_hotplug.c | 7 +-- src/qemu/qemu_monitor.c | 39 +++

[libvirt] [PATCH v1 04/12] qemu: Make qemuMonitorAddHostNetwork to pass multiple FDs

2013-04-22 Thread Michal Privoznik
Currently, only one tapfd and one vhostfd could be passed. However, multiqueue network requires several FDs to be passed to qemu so we must adapt out monitor handling functions to cope with that. --- src/qemu/qemu_hotplug.c | 7 +-- src/qemu/qemu_monitor.c | 39 +++

[libvirt] [PATCH v1 08/12] qemu: Rework qemuNetworkIfaceConnect

2013-04-22 Thread Michal Privoznik
For future work it's better, if tapfd is passed as pointer. Moreover, we need to be able to return multiple values now. --- src/qemu/qemu_command.c | 70 + src/qemu/qemu_command.h | 4 ++- src/qemu/qemu_hotplug.c | 4 +-- 3 files changed, 41 insert

[libvirt] [PATCH v2 4/5] Add 'nbd' as a valid filesystem driver type

2013-04-22 Thread Daniel P. Berrange
From: "Daniel P. Berrange" The element can now accept a as an alternative to 'loop'. The benefit of NBD is support for non-raw disk image formats. Signed-off-by: Daniel P. Berrange --- docs/formatdomain.html.in | 5 +++-- docs/schemas/domaincommon.rng | 1 + src/conf/domain_conf.c

Re: [libvirt] [PATCH-v4 1/2] create virSocketAddrGetIpPrefix utility function

2013-04-22 Thread Laine Stump
On 04/20/2013 03:45 PM, Gene Czarcinski wrote: > Create the utility function virSocketAddrGetIpPrefix() to > determine the prefix for this network. The code in this > function was adapted from virNetworkIpDefPrefix(). > > Update virNetworkIpDefPrefix() in src/conf/network_conf.c > to use the new u

[libvirt] [PATCH] rpc: message related sizes enlarged

2013-04-22 Thread Viktor Mihajlovski
From: Daniel Hansel We have seen an issue on s390x platform where domain XMLs larger than 1MB were used. The define command was finished successfully. The dumpxml command was not successful (i.e. could not encode message payload). Enlarged message related sizes (e.g. maximum string size, message

Re: [libvirt] [PATCH] Use camelCase for XML attribute numQueues

2013-04-22 Thread Laine Stump
On 04/22/2013 06:58 AM, Daniel Veillard wrote: > On Thu, Apr 18, 2013 at 08:27:56AM -0600, Eric Blake wrote: >> On 04/18/2013 03:02 AM, Martin Kletzander wrote: >>> In commit d4bf0a9, we used num_queues for an attribute in the XML, but >>> the consensus is that we use camelCase for that. Since the

[libvirt] [PATCH v2 3/5] Add a helper API for setting up a NBD device with qemu-nbd

2013-04-22 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Add a virFileNBDDeviceAssociate method, which given a filename will setup a NBD device, using qemu-nbd as the server. Signed-off-by: Daniel P. Berrange --- src/libvirt_private.syms | 1 + src/util/virfile.c | 151 ++

Re: [libvirt] [PATCH] rng: tighten up domain schema

2013-04-22 Thread Laine Stump
On 04/19/2013 11:25 AM, Laine Stump wrote: > On 04/19/2013 04:32 AM, Osier Yang wrote: >> On 18/04/13 19:59, Laine Stump wrote: >>> On 04/18/2013 07:27 AM, Osier Yang wrote: On 18/04/13 19:16, Laine Stump wrote: > On 04/18/2013 05:41 AM, Martin Kletzander wrote: >> On 04/18/2013 11:05

[libvirt] [PATCH v2 2/5] Re-arrange code setting up ifs/disk loop devices for LXC

2013-04-22 Thread Daniel P. Berrange
From: "Daniel P. Berrange" The current code for setting up loop devices to LXC disks first does a switch() based on the disk format, then looks at the disk driver name. Reverse this so it first looks at the driver name, and then the disk format. This is more useful since the list of supported dis

[libvirt] [PATCH v2 5/5] Support NBD backed disks/filesystems in LXC driver

2013-04-22 Thread Daniel P. Berrange
From: "Daniel P. Berrange" The LXC driver can already configure or devices to use the loop device. This extends it to also allow for use of the NBD device, to support non-raw formats. Signed-off-by: Daniel P. Berrange --- src/lxc/lxc_controller.c | 80

[libvirt] [PATCH v2 1/5] Add support for storage format in FS

2013-04-22 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Extend the element in filesystem devices to allow a storage format to be set. The new attribute uses 'format' to reflect the storage format. This is different from the element in disk devices which use 'type' to reflect the storage format. This is because the 'type' a

[libvirt] [PATCH v2 0/5] Support NBD volumes with LXC containers

2013-04-22 Thread Daniel P. Berrange
A second version of: https://www.redhat.com/archives/libvir-list/2013-March/msg00941.html Aside from the addressing the previous round of feedbac, this adds use of the new '--format' flag to qemu-nbd. This is introduced due to CVE-2013-1922. The upshot is that this code won't work with any qemu

[libvirt] [PATCH] test: Add JSON test for query-tpm-types

2013-04-22 Thread Stefan Berger
Add a test case for query-tpm-models QMP command. Signed-off-by: Stefan Berger --- tests/qemumonitorjsontest.c | 55 1 file changed, 55 insertions(+) Index: libvirt/tests/qemumonitorjsontest.c ===

Re: [libvirt] [PATCH] Omitting braces with a single-line body

2013-04-22 Thread harryxiyou
On Mon, Apr 22, 2013 at 9:13 PM, Osier Yang wrote: > On 22/04/13 20:33, harryxi...@gmail.com wrote: >> >> From: Harry Wei >> >> After i read libvirt/HACKING file, i find we should > > > s/i/I/, Actually, i wonder what 's/i/l/' means? > > >> Omit braces with a single-line body. So this patch >>

Re: [libvirt] [PATCH] Omitting braces with a single-line body

2013-04-22 Thread Osier Yang
On 22/04/13 20:33, harryxi...@gmail.com wrote: From: Harry Wei After i read libvirt/HACKING file, i find we should s/i/I/, Omit braces with a single-line body. So this patch fix this coding style problem for Sheepdog storage s/fix this/fixes the/, backend driver. The commit log can be

[libvirt] [PATCH] Omitting braces with a single-line body

2013-04-22 Thread harryxiyou
From: Harry Wei After i read libvirt/HACKING file, i find we should Omit braces with a single-line body. So this patch fix this coding style problem for Sheepdog storage backend driver. Signed-off-by: Harry Wei --- src/storage/storage_backend_sheepdog.c | 11 --- 1 file changed, 4 in

Re: [libvirt] [PATCH 2/2] qemu: launch bridge helper from libvirtd

2013-04-22 Thread Daniel P. Berrange
On Sat, Apr 20, 2013 at 11:11:25AM +0200, Paolo Bonzini wrote: > uses a helper application to do the necessary > TUN/TAP setup to use an existing network bridge, thus letting > unprivileged users use TUN/TAP interfaces. > > However, libvirt should be preventing QEMU from running any setuid > prog

Re: [libvirt] [PATCH 1/2] virnetdevtap: add virNetDevTapGetName

2013-04-22 Thread Daniel P. Berrange
On Sat, Apr 20, 2013 at 11:11:24AM +0200, Paolo Bonzini wrote: > This will be used on a tap file descriptor returned by the bridge helper > to populate the element, because the helper does not provide > the interface name. > > Signed-off-by: Paolo Bonzini > --- > src/libvirt_private.syms | 1 +

Re: [libvirt] [PATCH v3] qemu: Implement CPUs check against machine type's cpu-max

2013-04-22 Thread Michal Novotny
ping? On 04/17/2013 04:15 PM, Michal Novotny wrote: > Implement check whether (maximum) vCPUs doesn't exceed machine > type's cpu-max settings. > > On older versions of QEMU the check is disabled. > > Signed-off-by: Michal Novotny > --- > src/qemu/qemu_capabilities.c | 38 +++

Re: [libvirt] [PATCH] Use camelCase for XML attribute numQueues

2013-04-22 Thread Daniel Veillard
On Thu, Apr 18, 2013 at 08:27:56AM -0600, Eric Blake wrote: > On 04/18/2013 03:02 AM, Martin Kletzander wrote: > > In commit d4bf0a9, we used num_queues for an attribute in the XML, but > > the consensus is that we use camelCase for that. Since there was no > > release yet (the above commit descri

  1   2   >