Re: [libvirt] [PATCH v3 00/12] Add user namespace support for libvirt lxc

Am 11.06.2013 05:12, schrieb Gao feng: On 06/11/2013 04:51 AM, Richard Weinberger wrote: Am 10.06.2013 21:53, schrieb Richard Weinberger: Am 10.06.2013 21:17, schrieb Richard Weinberger: Hi! Am 04.06.2013 13:03, schrieb Daniel P. Berrange: It's still under review. needs some ACK. If you can

Re: [libvirt] [PATCH v3 00/12] Add user namespace support for libvirt lxc

On 06/11/2013 04:51 AM, Richard Weinberger wrote: > Am 10.06.2013 21:53, schrieb Richard Weinberger: >> Am 10.06.2013 21:17, schrieb Richard Weinberger: >>> Hi! >>> >>> Am 04.06.2013 13:03, schrieb Daniel P. Berrange: > It's still under review. needs some ACK. > If you can help to test or A

Re: [libvirt] [PATCH] remote: fix dom->id after virDomainCreateWithFlags

On 23.05.2013 15:19, Michal Privoznik wrote: > On 23.05.2013 02:01, Marek Marczykowski wrote: >> The same issue as (already fixed) in virDomainCreate - >> REMOTE_PROC_DOMAIN_CREATE_WITH_FLAGS doesn't return new domain ID, only >> -1 on error or 0 on success. >> >> Besides this one fix it is more ge

Re: [libvirt] [PATCH v3 00/12] Add user namespace support for libvirt lxc

Am 10.06.2013 21:53, schrieb Richard Weinberger: Am 10.06.2013 21:17, schrieb Richard Weinberger: Hi! Am 04.06.2013 13:03, schrieb Daniel P. Berrange: It's still under review. needs some ACK. If you can help to test or ACK this patchset, it will be very helpful. :) Actually, I just want to pi

[libvirt] [PATCH 2/2] libxl: set bootloader for PV domains if not specified

The legacy xen toolstack will set pygrub as the bootloader if not specified. For compatibility, do the same in the libxl driver iff not using direct kernel boot. --- src/libxl/libxl_conf.c | 13 +++-- src/libxl/libxl_conf.h |1 + 2 files changed, 12 insertions(+), 2 deletions(-) di

[libvirt] [PATCH 1/2] libxl: Report connect type as Xen

Currently, the libxl driver reports a connection type of "xenlight". To be compatible with the legacy Xen driver, it should return "Xen". Note: I noticed this while testing the libxl driver on OpenStack. After switching my Xen compute nodes to use the libxl stack, I could no longer launch instance

[libvirt] [PATCH 0/2] libxl: compatibility fixes

This small series fixes some capatiblity issues in the libxl driver wrt the legacy xen driver. Jim Fehlig (2): libxl: Report connect type as Xen libxl: set bootloader for PV domains if not specified src/libxl/libxl_conf.c | 13 +++-- src/libxl/libxl_conf.h |1 + src/libxl/l

Re: [libvirt] [PATCH v3 00/12] Add user namespace support for libvirt lxc

Am 10.06.2013 21:17, schrieb Richard Weinberger: Hi! Am 04.06.2013 13:03, schrieb Daniel P. Berrange: It's still under review. needs some ACK. If you can help to test or ACK this patchset, it will be very helpful. :) Actually, I just want to ping... I've been away on holiday for 2 weeks, so

Re: [libvirt] [PATCH v3 00/12] Add user namespace support for libvirt lxc

Hi! Am 04.06.2013 13:03, schrieb Daniel P. Berrange: It's still under review. needs some ACK. If you can help to test or ACK this patchset, it will be very helpful. :) Actually, I just want to ping... I've been away on holiday for 2 weeks, so not had a chance to review it yet. I'll get to it

[libvirt] [PATCH] qemu_migrate: Dispose listen address if set from config

https://bugzilla.redhat.com/show_bug.cgi?id=971485 As of d7f9d827531bc843b7c5aa9d3e8c08738a1de248 we copy the listen address from the qemu.conf config file in case none has been provided via XML. But later, when migrating, we should not include such listen address in the migratable XML as it is so

[libvirt] [PATCH v2 2/2] lxc: Resolve issue with GetScheduler APIs for non running domain

As a consequence of the cgroup layout changes from commit 'cfed9ad4', the lxcDomainGetSchedulerParameters[Flags]()' and lxcGetSchedulerType() APIs failed to return data for a non running domain. This can be seen through a 'virsh schedinfo ' command which returns: Scheduler : Unknown error: R

[libvirt] [PATCH v2 1/2] qemu: Resolve issue with GetScheduler APIs for non running domain

As a consequence of the cgroup layout changes from commit '632f78ca', the qemuDomainGetSchedulerParameters[Flags]()' and qemuGetSchedulerType() APIs failed to return data for a non running domain. This can be seen through a 'virsh schedinfo ' command which returns: Scheduler : Unknown error:

[libvirt] [PATCH v2 0/2] Resolve issues seen with schedinfo

These patches resolve an issue seen using 'virsh schedinfo ' on a non running domain that have been present since 1.0.4 as a result of the cgroup infrastructure changes: https://www.redhat.com/archives/libvir-list/2013-April/msg00783.html The exact commit id that caused the issue is listed in eac

Re: [libvirt] [PATCH] storage_backend: Drop unused code

On 06/10/2013 11:38 AM, Osier Yang wrote: > On 10/06/13 23:17, Cole Robinson wrote: >> This has been disabled for years >> --- >> src/storage/storage_backend.c | 32 +--- >> 1 file changed, 5 insertions(+), 27 deletions(-) >> >> diff --git a/src/storage/storage_backen

Re: [libvirt] [PATCH] storage_backend: Drop unused code

On 10.06.2013 17:17, Cole Robinson wrote: > This has been disabled for years > --- > src/storage/storage_backend.c | 32 +--- > 1 file changed, 5 insertions(+), 27 deletions(-) > This while code will be overwritten while introducing a job control to the storage driver

Re: [libvirt] [PATCH] storage_backend: Drop unused code

On 10/06/13 23:17, Cole Robinson wrote: This has been disabled for years --- src/storage/storage_backend.c | 32 +--- 1 file changed, 5 insertions(+), 27 deletions(-) diff --git a/src/storage/storage_backend.c b/src/storage/storage_backend.c index e5c9209..0fd4598

[libvirt] [PATCH] storage_backend: Drop unused code

This has been disabled for years --- src/storage/storage_backend.c | 32 +--- 1 file changed, 5 insertions(+), 27 deletions(-) diff --git a/src/storage/storage_backend.c b/src/storage/storage_backend.c index e5c9209..0fd4598 100644 --- a/src/storage/storage_backend.c +

Re: [libvirt] [PATCH 2/7] util: add support for qcow2v3 image detection

On 06/10/2013 02:10 PM, Ján Tomko wrote: > Detect qcow2 images with version 3 in the image header as > VIR_STORAGE_FILE_QCOW2. > > These images have a feature bitfield, with just one feature supported > so far: lazy_refcounts. > > The header length changed too, moving the location of the backing

Re: [libvirt] [PATCH] udev: fix crash in libudev logging

- Original Message - From: "Ján Tomko" To: libvir-list@redhat.com Sent: Friday, June 7, 2013 7:20:10 AM Subject: [libvirt] [PATCH] udev: fix crash in libudev logging VIR_ERROR_INT calls virLogMessage(..., const char *fmt, ...). Call virLogVMessage(..., const char *fmt, va_list list) ins

[libvirt] [PATCH] qemu_migration: Move waiting for SPICE migration

Currently, we wait for SPICE to migrate in the very same loop where we wait for qemu to migrate. This has a disadvantage of slowing seamless migration down. One one hand, we should not kill the domain until all SPICE data has been migrated. On the other hand, there is no need to wait in the very s

Re: [libvirt] [PATCH 1/7] storage: rework qemu-img command line generation

On 06/10/2013 02:10 PM, Ján Tomko wrote: > Split out option string generation to make adding new options easier > and simplify the code. > --- > src/storage/storage_backend.c | 111 > ++ > 1 file changed, 59 insertions(+), 52 deletions(-) > [...] > @@ -795

Re: [libvirt] [PATCH for v1.0.5-maint] Fix use of VIR_STRDUP vs strdup

On 06/10/2013 09:45 AM, Doug Goldstein wrote: > On Mon, Jun 10, 2013 at 3:28 AM, Eric Blake > wrote: > > - Original Message - > > Commit 894f784948a93760629de3cb195c69ef4f4b831f broke the v1.0.5-maint > > branch because VIR_STRDUP() didn't exist in th

Re: [libvirt] [PATCH for v1.0.5-maint] Fix use of VIR_STRDUP vs strdup

On Mon, Jun 10, 2013 at 3:28 AM, Eric Blake wrote: > - Original Message - > > Commit 894f784948a93760629de3cb195c69ef4f4b831f broke the v1.0.5-maint > > branch because VIR_STRDUP() didn't exist in the v1.0.5 release so the > > resulting build is missing that symbol. > > > > This patch is

Re: [libvirt] [PATCH for v1.0.5-maint] Fix use of VIR_STRDUP vs strdup

On 06/10/2013 04:28 AM, Eric Blake wrote: > - Original Message - >> Commit 894f784948a93760629de3cb195c69ef4f4b831f broke the v1.0.5-maint >> branch because VIR_STRDUP() didn't exist in the v1.0.5 release so the >> resulting build is missing that symbol. >> >> This patch is only for the v1.

Re: [libvirt] [PATCH for v1.0.5-maint] Fix use of VIR_STRDUP vs strdup

On 06/10/2013 10:28 AM, Eric Blake wrote: > - Original Message - >> Commit 894f784948a93760629de3cb195c69ef4f4b831f broke the v1.0.5-maint >> branch because VIR_STRDUP() didn't exist in the v1.0.5 release so the >> resulting build is missing that symbol. >> >> This patch is only for the v1.

Re: [libvirt] [PATCH] qemu: Fix memory leak in Prepare phase

On 06/07/2013 02:14 PM, Jiri Denemark wrote: > Avoid leaking virDomainDef if Prepare phase fails before it gets to > qemuMigrationPrepareAny. > --- > src/qemu/qemu_driver.c| 12 > src/qemu/qemu_migration.c | 29 ++--- > src/qemu/qemu_migration.h | 4 ++-- >

Re: [libvirt] [PATCH] virSocketAddrIsWildcard: Use IN6_IS_ADDR_UNSPECIFIED correctly

On 06/10/13 14:39, Michal Privoznik wrote: The IN6_IS_ADDR_UNSPECIFIED macro expects pointer to sin6_addr element instead of s6_addr element. --- src/util/virsocketaddr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virsocketaddr.c b/src/util/virsocketaddr.c ind

[libvirt] [PATCH] remote: Forbid default "/session" connections when using ssh transport

Without the socket path explicitly specified, the remote driver tried to connect to the "/system" instance socket even if "/session" was specified in the uri. With this patch this configuration now produces an error. It is still possible to initiate a session connection with specifying the path to

[libvirt] [PATCH v3] selinux: assume 's0' if the range is empty

This fixes a crash: https://bugzilla.redhat.com/show_bug.cgi?id=969878 --- v3: rewrote the patch to assume 's0' if the range is empty, instead of reporting an error v2: https://www.redhat.com/archives/libvir-list/2013-June/msg00082.html src/security/security_selinux.c | 9 +++-- tests/securi

[libvirt] [PATCH] virSocketAddrIsWildcard: Use IN6_IS_ADDR_UNSPECIFIED correctly

The IN6_IS_ADDR_UNSPECIFIED macro expects pointer to sin6_addr element instead of s6_addr element. --- src/util/virsocketaddr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virsocketaddr.c b/src/util/virsocketaddr.c index e84c58e..2666574 100644 --- a/src/util/virso

Re: [libvirt] [PATCH 0/6] Support to use iscsi storage in domain conf

On 10/06/13 13:34, Osier Yang wrote: Sorry for the duplication, I don't know why the git send-email hanged there and produced these duplications. I meant to post the series. This supports to use libvirt iscsi storage volume for qemu with either the LUN's path on host (e.g. /dev/disk/by-path/*-l

[libvirt] [PATCH 6/7] Add qcow2 features support to snapshots

--- docs/schemas/domainsnapshot.rng | 7 +++ src/conf/snapshot_conf.c | 74 src/conf/snapshot_conf.h | 2 + tests/domainsnapshotxml2xmlin/disk_snapshot.xml | 5 ++ tests/domainsnapshotxml2xmlout/disk_snap

[libvirt] [PATCH 3/7] conf: add features to volume target XML

Add and elements to volume target XML. is a string which for qcow2 represents the QEMU version it should be compatible with. Valid values are 0.10 and 1.1. 1.1 is implicit if the element is present, otherwise qemu-img default is used. 0.10 can be specified to explicitly create older images aft

[libvirt] [PATCH 1/7] storage: rework qemu-img command line generation

Split out option string generation to make adding new options easier and simplify the code. --- src/storage/storage_backend.c | 111 ++ 1 file changed, 59 insertions(+), 52 deletions(-) diff --git a/src/storage/storage_backend.c b/src/storage/storage_backen

[libvirt] [PATCH 7/7] qemu: add qcow2 extension support to inactive external snapshots

For live external snapshots, the image creation is done by QEMU and we can't pass the needed options. --- docs/formatsnapshot.html.in | 5 src/qemu/qemu_driver.c | 72 +++-- 2 files changed, 62 insertions(+), 15 deletions(-) diff --git a/docs/for

[libvirt] [PATCH 5/7] conf: split out snapshot disk XML formatting

Just to reduce the indentation levels. Remove the unneeded NULL check for disk->file, as virBufferEscapeString doesn't print anything with NULL arguments. --- src/conf/snapshot_conf.c | 53 ++-- 1 file changed, 29 insertions(+), 24 deletions(-) diff --g

[libvirt] [PATCH 2/7] util: add support for qcow2v3 image detection

Detect qcow2 images with version 3 in the image header as VIR_STORAGE_FILE_QCOW2. These images have a feature bitfield, with just one feature supported so far: lazy_refcounts. The header length changed too, moving the location of the backing format name. --- src/util/virstoragefile.c | 164 +

[libvirt] [PATCH 4/7] storage: add support for creating qcow2 images with extensions

Add -o compat= and -o lazy_refcounts options for qemu-img. --- src/storage/storage_backend.c | 36 +++-- tests/storagevolxml2argvdata/qcow2-1.1.argv | 1 + tests/storagevolxml2argvdata/qcow2-lazy.argv| 1 + tests/storagevolxml2argvdata/vol-qcow2-1.1.

[libvirt] [PATCH v4 0/7] Add qcow2 extensions support

Since QEMU 1.1 qcow2 supports a features bitfield, allowing to implement additional features without breaking compatibility with older QEMU versions. The version header on-disk is bumped to 3, however the format name is still 'qcow2', not 'qcow3' (which is what I used in v2). v4: rebased v3: http

Re: [libvirt] [PATCH] virSocketAddrIsWildcard: Drop IN6_IS_ADDR_UNSPECIFIED

On 10.06.2013 13:51, Michele Paolino wrote: > Hi Michal, > > The IN6_IS_ADDR_UNSPECIFIED() function needs a struct in6_addr as > argument. So changing the line in this way: > > -return > IN6_IS_ADDR_UNSPECIFIED(&addr->data.inet6.sin6_addr.s6_addr); > +return IN6_IS_ADDR_UNSPECIFIE

Re: [libvirt] [PATCH] virSocketAddrIsWildcard: Drop IN6_IS_ADDR_UNSPECIFIED

Hi Michal, The IN6_IS_ADDR_UNSPECIFIED() function needs a struct in6_addr as argument. So changing the line in this way: -return IN6_IS_ADDR_UNSPECIFIED(&addr->data.inet6.sin6_addr.s6_addr); +return IN6_IS_ADDR_UNSPECIFIED(&addr->data.inet6.sin6_addr); it should work. Regards,

[libvirt] [PATCH] virSocketAddrIsWildcard: Drop IN6_IS_ADDR_UNSPECIFIED

There's this macro IN6_IS_ADDR_UNSPECIFIED which seems to be portable, but it is not. On other architectures many errors are produced, e.g. on my ARM box I get: CC libvirt_util_la-virsocketaddr.lo util/virsocketaddr.c: In function 'virSocketAddrIsWildcard': util/virsocketaddr.c:244:16: err

Re: [libvirt] [PATCH] storage: Small file probing fixup

On 06/10/2013 11:25 AM, Peter Krempa wrote: > On 06/10/13 09:58, Martin Kletzander wrote: >> Fallback to possible storage format after nothing else than magic has >> matched, since this is likely theformat user wants even though we >> don't know any better. >> >> Also fix a comment which wasn't ver

Re: [libvirt] [PATCH] storage: Small file probing fixup

On 06/10/13 09:58, Martin Kletzander wrote: Fallback to possible storage format after nothing else than magic has matched, since this is likely theformat user wants even though we don't know any better. Also fix a comment which wasn't very clear about what "skip" meant. Resolves: https://bugzil

Re: [libvirt] [PATCH for v1.0.5-maint] Fix use of VIR_STRDUP vs strdup

- Original Message - > Commit 894f784948a93760629de3cb195c69ef4f4b831f broke the v1.0.5-maint > branch because VIR_STRDUP() didn't exist in the v1.0.5 release so the > resulting build is missing that symbol. > > This patch is only for the v1.0.5-maint branch. > --- > src/qemu/qemu_migrati

Re: [libvirt] [PATCH] Fix commit 29c1e913e459058c12d02b3f4b767b3dd428a498

On 06/07/13 17:31, Michal Privoznik wrote: On 07.06.2013 17:18, Peter Krempa wrote: This patch fixes changes done in commit 29c1e913e459058c12d02b3f4b767b3 that was pushed without implementing review feedback. The flag introduced by the patch is changed to VIR_DOMAIN_VCPU_GUEST and documentatio

[libvirt] [PATCH] storage: Small file probing fixup

Fallback to possible storage format after nothing else than magic has matched, since this is likely theformat user wants even though we don't know any better. Also fix a comment which wasn't very clear about what "skip" meant. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=836676 Signed-o