For BZ 924672 the problem stems from the fact that thin pool logical
volume devices show up in /sbin/lvs output just like normal logical
volumes do. Since the thin pool devices show up libvirt assumes they are
just normal logical volumes and assumes there will be a corresponding
/dev/vgname/lvname
Since the wait is done during migration (still inside
QEMU_ASYNC_JOB_MIGRATION_OUT), the code should enter the monitor as such
in order to prohibit all other jobs from interfering in the meantime.
This patch fixes bug #1009886 in which qemuDomainGetBlockInfo was
waiting on the monitor condition and
On Fri, Sep 20, 2013 at 05:37:58PM +0200, Ján Tomko wrote:
> On 09/20/2013 05:13 PM, Martin Kletzander wrote:
> > Since the wait is done during migration (still inside
> > QEMU_ASYNC_JOB_MIGRATION_OUT), the code should enter the monitor as such
> > in order to prohibit all other jobs from interferi
Add support for VMware Fusion in the existing VMware driver. Connect
via the URI vmwarefusion:///session
---
docs/drvvmware.html.in | 15 +++
src/vmware/vmware_conf.c | 8 +++-
src/vmware/vmware_conf.h | 1 +
src/vmware/vmware_driver.c | 3 +++
4 files changed, 22 inser
Currently the VMware version check code only supports two types of
VMware backends, Workstation and Player. But in the near future we will
have an additional one so we need to support more. Additionally, we
discover and cache the path to the vmrun binary so we should use that
path when using the co
libvirt 0.10.2.8 maintenance release is now available. This is
libvirt 0.10.2 with additional bugfixes that have accumulated
upstream since the initial release.
This release can be downloaded at:
http://libvirt.org/sources/stable_updates/libvirt-0.10.2.8.tar.gz
Changes in this version:
* virsh:
libvirt 1.0.5.6 maintenance release is now available. This is
libvirt 1.0.5 with additional bugfixes that have accumulated
upstream since the initial release.
This release can be downloaded at:
http://libvirt.org/sources/stable_updates/libvirt-1.0.5.6.tar.gz
Changes in this version:
* virsh: fi
On 09/20/2013 05:13 PM, Martin Kletzander wrote:
> Since the wait is done during migration (still inside
> QEMU_ASYNC_JOB_MIGRATION_OUT), the code should enter the monitor as such
> in order to prohibit all other jobs from interfering in the meantime.
> This patch fixes bug #1009886 in which qemuDo
On Fri, Sep 20, 2013 at 08:41:54AM -0600, Eric Blake wrote:
> On 09/20/2013 08:16 AM, Jiri Denemark wrote:
>
> >> +++ b/docs/Makefile.am
> >> @@ -242,6 +242,7 @@ internals/%.html.tmp: internals/%.html.in subsite.xsl
> >> page.xsl sitemap.html.in
> >> html/index.html: libvirt-api.xml newapi.xsl p
On Fri, Sep 20, 2013 at 10:15:30AM -0400, Laine Stump wrote:
> On 09/20/2013 09:33 AM, Daniel P. Berrange wrote:
> > On Fri, Sep 20, 2013 at 06:25:10AM -0400, Laine Stump wrote:
> >> This resolves https://bugzilla.redhat.com/show_bug.cgi?id=1008903
> >>
> >> The Q35 machinetype has an implicit SATA
On Fri, Sep 20, 2013 at 04:16:51PM +0200, Jiri Denemark wrote:
> On Fri, Sep 20, 2013 at 16:13:54 +0200, Jiri Denemark wrote:
> > The xml files are generated in build directory and thus docs/newapi.xsl
> > was not able to find them in a VPATH build.
> >
> > Signed-off-by: Jiri Denemark
> > ---
>
On 09/20/2013 08:13 AM, Jiri Denemark wrote:
> The xml files are generated in build directory and thus docs/newapi.xsl
> was not able to find them in a VPATH build.
>
> Signed-off-by: Jiri Denemark
> ---
> docs/Makefile.am | 1 +
> docs/newapi.xsl | 8 +---
> 2 files changed, 6 insertions(+
On 09/20/2013 08:16 AM, Jiri Denemark wrote:
>> +++ b/docs/Makefile.am
>> @@ -242,6 +242,7 @@ internals/%.html.tmp: internals/%.html.in subsite.xsl
>> page.xsl sitemap.html.in
>> html/index.html: libvirt-api.xml newapi.xsl page.xsl sitemap.html.in
>> $(AM_V_GEN)if [ -x $(XSLTPROC) ] ; then
On Fri, Sep 20, 2013 at 04:35:12PM +0200, Gerd Hoffmann wrote:
> Hi,
>
> > 1) Every SATA controller has 6 buses, and each bus allows a single
> > target (or "unit").
>
> That is how it is modeled in qemu, largely due to reusing the ide code.
>
> On real hardware you have a sata controller with
On 09/20/2013 08:15 AM, Laine Stump wrote:
>
> This will leave one problem - what to do if someone migrates a guest
> with the new non-0 unit# to a host that's still running old libvirt that
> ignores unit#. I don't see how to get around this problem without having
> knowledge of the source and
Hi,
> 1) Every SATA controller has 6 buses, and each bus allows a single
> target (or "unit").
That is how it is modeled in qemu, largely due to reusing the ide code.
On real hardware you have a sata controller with a number of ports
(happens to be 6 for the one emulated by qemu, but that may
On Fri, Sep 20, 2013 at 16:13:54 +0200, Jiri Denemark wrote:
> The xml files are generated in build directory and thus docs/newapi.xsl
> was not able to find them in a VPATH build.
>
> Signed-off-by: Jiri Denemark
> ---
> docs/Makefile.am | 1 +
> docs/newapi.xsl | 8 +---
> 2 files changed
On 09/20/2013 09:33 AM, Daniel P. Berrange wrote:
> On Fri, Sep 20, 2013 at 06:25:10AM -0400, Laine Stump wrote:
>> This resolves https://bugzilla.redhat.com/show_bug.cgi?id=1008903
>>
>> The Q35 machinetype has an implicit SATA controller at 00:1F.2 which
>> isn't given the "expected" id of ahci0
The xml files are generated in build directory and thus docs/newapi.xsl
was not able to find them in a VPATH build.
Signed-off-by: Jiri Denemark
---
docs/Makefile.am | 1 +
docs/newapi.xsl | 8 +---
2 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/docs/Makefile.am b/docs/Makef
On 09/20/2013 07:05 AM, Peter Krempa wrote:
> The ABI compatibility check for domain features didn't check the
> expanded HyperV and APIC EOI values, thus possibly allowing change in
> guest ABI.
>
> Add the check and use typecasted switch statement to warn developers
> when adding a new HyperV fe
On Fri, Sep 20, 2013 at 06:25:10AM -0400, Laine Stump wrote:
> This resolves https://bugzilla.redhat.com/show_bug.cgi?id=1008903
>
> The Q35 machinetype has an implicit SATA controller at 00:1F.2 which
> isn't given the "expected" id of ahci0 by qemu when it's created. The
> original suggested sol
The ABI compatibility check for domain features didn't check the
expanded HyperV and APIC EOI values, thus possibly allowing change in
guest ABI.
Add the check and use typecasted switch statement to warn developers
when adding a new HyperV feature.
---
src/conf/domain_conf.c | 72
On Fri, Sep 20, 2013 at 13:16:06 +0100, Daniel Berrange wrote:
> On Fri, Sep 20, 2013 at 11:50:57AM +0200, Jiri Denemark wrote:
> > Technically, these files should be generated in build dir but since
> > docs/newapi.xsl style sheet is expecting them to be in source dir, it's
> > much easier to put
On Fri, Sep 20, 2013 at 11:50:57AM +0200, Jiri Denemark wrote:
> Technically, these files should be generated in build dir but since
> docs/newapi.xsl style sheet is expecting them to be in source dir, it's
> much easier to put them there than trying to convince newapi.xsl to look
> elsewhere.
It
On Fri, Sep 20, 2013 at 06:00:31AM -0600, Eric Blake wrote:
> On 09/20/2013 03:50 AM, Jiri Denemark wrote:
> > Technically, these files should be generated in build dir but since
> > docs/newapi.xsl style sheet is expecting them to be in source dir, it's
> > much easier to put them there than tryin
On Fri, Sep 20, 2013 at 5:18 AM, Daniel P. Berrange wrote:
> On Thu, Sep 19, 2013 at 11:34:15PM -0400, Dusty Mabe wrote:
>>
>> I'm sure the fix isn't this trivial but i can finish it up and submit
>> an official patch (through git) if this is close.
>
> Do we really want to hide thin volumes. Unle
On 09/20/2013 03:50 AM, Jiri Denemark wrote:
> Technically, these files should be generated in build dir but since
> docs/newapi.xsl style sheet is expecting them to be in source dir, it's
> much easier to put them there than trying to convince newapi.xsl to look
> elsewhere.
>
> Signed-off-by: Ji
On Fri, Sep 20, 2013 at 11:06:59AM +0200, Peter Krempa wrote:
> Check the presence of the selected PCI passthrough option when starting
> a VM.
> ---
> src/qemu/qemu_process.c | 41 +
> 1 file changed, 41 insertions(+)
>
> diff --git a/src/qemu/qemu_process
On Fri, Sep 20, 2013 at 11:07:00AM +0200, Peter Krempa wrote:
> Prefer using VFIO (if available) to the legacy KVM device passthrough.
>
> With this patch a PCI passthrough device without the driver configured
> will be started with VFIO if it's available on the host. If not legacy
> KVM passthrou
On 09/20/2013 07:47 AM, Ján Tomko wrote:
> In case of an error, qemuMonitorTestNewSimple returns NULL.
> Error out instead of dereferencing it.
>
> Found by Coverity, reported by John Ferlan.
> ---
> Pushed as trivial.
>
> tests/qemumonitorjsontest.c | 6 ++
> 1 file changed, 6 insertions(+)
On 09/20/2013 12:32 PM, John Ferlan wrote:
> On 09/18/2013 12:16 PM, Michal Privoznik wrote:
>> static int
>> +testQemuMonitorJSONSimpleFunc(const void *opaque)
>> +{
>> +const testQemuMonitorJSONSimpleFuncDataPtr data = (const
>> testQemuMonitorJSONSimpleFuncDataPtr) opaque;
>> +virDomai
In case of an error, qemuMonitorTestNewSimple returns NULL.
Error out instead of dereferencing it.
Found by Coverity, reported by John Ferlan.
---
Pushed as trivial.
tests/qemumonitorjsontest.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/tests/qemumonitorjsontest.c b/tests/qemumoni
On 09/20/2013 06:48 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange"
>
> Coverity complains that the test suite did not check the
> return value of dbus_message_iter_append_basic() as we did
> in most other places.
>
> Signed-off-by: Daniel P. Berrange
> ---
> tests/virsystemdmock.c
From: "Daniel P. Berrange"
Coverity complains that the test suite did not check the
return value of dbus_message_iter_append_basic() as we did
in most other places.
Signed-off-by: Daniel P. Berrange
---
tests/virsystemdmock.c | 24 ++--
1 file changed, 14 insertions(+), 10
On 09/20/2013 12:25 PM, Laine Stump wrote:
> This resolves https://bugzilla.redhat.com/show_bug.cgi?id=1008903
>
> The Q35 machinetype has an implicit SATA controller at 00:1F.2 which
> isn't given the "expected" id of ahci0 by qemu when it's created. The
> original suggested solution to this prob
On Thu, Sep 19, 2013 at 11:26:08PM +0900, Yuto KAWAMURA(kawamuray) wrote:
> diff --git a/tools/wireshark/src/moduleinfo.h
> b/tools/wireshark/src/moduleinfo.h
> new file mode 100644
> index 000..9ab642c
> --- /dev/null
> +++ b/tools/wireshark/src/moduleinfo.h
> @@ -0,0 +1,37 @@
> +/* moduleinf
On 09/18/2013 12:16 PM, Michal Privoznik wrote:
> This macro is there to test the simplest monitor functions we have,
> those in the form of: int ( *func) (qemuMonitorPtr). So far, we have
> seven such functions.
>
> Signed-off-by: Michal Privoznik
> ---
> tests/qemumonitorjsontest.c | 47
> +++
On 09/18/2013 12:16 PM, Michal Privoznik wrote:
> Signed-off-by: Michal Privoznik
> ---
> tests/qemumonitorjsontest.c | 56
> +
> 1 file changed, 56 insertions(+)
>
> diff --git a/tests/qemumonitorjsontest.c b/tests/qemumonitorjsontest.c
> index b2877
This resolves https://bugzilla.redhat.com/show_bug.cgi?id=1008903
The Q35 machinetype has an implicit SATA controller at 00:1F.2 which
isn't given the "expected" id of ahci0 by qemu when it's created. The
original suggested solution to this problem was to not specify any
controller for the disks t
On Thu, Sep 19, 2013 at 03:18:07PM -0500, Doug Goldstein wrote:
> This splits up the version parsing code into a callable API like QEMU
> help/version string parsing so that we can test it as we need to add
> additional patterns for newer versions/products.
> ---
> .gitignore
On Thu, Sep 19, 2013 at 03:18:06PM -0500, Doug Goldstein wrote:
> Rather than looking up the path to vmrun each time we call it, look it
> up once and save it. This sets up the ability for us to detect where the
> path is on Mac OS X and not have to look it up each time we execute it.
> ---
> src/
On Thu, Sep 19, 2013 at 03:18:05PM -0500, Doug Goldstein wrote:
> The VMware driver supports multiple backends for the VMware Player and
> VMware Workstation, convert this logic into enum and use VIR_ENUM_IMPL()
> to provide conversions to and from strings.
> ---
> src/vmware/vmware_conf.c | 11
Technically, these files should be generated in build dir but since
docs/newapi.xsl style sheet is expecting them to be in source dir, it's
much easier to put them there than trying to convince newapi.xsl to look
elsewhere.
Signed-off-by: Jiri Denemark
---
src/Makefile.am | 12 ++--
1 fi
On Thu, Sep 19, 2013 at 14:43:23 -0600, Eric Blake wrote:
> On 09/19/2013 06:59 AM, Jiri Denemark wrote:
> > Signed-off-by: Jiri Denemark
> > ---
> > daemon/remote.c | 27 +++
> > 1 file changed, 15 insertions(+), 12 deletions(-)
>
> Reviewed-by: Eric Blake
:-) pushed,
On Thu, Sep 19, 2013 at 11:34:15PM -0400, Dusty Mabe wrote:
> Hey guys,
>
> Just looking at https://bugzilla.redhat.com/show_bug.cgi?id=924672 and
> looks like all we need to do is ignore thin pools and thin pool data
> devices. With some trivial testing this seems to work fine (i.e.
> failed befo
Use the checking functions to verify that the host supports PCI
passthrough before attempting it.
---
src/qemu/qemu_hotplug.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c
index 728c734..9320ab9 100644
--- a/src/qemu/qemu_hotp
To simplify future patches dealing with this code, simplify and refactor
some conditions to switch statements.
---
src/qemu/qemu_command.c | 27 ++-
src/qemu/qemu_hotplug.c | 27 ---
2 files changed, 34 insertions(+), 20 deletions(-)
diff --git a/sr
Add code that will be used to check availability of PCI passhthrough
using VFIO and the legacy KVM passthrough. These will be later used to
determine the preferred passthrough option.
---
src/qemu/qemu_hostdev.c | 76 +
src/qemu/qemu_hostdev.h | 3 +
Prefer using VFIO (if available) to the legacy KVM device passthrough.
With this patch a PCI passthrough device without the driver configured
will be started with VFIO if it's available on the host. If not legacy
KVM passthrough is checked and error is reported if it's not available.
---
docs/for
Change the default type to VFIO if available.
Please note that the majority of the code here is only compile tested as
I don't have appropriate hardware to test it.
Peter Krempa (5):
qemu: hostdev: Refactor PCI passhrough handling
qemu: hostdev: Add checks if PCI passthrough is availabe in th
Check the presence of the selected PCI passthrough option when starting
a VM.
---
src/qemu/qemu_process.c | 41 +
1 file changed, 41 insertions(+)
diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
index dd16f6c..e36ab99 100644
--- a/src/qemu/qe
That release fixes the java-6 compatibility problem of the 0.5.0 build.
It is tagged in git and available at the usual place:
ftp://libvirt.org/libvirt/java/
as well as in the maven repository for libvirt-java at
http://libvirt.org/maven2/org/libvirt/libvirt/
Thanks Wido and Claudio for f
Hi experts:
When I did some test, I was puzzled by one thing: When I use "virsh
update-device" to update
floppy device, always got an error message, "error: internal error
unable to execute QEMU command
'change': Could not open'***file':Permission denied".But when I execute
command "setenforce
If we want to stick to the end of the month schedule we need to
enter freeze for 1.1.3 next week, I suggest to do this early on Wed 25
so that we can plan on pushing 1.1.3 on the Tue 1st Oct
So unless there is a serious issue, let's plan to freeze next Wed,
Daniel
--
Daniel Veillard | O
54 matches
Mail list logo
