Tagged in git, and pushed as tarballs and rpms to the usual place:
ftp://libvirt.org/libvirt/
Seems to work correctly for me, if everything goes well I will push
1.1.4 final on Monday
Please give it a try,
thanks !
Daniel
--
Daniel Veillard | Open Source and Standards, Red Ha
Eric Blake wrote:
> On 10/31/2013 06:23 PM, Jim Fehlig wrote:
>
>
>>> + for (i = 0; i < virBitmapSize(cpumask); ++i) {
>>> + bool bit;
>>> + if (virBitmapGetBit(cpumask, i, &bit) < 0) {
>>> + virReportError(VIR_ERR_INTERNAL_ERROR,
>>> + _("Failed to get cpumask bit '%zd' with
>>> libxenlight"),
On 10/31/2013 06:23 PM, Jim Fehlig wrote:
>> + for (i = 0; i < virBitmapSize(cpumask); ++i) {
>> + bool bit;
>> + if (virBitmapGetBit(cpumask, i, &bit) < 0) {
>> + virReportError(VIR_ERR_INTERNAL_ERROR,
>> + _("Failed to get cpumask bit '%zd' with
>> libxenlight"), i);
>
> I don't think that is t
On 10/31/2013 05:23 PM, Jim Fehlig wrote:
> Jeremy Fitzhardinge wrote:
>> On 10/24/2013 02:52 AM, Martin Kletzander wrote:
>>> On Wed, Oct 23, 2013 at 10:46:14AM -0700, Jeremy Fitzhardinge wrote:
Hi all,
I posted this bug (https://bugzilla.redhat.com/show_bug.cgi?id=1013045)
to
I found the poll in virEventPollRunOnce (vireventpoll.c), a POLLHUP event
occurred for a pipe descriptor, thus the poll always returned because of
it.( the pipe broken). this may be the best I could track temporarily，I
don't know what to do netx , to mask the hangup event or to do something to
ha
On Thu, Oct 31, 2013 at 7:13 PM, Ryan Schmidt
wrote:
>
> libvirt 1.1.3 doesn't compile on OS X 10.9 Mavericks. A bug report has
> already been filed, but I was asked to write to this mailing list to bring
> the matter to your attention.
>
> https://bugzilla.redhat.com/show_bug.cgi?id=1023860
>
> I
Jeremy Fitzhardinge wrote:
> On 10/30/2013 12:04 PM, Eric Blake wrote:
>
>> On 10/30/2013 01:00 PM, Jeremy Fitzhardinge wrote:
>>
>>> On 10/30/2013 11:37 AM, Eric Blake wrote:
>>>
On 10/30/2013 11:38 AM, Jeremy Fitzhardinge wrote:
> libxl: fix dubious cpuma
Jeremy Fitzhardinge wrote:
> On 10/24/2013 02:52 AM, Martin Kletzander wrote:
> > On Wed, Oct 23, 2013 at 10:46:14AM -0700, Jeremy Fitzhardinge wrote:
> >> Hi all,
> >>
> >> I posted this bug (https://bugzilla.redhat.com/show_bug.cgi?id=1013045)
> >> to the Redhat Bugzilla a while ago, and the only
libvirt 1.1.3 doesn't compile on OS X 10.9 Mavericks. A bug report has
already been filed, but I was asked to write to this mailing list to
bring the matter to your attention.
https://bugzilla.redhat.com/show_bug.cgi?id=1023860
In that bug report it mentions that this was fixed, however th
On 10/30/2013 05:30 PM, Eric Blake wrote:
> Actually put gfapi to use, by allowing the creation of a gluster
> pool. Right now, all volumes are treated as raw; further patches
> will allow peering into files to allow for qcow2 files and backing
> chains, and reporting proper volume allocation.
>
On Thu, Oct 31, 2013 at 09:20:16AM +, Daniel P. Berrange wrote:
> >
>
> I believe you *can* update a filter while it is in use. NWFilter will
> build the new ruleset, then switch over to it atomically.
Thanks, I was not aware that one code re-define an existing nwfilter.
Dan.
--
libvir-lis
This will properly lock libvirt's usage of iptables with
others (like ufw).
(See https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/1245322)
Signed-off-by: Serge Hallyn
---
src/util/viriptables.c | 30 ++
1 file changed, 26 insertions(+), 4 deletions(-)
diff --g
On 10/31/2013 01:00 PM, Eric Blake wrote:
> On 10/31/2013 12:41 PM, Daniel P. Berrange wrote:
>> From: "Daniel P. Berrange"
>>
>> When starting a transient VM the first thing done is to check
>> for duplicates. The check looks if there are any running VMs
>> with the matching name/uuid. It explici
On 10/31/2013 12:41 PM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange"
>
> When starting a transient VM the first thing done is to check
> for duplicates. The check looks if there are any running VMs
> with the matching name/uuid. It explicitly allows there to
> be inactive VMs, so that a
On Thu, Oct 31, 2013 at 12:17:54PM -0600, Eric Blake wrote:
> On 10/31/2013 12:09 PM, Daniel P. Berrange wrote:
>
> >
> > If were made to require a storage pool in order
> > to use it, that would be a regression in functionality IMHO. This setup
> > should be completely independant of the stora
On 10/31/2013 12:34 PM, Daniel P. Berrange wrote:
>
> IIUC, this is still going to be introducing a direct code path dependancy
> between the QEMU and storage driver code though.
No, src/qemu would still get backing chain details via src/util, the way
it has always done. Only src/util has to ha
From: "Daniel P. Berrange"
When starting a transient VM the first thing done is to check
for duplicates. The check looks if there are any running VMs
with the matching name/uuid. It explicitly allows there to
be inactive VMs, so that a persistent VM can be temporarily
booted with a different conf
On 10/31/2013 12:09 PM, Daniel P. Berrange wrote:
>
> If were made to require a storage pool in order
> to use it, that would be a regression in functionality IMHO. This setup
> should be completely independant of the storage driver code. It needs to
> be able to resolve the backing file chain
On Thu, Oct 31, 2013 at 11:58:48AM -0600, Eric Blake wrote:
> On 10/31/2013 11:49 AM, Daniel P. Berrange wrote:
>
> > The QEMU driver should be near 100% functional without needing the
> > storage driver at all. The only dep should be if you use .
> > A should have no dependancy on the storage dr
Il 31/10/2013 18:18, Michael S. Tsirkin ha scritto:
> On Thu, Oct 31, 2013 at 06:10:36PM +0100, Paolo Bonzini wrote:
>> Il 31/10/2013 18:01, Michael S. Tsirkin ha scritto:
Yes, that's what my patch (posted the link before) does:
-{ RUN_STATE_GUEST_PANICKED, RUN_STATE_PAUSED },
>>
On 10/31/2013 11:49 AM, Daniel P. Berrange wrote:
> The QEMU driver should be near 100% functional without needing the
> storage driver at all. The only dep should be if you use .
> A should have no dependancy on the storage driver,
> so we'd need rbd there even if the storage driver was not ther
On Thu, Oct 31, 2013 at 11:43:11AM -0600, Eric Blake wrote:
> On 10/31/2013 11:30 AM, Daniel P. Berrange wrote:
>
> >>
> >> I don't know if that means the libvirt-daemon-driver-storage needs to be
> >> further split into multiple .so files across multiple sub-rpms, so that
> >> a user can pick and
On 10/31/2013 11:30 AM, Daniel P. Berrange wrote:
>>
>> I don't know if that means the libvirt-daemon-driver-storage needs to be
>> further split into multiple .so files across multiple sub-rpms, so that
>> a user can pick and choose which .so backends to install rather than
>> dragging in all dep
On 10/31/2013 09:40 AM, Ján Tomko wrote:
> Also try to bind on IPv6 to check if the port is occupied.
>
> https://bugzilla.redhat.com/show_bug.cgi?id=1025407
> ---
> src/util/virportallocator.c | 45
> ++---
> 1 file changed, 38 insertions(+), 7 deletions(
On Thu, Oct 31, 2013 at 04:40:11PM +0100, Ján Tomko wrote:
> Also try to bind on IPv6 to check if the port is occupied.
>
> https://bugzilla.redhat.com/show_bug.cgi?id=1025407
> ---
> src/util/virportallocator.c | 45
> ++---
> 1 file changed, 38 insertion
On Thu, Oct 31, 2013 at 06:35:56AM -0600, Eric Blake wrote:
> On 10/31/2013 03:23 AM, Daniel P. Berrange wrote:
> >>
> >> My next task - figuring out the use of glfs_open() to read metadata
> >> from a file and determine backing chains.
> >
> > NB, we don't want the src/util code to gain a dependa
On 10/31/2013 09:40 AM, Ján Tomko wrote:
> ---
> src/util/virportallocator.c | 72
> -
> 1 file changed, 45 insertions(+), 27 deletions(-)
Looks larger, but makes later patches possible. ACK.
--
Eric Blake eblake redhat com+1-919-301-3266
Libv
Eric Blake wrote:
> On 10/31/2013 03:23 AM, Daniel P. Berrange wrote:
>
>>> My next task - figuring out the use of glfs_open() to read metadata
>>> from a file and determine backing chains.
>>>
>> NB, we don't want the src/util code to gain a dependancy on glusterfs
>> RPMs. It is a very
On 10/31/2013 09:45 AM, Ryota Ozaki wrote:
> Thie patch fixes the segfault:
> error : nodeStateInitialize:658 : DBus not available,
> disabling HAL driver: internal error: Unable to get DBus
> system bus connection: Failed to connect to socket
> /var/run/dbus/system_bus_socket
On 10/31/2013 10:00 AM, Ján Tomko wrote:
> Instead of using a port from the remote display range.
> ---
> src/qemu/qemu_migration.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
ACK; okay for 1.1.4. Is there a BZ you can mention?
>
> diff --git a/src/qemu/qemu_migration.c b/src/qemu/
On 10/31/2013 06:20 PM, Hongwei Bi wrote:
> The result variable in virNetworkDNSDefFormat() function should be
> initialized to -1 at first,only in this way can we use it properly.
>
> Signed-off-by: Hongwei Bi
> ---
> src/conf/network_conf.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deleti
On Thu, Oct 31, 2013 at 06:10:36PM +0100, Paolo Bonzini wrote:
> Il 31/10/2013 18:01, Michael S. Tsirkin ha scritto:
> > > Yes, that's what my patch (posted the link before) does:
> > >
> > > -{ RUN_STATE_GUEST_PANICKED, RUN_STATE_PAUSED },
> > > +{ RUN_STATE_GUEST_PANICKED, RUN_STATE_RUNN
Il 31/10/2013 18:01, Michael S. Tsirkin ha scritto:
> > Yes, that's what my patch (posted the link before) does:
> >
> > -{ RUN_STATE_GUEST_PANICKED, RUN_STATE_PAUSED },
> > +{ RUN_STATE_GUEST_PANICKED, RUN_STATE_RUNNING },
> > { RUN_STATE_GUEST_PANICKED, RUN_STATE_FINISH_MIGRATE },
>
Il 31/10/2013 18:00, Michael S. Tsirkin ha scritto:
> Interesting. Why do we have
> -{ RUN_STATE_INTERNAL_ERROR, RUN_STATE_PAUSED },
> then?
It's only for non-resumable states (such as pvpanic right now).
It's used here:
if (qemu_reset_requested()) {
pause_all_vcpus();
c
On Thu, Oct 31, 2013 at 05:38:40PM +0100, Paolo Bonzini wrote:
> Il 31/10/2013 17:26, Michael S. Tsirkin ha scritto:
> > On Thu, Oct 31, 2013 at 05:17:24PM +0100, Paolo Bonzini wrote:
> >> Il 31/10/2013 17:14, Michael S. Tsirkin ha scritto:
> PANICKED->DEBUG was added by commit bc7d0e667. Tha
On Thu, Oct 31, 2013 at 05:52:11PM +0100, Paolo Bonzini wrote:
> Il 31/10/2013 17:48, Michael S. Tsirkin ha scritto:
> > But code duplication is bad.
>
> So should we make a table of IO_ERROR-like states to avoid code
> duplication? You have to draw a line somewhere...
>
> > I think IO error for
Il 31/10/2013 17:48, Michael S. Tsirkin ha scritto:
> But code duplication is bad.
So should we make a table of IO_ERROR-like states to avoid code
duplication? You have to draw a line somewhere...
> I think IO error for example
> is broken in that you can't pause but can run then pause.
> Seems
On Thu, Oct 31, 2013 at 05:38:40PM +0100, Paolo Bonzini wrote:
> Il 31/10/2013 17:26, Michael S. Tsirkin ha scritto:
> > On Thu, Oct 31, 2013 at 05:17:24PM +0100, Paolo Bonzini wrote:
> >> Il 31/10/2013 17:14, Michael S. Tsirkin ha scritto:
> PANICKED->DEBUG was added by commit bc7d0e667. Tha
The result variable in virNetworkDNSDefFormat() function should be
initialized to -1 at first,only in this way can we use it properly.
Signed-off-by: Hongwei Bi
---
src/conf/network_conf.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/conf/network_conf.c b/src/conf/n
Il 31/10/2013 17:26, Michael S. Tsirkin ha scritto:
> On Thu, Oct 31, 2013 at 05:17:24PM +0100, Paolo Bonzini wrote:
>> Il 31/10/2013 17:14, Michael S. Tsirkin ha scritto:
PANICKED->DEBUG was added by commit bc7d0e667. That commit can be
reverted if the panicked state is removed from run
On Thu, Oct 31, 2013 at 05:17:24PM +0100, Paolo Bonzini wrote:
> Il 31/10/2013 17:14, Michael S. Tsirkin ha scritto:
> >> PANICKED->DEBUG was added by commit bc7d0e667. That commit can be
> >> reverted if the panicked state is removed from runstate_needs_reset.
> >
> > Okay so let's drop the code
On Thu, Oct 31, 2013 at 05:17:24PM +0100, Paolo Bonzini wrote:
> Il 31/10/2013 17:14, Michael S. Tsirkin ha scritto:
> >> PANICKED->DEBUG was added by commit bc7d0e667. That commit can be
> >> reverted if the panicked state is removed from runstate_needs_reset.
> >
> > Okay so let's drop the code
Il 31/10/2013 17:14, Michael S. Tsirkin ha scritto:
>> PANICKED->DEBUG was added by commit bc7d0e667. That commit can be
>> reverted if the panicked state is removed from runstate_needs_reset.
>
> Okay so let's drop the code duplication and explicitly make
> them the same?
>
> Signed-off-by: Mic
On Thu, Oct 31, 2013 at 04:56:07PM +0100, Paolo Bonzini wrote:
> Il 31/10/2013 16:45, Michael S. Tsirkin ha scritto:
> > On Thu, Oct 31, 2013 at 04:26:13PM +0100, Paolo Bonzini wrote:
> >> Il 31/10/2013 16:09, Michael S. Tsirkin ha scritto:
> >>> On Thu, Oct 31, 2013 at 03:56:42PM +0100, Paolo Bonz
Instead of using a port from the remote display range.
---
src/qemu/qemu_migration.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c
index cb59620..4f35a7a 100644
--- a/src/qemu/qemu_migration.c
+++ b/src/qemu/qemu_migration
Il 31/10/2013 16:45, Michael S. Tsirkin ha scritto:
> On Thu, Oct 31, 2013 at 04:26:13PM +0100, Paolo Bonzini wrote:
>> Il 31/10/2013 16:09, Michael S. Tsirkin ha scritto:
>>> On Thu, Oct 31, 2013 at 03:56:42PM +0100, Paolo Bonzini wrote:
Il 31/10/2013 15:52, Michael S. Tsirkin ha scritto:
>>>
Thie patch fixes the segfault:
error : nodeStateInitialize:658 : DBus not available,
disabling HAL driver: internal error: Unable to get DBus
system bus connection: Failed to connect to socket
/var/run/dbus/system_bus_socket: No such file or directory
error : nodeStateInit
On Thu, Oct 31, 2013 at 04:26:13PM +0100, Paolo Bonzini wrote:
> Il 31/10/2013 16:09, Michael S. Tsirkin ha scritto:
> > On Thu, Oct 31, 2013 at 03:56:42PM +0100, Paolo Bonzini wrote:
> >> Il 31/10/2013 15:52, Michael S. Tsirkin ha scritto:
> > Yes, it does.
> >>> What does it break exactly?
>
Also try to bind on IPv6 to check if the port is occupied.
https://bugzilla.redhat.com/show_bug.cgi?id=1025407
---
src/util/virportallocator.c | 45 ++---
1 file changed, 38 insertions(+), 7 deletions(-)
diff --git a/src/util/virportallocator.c b/src/util/
---
src/util/virportallocator.c | 72 -
1 file changed, 45 insertions(+), 27 deletions(-)
diff --git a/src/util/virportallocator.c b/src/util/virportallocator.c
index 42e1f28..1922ea6 100644
--- a/src/util/virportallocator.c
+++ b/src/util/virportalloca
This goes on top of:
[PATCH v2 0/2] Report an error in virPortAllocatorAcquire if all ports are used
https://www.redhat.com/archives/libvir-list/2013-October/msg01289.html
v1: Support IPv6 in port allocator
https://www.redhat.com/archives/libvir-list/2013-October/msg7.html
Ján Tomko (2):
Sp
Il 31/10/2013 16:09, Michael S. Tsirkin ha scritto:
> On Thu, Oct 31, 2013 at 03:56:42PM +0100, Paolo Bonzini wrote:
>> Il 31/10/2013 15:52, Michael S. Tsirkin ha scritto:
> Yes, it does.
>>> What does it break exactly?
>>
>> The point of a panicked event is to examine the guest at a particular
On Thu, Oct 31, 2013 at 08:49:08AM -0600, Eric Blake wrote:
> On 10/31/2013 08:47 AM, Michael S. Tsirkin wrote:
>
> >>> if (event & PVPANIC_PANICKED) {
> >>> panicked_mon_event("pause");
> >>> -vm_stop(RUN_STATE_GUEST_PANICKED);
> >>
> >> Don't you still need to halt the gues
On Thu, Oct 31, 2013 at 03:56:42PM +0100, Paolo Bonzini wrote:
> Il 31/10/2013 15:52, Michael S. Tsirkin ha scritto:
> >> > Yes, it does.
> > What does it break exactly?
>
> The point of a panicked event is to examine the guest at a particular
> moment in time (e.g. host-initiated crash dump). If
On 10/31/2013 08:47 AM, Michael S. Tsirkin wrote:
>>> if (event & PVPANIC_PANICKED) {
>>> panicked_mon_event("pause");
>>> -vm_stop(RUN_STATE_GUEST_PANICKED);
>>
>> Don't you still need to halt the guest on a panic event, for management
>> to have a chance to choose what to d
Il 31/10/2013 15:52, Michael S. Tsirkin ha scritto:
>> > Yes, it does.
> What does it break exactly?
The point of a panicked event is to examine the guest at a particular
moment in time (e.g. host-initiated crash dump). If you let the guest
run, it may reboot and prevent you from getting a meanin
On Thu, Oct 31, 2013 at 03:39:17PM +0100, Paolo Bonzini wrote:
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA1
>
> Il 31/10/2013 15:32, Eric Blake ha scritto:
> > On 10/31/2013 08:30 AM, Michael S. Tsirkin wrote:
> >> On Thu, Oct 24, 2013 at 10:39:03AM +0800, Hu Tao wrote:
> >>> Hi All,
> >>>
>
On Thu, Oct 31, 2013 at 08:32:43AM -0600, Eric Blake wrote:
> On 10/31/2013 08:30 AM, Michael S. Tsirkin wrote:
> > On Thu, Oct 24, 2013 at 10:39:03AM +0800, Hu Tao wrote:
> >> Hi All,
> >>
> >> I know it's been a long time since this thread. But qemu 1.7 is
> >> releasing, do you have any consensu
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Il 31/10/2013 15:32, Eric Blake ha scritto:
> On 10/31/2013 08:30 AM, Michael S. Tsirkin wrote:
>> On Thu, Oct 24, 2013 at 10:39:03AM +0800, Hu Tao wrote:
>>> Hi All,
>>>
>>> I know it's been a long time since this thread. But qemu 1.7 is
>>> releasin
On 10/31/2013 07:26 AM, Martin Kletzander wrote:
>>> root@freebsd9:/home/jenkins/workspace/libvirt/platform/freebsd-9/gnulib/tests
>>> # ./test-poll
>>> Unconnected socket test... passed
>>> Connected sockets test... failed (expecting POLLHUP after shutdown)
>>> General socket test with fork... fa
On Thu, Oct 31, 2013 at 3:32 PM, Eric Blake wrote:
> On 10/31/2013 08:30 AM, Michael S. Tsirkin wrote:
>> On Thu, Oct 24, 2013 at 10:39:03AM +0800, Hu Tao wrote:
>>> Hi All,
>>>
>>> I know it's been a long time since this thread. But qemu 1.7 is
>>> releasing, do you have any consensus on this?
>>
On 10/31/2013 08:30 AM, Michael S. Tsirkin wrote:
> On Thu, Oct 24, 2013 at 10:39:03AM +0800, Hu Tao wrote:
>> Hi All,
>>
>> I know it's been a long time since this thread. But qemu 1.7 is
>> releasing, do you have any consensus on this?
>>
>> Thanks.
>
>
> I think the biggest issue is the new PA
On Thu, Oct 31, 2013 at 10:23:25AM -0400, Cole Robinson wrote:
> On 10/29/2013 11:22 AM, Cole Robinson wrote:
> > On 10/29/2013 10:25 AM, Daniel P. Berrange wrote:
> >> On Mon, Oct 28, 2013 at 01:22:39PM -0400, Cole Robinson wrote:
> >>> On 10/28/2013 01:14 PM, Daniel P. Berrange wrote:
> On M
On Thu, Oct 24, 2013 at 10:39:03AM +0800, Hu Tao wrote:
> Hi All,
>
> I know it's been a long time since this thread. But qemu 1.7 is
> releasing, do you have any consensus on this?
>
> Thanks.
I think the biggest issue is the new PANICKED state.
Guests already have simple ways to halt the CPU,
On Wed, Oct 30, 2013 at 02:17:32PM -0700, Ian Main wrote:
> On Wed, Oct 30, 2013 at 10:52:19AM +0100, Christophe Fergeau wrote:
> > ACK
> >
> > Do you have push access to libvirt git repos?
>
> No I do not.
I've pushed this for you, though I had to squash
diff --git a/libvirt-gconfig/libvirt-gco
On 10/29/2013 11:22 AM, Cole Robinson wrote:
> On 10/29/2013 10:25 AM, Daniel P. Berrange wrote:
>> On Mon, Oct 28, 2013 at 01:22:39PM -0400, Cole Robinson wrote:
>>> On 10/28/2013 01:14 PM, Daniel P. Berrange wrote:
On Mon, Oct 28, 2013 at 01:08:45PM -0400, Cole Robinson wrote:
> On 10/28
On Wed, Oct 23, 2013 at 02:20:17AM +0800, Hongwei Bi wrote:
>
> fix the if statement coding stype
>
s/stype/style/
both here and in the subject.
> Signed-off-by: Hongwei Bi
> ---
> src/xenapi/xenapi_driver.c | 63
> ++
> 1 file changed, 42 insertio
On Tue, Oct 29, 2013 at 02:12:00PM -0600, Eric Blake wrote:
> [adding bug-gnulib]
>
> On 10/29/2013 11:15 AM, Martin Kletzander wrote:
> > On Mon, Oct 28, 2013 at 03:50:20PM -0600, Eric Blake wrote:
> >> Since we haven't quite frozen yet, it's time to pick up some
> >> fixes. I know at least cygw
On 10/31/2013 05:29 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange"
>
> In debugging a recent oVirt/libvirt race condition, I was very
> frustrated by lack of logging in the job enter/exit code. This
> patch adds some key data which would have been useful in by
> debugging attempts.
>
On 10/31/2013 05:29 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange"
>
> Include reference of the VM object pointer and name in debug
> logs for QEMU start/stop functions. Also make sure we log the
> PID that we started, since it isn't available elsewhere in the
> logs.
>
> Signed-off-
On 10/31/2013 01:48 AM, Osier Yang wrote:
> On 31/10/13 05:43, Eric Blake wrote:
>> Using size_t counts will let us use VIR_APPEND_ELEMENT and friends.
>>
>> * src/conf/storage_conf.h (_virStoragePoolObjList)
>> (_virStorageVolDefList): Track list sizes with size_t.
>> * src/storage/storage_backend
On 10/31/2013 03:23 AM, Daniel P. Berrange wrote:
>>
>> My next task - figuring out the use of glfs_open() to read metadata
>> from a file and determine backing chains.
>
> NB, we don't want the src/util code to gain a dependancy on glusterfs
> RPMs. It is a very heavy weight package chain which c
Report the error in virPortAllocatorAcquire instead
of doing it in every caller.
The error contains the port range name instead of the intended
use for the port, e.g.:
Unable to find an unused port in range 'display' (65534-65535)
instead of:
Unable to find an unused port for SPICE
This also adds
This allows its error messages to be more specific.
---
src/libxl/libxl_driver.c | 3 ++-
src/qemu/qemu_driver.c | 9 ++---
src/util/virportallocator.c | 9 +++--
src/util/virportallocator.h | 3 ++-
tests/virportallocatortest.c | 4 ++--
5 files changed, 19 insertions(+), 9 de
v1: Properly check the return value of virPortAllocatorAcquire
https://www.redhat.com/archives/libvir-list/2013-October/msg01239.html
v2: Moves the error reporting inside virPortAllocatorAcquire
Ján Tomko (2):
Add a name to virPortAllocator
Return -1 in virPortAllocatorAcquire if all ports ar
From: "Daniel P. Berrange"
In debugging a recent oVirt/libvirt race condition, I was very
frustrated by lack of logging in the job enter/exit code. This
patch adds some key data which would have been useful in by
debugging attempts.
Signed-off-by: Daniel P. Berrange
---
src/qemu/qemu_domain.c
From: "Daniel P. Berrange"
Include reference of the VM object pointer and name in debug
logs for QEMU start/stop functions. Also make sure we log the
PID that we started, since it isn't available elsewhere in the
logs.
Signed-off-by: Daniel P. Berrange
---
src/qemu/qemu_process.c | 33
This just introduces the test for bug fixed in the previous patch.
Signed-off-by: Michal Privoznik
---
tests/virpcitest.c | 30 ++
1 file changed, 26 insertions(+), 4 deletions(-)
diff --git a/tests/virpcitest.c b/tests/virpcitest.c
index 8811add..5fb35ce 100644
---
The 4/5 is actually fix for a bug,
Michal Privoznik (5):
tests: Introduce virpcitest
virpcitest: Test virPCIDeviceDetach
virpcitest: Introduce testVirPCIDeviceReattach
virpci: Don't error on not binded devices
virpcitest: Introduce check for unbinded devices
.gitignore | 1 +
If a PCI deivce is not binded to any driver (e.g. there's yet no PCI
driver in the linux kernel) but still users want to passthru the device
we fail the whole operation as we fail to resolve the 'driver' link
under the PCI device sysfs tree. Obviously, this is not a fatal error
and it shouldn't be
Among with this test introduce virpcimock as we need to mock some
syscalls, e.g. redirect open() of a file under /sys/bus/pci to a
stub sysfs tree.
Signed-off-by: Michal Privoznik
---
.gitignore | 1 +
cfg.mk | 2 +-
tests/Makefile.am | 13 +++
tests/virpcimock.c | 312
This test will reattach the PCI device detached in the previous test.
Signed-off-by: Michal Privoznik
---
tests/virpcitest.c | 37 +
1 file changed, 37 insertions(+)
diff --git a/tests/virpcitest.c b/tests/virpcitest.c
index 3eaa469..8811add 100644
--- a/test
This commit introduces yet another test under virpcitest:
virPCIDeviceDetach. However, in order to be able to do this, the
virpcimock needs to be extended to model the kernel behavior on PCI
device binding and unbinding (create 'driver' symlinks under the device
tree, check for device ID in driver'
CC Kevin, Paolo
On Thu, Oct 31, 2013 at 04:35:43PM +0800, Amos Kong wrote:
> On Thu, Oct 31, 2013 at 04:07:15PM +0800, Osier Yang wrote:
> > CC to Amos.
> >
> > On 30/10/13 16:19, whitearchey wrote:
> > >
> > >In QEMU 1.6 parameters of 'drive' option were removed:
> > >
> > >QemuOptsList qemu_dri
On Wed, Oct 30, 2013 at 05:30:27PM -0600, Eric Blake wrote:
> Actually put gfapi to use, by allowing the creation of a gluster
> pool. Right now, all volumes are treated as raw; further patches
> will allow peering into files to allow for qcow2 files and backing
> chains, and reporting proper volu
On Wed, Oct 30, 2013 at 09:33:51PM +, Dan Kenigsberg wrote:
> On Wed, Oct 30, 2013 at 10:13:28AM +, Daniel P. Berrange wrote:
> > On Wed, Oct 30, 2013 at 11:57:16AM +0200, Laine Stump wrote:
> > > On 10/29/2013 06:33 PM, Dan Kenigsberg wrote:
> > > > I'd like oVirt to make a more extensive
On 10/30/2013 04:46 PM, Lucas Brasilino wrote:
> Laine Stump wrote:
>> AFAIK, virt-install has no method of specifying the
>> parameters for an interface. What you're asking for here is an interface
>> definition of:
> Yes, up to version 0.10. there's not.
>
>> As long as the OVS service is runnin
On Thu, Oct 31, 2013 at 04:07:15PM +0800, Osier Yang wrote:
> CC to Amos.
>
> On 30/10/13 16:19, whitearchey wrote:
> >
> >In QEMU 1.6 parameters of 'drive' option were removed:
> >
> >QemuOptsList qemu_drive_opts = {
> >.name = "drive",
> >.head = QTAILQ_HEAD_INITIALIZER(qemu_drive_opts.h
CC to Amos.
On 30/10/13 16:19, whitearchey wrote:
In QEMU 1.6 parameters of 'drive' option were removed:
QemuOptsList qemu_drive_opts = {
.name = "drive",
.head = QTAILQ_HEAD_INITIALIZER(qemu_drive_opts.head),
.desc = {
/*
* no elements => accept any params
On 31/10/13 05:43, Eric Blake wrote:
Using size_t counts will let us use VIR_APPEND_ELEMENT and friends.
* src/conf/storage_conf.h (_virStoragePoolObjList)
(_virStorageVolDefList): Track list sizes with size_t.
* src/storage/storage_backend_rbd.c
(virStorageBackendRBDRefreshPool): Fix type fallo
90 matches
Mail list logo
