[libvirt] [PATCH] Fix docs for PMWakeup/PMSuspend callback types

s/is waken up/is woken up/ A registered PMSuspendCallback is called when the domain is suspended, not when it is woken up. Signed-off-by: Claudio Bley --- It's just a trivial fix, but I'd like some educated comment on the grammar fix. IMO it is correct, or is there a better way to express this?

Re: [libvirt] [PATCH 3/6] Make qemuGetDomainTotalCPUStats a virCgroup function.

On 01/15/2014 07:23 AM, Thorsten Behrens wrote: > To reuse this from other drivers, like lxc. > --- > src/libvirt_private.syms | 1 + > src/qemu/qemu_driver.c | 54 > ++-- > src/util/vircgroup.c | 53 ++

Re: [libvirt] [PATCH] lxc: do cleanup when failed to create new string

> -Original Message- > From: Martin Kletzander [mailto:mklet...@redhat.com] > Sent: Wednesday, January 15, 2014 2:36 PM > To: Chen Hanxiao > Cc: libvir-list@redhat.com > Subject: Re: [libvirt] [PATCH] lxc: do cleanup when failed to create new string > > > > > if (virAsprintf(&logfil

Re: [libvirt] [PATCH 1/6] Add util virCgroupGetBlkioIo*Serviced methods.

On 01/15/2014 07:23 AM, Thorsten Behrens wrote: > This reads blkio stats from blkio.throttle.io_service_bytes and > blkio.throttle.io_serviced. > --- > src/libvirt_private.syms | 2 + > src/util/vircgroup.c | 208 > +++ > src/util/vircgroup.h

Re: [libvirt] [PATCH 2/6] Implement domainMemoryStats API slot for LXC driver.

On 01/15/2014 07:23 AM, Thorsten Behrens wrote: > --- > src/lxc/lxc_driver.c | 52 > > 1 file changed, 52 insertions(+) > > diff --git a/src/lxc/lxc_driver.c b/src/lxc/lxc_driver.c > index 7e56a59..9f586af 100644 > --- a/src/lxc/lxc_driver.c >

Re: [libvirt] [PATCH] lxc: do cleanup when failed to create new string

On Wed, Jan 15, 2014 at 09:47:53AM +0800, Chen Hanxiao wrote: > > > > -Original Message- > > From: Martin Kletzander [mailto:mklet...@redhat.com] > > Sent: Tuesday, January 14, 2014 9:24 PM > > To: Chen Hanxiao > > Cc: libvir-list@redhat.com > > Subject: Re: [libvirt] [PATCH] lxc: do cleanu

Re: [libvirt] [PATCH 1/6] Add util virCgroupGetBlkioIo*Serviced methods.

On 01/15/2014 07:23 AM, Thorsten Behrens wrote: > This reads blkio stats from blkio.throttle.io_service_bytes and > blkio.throttle.io_serviced. > --- > src/libvirt_private.syms | 2 + > src/util/vircgroup.c | 208 > +++ > src/util/vircgroup.h

[libvirt] CVE-2014-1447 [was: [PATCH] Really don't crash if a connection closes early]

On 01/13/2014 08:24 AM, Jiri Denemark wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1047577 > > When writing commit 173c291, I missed the fact virNetServerClientClose > unlocks the client object before actually clearing client->sock and thus > it is possible to hit a window when client->kee

Re: [libvirt] [PATCH] lxc: do cleanup when failed to create new string

> -Original Message- > From: Martin Kletzander [mailto:mklet...@redhat.com] > Sent: Tuesday, January 14, 2014 9:24 PM > To: Chen Hanxiao > Cc: libvir-list@redhat.com > Subject: Re: [libvirt] [PATCH] lxc: do cleanup when failed to create new string > > On Tue, Jan 14, 2014 at 05:31:03PM +

[libvirt] [PATCHv2] tests: be more explicit on qcow2 versions in virstoragetest

While working on v1.0.5-maint (the branch in use on Fedora 19) with the host at Fedora 20, I got a failure in virstoragetest. I traced it to the fact that we were using qemu-img to create a qcow2 file, but qemu-img changed from creating v2 files by default in F19 to creating v3 files in F20. Rathe

[libvirt] [PATCH 4/6] Implement domainGetCPUStats for lxc driver.

--- src/lxc/lxc_driver.c | 132 +++ 1 file changed, 132 insertions(+) diff --git a/src/lxc/lxc_driver.c b/src/lxc/lxc_driver.c index 9f586af..1e9c77a 100644 --- a/src/lxc/lxc_driver.c +++ b/src/lxc/lxc_driver.c @@ -75,6 +75,8 @@ #define LXC_NB_

[libvirt] [PATCH 5/6] Implemet lxcDomainBlockStats for lxc driver

--- src/lxc/lxc_driver.c | 51 +++ 1 file changed, 51 insertions(+) diff --git a/src/lxc/lxc_driver.c b/src/lxc/lxc_driver.c index 1e9c77a..1d2a457 100644 --- a/src/lxc/lxc_driver.c +++ b/src/lxc/lxc_driver.c @@ -2021,6 +2021,56 @@ lxcDomainGetSched

[libvirt] [PATCH 6/6] Widening API change - accept empty path for virDomainBlockStats

And provide domain summary stats in that case, for lxc backend. Use case is a container domain using passthrough bind mounts of the host filesystem, which is a common case for lxc. --- src/libvirt.c | 1 - src/lxc/lxc_driver.c | 10 ++ src/qemu/qemu_driver.c | 2 ++

[libvirt] [PATCH 1/6] Add util virCgroupGetBlkioIo*Serviced methods.

This reads blkio stats from blkio.throttle.io_service_bytes and blkio.throttle.io_serviced. --- src/libvirt_private.syms | 2 + src/util/vircgroup.c | 208 +++ src/util/vircgroup.h | 12 +++ 3 files changed, 222 insertions(+) diff --git a/src

[libvirt] [PATCH 3/6] Make qemuGetDomainTotalCPUStats a virCgroup function.

To reuse this from other drivers, like lxc. --- src/libvirt_private.syms | 1 + src/qemu/qemu_driver.c | 54 ++-- src/util/vircgroup.c | 53 +++ src/util/vircgroup.h | 5 + 4 files changed, 61 i

[libvirt] [PATCH 2/6] Implement domainMemoryStats API slot for LXC driver.

--- src/lxc/lxc_driver.c | 52 1 file changed, 52 insertions(+) diff --git a/src/lxc/lxc_driver.c b/src/lxc/lxc_driver.c index 7e56a59..9f586af 100644 --- a/src/lxc/lxc_driver.c +++ b/src/lxc/lxc_driver.c @@ -4554,6 +4554,57 @@ lxcNodeGetInfo(v

[libvirt] [PATCH 0/6] Add BlkIO and CPU/mem stat API implementations for lxc

This patch set adds block io, memory and domain cpu statistics API slot implementations to the LXC driver, in order to get linux container monitoring and accounting a bit closer to qemu standards. The last patch is a tad quirky (happy to hear suggestions on alternative ways), in that it widens the

[libvirt] [PATCHv2 6/6] maint: replace remaining virLib*Error with better names

Finish the cleanup of libvirt.c; all uses of virLib*Error have now been converted to more canonical conventions. * src/libvirt.c: Use virReportError in remaining errors. (virLibConnError, virLibDomainError): Delete unused macros. * cfg.mk (msg_gen_function): Drop unused names. Signed-off-by: Eric

[libvirt] [PATCHv2 1/6] maint: don't leave garbage on early API exit

Several APIs clear out a user input buffer before attempting to populate it; but in a few cases we missed this memset if we detect a reason for an early exit. Note that these APIs check for non-NULL arguments, and exit early with an error message when NULL is passed in; which means that we must be

[libvirt] [PATCHv2 5/6] maint: simplify driver registration at startup

We had a lot of repetition of errors that would occur if we ever register too many drivers; this is unlikely to occur unless we start adding a lot of new hypervisor modules, but if it does occur, it's better to have uniform handling of the situation, so that a one-line change is all that would be n

[libvirt] [PATCHv2 4/6] maint: clean up error reporting in migration

The choice of error message and category was not consistent in the migration code; furthermore, the use of virLibConnError is no longer necessary now that we have a generic virReportError. * src/qemu/qemu_migration.c (virDomainMigrate*): Prefer virReportError over virLibConnError. Signed-off-by:

[libvirt] [PATCHv2 0/6] remaining cleanups to libvirt.c

v2 of my patch series started here, after applying all patches already reviewed in that thread: https://www.redhat.com/archives/libvir-list/2013-December/msg01284.html Patches 1-3 can be considered bug fixes (particularly patch 3), so I'd like them in 1.2.1 if they get a favorable review. Patches

[libvirt] [PATCHv2 3/6] maint: don't lose error on canceled migration

While auditing the error reporting, I noticed that migration had some issues. Some of the static helper functions tried to call virDispatchError(), even though their caller will also report the error. Also, if a migration is cancelled early because a uri was not set, we did not guarantee that the

[libvirt] [PATCHv2 2/6] maint: avoid nested use of virConnect{Ref, Close}

The public virConnectRef and virConnectClose API are just thin wrappers around virObjectRef/virObjectRef, with added object validation and an error reset. Within our backend drivers, use of the object validation is just an inefficiency since we always pass valid objects. More important to think a

[libvirt] [PATCH] maint: ignore transient files during tests

I ran 'git add .' for a patch in progress, while in the middle of running 'make check' to test my work, and was surprised when it picked up some files I wasn't expecting. * .gitignore: Ignore *.pem. Signed-off-by: Eric Blake --- Pushing under the trivial rule. .gitignore | 1 + 1 file changed

[libvirt] [PATCH v2] Add helper program to create custom leases

Introduce helper program to catch events from dnsmasq and maintain a custom lease file per network. It supports DHCPv4 and DHCPv6. The file is saved as ".status". The format of each lease is: Example of custom leases file content: 1385245780 52:54:00:2f:ba:76 * 192.168.150.153 * * 138524578

Re: [libvirt] [PATCH] Add helper program to create custom leases

Ignore this. It has missing lines for compilation and addition in network driver. I am sending Patch v2. On Thu, Dec 19, 2013 at 1:09 PM, Nehal J Wani wrote: > Introduce helper program to catch events from dnsmasq and maintain a custom > lease file per network. It supports dhcpv4 and dhcpv6. The

[libvirt] [PATCH 1/2] DO NOT APPLY UPSTREAM: Reproducer

Apply this patch and run a patched libvirt daemon. Then start a VM and kill it's process after few seconds: # virsh start VM & sleep 3; killall -9 qemu-kvm Upstream version doesn't crash but the virsh command returns cryptic error message: error: invalid argument: monitor must not be NULL 0.10

[libvirt] [PATCH 2/2] qemu: Avoid operations on NULL monitor if VM fails early

https://bugzilla.redhat.com/show_bug.cgi?id=1047659 If a VM dies very early during an attempted connect to the guest agent while the locks are down the domain monitor object will be freed. The object is then accessed later as any failure during guest agent startup isn't considered fatal. In the c

[libvirt] [PATCH 0/2] Avoid issue when VM quits while attempting connection to the guest agent.

Peter Krempa (2): DO NOT APPLY UPSTREAM: Reproducer qemu: Avoid operations on NULL monitor if VM fails early src/qemu/qemu_process.c | 36 +++- 1 file changed, 27 insertions(+), 9 deletions(-) -- 1.8.5.2 -- libvir-list mailing list libvir-list@redhat.com htt

[libvirt] [PATCH] docs: mention maintenance branches

Mitre tried to assign us two separate CVEs for the fix for https://bugzilla.redhat.com/show_bug.cgi?id=1047577, on the grounds that the fixes were separated by more than an hour and thus triggered different hourly snapshots. But we explicitly do NOT want to treat transient security bugs as CVEs if

[libvirt] [PATCH v2] vbox: add support for v4.2.20+ and v4.3.4+

Hi, While working on adding virDomain*Stats support to the vbox driver, we found bugs in the VirtualBox API C bindings. These bugs have been fixed in versions 4.2.20 and 4.3.4. However, the changes in the C bindings are incompatible with the vbox_CAPI_v4_2.h and vbox_CAPI_v4_3.h files which are b

[libvirt] [PATCH 14/16] LXC from native: map lxc.arch to /domain/os/type@arch

--- src/lxc/lxc_native.c| 8 tests/lxcconf2xmldata/lxcconf2xml-simple.config | 1 + tests/lxcconf2xmldata/lxcconf2xml-simple.xml| 2 +- 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/src/lxc/lxc_native.c b/src/lxc/lxc_native.c index 75e05a5.

[libvirt] [PATCH 10/16] LXC from native: migrate memory tuning

--- src/lxc/lxc_native.c | 26 tests/lxcconf2xmldata/lxcconf2xml-memtune.config | 12 tests/lxcconf2xmldata/lxcconf2xml-memtune.xml| 38 tests/lxcconf2xmltest.c | 1 + 4 files changed, 77 i

[libvirt] [PATCH 13/16] LXC from native: add lxc.cgroup.blkio.* mapping

--- src/lxc/lxc_native.c | 44 ++ tests/lxcconf2xmldata/lxcconf2xml-blkiotune.config | 9 + tests/lxcconf2xmldata/lxcconf2xml-blkiotune.xml| 44 ++ tests/lxcconf2xmltest.c| 1 + 4 files chan

[libvirt] [PATCH 15/16] LXC from native: map block filesystems

--- src/lxc/lxc_native.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/lxc/lxc_native.c b/src/lxc/lxc_native.c index 1c0f325..5ba6f94 100644 --- a/src/lxc/lxc_native.c +++ b/src/lxc/lxc_native.c @@ -471,6 +471,7 @@ lxcAddFstabLine(virDomainDefPtr def, lxcFstabPtr fstab, unsigned lo

[libvirt] [PATCH 07/16] LXC from native: convert lxc.tty to console devices

--- src/lxc/lxc_native.c | 41 tests/lxcconf2xmldata/lxcconf2xml-simple.xml | 6 2 files changed, 47 insertions(+) diff --git a/src/lxc/lxc_native.c b/src/lxc/lxc_native.c index 3667d04..6ea4998 100644 --- a/src/lxc/lxc_native.c +++ b/src

[libvirt] [PATCH 01/16] LXC driver: started implementing connectDomainXMLFromNative

This function aims at converting LXC configuration into a libvirt domain XML description to help users migrate from LXC to libvirt. Here is an example of how the lxc configuration works: virsh -c lxc:/// domxml-from-native lxc /var/lib/lxc/migrate_test/config It is possible that some parts couldn

[libvirt] [PATCH 03/16] LXC from native: migrate fstab and lxc.mount.entry

Tmpfs default usage is computed based on the host physical memory. To test this more easily, the value is computed outside the parse method. --- src/lxc/lxc_container.c | 2 +- src/lxc/lxc_container.h | 2 + src/lxc/lxc_native.c

[libvirt] [PATCH 05/16] LXC from native: migrate veth network configuration

Some of the LXC configuration properties aren't migrated since they would only cause problems in libvirt-lxc: lxc.network.ipv[46]: LXC driver doesn't setup IP address of guests lxc.network.name --- src/lxc/lxc_native.c | 98 ++-- tests/lxcconf2xm

[libvirt] [PATCH 02/16] LXC from native: import rootfs

LXC rootfs can be either a directory or a block device or an image file. The first two types have been implemented, but the image file is still to be done since LXC auto-guesses the file format at mount time and the LXC driver doesn't support the 'auto' format. --- src/lxc/lxc_native.c

[libvirt] [PATCH 12/16] LXC from native: map lxc.cgroup.cpuset.*

--- src/lxc/lxc_native.c | 27 .../lxcconf2xmldata/lxcconf2xml-cpusettune.config | 8 + tests/lxcconf2xmldata/lxcconf2xml-cpusettune.xml | 36 ++ tests/lxcconf2xmltest.c| 1 + 4 files changed, 7

[libvirt] [PATCH 04/16] LXC from native: implement no network conversion

If no network configuration is provided, LXC only provides the loopback interface. To match this, we need to use the privnet feature. --- src/lxc/lxc_native.c | 43 ++ tests/lxcconf2xmldata/lxcconf2xml-nonetwork.config | 5 +++ tests/lxcconf2xmlda

[libvirt] [PATCH 00/16] lxc driver connectDomainXMLFromNative

The aim of these patches is to provide users a way to easily convert existing LXC containers into libvirt LXC domains. This conversion is mostly based on the use of connectDomainXMLFromNative implementation, but there are small bits that will still need to be manually tweaked, like creating a VLAN

[libvirt] [PATCH 08/16] LXC from native: convert macvlan network configuration

--- src/lxc/lxc_native.c | 38 +- .../lxcconf2xml-macvlannetwork.config | 14 .../lxcconf2xmldata/lxcconf2xml-macvlannetwork.xml | 30 + tests/lxcconf2xmltest.c| 1 + 4 files change

[libvirt] [PATCH 11/16] LXC from native: map lxc.cgroup.cpu.*

--- src/lxc/lxc_native.c | 26 tests/lxcconf2xmldata/lxcconf2xml-cputune.config | 9 ++ tests/lxcconf2xmldata/lxcconf2xml-cputune.xml| 38 tests/lxcconf2xmltest.c | 1 + 4 files changed, 74 ins

[libvirt] [PATCH 06/16] LXC from native: convert phys network types to net hostdev devices

--- src/lxc/lxc_native.c | 43 +++--- .../lxcconf2xmldata/lxcconf2xml-physnetwork.config | 8 tests/lxcconf2xmldata/lxcconf2xml-physnetwork.xml | 35 ++ tests/lxcconf2xmltest.c| 1 + 4 files changed,

[libvirt] [PATCH 16/16] LXC from native: map vlan network type

The problem with VLAN is that the user still has to manually create the vlan interface on the host. Then the generated configuration will use it as a nerwork hostdev device. So the generated configurations of the following two fragments are equivalent. lxc.network.type = phys lxc.network.link = et

[libvirt] [PATCH 09/16] LXC from native: convert lxc.id_map into

--- src/lxc/lxc_native.c | 41 ++ tests/lxcconf2xmldata/lxcconf2xml-idmap.config | 6 tests/lxcconf2xmldata/lxcconf2xml-idmap.xml| 32 tests/lxcconf2xmltest.c| 1 + 4 files changed, 80 inserti

Re: [libvirt] [PATCH] Fix memory leak in testDomainCreateXMLMixed()

On 01/14/2014 02:10 PM, Nehal J Wani wrote: > While running objecteventtest, it was found that valgrind pointed out the > following memory leak: > > ==13025== 538 (56 direct, 482 indirect) bytes in 1 blocks are definitely lost > in loss record 216 of 226 > ==13025==at 0x4A06B6F: calloc (vg_re

Re: [libvirt] [PATCH] virsh nodecpustats returns incorrect stats of cpu on Linux when the number of online cpu exceed 9.

On Mon, Jan 13, 2014 at 06:28:07PM +0800, m...@linux.vnet.ibm.com wrote: > From: Bing Bu Cao > > To retrieve node cpu statistics on Linux system, the > linuxNodeGetCPUstats function use STRPREFIX() to match the > cpuid with the cpuid read from /proc/cpustat, it will cause > obvious error. > > Fo

Re: [libvirt] [PATCH] virsh nodecpustats returns incorrect stats of cpu on Linux when the number of online cpu exceed 9.

On 01/13/2014 11:28 AM, m...@linux.vnet.ibm.com wrote: > From: Bing Bu Cao > > To retrieve node cpu statistics on Linux system, the > linuxNodeGetCPUstats function use STRPREFIX() to match the > cpuid with the cpuid read from /proc/cpustat, it will cause > obvious error. > > For example: > 'virs

Re: [libvirt] [PATCH] lxc: do cleanup when failed to create new string

On Tue, Jan 14, 2014 at 05:31:03PM +0800, Chen Hanxiao wrote: > From: Chen Hanxiao > > Signed-off-by: Chen Hanxiao > --- > src/lxc/lxc_process.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/lxc/lxc_process.c b/src/lxc/lxc_process.c > index c51c4d5..fc399fb 10064

[libvirt] [PATCH] Fix memory leak in testDomainCreateXMLMixed()

While running objecteventtest, it was found that valgrind pointed out the following memory leak: ==13025== 538 (56 direct, 482 indirect) bytes in 1 blocks are definitely lost in loss record 216 of 226 ==13025==at 0x4A06B6F: calloc (vg_replace_malloc.c:593) ==13025==by 0x4C65D8D: virAl

Re: [libvirt] [PATCH v2] conf: Always use VIR_ERR_CONFIG_UNSUPPORTED on enumFromString() failures

On 01/13/2014 11:41 AM, Christophe Fergeau wrote: > Currently, during XML parsing, when a call to a FromString() function to > get an enum value fails, the error which is reported is either > VIR_ERR_CONFIG_UNSUPPORTED, VIR_ERR_INTERNAL_ERROR or VIR_ERR_XML_ERROR. > > This commit makes such conver

Re: [libvirt] [PATCH] BSD: implement nodeGetCPUStats

Daniel P. Berrange wrote: > On Tue, Jan 14, 2014 at 12:47:20PM +0400, Roman Bogorodskiy wrote: > > I had doubts how to implement that. Looks like the current > > implementation is tied to Linux CPU metrics: > > > > user nice system idle iowait > > > > That list is hardcoded into virsh-host.c

[libvirt] [PATCH v2] lxc: do cleanup when failed to create new string

From: Chen Hanxiao Signed-off-by: Chen Hanxiao --- v2: fix an indent issue src/lxc/lxc_process.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lxc/lxc_process.c b/src/lxc/lxc_process.c index c51c4d5..7d6c5d3 100644 --- a/src/lxc/lxc_process.c +++ b/src/lxc/lxc_proces

Re: [libvirt] [PATCH] BSD: implement nodeGetCPUStats

On Tue, Jan 14, 2014 at 12:47:20PM +0400, Roman Bogorodskiy wrote: > I had doubts how to implement that. Looks like the current > implementation is tied to Linux CPU metrics: > > user nice system idle iowait > > That list is hardcoded into virsh-host.c. FreeBSD has a slightly > different set of

Re: [libvirt] [PATCH] vbox: add support for v4.2.20+ and v4.3.4+

2013/12/31 Jean-Baptiste Rouault : > On Monday 30 December 2013 11:26:08 Ryota Ozaki wrote: >> On Mon, Dec 30, 2013 at 5:55 PM, Jean-Baptiste Rouault >> >> wrote: >> > On Sunday 29 December 2013 14:44:10 Ryota Ozaki wrote: >> >> On Wed, Dec 25, 2013 at 12:47 AM, Jean-Baptiste Rouault >> >> >> >>

Re: [libvirt] [PATCH 0/6] Fix some memory leaks and other issues find by coverity tool

On 14/01/14 01:17, John Ferlan wrote: On 01/13/2014 11:12 AM, Pavel Hrdina wrote: This patch series fixes few memory leaks found by coverity tool to make that tool happy. The last patch is adding only one comment to hide "double_close" error as coverity tool is wrong about this and we don't ha

[libvirt] [PATCH] lxc: do cleanup when failed to create new string

From: Chen Hanxiao Signed-off-by: Chen Hanxiao --- src/lxc/lxc_process.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lxc/lxc_process.c b/src/lxc/lxc_process.c index c51c4d5..fc399fb 100644 --- a/src/lxc/lxc_process.c +++ b/src/lxc/lxc_process.c @@ -1045,7 +1045,7 @@

Re: [libvirt] [PATCH 0/6] Fix some memory leaks and other issues find by coverity tool

On 13.1.2014 18:17, John Ferlan wrote: On 01/13/2014 11:12 AM, Pavel Hrdina wrote: This patch series fixes few memory leaks found by coverity tool to make that tool happy. The last patch is adding only one comment to hide "double_close" error as coverity tool is wrong about this and we don't

[libvirt] [PATCH] BSD: implement nodeGetCPUStats

Implementation obtains CPU usage information using kern.cp_time and kern.cp_times sysctl(8)s and reports CPU utilization. --- src/nodeinfo.c | 85 ++ 1 file changed, 85 insertions(+) diff --git a/src/nodeinfo.c b/src/nodeinfo.c index 05bc038

[libvirt] [PATCH] BSD: implement nodeGetCPUStats

I had doubts how to implement that. Looks like the current implementation is tied to Linux CPU metrics: user nice system idle iowait That list is hardcoded into virsh-host.c. FreeBSD has a slightly different set of metrics: user nice system intr idle I.e. it's interrupt time instead of i/o