[libvirt] [PATCH 3/3] Doc: Add "note" for node-memory-tune

2014-01-21 Thread Osier Yang
To let the user know the command onlys work for KSM under Linux. --- tools/virsh.pod | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tools/virsh.pod b/tools/virsh.pod index 35a7292..07f4397 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -317,6 +317,9 @@ different numa nodes can be me

[libvirt] [PATCH 0/3] Doc fixes

2014-01-21 Thread Osier Yang
*** BLURB HERE *** Osier Yang (3): virsh: Fix the string breaking style Doc: Improve the document for nodesuspend Doc: Add "note" for node-memory-tune tools/virsh-host.c | 6 +++--- tools/virsh.pod| 16 +++- 2 files changed, 14 insertions(+), 8 deletions(-) -- 1.8.1.4 -

[libvirt] [PATCH 2/3] Doc: Improve the document for nodesuspend

2014-01-21 Thread Osier Yang
Explicitly lists the possible values for "--target" option; Gets rid of the confused strings like "Suspend-to-RAM"; Emphasises the node *has to* be suspended in the time duration specified by "--duration". And rewords the entire document a bit according to the API's implementation and document. ---

[libvirt] [PATCH 1/3] virsh: Fix the string breaking style

2014-01-21 Thread Osier Yang
--- Pushed under trivial rule. --- tools/virsh-host.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/virsh-host.c b/tools/virsh-host.c index 967bd52..3438ae7 100644 --- a/tools/virsh-host.c +++ b/tools/virsh-host.c @@ -516,7 +516,7 @@ static const vshCmdInfo info_n

[libvirt] [vmware] Fix VMware driver version checking on Linux

2014-01-21 Thread ryan woodsmall
> Daniel Excellent point, Daniel. Try two is below. The verbuf string is tokenized on newline, then iterated over with blank lines ignored. First match of the VMware driver pattern will break out of the loop with tmp set correctly or the default NULL if it's not found. This should allow vmwareExtr

[libvirt] [sec-notice PATCH 4/2] LSN-2013-0018: still vulnerable in latest release

2014-01-21 Thread Eric Blake
We still don't have a full solution for CVE-2013-6456. * notices/2013/0018.xml: several maint branches had a vulnerable release. Signed-off-by: Eric Blake --- notices/2013/0018.xml | 14 ++ 1 file changed, 14 insertions(+) diff --git a/notices/2013/0018.xml b/notices/2013/0018.xml

[libvirt] [sec-notice PATCH 5/2] LSN-2013-0019: document CVE-2013-6457

2014-01-21 Thread Eric Blake
All affected branches have been patched. * notices/2013/0019.xml: New file. Signed-off-by: Eric Blake --- Pushing this and the earlier patches, since I already sent the corresponding email. I'm still working up LSN-2013-0020 for CVE-2013-6458 notices/2013/0019.xml | 97 ++

[libvirt] [sec-notice PATCH 3/2] notices: recent maintenance releases

2014-01-21 Thread Eric Blake
Cleanups found while revisiting some of my recent backport efforts, and documentation of recent releases. * notices/2014/0001.xml: Typo fix, more details. * notices/2014/0002.xml: Likewise. * notices/2013/0017.xml: Maintenance releases. Signed-off-by: Eric Blake --- notices/2013/0017.xml | 3 +

[libvirt] [PATCH 3/4] qemu: parse and format os.bootStrict from/to command line

2014-01-21 Thread Laszlo Ersek
Recent commit 96fddee3 ('qemu: add "-boot strict" to commandline whenever possible') breaks qemu boot order processing in OVMF. The qemu option '-boot strict=on' closes down the fw_cfg boot option list with a HALT string: /pci@i0cf8/ethernet@3/ethernet-phy@0 /pci@i0cf8/scsi@4/disk@0,0 HALT

[libvirt] [PATCH 2/4] domain: parse and format os.bootStrict from/to XML

2014-01-21 Thread Laszlo Ersek
Signed-off-by: Laszlo Ersek --- src/conf/domain_conf.c| 21 + docs/formatdomain.html.in | 9 + docs/schemas/domaincommon.rng | 10 ++ 3 files changed, 40 insertions(+) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index f0f165f..cb4

[libvirt] [PATCH 4/4] parallels: reject non-default os.bootStrict

2014-01-21 Thread Laszlo Ersek
This is similar to how os.bootmenu is handled. Signed-off-by: Laszlo Ersek --- src/parallels/parallels_driver.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/parallels/parallels_driver.c b/src/parallels/parallels_driver.c index 33260ef..4a386c2 100644 --- a/src/parallels/parallels_driv

[libvirt] [PATCH 0/4] allow OVMF users to disable qemu's "-boot strict=on"

2014-01-21 Thread Laszlo Ersek
Recently, commit 96fddee322c7d39a57cfdc5e7be71326d597d30a Author: Laine Stump Date: Mon Dec 2 14:07:12 2013 +0200 qemu: add "-boot strict" to commandline whenever possible introduced a regression for OVMF guests. The symptoms and causes are described in patch 3/4, and in https:

[libvirt] [PATCH 1/4] domain: introduce os.bootStrict

2014-01-21 Thread Laszlo Ersek
This field will allow the user to disable strict booting under qemu. Signed-off-by: Laszlo Ersek --- src/conf/domain_conf.h | 11 +++ src/conf/domain_conf.c | 5 + src/libvirt_private.syms | 2 ++ 3 files changed, 18 insertions(+) diff --git a/src/conf/domain_conf.h b/src/conf

Re: [libvirt] [libvirt-sandbox PATCH v3] Add filter support.

2014-01-21 Thread Ian Main
On Thu, Jan 09, 2014 at 12:25:51PM +0100, Christophe Fergeau wrote: > Hey, > > Mostly looks good, see below a few small changes I'd squash in. > The only functional change is the addition of missing calls to > g_object_notify() in the various setters, and the renaming of > GVirSandboxConfigFilterr

Re: [libvirt] [RFC PATCH 1/7] config: Adding source for the config driver

2014-01-21 Thread Adam Walters
Peter, Thank you for the feedback on my patches, and sorry for the delay. I was away all weekend, since it was a holiday weekend (definitely a plus, having my day job in education). I figured it would be a bit spammy to reply to each individual message, but I did read each of them, and will be wor

Re: [libvirt] [RFC PATCH 0/7] Adding 'config' driver

2014-01-21 Thread Adam Walters
On Mon, Jan 20, 2014 at 11:27 AM, Daniel P. Berrange wrote: > On Fri, Dec 20, 2013 at 11:03:53PM -0500, Adam Walters wrote: > > This patchset adds a driver named 'config' that allows access to > configuration > > data, such as secret and storage definitions. This is a pre-requisite > for my > > ne

[libvirt] [sec-notice PATCH 2/2] scripts: require bash for bashisms

2014-01-21 Thread Eric Blake
Use of ${BASH_SOURCE[0]} is a syntax error in dash. Use of `` is pointless when we know we are in bash. * scripts/lsn2text: Make more robust. * scripts/lsn2html: Likewise. * scripts/lsn2indexhtml: Likewise. * scripts/lsn2index: Likewise. Signed-off-by: Eric Blake --- scripts/lsn2html | 4 +

[libvirt] [sec-notice PATCH 1/2] maint: typo fixes

2014-01-21 Thread Eric Blake
Noticed this while working on some additions. * docs/schema.txt: Typo fixes. * README: Refer to the schema. Signed-off-by: Eric Blake --- README | 5 +++-- docs/schema.txt | 6 +++--- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/README b/README index 426d9ca..fa7f103

Re: [libvirt] [PATCH] qemu: hyperv: Add enlightenment support for TSC timekeeping

2014-01-21 Thread Eric Blake
On 01/21/2014 10:54 AM, Peter Krempa wrote: > The hyperv enlightenment features allow to ease guests timekeeping by > allowing to store offset from the TSC as a reference. Add the support > for enabling this flag in qemu. > --- > > Notes: > This feature is still under development in qemu. I wi

[libvirt] [PATCH] qemu: hyperv: Add enlightenment support for TSC timekeeping

2014-01-21 Thread Peter Krempa
The hyperv enlightenment features allow to ease guests timekeeping by allowing to store offset from the TSC as a reference. Add the support for enabling this flag in qemu. --- Notes: This feature is still under development in qemu. I will wait until it's finished before pushing this:

[libvirt] [PATCH] api: require write permission for guest agent interaction

2014-01-21 Thread Eric Blake
I noticed that we allow virDomainGetVcpusFlags even for read-only connections, but that with a flag, it can require guest agent interaction. It is feasible that a malicious guest could intentionally abuse the replies it sends over the guest agent connection to possibly trigger a bug in libvirt's J

Re: [libvirt] [Users] libvirt migration port configuration and virPortAllocator

2014-01-21 Thread Gianluca Cecchi
On Thu, Jan 9, 2014 at 2:27 PM, Ján Tomko wrote: > On 01/08/2014 05:48 PM, Eric Blake wrote: >> On 01/08/2014 02:45 AM, Dan Kenigsberg wrote: >>> On Wed, Jan 08, 2014 at 01:26:23AM +0100, Gianluca Cecchi wrote: Hello, following the bugzilla here: https://bugzilla.redhat.com/show_bug

Re: [libvirt] [[PATCH v2]] virsh nodecpustats returns incorrect stats of cpu on Linux when the number of online cpu exceed 9.

2014-01-21 Thread Michal Privoznik
On 16.01.2014 09:18, m...@linux.vnet.ibm.com wrote: > From: Bing Bu Cao > > To retrieve node cpu statistics on Linux system, the > linuxNodeGetCPUstats function simply uses STRPREFIX() to match the > cpuid with the cpuid read from /proc/stat, it will cause > obvious error. > > For example: > 'vi

Re: [libvirt] [PATCH] Honour prefix in wireshark install dir

2014-01-21 Thread Eric Blake
On 01/21/2014 09:07 AM, Daniel P. Berrange wrote: > Trying to run > > $ ./configure --prefix=$HOME/usr/libvirt-git > $ make install > > results in libvirt trying to install in /usr/lib/wireshark/plugins/ > with predictable amounts of fail. The configure script should not be > hardcoding /

[libvirt] [PATCH] Honour prefix in wireshark install dir

2014-01-21 Thread Daniel P. Berrange
Trying to run $ ./configure --prefix=$HOME/usr/libvirt-git $ make install results in libvirt trying to install in /usr/lib/wireshark/plugins/ with predictable amounts of fail. The configure script should not be hardcoding /usr/lib by default but rather honour $libdir Signed-off-by: Danie

Re: [libvirt] [PATCH] qemu: snapshot: Forbid snapshots when backing is a scsi passthrough disk

2014-01-21 Thread Eric Blake
On 01/21/2014 08:57 AM, Peter Krempa wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1034993 > > SCSI passthrough disks () can't be used as backing > for snapshots. Currently with upstream qemu the vm crashes on such > attempt. > > This patch adds a early check to catch an attempt to do such

[libvirt] [PATCH] qemu: snapshot: Forbid snapshots when backing is a scsi passthrough disk

2014-01-21 Thread Peter Krempa
https://bugzilla.redhat.com/show_bug.cgi?id=1034993 SCSI passthrough disks () can't be used as backing for snapshots. Currently with upstream qemu the vm crashes on such attempt. This patch adds a early check to catch an attempt to do such a snapshot and rejects it right away. qemu will fix the i

Re: [libvirt] [PATCH] Be more clever and verbose about localization-initialization.

2014-01-21 Thread Fuchs, Andreas
Hi all, I just wanted to query about the status of this, since my personal tracker just reminded me... Is it rejected ? Does it need rework ? ...? Would be a pitty if something this simple got lost over time... Bug-Entry: https://bugzilla.redhat.com/show_bug.cgi?id=1016158 Patch-Pointers: Opti

Re: [libvirt] What is the robust/recommended way to retrieve the PID of a VM's init process ?

2014-01-21 Thread Eric Blake
On 01/21/2014 05:20 AM, Thierry Parmentelat wrote: > Hi again [once again, please don't top-post on technical lists] > > So I did give this interesting lxc-enter-namespace feature a try Thank you. > > So my comments are, > - first that defining some even minimal PATH would help; PATH relat

[libvirt] [PATCH 2/2] Simplify linuxNodeGetCPUStats

2014-01-21 Thread Ján Tomko
Split out the repetitive code. --- src/nodeinfo.c | 77 +++--- 1 file changed, 30 insertions(+), 47 deletions(-) diff --git a/src/nodeinfo.c b/src/nodeinfo.c index 671054e..8d4a3ed 100644 --- a/src/nodeinfo.c +++ b/src/nodeinfo.c @@ -683,6 +683,

[libvirt] [PATCH 0/2] Add a test for linuxNodeGetCPUStats

2014-01-21 Thread Ján Tomko
Ján Tomko (2): Add test for linuxNodeGetCPUStats Simplify linuxNodeGetCPUStats src/libvirt_linux.syms | 1 + src/nodeinfo.c | 83 +++ tests/nodeinfodata/linux-cpustat-24cpu.out | 150 tests/nodeinfo

[libvirt] [PATCH 1/2] Add test for linuxNodeGetCPUStats

2014-01-21 Thread Ján Tomko
Check if cpu stats are read correctly from a sample /proc/stat collected from a 24 CPU machine. --- src/libvirt_linux.syms | 1 + src/nodeinfo.c | 6 +- tests/nodeinfodata/linux-cpustat-24cpu.out | 150 tests/nodei

Re: [libvirt] RFC: Move tests into same directory as the sources

2014-01-21 Thread Michal Privoznik
On 21.01.2014 12:26, Daniel P. Berrange wrote: > Currently we have a split with all the "source" code under various > subdirectories of src/, while the test cases are (mostly) all under > the tests/ directory. I think there could be some benefits to moving > the test files to be alongside the sourc

Re: [libvirt] What is the robust/recommended way to retrieve the PID of a VM's init process ?

2014-01-21 Thread Thierry Parmentelat
Hi again So I did give this interesting lxc-enter-namespace feature a try I found a few glitches that I thought might be of interest; I recall that I use a stock f20 box which probably is already behind as compared to the devel version root@warhol ~/thierry # rpm -q libvirt libvirt-1.1.3.2-1.f

Re: [libvirt] RFC: Move tests into same directory as the sources

2014-01-21 Thread Daniel P. Berrange
On Tue, Jan 21, 2014 at 02:09:58PM +0200, Laine Stump wrote: > On 01/21/2014 01:26 PM, Daniel P. Berrange wrote: > > Currently we have a split with all the "source" code under various > > subdirectories of src/, while the test cases are (mostly) all under > > the tests/ directory. I think there cou

Re: [libvirt] RFC: Move tests into same directory as the sources

2014-01-21 Thread Laine Stump
On 01/21/2014 01:26 PM, Daniel P. Berrange wrote: > Currently we have a split with all the "source" code under various > subdirectories of src/, while the test cases are (mostly) all under > the tests/ directory. I think there could be some benefits to moving > the test files to be alongside the so

[libvirt] RFC: Move tests into same directory as the sources

2014-01-21 Thread Daniel P. Berrange
Currently we have a split with all the "source" code under various subdirectories of src/, while the test cases are (mostly) all under the tests/ directory. I think there could be some benefits to moving the test files to be alongside the source files being tested. eg instead of tests/virhashtest.c

[libvirt] [PATCH] Implement lxcDomainBlockStatsFlags for lxc driver

2014-01-21 Thread Thorsten Behrens
--- src/lxc/lxc_driver.c | 124 +++ 1 file changed, 124 insertions(+) diff --git a/src/lxc/lxc_driver.c b/src/lxc/lxc_driver.c index 7fa9612..57d8fcb 100644 --- a/src/lxc/lxc_driver.c +++ b/src/lxc/lxc_driver.c @@ -77,6 +77,8 @@ #define LXC_NB_MEM_

Re: [libvirt] [PATCHv2 2/2] qemu: snapshot: Avoid libvirtd crash when qemu crashes while snapshotting

2014-01-21 Thread Peter Krempa
On 01/20/14 19:03, Eric Blake wrote: > On 01/20/2014 10:09 AM, Peter Krempa wrote: >> We shouldn't access the domain definition while we are in the monitor >> section as the domain is unlocked. Additionaly after we exit from the > > s/Additionaly/Additionally/ > >> monitor we need to check if the

[libvirt] [libvirt-glib 4/5] gconfig: Fix removal of GVirConfigCapabilitiesCpu topology

2014-01-21 Thread Christophe Fergeau
Calling gvir_config_capabilities_cpu_set_topology with a NULL topology would not remove the topology as expected as NULL would be rejected by this method preconditions. --- libvirt-gconfig/libvirt-gconfig-capabilities-cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libvir

[libvirt] [libvirt-glib 5/5] gconfig: Fix removal of GVirConfigDomainCpu from domains

2014-01-21 Thread Christophe Fergeau
A wrong precondition in gvir_config_domain_set_cpu() would reject NULL GVirConfigDomainCpus instead of accepting them. --- libvirt-gconfig/libvirt-gconfig-domain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libvirt-gconfig/libvirt-gconfig-domain.c b/libvirt-gconfig/libvir

[libvirt] [libvirt-glib 2/5] Add various clock-related getters

2014-01-21 Thread Christophe Fergeau
--- libvirt-gconfig/libvirt-gconfig-domain-clock.c | 35 ++ libvirt-gconfig/libvirt-gconfig-domain-clock.h | 3 +++ libvirt-gconfig/libvirt-gconfig-domain.c | 24 ++ libvirt-gconfig/libvirt-gconfig-domain.h | 1 + libvirt-gconfig/libvirt-gconfi

[libvirt] [libvirt-glib 1/5] gconfig: Fix gvir_config_domain_os_get_boot_devices() API doc

2014-01-21 Thread Christophe Fergeau
The elements of the returned list are integer enum values, so they cannot be unreffed. --- libvirt-gconfig/libvirt-gconfig-domain-os.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libvirt-gconfig/libvirt-gconfig-domain-os.c b/libvirt-gconfig/libvirt-gconfig-domain-os.c in

[libvirt] [libvirt-glib 3/5] Implement getters for GVirConfigDomainInput

2014-01-21 Thread Christophe Fergeau
--- libvirt-gconfig/libvirt-gconfig-domain-input.c | 24 libvirt-gconfig/libvirt-gconfig-domain-input.h | 2 ++ libvirt-gconfig/libvirt-gconfig.sym| 3 +++ 3 files changed, 29 insertions(+) diff --git a/libvirt-gconfig/libvirt-gconfig-domain-input.c b/libvi

Re: [libvirt] [PATCH 0/2] v6: spice: expose the disable file transfer option

2014-01-21 Thread Francesco Romani
Hi, - Original Message - > From: "Michal Privoznik" > To: "Francesco Romani" , libvir-list@redhat.com > Sent: Tuesday, January 21, 2014 11:35:57 AM > Subject: Re: [libvirt] [PATCH 0/2] v6: spice: expose the disable file > transfer option > > On 16.01.2014 17:11, Francesco Romani wrote:

[libvirt] [PATCH] patch to correct bug to refresh volume on sheepdog from a sheep pool Reload correctly pool and get vols.

2014-01-21 Thread joel . simoes
From: Joël Simoes --- src/storage/storage_backend_sheepdog.c | 91 ++ 1 file changed, 81 insertions(+), 10 deletions(-) diff --git a/src/storage/storage_backend_sheepdog.c b/src/storage/storage_backend_sheepdog.c index a6981ce..fbed11a 100644 --- a/src/storage/s

Re: [libvirt] [PATCH 0/2] v6: spice: expose the disable file transfer option

2014-01-21 Thread Michal Privoznik
On 16.01.2014 17:11, Francesco Romani wrote: > Changes v6: > amended commit message for patch #2 as suggested by Doug. > > > Francesco Romani (2): > spice: detect if qemu can disable file transfer > spice: expose the QEMU disable file transfer option > > docs/formatdomain.html.in

Re: [libvirt] [Qemu-devel] Exposing and calculating CPU APIC IDs (was Re: [RFC 1/3] target-i386: moving registers of vmstate from cpu_exec_init() to x86_cpu_realizefn())

2014-01-21 Thread Andreas Färber
Am 21.01.2014 10:51, schrieb Chen Fan: > On Tue, 2014-01-21 at 10:31 +0100, Igor Mammedov wrote: >> On Tue, 21 Jan 2014 15:12:45 +0800 >> Chen Fan wrote: >>> On Mon, 2014-01-20 at 13:29 +0100, Igor Mammedov wrote: On Fri, 17 Jan 2014 17:13:55 -0200 Eduardo Habkost wrote: > On Wed, J

Re: [libvirt] [PATCH glib] Switch over to using standard gobject introspection macros

2014-01-21 Thread Daniel P. Berrange
On Tue, Jan 21, 2014 at 11:06:24AM +0100, Christophe Fergeau wrote: > On Fri, Jan 17, 2014 at 04:56:27PM +, Daniel P. Berrange wrote: > > Remove hand crafted configure.ac and Makefile.am rules in > > favour of the standard macros. > > > > Signed-off-by: Daniel P. Berrange > As discussed in h

Re: [libvirt] [PATCH glib] Switch over to using standard gobject introspection macros

2014-01-21 Thread Christophe Fergeau
On Fri, Jan 17, 2014 at 04:56:27PM +, Daniel P. Berrange wrote: > Remove hand crafted configure.ac and Makefile.am rules in > favour of the standard macros. > > Signed-off-by: Daniel P. Berrange > --- > configure.ac| 25 +--- > libvirt-gconfig/Makefile.am | 71 >

Re: [libvirt] [PATCH 0/2] Introduce max_anonymous_clients

2014-01-21 Thread Michal Privoznik
On 09.12.2013 15:35, Michal Privoznik wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=981729 > > So far we can limit how many clients are connected, > how many are waiting in accept() line but we could > not control the count of accepted but not > authenticated yet. > > Michal Privoznik (2):

Re: [libvirt] [vmware] Fix VMware driver version checking on Linux

2014-01-21 Thread Daniel P. Berrange
On Mon, Jan 20, 2014 at 02:19:20PM -0600, ryan woodsmall wrote: > Recent changes to the VMware driver allow for VMware Fusion version checking > on OS X. It looks like the version checking on Linux for VMware Workstation > and Player could possibly be broken by the changes. The version check in

Re: [libvirt] [PATCH RESEND v4 1/2] Introduce Libvirt Wireshark dissector

2014-01-21 Thread Daniel P. Berrange
On Tue, Jan 21, 2014 at 10:32:53AM +0900, Yuto KAWAMURA wrote: > 2014/1/21 Michal Privoznik : > > On 20.01.2014 15:04, Yuto KAWAMURA wrote: > >> 2014/1/16 Michal Privoznik : > >>> On 15.01.2014 18:06, Yuto KAWAMURA(kawamuray) wrote: > From: "Yuto KAWAMURA(kawamuray)" > > Introduce W

Re: [libvirt] [Qemu-devel] Exposing and calculating CPU APIC IDs (was Re: [RFC 1/3] target-i386: moving registers of vmstate from cpu_exec_init() to x86_cpu_realizefn())

2014-01-21 Thread Chen Fan
On Tue, 2014-01-21 at 10:31 +0100, Igor Mammedov wrote: > On Tue, 21 Jan 2014 15:12:45 +0800 > Chen Fan wrote: > > > On Mon, 2014-01-20 at 13:29 +0100, Igor Mammedov wrote: > > > On Fri, 17 Jan 2014 17:13:55 -0200 > > > Eduardo Habkost wrote: > > > > > > > On Wed, Jan 15, 2014 at 03:37:04PM +01

Re: [libvirt] [Qemu-devel] Exposing and calculating CPU APIC IDs (was Re: [RFC 1/3] target-i386: moving registers of vmstate from cpu_exec_init() to x86_cpu_realizefn())

2014-01-21 Thread Igor Mammedov
On Tue, 21 Jan 2014 15:12:45 +0800 Chen Fan wrote: > On Mon, 2014-01-20 at 13:29 +0100, Igor Mammedov wrote: > > On Fri, 17 Jan 2014 17:13:55 -0200 > > Eduardo Habkost wrote: > > > > > On Wed, Jan 15, 2014 at 03:37:04PM +0100, Igor Mammedov wrote: > > > > On Wed, 15 Jan 2014 20:24:01 +0800 > >

Re: [libvirt] [PATCH] lxc: Fix coverity

2014-01-21 Thread Martin Kletzander
On Tue, Jan 21, 2014 at 09:43:07AM +0100, Ján Tomko wrote: > On 01/21/2014 09:04 AM, Martin Kletzander wrote: > > Commit 399394ab74ebf3f6e60771044fda0ee69a2acf67 removed some coverity > > comments which skipped the dead code, so add them back. > > > > Signed-off-by: Martin Kletzander > > --- > >

Re: [libvirt] [PATCH] lxc: Fix coverity

2014-01-21 Thread Ján Tomko
On 01/21/2014 09:04 AM, Martin Kletzander wrote: > Commit 399394ab74ebf3f6e60771044fda0ee69a2acf67 removed some coverity > comments which skipped the dead code, so add them back. > > Signed-off-by: Martin Kletzander > --- > src/lxc/lxc_driver.c | 2 ++ > 1 file changed, 2 insertions(+) ACK Jan

Re: [libvirt] [PATCHv2 2/2] qemu: snapshot: Avoid libvirtd crash when qemu crashes while snapshotting

2014-01-21 Thread Ján Tomko
On 01/20/2014 06:09 PM, Peter Krempa wrote: > We shouldn't access the domain definition while we are in the monitor > section as the domain is unlocked. Additionaly after we exit from the > monitor we need to check if the VM is still alive. Not doing so resulted > into crash if qemu exits while att

[libvirt] [libvirt-java] [PATCH] Depend on JNA versions 3.3 to 4.0

2014-01-21 Thread Claudio Bley
Specify a version range for the net.java.dev.jna / jna artefact in order to accept any version we tested the libvirt Java bindings against. --- It's been some time we discussed this[1], but here we go... https://www.redhat.com/archives/libvir-list/2013-September/msg00929.html pom.xml.in | 2 +-

[libvirt] [PATCH] lxc: Fix coverity

2014-01-21 Thread Martin Kletzander
Commit 399394ab74ebf3f6e60771044fda0ee69a2acf67 removed some coverity comments which skipped the dead code, so add them back. Signed-off-by: Martin Kletzander --- src/lxc/lxc_driver.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/lxc/lxc_driver.c b/src/lxc/lxc_driver.c index 4f35f93.