Re: [libvirt] [PATCH 1/6] squash this into domain conf XML "eliminate hardcoded indent" patch

2014-03-13 Thread Laine Stump
On 03/13/2014 04:06 PM, Eric Blake wrote: > On 03/12/2014 10:04 PM, Laine Stump wrote: >> This should be squashed into the first patch of the previous >> "eliminate hardcoded indent" series (which was ACKed but hasn't yet >> been pushed): >> >> https://www.redhat.com/archives/libvir-list/2014-Mar

Re: [libvirt] RFC: Exposing backing chains in XML

2014-03-13 Thread Eric Blake
On 03/13/2014 05:18 PM, Richard W.M. Jones wrote: > It seems like for (1) we don't need to change anything. For (2) > we might add: > > > > > > > > > > Note not specifying disk.img's backing store (we don't know it). > > Also, non-disk sourc

Re: [libvirt] RFC: Exposing backing chains in XML

2014-03-13 Thread Richard W.M. Jones
On Wed, Mar 12, 2014 at 02:21:46PM -0600, Eric Blake wrote: > A backing chain of 3 files (base <- mid <- top) in the local file system: > > > > > > > > > > > > > > > Libguestfs gets a

Re: [libvirt] [PATCH 3/7] Switch systemd test to use generic dbus mock

2014-03-13 Thread Eric Blake
On 03/12/2014 07:21 AM, Daniel P. Berrange wrote: > Remove the virsystemdmock.la library and instead make use > of the shared virmockdbus.la library > > Signed-off-by: Daniel P. Berrange > --- > tests/Makefile.am | 13 ++--- > tests/virsystemdmock.c | 139 > ---

Re: [libvirt] RFC: Exposing backing chains in XML

2014-03-13 Thread Richard W.M. Jones
On Wed, Mar 12, 2014 at 02:21:46PM -0600, Eric Blake wrote: > This feature is being driven in part by > https://bugzilla.redhat.com/show_bug.cgi?id=1069407 Also: https://bugzilla.redhat.com/show_bug.cgi?id=1011063 Perhaps this too? https://bugzilla.redhat.com/show_bug.cgi?id=921135 Rich. --

Re: [libvirt] [PATCH 2/7] Create a re-usable DBus LD_PRELOAD mock library

2014-03-13 Thread Eric Blake
On 03/12/2014 07:21 AM, Daniel P. Berrange wrote: > A number of test suites want to mock the DBus APIs. To avoid > re-inventing the wheel create a re-usable virmockdbus.la > library for LD_PRELOAD usage. > > Signed-off-by: Daniel P. Berrange > --- > tests/Makefile.am | 11 +++-- > tests/vi

Re: [libvirt] [PATCH 6/6] build: detect/prohibit hardcoded XML indent in syntax-check

2014-03-13 Thread Eric Blake
On 03/12/2014 10:04 PM, Laine Stump wrote: > This rule wouldn't be able to find any case of a hardcoded indent that > was in the middle of a string, but then virBuffer doesn't add > indentation in the middle of a string either. > --- > cfg.mk | 7 ++- > 1 file changed, 6 insertions(+), 1 delet

Re: [libvirt] [PATCH 4/6] util: eliminate hardcoded indent in virConnectSysInfo formatting

2014-03-13 Thread Eric Blake
On 03/12/2014 10:04 PM, Laine Stump wrote: > This same set of functions is used by the qemu, xen, and lxc drivers' > connectSysInfo function. > --- > src/util/virsysinfo.c | 72 > --- > 1 file changed, 40 insertions(+), 32 deletions(-) ACK. -- Er

Re: [libvirt] [PATCH 5/6] qemu: elmininate hardcoded indent in capabilities cache XML

2014-03-13 Thread Eric Blake
On 03/12/2014 10:04 PM, Laine Stump wrote: > --- s/elmininate/eliminate/ in the subject > src/qemu/qemu_capabilities.c | 20 +++- > 1 file changed, 11 insertions(+), 9 deletions(-) ACK. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://

Re: [libvirt] [PATCH 1/7] Introduce a new set of helper macros for mocking symbols

2014-03-13 Thread Eric Blake
On 03/12/2014 07:21 AM, Daniel P. Berrange wrote: > Introduce virmock.h which provides some macros to assist in > creation of LD_PRELOAD overrides. When these are used, the > LD_PRELOAD code simply has some stubs which forward to a > wrapper function inside the main test case. This means that > log

Re: [libvirt] [PATCH] nwfilter: Add ARP src/dst IP mask for ebtables ARP

2014-03-13 Thread Stefan Berger
sendmail wrote on 03/13/2014 01:50:04 PM: > > On 03/12/2014 05:10 AM, Stefan Berger wrote: > > From: Stefan Berger > > > > Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=862887 > > > > Add a netmask for the source and destination IP address for the > > ebtables --arp-ip-src and --arp-ip

Re: [libvirt] [PATCH] nwfilter: Fix rule priority problem

2014-03-13 Thread Stefan Berger
sendmail wrote on 03/13/2014 01:57:42 PM: > > On 03/11/2014 05:47 AM, Stefan Berger wrote: > > From: Stefan Berger > > > > Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1072292 > > > > Fix a problem related to rule priorities that did not allow to > > have rules applied that had a high

Re: [libvirt] [PATCH 3/3] qemu: XMLToNative: Parse XML as INACTIVE

2014-03-13 Thread Jim Fehlig
Cole Robinson wrote: > Right now we are parsing the XML as though it's live, which for example > will choke on hardcoded XML like: > > > > Erroring with: > > $ sudo virsh domxml-to-native qemu-argv f > error: XML error: security label is missing > --- > src/qemu/qemu_driver.c | 3 ++- > 1 f

Re: [libvirt] [PATCH 3/6] qemu: eliminate hardcoded indent from migration cookie xml

2014-03-13 Thread Eric Blake
On 03/12/2014 10:04 PM, Laine Stump wrote: > This is also never seen by a human. except maybe when reading log files > --- > src/qemu/qemu_migration.c | 49 > --- > 1 file changed, 29 insertions(+), 20 deletions(-) > ACK -- Eric Blake eblake red

Re: [libvirt] RFC: Exposing backing chains in XML

2014-03-13 Thread Eric Blake
[adding qemu-devel] Background to those new to the thread: Previously, libvirt has been tracking a lot of disk tunables alongside the active layer of a backing chain, without regards to any backing files in the chain. However, now that qemu supports named BDS nodes anywhere in the backing chain,

Re: [libvirt] [PATCH 2/6] virsh: eliminate hardcoded indentation in xml generated for commands

2014-03-13 Thread Eric Blake
On 03/12/2014 10:04 PM, Laine Stump wrote: > These are never seen externally, only passed into libvirt APIs, so in > practice this makes no real difference, but it's good to be > consistent. > --- > tools/virsh-domain.c | 43 --- > tools/virsh-pool.c |

Re: [libvirt] [PATCH 3/3] qemu: XMLToNative: Parse XML as INACTIVE

2014-03-13 Thread Laine Stump
On 03/13/2014 01:13 PM, Cole Robinson wrote: > Right now we are parsing the XML as though it's live, which for example > will choke on hardcoded XML like: > > > > Erroring with: > > $ sudo virsh domxml-to-native qemu-argv f > error: XML error: security label is missing > --- > src/qemu/qemu

[libvirt] [PATCH V2 12/13] libxl: move domain event handler to libxl_domain

2014-03-13 Thread Jim Fehlig
Move the domain event handler and shutdown thread out of the main driver module and into libxl_domain module Signed-off-by: Jim Fehlig --- src/libxl/libxl_domain.c | 179 +++ src/libxl/libxl_driver.c | 179 --

[libvirt] [PATCH V2 10/13] libxl: move libxlVmStart to libxl_domain

2014-03-13 Thread Jim Fehlig
Move libxlVmStart from libxl_driver to libxl_domain for use by other libxl modules. For consistency, rename to libxlDomainStart. Signed-off-by: Jim Fehlig --- src/libxl/libxl_domain.c | 181 +++ src/libxl/libxl_domain.h | 6 ++ src/libxl/libxl_driver.c

[libvirt] [PATCH V2 08/13] libxl: move libxlDomainSetVcpuAffinities to libxl_domain

2014-03-13 Thread Jim Fehlig
Move libxlDomainSetVcpuAffinities from libxl_driver to libxl_domain for use by other libxl modules. Signed-off-by: Jim Fehlig --- src/libxl/libxl_domain.c | 54 src/libxl/libxl_domain.h | 4 src/libxl/libxl_driver.c | 54

[libvirt] [PATCH V2 13/13] libxl: add migration support

2014-03-13 Thread Jim Fehlig
This patch adds initial migration support to the libxl driver, using the VIR_DRV_FEATURE_MIGRATION_PARAMS family of migration functions. Signed-off-by: Jim Fehlig --- V2: - Now that the libxl driver supports hostdev passthrough, ensure domain has no hostdevs before migration - Fail early in li

[libvirt] [PATCH V2 11/13] libxl: include a pointer to the driver in libxlDomainObjPrivate

2014-03-13 Thread Jim Fehlig
Include a pointer to the libxl driver in libxlDomainObjPrivate object so it can be used in the domain event handler and shutdown thread. Signed-off-by: Jim Fehlig --- src/libxl/libxl_domain.c | 5 +++-- src/libxl/libxl_domain.h | 4 +++- src/libxl/libxl_driver.c | 4 ++-- 3 files changed, 8 inse

[libvirt] [PATCH V2 01/13] libxl: move libxlDomainEventQueue to libxl_domain

2014-03-13 Thread Jim Fehlig
Move libxlDomainEventQueue from libxl_driver to libxl_domain for use by other libxl modules. Signed-off-by: Jim Fehlig --- src/libxl/libxl_domain.c | 6 ++ src/libxl/libxl_domain.h | 4 src/libxl/libxl_driver.c | 6 -- 3 files changed, 10 insertions(+), 6 deletions(-) diff --git a/

[libvirt] [PATCH V2 06/13] libxl: move libxlDomainAutoCoreDump to libxl_domain

2014-03-13 Thread Jim Fehlig
Move libxlDomainAutoCoreDump from libxl_driver to libxl_domain for use by other libxl modules. Signed-off-by: Jim Fehlig --- src/libxl/libxl_domain.c | 44 src/libxl/libxl_domain.h | 4 src/libxl/libxl_driver.c | 44 -

[libvirt] [PATCH V2 04/13] libxl: move libxlVmCleanup{, Job} to libxl_domain

2014-03-13 Thread Jim Fehlig
Move libxlVmCleanup and libxlVmCleanupJob from libxl_driver to libxl_domain for use by other libxl modules. For consistency, rename to libxlDomainCleanup and libxlDomainCleanupJob. Signed-off-by: Jim Fehlig --- src/libxl/libxl_domain.c | 91 ++ src/libxl

[libvirt] [PATCH V2 05/13] libxl: move libxlDomEventsRegister to libxl_domain

2014-03-13 Thread Jim Fehlig
Move libxlDomEventsRegister from libxl_driver to libxl_domain for use by other libxl modules. For consistency, rename to libxlDomainEventsRegister. Signed-off-by: Jim Fehlig --- src/libxl/libxl_domain.c | 24 src/libxl/libxl_domain.h | 4 +++- src/libxl/libxl_driver.c

[libvirt] [PATCH V2 09/13] libxl: move libxlFreeMem to libxl_domain

2014-03-13 Thread Jim Fehlig
Move libxlFreeMem from libxl_driver to libxl_domain for use by other libxl modules. For consistency, rename to libxlDomainFreeMem. Signed-off-by: Jim Fehlig --- src/libxl/libxl_domain.c | 39 +++ src/libxl/libxl_domain.h | 4 src/libxl/libxl_driver.c |

[libvirt] [PATCH V2 07/13] libxl: move libxlDoNodeGetInfo to libxl_conf

2014-03-13 Thread Jim Fehlig
Move libxlDoNodeGetInfo from libxl_driver to libxl_conf for use by other libxl modules. For consistency, rename to libxlDriverNodeGetInfo. Signed-off-by: Jim Fehlig --- src/libxl/libxl_conf.c | 36 src/libxl/libxl_conf.h | 4 src/libxl/libxl_driver

[libvirt] [PATCH V2 03/13] libxl: move libxlSaveImageOpen to libxl_domain

2014-03-13 Thread Jim Fehlig
Move libxlSaveImageOpen from libxl_driver to libxl_domain for use by other libxl modules. For consistency, rename to libxlDomainSaveImageOpen. Signed-off-by: Jim Fehlig --- src/libxl/libxl_domain.c | 76 + src/libxl/libxl_domain.h | 8 + src/libx

[libvirt] [PATCH V2 02/13] libxl: move libxlDomainManagedSavePath to libxl_domain

2014-03-13 Thread Jim Fehlig
Move libxlDomainManagedSavePath from libxl_driver to libxl_domain for use by other libxl modules. Signed-off-by: Jim Fehlig --- src/libxl/libxl_domain.c | 10 ++ src/libxl/libxl_domain.h | 4 src/libxl/libxl_driver.c | 10 -- 3 files changed, 14 insertions(+), 10 deletions(

[libvirt] [PATCH V2 00/13] libxl: add basic support for migration

2014-03-13 Thread Jim Fehlig
V2 of https://www.redhat.com/archives/libvir-list/2014-March/msg00156.html New in this version: not much. I rebased on the hostdev passthrough changes and added a few 'begin phase' checks to fail early if the domain is not migratable. See 13/13 for details. Based on an earlier patch from Chu

Re: [libvirt] [PATCH 1/6] squash this into domain conf XML "eliminate hardcoded indent" patch

2014-03-13 Thread Eric Blake
On 03/12/2014 10:04 PM, Laine Stump wrote: > This should be squashed into the first patch of the previous > "eliminate hardcoded indent" series (which was ACKed but hasn't yet > been pushed): > > https://www.redhat.com/archives/libvir-list/2014-March/msg00361.html > > The initial patch neglecte

Re: [libvirt] [PATCH 2/3] qemu: XMLToNative: Don't open vhostfd

2014-03-13 Thread Laine Stump
On 03/13/2014 01:13 PM, Cole Robinson wrote: > Just skip the vhost command line generation, since this won't work if > attempting to run manually. > --- > src/qemu/qemu_command.c | 15 +-- > 1 file changed, 9 insertions(+), 6 deletions(-) > > diff --git a/src/qemu/qemu_command.c b/src/

Re: [libvirt] [PATCH 1/3] qemu: XMLToNative: Don't show -S

2014-03-13 Thread Laine Stump
On 03/13/2014 01:13 PM, Cole Robinson wrote: > -S causes qemu to start in the paused state. Since XML2Native is intended > to generate something that users can run directly, this will trip them up. > --- > src/qemu/qemu_command.c | 8 ++-- > src/qemu/qemu_command.h | 3 ++- > src/qemu/qemu_d

Re: [libvirt] [PATCH 0/7] POC: Saner firewall integration

2014-03-13 Thread Laine Stump
On 03/12/2014 07:21 AM, Daniel P. Berrange wrote: > We currently have three areas of code which deal with firewall > changes. The bridge driver's iptables usage, the QEMU driver's > ebtables usage for mac filters and the nwfilter code. > > These all directly invoke the iptables/ebtables commands or

[libvirt] [PATCH 3/3] qemu: XMLToNative: Parse XML as INACTIVE

2014-03-13 Thread Cole Robinson
Right now we are parsing the XML as though it's live, which for example will choke on hardcoded XML like: Erroring with: $ sudo virsh domxml-to-native qemu-argv f error: XML error: security label is missing --- src/qemu/qemu_driver.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-

[libvirt] [PATCH 1/3] qemu: XMLToNative: Don't show -S

2014-03-13 Thread Cole Robinson
-S causes qemu to start in the paused state. Since XML2Native is intended to generate something that users can run directly, this will trip them up. --- src/qemu/qemu_command.c | 8 ++-- src/qemu/qemu_command.h | 3 ++- src/qemu/qemu_driver.c | 6 -- src/qemu/qemu_process.c | 2 +- te

[libvirt] [PATCH 2/3] qemu: XMLToNative: Don't open vhostfd

2014-03-13 Thread Cole Robinson
Just skip the vhost command line generation, since this won't work if attempting to run manually. --- src/qemu/qemu_command.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 755a72a..bf7fb12 100644 --- a/sr

Re: [libvirt] [PATCH] nwfilter: Add ARP src/dst IP mask for ebtables ARP

2014-03-13 Thread Laine Stump
On 03/12/2014 05:10 AM, Stefan Berger wrote: > From: Stefan Berger > > Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=862887 > > Add a netmask for the source and destination IP address for the > ebtables --arp-ip-src and --arp-ip-dst options. Extend the XML > parser with support for XML att

[libvirt] Zombie process after open libvirt connection

2014-03-13 Thread Carlos Rodrigues
Hello, I have the following Perl test script and when open libvirt connection with qemu+tls i get zombie process. Let me show the output of script for different versions: * connection with qemu+libssh2 or test:/// $ perl test-chldhandle-bug.pl init... pid=15305 while... fork 1 end... pid=1530

Re: [libvirt] [PATCH] nwfilter: Fix rule priority problem

2014-03-13 Thread Laine Stump
On 03/11/2014 05:47 AM, Stefan Berger wrote: > From: Stefan Berger > > Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1072292 > > Fix a problem related to rule priorities that did not allow to > have rules applied that had a higher priority than the chain they > were in. In this case the ch

Re: [libvirt] RFC: Exposing backing chains in XML

2014-03-13 Thread Eric Blake
On 03/12/2014 05:34 PM, Eric Blake wrote: > > Code-wise, I'm looking at splitting 'struct _virDomainDiskDef' into two > parts. The outermost part is _virDomainDiskDef, which tracks anything > tied to the guest view, or to the device as a whole (, , > ); the inner part is a new _virDomainDiskSrcDe

Re: [libvirt] [PATCH] hostdev: add virObject field to virHostdevManager struct

2014-03-13 Thread Jim Fehlig
Eric Blake wrote: > On 03/12/2014 05:26 PM, Jim Fehlig wrote: > >> Commit 6b306d66 converted virHostdevManager to a virObject, but >> missed adding a virObject field to the virHostdevManager struct. >> Result is memory corruption when taking a reference on an instance >> of the object, where ato

Re: [libvirt] How to build libvirt installation environment on ARM64?

2014-03-13 Thread Daniel P. Berrange
On Thu, Mar 13, 2014 at 12:45:11PM +, Chenqun (kuhn) wrote: > Hi Daniel > > > > I think this only one error is found. The libvirt depends on a lot of > > > other > > > libs,it will be find more similar errors. So, how to create a friendly > > > environment to compile and install libvirt on AR

Re: [libvirt] How to build libvirt installation environment on ARM64?

2014-03-13 Thread Chenqun (kuhn)
Hi Daniel > > I think this only one error is found. The libvirt depends on a lot of other > > libs,it will be find more similar errors. So, how to create a friendly > > environment to compile and install libvirt on ARM64 ? > > Using the sample filesystems from Linaro isn't really going to be a vi

Re: [libvirt] [PATCH 0/4] Fix capitalization of abbreviations

2014-03-13 Thread Eric Blake
On 03/13/2014 06:03 AM, Daniel P. Berrange wrote: > Complete the cleanup of bogus capitalization of Pci/Scsi/Usb > > Daniel P. Berrange (4): > Replace Scsi with SCSI throughout > Replace Usb with USB throughout > Replace Pci with PCI throughout > Add syntax check to validate capitalizatio

[libvirt] [PATCH 3/4] Replace Pci with PCI throughout

2014-03-13 Thread Daniel P. Berrange
Since it is an abbreviation, PCI should always be fully capitalized or full lower case, never Pci. Signed-off-by: Daniel P. Berrange --- src/conf/device_conf.c | 4 ++-- src/conf/device_conf.h | 6 +++--- src/conf/domain_conf.c | 22 +++--- src/conf/domain_con

[libvirt] [PATCH 2/4] Replace Usb with USB throughout

2014-03-13 Thread Daniel P. Berrange
Since it is an abbreviation, USB should always be fully capitalized or full lower case, never Usb. Signed-off-by: Daniel P. Berrange --- src/conf/domain_conf.c | 40 src/conf/domain_conf.h | 8 src/conf/node_device_conf.c | 8 -

[libvirt] [PATCH 0/4] Fix capitalization of abbreviations

2014-03-13 Thread Daniel P. Berrange
Complete the cleanup of bogus capitalization of Pci/Scsi/Usb Daniel P. Berrange (4): Replace Scsi with SCSI throughout Replace Usb with USB throughout Replace Pci with PCI throughout Add syntax check to validate capitalization of abbreviations cfg.mk | 8 +++

[libvirt] [PATCH 1/4] Replace Scsi with SCSI throughout

2014-03-13 Thread Daniel P. Berrange
Since it is an abbreviation, SCSI should always be fully capitalized or full lower case, never Scsi. Signed-off-by: Daniel P. Berrange --- src/conf/domain_conf.c | 8 src/conf/domain_conf.h | 2 +- src/conf/node_device_conf.c| 12 ++-- src/conf/

[libvirt] [PATCH 4/4] Add syntax check to validate capitalization of abbreviations

2014-03-13 Thread Daniel P. Berrange
Use a syntax-check rule to force PCI, USB and SCSI instead of Pci, Usb and Scsi. Signed-off-by: Daniel P. Berrange --- cfg.mk | 8 1 file changed, 8 insertions(+) diff --git a/cfg.mk b/cfg.mk index 9ad8cf7..f61ccfc 100644 --- a/cfg.mk +++ b/cfg.mk @@ -887,6 +887,11 @@ sc_prohibit_wrong

Re: [libvirt] [PATCH v3] Add helper program to create custom leases

2014-03-13 Thread Daniel P. Berrange
On Thu, Mar 13, 2014 at 04:45:35PM +0530, Nehal J Wani wrote: > >> +/** > >> + * VIR_NETWORK_DHCP_LEASE_FILE_SIZE_MAX: > >> + * > >> + * Macro providing the upper limit on the size of leases file > >> + */ > >> +#define VIR_NETWORK_DHCP_LEASE_FILE_SIZE_MAX (2 * 1024 * 1024) > > > > Do you think thi

Re: [libvirt] [PATCH v3] Add helper program to create custom leases

2014-03-13 Thread Nehal J Wani
>> +/** >> + * VIR_NETWORK_DHCP_LEASE_FILE_SIZE_MAX: >> + * >> + * Macro providing the upper limit on the size of leases file >> + */ >> +#define VIR_NETWORK_DHCP_LEASE_FILE_SIZE_MAX (2 * 1024 * 1024) > > Do you think this is large enough ? Lets imagine a case of > 65,000 leases - will they all fit

Re: [libvirt] [PATCH v2 3/5] qemu: Track domain quiesced status

2014-03-13 Thread Daniel P. Berrange
On Wed, Mar 05, 2014 at 02:53:10PM -0500, Tomoki Sekiyama wrote: > Adds an quiesced flag into qemuDomainObjPrivate that tracks whether guest > filesystems of the domain is quiesced of not. > It also modify error code from qemuDomainSnapshotFSFreeze and > qemuDomainSnapshotFSThaw, so that a caller c

Re: [libvirt] [PATCH v2 2/5] remote: Implement virDomainFSFreeze and virDomainFSThaw

2014-03-13 Thread Daniel P. Berrange
On Wed, Mar 05, 2014 at 02:53:03PM -0500, Tomoki Sekiyama wrote: > New rules are added in fixup_name in gendispatch.pl to keep the name > FSFreeze and FSThaw. > > Signed-off-by: Tomoki Sekiyama > --- > src/remote/remote_driver.c |2 ++ > src/remote/remote_protocol.x | 23

Re: [libvirt] [PATCH v2 1/5] Introduce virDomainFSFreeze() and virDomainFSThaw() public API

2014-03-13 Thread Daniel P. Berrange
On Thu, Mar 06, 2014 at 11:09:09AM -0500, Tomoki Sekiyama wrote: > These will freeze and thaw filesystems within guest. The APIs take flags > arguments which are currently not used, for future extensions. > > Signed-off-by: Tomoki Sekiyama > --- > include/libvirt/libvirt.h.in |6 > src/

Re: [libvirt] [PATCH v3] Add helper program to create custom leases

2014-03-13 Thread Daniel P. Berrange
On Mon, Feb 24, 2014 at 05:27:14PM +0530, Nehal J Wani wrote: > Introduce helper program to catch events from dnsmasq and maintain a custom > lease file per network. It supports dhcpv4 and dhcpv6. The file is saved as > ".status". > > Each lease contains the following info: > > > Example of

Re: [libvirt] [PATCH] hotplug:Fix log mistake in qemuMonitorAddNetdev

2014-03-13 Thread Martin Kletzander
On Thu, Mar 13, 2014 at 09:26:16AM +, Wangrui (K) wrote: > >From 81de0ce710bad91a2df18247e681b5a83872b8d5 Mon Sep 17 00:00:00 2001 > From: Wang Rui > Date: Thu, 13 Mar 2014 17:05:03 + > Subject: [PATCH] hotplug:Fix log mistake in qemuMonitorAddNetdev > > VIR_DEBUG in qemuMonitorAddNetdev

Re: [libvirt] [PATCH] Make ABI stability issue easier to debug

2014-03-13 Thread Jiri Denemark
On Wed, Mar 12, 2014 at 10:05:56 -0600, Eric Blake wrote: > On 03/12/2014 09:52 AM, Jiri Denemark wrote: > > When ABI stability check fails, we only log the error message describing > > the incompatibility. Let's log both XMLs in case of an error to make it > > easier to analyze where and why the s

Re: [libvirt] [PATCH 5/7] Add virCommandSetMockOutputFile

2014-03-13 Thread Daniel P. Berrange
On Wed, Mar 12, 2014 at 04:33:22PM +0100, Ján Tomko wrote: > On 03/12/2014 03:26 PM, Daniel P. Berrange wrote: > > On Wed, Mar 12, 2014 at 02:08:15PM +0100, Ján Tomko wrote: > >> > After this file is set, all commands executed will be replaced by > >> > cat . > > I think this is a bit too special c

Re: [libvirt] [PATCH] qemu: Forbid "sgio" support for SCSI generic host device

2014-03-13 Thread Osier Yang
On 13/03/14 15:50, Jiri Denemark wrote: On Wed, Mar 12, 2014 at 23:13:24 +0800, Osier Yang wrote: On 12/03/14 21:54, Jiri Denemark wrote: On Fri, Mar 07, 2014 at 22:23:26 +0800, Osier Yang wrote: The kernel didn't support the unprivileged SGIO for SCSI generic device finally, and since it's un

Re: [libvirt] How to build libvirt installation environment on ARM64?

2014-03-13 Thread Daniel P. Berrange
On Thu, Mar 13, 2014 at 09:16:55AM +, Chenqun (kuhn) wrote: > Hi all, > > The libvirt can be used for ARM64? If it can be used for ARM64, what > resources are needed for setup ? > How to build libvirt installation environment on ARM64? > > I got some resource as follow: > 3.ARM64 f

Re: [libvirt] [PATCH v5 1/3] add new virDomainCoreDumpWithFormat API

2014-03-13 Thread Martin Kletzander
On Thu, Mar 13, 2014 at 09:20:09AM +, qiaonuo...@cn.fujitsu.com wrote: > On 03/12/2014 11:04 PM, Martin Kletzander wrote: > > diff --git c/src/test/test_driver.c i/src/test/test_driver.c > > index 39b3066..20f7bb3 100644 > > --- c/src/test/test_driver.c > > +++ i/src/test/test_driver.c > > @@ -

Re: [libvirt] [PATCH v5 3/3] allow "virsh dump --memory-only" specify dump format

2014-03-13 Thread Martin Kletzander
On Thu, Mar 13, 2014 at 09:22:30AM +, qiaonuo...@cn.fujitsu.com wrote: > On 03/13/2014 03:40 PM, Martin Kletzander wrote: > > On Wed, Mar 12, 2014 at 05:18:22PM +, Daniel P. Berrange wrote: > >> > On Thu, Mar 06, 2014 at 09:35:47AM +,qiaonuo...@cn.fujitsu.com > >> > wrote: > >>> > >

Re: [libvirt] [PATCH v5 1/3] add new virDomainCoreDumpWithFormat API

2014-03-13 Thread qiaonuo...@cn.fujitsu.com
On 03/13/2014 03:42 PM, Martin Kletzander wrote: > On Wed, Mar 12, 2014 at 09:29:55AM -0600, Eric Blake wrote: >> On 03/12/2014 09:04 AM, Martin Kletzander wrote: >>> On Thu, Mar 06, 2014 at 09:35:47AM +, qiaonuo...@cn.fujitsu.com wrote: --memory-only option is introduced without compressi

[libvirt] [PATCH] hotplug:Fix log mistake in qemuMonitorAddNetdev

2014-03-13 Thread Wangrui (K)
>From 81de0ce710bad91a2df18247e681b5a83872b8d5 Mon Sep 17 00:00:00 2001 From: Wang Rui Date: Thu, 13 Mar 2014 17:05:03 + Subject: [PATCH] hotplug:Fix log mistake in qemuMonitorAddNetdev VIR_DEBUG in qemuMonitorAddNetdev should print vhostfdSize Signed-off-by: Wang Rui --- src/qemu/qemu_mo

Re: [libvirt] [PATCH v5 3/3] allow "virsh dump --memory-only" specify dump format

2014-03-13 Thread qiaonuo...@cn.fujitsu.com
On 03/13/2014 03:40 PM, Martin Kletzander wrote: > On Wed, Mar 12, 2014 at 05:18:22PM +, Daniel P. Berrange wrote: >> > On Thu, Mar 06, 2014 at 09:35:47AM +,qiaonuo...@cn.fujitsu.com wrote: >>> > > This patch is used to add "--compress" and >>> > "[--compression-format]" to >>> > > "

Re: [libvirt] [PATCH v5 1/3] add new virDomainCoreDumpWithFormat API

2014-03-13 Thread qiaonuo...@cn.fujitsu.com
On 03/12/2014 11:04 PM, Martin Kletzander wrote: > diff --git c/src/test/test_driver.c i/src/test/test_driver.c > index 39b3066..20f7bb3 100644 > --- c/src/test/test_driver.c > +++ i/src/test/test_driver.c > @@ -2436,6 +2436,13 @@ static int testDomainCoreDumpWithFormat(virDomainPtr > domain, > >

[libvirt] How to build libvirt installation environment on ARM64?

2014-03-13 Thread Chenqun (kuhn)
Hi all, The libvirt can be used for ARM64? If it can be used for ARM64, what resources are needed for setup ? How to build libvirt installation environment on ARM64? I got some resource as follow: 1.ARM64 hardware is based Cortex-A57 fastmodel 2.Host and Guest kernel is linux 3.13.0 3.A

[libvirt] [PATCH v1 1/2] security_dac: Keep original file label

2014-03-13 Thread Michal Privoznik
In the DAC security driver chown() is executed in order to allow a domain accessing certain files. Later, when the domain is shutting down, we are chown()-ing the file back. But we don't remember the original owner anywhere, so we return the file to root:root and hope for the best. In this approac

[libvirt] [PATCH v1 2/2] security_dac: Lock label store file

2014-03-13 Thread Michal Privoznik
If there are two or more libvirtds fighting over the label store file a data corruption is likely to occur. Therefore we need to enforce an exclusive access to the file. With a little help from virtlockd we can achieve that. Signed-off-by: Michal Privoznik --- src/Makefile.am |

[libvirt] [PATCH v1 0/2] Keep original file label

2014-03-13 Thread Michal Privoznik
This creates a new file to store the original file labels. Or do we want the whole functionality to reside in virtlockd? Michal Privoznik (2): security_dac: Keep original file label security_dac: Lock label store file src/Makefile.am | 3 +- src/locking/lock_driver.h

Re: [libvirt] [PATCH] qemu: Forbid "sgio" support for SCSI generic host device

2014-03-13 Thread Jiri Denemark
On Wed, Mar 12, 2014 at 23:13:24 +0800, Osier Yang wrote: > On 12/03/14 21:54, Jiri Denemark wrote: > > On Fri, Mar 07, 2014 at 22:23:26 +0800, Osier Yang wrote: > >> The kernel didn't support the unprivileged SGIO for SCSI generic > >> device finally, and since it's unknow whether the way to suppo

Re: [libvirt] [PATCH v5 1/3] add new virDomainCoreDumpWithFormat API

2014-03-13 Thread Martin Kletzander
On Wed, Mar 12, 2014 at 09:29:55AM -0600, Eric Blake wrote: > On 03/12/2014 09:04 AM, Martin Kletzander wrote: > > On Thu, Mar 06, 2014 at 09:35:47AM +, qiaonuo...@cn.fujitsu.com wrote: > >> --memory-only option is introduced without compression supported. > >> Therefore, > >> this is a freatu

Re: [libvirt] [PATCH v5 3/3] allow "virsh dump --memory-only" specify dump format

2014-03-13 Thread Martin Kletzander
On Wed, Mar 12, 2014 at 05:18:22PM +, Daniel P. Berrange wrote: > On Thu, Mar 06, 2014 at 09:35:47AM +, qiaonuo...@cn.fujitsu.com wrote: > > This patch is used to add "--compress" and "[--compression-format] > > " to > > "virsh dump --memory-only". And "virsh dump --memory-only" is going b

Re: [libvirt] [PATCH] docs: add VMmanager to web apps

2014-03-13 Thread Martin Kletzander
On Wed, Mar 12, 2014 at 06:57:30AM -0600, Eric Blake wrote: > On 03/12/2014 01:30 AM, Martin Kletzander wrote: > > This is a request for adding a VMmanager application as requested and > > described by Ksenya Phil. > > > > Signed-off-by: Ksenya Phil > > Signed-off-by: Martin Kletzander > > --- >